[PATCH 2/5] migration: HMP side changes for modified 'migrate' QAPI design

2022-12-25 Thread Het Gala
From: Author Het Gala hmp_migrate() accepts uri (backward compatibility) and a well-defined struct for migration parameters, and with help of migrate_channel_from_qdict() maps QDict's 'key':'value' pair required for migration stream into MigrateChannel struct. Suggested-by: Daniel P. Berrange S

[PATCH 0/5] migration: Modified 'migrate' QAPI command for migration

2022-12-25 Thread Het Gala
Current QAPI 'migrate' command design (for initiating a migration stream) contains information regarding different migrate transport mechanism (tcp / unix / exec), dest-host IP address, and binding port number in form of a string. Thus the design does seem to have some design issues. Some of the is

[PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2022-12-25 Thread Het Gala
From: Author Het Gala Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri' parameter. This scheme does seem to have an issue in it, i.e. double-level encoding of URIs. The current patc

[PATCH 4/5] migration: Modified 'migrate-incoming' QAPI and HMP side changes on the destination interface.

2022-12-25 Thread Het Gala
From: Author Het Gala 'migrate-incoming' QAPI design have been modified into a well-defined struct 'MigrateChannel'. Similarly like the source side, modified design was introduced on destination side mainly to prevent multiple-level encoding of uri string. The struct contains various fields for

[PATCH 3/5] migration: Avoid multiple parsing of uri in migration code flow

2022-12-25 Thread Het Gala
From: Author Het Gala Existing uri is encoded at multiple levels to extract the relevant migration information. The modified QAPI design maps migration parameters into MigrateChannel struct before, thus avoiding double-level uri encoding. socket_outgoing_migration() has been depricated as It's

[PATCH 5/5] migration: Established connection for listener sockets on the dest interface

2022-12-25 Thread Het Gala
From: Author Het Gala Modified 'migrate-incoming' QAPI supports MigrateChannel parameters to prevent multi-level encodings of uri on the destination side. socket_start_incoming_migration() has been depricated as it's only purpose was uri parsing. Renamed socket_outgoing_migration_internal() as

Re: [PATCH v3] intel-iommu: Document iova_tree

2022-12-25 Thread Jason Wang
On Sat, Dec 24, 2022 at 12:26 AM Peter Xu wrote: > > On Fri, Dec 23, 2022 at 03:48:01PM +0800, Jason Wang wrote: > > On Wed, Dec 7, 2022 at 6:13 AM Peter Xu wrote: > > > > > > It seems not super clear on when iova_tree is used, and why. Add a rich > > > comment above iova_tree to track why we ne

Re: [PATCH] hw/audio/c97: fix abort in audio_calloc()

2022-12-25 Thread Bernhard Beschow
Am 25. Dezember 2022 12:13:57 UTC schrieb Qiang Liu : There is an 'a' missing in the topic: It should be ac97, not c97. Best regards, Bernhard >Section 5.10.2 of the AC97 specification (https://hands.com/~lkcl/ac97_r23.pdf) >shows the feasibility to support for rates other than 48kHZ. Specifi

Re: [PATCH] hw/audio/c97: fix abort in audio_calloc()

2022-12-25 Thread Bernhard Beschow
Am 25. Dezember 2022 12:13:57 UTC schrieb Qiang Liu : >Section 5.10.2 of the AC97 specification (https://hands.com/~lkcl/ac97_r23.pdf) >shows the feasibility to support for rates other than 48kHZ. Specifically, >AC97_PCM_Front_DAC_Rate (reg 2Ch) should be from 8kHZ to 48kHZ. > >Before Volker Rüm

Re: [PATCH] hw/audio/c97: fix abort in audio_calloc()

2022-12-25 Thread Christian Schoenebeck
On Sunday, December 25, 2022 1:13:57 PM CET Qiang Liu wrote: > Section 5.10.2 of the AC97 specification > (https://hands.com/~lkcl/ac97_r23.pdf) > shows the feasibility to support for rates other than 48kHZ. Specifically, > AC97_PCM_Front_DAC_Rate (reg 2Ch) should be from 8kHZ to 48kHZ. > > Befor

[PATCH] hw/audio/c97: fix abort in audio_calloc()

2022-12-25 Thread Qiang Liu
Section 5.10.2 of the AC97 specification (https://hands.com/~lkcl/ac97_r23.pdf) shows the feasibility to support for rates other than 48kHZ. Specifically, AC97_PCM_Front_DAC_Rate (reg 2Ch) should be from 8kHZ to 48kHZ. Before Volker Rümelin fixed it in 12f4abf6a245 and 0cbc8bd4694f, an adversary c

Re: [PATCH] m25p80: Add the is25wp256 SFPD table

2022-12-25 Thread Ben Dooks
On Wed, Dec 21, 2022 at 06:36:02PM +0100, Cédric Le Goater wrote: > On 12/21/22 13:22, Guenter Roeck wrote: > > Generated from hardware using the following command and then padding > > with 0xff to fill out a power-of-2: > > xxd -p /sys/bus/spi/devices/spi0.0/spi-nor/sfdp > > > > Cc: Michael W

[PATCH] e1000e: Introduce e1000_rx_desc_union

2022-12-25 Thread Akihiko Odaki
Before this change, e1000e_write_packet_to_guest() allocated the receive descriptor buffer as an array of uint8_t. This does not ensure the buffer is sufficiently aligned. Introduce e1000_rx_desc_union type, a union type of all receive descriptor types to correct this. Signed-off-by: Akihiko Odak

[PATCH v3] linux-user: Fix brk() to release pages

2022-12-25 Thread Helge Deller
The current brk() implementation does not de-allocate pages if a lower address is given compared to earlier brk() calls. But according to the manpage, brk() shall deallocate memory in this case and currently it breaks a real-world application, specifically building the debian gcl package in qemu-us