Re: [PATCH v8 01/13] linux-headers: Update to v6.2-rc1

2023-01-16 Thread Cédric Le Goater
On 1/16/23 15:11, Avihai Horon wrote: Update to commit 1b929c02afd3 ("Linux 6.2-rc1"). Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater Thanks, C. --- include/standard-headers/drm/drm_fourcc.h | 63 +++- include/standard-headers/linux/ethtool.h | 81 -

[RFC] 2-stage translation emulation support for SMMUv3 on TCG

2023-01-16 Thread Evgeny Iakovlev
Hi! We are using qemu-tcg-aarch64 to run Hyper-V test and debug builds for arm. Besides some minor fixes that i have submitted over the last couple of weeks, one big compatibility item for us is SMMUv3 2-stage translations support. We can do fine without it right now, but having it would

Re: [PATCH v8] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-16 Thread Igor Mammedov
On Fri, 13 Jan 2023 16:31:26 -0500 Chuck Zmudzinski wrote: > On 1/13/23 4:33 AM, Igor Mammedov wrote: > > On Thu, 12 Jan 2023 23:14:26 -0500 > > Chuck Zmudzinski wrote: > > > >> On 1/12/23 6:03 PM, Michael S. Tsirkin wrote: > >> > On Thu, Jan 12, 2023 at 10:55:25PM +, Bernhard Beschow

[PATCH v3 6/7] hw/isa/isa-bus: Turn isa_build_aml() into qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Frees isa-bus.c from implicit ACPI dependency. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/acpi/acpi_aml_interface.h | 3 +++ include/hw/isa/isa.h | 1 - hw/acpi/acpi_interface.c | 10 ++ hw/i386/acpi-microvm.c

[PATCH v3 4/7] hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"

2023-01-16 Thread Bernhard Beschow
hw/acpi/piix4 has its own header with its structure definition etc. Ammends commit 2bfd0845f0 'hw/acpi/piix4: move PIIX4PMState into separate piix4.h header'. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/piix4.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v3 1/7] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu

2023-01-16 Thread Bernhard Beschow
The only function ever assigned to AcpiDeviceIfClass::madt_cpu is pc_madt_cpu_entry() which doesn't use the AcpiDeviceIf parameter. Signed-off-by: Bernhard Beschow --- include/hw/acpi/acpi_dev_interface.h | 3 +-- include/hw/i386/pc.h | 6 ++ hw/acpi/acpi-x86-stub.c

[PATCH v3 7/7] piix3, ich9: Reuse qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i2c/smbus_ich9.c | 5 + hw/isa/lpc_ich9.c | 5 + hw/isa/piix3.c | 5 + 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/hw/i2c/smbus_ich9.c b/hw/i2c/smbus_ich9.c index

[PATCH v3 3/7] hw/acpi/acpi_dev_interface: Remove now unused #include "hw/boards.h"

2023-01-16 Thread Bernhard Beschow
Removing the "hw/boards.h" include from hw/acpi/acpi_dev_interface.h requires include fixes in various unrelated files to keep the code compiling. Signed-off-by: Bernhard Beschow --- hw/acpi/hmat.h | 3 ++- include/hw/acpi/acpi_dev_interface.h | 1 - hw/acpi/cpu.c

[PATCH v3 5/7] hw/i386/acpi-build: Remove unused attributes

2023-01-16 Thread Bernhard Beschow
Ammends commit 3db119da7915 'pc: acpi: switch to AML API composed DSDT'. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0be3960a37..428328dc2d

[PATCH v3 0/7] AML Housekeeping

2023-01-16 Thread Bernhard Beschow
This series resolves the AcpiDeviceIfClass::madt_cpu function pointer. It turns out that it isn't needed and it even frees the ACPI controllers from assigning it an x86 specific function. This is especially interesting for the PIIX4 PM which is also used in MIPS only contexts. Furthermore, the

[PATCH v3 2/7] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu

2023-01-16 Thread Bernhard Beschow
This class attribute was always set to pc_madt_cpu_entry(). pc_madt_cpu_entry() is architecture dependent and was assigned to the attribute even in architecture agnostic code such as in hw/acpi/piix4.c and hw/isa/lpc_ich9. Not having to set madt_cpu there resolves the assumption that these device

Re: [PATCH v8 04/13] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support

2023-01-16 Thread Cédric Le Goater
On 1/16/23 15:11, Avihai Horon wrote: Currently, if IOMMU of a VFIO container doesn't support dirty page tracking, migration is blocked. This is because a DMA-able VFIO device can dirty RAM pages without updating QEMU about it, thus breaking the migration. However, this doesn't mean that

Re: [RFC v2 11/13] vdpa: add vdpa net migration state notifier

2023-01-16 Thread Eugenio Perez Martin
On Mon, Jan 16, 2023 at 7:51 AM Jason Wang wrote: > > > 在 2023/1/13 17:00, Eugenio Perez Martin 写道: > > On Fri, Jan 13, 2023 at 5:55 AM Jason Wang wrote: > >> On Fri, Jan 13, 2023 at 1:25 AM Eugenio Pérez wrote: > >>> This allows net to restart the device backend to configure SVQ on it. > >>> >

Re: [PATCH 3/3] target/arm: allow writes to SCR_EL3.HXEn bit when FEAT_HCX is enabled

2023-01-16 Thread Evgeny Iakovlev
On 1/13/2023 14:20, Peter Maydell wrote: On Thu, 5 Jan 2023 at 22:13, Evgeny Iakovlev wrote: ARM trusted firmware, when built with FEAT_HCX support, sets SCR_EL3.HXEn bit to allow EL2 to modify HCRX_EL2 register without trapping it in EL3. Qemu uses a valid mask to clear unsupported SCR_EL3

[PATCH 1/1] vhost-user: Skip unnecessary duplicated VHOST_USER_ADD/REM_MEM_REG requests

2023-01-16 Thread Minghao Yuan
The VHOST_USER_ADD/REM_MEM_REG requests should be categorized into non-vring specific messages, and should be sent only once. Signed-off-by: Minghao Yuan --- hw/virtio/vhost-user.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index

[PATCH 1/1] vhost-user: Skip unnecessary duplicated VHOST_USER_ADD/REM_MEM_REG requests

2023-01-16 Thread Minghao Yuan
The VHOST_USER_ADD/REM_MEM_REG requests should be categorized into non-vring specific messages, and should be sent only once. Signed-off-by: Minghao Yuan --- configure | 2 +- hw/virtio/vhost-user.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/configure

Re: [PATCH 4/4] tests/tcg/multiarch: add vma-pthread.c

2023-01-16 Thread Peter Maydell
On Mon, 16 Jan 2023 at 12:40, Philippe Mathieu-Daudé wrote: > > On 13/1/23 18:10, Alex Bennée wrote: > > > > Peter Maydell writes: > > > >> On Sat, 24 Dec 2022 at 15:19, Richard Henderson > >> wrote: > >>> > >>> From: Ilya Leoshkevich > >>> > >>> Add a test that locklessly changes and

Re: [PULL 00/46] MIPS patches for 2023-01-13

2023-01-16 Thread Peter Maydell
On Fri, 13 Jan 2023 at 20:32, Philippe Mathieu-Daudé wrote: > > On 13/1/23 18:57, Peter Maydell wrote: > > On Fri, 13 Jan 2023 at 16:05, Philippe Mathieu-Daudé > > wrote: > >> > >> The following changes since commit > >> 3db29dcac23da85486704ef9e7a8e7217f7829cd: > >> > >>Merge tag

Re: [PATCH v3 3/8] migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)

2023-01-16 Thread David Hildenbrand
On 16.01.23 15:56, Peter Xu wrote: On Mon, Jan 16, 2023 at 11:35:22AM +0100, David Hildenbrand wrote: What about the following: diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 7bc0cd9de9..cc910cab0f 100644 --- a/include/migration/vmstate.h +++

Re: [PATCH v3 3/8] migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)

2023-01-16 Thread Peter Xu
On Mon, Jan 16, 2023 at 11:35:22AM +0100, David Hildenbrand wrote: > What about the following: > > diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h > index 7bc0cd9de9..cc910cab0f 100644 > --- a/include/migration/vmstate.h > +++ b/include/migration/vmstate.h > @@ -188,6

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Alex Bennée
Marc-André Lureau writes: > Hi > > On Mon, Jan 16, 2023 at 2:08 PM Alex Bennée wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > I'm not sure how but this is re-breaking the windows build you just fixed: > >In

[PING] [PATCH v4] qapi/qmp: Add timestamps to qmp command responses

2023-01-16 Thread Denis Plotnikov
On 10.01.2023 13:32, Denis Plotnikov wrote: [ping] On 01.11.2022 18:37, Denis Plotnikov wrote: Add "start" & "end" time values to QMP command responses. These time values are added to let the qemu management layer get the exact command execution time without any other time variance which

Re: [RFC] cxl-host: Fix committed check for passthrough decoder

2023-01-16 Thread Jonathan Cameron via
On Fri, 13 Jan 2023 17:10:51 + Fan Ni wrote: > On Fri, Jan 13, 2023 at 09:47:25AM +, Jonathan Cameron wrote: > > > On Fri, 13 Jan 2023 00:27:55 + > > Fan Ni wrote: > > > > > For passthrough decoder (a decoder hosted by a cxl component with only > > > one downstream port), its

Re: [PATCH 6/7] hw/i386/acpi-microvm: Reuse qbus_build_aml()

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 15:02, Bernhard Beschow wrote: Am 16. Januar 2023 09:14:28 UTC schrieb "Philippe Mathieu-Daudé" : On 14/1/23 23:27, Bernhard Beschow wrote: Signed-off-by: Bernhard Beschow --- hw/i386/acpi-microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Possibly squash

Re: [PATCH 6/7] hw/i386/acpi-microvm: Reuse qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Am 16. Januar 2023 14:02:55 UTC schrieb Bernhard Beschow : > > >Am 16. Januar 2023 09:14:28 UTC schrieb "Philippe Mathieu-Daudé" >: >>On 14/1/23 23:27, Bernhard Beschow wrote: >>> Signed-off-by: Bernhard Beschow >>> --- >>> hw/i386/acpi-microvm.c | 3 ++- >>> 1 file changed, 2

Re: [PATCH v5 1/2] riscv: Pass Object to register_cpu_props instead of DeviceState

2023-01-16 Thread Frank Chang
Reviewed-by: Frank Chang On Fri, Jan 13, 2023 at 6:35 PM Alexandre Ghiti wrote: > One can extract the DeviceState pointer from the Object pointer, so pass > the Object for future commits to access other fields of Object. > > No functional changes intended. > > Signed-off-by: Alexandre Ghiti >

[PATCH v8 13/13] docs/devel: Align VFIO migration docs to v2 protocol

2023-01-16 Thread Avihai Horon
Now that VFIO migration protocol v2 has been implemented and v1 protocol has been removed, update the documentation according to v2 protocol. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater --- docs/devel/vfio-migration.rst | 68 --- 1 file changed, 30

[PATCH v8 04/13] vfio/migration: Allow migration without VFIO IOMMU dirty tracking support

2023-01-16 Thread Avihai Horon
Currently, if IOMMU of a VFIO container doesn't support dirty page tracking, migration is blocked. This is because a DMA-able VFIO device can dirty RAM pages without updating QEMU about it, thus breaking the migration. However, this doesn't mean that migration can't be done at all. In such case,

[PATCH v8 09/13] vfio/migration: Implement VFIO migration protocol v2

2023-01-16 Thread Avihai Horon
Implement the basic mandatory part of VFIO migration protocol v2. This includes all functionality that is necessary to support VFIO_MIGRATION_STOP_COPY part of the v2 protocol. The two protocols, v1 and v2, will co-exist and in the following patches v1 protocol code will be removed. There are

[PATCH v8 05/13] migration/qemu-file: Add qemu_file_get_to_fd()

2023-01-16 Thread Avihai Horon
Add new function qemu_file_get_to_fd() that allows reading data from QEMUFile and writing it straight into a given fd. This will be used later in VFIO migration code. Signed-off-by: Avihai Horon Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Cédric Le Goater --- migration/qemu-file.h

[PATCH v8 12/13] vfio: Alphabetize migration section of VFIO trace-events file

2023-01-16 Thread Avihai Horon
Sort the migration section of VFIO trace events file alphabetically and move two misplaced traces to common.c section. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater --- hw/vfio/trace-events | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git

[PATCH v8 02/13] migration: No save_live_pending() method uses the QEMUFile parameter

2023-01-16 Thread Avihai Horon
From: Juan Quintela So remove it everywhere. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Dr. David Alan Gilbert --- include/migration/register.h | 3 +-- migration/savevm.h | 3 +-- hw/s390x/s390-stattrib.c | 2 +-

[PATCH v8 11/13] vfio/migration: Remove VFIO migration protocol v1

2023-01-16 Thread Avihai Horon
Now that v2 protocol implementation has been added, remove the deprecated v1 implementation. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 5 - hw/vfio/common.c | 19 +- hw/vfio/migration.c | 703

[PATCH v8 08/13] vfio/migration: Rename functions/structs related to v1 protocol

2023-01-16 Thread Avihai Horon
To avoid name collisions, rename functions and structs related to VFIO migration protocol v1. This will allow the two protocols to co-exist when v2 protocol is added, until v1 is removed. No functional changes intended. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater ---

[PATCH v8 07/13] vfio/migration: Move migration v1 logic to vfio_migration_init()

2023-01-16 Thread Avihai Horon
Move vfio_dev_get_region_info() logic from vfio_migration_probe() to vfio_migration_init(). This logic is specific to v1 protocol and moving it will make it easier to add the v2 protocol implementation later. No functional changes intended. Signed-off-by: Avihai Horon Reviewed-by: Cédric Le

[PATCH v8 10/13] vfio/migration: Optimize vfio_save_pending()

2023-01-16 Thread Avihai Horon
During pre-copy phase of migration vfio_save_pending() is called repeatedly and queries the VFIO device for its pending data size. As long as pending RAM size is over the threshold, migration can't converge and be completed. Therefore, during this time there is no point in querying the VFIO

[PATCH v8 01/13] linux-headers: Update to v6.2-rc1

2023-01-16 Thread Avihai Horon
Update to commit 1b929c02afd3 ("Linux 6.2-rc1"). Signed-off-by: Avihai Horon --- include/standard-headers/drm/drm_fourcc.h | 63 +++- include/standard-headers/linux/ethtool.h | 81 - include/standard-headers/linux/fuse.h | 20 +- .../linux/input-event-codes.h

[PATCH v8 06/13] vfio/common: Change vfio_devices_all_running_and_saving() logic to equivalent one

2023-01-16 Thread Avihai Horon
vfio_devices_all_running_and_saving() is used to check if migration is in pre-copy phase. This is done by checking if migration is in setup or active states and if all VFIO devices are in pre-copy state, i.e. _SAVING | _RUNNING. In VFIO migration protocol v2 pre-copy support is made optional.

[PATCH v8 00/13] vfio/migration: Implement VFIO migration protocol v2

2023-01-16 Thread Avihai Horon
Hello, Following VFIO migration protocol v2 acceptance in kernel, this series implements VFIO migration according to the new v2 protocol and replaces the now deprecated v1 implementation. The main differences between v1 and v2 migration protocols are: 1. VFIO device state is represented as a

[PATCH v8 03/13] vfio/migration: Fix NULL pointer dereference bug

2023-01-16 Thread Avihai Horon
As part of its error flow, vfio_vmstate_change() accesses MigrationState->to_dst_file without any checks. This can cause a NULL pointer dereference if the error flow is taken and MigrationState->to_dst_file is not set. For example, this can happen if VM is started or stopped not during migration

Re: [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build

2023-01-16 Thread Fabiano Rosas
Peter Maydell writes: > On Mon, 16 Jan 2023 at 13:45, Fabiano Rosas wrote: >> >> Richard Henderson writes: >> >> > On 1/13/23 06:04, Fabiano Rosas wrote: >> >> The cortex-a15 is not present anymore when CONFIG_TCG=n, so use the >> >> cortex-a57 as default cpu for KVM. >> >> >> >>

Re: [PATCH 6/7] hw/i386/acpi-microvm: Reuse qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Am 16. Januar 2023 09:14:28 UTC schrieb "Philippe Mathieu-Daudé" : >On 14/1/23 23:27, Bernhard Beschow wrote: >> Signed-off-by: Bernhard Beschow >> --- >> hw/i386/acpi-microvm.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) > >Possibly squash with next patch, regardless: Not

Re: [PATCH] target/arm: Widen cnthctl_el2 to uint64_t

2023-01-16 Thread Peter Maydell
On Sun, 15 Jan 2023 at 17:16, Richard Henderson wrote: > > This is a 64-bit register on AArch64, even if the high 44 bits > are RES0. Because this is defined as ARM_CP_STATE_BOTH, we are > asserting that the cpreg field is 64-bits. > > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1400

Re: [PATCH v2 4/8] hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 13:58, Bernhard Beschow wrote: hw/acpi/piix4 has its own header with its structure definition etc. Signed-off-by: Bernhard Beschow --- hw/acpi/piix4.c | 1 - 1 file changed, 1 deletion(-) Indeed, since 2bfd0845f0 ("hw/acpi/piix4: move PIIX4PMState into separate piix4.h

Re: [PATCH v2] tests/qtest/qom-test: Do not print tested properties by default

2023-01-16 Thread Philippe Mathieu-Daudé
On 15/12/22 16:30, Thomas Huth wrote: We're still running into the problem that some logs are cut in the gitlab-CI since they got too big. The biggest part of the log is still the output of the qom-test. Let's stop printing the properties by default to get to a saner size here. The full output

Re: [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build

2023-01-16 Thread Peter Maydell
On Mon, 16 Jan 2023 at 13:45, Fabiano Rosas wrote: > > Richard Henderson writes: > > > On 1/13/23 06:04, Fabiano Rosas wrote: > >> The cortex-a15 is not present anymore when CONFIG_TCG=n, so use the > >> cortex-a57 as default cpu for KVM. > >> > >> Signed-off-by: Fabiano Rosas > > > > Ideally

Re: [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build

2023-01-16 Thread Peter Maydell
On Fri, 13 Jan 2023 at 22:05, Richard Henderson wrote: > > On 1/13/23 06:04, Fabiano Rosas wrote: > > The cortex-a15 is not present anymore when CONFIG_TCG=n, so use the > > cortex-a57 as default cpu for KVM. > > > > Signed-off-by: Fabiano Rosas > > Ideally there would not be a default at all,

Re: [PATCH v10 0/9] KVM: mm: fd-based approach for supporting KVM

2023-01-16 Thread Kirill A. Shutemov
On Sat, Jan 14, 2023 at 12:37:59AM +, Sean Christopherson wrote: > On Fri, Dec 02, 2022, Chao Peng wrote: > > This patch series implements KVM guest private memory for confidential > > computing scenarios like Intel TDX[1]. If a TDX host accesses > > TDX-protected guest memory, machine check

Re: [RFC PATCH v3 21/28] tests/qtest: Skip tests that depend on TCG when CONFIG_TCG=n

2023-01-16 Thread Fabiano Rosas
Richard Henderson writes: > On 1/13/23 06:04, Fabiano Rosas wrote: >> @@ -373,6 +387,11 @@ static void sve_tests_sve_off(const void *data) >> { >> QTestState *qts; >> >> +if (tcg_disabled()) { >> +g_test_skip("TCG support is disabled in this build"); >> +return; >>

Re: [RFC PATCH v3 20/28] target/arm: Set cortex-a57 as default cpu for KVM-only build

2023-01-16 Thread Fabiano Rosas
Richard Henderson writes: > On 1/13/23 06:04, Fabiano Rosas wrote: >> The cortex-a15 is not present anymore when CONFIG_TCG=n, so use the >> cortex-a57 as default cpu for KVM. >> >> Signed-off-by: Fabiano Rosas > > Ideally there would not be a default at all, requiring the command-line >

Re: [PATCH 1/7] hw/acpi: Add missing includes

2023-01-16 Thread Bernhard Beschow
Am 16. Januar 2023 13:02:23 UTC schrieb Markus Armbruster : >Bernhard Beschow writes: > >> Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster >> : >>>Bernhard Beschow writes: >>> When removing the "hw/boards.h" include from hw/acpi/acpi_dev_interface.h, these include

Re: [PATCH v14 03/11] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-01-16 Thread Nina Schoetterl-Glausch
On Thu, 2023-01-05 at 15:53 +0100, Pierre Morel wrote: > On interception of STSI(15.1.x) the System Information Block > (SYSIB) is built from the list of pre-ordered topology entries. > > Signed-off-by: Pierre Morel > --- > include/hw/s390x/cpu-topology.h | 3 + > include/hw/s390x/sclp.h

Re: [PATCH v7 09/13] vfio/migration: Implement VFIO migration protocol v2

2023-01-16 Thread Avihai Horon
On 16/01/2023 12:55, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello Avihai, On 1/15/23 19:35, Avihai Horon wrote: Implement the basic mandatory part of VFIO migration protocol v2. This includes all functionality that is necessary to support

[PATCH v2 4/8] hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"

2023-01-16 Thread Bernhard Beschow
hw/acpi/piix4 has its own header with its structure definition etc. Signed-off-by: Bernhard Beschow --- hw/acpi/piix4.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index 4d0d4fdeeb..2e19a55526 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/piix4.c @@ -20,7

Re: [PATCH 1/7] hw/acpi: Add missing includes

2023-01-16 Thread Markus Armbruster
Bernhard Beschow writes: > Am 16. Januar 2023 06:46:36 UTC schrieb Markus Armbruster : >>Bernhard Beschow writes: >> >>> When removing the "hw/boards.h" include from >>> hw/acpi/acpi_dev_interface.h, these include directives must be added to make >>> the code compile again. >>> >>>

[PATCH v2 7/8] hw/i386/acpi-microvm: Reuse qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-microvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/i386/acpi-microvm.c b/hw/i386/acpi-microvm.c index d8a444d06c..fec22d85c1 100644 --- a/hw/i386/acpi-microvm.c +++

[PATCH v2 2/8] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu

2023-01-16 Thread Bernhard Beschow
The only function ever assigned to AcpiDeviceIfClass::madt_cpu is pc_madt_cpu_entry() which doesn't use the AcpiDeviceIf parameter. Signed-off-by: Bernhard Beschow --- include/hw/acpi/acpi_dev_interface.h | 3 +-- include/hw/i386/pc.h | 6 ++ hw/acpi/acpi-x86-stub.c

[PATCH v2 8/8] hw/isa/isa-bus: Remove now unused isa_build_aml()

2023-01-16 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/isa/isa.h | 1 - hw/isa/isa-bus.c | 10 -- 2 files changed, 11 deletions(-) diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 6c8a8a92cb..25acd5c34c 100644 --- a/include/hw/isa/isa.h

[PATCH v2 1/8] hw/acpi: Add missing includes

2023-01-16 Thread Bernhard Beschow
When removing the "hw/boards.h" include in hw/acpi/acpi_dev_interface.h, these include directives must be added to make the code compile again. Signed-off-by: Bernhard Beschow --- hw/acpi/hmat.h | 3 ++- hw/acpi/cpu.c| 2 ++ hw/acpi/hmat.c | 1 +

[PATCH v2 5/8] hw/i386/acpi-build: Remove unused attributes

2023-01-16 Thread Bernhard Beschow
Ammends commit 3db119da7915 'pc: acpi: switch to AML API composed DSDT'. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/i386/acpi-build.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0be3960a37..428328dc2d

[PATCH v2 3/8] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu

2023-01-16 Thread Bernhard Beschow
This class attribute was always set to pc_madt_cpu_entry(). pc_madt_cpu_entry() is architecture dependent and was assigned to the attribute even in architecture agnostic code such as in hw/acpi/piix4.c and hw/isa/lpc_ich9. Not having to set madt_cpu there resolves the assumption that these device

[PATCH v2 6/8] hw/acpi/acpi_aml_interface: Extract qbus_build_aml()

2023-01-16 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- include/hw/acpi/acpi_aml_interface.h | 3 +++ hw/acpi/acpi_interface.c | 10 ++ hw/i2c/smbus_ich9.c | 5 + hw/isa/lpc_ich9.c| 5 + hw/isa/piix3.c

[PATCH v2 0/8] AML Housekeeping

2023-01-16 Thread Bernhard Beschow
This series resolves the AcpiDeviceIfClass::madt_cpu function pointer. It turns out that it isn't needed and it even frees the ACPI controllers from assigning it an x86 specific function. This is especially interesting for the PIIX4 PM which is also used in MIPS only contexts. Furthermore, the

[RFC] virtio-iommu: Take into account possible aliasing in virtio_iommu_mr()

2023-01-16 Thread Eric Auger
When devices are plugged downstream to a pcie to pci bridge, the virtio-iommu driver stills sends virtio-iommu commands using the rid without aliasing (ie. devfn != 0). However only an IOMMU MR matching :00.0 was registered so virtio_iommu_mr fails to identify the memory region matching the ep_id.

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-16 Thread Daniel Henrique Barboza
On 1/16/23 09:37, Philippe Mathieu-Daudé wrote: On 16/1/23 13:29, Daniel Henrique Barboza wrote: Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' stopped working. The reason seems to be that Xvisor is

Re: [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 49 + 1 file changed, 49 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c929c61d582a..4ac8ff11a835 100644 --- a/hw/arm/aspeed.c

Re: [PATCH 4/4] tests/tcg/multiarch: add vma-pthread.c

2023-01-16 Thread Philippe Mathieu-Daudé
On 13/1/23 18:10, Alex Bennée wrote: Peter Maydell writes: On Sat, 24 Dec 2022 at 15:19, Richard Henderson wrote: From: Ilya Leoshkevich Add a test that locklessly changes and exercises page protection bits from various threads. This helps catch race conditions in the VMA handling.

Re: [PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-16 Thread Philippe Mathieu-Daudé
On 16/1/23 13:29, Daniel Henrique Barboza wrote: Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' stopped working. The reason seems to be that Xvisor is using 64 bit to encode the 32 bit addresses from the

Re: [PATCH 6/6] hw/arm/aspeed: Init fby35 BMC FRUID EEPROM

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 49 + 1 file changed, 49 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c929c61d582a..4ac8ff11a835 100644 --- a/hw/arm/aspeed.c

[PATCH v8 1/3] hw/riscv/boot.c: consolidate all kernel init in riscv_load_kernel()

2023-01-16 Thread Daniel Henrique Barboza
The microchip_icicle_kit, sifive_u, spike and virt boards are now doing the same steps when '-kernel' is used: - execute load_kernel() - load init_rd() - write kernel_cmdline Let's fold everything inside riscv_load_kernel() to avoid code repetition. To not change the behavior of boards that

[PATCH v8 0/3] hw/riscv: clear kernel_entry high bits with 32bit CPUs

2023-01-16 Thread Daniel Henrique Barboza
Hi, This version has changes in patch 3 where we're now using extract64() instead of a plain bit mask to return the 32 bit address in translate_fn(). Changes from v7: - patch 2: - added Alistair's r-b - patch 3: - use extract64() to return the 32 bit address v7 link:

[PATCH v8 3/3] hw/riscv: clear kernel_entry higher bits in load_elf_ram_sym()

2023-01-16 Thread Daniel Henrique Barboza
Recent hw/risc/boot.c changes caused a regression in an use case with the Xvisor hypervisor. Running a 32 bit QEMU guest with '-kernel' stopped working. The reason seems to be that Xvisor is using 64 bit to encode the 32 bit addresses from the guest, and load_elf_ram_sym() is sign-extending the

[PATCH v8 2/3] hw/riscv/boot.c: make riscv_load_initrd() static

2023-01-16 Thread Daniel Henrique Barboza
The only remaining caller is riscv_load_kernel_and_initrd() which belongs to the same file. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Bin Meng Reviewed-by: Alistair Francis --- hw/riscv/boot.c | 80

Re: [PATCH 4/6] hw/arm/npcm7xx: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/npcm7xx_boards.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 3/6] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43 insertions(+), 52 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/arm/aspeed.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) -static void at24c_eeprom_init(I2CBus *bus, uint8_t addr, uint32_t rsize) -{ -I2CSlave *i2c_dev = i2c_slave_new("at24c-eeprom",

Re: [PATCH 1/6] hw/nvram/eeprom_at24c: Add header w/ init helper

2023-01-16 Thread Philippe Mathieu-Daudé
On 14/1/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas --- hw/nvram/eeprom_at24c.c | 10 ++ include/hw/nvram/eeprom_at24c.h | 10 ++ 2 files changed, 20 insertions(+) create mode 100644 include/hw/nvram/eeprom_at24c.h +void

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Alex Bennée
Daniel P. Berrangé writes: > On Mon, Jan 16, 2023 at 10:06:07AM +, Alex Bennée wrote: >> >> marcandre.lur...@redhat.com writes: >> >> > From: Marc-André Lureau >> > >> > Signed-off-by: Marc-André Lureau >> >> I'm not sure how but this is re-breaking the windows build you just fixed:

Re: [PATCH v5 1/4] file-posix: add tracking of the zone write pointers

2023-01-16 Thread Sam Li
Sam Li 于2022年10月27日周四 23:52写道: > > Since Linux doesn't have a user API to issue zone append operations to > zoned devices from user space, the file-posix driver is modified to add > zone append emulation using regular writes. To do this, the file-posix > driver tracks the wp location of all zones

Re: [RFC PATCH 4/5] hw/xen: [FIXME] Avoid deadlock in xen_evtchn_set_gsi()

2023-01-16 Thread David Woodhouse
FWIW, with this support in QEMU I've just found and fixed two guest kernel regressions in MSI-X handling under Xen. And having done that, I can get back to frowning at the locking on the qemu side... On Sat, 2023-01-14 at 00:39 +, David Woodhouse wrote: > From: David Woodhouse > >

Re: Re: [for-8.0 v2 00/11] Refactor cryptodev

2023-01-16 Thread Daniel P . Berrangé
On Mon, Jan 16, 2023 at 05:53:07PM +0800, zhenwei pi wrote: > On 12/20/22 23:36, Michael S. Tsirkin wrote: > > On Tue, Nov 22, 2022 at 10:07:45PM +0800, zhenwei pi wrote: > > > v1 -> v2: > > > - fix coding style and use 'g_strjoin()' instead of 'char services[128]' > > >(suggested by Dr. David

Re: [for-8.0 v2 07/11] cryptodev-builtin: Detect akcipher capability

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:52PM +0800, zhenwei pi wrote: > Rather than exposing akcipher service/RSA algorithm to virtio crypto > device unconditionally, detect akcipher capability from akcipher > crypto framework. This avoids unsuccessful requests. > > Signed-off-by: zhenwei pi > --- >

Re: [for-8.0 v2 06/11] cryptodev: Support statistics

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:51PM +0800, zhenwei pi wrote: > Introduce cryptodev statistics in QAPI, and record OPS/Bandwidth for > each crypto device. > > Example of this feature: > virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq > { > "return": [ > { >

Re: [PATCH] accel/kvm: Specify default IPA size for arm64

2023-01-16 Thread Peter Maydell
On Sat, 14 Jan 2023 at 06:49, Akihiko Odaki wrote: > > On 2023/01/14 14:23, Richard Henderson wrote: > > On 1/8/23 22:22, Akihiko Odaki wrote: > >> libvirt uses "none" machine type to test KVM availability. Before this > >> change, QEMU used to pass 0 as machine type when calling KVM_CREATE_VM. >

Re: [for-8.0 v2 05/11] cryptodev: Introduce 'query-cryptodev' QMP command

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:50PM +0800, zhenwei pi wrote: > Now we have a QMP command to query crypto devices: > virsh qemu-monitor-command vm '{"execute": "query-cryptodev"}' | jq > { > "return": [ > { > "service": [ > "akcipher", > "mac", > "hash", >

Re: [PATCH 2/6] hw/arm/aspeed: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 55f114ef729f..1f9799d4321e

Re: [PATCH 4/6] hw/arm/npcm7xx: Remove local copy of at24c_eeprom_init

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/npcm7xx_boards.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/hw/arm/npcm7xx_boards.c b/hw/arm/npcm7xx_boards.c

Re: [PATCH 3/6] hw/arm/aspeed: Replace aspeed_eeprom_init with at24c_eeprom_init

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 95 ++--- 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/hw/arm/aspeed.c

Re: [PATCH 1/6] hw/nvram/eeprom_at24c: Add header w/ init helper

2023-01-16 Thread Cédric Le Goater
On 1/14/23 18:01, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas Please add some short commit log explaining how the helper could be useful. Reviewed-by: Cédric Le Goater Thanks, C. --- hw/nvram/eeprom_at24c.c | 10 ++ include/hw/nvram/eeprom_at24c.h | 10

Re: [for-8.0 v2 04/11] cryptodev: Introduce server type in QAPI

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:49PM +0800, zhenwei pi wrote: > Introduce cryptodev service type in cryptodev.json, then apply this > to related codes. Now we can remove VIRTIO_CRYPTO_SERVICE_xxx > dependence from QEMU cryptodev. > > Signed-off-by: zhenwei pi > --- > backends/cryptodev-builtin.c

Re: [for-8.0 v2 03/11] cryptodev: Introduce cryptodev alg type in QAPI

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:48PM +0800, zhenwei pi wrote: > Introduce cryptodev alg type in cryptodev.json, then apply this to > related codes, and drop 'enum CryptoDevBackendAlgType'. > > There are two options: > 1, { 'enum': 'QCryptodevBackendAlgType', > 'prefix': 'CRYPTODEV_BACKEND_ALG', >

Re: [for-8.0 v2 02/11] cryptodev: Remove 'name' & 'model' fields

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:47PM +0800, zhenwei pi wrote: > We have already used qapi to generate crypto device types, this allows > to convert type to a string 'model', so the 'model' field is not > needed. > > And the 'name' field is not used by any backend driver, drop it. > >

Re: [PATCH 7/7] hw/mem/cxl_type3: Add CXL RAS Error Injection Support.

2023-01-16 Thread Jonathan Cameron via
Hi Mike, > > +static int ct3d_qmp_uncor_err_to_cxl(CxlUncorErrorType qmp_err) > > +{ > > +switch (qmp_err) { > > +case CXL_UNCOR_ERROR_TYPE_CACHE_DATA_PARITY: > > +return CXL_RAS_UNC_ERR_CACHE_DATA_PARITY; > > +case CXL_UNCOR_ERROR_TYPE_CACHE_ADDRESS_PARITY: > > +

Re: [for-8.0 v2 01/11] cryptodev: Introduce cryptodev.json

2023-01-16 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 10:07:46PM +0800, zhenwei pi wrote: > Introduce QCryptodevBackendType in cryptodev.json, also apply this to > related codes. Then we can drop 'enum CryptoDevBackendOptionsType'. > > Signed-off-by: zhenwei pi > --- > MAINTAINERS | 1 + >

Re: [PATCH v7 09/13] vfio/migration: Implement VFIO migration protocol v2

2023-01-16 Thread Cédric Le Goater
Hello Avihai, On 1/15/23 19:35, Avihai Horon wrote: Implement the basic mandatory part of VFIO migration protocol v2. This includes all functionality that is necessary to support VFIO_MIGRATION_STOP_COPY part of the v2 protocol. The two protocols, v1 and v2, will co-exist and in the following

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Daniel P . Berrangé
On Mon, Jan 16, 2023 at 10:06:07AM +, Alex Bennée wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > I'm not sure how but this is re-breaking the windows build you just fixed: > > In file included from >

Re: regarding qapi and qapi-rs

2023-01-16 Thread Alex Bennée
Yu Zhang writes: > Hi all, > > I noticed that with each qemu release, the qapi (C version) may introduce > some changes, and the qapi-rs > (Rust version) also changes correspondingly. However, recently there is no > qapi-rs release yet for qemu-7.2. > I'd like to know, is the release of the

Re: [PATCH v3 3/8] migration/savevm: Allow immutable device state to be migrated early (i.e., before RAM)

2023-01-16 Thread David Hildenbrand
On 13.01.23 16:27, Peter Xu wrote: On Fri, Jan 13, 2023 at 10:20:31AM -0500, Peter Xu wrote: On Fri, Jan 13, 2023 at 02:47:24PM +0100, David Hildenbrand wrote: I'd prefer to not go down that path for now. QEMU_VM_SECTION_START without QEMU_VM_SECTION_PART and QEMU_VM_SECTION_END feels pretty

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Marc-André Lureau
Hi On Mon, Jan 16, 2023 at 2:08 PM Alex Bennée wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > Signed-off-by: Marc-André Lureau > > I'm not sure how but this is re-breaking the windows build you just fixed: > > In file included from >

Re: [PATCH v4 8/8] lcitool: drop texinfo from QEMU project/dependencies

2023-01-16 Thread Alex Bennée
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau I'm not sure how but this is re-breaking the windows build you just fixed: In file included from /usr/x86_64-w64-mingw32/sys-root/mingw/include/epoxy/egl.h:46, from

<    1   2   3   4   >