Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
On 1/21/23 1:06 PM, Chuck Zmudzinski wrote: > On 1/6/2023 9:03 AM, Anthony PERARD wrote: >> On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: >> > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, >> > as noted in docs/igd-assign.txt in the Qemu source code. >> >

[PATCH v11] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI devi

Re: Commit 145e2198d749 broke mips big endian.

2023-01-21 Thread Rob Landley
On 1/21/23 07:14, Peter Maydell wrote: > On Sat, 21 Jan 2023 at 10:45, Rob Landley wrote: >> >> wget https://landley.net/toybox/downloads/binaries/mkroot/0.8.9/mips.tgz >> extract >> and ./run-qemu.sh in there. Before this commit it goes: > > Hi; does this patchset fix the regression for you? >

Re: [PATCH] hw/pci-host/mv64361: Reuse pci_swizzle_map_irq_fn

2023-01-21 Thread Bernhard Beschow
Am 6. Januar 2023 11:39:27 UTC schrieb Bernhard Beschow : >mv64361_pcihost_map_irq() is a reimplementation of >pci_swizzle_map_irq_fn(). Resolve this redundancy. > >Signed-off-by: Bernhard Beschow Ping Patch is reviewed. Who will queue it? Daniel? Best regards, Bernhard >--- >Testing done:

[PATCH 1/3] hw/display/sm501: Remove parenthesis around consant macro definitions

2023-01-21 Thread BALATON Zoltan
No need to wrap constants in parenthesis. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 394 ++--- 1 file changed, 197 insertions(+), 197 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 52e42585af..0cbd1fecd5 100644 --- a/

[PATCH 0/3] Misc sm501 clean ups

2023-01-21 Thread BALATON Zoltan
Some small trivial clean ups I've found while looking at this file. BALATON Zoltan (3): hw/display/sm501: Remove parenthesis around consant macro definitions hw/display/sm501: Remove unneeded casts from void pointer hw/display/sm501: Code style fix hw/display/sm501.c | 419

[PATCH 3/3] hw/display/sm501: Code style fix

2023-01-21 Thread BALATON Zoltan
Fix checkpatch warning about multi-line comment. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 1e17072452..e1d0591d36 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.

[PATCH 2/3] hw/display/sm501: Remove unneeded casts from void pointer

2023-01-21 Thread BALATON Zoltan
This is not needed in C. Signed-off-by: BALATON Zoltan --- hw/display/sm501.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 0cbd1fecd5..1e17072452 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c

Re: [PATCH v3 3/7] hw/riscv/microchip_pfsoc.c: add an Icicle Kit fdt address function

2023-01-21 Thread Conor Dooley
On Sat, Jan 21, 2023 at 02:58:19PM -0300, Daniel Henrique Barboza wrote: > Conor, > > Thanks for the Icicle-kit walk-through! nw chief > I'll not claim that I fully understood it, > but I understood enough to handle the situation ATM. tbf, I struggle to explain/visualise that stuff with the "wi

Re: [PATCH v3 3/7] hw/riscv/microchip_pfsoc.c: add an Icicle Kit fdt address function

2023-01-21 Thread Daniel Henrique Barboza
Conor, Thanks for the Icicle-kit walk-through! I'll not claim that I fully understood it, but I understood enough to handle the situation ATM. Without this change, this is where the FDT is being installed in the board when I start it with 8Gb of RAM (retrieved via 'info roms'): addr=bf

Re: [PATCH v6] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
On 1/6/2023 9:03 AM, Anthony PERARD wrote: > On Sun, Jan 01, 2023 at 06:52:03PM -0500, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack is used to

Re: [PATCH v9] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
On 1/20/2023 4:34 PM, Stefano Stabellini wrote: > On Sat, 14 Jan 2023, Chuck Zmudzinski wrote: > > Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, > > as noted in docs/igd-assign.txt in the Qemu source code. > > > > Currently, when the xl toolstack is used to configure a Xen

Re: [PATCH v3 2/7] hw/acpi/acpi_dev_interface: Resolve AcpiDeviceIfClass::madt_cpu

2023-01-21 Thread Bernhard Beschow
On Fri, Jan 20, 2023 at 5:34 PM Igor Mammedov wrote: > On Thu, 19 Jan 2023 14:47:41 + > Bernhard Beschow wrote: > > > Am 18. Januar 2023 14:59:05 UTC schrieb Igor Mammedov < > imamm...@redhat.com>: > > >On Tue, 17 Jan 2023 00:30:23 + > > >Bernhard Beschow wrote: > > > > > >> Am 16. Janu

[PATCH v4 0/7] AML Housekeeping

2023-01-21 Thread Bernhard Beschow
This series factors out AcpiCpuAmlIfClass::madt_cpu from AcpiDeviceIfClass. By letting the (x86) CPUs implement the new interface, AML generation is delegated to the CPUs, freeing the ACPI controllers from worrying about x86 CPU specifics. The delegation to the CPUs is especially interesting for th

[PATCH v4 1/7] hw/i386/acpi-build: Remove unused attributes

2023-01-21 Thread Bernhard Beschow
Ammends commit 3db119da7915 'pc: acpi: switch to AML API composed DSDT'. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- hw/i386/acpi-build.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c inde

[PATCH v4 6/7] hw/acpi/acpi_dev_interface: Remove now unused #include "hw/boards.h"

2023-01-21 Thread Bernhard Beschow
Removing the "hw/boards.h" include from hw/acpi/acpi_dev_interface.h requires include fixes in various unrelated files to keep the code compiling. Signed-off-by: Bernhard Beschow --- hw/acpi/hmat.h | 3 ++- include/hw/acpi/acpi_dev_interface.h | 1 - hw/acpi/cpu.c

[PATCH v4 5/7] hw/acpi/acpi_dev_interface: Factor out TYPE_ACPI_CPU_AML_IF

2023-01-21 Thread Bernhard Beschow
This class attribute was always set to pc_madt_cpu_entry(). pc_madt_cpu_entry() is architecture dependent and was assigned to the attribute even in architecture agnostic code such as in hw/acpi/piix4.c and hw/isa/lpc_ich9. Not having to set madt_cpu there resolves the assumption that these device m

[PATCH v4 7/7] hw/i386/pc: Unexport pc_madt_cpu_entry()

2023-01-21 Thread Bernhard Beschow
pc_madt_cpu_entry() is now only used in target/i386/cpu, so move it there, and unexport and rename it. Signed-off-by: Bernhard Beschow --- include/hw/i386/pc.h| 4 hw/acpi/acpi-x86-stub.c | 6 -- hw/i386/acpi-common.c | 33 - target/i386/cpu.c

[PATCH v4 2/7] hw/isa/isa-bus: Turn isa_build_aml() into qbus_build_aml()

2023-01-21 Thread Bernhard Beschow
Frees isa-bus.c from implicit ACPI dependency. While at it, resolve open coding of qbus_build_aml() in piix3 and ich9. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov --- include/hw/acpi/acpi_aml_interface.h | 3 +++ include/hw/isa/isa.h

[PATCH v4 4/7] hw/acpi/acpi_dev_interface: Remove unused parameter from AcpiDeviceIfClass::madt_cpu

2023-01-21 Thread Bernhard Beschow
The only function ever assigned to AcpiDeviceIfClass::madt_cpu is pc_madt_cpu_entry() which doesn't use the AcpiDeviceIf parameter. Signed-off-by: Bernhard Beschow Reviewed-by: Igor Mammedov --- include/hw/acpi/acpi_dev_interface.h | 3 +-- include/hw/i386/pc.h | 6 ++ hw/ac

[PATCH v4 3/7] hw/acpi/piix4: No need to #include "hw/southbridge/piix.h"

2023-01-21 Thread Bernhard Beschow
hw/acpi/piix4 has its own header with its structure definition etc. Ammends commit 2bfd0845f0 'hw/acpi/piix4: move PIIX4PMState into separate piix4.h header'. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé --- hw/acpi/piix4.c | 1 - 1 file changed, 1 deletion(-) diff --gi

Re: Commit 145e2198d749 broke mips big endian.

2023-01-21 Thread Peter Maydell
On Sat, 21 Jan 2023 at 13:14, Peter Maydell wrote: > > On Sat, 21 Jan 2023 at 10:45, Rob Landley wrote: > > > > wget https://landley.net/toybox/downloads/binaries/mkroot/0.8.9/mips.tgz > > extract > > and ./run-qemu.sh in there. Before this commit it goes: > > Hi; does this patchset fix the regr

Re: Commit 145e2198d749 broke mips big endian.

2023-01-21 Thread Peter Maydell
On Sat, 21 Jan 2023 at 10:45, Rob Landley wrote: > > wget https://landley.net/toybox/downloads/binaries/mkroot/0.8.9/mips.tgz > extract > and ./run-qemu.sh in there. Before this commit it goes: Hi; does this patchset fix the regression for you? https://lore.kernel.org/qemu-devel/20230118095751.4

Re: [PULL 00/38] Block layer patches

2023-01-21 Thread Peter Maydell
On Fri, 20 Jan 2023 at 12:26, Kevin Wolf wrote: > > The following changes since commit 239b8b0699a222fd21da1c5fdeba0a2456085a47: > > Merge tag 'trivial-branch-for-8.0-pull-request' of > https://gitlab.com/laurent_vivier/qemu into staging (2023-01-19 15:05:29 > +) > > are available in the G

Re: [PULL 00/37] riscv-to-apply queue

2023-01-21 Thread Peter Maydell
On Fri, 20 Jan 2023 at 07:47, Alistair Francis wrote: > > From: Alistair Francis > > The following changes since commit 239b8b0699a222fd21da1c5fdeba0a2456085a47: > > Merge tag 'trivial-branch-for-8.0-pull-request' of > https://gitlab.com/laurent_vivier/qemu into staging (2023-01-19 15:05:29 >

Re: [PATCH 0/2] tests/migration: add support for ppc64le in guestperf.py

2023-01-21 Thread Daniel Henrique Barboza
On 1/21/23 08:57, BALATON Zoltan wrote: On Sat, 21 Jan 2023, Daniel Henrique Barboza wrote: Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Unrelated to this patch but just so you won't miss it, can you please take care of this patch too? https://patchew.org/QEMU/20230118164512.

Re: [PATCH v2] ppc/pegasos2: Improve readability of VIA south bridge creation

2023-01-21 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 1/18/23 13:45, BALATON Zoltan wrote: Slightly improve readability of creating the south bridge by changing type of a local variable to avoid some casts within function arguments which makes some lines shorter and easier to rea

Re: [PATCH 0/2] tests/migration: add support for ppc64le in guestperf.py

2023-01-21 Thread BALATON Zoltan
On Sat, 21 Jan 2023, Daniel Henrique Barboza wrote: Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Unrelated to this patch but just so you won't miss it, can you please take care of this patch too? https://patchew.org/QEMU/20230118164512.1bcfb745...@zero.eik.bme.hu/ Thank you, BA

Re: [PATCH 0/2] tests/migration: add support for ppc64le in guestperf.py

2023-01-21 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 8/8/22 21:24, Murilo Opsfelder Araujo wrote: The first patch adds sysprof-capture-4 dependency when building stress binary in order to fix a build error. The second patch adds support for ppc64le in guestperf.py. Murilo Opsf

[PATCH v10] xen/pt: reserve PCI slot 2 for Intel igd-passthru

2023-01-21 Thread Chuck Zmudzinski
Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI devi

Commit 145e2198d749 broke mips big endian.

2023-01-21 Thread Rob Landley
wget https://landley.net/toybox/downloads/binaries/mkroot/0.8.9/mips.tgz extract and ./run-qemu.sh in there. Before this commit it goes: loop: module loaded ata_piix :00:0a.1: enabling device ( -> 0001) scsi host0: ata_piix scsi host1: ata_piix ata1: PATA max UDMA/33 cmd 0x1f0 ctl 0x3f6 bm

[PATCH v2 03/11] audio: rename hardware store to backend

2023-01-21 Thread Volker Rümelin
Use a consistent friendly name for the HWVoiceOut and HWVoiceIn structures. Reviewed-by: Thomas Huth Signed-off-by: Volker Rümelin --- audio/audio_template.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/audio_template.h b/audio/audio_template.h index ee320a2e3f.

[PATCH v2 07/11] audio/audio_template: use g_malloc0() to replace audio_calloc()

2023-01-21 Thread Volker Rümelin
Use g_malloc0() as a direct replacement for audio_calloc(). Since the type of the parameter n_bytes of the function g_malloc0() is unsigned, the type of the variables voice_size_out and voice_size_in has been changed to size_t. This means that the function argument no longer has to be checked for

[PATCH v2 01/11] audio: log unimplemented audio device sample rates

2023-01-21 Thread Volker Rümelin
Some emulated audio devices allow guests to select very low sample rates that the audio subsystem doesn't support. The lowest supported sample rate depends on the audio backend used and in most cases can be changed with various -audiodev arguments. Until now, the audio_bug function emits an error m

[PATCH v2 10/11] alsaaudio: change default playback settings

2023-01-21 Thread Volker Rümelin
The currently used default playback settings in the ALSA audio backend are a bit unfortunate. With a few emulated audio devices, audio playback does not work properly. Here is a short part of the debug log while audio is playing (elapsed time in seconds). audio: Elapsed since last alsa run (runnin

[PATCH v2 08/11] audio/audio_template: use g_new0() to replace audio_calloc()

2023-01-21 Thread Volker Rümelin
Replace audio_calloc() with the equivalent g_new0(). With a n_structs argument >= 1, g_new0() never returns NULL. Also remove the unnecessary NULL checks. Signed-off-by: Volker Rümelin --- audio/audio_template.h | 29 - 1 file changed, 12 insertions(+), 17 deletions(

[PATCH v2 09/11] audio: remove audio_calloc() function

2023-01-21 Thread Volker Rümelin
Now that the last call site of audio_calloc() was removed, remove the unused audio_calloc() function. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- audio/audio.c | 20 audio/audio_int.h | 1 - 2 files changed, 21 deletions(-) diff --git a/audio

[PATCH v2 06/11] audio/alsaaudio: use g_new0() instead of audio_calloc()

2023-01-21 Thread Volker Rümelin
Replace audio_calloc() with the equivalent g_new0(). The value of the g_new0() argument count is >= 1, which means g_new0() will never return NULL. Also remove the unnecessary NULL check. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Volker Rümelin --- audi

[PATCH v2 02/11] audio: don't show unnecessary error messages

2023-01-21 Thread Volker Rümelin
Let the audio_pcm_create_voice_pair_* functions handle error reporting. This avoids an additional error message in case the guest selected an unimplemented sample rate. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Volker Rümelin --- audio/audio_template.h | 2 +- 1 file changed, 1 inserti

[PATCH v2 05/11] audio/mixeng: use g_new0() instead of audio_calloc()

2023-01-21 Thread Volker Rümelin
Replace audio_calloc() with the equivalent g_new0(). With a n_structs argument of 1, g_new0() never returns NULL. Also remove the unnecessary NULL checks. Reviewed-by: Richard Henderson Signed-off-by: Volker Rümelin --- audio/audio.c | 5 - audio/audio_template.h | 6 +- audio

[PATCH v2 11/11] alsaaudio: reintroduce default recording settings

2023-01-21 Thread Volker Rümelin
Audio recording with ALSA default settings currently doesn't work. The debug log shows updates every 0.75s and 1.5s. audio: Elapsed since last alsa run (running): 0.743030 audio: Elapsed since last alsa run (running): 1.486048 audio: Elapsed since last alsa run (running): 0.743008 audio: Elapsed s

[PATCH v2 04/11] audio: remove unused #define AUDIO_STRINGIFY

2023-01-21 Thread Volker Rümelin
Remove the unused #define AUDIO_STRINGIFY. It was last used before commit 470bcabd8f ("audio: Replace AUDIO_FUNC with __func__"). Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Signed-off-by: Volker Rümelin --- audio/audio_int.h | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH v2 00/11] audio: more improvements

2023-01-21 Thread Volker Rümelin
A few patches from my audio patch queue. Patches 1 - 2: If a guest selects an unsupported sample rate, an error message is currently shown. The first patch takes care to suppress the error message and reports with the qemu_log_mask(LOG_UNIMP, ...) function that this is not supported. The secon