Re: [PATCH] linux-user: Provide print_raw_param64() for 64-bit values

2023-03-07 Thread Laurent Vivier
Le 31/01/2023 à 18:18, Helge Deller a écrit : Add a new function print_raw_param64() to print 64-bit values in the same way as print_raw_param(). This prevents that qemu_log() is used to work around the problem that print_raw_param() can only print 32-bit values when compiled for 32-bit targets.

Re: [PATCH] pflash: Fix blk_pread_nonzeroes()

2023-03-07 Thread Cédric Le Goater
On 3/7/23 15:02, Kevin Wolf wrote: Commit a4b15a8b introduced a new function blk_pread_nonzeroes(). Instead of reading directly from the root node of the BlockBackend, it reads from its 'file' child node. This can happen to mostly work for raw images (as long as the 'raw' format driver is in use,

Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select

2023-03-07 Thread BALATON Zoltan
On Tue, 7 Mar 2023, Daniel Henrique Barboza wrote: On 3/7/23 08:42, BALATON Zoltan wrote: From: David Woodhouse Back in the mists of time, before EISA came along and required per-pin level control in the ELCR register, the i8259 had a single chip-wide level-mode control in bit 3 of ICW1. Even

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-07 Thread Stefan Hajnoczi
On Tue, Mar 07, 2023 at 09:48:51AM +0100, Kevin Wolf wrote: > Am 01.03.2023 um 17:16 hat Stefan Hajnoczi geschrieben: > > On Fri, Feb 03, 2023 at 08:17:28AM -0500, Emanuele Giuseppe Esposito wrote: > > > Remove usage of aio_context_acquire by always submitting asynchronous > > > AIO to the current

Re: [PATCH] linux-user/mips: Low down switchable NaN2008 requirement

2023-03-07 Thread Laurent Vivier
Phil (or someone else that knows mips), could you review? With one review I will apply to my linux-user branch. Thanks, Laurent Le 22/02/2023 à 11:28, Jiaxun Yang a écrit : Ping? 2023年2月11日 17:34,Jiaxun Yang 写道: Previously switchable NaN2008 requires fcsr31.nan2008 to be writable for guest

Re: [PATCH] linux-user: fill out task state in /proc/self/stat

2023-03-07 Thread Laurent Vivier
Le 06/03/2023 à 10:59, Andreas Schwab a écrit : Some programs want to match an actual task state character. Signed-off-by: Andreas Schwab --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 36fffd36ca..eb4c2c3162 1

Re: [PULL 03/38] pflash: Only read non-zero parts of backend image

2023-03-07 Thread Cédric Le Goater
On 3/7/23 15:00, Kevin Wolf wrote: Am 03.03.2023 um 23:51 hat Maciej S. Szmigiero geschrieben: On 8.02.2023 12:19, Cédric Le Goater wrote: On 2/7/23 13:48, Kevin Wolf wrote: Am 07.02.2023 um 10:19 hat Cédric Le Goater geschrieben: On 2/7/23 09:38, Kevin Wolf wrote: Am 06.02.2023 um 16:54 hat

Re: Requesting help for the Outreachy contribution Stage

2023-03-07 Thread Alex Bennée
Sidrah writes: > Hello, > I am Sidrah Ahmed, an undergrad IT student. I've had my initial application > to Outreachy approved. I had ' > Problem Solving using C' class in my last semester and I have 'Data > Structures using ‘C’ ' class this semester, > worth 4 credits each. I believe I posses

query-command-line-options (was: [PATCH 1/7] qemu: capabilities: Introduce QEMU_CAPS_MACHINE_ACPI)

2023-03-07 Thread Markus Armbruster
[Resent with cc: qemu-devel and adjusted subject, sorry for the noise] abologna at redhat.com (Andrea Bolognani) writes: > On Mon, Feb 27, 2023 at 06:25:23PM +0100, Peter Krempa wrote: >> On Mon, Feb 27, 2023 at 08:44:57 -0800, Andrea Bolognani wrote: >> > This looks like you're checking whether

[Question] Support RISC-V Board on QEMU

2023-03-07 Thread 김진홍
Dear Developer of QEMU.   I have a question to run QEMU by RISC-V board.   Currently, sifive has "HiFive Unleashed" and "HiFive Unmatched" boards.   HiFive Unleashed board is set when executed with "-M sifive_u" option in QEMU (v7.2.0).   And the official guide of QEMU is also the gui

Re: [PATCH V2] migration: fix populate_vfio_info

2023-03-07 Thread Steven Sistare
On 3/7/2023 6:32 AM, Dr. David Alan Gilbert wrote: > * Steve Sistare (steven.sist...@oracle.com) wrote: >> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for >> CONFIG_VFIO. Without it, the 'info migrate' command never returns >> info about vfio. >> >> Fixes: 43bd0bf30f ("migrat

Re: [RFC PATCH v1 09/25] hw/xen: Add evtchn operations to allow redirection to internal emulation

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse The existing implementation calling into the real libxenevtchn moves to a new file hw/xen/xen-operations.c, and is called via a function table which in a subsequent commit will also be able to invoke the emulated event channel su

Re: [PATCH v8 3/6] hw/isa/vt82c686: Implement PCI IRQ routing

2023-03-07 Thread Alex Bennée
BALATON Zoltan writes: > On Tue, 7 Mar 2023, Mark Cave-Ayland wrote: >> On 07/03/2023 00:20, BALATON Zoltan wrote: >>> On Mon, 6 Mar 2023, Mark Cave-Ayland wrote: On 06/03/2023 12:33, BALATON Zoltan wrote: >>> Given that we only have a few hours left until the freeze I hope >>> you're not

[PATCH] pflash: Fix blk_pread_nonzeroes()

2023-03-07 Thread Kevin Wolf
Commit a4b15a8b introduced a new function blk_pread_nonzeroes(). Instead of reading directly from the root node of the BlockBackend, it reads from its 'file' child node. This can happen to mostly work for raw images (as long as the 'raw' format driver is in use, but not actually doing anything), bu

Re: [PULL 03/38] pflash: Only read non-zero parts of backend image

2023-03-07 Thread Kevin Wolf
Am 03.03.2023 um 23:51 hat Maciej S. Szmigiero geschrieben: > On 8.02.2023 12:19, Cédric Le Goater wrote: > > On 2/7/23 13:48, Kevin Wolf wrote: > > > Am 07.02.2023 um 10:19 hat Cédric Le Goater geschrieben: > > > > On 2/7/23 09:38, Kevin Wolf wrote: > > > > > Am 06.02.2023 um 16:54 hat Cédric Le G

Re: [PATCH 0/9] accel/tcg: Fix page_set_flags and related [#1528]

2023-03-07 Thread Ninad Palsule
On 3/6/23 9:19 PM, Joel Stanley wrote: On Mon, 6 Mar 2023 at 02:14, Richard Henderson wrote: The primary issue is that of overflow, where "end" for the last page of the 32-bit address space overflows to 0. The fix is to use "last" instead, which can always be represented. This requires that

Re: [PATCH v1] Added TMP421 type sensor's support in tiogapass

2023-03-07 Thread Cédric Le Goater
On 3/7/23 11:33, Karthikeyan Pasupathi wrote: Added TMP421 type sensor support in tiogapass platform. Tested: Tested and verified in tiogapass platform. Signed-off-by: Karthikeyan Pasupathi Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed.c | 4 1 file changed, 4 inse

Re: [PATCH v1] Modified BMC FRU byte data in yosemitev2

2023-03-07 Thread Cédric Le Goater
On 3/7/23 11:48, Karthikeyan Pasupathi wrote: Modified BMC FRU data in yosemite v2 platform. Tested: Tested and Verified in yosemitev2 platform. Signed-off-by: Karthikeyan Pasupathi Fixes: 34f73a81e6 ("hw/arm/aspeed: Adding new machine Yosemitev2 in QEMU") Reviewed-by: Cédric Le Goater Tha

Re: [RFC PATCH v1 08/25] hw/xen: Create initial XenStore nodes

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 70 ++ 1 file changed, 70 insertions(+) Reviewed-by: Paul Durrant

Re: [PATCH v5] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-07 Thread Marc-André Lureau
Hi On Fri, Mar 3, 2023 at 8:06 PM Dorinda Bassey >> What are those thread_loop_signal() for? Maybe leave a comment? > > the explanation of the function is in the reference header file. > Yes, I read the reference documentation before asking: "Signal all threads waiting with pw_thread_loop_wait."

[PULL v2 00/13] Final tests, s390x and misc updates before the soft freeze

2023-03-07 Thread Thomas Huth
Hi Peter! The following changes since commit c29a2f40cd5d1fdad4632b48343cd968db041a44: Merge tag 'pull-target-arm-20230306' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-03-07 09:58:43 +) are available in the Git repository at: https://gitlab.com/thuth/qemu.gi

Re: Deadlock with ide_issue_trim and draining

2023-03-07 Thread Hanna Czenczek
On 07.03.23 13:22, Fiona Ebner wrote: Hi, I am suspecting that commit 7e5cdb345f ("ide: Increment BB in-flight counter for TRIM BH") introduced an issue in combination with draining. From a debug session on a costumer's machine I gathered the following information: * The QEMU process hangs in a

Re: [RFC PATCH v1 06/25] hw/xen: Implement XenStore permissions

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: Paul Durrant Store perms as a GList of strings, check permissions. Signed-off-by: Paul Durrant Signed-off-by: David Woodhouse --- hw/i386/kvm/xen_xenstore.c | 2 +- hw/i386/kvm/xenstore_impl.c | 259 +---

Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 10:36 -0300, Daniel Henrique Barboza wrote: > > Checkpatch will nag about it claiming that we need spaces between > '*'. The maintainer can fix it in-tree though. I saw that and explicitly didn't care. 3/5 of the existing examples within the tree look like that one — which i

Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select

2023-03-07 Thread Peter Maydell
On Tue, 7 Mar 2023 at 13:36, Daniel Henrique Barboza wrote: > On 3/7/23 08:42, BALATON Zoltan wrote: > > @@ -168,6 +186,10 @@ static const VMStateDescription vmstate_pic_common = { > > VMSTATE_UINT8(single_mode, PICCommonState), > > VMSTATE_UINT8(elcr, PICCommonState), > >

Re: [RFC PATCH v1 05/25] hw/xen: Watches on XenStore transactions

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 13:32 +, Paul Durrant wrote: > > Reviewed-by: Paul Durrant > > ... with a couple of nits in comments called out below... Thanks, I'm fixing these and pushing them out to my tree at https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xenfv (and occasional

Re: [PATCH v2 2/4] linux-user: fix sockaddr_in6 endianness

2023-03-07 Thread Laurent Vivier
Le 07/03/2023 à 12:27, Mathis MARION a écrit : On 06/03/2023 22:52, Laurent Vivier wrote: CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. Le 20/02/2023 à 09:58, Mathis Mario

Re: [PATCH v9 3/7] Revert "hw/isa/vt82c686: Remove intermediate IRQ forwarder"

2023-03-07 Thread Daniel Henrique Barboza
On 3/7/23 08:42, BALATON Zoltan wrote: This partially reverts commit bb98e0f59cde84d9fddc60ae74ef7ddfca17 keeping the rename of a state field but reverting other cahanges which break interrupts on pegasos2. Signed-off-by: BALATON Zoltan --- Reviewed-by: Daniel Henrique Barboza hw/

Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select

2023-03-07 Thread Daniel Henrique Barboza
On 3/7/23 08:42, BALATON Zoltan wrote: From: David Woodhouse Back in the mists of time, before EISA came along and required per-pin level control in the ELCR register, the i8259 had a single chip-wide level-mode control in bit 3 of ICW1. Even in the PIIX3 datasheet from 1996 this is documen

Re: [PATCH v5 09/15] vfio/common: Record DMA mapped IOVA ranges

2023-03-07 Thread Cédric Le Goater
On 3/7/23 13:54, Joao Martins wrote: According to the device DMA logging uAPI, IOVA ranges to be logged by the device must be provided all at once upon DMA logging start. As preparation for the following patches which will add device dirty page tracking, keep a record of all DMA mapped IOVA rang

Re: [PATCH v2 17/18] ui/dbus: do not require opengl & gbm

2023-03-07 Thread Marc-André Lureau
Hi On Tue, Mar 7, 2023 at 3:59 PM wrote: > > From: Marc-André Lureau > > Allow to build & use the DBus display without 3d/GPU acceleration support. > > Signed-off-by: Marc-André Lureau > --- > meson.build | 2 -- > ui/dbus-listener.c | 15 +-- > ui/dbus.c

Re: [RFC PATCH v1 05/25] hw/xen: Watches on XenStore transactions

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Firing watches on the nodes that still exist is relatively easy; just walk the tree and look at the nodes with refcount of one. Firing watches on *deleted* nodes is more fun. We add 'modified_in_tx' and 'deleted_in_tx' flags to

Re: [PATCH v5 08/15] vfio/common: Add helper to consolidate iova/end calculation

2023-03-07 Thread Cédric Le Goater
On 3/7/23 13:54, Joao Martins wrote: In preparation to be used in device dirty tracking, move the code that calculate a iova/end range from the container/section. This avoids duplication on the common checks across listener callbacks. Signed-off-by: Joao Martins Reviewed-by: Cédric Le Goater

Re: [PATCH v5 06/15] vfio/common: Use a single tracepoint for skipped sections

2023-03-07 Thread Cédric Le Goater
On 3/7/23 13:54, Joao Martins wrote: In preparation to turn more of the memory listener checks into common functions, one of the affected places is how we trace when sections are skipped. Right now there is one for each. Change it into one single tracepoint `vfio_listener_region_skip` which recei

Re: [PATCH RESEND v6 0/5] migration: reduce time of loading non-iterable vmstate

2023-03-07 Thread Chuang Xu
Hi, Peter, On 2023/3/7 上午4:48, Peter Xu wrote: On Mon, Mar 06, 2023 at 08:48:05PM +0800, Chuang Xu wrote: Hi, Peter, On 2023/3/6 上午6:05, Peter Xu wrote: 1.virtio_load->virtio_init_region_cache 2.virtio_load->virtio_set_features_nocheck What is this one specifically? I failed to see quickly

Re: [PATCH V2 3/5] memory: introduce memory_region_unmap_iommu_notifier_range()

2023-03-07 Thread Thomas Huth
On 23/02/2023 07.59, Jason Wang wrote: This patch introduces a new helper to unmap the range of a specific IOMMU notifier. Signed-off-by: Jason Wang --- include/exec/memory.h | 10 ++ softmmu/memory.c | 13 + 2 files changed, 23 insertions(+) diff --git a/include/e

QEMU/KVM call minutes for 2022-02-21

2023-03-07 Thread Juan Quintela
Hi Sorry for the delay, some of the topics of the previous call: Record of sessions: - What do peple think? This makes things easier for people that can't attend due to whatever reason. Mainly TZ problems. - Should we do another one next week? Which one? TDX migration VFIO/VPDA/Vhos

Re: [RFC PATCH v1 04/25] hw/xen: Implement XenStore transactions

2023-03-07 Thread Paul Durrant
On 02/03/2023 15:34, David Woodhouse wrote: From: David Woodhouse Given that the whole thing supported copy on write from the beginning, transactions end up being fairly simple. On starting a transaction, just take a ref of the existing root; swap it back in on a successful commit. The main tr

[PATCH v2] qapi: give available enum values as error hint

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau This allows for a more pleasant user experience. Before: $ ./qemu-system-x86_64 -display egl-headless,gl= qemu-system-x86_64: -display egl-headless,gl=: Parameter 'gl' does not accept value '' After: $ ./qemu-system-x86_64 -display egl-headless,gl= qemu-system-x86_64: -

Re: [PATCH] qapi: give available enum values in error string

2023-03-07 Thread Marc-André Lureau
Hi On Tue, Mar 7, 2023 at 4:39 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > This allows for a more pleasant user experience. > > > > Before: > > $ ./qemu-system-x86_64 -display egl-headless,gl= > > qemu-system-x86_64: -display egl-headl

Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files

2023-03-07 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Mar 07, 2023 at 04:30:27PM +0400, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> This seems to be the preferred style. >> >> The EditorConfig property is not supported by all editors: >> https://github.com/editorconfig/editorconfig/wiki

[PATCH v5 07/15] vfio/common: Consolidate skip/invalid section into helper

2023-03-07 Thread Joao Martins
The checks are replicated against region_add and region_del and will be soon added in another memory listener dedicated for dirty tracking. Move these into a new helper for avoid duplication. Signed-off-by: Joao Martins Reviewed-by: Cédric Le Goater Reviewed-by: Avihai Horon --- hw/vfio/commo

[PATCH v5 11/15] vfio/common: Extract code from vfio_get_dirty_bitmap() to new function

2023-03-07 Thread Joao Martins
From: Avihai Horon Extract the VFIO_IOMMU_DIRTY_PAGES ioctl code in vfio_get_dirty_bitmap() to its own function. This will help the code to be more readable after next patch will add device dirty page bitmap sync functionality. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins Reviewed-

[PATCH v5 05/15] vfio/common: Add helper to validate iova/end against hostwin

2023-03-07 Thread Joao Martins
Move the code that finds the container host DMA window against a iova range. This avoids duplication on the common checks across listener callbacks. Signed-off-by: Joao Martins Reviewed-by: Cédric Le Goater Reviewed-by: Avihai Horon --- hw/vfio/common.c | 38 ---

[PATCH v5 09/15] vfio/common: Record DMA mapped IOVA ranges

2023-03-07 Thread Joao Martins
According to the device DMA logging uAPI, IOVA ranges to be logged by the device must be provided all at once upon DMA logging start. As preparation for the following patches which will add device dirty page tracking, keep a record of all DMA mapped IOVA ranges so later they can be used for DMA lo

[PATCH v5 03/15] vfio/common: Abort migration if dirty log start/stop/sync fails

2023-03-07 Thread Joao Martins
From: Avihai Horon If VFIO dirty pages log start/stop/sync fails during migration, migration should be aborted as pages dirtied by VFIO devices might not be reported properly. This is not the case today, where in such scenario only an error is printed. Fix it by aborting migration in the above

[PATCH v5 00/15] vfio/migration: Device dirty page tracking

2023-03-07 Thread Joao Martins
Hey, Presented herewith a series based on the basic VFIO migration protocol v2 implementation [1]. It is split from its parent series[5] to solely focus on device dirty page tracking. Device dirty page tracking allows the VFIO device to record its DMAs and report them back when needed. This is pa

[PATCH v5 01/15] vfio/common: Fix error reporting in vfio_get_dirty_bitmap()

2023-03-07 Thread Joao Martins
From: Avihai Horon Return -errno instead of -1 if VFIO_IOMMU_DIRTY_PAGES ioctl fails in vfio_get_dirty_bitmap(). Signed-off-by: Avihai Horon Reviewed-by: Cédric Le Goater --- hw/vfio/common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index bab83c0

[PATCH v5 10/15] vfio/common: Add device dirty page tracking start/stop

2023-03-07 Thread Joao Martins
Add device dirty page tracking start/stop functionality. This uses the device DMA logging uAPI to start and stop dirty page tracking by device. Device dirty page tracking is used only if all devices within a container support device dirty page tracking. Signed-off-by: Avihai Horon Signed-off-by:

[PATCH v5 15/15] docs/devel: Document VFIO device dirty page tracking

2023-03-07 Thread Joao Martins
From: Avihai Horon Adjust the VFIO dirty page tracking documentation and add a section to describe device dirty page tracking. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins Reviewed-by: Cédric Le Goater --- docs/devel/vfio-migration.rst | 46 +++ 1 f

[PATCH v5 13/15] vfio/migration: Block migration with vIOMMU

2023-03-07 Thread Joao Martins
Migrating with vIOMMU will require either tracking maximum IOMMU supported address space (e.g. 39/48 address width on Intel) or range-track current mappings and dirty track the new ones post starting dirty tracking. This will be done as a separate series, so add a live migration blocker until that

[PATCH v5 12/15] vfio/common: Add device dirty page bitmap sync

2023-03-07 Thread Joao Martins
Add device dirty page bitmap sync functionality. This uses the device DMA logging uAPI to sync dirty page bitmap from the device. Device dirty page bitmap sync is used only if all devices within a container support device dirty page tracking. Signed-off-by: Avihai Horon Signed-off-by: Joao Marti

[PATCH v5 14/15] vfio/migration: Query device dirty page tracking support

2023-03-07 Thread Joao Martins
Now that everything has been set up for device dirty page tracking, query the device for device dirty page tracking support. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins Reviewed-by: Cédric Le Goater --- hw/vfio/migration.c | 15 +++ 1 file changed, 15 insertions(+) dif

[PATCH v5 06/15] vfio/common: Use a single tracepoint for skipped sections

2023-03-07 Thread Joao Martins
In preparation to turn more of the memory listener checks into common functions, one of the affected places is how we trace when sections are skipped. Right now there is one for each. Change it into one single tracepoint `vfio_listener_region_skip` which receives a name which refers to the callback

[PATCH v5 02/15] vfio/common: Fix wrong %m usages

2023-03-07 Thread Joao Martins
From: Avihai Horon There are several places where the %m conversion is used if one of vfio_dma_map(), vfio_dma_unmap() or vfio_get_dirty_bitmap() fail. The %m usage in these places is wrong since %m relies on errno value while the above functions don't report errors via errno. Fix it by using s

Re: [PATCH] hw/acpi: Set memory regions to native endian as a work around

2023-03-07 Thread BALATON Zoltan
On Tue, 7 Mar 2023, Paolo Bonzini wrote: On 3/7/23 11:01, BALATON Zoltan wrote: I'm not sure I follow what you mean so I'd need a patch to see then I can test it with the clients I run on pegasos2. Do you have a spec, or pointer to the morphos kernel sources, to figure out how the hardware wo

[PATCH v5 08/15] vfio/common: Add helper to consolidate iova/end calculation

2023-03-07 Thread Joao Martins
In preparation to be used in device dirty tracking, move the code that calculate a iova/end range from the container/section. This avoids duplication on the common checks across listener callbacks. Signed-off-by: Joao Martins --- hw/vfio/common.c | 41 +++--

Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files

2023-03-07 Thread Marc-André Lureau
Hi On Tue, Mar 7, 2023 at 4:41 PM Daniel P. Berrangé wrote: > > On Tue, Mar 07, 2023 at 04:30:27PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This seems to be the preferred style. > > > > The EditorConfig property is not supported by all editors: > > https://gi

[PATCH v5 04/15] vfio/common: Add VFIOBitmap and alloc function

2023-03-07 Thread Joao Martins
From: Avihai Horon There are already two places where dirty page bitmap allocation and calculations are done in open code. To avoid code duplication, introduce VFIOBitmap struct and corresponding alloc function and use them where applicable. Signed-off-by: Avihai Horon Signed-off-by: Joao Mart

Re: [PATCH v1 1/2] vhost: Defer filtering memory sections until building the vhost memory structure

2023-03-07 Thread David Hildenbrand
On 07.03.23 11:51, Igor Mammedov wrote: On Thu, 16 Feb 2023 12:47:51 +0100 David Hildenbrand wrote: Having multiple devices, some filtering memslots and some not filtering memslots, messes up the "used_memslot" accounting. If we'd have a device the filters out less memory sections after a devi

Re: [PATCH v5 00/16] hw/9pfs: Add 9pfs support for Windows

2023-03-07 Thread Christian Schoenebeck
On Monday, March 6, 2023 3:56:49 PM CET Bin Meng wrote: > On Mon, Mar 6, 2023 at 10:15 PM Christian Schoenebeck > wrote: > > > > On Monday, February 20, 2023 11:07:59 AM CET Bin Meng wrote: > > > At present there is no Windows support for 9p file system. > > > This series adds initial Windows supp

Re: [PULL 00/21] target-arm queue

2023-03-07 Thread Peter Maydell
On Mon, 6 Mar 2023 at 15:34, Peter Maydell wrote: > > The following changes since commit f003dd8d81f7d88f4b1f8802309eaa76f6eb223a: > > Merge tag 'pull-tcg-20230305' of https://gitlab.com/rth7680/qemu into > staging (2023-03-06 10:20:04 +) > > are available in the Git repository at: > > ht

Re: [PULL 0/2] xen queue

2023-03-07 Thread Peter Maydell
On Mon, 6 Mar 2023 at 14:03, Anthony PERARD via wrote: > > The following changes since commit 2946e1af2704bf6584f57d4e3aec49d1d5f3ecc0: > > configure: Disable thread-safety warnings on macOS (2023-03-04 14:03:46 > +) > > are available in the Git repository at: > > https://xenbits.xen.org/

Re: [PULL 0/5] hw/nvme updates

2023-03-07 Thread Peter Maydell
On Mon, 6 Mar 2023 at 14:34, Klaus Jensen wrote: > > From: Klaus Jensen > > Hi, > > The following changes since commit f003dd8d81f7d88f4b1f8802309eaa76f6eb223a: > > Merge tag 'pull-tcg-20230305' of https://gitlab.com/rth7680/qemu into > staging (2023-03-06 10:20:04 +) > > are available in

Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files

2023-03-07 Thread Daniel P . Berrangé
On Tue, Mar 07, 2023 at 04:30:27PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This seems to be the preferred style. > > The EditorConfig property is not supported by all editors: > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_len

Re: [PATCH] qapi: give available enum values in error string

2023-03-07 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > This allows for a more pleasant user experience. > > Before: > $ ./qemu-system-x86_64 -display egl-headless,gl= > qemu-system-x86_64: -display egl-headless,gl=: Parameter 'gl' does not accept > value '' > > After: > $ ./qemu-syste

Re: [PATCH v4 08/11] qmp: add 'get-win32-socket'

2023-03-07 Thread Marc-André Lureau
Hi On Mon, Mar 6, 2023 at 7:49 PM Markus Armbruster wrote: > > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > A process with enough capabilities can duplicate a socket to QEMU. Add a > > QMP command to import it and add it to the monitor fd list, so it can be > > later

[PATCH] .editorconfig: set max line at 70 chars for QAPI files

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau This seems to be the preferred style. The EditorConfig property is not supported by all editors: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Signed-off-by: Marc-André Lureau --- .editorconfig | 1 + 1 file changed, 1 insert

Deadlock with ide_issue_trim and draining

2023-03-07 Thread Fiona Ebner
Hi, I am suspecting that commit 7e5cdb345f ("ide: Increment BB in-flight counter for TRIM BH") introduced an issue in combination with draining. >From a debug session on a costumer's machine I gathered the following information: * The QEMU process hangs in aio_poll called during draining and doesn

Re: [RFC PATCH v1 03/25] hw/xen: Implement XenStore watches

2023-03-07 Thread David Woodhouse
On Tue, 2023-03-07 at 11:29 +, Paul Durrant wrote: > > I think you could stash a tail pointer here... > > > +    } > > + > > +    if (dom_id && s->nr_domu_watches >= XS_MAX_WATCHES) { > > +    return E2BIG; > > +    } > > + > > +    w = g_new0(XsWatch, 1); > > +    w->token = g_strdup(tok

Re: [PATCH v10 00/12] parallels: Refactor the code of images checks and fix a bug

2023-03-07 Thread Hanna Czenczek
On 03.02.23 10:18, Alexander Ivanov wrote: Fix image inflation when offset in BAT is out of image. Replace whole BAT syncing by flushing only dirty blocks. Move all the checks outside the main check function in separate functions Use WITH_QEMU_LOCK_GUARD for simplier code. Fix incorrect condi

Re: [PATCH v10 07/12] parallels: Move check of cluster outside image to a separate function

2023-03-07 Thread Hanna Czenczek
On 03.02.23 10:18, Alexander Ivanov wrote: We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov Reviewed-by: Denis V. Lunev --- block/parallels.c | 81 ++

Re: [PATCH v5 1/4] linux-aio: use LinuxAioState from the running thread

2023-03-07 Thread Kevin Wolf
Am 07.03.2023 um 11:58 hat Paolo Bonzini geschrieben: > On 3/7/23 09:48, Kevin Wolf wrote: > > You mean we have a device that has a separate iothread, but a request is > > submitted from the main thread? This isn't even allowed today; if a node > > is in an iothread, all I/O must be submitted from

Re: [PATCH v10 09/12] parallels: Move check of leaks to a separate function

2023-03-07 Thread Hanna Czenczek
On 03.02.23 10:18, Alexander Ivanov wrote: We will add more and more checks so we need a better code structure in parallels_co_check. Let each check performs in a separate loop in a separate helper. Signed-off-by: Alexander Ivanov --- block/parallels.c | 80 ---

Re: [PATCH v4 08/14] vfio/common: Record DMA mapped IOVA ranges

2023-03-07 Thread Joao Martins
On 07/03/2023 10:16, Joao Martins wrote: > On 07/03/2023 02:57, Alex Williamson wrote: >> On Tue, 7 Mar 2023 02:02:52 + >> Joao Martins wrote: >> >>> According to the device DMA logging uAPI, IOVA ranges to be logged by >>> the device must be provided all at once upon DMA logging start. >>

[PATCH v2 17/18] ui/dbus: do not require opengl & gbm

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Allow to build & use the DBus display without 3d/GPU acceleration support. Signed-off-by: Marc-André Lureau --- meson.build | 2 -- ui/dbus-listener.c | 15 +-- ui/dbus.c | 8 tests/qtest/meson.build | 2 +- ui/meso

[PATCH v2 18/18] ui/dbus: restrict opengl to gbm-enabled config

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau We can enable EGL later for non-GBM hosts. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 10 +- ui/dbus.c | 12 +++- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/ui/dbus-listener.c b/ui/dbus-listener.c index 85692f

[PATCH v2 15/18] ui/sdl: try to instantiate the matching opengl renderer

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau User can still bypass the QEMU choice with SDL_RENDER_DRIVER environment variable. (for some reason, specifying a driver disables batching and breaks rendering, so enable it explicitly) Signed-off-by: Marc-André Lureau --- ui/sdl2.c | 11 +++ 1 file changed, 11

[PATCH v2 08/18] ui: keep current cursor with QemuConsole

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Keeping the current cursor around is useful, not only for VNC, but for other displays. Let's move it down, see the following patches for other usages. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 1 + ui/vnc.h | 1 - ui/console.c | 8 +

[PATCH v2 09/18] ui: set cursor upon listener registration

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/console.c b/ui/console.c index 0dccbdd4be..7b808f080e 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1662,6 +1662,9 @@ void register_displaychangelistener(Displa

[PATCH v2 14/18] ui/sdl: add optional logging when _SDL_DEBUG is set

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Apparently, there is no environment variable you can set for libsdl to enable logging. (similar to _VNC_DEBUG) Signed-off-by: Marc-André Lureau --- include/ui/sdl2.h | 2 ++ ui/sdl2.c | 4 2 files changed, 6 insertions(+) diff --git a/include/ui/sdl2.h b/

[PATCH v2 12/18] ui/shader: fix #version directive must occur on first line

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau ANGLE fails to compile shaders otherwise. Signed-off-by: Marc-André Lureau --- ui/shader/texture-blit-flip.vert | 1 - ui/shader/texture-blit.frag | 1 - ui/shader/texture-blit.vert | 1 - 3 files changed, 3 deletions(-) diff --git a/ui/shader/texture-blit-fl

[PATCH v2 16/18] ui: introduce egl_init()

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Future patches will introduce EGL support on win32 (too late for 8.0 though). Having a common place for EGL initialization and error handling will make it simpler. Signed-off-by: Marc-André Lureau --- include/ui/egl-helpers.h | 2 ++ ui/dbus.c| 7 +

[PATCH v2 05/18] meson: ensure dbus-display generated code is built before other units

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau It's simply by luck that dbus-display header is built first before the other units using it. With sourceset, I can't find an easier way out than declaring an extra dependency for dbus-display1 generate code. Signed-off-by: Marc-André Lureau --- ui/meson.build | 6 -

[PATCH v2 02/18] ui/dbus: unregister clipboard on connection close

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Fixes unregistration with p2p connections, since they don't have an associated name owner. Signed-off-by: Marc-André Lureau --- ui/dbus-clipboard.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/ui/dbus-clipboard.c b/ui/dbus-clip

[PATCH v2 13/18] ui/egl: print EGL error, helping debugging

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/egl-helpers.c | 54 ++-- 1 file changed, 48 insertions(+), 6 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index 3a88245b67..10772b6471 100644 --- a/ui/egl-helpers.c +++

[PATCH v2 04/18] ui/dbus: set mouse is-absolute during console creation

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/dbus-console.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index 0bfaa2298d..f77bc49d2e 100644 --- a/ui/dbus-console.c +++ b/ui/dbus-console.c @@ -411,15

[PATCH v2 10/18] ui: set cursor position upon listener registration

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- ui/console.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/console.c b/ui/console.c index 7b808f080e..8fc18c44bf 100644 --- a/ui/console.c +++ b/ui/console.c @@ -95,6 +95,7 @@ struct QemuConsole { QemuUIInfo ui_in

[PATCH v2 00/18] ui: dbus & misc fixes

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Hi, This is a respin of a series I sent end of January that didn't get reviews, here is your chance! :) A collection of fixes for UI related-stuff, and paving the way for accelerated/egl dbus display support on win32 (for 8.1 hopefully). I think they are worth to include

[PATCH v2 03/18] audio/dbus: there are no sender for p2p mode

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- audio/audio_int.h | 2 +- audio/dbusaudio.c | 6 -- ui/dbus.c | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index d51d63f08d..e57ff50155 100644 --- a/audio/aud

[PATCH v2 11/18] ui/sdl: get the GL context from the window

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau There is no guarantee to have a current GL context here. The current code seems to rely on the renderer using a GL backend, and to set a current GL context. But this is not always the case, for example if the renderer backend is DirectX. This change is enough to fix using

[PATCH v2 01/18] ui/dbus: initialize cursor_fb

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau Or else, we may randomly destroy some textures.. Signed-off-by: Marc-André Lureau --- include/ui/egl-helpers.h | 2 ++ ui/dbus-listener.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/ui/egl-helpers.h b/include/ui/egl-helpers.h inde

[PATCH v2 07/18] ui: rename cursor_{get->ref}, return it

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU code, and allows to simplify some code. Signed-off-by: Marc-André Lureau --- include/ui/console.h | 2 +- ui/cursor.c | 3 ++- ui/dbus-listener.c | 3 +-- ui/spice-display.c | 4 ++-- ui/vnc.c | 3 +-- 5 f

[PATCH v2 06/18] ui: rename cursor_{put->unref}

2023-03-07 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU. Signed-off-by: Marc-André Lureau --- include/ui/console.h| 2 +- hw/display/qxl-render.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vmware_vga.c | 4 ++-- ui/cursor.c | 2 +- ui/dbus-listener.c | 2

Re: [PULL 00/16] Final tests, s390x and misc updates before the soft freeze

2023-03-07 Thread Thomas Huth
On 07/03/2023 10.57, Peter Maydell wrote: On Mon, 6 Mar 2023 at 13:30, Thomas Huth wrote: Hi Peter! The following changes since commit 2946e1af2704bf6584f57d4e3aec49d1d5f3ecc0: configure: Disable thread-safety warnings on macOS (2023-03-04 14:03:46 +) are available in the Git repo

[PULL 3/9] qemu-thread-win32: cleanup, fix, document QemuEvent

2023-03-07 Thread Paolo Bonzini
QemuEvent is currently broken on ARM due to missing memory barriers after qatomic_*(). Apart from adding the memory barrier, a closer look reveals some unpaired memory barriers that are not really needed and complicated the functions unnecessarily. Also, it is relying on a memory barrier in Reset

[PULL 6/9] qemu-coroutine-lock: add smp_mb__after_rmw()

2023-03-07 Thread Paolo Bonzini
mutex->from_push and mutex->handoff in qemu-coroutine-lock implement the familiar pattern: write a write b smp_mb() smp_mb() read b read a The memory barrier is required by the C memory mod

[PULL 2/9] qemu-thread-posix: cleanup, fix, document QemuEvent

2023-03-07 Thread Paolo Bonzini
QemuEvent is currently broken on ARM due to missing memory barriers after qatomic_*(). Apart from adding the memory barrier, a closer look reveals some unpaired memory barriers too. Document more clearly what is going on. Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off

[PULL 8/9] async: update documentation of the memory barriers

2023-03-07 Thread Paolo Bonzini
Ever since commit 8c6b0356b539 ("util/async: make bh_aio_poll() O(1)", 2020-02-22), synchronization between qemu_bh_schedule() and aio_bh_poll() is happening when the bottom half is enqueued in the bh_list; not when the flags are set. Update the documentation to match. Reviewed-by: Stefan Hajnocz

[PULL 7/9] physmem: add missing memory barrier

2023-03-07 Thread Paolo Bonzini
Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Signed-off-by: Paolo Bonzini --- softmmu/physmem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/softmmu/physmem.c b/softmmu/physmem.c index 47143edb4f6c..a6efd8e8dd11 100644 --- a/softmmu/physmem.c +++ b/softmmu/physmem.c @

<    1   2   3   4   5   6   7   8   >