Re: [PULL 4/5] contrib/gitdm: Add Facebook the domain map

2023-03-10 Thread Peter Delevoryas
> On Mar 10, 2023, at 7:57 AM, Alex Bennée wrote: > > A number of Facebook developers contribute to the project. Peter can > you confirm your want pjd.dev contributions counted here or as > an individual contributor? I want them counted as Facebook, for now. If I leave Facebook I’ll send an

Re: [PULL 3/5] contrib/gitdm: add Tsukasa as an individual contributor

2023-03-10 Thread Tsukasa OI
On 2023/03/11 0:57, Alex Bennée wrote: > I wasn't sure if you want to be added as an individual contributor or > an academic so please confirm. Individual. > > Signed-off-by: Alex Bennée > Acked-by: Tsukasa OI > Message-Id: <20221219121914.851488-7-alex.ben...@linaro.org> > > diff --git

Re: [PATCH nbd 1/4] nbd: Add multi-conn option

2023-03-10 Thread Richard W.M. Jones
On Fri, Mar 10, 2023 at 04:17:17PM -0600, Eric Blake wrote: > On Thu, Mar 09, 2023 at 11:39:43AM +, Richard W.M. Jones wrote: > > + * safe for multi-conn, force it to 1. > > + */ > > +if (!(s->info.flags & NBD_FLAG_CAN_MULTI_CONN)) { > > +s->multi_conn = 1; > > +} > > +

Re: [PULL 00/73] virtio,pc,pci: features, fixes

2023-03-10 Thread Philippe Mathieu-Daudé
Hi, On 10/3/23 18:32, Peter Maydell wrote: On Thu, 9 Mar 2023 at 14:47, Michael S. Tsirkin wrote: I moved it one commit back, now at (96cb085897) Cornelia posted some concerns about the last commit. virtio,pc,pci: features,

Re: [PATCH nbd 1/4] nbd: Add multi-conn option

2023-03-10 Thread Eric Blake
On Thu, Mar 09, 2023 at 11:39:43AM +, Richard W.M. Jones wrote: > Add multi-conn option to the NBD client. This commit just adds the > option, it is not functional. Maybe add the phrase "until later in this patch series" ? > > Setting this to a value > 1 permits multiple connections to the

[PULL 22/28] linux-user/sparc: Handle priviledged opcode trap

2023-03-10 Thread Laurent Vivier
From: Richard Henderson For the most part priviledged opcodes are ifdefed out of the user-only sparc translator, which will then incorrectly produce illegal opcode traps. But there are some code paths that properly raise TT_PRIV_INSN, so we must handle it. Signed-off-by: Richard Henderson

[PULL 16/28] linux-user/sparc: Use TT_TRAP for flush windows

2023-03-10 Thread Laurent Vivier
From: Richard Henderson The v9 and pre-v9 code can be unified with this macro. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230216054516.1267305-5-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/cpu_loop.c | 7 +++

[PULL 09/28] linux-user: Add strace for prlimit64() syscall

2023-03-10 Thread Laurent Vivier
From: Helge Deller Add proper prlimit64() strace output. Signed-off-by: Helge Deller Reviewed-by: Laurent Vivier Message-Id: <20221222190639.124078-1-del...@gmx.de> [lvivier: use print_raw_param64()] Signed-off-by: Laurent Vivier --- linux-user/strace.c| 88

[PULL 24/28] linux-user/sparc: Handle coprocessor disabled trap

2023-03-10 Thread Laurent Vivier
From: Richard Henderson Since qemu does not implement a sparc coprocessor, all such instructions raise this trap. Because of that, we never raise the coprocessor exception trap, which would be vector 0x28. Signed-off-by: Richard Henderson Message-Id:

[PULL 19/28] linux-user/sparc: Handle software breakpoint trap

2023-03-10 Thread Laurent Vivier
From: Richard Henderson This is 'ta 1' for both v9 and pre-v9. Signed-off-by: Richard Henderson Message-Id: <20230216054516.1267305-8-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/cpu_loop.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-)

[PULL 18/28] linux-user/sparc: Fix sparc64_{get, set}_context traps

2023-03-10 Thread Laurent Vivier
From: Richard Henderson These traps are present for sparc64 with ilp32, aka sparc32plus. Enabling them means adjusting the defines over in signal.c, and fixing an incorrect usage of abi_ulong when we really meant the full register, target_ulong. Signed-off-by: Richard Henderson Message-Id:

[PULL 26/28] linux-user/sparc: Handle floating-point exceptions

2023-03-10 Thread Laurent Vivier
From: Richard Henderson Raise SIGFPE for ieee exceptions. The other types, such as FSR_FTT_UNIMPFPOP, should not appear, because we enable normal emulation of missing insns at the start of sparc_cpu_realizefn(). Signed-off-by: Richard Henderson Message-Id:

[PULL 04/28] linux-user: Fix unaligned memory access in prlimit64 syscall

2023-03-10 Thread Laurent Vivier
From: Ilya Leoshkevich target_rlimit64 contains uint64_t fields, so it's 8-byte aligned on some hosts, while some guests may align their respective type on a 4-byte boundary. This may lead to an unaligned access, which is an UB. Fix by defining the fields as abi_ullong. This makes the host

[PULL 27/28] linux-user/sparc: Handle tag overflow traps

2023-03-10 Thread Laurent Vivier
From: Richard Henderson This trap is raised by taddcctv and tsubcctv insns. Signed-off-by: Richard Henderson Message-Id: <20230216054516.1267305-16-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/cpu_loop.c | 3 +++ linux-user/sparc/target_signal.h | 2

[PULL 23/28] linux-user/sparc: Handle privilidged action trap

2023-03-10 Thread Laurent Vivier
From: Richard Henderson This is raised by using an %asi < 0x80 in user-mode. Signed-off-by: Richard Henderson Message-Id: <20230216054516.1267305-12-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/cpu_loop.c | 6 ++ 1 file changed, 6 insertions(+) diff

[PULL 15/28] linux-user/sparc: Tidy syscall error return

2023-03-10 Thread Laurent Vivier
From: Richard Henderson Reduce ifdefs with #define syscall_cc. Signed-off-by: Richard Henderson Message-Id: <20230216054516.1267305-4-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/cpu_loop.c | 15 +-- 1 file changed, 5 insertions(+), 10

[PULL 25/28] linux-user/sparc: Handle unimplemented flush trap

2023-03-10 Thread Laurent Vivier
From: Richard Henderson For sparc64, TT_UNIMP_FLUSH == TT_ILL_INSN, so this is already handled. For sparc32, the kernel uses SKIP_TRAP. Signed-off-by: Richard Henderson Message-Id: <20230216054516.1267305-14-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 14/28] linux-user/sparc: Tidy syscall trap

2023-03-10 Thread Laurent Vivier
From: Richard Henderson Use TT_TRAP. For sparc32, 0x88 is the "Slowaris" system call, currently BAD_TRAP in the kernel's ttable_32.S. For sparc64, 0x110 is tl0_linux32, the sparc32 trap, now folded into the TARGET_ABI32 case via TT_TRAP. For sparc64, there does still exist trap 0x111 as

[PULL 07/28] linux-user: Fix brk() to release pages

2023-03-10 Thread Laurent Vivier
From: Helge Deller The current brk() implementation does not de-allocate pages if a lower address is given compared to earlier brk() calls. But according to the manpage, brk() shall deallocate memory in this case and currently it breaks a real-world application, specifically building the debian

[PULL 17/28] linux-user/sparc: Tidy window spill/fill traps

2023-03-10 Thread Laurent Vivier
From: Richard Henderson Add some macros to localize the hw difference between v9 and pre-v9. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230216054516.1267305-6-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier --- linux-user/sparc/cpu_loop.c

[PULL 08/28] linux-user: Provide print_raw_param64() for 64-bit values

2023-03-10 Thread Laurent Vivier
From: Helge Deller Add a new function print_raw_param64() to print 64-bit values in the same way as print_raw_param(). This prevents that qemu_log() is used to work around the problem that print_raw_param() can only print 32-bit values when compiled for 32-bit targets. Additionally convert the

[PULL 12/28] linux-user: Add translation for argument of msync()

2023-03-10 Thread Laurent Vivier
From: Helge Deller msync() uses the flags MS_ASYNC, MS_INVALIDATE and MS_SYNC, which differ between platforms, specifcally on alpha and hppa. Add a target to host translation for those and wire up a nicer strace output. This fixes the testsuite of the macaulay2 debian package with a hppa-linux

[PULL 21/28] linux-user/sparc: Handle getcc, setcc, getpsr traps

2023-03-10 Thread Laurent Vivier
From: Richard Henderson These are really only meaningful for sparc32, but they're still present for backward compatibility for sparc64. Signed-off-by: Richard Henderson Message-Id: <20230216054516.1267305-10-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 11/28] linux-user: handle netlink flag NLA_F_NESTED

2023-03-10 Thread Laurent Vivier
From: Mathis Marion Newer kernel versions require this flag to be present contrary to older ones. Depending on the libnl version it is added or not. Typically when using rtnl_link_inet6_set_addr_gen_mode, the netlink packet generated may contain the following attribute: with libnl 3.4

[PULL 00/28] Linux user for 8.0 patches

2023-03-10 Thread Laurent Vivier
The following changes since commit 817fd33836e73812df2f1907612b57750fcb9491: Merge tag 'audio-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-03-06 14:06:06 +) are available in the Git repository at: https://gitlab.com/laurent_vivier/qemu.git

[PULL 20/28] linux-user/sparc: Handle division by zero traps

2023-03-10 Thread Laurent Vivier
From: Richard Henderson In addition to the hw trap vector, there is a software trap assigned for older sparc without hw division instructions. Signed-off-by: Richard Henderson Message-Id: <20230216054516.1267305-9-richard.hender...@linaro.org> Signed-off-by: Laurent Vivier ---

[PULL 05/28] linux-user: add support for xtensa FDPIC

2023-03-10 Thread Laurent Vivier
From: Max Filippov Define xtensa-specific info_is_fdpic and fill in FDPIC-specific registers in the xtensa version of init_thread. Signed-off-by: Max Filippov Message-Id: <20230205061230.544451-1-jcmvb...@gmail.com> Signed-off-by: Laurent Vivier --- include/elf.h| 1 +

[PULL 06/28] linux-user: fill out task state in /proc/self/stat

2023-03-10 Thread Laurent Vivier
From: Andreas Schwab Some programs want to match an actual task state character. Signed-off-by: Andreas Schwab Reviewed-by: Laurent Vivier Message-Id: Signed-off-by: Laurent Vivier --- linux-user/syscall.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/linux-user/syscall.c

[PULL 01/28] linux-user: Fix access to /proc/self/exe

2023-03-10 Thread Laurent Vivier
From: Helge Deller When accsssing /proc/self/exe from a userspace program, linux-user tries to resolve the name via realpath(), which may fail if the process changed the working directory in the meantime. An example: - a userspace program ist started with ./testprogram - the program runs

[PULL 28/28] linux-user: fix bug about incorrect base addresss of gdt on i386 and x86_64

2023-03-10 Thread Laurent Vivier
From: "fa...@mail.ustc.edu.cn" On linux user mode, CPUX86State::gdt::base from Different CPUX86State Objects have same value, It is incorrect! Every CPUX86State::gdt::base Must points to independent memory space. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1405 Signed-off-by:

[PULL 10/28] linux-user: fix sockaddr_in6 endianness

2023-03-10 Thread Laurent Vivier
From: Mathis Marion The sin6_scope_id field uses the host byte order, so there is a conversion to be made when host and target endianness differ. Signed-off-by: Mathis Marion Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PULL 02/28] linux-user: fix timerfd read endianness conversion

2023-03-10 Thread Laurent Vivier
From: Mathis Marion When reading the expiration count from a timerfd, the endianness of the 64bit value read is the one of the host, just as for eventfds. Signed-off-by: Mathis Marion Reviewed-by: Laurent Vivier Message-Id: <20230220085822.626798-2-mathis.mar...@silabs.com> Signed-off-by:

[PULL 03/28] linux-user: add target to host netlink conversions

2023-03-10 Thread Laurent Vivier
From: Mathis Marion Added conversions for: - IFLA_MTU - IFLA_TXQLEN - IFLA_AF_SPEC AF_INET6 IFLA_INET6_ADDR_GEN_MODE These relate to the libnl functions rtnl_link_set_mtu, rtnl_link_set_txqlen, and rtnl_link_inet6_set_addr_gen_mode. Signed-off-by: Mathis Marion Reviewed-by: Philippe

[PULL 13/28] linux-user: Emulate CLONE_PIDFD flag in clone()

2023-03-10 Thread Laurent Vivier
From: Helge Deller Add emulation for the CLONE_PIDFD flag of the clone() syscall. This flag was added in Linux kernel 5.2. Successfully tested on a x86-64 Linux host with hppa-linux target. Can be verified by running the testsuite of the qcoro debian package, which breaks hard and kills the

Re: [PATCH v2 7/7] include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

2023-03-10 Thread Philippe Mathieu-Daudé
On 10/3/23 20:52, Richard Henderson wrote: Now that we've broken the include loop with cpu.h, we can bring this inline. Signed-off-by: Richard Henderson --- include/qemu/plugin.h | 6 +- plugins/core.c| 11 --- 2 files changed, 5 insertions(+), 12 deletions(-)

Re: [PATCH v2 6/7] include/qemu: Split out plugin-event.h

2023-03-10 Thread Philippe Mathieu-Daudé
On 10/3/23 20:52, Richard Henderson wrote: The usage in hw/core/cpu.h only requires QEMU_PLUGIN_EV_MAX. Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 2 +- include/qemu/plugin-event.h | 26 ++ include/qemu/plugin.h | 17 +

Re: [PATCH v2 5/7] *: Add missing includes of qemu/plugin.h

2023-03-10 Thread Philippe Mathieu-Daudé
On 10/3/23 20:52, Richard Henderson wrote: This had been pulled in from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec-common.c | 1 + cpu.c | 1 + linux-user/exit.c | 1 + linux-user/syscall.c| 1 +

Re: [PATCH v2 4/7] *: Add missing includes of qemu/error-report.h

2023-03-10 Thread Philippe Mathieu-Daudé
On 10/3/23 20:52, Richard Henderson wrote: This had been pulled in via qemu/plugin.h from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson --- accel/accel-softmmu.c | 2 +- block/monitor/block-hmp-cmds.c | 1 + dump/dump.c| 1 +

Re: [PATCH v2 05/10] contrib/gitdm: Add SYRMIA to the domain map

2023-03-10 Thread Philippe Mathieu-Daudé
On 10/3/23 19:03, Alex Bennée wrote: The company website lists QEMU amongst the things they work on so I assume these are corporate contributions. Signed-off-by: Alex Bennée Cc: Milica Lazarevic --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe

Re: [PATCH v2 06/10] contrib/gitdm: add Amazon to the domain map

2023-03-10 Thread Philippe Mathieu-Daudé
On 10/3/23 19:03, Alex Bennée wrote: We have multiple contributors from both .co.uk and .com versions of the address. Signed-off-by: Alex Bennée Cc: Alexander Graf Cc: Paul Durrant Cc: David Wooodhouse --- contrib/gitdm/domain-map | 2 ++ 1 file changed, 2 insertions(+) Reviewed-by:

Re: [PATCH v2 08/10] contrib/gitdm: add revng to domain map

2023-03-10 Thread Alessandro Di Federico via
On Fri, 10 Mar 2023 18:03:30 + Alex Bennée wrote: > +rev.ng revng Please use "rev.ng Labs". Thanks! Reviewed-by: Alessandro Di Federico -- Alessandro Di Federico rev.ng Labs

Re: [PULL 3/3] edk2: update firmware binaries

2023-03-10 Thread Simon Glass
Hi Gerd, On Thu, 9 Mar 2023 at 22:38, Gerd Hoffmann wrote: > > On Thu, Mar 09, 2023 at 02:09:30PM -0800, Simon Glass wrote: > > Hi Gerd, > > > > Where did these binaries come from? What commit and how were they built? > > See patch 1/3 for the source (edk2 submodule) update and patch 2/3 for >

Re: [RFC PATCH] intel-iommu: Report interrupt remapping faults

2023-03-10 Thread Peter Xu
On Fri, Mar 10, 2023 at 05:49:38PM +, David Woodhouse wrote: > From: David Woodhouse > > There is more work to be done here, as pretranslations for the KVM IRQ > routing table can't fault yet; they should be handled in userspace and > the fault raised only when the IRQ actually happens (if

Re: [PATCH] hw/intc/ioapic: Update KVM routes before redelivering IRQ, on RTE update

2023-03-10 Thread Peter Xu
On Fri, Mar 10, 2023 at 05:52:57PM +, David Woodhouse wrote: > On Thu, 2023-03-09 at 11:55 -0500, Peter Xu wrote: > > > > There're four devices that can hook onto this, IIUC.  Besides IOAPIC and > > VFIO, there's also ivshmem and vhost.  IIUC we'll need to change all the > > four devices to

Re: [PATCH 01/12] target/s390x: Handle branching to odd addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 11:34, Ilya Leoshkevich wrote: On Fri, 2023-03-10 at 11:24 -0800, Richard Henderson wrote: On 3/10/23 09:42, Ilya Leoshkevich wrote: @@ -381,6 +382,14 @@ static inline int cpu_mmu_index(CPUS390XState *env, bool ifetch)   static inline void cpu_get_tb_cpu_state(CPUS390XState* env,

[PATCH v2 4/7] *: Add missing includes of qemu/error-report.h

2023-03-10 Thread Richard Henderson
This had been pulled in via qemu/plugin.h from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson --- accel/accel-softmmu.c | 2 +- block/monitor/block-hmp-cmds.c | 1 + dump/dump.c| 1 + dump/win_dump.c| 1 + hw/arm/collie.c

[PATCH v2 5/7] *: Add missing includes of qemu/plugin.h

2023-03-10 Thread Richard Henderson
This had been pulled in from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec-common.c | 1 + cpu.c | 1 + linux-user/exit.c | 1 + linux-user/syscall.c| 1 + 4 files changed, 4 insertions(+) diff --git

[PATCH v2 2/7] tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb

2023-03-10 Thread Richard Henderson
Now that we call qemu_plugin_disable_mem_helpers in cpu_tb_exec, we don't need to do this in generated code as well. Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tcg/tcg-op.c b/tcg/tcg-op.c index 77658a88f0..cc8fdb0e46 100644 ---

[PATCH v2 7/7] include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

2023-03-10 Thread Richard Henderson
Now that we've broken the include loop with cpu.h, we can bring this inline. Signed-off-by: Richard Henderson --- include/qemu/plugin.h | 6 +- plugins/core.c| 11 --- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/include/qemu/plugin.h

[PATCH v2 0/7] plugin: fix clearing of plugin_mem_cbs on TB exit

2023-03-10 Thread Richard Henderson
Changes for v2: * Use plugin_gen_disable_mem_helpers, * Remove plugin_gen_disable_mem_helpers from tcg_gen_exit_tb. * Break include loop with hw/core/cpu.h and qemu/plugins.h. * Inline plugin_gen_disable_mem_helpers. r~ Richard Henderson (7): tcg: Clear plugin_mem_cbs on TB exit

[PATCH v2 6/7] include/qemu: Split out plugin-event.h

2023-03-10 Thread Richard Henderson
The usage in hw/core/cpu.h only requires QEMU_PLUGIN_EV_MAX. Signed-off-by: Richard Henderson --- include/hw/core/cpu.h | 2 +- include/qemu/plugin-event.h | 26 ++ include/qemu/plugin.h | 17 + 3 files changed, 28 insertions(+), 17

[PATCH v2 1/7] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Richard Henderson
Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception), adjacent to where we reset can_do_io. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381 Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec-common.c | 2 ++ accel/tcg/cpu-exec.c| 5 + 2 files changed,

[PATCH v2 3/7] include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT

2023-03-10 Thread Richard Henderson
This macro is no longer used. Signed-off-by: Richard Henderson --- include/qemu/plugin.h | 4 1 file changed, 4 deletions(-) diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index fb338ba576..e0ebedef84 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -59,8

Re: [PATCH 11/12] target/s390x: Update do_unaligned_access() comment

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Relative long instructions now depend on do_unaligned_access() too. Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/excp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH 01/12] target/s390x: Handle branching to odd addresses

2023-03-10 Thread Ilya Leoshkevich
On Fri, 2023-03-10 at 11:24 -0800, Richard Henderson wrote: > On 3/10/23 09:42, Ilya Leoshkevich wrote: > > @@ -381,6 +382,14 @@ static inline int cpu_mmu_index(CPUS390XState > > *env, bool ifetch) > >   static inline void cpu_get_tb_cpu_state(CPUS390XState* env, > > target_ulong *pc, > >  

Re: [PATCH 10/12] target/s390x: Handle STGRL to non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_8 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 8

Re: [PATCH 09/12] target/s390x: Handle STRL to non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_4 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 12 ++--

Re: [PATCH 08/12] target/s390x: Handle CLRL and CLGFRL with non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_4 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2

Re: [PATCH 07/12] target/s390x: Handle CGRL and CLGRL with non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_8 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2

Re: [PATCH 06/12] target/s390x: Handle CRL and CGFRL with non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_4 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2

Re: [PATCH 02/12] target/s390x: Handle EXECUTE of odd addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Generate a specification exception in the helper before trying to fetch the instruction. Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/mem_helper.c | 12 ++-- 1 file changed, 10 insertions(+), 2

Re: [PATCH 04/12] target/s390x: Handle LRL and LGFRL from non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_4 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 14 +++---

Re: [PATCH 05/12] target/s390x: Handle LLGFRL from non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_4 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 6 +++---

Re: [PATCH 03/12] target/s390x: Handle LGRL from non-aligned addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: Use MO_ALIGN_8 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 6 +++---

Re: [PATCH 01/12] target/s390x: Handle branching to odd addresses

2023-03-10 Thread Richard Henderson
On 3/10/23 09:42, Ilya Leoshkevich wrote: @@ -381,6 +382,14 @@ static inline int cpu_mmu_index(CPUS390XState *env, bool ifetch) static inline void cpu_get_tb_cpu_state(CPUS390XState* env, target_ulong *pc, target_ulong *cs_base, uint32_t *flags) {

RE: [PATCH v2] TCG plugin API extension to read guest memory content by an address

2023-03-10 Thread Mikhail Tyutin
> > Do you mean concurrent access to the same memory block by multiple > > threads? > > Yes - although we also see MMU changes updating a mapping for a given > vaddr -> phys address. > > > > > I think , for guest threads/cores if we observe mismatch of memory content > > read by a plugin and

Re: [PATCH nbd 0/4] Enable multi-conn NBD [for discussion only]

2023-03-10 Thread Richard W.M. Jones
On Fri, Mar 10, 2023 at 01:04:12PM -0600, Eric Blake wrote: > How many of these timing numbers can be repeated with TLS in the mix? While I have been playing with TLS and kTLS recently, it's not something that is especially important to v2v since all NBD traffic goes over Unix domain sockets only

Re: [PATCH nbd 0/4] Enable multi-conn NBD [for discussion only]

2023-03-10 Thread Eric Blake
On Thu, Mar 09, 2023 at 11:39:42AM +, Richard W.M. Jones wrote: > [ Patch series also available here, along with this cover letter and the > script used to generate test results: > https://gitlab.com/rwmjones/qemu/-/commits/2023-nbd-multi-conn-v1 ] > > This patch series adds multi-conn

[PATCH v2] Fix incorrect register name in disassembler for fmv,fabs,fneg instructions

2023-03-10 Thread Mikhail Tyutin
Fix incorrect register name in RISC-V disassembler for fmv,fabs,fneg instructions Signed-off-by: Mikhail Tyutin Reviewed-by: Alistair Francis --- disas/riscv.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/disas/riscv.c b/disas/riscv.c index

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-10 Thread Alex Bennée
(adding some more gdb types to CC) Fabiano Rosas writes: > Peter Maydell writes: > >> On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: >>> >>> You need a very new gdb to be able to run with pauth support otherwise >>> your likely to hit asserts and aborts. Disable pauth for now until we >>>

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-10 Thread Fabiano Rosas
Peter Maydell writes: > On Fri, 10 Mar 2023 at 18:00, Fabiano Rosas wrote: >> >> Peter Maydell writes: >> >> > On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: >> >> >> >> You need a very new gdb to be able to run with pauth support otherwise >> >> your likely to hit asserts and aborts.

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-10 Thread Richard Henderson
On 3/10/23 09:47, Peter Maydell wrote: On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: You need a very new gdb to be able to run with pauth support otherwise your likely to hit asserts and aborts. Disable pauth for now until we can properly probe support in gdb. Signed-off-by: Alex Bennée

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-10 Thread Peter Maydell
On Fri, 10 Mar 2023 at 18:00, Fabiano Rosas wrote: > > Peter Maydell writes: > > > On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: > >> > >> You need a very new gdb to be able to run with pauth support otherwise > >> your likely to hit asserts and aborts. Disable pauth for now until we > >>

Re: [PATCH v2 01/10] contrib/gitdm: Add Rivos Inc to the domain map

2023-03-10 Thread Palmer Dabbelt
On Fri, 10 Mar 2023 10:03:23 PST (-0800), alex.ben...@linaro.org wrote: Whatever they are up to a number of people for the company are contributing to QEMU so lets group them together. Signed-off-by: Alex Bennée Cc: Atish Patra Cc: Dao Lu Cc: Andrew Bresticker Cc: Palmer Dabbelt Cc: Vineet

[PATCH v2 03/10] contrib/gitdm: Add ASPEED Technology to the domain map

2023-03-10 Thread Alex Bennée
We have a number of contributors from this domain which looks like it is a corporate endeavour. Signed-off-by: Alex Bennée Cc: Steven Lee Cc: Troy Lee Cc: Howard Chiu Cc: Jamin Lin --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map

[PATCH v2 10/10] contrib/gitdm: add group map for AMD

2023-03-10 Thread Alex Bennée
AMD recently acquired Xilinx and contributors have been transitioning their emails across. Signed-off-by: Alex Bennée Cc: Vikram Garhwal Cc: Francisco Iglesias Cc: Stefano Stabellini Cc: Sai Pavan Boddu Cc: Tong Ho --- contrib/gitdm/domain-map| 1 - contrib/gitdm/group-map-amd | 8

[PATCH v2 01/10] contrib/gitdm: Add Rivos Inc to the domain map

2023-03-10 Thread Alex Bennée
Whatever they are up to a number of people for the company are contributing to QEMU so lets group them together. Signed-off-by: Alex Bennée Cc: Atish Patra Cc: Dao Lu Cc: Andrew Bresticker Cc: Palmer Dabbelt Cc: Vineet Gupta --- contrib/gitdm/domain-map | 1 + 1 file changed, 1

[PATCH v2 05/10] contrib/gitdm: Add SYRMIA to the domain map

2023-03-10 Thread Alex Bennée
The company website lists QEMU amongst the things they work on so I assume these are corporate contributions. Signed-off-by: Alex Bennée Cc: Milica Lazarevic --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map b/contrib/gitdm/domain-map

[PATCH v2 04/10] contrib/gitdm: add a group map for Google

2023-03-10 Thread Alex Bennée
Long standing community contributors often use their upstream email addresses when working on project. Signed-off-by: Alex Bennée Cc: Marc Zyngier --- contrib/gitdm/group-map-google | 5 + gitdm.config | 1 + 2 files changed, 6 insertions(+) create mode 100644

[PATCH v2 07/10] contrib/gitdm: add Alibaba to the domain-map

2023-03-10 Thread Alex Bennée
This replaces the previous attempt to add c-sky.com so I've dropped the review/ack tags. Group everything under Alibaba now. Added as requested by LIU Zhiwei. Signed-off-by: Alex Bennée Cc: LIU Zhiwei Cc: Xuan Zhuo Cc: Guo Ren --- contrib/gitdm/domain-map| 1 +

[PATCH v2 02/10] contrib/gitdm: add a group map for SiFive

2023-03-10 Thread Alex Bennée
Some SiFive contributors use there personal emails. Add a group map for those developers. Please confirm. Signed-off-by: Alex Bennée Cc: eopXD --- contrib/gitdm/group-map-sifive | 5 + gitdm.config | 1 + 2 files changed, 6 insertions(+) create mode 100644

[PATCH v2 09/10] contrib/gitdm: add more individual contributors

2023-03-10 Thread Alex Bennée
I'll only add names explicitly acked here. Let me know if you want contributions mapped to a company instead. Signed-off-by: Alex Bennée Cc: Bernhard Beschow Cc: Amarjargal Gundjalam Cc: Bin Meng Cc: Jason A. Donenfeld Cc: Strahinja Jankovic --- contrib/gitdm/group-map-individuals | 5

[PATCH v2 08/10] contrib/gitdm: add revng to domain map

2023-03-10 Thread Alex Bennée
Not sure what the correct style should be, please advise. Signed-off-by: Alex Bennée Cc: Anton Johansson Cc: Alessandro Di Federico Cc: Niccolò Izzo Cc: Paolo Montesel --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map

[PATCH v2 06/10] contrib/gitdm: add Amazon to the domain map

2023-03-10 Thread Alex Bennée
We have multiple contributors from both .co.uk and .com versions of the address. Signed-off-by: Alex Bennée Cc: Alexander Graf Cc: Paul Durrant Cc: David Wooodhouse --- contrib/gitdm/domain-map | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/gitdm/domain-map

[PATCH v2 00/10] gitdm metadata updates

2023-03-10 Thread Alex Bennée
Hi, I've sent a PR with the acked names so this series contains those that didn't respond as well as some updates from the new year. The c-sky situation is a little confused but I saw t-head was part of Alibaba so have wrapped them all up there. Do let me know if you want different mappings.

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-10 Thread Fabiano Rosas
Peter Maydell writes: > On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: >> >> You need a very new gdb to be able to run with pauth support otherwise >> your likely to hit asserts and aborts. Disable pauth for now until we >> can properly probe support in gdb. >> >> Signed-off-by: Alex Bennée

Re: [PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Richard Henderson
On 3/10/23 09:56, Alex Bennée wrote: Richard Henderson writes: On 3/10/23 09:39, Richard Henderson wrote: +    /* Undo any setting in generated code. */ +    plugin_gen_disable_mem_helpers(); Oh! And this is the wrong function. Should be qemu_plugin_disable_mem_helpers. Did I miss a

[PULL 3/3] qed: remove spurious BDRV_POLL_WHILE()

2023-03-10 Thread Kevin Wolf
From: Stefan Hajnoczi This looks like a copy-paste or merge error. BDRV_POLL_WHILE() is already called above. It's not needed in the qemu_in_coroutine() case. Fixes: 9fb4dfc570ce ("qed: make bdrv_qed_do_open a coroutine_fn") Signed-off-by: Stefan Hajnoczi Message-Id:

Re: [PATCH 07/11] tcg: Clear plugin_mem_cbs on TB exit

2023-03-10 Thread Alex Bennée
Richard Henderson writes: > On 3/10/23 09:39, Richard Henderson wrote: >> +    /* Undo any setting in generated code. */ >> +    plugin_gen_disable_mem_helpers(); > > Oh! And this is the wrong function. Should be > qemu_plugin_disable_mem_helpers. Did I miss a newer version of the patches?

[PULL 1/3] block/fuse: Let PUNCH_HOLE write zeroes

2023-03-10 Thread Kevin Wolf
From: Hanna Czenczek fallocate(2) says about PUNCH_HOLE: "After a successful call, subsequent reads from this range will return zeros." As it is, PUNCH_HOLE is implemented as a call to blk_pdiscard(), which does not guarantee this. We must call blk_pwrite_zeroes() instead. The difference to

[PULL 2/3] iotests/308: Add test for 'write -zu'

2023-03-10 Thread Kevin Wolf
From: Hanna Czenczek Try writing zeroes to a FUSE export while allowing the area to be unmapped; block/file-posix.c generally implements writing zeroes with BDRV_REQ_MAY_UNMAP ('write -zu') by calling fallocate(PUNCH_HOLE). This used to lead to a blk_pdiscard() in the FUSE export, which may or

[PULL 0/3] Block layer patches

2023-03-10 Thread Kevin Wolf
The following changes since commit ee59483267de29056b5b2ee2421ef3844e5c9932: Merge tag 'qemu-openbios-20230307' of https://github.com/mcayland/qemu into staging (2023-03-09 16:55:03 +) are available in the Git repository at: https://repo.or.cz/qemu/kevin.git tags/for-upstream for you

Re: [PATCH] hw/intc/ioapic: Update KVM routes before redelivering IRQ, on RTE update

2023-03-10 Thread David Woodhouse
On Thu, 2023-03-09 at 11:55 -0500, Peter Xu wrote: > > There're four devices that can hook onto this, IIUC.  Besides IOAPIC and > VFIO, there's also ivshmem and vhost.  IIUC we'll need to change all the > four devices to implement this. If you grep for kvm_irqchip_add_irqfd_notifier() there are

[RFC PATCH] intel-iommu: Report interrupt remapping faults

2023-03-10 Thread David Woodhouse
From: David Woodhouse There is more work to be done here, as pretranslations for the KVM IRQ routing table can't fault yet; they should be handled in userspace and the fault raised only when the IRQ actually happens (if indeed the IRTE is still not valid at that time). But we can work on that

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-10 Thread Peter Maydell
On Fri, 10 Mar 2023 at 10:31, Alex Bennée wrote: > > You need a very new gdb to be able to run with pauth support otherwise > your likely to hit asserts and aborts. Disable pauth for now until we > can properly probe support in gdb. > > Signed-off-by: Alex Bennée If it makes gdb fall over, then

Re: [PATCH nbd 0/4] Enable multi-conn NBD [for discussion only]

2023-03-10 Thread Vladimir Sementsov-Ogievskiy
On 09.03.23 14:39, Richard W.M. Jones wrote: [ Patch series also available here, along with this cover letter and the script used to generate test results: https://gitlab.com/rwmjones/qemu/-/commits/2023-nbd-multi-conn-v1 ] This patch series adds multi-conn support to the NBD block

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-10 Thread Richard Henderson
On 3/10/23 02:31, Alex Bennée wrote: You need a very new gdb to be able to run with pauth support otherwise your likely to hit asserts and aborts. Disable pauth for now until we can properly probe support in gdb. Signed-off-by: Alex Bennée --- tests/tcg/aarch64/Makefile.target | 2 ++ 1

[PATCH 06/12] target/s390x: Handle CRL and CGFRL with non-aligned addresses

2023-03-10 Thread Ilya Leoshkevich
Use MO_ALIGN_4 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 07/12] target/s390x: Handle CGRL and CLGRL with non-aligned addresses

2023-03-10 Thread Ilya Leoshkevich
Use MO_ALIGN_8 and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 02/12] target/s390x: Handle EXECUTE of odd addresses

2023-03-10 Thread Ilya Leoshkevich
Generate a specification exception in the helper before trying to fetch the instruction. Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/mem_helper.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git

  1   2   3   4   >