Re: [PATCH v4 1/6] hw/cxl: rename mailbox return code type from ret_code to CXLRetCode

2023-03-13 Thread Philippe Mathieu-Daudé
On 3/3/23 16:09, Jonathan Cameron wrote: Given the increasing usage of this mailbox return code type, now is a good time to switch to QEMU style naming. Reviewed-by: Ira Weiny Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- v8: Picked up tag from Fan Ni ---

Re: [PATCH 4/4] target/riscv: Simplify arguments for riscv_csrrw_check

2023-03-13 Thread Philippe Mathieu-Daudé
On 9/3/23 08:13, Weiwei Li wrote: Remove RISCVCPU argument, and get cfg infomation from CPURISCVState directly. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/csr.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) Reviewed-by: Philippe

Re: [PATCH 2/4] target/riscv: Simplify getting RISCVCPU pointer from env

2023-03-13 Thread Philippe Mathieu-Daudé
On 9/3/23 08:13, Weiwei Li wrote: Use env_archcpu() to get RISCVCPU pointer from env directly. Signed-off-by: Weiwei Li Signed-off-by: Junqiang Wang --- target/riscv/pmu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/4] target/riscv: Simplify arguments for riscv_csrrw_check

2023-03-13 Thread Alistair Francis
On Thu, Mar 9, 2023 at 5:14 PM Weiwei Li wrote: > > Remove RISCVCPU argument, and get cfg infomation from CPURISCVState > directly. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/csr.c | 12 > 1 file

Re: [PATCH 3/4] target/riscv: Simplify type conversion for CPURISCVState

2023-03-13 Thread Alistair Francis
On Thu, Mar 9, 2023 at 5:14 PM Weiwei Li wrote: > > Use CPURISCVState as argument directly in riscv_cpu_update_mip and > riscv_timer_write_timecmp, since type converts from CPURISCVState to > RISCVCPU in many caller of them and then back to CPURISCVState in them. > > Signed-off-by: Weiwei Li >

Re: [PATCH 2/4] target/riscv: Simplify getting RISCVCPU pointer from env

2023-03-13 Thread Alistair Francis
On Thu, Mar 9, 2023 at 5:14 PM Weiwei Li wrote: > > Use env_archcpu() to get RISCVCPU pointer from env directly. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/pmu.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [PATCH 1/4] target/riscv: Avoid env_archcpu() when reading RISCVCPUConfig

2023-03-13 Thread Alistair Francis
On Thu, Mar 9, 2023 at 5:14 PM Weiwei Li wrote: > > Use riscv_cpu_cfg(env) instead of env_archcpu().cfg. > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu_helper.c | 9 - > target/riscv/csr.c| 40

Re: [PATCH v2] Fix incorrect register name in disassembler for fmv,fabs,fneg instructions

2023-03-13 Thread Alistair Francis
On Sat, Mar 11, 2023 at 5:00 AM Mikhail Tyutin wrote: > > Fix incorrect register name in RISC-V disassembler for fmv,fabs,fneg > instructions > > Signed-off-by: Mikhail Tyutin > Reviewed-by: Alistair Francis Thanks! Applied to riscv-to-apply.next Alistair > --- > disas/riscv.c | 19

Re: [PATCH qemu v2] linux-user: Emulate /proc/cpuinfo output for riscv

2023-03-13 Thread Alistair Francis
On Tue, Mar 14, 2023 at 6:28 AM ~abordado wrote: > > From: Afonso Bordado > > RISC-V does not expose all extensions via hwcaps, thus some userspace > applications may want to query these via /proc/cpuinfo. > > Currently when querying this file the host's file is shown instead > which is slightly

[PATCH v2 0/2] pci: slot_reserved_mask improvements

2023-03-13 Thread Chuck Zmudzinski
This patch series consists of two patches. The first provides accessor functions in pci.h to avoid direct access of slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h. No functional change is intended with this patch. The second patch allows a pci bus to be

[PATCH v2 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c

2023-03-13 Thread Chuck Zmudzinski
This patch provides accessor functions as replacements for direct access to slot_reserved_mask according to the comment at the top of include/hw/pci/pci_bus.h which advises that data structures for PCIBus should not be directly accessed but instead be accessed using accessor functions in pci.h.

[PATCH v2 2/2] pci: allow slot_reserved_mask to be ignored with manual slot assignment

2023-03-13 Thread Chuck Zmudzinski
Commit 4f67543bb8c5 ("xen/pt: reserve PCI slot 2 for Intel igd-passthru") uses slot_reserved_mask to reserve slot 2 for the Intel IGD for the xenfv machine when the guest is configured for igd-passthru. A desired extension to that commit is to allow use of the reserved slot if the administrator

Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers

2023-03-13 Thread Damien Le Moal
On 3/14/23 11:23, Dmitry Fomichev wrote: >> @@ -3339,10 +3473,27 @@ static int coroutine_fn >> raw_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op, >> len >> BDRV_SECTOR_BITS); >> ret = raw_thread_pool_submit(bs, handle_aiocb_zone_mgmt, ); >> if (ret != 0) { >>

Re: [PATCH v6 2/4] block: introduce zone append write for zoned devices

2023-03-13 Thread Dmitry Fomichev
On Fri, 2023-03-10 at 18:31 +0800, Sam Li wrote: > A zone append command is a write operation that specifies the first > logical block of a zone as the write position. When writing to a zoned > block device using zone append, the byte offset of writes is pointing > to the write pointer of that

Re: [PATCH v6 4/4] block: add some trace events for zone append

2023-03-13 Thread Dmitry Fomichev
On Fri, 2023-03-10 at 18:31 +0800, Sam Li wrote: > Signed-off-by: Sam Li Looks good, Reviewed-by: Dmitry Fomichev >  block/file-posix.c | 3 +++ >  block/trace-events | 2 ++ >  2 files changed, 5 insertions(+) > > diff --git a/block/file-posix.c b/block/file-posix.c > index

Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers

2023-03-13 Thread Dmitry Fomichev
On Fri, 2023-03-10 at 18:31 +0800, Sam Li wrote: > Since Linux doesn't have a user API to issue zone append operations to > zoned devices from user space, the file-posix driver is modified to add > zone append emulation using regular writes. To do this, the file-posix > driver tracks the wp

[PATCH] add option for a multislot usb ccid device

2023-03-13 Thread Ripke, Klaus
Signed-off-by: Klaus Ripke hw/usb/dev-smartcard-reader.c: add multi option for a multislot smartcard reader, similar to audio multi --- hw/usb/dev-smartcard-reader.c | 106 +- 1 file changed, 103 insertions(+), 3 deletions(-) diff --git

Re: [PATCH qemu v2] linux-user: Emulate /proc/cpuinfo output for riscv

2023-03-13 Thread Bin Meng
On Tue, Mar 14, 2023 at 4:29 AM ~abordado wrote: > > From: Afonso Bordado > > RISC-V does not expose all extensions via hwcaps, thus some userspace > applications may want to query these via /proc/cpuinfo. > > Currently when querying this file the host's file is shown instead > which is slightly

Re: [PATCH v2 07/10] contrib/gitdm: add Alibaba to the domain-map

2023-03-13 Thread Guo Ren
Acked-by: Guo Ren On Sat, Mar 11, 2023 at 2:03 AM Alex Bennée wrote: > > This replaces the previous attempt to add c-sky.com so I've dropped > the review/ack tags. Group everything under Alibaba now. > > Added as requested by LIU Zhiwei. > > Signed-off-by: Alex Bennée > Cc: LIU Zhiwei > Cc:

Re: [PATCH v16 7/8] block: add some trace events for new block layer APIs

2023-03-13 Thread Dmitry Fomichev
On Fri, 2023-03-10 at 18:24 +0800, Sam Li wrote: > Signed-off-by: Sam Li > Reviewed-by: Stefan Hajnoczi With one small nit below, Reviewed-by: Dmitry Fomichev > --- >  block/file-posix.c | 3 +++ >  block/trace-events | 2 ++ >  2 files changed, 5 insertions(+) > > diff --git

Re: [PATCH v16 3/8] block: add block layer APIs resembling Linux ZonedBlockDevice ioctls

2023-03-13 Thread Dmitry Fomichev
On Fri, 2023-03-10 at 18:23 +0800, Sam Li wrote: > Add zoned device option to host_device BlockDriver. It will be presented only > for zoned host block devices. By adding zone management operations to the > host_block_device BlockDriver, users can use the new block layer APIs > including Report

Re: [PATCH v16 1/8] include: add zoned device structs

2023-03-13 Thread Dmitry Fomichev
On Fri, 2023-03-10 at 18:23 +0800, Sam Li wrote: > Signed-off-by: Sam Li > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Damien Le Moal > Reviewed-by: Hannes Reinecke Looks good to me. Reviewed-by: Dmitry Fomichev > --- >  include/block/block-common.h | 43

[PATCH 1/2] target/s390x: Fix EXECUTE of relative long instructions

2023-03-13 Thread Ilya Leoshkevich
The code uses the wrong base for relative addressing: it should use the target instruction address and not the EXECUTE's address. Fix by storing the target instruction address in the new CPUS390XState member and loading it from the code generated by in2_ri2(). Reported-by: Nina

[PATCH 2/2] tests/tcg/s390x: Add ex-relative-long.c

2023-03-13 Thread Ilya Leoshkevich
Test EXECUTE and EXECUTE RELATIVE LONG with relative long instructions as targets. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target| 1 + tests/tcg/s390x/ex-relative-long.c | 149 + 2 files changed, 150 insertions(+) create mode 100644

[PATCH 0/2] Fix EXECUTE of relative long instructions

2023-03-13 Thread Ilya Leoshkevich
Hi, This series fixes EXECUTE of instructions like LARL, LGLR, etc. Currently the address calculation uses EXECUTE's address as a base, while it should be using that of the target instruction. Patch 1 fixes the issue, patch 2 adds a test. Best regards, Ilya Ilya Leoshkevich (2): target/s390x:

Re: [PULL 13/27] hw/xen: Add xenstore operations to allow redirection to internal emulation

2023-03-13 Thread Jason Andryuk
Hi, David, On Mon, Mar 13, 2023 at 4:45 AM David Woodhouse wrote: > > On Sun, 2023-03-12 at 15:19 -0400, Jason Andryuk wrote: > > > > This breaks dm_restrict=1 since the xs_open is not allowed by the > > time > > this is called. There are other evtchn errors before this as well: > > # cat

Re: [PATCH] include/blcok: fixup typos

2023-03-13 Thread Wilfred Mallawa
On Mon, 2023-03-13 at 10:01 +, Peter Maydell wrote: > On Mon, 13 Mar 2023 at 00:26, Wilfred Mallawa > wrote: > > > > From: Wilfred Mallawa > > > > Fixup a few minor typos > > Typo in patch subject line: should be 'block' :-) Ha! already sent a V2 for this :) > > > Signed-off-by: Wilfred

need help with ACPI generic port implementation for QEMU

2023-03-13 Thread Dave Jiang
I'm attempting to implement the support of ACPI "generic port" detailed in the ACPI r6.5 spec in QEMU. The spec section 5.2.16.7 details the Generi Port Affinity Structure where it ties a Device Handle to a Proximity Domain. And with section 6.2.28.4 for the HMAT table, the latency and

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-13 Thread Peter Maydell
On Mon, 13 Mar 2023 at 19:21, Richard Henderson wrote: > > On 3/13/23 04:44, Luis Machado wrote: > >> Luis: I think that rather than doing (2) with a QEMU namespace, > >> we should define a gdb namespace for this. That makes it clear > >> that this is still a gdb-upstream-sanctioned way of

Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-03-13 Thread Daniel Henrique Barboza
On 3/13/23 12:49, Anup Patel wrote: On Mon, Mar 13, 2023 at 7:49 AM Hang Xu wrote: Because the starting address of ram is not necessarily 0, the remaining free space in ram is ram_size - (start - ram_base) instead of ram_size-start. Signed-off-by: Hang Xu What happens in-case a

[PATCH] s390x/gdb: Split s390-virt.xml

2023-03-13 Thread Ilya Leoshkevich
TCG emulates ckc, cputm, last_break and prefix, and it's quite useful to have them during debugging. So move them into the new s390-virt-tcg.xml file. pp, pfault_token, pfault_select and pfault_compare are not emulated, so keep them in s390-virt.xml. Signed-off-by: Ilya Leoshkevich ---

Re: [PATCH v2 10/10] contrib/gitdm: add group map for AMD

2023-03-13 Thread Francisco Iglesias
On 2023-03-10 19:03, Alex Bennée wrote: AMD recently acquired Xilinx and contributors have been transitioning their emails across. > Signed-off-by: Alex Bennée Reviewed-by: Francisco Iglesias Cc: Vikram Garhwal Cc: Francisco Iglesias Cc: Stefano Stabellini Cc: Sai Pavan Boddu Cc:

Re: [PATCH] MAINTAINERS: Mark the Nios II CPU as orphan

2023-03-13 Thread Philippe Mathieu-Daudé
+CodeSourcery folks On 13/3/23 19:33, Thomas Huth wrote: Marek and Chris haven't been active for Nios II since years (the last time seems to have been in 2017), and we've got unhandled severe Nios II bug tickets in the bug tracker since a long time, so to avoid wrong expectations of people who

Re: [PATCH v7 0/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Philippe Mathieu-Daudé
On 13/3/23 17:18, Thomas Huth wrote:  https://gitlab.com/thuth/qemu/-/jobs/3920337136#L307 ... but I think that was pre-existing and was caused by one of Philippe's reworks, hopefully to be fixed soon ... Phillipe? Jiaxun fixed this on little-endian hosts, but this is still failing on

[PATCH qemu v2] linux-user: Emulate /proc/cpuinfo output for riscv

2023-03-13 Thread ~abordado
From: Afonso Bordado RISC-V does not expose all extensions via hwcaps, thus some userspace applications may want to query these via /proc/cpuinfo. Currently when querying this file the host's file is shown instead which is slightly confusing. Emulate a basic /proc/cpuinfo file with mmu info and

Re: [PATCH v9 05/10] target/arm: gdbstub: Guard pauth code with CONFIG_TCG

2023-03-13 Thread Richard Henderson
On 3/13/23 08:10, Fabiano Rosas wrote: We currently don't have the reading of pauth regs implemented for KVM so wrap the pauth registration with CONFIG_TCG. This avoids the build error when using --disable-tcg: libqemu-aarch64-softmmu.fa.p/target_arm_gdbstub64.c.o: in function

Re: [PATCH] DO-NOT-MERGE: pipewire sample code

2023-03-13 Thread Volker Rümelin
Am 13.03.23 um 13:28 schrieb Dorinda Bassey: Hi Volker, Thanks for the patch, I've tested the patch and it works. I don't hear the choppy audio with this option "qemu-system-x86_64 -device ich9-intel-hda -device hda-duplex,audiodev=audio0 -audiodev

[PULL v2 12/18] ui/shader: fix #version directive must occur on first line

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau ANGLE fails to compile shaders otherwise. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/shader/texture-blit-flip.vert | 1 - ui/shader/texture-blit.frag | 1 - ui/shader/texture-blit.vert | 1 - 3 files changed, 3 deletions(-) diff

[PULL v2 13/18] ui/egl: print EGL error, helping debugging

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- ui/egl-helpers.c | 54 ++-- 1 file changed, 48 insertions(+), 6 deletions(-) diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c index

[PULL v2 03/18] audio/dbus: there are no sender for p2p mode

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- audio/audio_int.h | 2 +- audio/dbusaudio.c | 7 +-- ui/dbus.c | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/audio/audio_int.h b/audio/audio_int.h index

[PULL v2 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Enable SDL logging when QEMU_ENABLE_SDL_LOGGING variable is set, as suggested by Sam Lantinga, upstream SDL maintainer. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/sdl2.c | 4 1 file changed, 4 insertions(+) diff --git a/ui/sdl2.c

[PULL v2 17/18] ui/dbus: do not require opengl & gbm

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Allow to build & use the DBus display without 3d/GPU acceleration support. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- meson.build | 4 ++-- ui/dbus-listener.c | 15 +-- ui/dbus.c | 8

[PULL v2 10/18] ui: set cursor position upon listener registration

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/console.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/ui/console.c b/ui/console.c index 35f8274aab..f3783021e5 100644 --- a/ui/console.c +++ b/ui/console.c @@ -95,6 +95,7 @@ struct

[PULL v2 11/18] ui/sdl: get the GL context from the window

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau There is no guarantee to have a current GL context here. The current code seems to rely on the renderer using a GL backend, and to set a current GL context. But this is not always the case, for example if the renderer backend is DirectX. This change is enough to fix

[PULL v2 00/18] Display patches

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 284c52eec2d0a1b9c47f06c3eee46762c5fc0915: Merge tag 'win-socket-pull-request' of https://gitlab.com/marcandre.lureau/qemu into staging (2023-03-13 13:44:17 +) are available in the Git repository at:

[PULL v2 16/18] ui: introduce egl_init()

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Future patches will introduce EGL support on win32 (too late for 8.0 though). Having a common place for EGL initialization and error handling will make it simpler. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/egl-helpers.h | 2 ++

[PULL v2 15/18] ui/sdl: try to instantiate the matching opengl renderer

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau -display sdl,gl=es didn't actually use OpenGL ES. Using OpenGL ES allows to use ANGLE, which works generally better than Windows/OEM OpenGL driver. (note: users can still bypass the QEMU choice with SDL_RENDER_DRIVER environment variable) (note: for some reason,

[PULL v2 06/18] ui: rename cursor_{put->unref}

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h| 2 +- hw/display/qxl-render.c | 4 ++-- hw/display/qxl.c| 2 +- hw/display/vmware_vga.c | 4 ++-- ui/cursor.c |

[PULL v2 18/18] ui/dbus: restrict opengl to gbm-enabled config

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau We can enable EGL later for non-GBM hosts. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/dbus-listener.c | 10 +- ui/dbus.c | 12 +++- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/ui/dbus-listener.c

[PULL v2 09/18] ui: set cursor upon listener registration

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/console.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/console.c b/ui/console.c index 0dccbdd4be..35f8274aab 100644 --- a/ui/console.c +++ b/ui/console.c @@ -1662,6 +1662,9 @@ void

[PULL v2 02/18] ui/dbus: unregister clipboard on connection close

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Fixes unregistration with p2p connections, since they don't have an associated name owner. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- ui/dbus-clipboard.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git

[PULL v2 05/18] meson: ensure dbus-display generated code is built before other units

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau It's simply by luck that dbus-display header is built first before the other units using it. With sourceset, I can't find an easier way out than declaring an extra dependency for dbus-display1 generate code. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P.

[PULL v2 07/18] ui: rename cursor_{get->ref}, return it

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau The naming is more conventional in QEMU code, and allows to simplify some code by changing the API design, so it returns the input parameter, instead of void. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h | 2 +- ui/cursor.c

[PULL v2 04/18] ui/dbus: set mouse is-absolute during console creation

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- ui/dbus-console.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/ui/dbus-console.c b/ui/dbus-console.c index 0bfaa2298d..f77bc49d2e 100644 ---

[PULL v2 08/18] ui: keep current cursor with QemuConsole

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Keeping the current cursor around is useful, not only for VNC, but for other displays. Let's move it down, see the following patches for other usages. Signed-off-by: Marc-André Lureau Reviewed-by: Daniel P. Berrangé --- include/ui/console.h | 1 + ui/vnc.h

[PULL v2 01/18] ui/dbus: initialize cursor_fb

2023-03-13 Thread marcandre . lureau
From: Marc-André Lureau Or else, we may randomly destroy some textures.. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- include/ui/egl-helpers.h | 2 ++ ui/dbus-listener.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 01/12] target/s390x: Handle branching to odd addresses

2023-03-13 Thread Richard Henderson
On 3/13/23 08:38, Ilya Leoshkevich wrote: Let branching happen and try to generate a new translation block with an odd address. Generate a specification exception in cpu_get_tb_cpu_state(). Reported-by: Harold Grovesteen Reported-by: Nina Schoetterl-Glausch Signed-off-by: Ilya Leoshkevich ---

Re: [PATCH] MAINTAINERS: Mark the Nios II CPU as orphan

2023-03-13 Thread Richard Henderson
On 3/13/23 11:33, Thomas Huth wrote: Marek and Chris haven't been active for Nios II since years (the last time seems to have been in 2017), and we've got unhandled severe Nios II bug tickets in the bug tracker since a long time, so to avoid wrong expectations of people who are looking at the

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-13 Thread Volker Rümelin
Am 13.03.23 um 14:11 schrieb Dorinda Bassey: Hi Volker, To hear this, start QEMU with qemu-system-x86_64 -machine pcspk-audiodev=audio0 -device ich9-intel-hda -device hda-duplex,audiodev=audio0 -audiodev pipewire,id=audio0,out.mixing-engine=off ... I hear the clipped audio

Re: [PATCH 09/11] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-13 Thread Richard Henderson
On 3/13/23 04:44, Luis Machado wrote: Luis: I think that rather than doing (2) with a QEMU namespace, we should define a gdb namespace for this. That makes it clear that this is still a gdb-upstream-sanctioned way of exposing the pauth registers. That should be fine as well, and would work to

Re: [PATCH v7] audio/pwaudio.c: Add Pipewire audio backend for QEMU

2023-03-13 Thread Dorinda Bassey
> > Are you sure about sizeof(n_bytes) here? That's 4. ;-) > my bad! > > Volker's point was that "silence" is the center of the wave range. With > signed > range that's zero, yes, but with unsigned range that's 2^(bitdepth) / 2. > > So you need to memset() the correct value to generate "silence".

[PATCH RESEND v2 2/2] migration/xbzrle: fix out-of-bounds write with axv512

2023-03-13 Thread Matheus Tavares Bernardino
xbzrle_encode_buffer_avx512() checks for overflows too scarcely in its outer loop, causing out-of-bounds writes: $ ../configure --target-list=aarch64-softmmu --enable-sanitizers --enable-avx512bw $ make tests/unit/test-xbzrle && ./tests/unit/test-xbzrle ==5518==ERROR: AddressSanitizer:

[PATCH RESEND v2 1/2] migration/xbzrle: use ctz64 to avoid undefined result

2023-03-13 Thread Matheus Tavares Bernardino
__builtin_ctzll() produces undefined results when the argument is 0. This can be seen through test-xbzrle, which produces the following warning: ../migration/xbzrle.c:265: runtime error: passing zero to ctz(), which is not a valid argument Replace __builtin_ctzll() with our ctz64() wrapper

[PULL v3 00/91] tcg patch queue

2023-03-13 Thread Richard Henderson
in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-tcg-20230313 for you to fetch changes up to 0c8b6b9a6383e2e37ff3d1d12b40c58b7ed36c1c: tcg: Drop tcg_const_* (2023-03-13 07:03:39 -0700) accel/tcg: Fix

[PULL v3 73/91] target/arm: Improve trans_BFCI

2023-03-13 Thread Richard Henderson
Reorg temporary usage so that we can use tcg_constant_i32. tcg_gen_deposit_i32 already has a width == 32 special case, so remove the check here. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/arm/tcg/translate.c | 14 ++ 1 file changed, 6

[PATCH RESEND v2 0/2] migration/xbzrle: fix two avx512 runtime issues

2023-03-13 Thread Matheus Tavares Bernardino
This patchset strives to fix two bugs at xvzrle when --enable-avx512 is used: an out-of-bounds write and an invalid argument to __builtin_ctz(). Those two errors can be seen in the test suite running: $ ../configure --target-list=aarch64-softmmu --enable-sanitizers --enable-avx512bw $ make

Re: [PATCH v3 0/9] virtio-gpu: Support Venus Vulkan driver

2023-03-13 Thread Gurchetan Singh
On Mon, Mar 13, 2023 at 5:58 AM Marc-André Lureau wrote: > > Hi Gurchetan > > On Tue, Mar 7, 2023 at 2:41 AM Gurchetan Singh > wrote: > > > > On Tue, Jan 31, 2023 at 3:15 PM Dmitry Osipenko > > wrote: > > > > > > Hello, > > > > > > On 1/30/23 20:00, Alex Bennée wrote: > > > > > > > > Antonio

Re: [PATCH] MAINTAINERS: Remove CXL maintainer Ben Widawsky

2023-03-13 Thread Laurent Vivier
Le 20/02/2023 à 22:24, Markus Armbruster a écrit : Ben is no longer with intel. He told me he expected to get back to CXL, but it's not happening as quickly as he'd like, and that it's best to remove him as maintainer. So let's do that. Thank you for serving as maintainer, Ben!

[PATCH] MAINTAINERS: Mark the Nios II CPU as orphan

2023-03-13 Thread Thomas Huth
Marek and Chris haven't been active for Nios II since years (the last time seems to have been in 2017), and we've got unhandled severe Nios II bug tickets in the bug tracker since a long time, so to avoid wrong expectations of people who are looking at the MAINTAINERS file, it's maybe best to mark

Re: [PATCH v4] target/arm: Add Neoverse-N1 registers

2023-03-13 Thread Marcin Juszkiewicz
W dniu 13.03.2023 o 04:39, Chen Baozi pisze: Add implementation defined registers for neoverse-n1 which would be accessed by TF-A. Since there is no DSU in Qemu, CPUCFR_EL1.SCU bit is set to 1 to avoid DSU registers definition. Signed-off-by: Chen Baozi Tested-by: Marcin Juszkiewicz ~ # cat

Re: [PATCH] MAINTAINERS: update my email address for the clock framework

2023-03-13 Thread Laurent Vivier
Le 13/02/2023 à 11:53, Damien Hedde a écrit : Also update mailmap Signed-off-by: Damien Hedde --- MAINTAINERS | 2 +- .mailmap| 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 96e25f62ac..ceeda49d49 100644 --- a/MAINTAINERS +++

Re: [PATCH 10/11] include/exec: fix kerneldoc definition

2023-03-13 Thread Peter Maydell
On Mon, 13 Mar 2023 at 17:30, Peter Maydell wrote: > So I think the problem here is not with Sphinx, but with the > kernel-doc script. That script has an option "-Werror" which > turns its warnings into errors, but our Sphinx extension > docs/sphinx/kerneldoc.py does not set it. I think we need

[RFC 1/2] vhost-user: Add interface for virtio-fs migration

2023-03-13 Thread Hanna Czenczek
Add a virtio-fs-specific vhost-user interface to facilitate migrating back-end-internal state. We plan to migrate the internal state simply as a binary blob after the streaming phase, so all we need is a way to transfer such a blob from and to the back-end. We do so by using a dedicated area of

[RFC 2/2] vhost-user-fs: Implement stateful migration

2023-03-13 Thread Hanna Czenczek
A virtio-fs device's VM state consists of: - the virtio device (vring) state (VMSTATE_VIRTIO_DEVICE) - the back-end's (virtiofsd's) internal state We get/set the latter via the new vhost-user operations FS_SET_STATE_FD, FS_GET_STATE, and FS_SET_STATE. Signed-off-by: Hanna Czenczek ---

[RFC 0/2] vhost-user-fs: Stateful migration

2023-03-13 Thread Hanna Czenczek
Hi, Patch 1 of this RFC series adds virtio-fs-specific operations to vhost for transferring a binary blob of back-end-internal state, and implements those for vhost-user. Patch 2 uses those operations to implement stateful migration for vhost-user-fs devices, assuming the back-end (virtiofsd)

Re: [PATCH v2] qemu-options.hx: remove stray quote

2023-03-13 Thread Laurent Vivier
Le 02/02/2023 à 23:31, John Snow a écrit : Signed-off-by: John Snow --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index d59d19704bc..52d477547f5 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1606,7 +1606,7

Re: [PATCH 10/11] include/exec: fix kerneldoc definition

2023-03-13 Thread Peter Maydell
On Mon, 13 Mar 2023 at 17:14, Thomas Huth wrote: > > On 13/03/2023 18.03, Peter Maydell wrote: > > On Mon, 13 Mar 2023 at 17:00, Thomas Huth wrote: > >> I also keep running into this problem ... I wonder whether we should run > >> sphinx with "-W" to turn warnings into errors when configure has

[PATCH] Use f-strings in python scripts

2023-03-13 Thread Marco Liebel
Replace python 2 format string with f-strings Signed-off-by: Marco Liebel --- target/hexagon/gen_helper_funcs.py | 54 ++-- target/hexagon/gen_helper_protos.py | 10 +- target/hexagon/gen_idef_parser_funcs.py | 8 +- target/hexagon/gen_op_attribs.py| 4 +-

Re: [PATCH v7 0/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Alexander Bulekov
On 230313 1608, Peter Maydell wrote: > On Mon, 13 Mar 2023 at 15:41, Philippe Mathieu-Daudé > wrote: > > Now I wonder again if this is a good time to merge this change set. > > No, I don't think it is at this point in the release > cycle. I would vote for merging it when we reopen for 8.1, > so

Re: [PATCH 10/11] include/exec: fix kerneldoc definition

2023-03-13 Thread Thomas Huth
On 13/03/2023 18.03, Peter Maydell wrote: On Mon, 13 Mar 2023 at 17:00, Thomas Huth wrote: On 10/03/2023 11.31, Alex Bennée wrote: The kerneldoc processor complains about the mismatched variable name. Fix it. Signed-off-by: Alex Bennée --- include/exec/memory.h | 2 +- 1 file changed,

Re: [PULL v2 00/25] Win socket patches

2023-03-13 Thread Peter Maydell
On Mon, 13 Mar 2023 at 11:46, wrote: > > From: Marc-André Lureau > > The following changes since commit 29c8a9e31a982874ce4e2c15f2bf82d5f8dc3517: > > Merge tag 'linux-user-for-8.0-pull-request' of > https://gitlab.com/laurent_vivier/qemu into staging (2023-03-12 10:57:00 > +) > > are

Re: [PATCH 09/10] Python: Drop support for Python 3.6

2023-03-13 Thread Daniel P . Berrangé
On Wed, Feb 22, 2023 at 03:37:51PM +0100, Paolo Bonzini wrote: > Python 3.6 was EOL 2021-12-31. Newer versions of upstream libraries have > begun dropping support for this version and it is becoming more > cumbersome to support. Avocado-framework and qemu.qmp each have their > own reasons for

Re: [PATCH 10/11] include/exec: fix kerneldoc definition

2023-03-13 Thread Peter Maydell
On Mon, 13 Mar 2023 at 17:00, Thomas Huth wrote: > > On 10/03/2023 11.31, Alex Bennée wrote: > > The kerneldoc processor complains about the mismatched variable name. > > Fix it. > > > > Signed-off-by: Alex Bennée > > --- > > include/exec/memory.h | 2 +- > > 1 file changed, 1 insertion(+), 1

Re: [PATCH 10/11] include/exec: fix kerneldoc definition

2023-03-13 Thread Thomas Huth
On 10/03/2023 11.31, Alex Bennée wrote: The kerneldoc processor complains about the mismatched variable name. Fix it. Signed-off-by: Alex Bennée --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index

Re: [PATCH v1] hw/pvrdma: Protect against buggy or malicious guest driver

2023-03-13 Thread Red Hat Product Security
Hello! INC2534320 ([PATCH v1] hw/pvrdma: Protect against buggy or malicious guest driver) has been updated. Opened for: yuval.shaia...@gmail.com Followers: qemu-devel@nongnu.org, soulchen8...@gmail.com, Mauro Matteo Cascella, qemu-secur...@nongnu.org, yuval.shaia...@gmail.com,

Re: [PATCH for-8.0] ide: Fix manual in-flight count for TRIM BH

2023-03-13 Thread Kevin Wolf
Am 10.03.2023 um 16:13 hat Paolo Bonzini geschrieben: > On Fri, Mar 10, 2023 at 3:25 PM Kevin Wolf wrote: > > > 1. The TRIM operation should be completed on the IDE level before > > > draining ends. > > > 2. Block layer requests issued after draining has begun are queued. > > > > > > To me, the

Re: [PATCH v7 0/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Thomas Huth
On 13/03/2023 15.52, Alexander Bulekov wrote: On 230313 1502, Thomas Huth wrote: On 13/03/2023 09.24, Alexander Bulekov wrote: v6 -> v7: - Fix bad qemu_bh_new_guarded calls found by Thomas (Patch 4) - Add an MR-specific flag to disable reentrancy (Patch 5) - Disable

Re: [PATCH v4 6/6] hw/cxl: Add clear poison mailbox command support.

2023-03-13 Thread Jonathan Cameron via
On Fri, 3 Mar 2023 15:09:08 + Jonathan Cameron wrote: > Current implementation is very simple so many of the corner > cases do not exist (e.g. fragmenting larger poison list entries) > > Signed-off-by: Jonathan Cameron Another case in here of directly accessing MemoryRegion->size. I'll fix

Re: [PATCH v7 0/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Peter Maydell
On Mon, 13 Mar 2023 at 15:41, Philippe Mathieu-Daudé wrote: > Now I wonder again if this is a good time to merge this change set. No, I don't think it is at this point in the release cycle. I would vote for merging it when we reopen for 8.1, so that we'll have a full cycle to find all the weird

Re: [PATCH v4 2/2] hw/cxl: Multi-Region CXL Type-3 Devices (Volatile and Persistent)

2023-03-13 Thread Jonathan Cameron via
... > > +if (vmr) { > > +if (*dpa_offset < int128_get64(vmr->size)) { > > +*as = >hostvmem_as; > > +} else { > > +*as = >hostpmem_as; > > +*dpa_offset -= vmr->size; > > You can't do math on vmr->size, it's Int128. > And generally please

Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus

2023-03-13 Thread Huang Rui
On Mon, Mar 13, 2023 at 01:51:03AM +0800, Dmitry Osipenko wrote: > On 3/12/23 12:22, Huang Rui wrote: > > From: Antonio Caggiano > > > > Request Venus when initializing VirGL. > > > > Signed-off-by: Antonio Caggiano > > --- > > hw/display/virtio-gpu-virgl.c | 4 > > 1 file changed, 4

Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus

2023-03-13 Thread Huang Rui
On Mon, Mar 13, 2023 at 10:22:24AM +0800, Dmitry Osipenko wrote: > On 3/12/23 20:51, Dmitry Osipenko wrote: > > On 3/12/23 12:22, Huang Rui wrote: > >> From: Antonio Caggiano > >> > >> Request Venus when initializing VirGL. > >> > >> Signed-off-by: Antonio Caggiano > >> --- > >>

Re: [PATCH v3 1/1] hw/riscv: Fix max size limit when put initrd to RAM

2023-03-13 Thread Anup Patel
On Mon, Mar 13, 2023 at 7:49 AM Hang Xu wrote: > > Because the starting address of ram is not necessarily 0, > the remaining free space in ram is > ram_size - (start - ram_base) instead of ram_size-start. > > Signed-off-by: Hang Xu What happens in-case a platform has multiple RAM banks ?

Re: [PATCH v7 0/6] memory: prevent dma-reentracy issues

2023-03-13 Thread Philippe Mathieu-Daudé
On 13/3/23 15:52, Alexander Bulekov wrote: On 230313 1502, Thomas Huth wrote: On 13/03/2023 09.24, Alexander Bulekov wrote: v6 -> v7: - Fix bad qemu_bh_new_guarded calls found by Thomas (Patch 4) - Add an MR-specific flag to disable reentrancy (Patch 5) - Disable reentrancy

[PATCH v2 03/12] target/s390x: Handle LGRL from non-aligned addresses

2023-03-13 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 6 +++---

[PATCH v2 04/12] target/s390x: Handle LRL and LGFRL from non-aligned addresses

2023-03-13 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 14 +++---

[PATCH v2 05/12] target/s390x: Handle LLGFRL from non-aligned addresses

2023-03-13 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 6 +++---

[PATCH v2 10/12] target/s390x: Handle STGRL to non-aligned addresses

2023-03-13 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 8

[PATCH v2 00/12] target/s390x: Handle unaligned accesses

2023-03-13 Thread Ilya Leoshkevich
v1: https://lists.gnu.org/archive/html/qemu-devel/2023-03/msg03821.html v1 -> v2: Use MO_ALIGN (Richard). Patches that need review: - [PATCH 01/12] target/s390x: Handle branching to odd addresses - [PATCH 12/12] tests/tcg/s390x: Test unaligned accesses Hi, This series makes accessing unaligned

[PATCH v2 09/12] target/s390x: Handle STRL to non-aligned addresses

2023-03-13 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 12 ++--

  1   2   3   4   >