Re: [PATCH v2 09/10] contrib/gitdm: add more individual contributors

2023-03-15 Thread Bin Meng
On 2023/3/11 2:03:31, "Alex Bennée" wrote: I'll only add names explicitly acked here. Let me know if you want contributions mapped to a company instead. Signed-off-by: Alex Bennée Cc: Bernhard Beschow Cc: Amarjargal Gundjalam Cc: Bin Meng Cc: Jason A. Donenfeld Cc: Strahinja Jankovic

Re: [PATCH v2 01/28] accel/tcg: Introduce translator_use_goto_tb

2023-03-15 Thread Wu, Fei
On 3/16/2023 10:07 AM, Wu, Fei wrote: > On 3/15/2023 2:15 AM, Richard Henderson wrote: >> On 3/14/23 06:47, Wu, Fei wrote: >>> On 3/13/2023 11:00 PM, Richard Henderson wrote: On 3/13/23 07:13, Wu, Fei2 wrote: > Hi Richard, > > Sorry for disturbing you. I'm doing some perf

[Bug 1703506] Re: SMT not supported by QEMU on AMD Ryzen CPU

2023-03-15 Thread Anthony Kamau
I was able to avoid rebooting after following @Andrii's instructions - https://bugs.launchpad.net/qemu/+bug/1703506/comments/19 - above: systemctl stop libvirtd libvirtd-admin.socket libvirtd-ro.socket libvirtd.socket sudo modprobe -r kvm_intel kvm systemctl start libvirtd libvirtd-admin.socket

Re: [PATCH v2 01/28] accel/tcg: Introduce translator_use_goto_tb

2023-03-15 Thread Wu, Fei
On 3/15/2023 2:15 AM, Richard Henderson wrote: > On 3/14/23 06:47, Wu, Fei wrote: >> On 3/13/2023 11:00 PM, Richard Henderson wrote: >>> On 3/13/23 07:13, Wu, Fei2 wrote: Hi Richard, Sorry for disturbing you. I'm doing some perf profiling on qemu-riscv64, I see 10%+ faster

Re: Enable cross-page block chaining for user mode tcg

2023-03-15 Thread Wu, Fei
On 3/15/2023 10:40 PM, Wu, Fei wrote: > Block chaining is one of the key performance factors of tcg. Currently > tcg doesn't allow chaining across page boundary, an example can be found > in gen_goto_tb() in target/riscv/translate.c. > > For user-mode tcg, it's possible to enable cross-page

Re: [PATCH] disas/riscv: Add support for XThead* instructions

2023-03-15 Thread LIU Zhiwei
On 2023/3/15 21:35, Christoph Muellner wrote: From: Christoph Müllner Support for emulating XThead* instruction has been added recently. This patch adds support for these instructions to the RISC-V disassembler. This patch doesn't scale well. It will make the custom encoding only work for

[PATCH v2] target/sh4: Honor QEMU_LOG_FILENAME with QEMU_LOG=cpu

2023-03-15 Thread Ilya Leoshkevich
When using QEMU_LOG=cpu on sh4, QEMU_LOG_FILENAME is partially ignored. Fix by using qemu_fprintf() instead of qemu_printf() in the respective places. Fixes: 90c84c560067 ("qom/cpu: Simplify how CPUClass:cpu_dump_state() prints") Reviewed-by: Peter Maydell Reviewed-by: Yoshinori Sato

[RFC PATCH 02/10] KVM: selftests: Test that ftruncate to non-page-aligned size on a restrictedmem fd should fail

2023-03-15 Thread Ackerley Tng
Signed-off-by: Ackerley Tng --- tools/testing/selftests/vm/memfd_restricted.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/vm/memfd_restricted.c b/tools/testing/selftests/vm/memfd_restricted.c index 43a512f273f7..9c4e6a0becbc 100644 ---

[RFC PATCH 09/10] KVM: selftests: Add tests around sharing a restrictedmem fd

2023-03-15 Thread Ackerley Tng
Tests that + Different memslots in the same VM should be able to share a restrictedmem_fd + A second VM cannot share the same offsets in a restrictedmem_fd + Different VMs should be able to share the same restrictedmem_fd, as long as the offsets in the restrictedmem_fd are different

[RFC PATCH 08/10] KVM: selftests: Default private_mem_conversions_test to use 1 restrictedmem file for test data

2023-03-15 Thread Ackerley Tng
Default the private/shared memory conversion tests to use a single file (when multiple memslots are requested), while executing on multiple vCPUs in parallel, to stress-test the restrictedmem subsystem. Also add a flag to allow multiple files to be used. Signed-off-by: Ackerley Tng ---

[RFC PATCH 10/10] KVM: selftests: Test KVM exit behavior for private memory/access

2023-03-15 Thread Ackerley Tng
"Testing private access when memslot gets deleted" tests the behavior of KVM when a private memslot gets deleted while the VM is using the private memslot. When KVM looks up the deleted (slot = NULL) memslot, KVM should exit to userspace with KVM_EXIT_MEMORY_FAULT. In the second test, upon a

[RFC PATCH 07/10] KVM: selftests: Add vm_userspace_mem_region_add_with_restrictedmem

2023-03-15 Thread Ackerley Tng
Provide new function to allow restrictedmem's fd and offset to be specified in selftests. No functional change intended to vm_userspace_mem_region_add. Signed-off-by: Ackerley Tng --- .../selftests/kvm/include/kvm_util_base.h | 4 ++ tools/testing/selftests/kvm/lib/kvm_util.c| 46

[RFC PATCH 05/10] KVM: selftests: Generalize private_mem_conversions_test for parallel execution

2023-03-15 Thread Ackerley Tng
By running the private/shared memory conversion tests on multiple vCPUs in parallel, we stress-test the restrictedmem subsystem to test conversion of non-overlapping GPA ranges in multiple memslots. Signed-off-by: Ackerley Tng --- .../kvm/x86_64/private_mem_conversions_test.c | 203

[RFC PATCH 01/10] KVM: selftests: Test error message fixes for memfd_restricted selftests

2023-03-15 Thread Ackerley Tng
Signed-off-by: Ackerley Tng --- tools/testing/selftests/vm/memfd_restricted.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/vm/memfd_restricted.c b/tools/testing/selftests/vm/memfd_restricted.c index 3a556b570129..43a512f273f7 100644 ---

[RFC PATCH 06/10] KVM: selftests: Default private_mem_conversions_test to use 1 memslot for test data

2023-03-15 Thread Ackerley Tng
Default the private/shared memory conversion tests to use a single memslot, while executing on multiple vCPUs in parallel, to stress-test the restrictedmem subsystem. Also add a flag to allow multiple memslots to be used. Signed-off-by: Ackerley Tng ---

[RFC PATCH 04/10] KVM: selftests: Exercise restrictedmem allocation and truncation code after KVM invalidation code has been unbound

2023-03-15 Thread Ackerley Tng
The kernel interfaces restrictedmem_bind and restrictedmem_unbind are used by KVM to bind/unbind kvm functions to restrictedmem's invalidate_start and invalidate_end callbacks. After the KVM VM is freed, the KVM functions should have been unbound from the restrictedmem_fd's callbacks. In this

[RFC PATCH 03/10] KVM: selftests: Test that VM private memory should not be readable from host

2023-03-15 Thread Ackerley Tng
After VM memory is remapped as private memory and guest has written to private memory, request the host to read the corresponding hva for that private memory. The host should not be able to read the value in private memory. This selftest shows that private memory contents of the guest are not

[RFC PATCH 00/10] Additional selftests for restrictedmem

2023-03-15 Thread Ackerley Tng
Hello, This is a series containing additional selftests for restrictedmem, prepared to be used with the next iteration of the restrictedmem series after v10. restrictedmem v10 is available at https://lore.kernel.org/lkml/20221202061347.1070246-1-chao.p.p...@linux.intel.com/T/. The tree can be

[PATCH v2 1/2] target/s390x: Fix R[NOX]SBG with T=1

2023-03-15 Thread Ilya Leoshkevich
RXSBG usage in the "filetests" test from the wasmtime testsuite makes tcg_reg_alloc_op() attempt to temp_load() a TEMP_VAL_DEAD temporary, causing an assertion failure: 0x01000a70: ec14 b040 3057 rxsbg%r1, %r4, 0xb0, 0x40, 0x30 OP after optimization and liveness analysis:

[PATCH v2 2/2] tests/tcg/s390x: Add rxsbg.c

2023-03-15 Thread Ilya Leoshkevich
Add a small test for RXSBG with T=1 to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 3 +++ tests/tcg/s390x/rxsbg.c | 46 + 2 files changed, 49 insertions(+) create mode 100644 tests/tcg/s390x/rxsbg.c diff

[PATCH v2 0/2] target/s390x: Fix R[NOX]SBG with T=1

2023-03-15 Thread Ilya Leoshkevich
v1: https://lists.gnu.org/archive/html/qemu-devel/2023-03/msg04493.html v1 -> v2: Work around a clang issue (Thomas). Add cc=0 test, use more human-friendly constants. Hi, This series fixes ROTATE THEN SELECTED BITS when test-results control is on. The problem is the incorrect

Re: [PATCH] Use f-strings in python scripts

2023-03-15 Thread John Snow
On Wed, Mar 15, 2023 at 8:13 AM Philippe Mathieu-Daudé wrote: > > On 15/3/23 12:16, Daniel P. Berrangé wrote: > > On Wed, Mar 15, 2023 at 08:43:33AM +0100, Philippe Mathieu-Daudé wrote: > >> Hi Marco, > >> > >> (+Python experts) > >> > >> On 13/3/23 18:25, Marco Liebel wrote: > >>> Replace python

[PATCH v3 08/12] target/s390x: Handle CLRL and CLGFRL with non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v3 04/12] target/s390x: Handle LRL and LGFRL from non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 14 +++---

[PATCH v3 09/12] target/s390x: Handle STRL to non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 12 ++--

[PATCH v3 05/12] target/s390x: Handle LLGFRL from non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 6 +++---

[PATCH v3 11/12] target/s390x: Update do_unaligned_access() comment

2023-03-15 Thread Ilya Leoshkevich
Relative long instructions now depend on do_unaligned_access() too. Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/excp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s390x/tcg/excp_helper.c

[PATCH v3 03/12] target/s390x: Handle LGRL from non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 6 +++---

[PATCH v3 10/12] target/s390x: Handle STGRL to non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/insn-data.h.inc | 8

[PATCH v3 07/12] target/s390x: Handle CGRL and CLGRL with non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v3 00/12] target/s390x: Handle unaligned accesses

2023-03-15 Thread Ilya Leoshkevich
v2: https://lists.gnu.org/archive/html/qemu-devel/2023-03/msg04231.html v2 -> v3: Fix clang build (Thomas). v1: https://lists.gnu.org/archive/html/qemu-devel/2023-03/msg03821.html v1 -> v2: Use MO_ALIGN (Richard). Patches that need review: - [PATCH 12/12] tests/tcg/s390x: Test unaligned accesses

[PATCH v3 06/12] target/s390x: Handle CRL and CGFRL with non-aligned addresses

2023-03-15 Thread Ilya Leoshkevich
Use MO_ALIGN and let do_unaligned_access() generate a specification exception. Reported-by: Nina Schoetterl-Glausch Suggested-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/translate.c | 3 ++- 1 file changed, 2 insertions(+),

[PATCH v3 12/12] tests/tcg/s390x: Test unaligned accesses

2023-03-15 Thread Ilya Leoshkevich
Add a number of small test that check whether accessing unaligned addresses in various ways leads to a specification exception. Run these test both in softmmu and user configurations; expect a PGM in one case and SIGILL in the other. Signed-off-by: Ilya Leoshkevich ---

[PATCH v3 01/12] target/s390x: Handle branching to odd addresses

2023-03-15 Thread Ilya Leoshkevich
Let branching happen and try to generate a new translation block with an odd address. Generate a specification exception in cpu_get_tb_cpu_state(). Reported-by: Harold Grovesteen Reported-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich ---

[PATCH v3 02/12] target/s390x: Handle EXECUTE of odd addresses

2023-03-15 Thread Ilya Leoshkevich
Generate a specification exception in the helper before trying to fetch the instruction. Reported-by: Nina Schoetterl-Glausch Reviewed-by: Richard Henderson Signed-off-by: Ilya Leoshkevich --- target/s390x/tcg/mem_helper.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-)

Re: [RFC QEMU PATCH 08/18] virtio-gpu: Initialize Venus

2023-03-15 Thread Dmitry Osipenko
On 3/13/23 18:55, Huang Rui wrote: > On Mon, Mar 13, 2023 at 01:51:03AM +0800, Dmitry Osipenko wrote: >> On 3/12/23 12:22, Huang Rui wrote: >>> From: Antonio Caggiano >>> >>> Request Venus when initializing VirGL. >>> >>> Signed-off-by: Antonio Caggiano >>> --- >>> hw/display/virtio-gpu-virgl.c

Re: [PATCH 02/10] python: drop pipenv

2023-03-15 Thread John Snow
On Wed, Mar 15, 2023 at 5:17 PM Philippe Mathieu-Daudé wrote: > > +Jan > > On 22/2/23 15:37, Paolo Bonzini wrote: > > From: John Snow > > > > The pipenv tool was nice in theory, but in practice it's just too hard > > to update selectively, and it makes using it a pain. The qemu.qmp repo > >

Re: [PATCH v2 30/32] contrib/gitdm: add revng to domain map

2023-03-15 Thread Alessandro Di Federico via
On Wed, 15 Mar 2023 17:43:29 + Alex Bennée wrote: > +rev.ng revng Can we have "rev.ng Labs"? I suggested this in my previous e-mail too, but maybe it slipped away. -- Alessandro Di Federico rev.ng Labs

Re: [PATCH 2/4] hw/arm: Add WDT to Allwinner-A10 and Cubieboard

2023-03-15 Thread Strahinja Jankovic
Hi Niek, On Tue, Mar 14, 2023 at 10:21 PM Niek Linnenbank wrote: > > Hi Strahinja, > > > On Sat, Mar 11, 2023 at 3:42 PM Strahinja Jankovic > wrote: >> >> This patch adds WDT to Allwinner-A10 and Cubieboard. >> WDT is added as an overlay to the Timer module memory map. >> >> Signed-off-by:

Re: [PATCH 1/4] hw/watchdog: Allwinner WDT emulation for system reset

2023-03-15 Thread Strahinja Jankovic
)Hi Niek, On Tue, Mar 14, 2023 at 10:14 PM Niek Linnenbank wrote: > > Hi Strahinja, > > > On Sat, Mar 11, 2023 at 3:41 PM Strahinja Jankovic > wrote: >> >> This patch adds basic support for Allwinner WDT. >> Both sun4i and sun6i variants are supported. >> However, interrupt generation is not

Re: [PATCH v6 1/4] file-posix: add tracking of the zone write pointers

2023-03-15 Thread Damien Le Moal
On 3/15/23 21:59, Sam Li wrote: > Damien Le Moal 于2023年3月14日周二 11:49写道: >> >> On 3/14/23 11:23, Dmitry Fomichev wrote: @@ -3339,10 +3473,27 @@ static int coroutine_fn raw_co_zone_mgmt(BlockDriverState *bs, BlockZoneOp op, len >> BDRV_SECTOR_BITS);

Re: [PATCH] coverity: physmem: use simple assertions instead of modelling

2023-03-15 Thread Paolo Bonzini
On 3/15/23 15:28, Vladimir Sementsov-Ogievskiy wrote: On 22.02.23 18:57, Peter Maydell wrote: On Wed, 22 Feb 2023 at 14:19, Stefan Hajnoczi wrote: On Wed, 15 Feb 2023 at 15:22, Vladimir Sementsov-Ogievskiy wrote: ping [add Stefan] I'm not familiar with the Coverity models. Peter

Re: [PATCH 02/10] python: drop pipenv

2023-03-15 Thread Philippe Mathieu-Daudé
+Jan On 22/2/23 15:37, Paolo Bonzini wrote: From: John Snow The pipenv tool was nice in theory, but in practice it's just too hard to update selectively, and it makes using it a pain. The qemu.qmp repo dropped pipenv support a while back and it's been functioning just fine, so I'm backporting

Re: [PATCH RESEND v2 2/2] migration/xbzrle: fix out-of-bounds write with axv512

2023-03-15 Thread Juan Quintela
Matheus Tavares Bernardino wrote: > xbzrle_encode_buffer_avx512() checks for overflows too scarcely in its > outer loop, causing out-of-bounds writes: > > $ ../configure --target-list=aarch64-softmmu --enable-sanitizers > --enable-avx512bw > $ make tests/unit/test-xbzrle &&

Re: [PATCH RESEND v2 1/2] migration/xbzrle: use ctz64 to avoid undefined result

2023-03-15 Thread Juan Quintela
Matheus Tavares Bernardino wrote: > __builtin_ctzll() produces undefined results when the argument is 0. > This can be seen through test-xbzrle, which produces the following > warning: > > ../migration/xbzrle.c:265: runtime error: passing zero to ctz(), which is not > a valid argument > >

Re: [PATCH for-8.1 v2 25/26] target/riscv: rework write_misa()

2023-03-15 Thread Daniel Henrique Barboza
On 3/15/23 02:25, liweiwei wrote: On 2023/3/15 00:49, Daniel Henrique Barboza wrote: write_misa() must use as much common logic as possible. We want to open code just the bits that are exclusive to the CSR write operation and TCG internals. Rewrite write_misa() to work as follows: -

Re: [PATCH] migration: Wait on preempt channel in preempt thread

2023-03-15 Thread Juan Quintela
Peter Xu wrote: > QEMU main thread will wait until dest preempt channel established during > processing the LISTEN command (within the whole postcopy PACKAGED data), by > waiting on the semaphore postcopy_qemufile_dst_done. > > That's racy, because it's possible that the dest QEMU main thread

Re: [PATCH v3 1/3] scripts/git.orderfile: Display QAPI script changes before schema ones

2023-03-15 Thread Juan Quintela
Philippe Mathieu-Daudé wrote: > When modifying QAPI scripts and modifying C files along, > it makes sense to display QAPI changes first. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela

Re: [PATCH v3 3/3] qapi: Generate enum count as definition

2023-03-15 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote: > QAPI's gen_enum() generates QAPI enum values and the > number of this values (as foo__MAX). > The number of entries in an enum type is not part of > the enumerated values, but we generate it as such. > See for example: > > typedef enum

RE: [PATCH v2 28/32] contrib/gitdm: add Amazon to the domain map

2023-03-15 Thread Durrant, Paul
> -Original Message- > From: Alex Bennée > Sent: 15 March 2023 17:43 > To: qemu-devel@nongnu.org > Cc: Akihiko Odaki ; Marc-André Lureau > ; qemu-ri...@nongnu.org; Riku Voipio > ; Igor Mammedov ; Xiao Guangrong > ; Thomas Huth ; Wainer dos > Santos Moschetta ; Dr. David Alan Gilbert > ;

RE: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() APIs

2023-03-15 Thread Shi, Guohuai
> -Original Message- > From: Christian Schoenebeck > Sent: Wednesday, March 15, 2023 00:06 > To: Greg Kurz ; qemu-devel@nongnu.org > Cc: Shi, Guohuai ; Meng, Bin > > Subject: Re: [PATCH v5 04/16] hw/9pfs: Implement Windows specific xxxdir() > APIs > > CAUTION: This email comes from a

Re: [RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Stefan Hajnoczi
On Wed, Mar 15, 2023 at 01:13:29PM +0100, Hanna Czenczek wrote: > When processing vectored guest requests that are not aligned to the > storage request alignment, we pad them by adding head and/or tail > buffers for a read-modify-write cycle. > > The guest can submit I/O vectors up to IOV_MAX

Re: [PATCH RESEND v2 2/2] migration/xbzrle: fix out-of-bounds write with axv512

2023-03-15 Thread Dr. David Alan Gilbert
* Matheus Tavares Bernardino (quic_mathb...@quicinc.com) wrote: > xbzrle_encode_buffer_avx512() checks for overflows too scarcely in its > outer loop, causing out-of-bounds writes: > > $ ../configure --target-list=aarch64-softmmu --enable-sanitizers > --enable-avx512bw > $ make

Re: [PATCH 2/2] tests/tcg/s390x: Add rxsbg.c

2023-03-15 Thread Ilya Leoshkevich
On Wed, 2023-03-15 at 19:12 +0100, Thomas Huth wrote: > On 15/03/2023 00.34, Ilya Leoshkevich wrote: > > Add a small test for RXSBG with T=1 to prevent regressions. > > > > Signed-off-by: Ilya Leoshkevich > > --- > >   tests/tcg/s390x/Makefile.target |  1 + > >   tests/tcg/s390x/rxsbg.c

Re: [RFC 1/2] block: Split padded I/O vectors exceeding IOV_MAX

2023-03-15 Thread Eric Blake
On Wed, Mar 15, 2023 at 01:13:29PM +0100, Hanna Czenczek wrote: > When processing vectored guest requests that are not aligned to the > storage request alignment, we pad them by adding head and/or tail > buffers for a read-modify-write cycle. > > The guest can submit I/O vectors up to IOV_MAX

Re: [PATCH v2 2/2] linux-user/m68k: Handle EXCP_ADDRESS in cpu_loop

2023-03-15 Thread Laurent Vivier
Le 09/03/2023 à 21:16, Richard Henderson a écrit : This exception can be raised by illegal instructions. Signed-off-by: Richard Henderson --- linux-user/m68k/cpu_loop.c | 5 - tests/tcg/m68k/excp-address.c | 32 tests/tcg/m68k/Makefile.target | 1

[PATCH 2/2] linux-user: Improve strace output of pread64() and pwrite64()

2023-03-15 Thread Helge Deller
Make the strace look nicer for those two syscalls. Signed-off-by: Helge Deller --- linux-user/strace.c| 19 +++ linux-user/strace.list | 4 ++-- 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/linux-user/strace.c b/linux-user/strace.c index

[PATCH 1/2] linux-user: Fix mmap2() syscall on 32-bit targets to allow file mapping beyond 4GB

2023-03-15 Thread Helge Deller
The mmap2() syscall allows 32-bit guests to specify the offset into a file in page units (instead of bytes, as done by mmap(2)). On physical machines this allows 32-bit applications to map such parts of large files which are stored beyond the 4GB limit. Allow the same behaviour when emulating

Re: [PATCH v2 12/12] tests/tcg/s390x: Test unaligned accesses

2023-03-15 Thread Ilya Leoshkevich
On Wed, 2023-03-15 at 19:09 +0100, Thomas Huth wrote: > On 13/03/2023 16.38, Ilya Leoshkevich wrote: > > Add a number of small test that check whether accessing unaligned > > addresses in various ways leads to a specification exception. > > > > Run these test both in softmmu and user

Re: [PATCH 2/2] tests/tcg/s390x: Add rxsbg.c

2023-03-15 Thread Thomas Huth
On 15/03/2023 00.34, Ilya Leoshkevich wrote: Add a small test for RXSBG with T=1 to prevent regressions. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/rxsbg.c | 25 + 2 files changed, 26 insertions(+) create

Re: [PATCH v2 12/12] tests/tcg/s390x: Test unaligned accesses

2023-03-15 Thread Thomas Huth
On 13/03/2023 16.38, Ilya Leoshkevich wrote: Add a number of small test that check whether accessing unaligned addresses in various ways leads to a specification exception. Run these test both in softmmu and user configurations; expect a PGM in one case and SIGILL in the other. Signed-off-by:

Re: [PATCH RESEND v2 1/2] migration/xbzrle: use ctz64 to avoid undefined result

2023-03-15 Thread Dr. David Alan Gilbert
* Matheus Tavares Bernardino (quic_mathb...@quicinc.com) wrote: > __builtin_ctzll() produces undefined results when the argument is 0. > This can be seen through test-xbzrle, which produces the following > warning: > > ../migration/xbzrle.c:265: runtime error: passing zero to ctz(), which is not

[PATCH v2 22/32] iotests: connect stdin to /dev/null when running tests

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Currently the tests have their stdin inherited from the test harness, meaning they are connected to a TTY. The QEMU processes spawned by certain tests, however, modify TTY settings and if the test exits abnormally the settings might not be restored. The python test

[PATCH v2 11/32] tcg: Clear plugin_mem_cbs on TB exit

2023-03-15 Thread Alex Bennée
From: Richard Henderson Do this in cpu_tb_exec (normal exit) and cpu_loop_exit (exception), adjacent to where we reset can_do_io. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1381 Signed-off-by: Richard Henderson Message-Id: <20230310195252.210956-2-richard.hender...@linaro.org>

[PATCH v2 25/32] iotests: remove the check-block.sh script

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Now that meson directly invokes the individual I/O tests, the check-block.sh wrapper script is no longer required. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Acked-by: Hanna Czenczek Tested-by: Thomas Huth Message-Id:

[PATCH v2 29/32] contrib/gitdm: add Alibaba to the domain-map

2023-03-15 Thread Alex Bennée
This replaces the previous attempt to add c-sky.com. Group everything under Alibaba now. Added as requested by LIU Zhiwei. Signed-off-by: Alex Bennée Acked-by: Guo Ren Reviewed-by: Xuan Zhuo Reviewed-by: LIU Zhiwei Message-Id: <20230310180332.2274827-8-alex.ben...@linaro.org> ---

[PATCH v2 13/32] include/qemu/plugin: Remove QEMU_PLUGIN_ASSERT

2023-03-15 Thread Alex Bennée
From: Richard Henderson This macro is no longer used. Signed-off-by: Richard Henderson Message-Id: <20230310195252.210956-4-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/plugin.h | 4 1 file changed, 4 deletions(-) diff --git a/include/qemu/plugin.h

[PATCH v2 09/32] include/exec: fix kerneldoc definition

2023-03-15 Thread Alex Bennée
The kerneldoc processor complains about the mismatched variable name. Fix it. Message-Id: <20230310103123.2118519-11-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée --- include/exec/memory.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v2 23/32] iotests: always use a unique sub-directory per test

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé The current test runner is only safe against parallel execution within a single instance of the 'check' process, and only if -j is given a value greater than 2. This prevents running multiple copies of the 'check' process for different test scenarios. This change

[PATCH v2 08/32] tests/tcg: disable pauth for aarch64 gdb tests

2023-03-15 Thread Alex Bennée
You need a very new gdb to be able to run with pauth support otherwise your likely to hit asserts and aborts. Disable pauth for now until we can properly probe support in gdb. Message-Id: <20230310103123.2118519-10-alex.ben...@linaro.org> Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée

[PATCH v2 31/32] contrib/gitdm: add more individual contributors

2023-03-15 Thread Alex Bennée
I've only added the names explicitly acked. Signed-off-by: Alex Bennée Cc: Bernhard Beschow Cc: Amarjargal Gundjalam Cc: Bin Meng Cc: Jason A. Donenfeld Cc: Strahinja Jankovic Acked-by: Bernhard Beschow Message-Id: <20230310180332.2274827-10-alex.ben...@linaro.org> ---

[PATCH v2 12/32] tcg: Drop plugin_gen_disable_mem_helpers from tcg_gen_exit_tb

2023-03-15 Thread Alex Bennée
From: Richard Henderson Now that we call qemu_plugin_disable_mem_helpers in cpu_tb_exec, we don't need to do this in generated code as well. Signed-off-by: Richard Henderson Message-Id: <20230310195252.210956-3-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- tcg/tcg-op.c | 1 -

[PATCH v2 28/32] contrib/gitdm: add Amazon to the domain map

2023-03-15 Thread Alex Bennée
We have multiple contributors from both .co.uk and .com versions of the address. Signed-off-by: Alex Bennée Cc: Alexander Graf Cc: Paul Durrant Cc: David Wooodhouse Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310180332.2274827-7-alex.ben...@linaro.org> --- contrib/gitdm/domain-map

[PATCH v2 30/32] contrib/gitdm: add revng to domain map

2023-03-15 Thread Alex Bennée
Signed-off-by: Alex Bennée Cc: Anton Johansson Cc: Niccolò Izzo Cc: Paolo Montesel Reviewed-by: Alessandro Di Federico Message-Id: <20230310180332.2274827-9-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/gitdm/domain-map

[PATCH v2 10/32] tests/avocado: don't use tags to define drive

2023-03-15 Thread Alex Bennée
We are abusing the avocado tags which are intended to provide test selection metadata to provide parameters to our test. This works OK up until the point you need to have ,'s in the field as this is the tag separator character which is the case for a number of the drive parameters. Fix this by

[PATCH v2 19/32] iotests: allow test discovery before building

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé The 'check' script can be invoked in "dry run" mode, in which case it merely does test discovery and prints out all their names. Despite only doing test discovery it still validates that the various QEMU binaries can be found. This makes it impossible todo test discovery

[PATCH v2 07/32] tests/tcg: add some help output for running individual tests

2023-03-15 Thread Alex Bennée
So you can do: cd tests/tcg/aarch64-linux-user make -f ../Makefile.target help To see the list of tests. You can then run each one individually. Signed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/tcg/Makefile.target

[PATCH v2 24/32] iotests: register each I/O test separately with meson

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Currently meson registers a single test that invokes an entire group of I/O tests, hiding the test granularity from meson. There are various downsides of doing this * You cannot ask 'meson test' to invoke a single I/O test * The meson test timeout can't be applied to

[PATCH v2 05/32] gitlab: update centos-8-stream job

2023-03-15 Thread Alex Bennée
A couple of clean-ups here: - inherit from the custom runners job for artefacts - call check-avocado directly - add some comments to the top about setup Signed-off-by: Alex Bennée --- .../custom-runners/centos-stream-8-x86_64.yml | 18 ++ 1 file changed, 6 insertions(+),

[PATCH v2 02/32] tests/docker: all add DOCKER_BUILDKIT to RUNC environment

2023-03-15 Thread Alex Bennée
It seems we also need to pass DOCKER_BUILDKIT as an argument to docker itself to get the full benefit of caching. Signed-off-by: Alex Bennée Suggested-by: Fabiano Rosas --- tests/docker/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 16/32] include/qemu: Split out plugin-event.h

2023-03-15 Thread Alex Bennée
From: Richard Henderson The usage in hw/core/cpu.h only requires QEMU_PLUGIN_EV_MAX. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-7-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/hw/core/cpu.h | 2 +-

[PATCH v2 27/32] contrib/gitdm: Add SYRMIA to the domain map

2023-03-15 Thread Alex Bennée
The company website lists QEMU amongst the things they work on so I assume these are corporate contributions. Signed-off-by: Alex Bennée Cc: Milica Lazarevic Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310180332.2274827-6-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1

[PATCH v2 26/32] contrib/gitdm: Add ASPEED Technology to the domain map

2023-03-15 Thread Alex Bennée
We have a number of contributors from this domain which is a corporate endeavour. Signed-off-by: Alex Bennée Cc: Steven Lee Cc: Troy Lee Cc: Howard Chiu Cc: Jamin Lin Reviewed-by: Troy Lee Message-Id: <20230310180332.2274827-4-alex.ben...@linaro.org> --- contrib/gitdm/domain-map | 1 + 1

[PATCH v2 06/32] include/qemu: add documentation for memory callbacks

2023-03-15 Thread Alex Bennée
Some API documentation was missed, rectify that. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1497 Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h | 47 ++ 1 file changed, 43 insertions(+), 4 deletions(-) diff --git

[PATCH v2 14/32] *: Add missing includes of qemu/error-report.h

2023-03-15 Thread Alex Bennée
From: Richard Henderson This had been pulled in via qemu/plugin.h from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-5-richard.hender...@linaro.org> [AJB: add various additional cases shown by

[PATCH v2 17/32] include/qemu/plugin: Inline qemu_plugin_disable_mem_helpers

2023-03-15 Thread Alex Bennée
From: Richard Henderson Now that we've broken the include loop with cpu.h, we can bring this inline. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-8-richard.hender...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/plugin.h |

[PATCH v2 20/32] iotests: strip subdir path when listing tests

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé When asking 'check' to list individual tests by invoking it in dry run mode, it prints the paths to the tests relative to the base of the I/O test directory. When asking 'check' to run an individual test, however, it mandates that only the unqualified test name is

[PATCH v2 18/32] iotests: explicitly pass source/build dir to 'check' command

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé The 'check' script has some rather dubious logic whereby it assumes that if invoked as a symlink, then it is running from a separate source tree and build tree, otherwise it assumes the current working directory is a combined source and build tree. This doesn't work if

[PATCH v2 21/32] iotests: print TAP protocol version when reporting tests

2023-03-15 Thread Alex Bennée
From: Daniel P. Berrangé Recently meson started complaining that TAP test reports don't include the TAP protocol version. While this warning is bogus and has since been removed from Meson, it looks like good practice to include this header going forward. The GLib library test harness has started

[PATCH v2 15/32] *: Add missing includes of qemu/plugin.h

2023-03-15 Thread Alex Bennée
From: Richard Henderson This had been pulled in from hw/core/cpu.h, but that will be removed. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20230310195252.210956-6-richard.hender...@linaro.org> [AJB: also syscall-trace.h] Signed-off-by: Alex Bennée ---

[PATCH v2 03/32] scripts/ci: add libslirp-devel to build-environment

2023-03-15 Thread Alex Bennée
Without libslip enabled we won't have user networking which means the KVM tests won't run. Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée --- scripts/ci/org.centos/stream/8/build-environment.yml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 32/32] contrib/gitdm: add group map for AMD

2023-03-15 Thread Alex Bennée
AMD recently acquired Xilinx and contributors have been transitioning their emails across. Signed-off-by: Alex Bennée Cc: Vikram Garhwal Cc: Stefano Stabellini Cc: Sai Pavan Boddu Cc: Tong Ho Reviewed-by: Francisco Iglesias Message-Id: <20230310180332.2274827-11-alex.ben...@linaro.org> ---

[PATCH v2 01/32] tests/avocado: update AArch64 tests to Alpine 3.17.2

2023-03-15 Thread Alex Bennée
From: Marcin Juszkiewicz To test Alpine boot on SBSA-Ref target we need Alpine Linux 'standard' image as 'virt' one lacks kernel modules. So to minimalize Avocado cache I move test to 'standard' image. Signed-off-by: Marcin Juszkiewicz Reviewed-by: Philippe Mathieu-Daudé Message-Id:

[PATCH v2 04/32] scripts/ci: update gitlab-runner playbook to handle CentOS

2023-03-15 Thread Alex Bennée
This was broken when we moved to using the pre-built packages as we didn't take care to ensure we used RPMs where required. NB: I could never get this to complete on my test setup but I suspect this was down to network connectivity and timeouts while downloading. Fixes: 69c4befba1 (scripts/ci:

[PATCH v2 00/32] tweaks and fixes for 8.0-rc1 (tests, plugins, docs)

2023-03-15 Thread Alex Bennée
As usual for softfreeze I switch from my usual maintainer trees to collecting up miscellaneous fixes and tweaks as we stabilise the build. I was intending to send it as a PR but I had to squash a number of CI failures by adding stuff to: *: Add missing includes of qemu/error-report.h

Re: [PATCH] vdpa: fix emulated guest announce feature status handling

2023-03-15 Thread Gautam Dawar
On 3/3/23 20:28, Eugenio Perez Martin wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Fri, Mar 3, 2023 at 12:58 PM Gautam Dawar wrote: Guest announce capability is emulated by qemu in the

Re: [PATCH v2 02/30] include/exec/memop: Add bits describing atomicity

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: These bits may be used to describe the precise atomicity requirements of the guest, which may then be used to constrain the methods by which it may be emulated by the host. For instance, the AArch64 LDP (32-bit) instruction changes semantics with

Re: [PATCH v2 14/30] tcg/i386: Add have_atomic16

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: Notice when Intel or AMD have guaranteed that vmovdqa is atomic. The new variable will also be used in generated code. Signed-off-by: Richard Henderson --- include/qemu/cpuid.h | 18 ++ tcg/i386/tcg-target.h | 1 +

Re: [PATCH v2 17/30] tcg/aarch64: Detect have_lse, have_lse2 for linux

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: Notice when the host has additional atomic instructions. The new variables will also be used in generated code. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 3 +++ tcg/aarch64/tcg-target.c.inc | 12 2 files

Re: [PATCH v2 18/30] tcg/aarch64: Detect have_lse, have_lse2 for darwin

2023-03-15 Thread Philippe Mathieu-Daudé
On 16/2/23 03:57, Richard Henderson wrote: These features are present for Apple M1. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.c.inc | 28 1 file changed, 28 insertions(+) Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

  1   2   >