Re: Re: [PULL 11/73] cryptodev: Support query-stats QMP command

2023-05-02 Thread zhenwei pi
On 5/3/23 01:03, Peter Maydell wrote: On Wed, 8 Mar 2023 at 01:11, Michael S. Tsirkin wrote: From: zhenwei pi Now we can use "query-stats" QMP command to query statistics of crypto devices. (Originally this was designed to show statistics by '{"execute": "query-cryptodev"}'. Daniel

Re: [PULL 61/73] hw/pci/aer: Implement PCI_ERR_UNCOR_MASK register

2023-05-02 Thread Michael S. Tsirkin
On Tue, May 02, 2023 at 09:32:34PM -0300, Leonardo Brás wrote: > Hello Michael, Juan, Peter, > > On Wed, 2023-04-26 at 09:19 +0200, Juan Quintela wrote: > > "Michael S. Tsirkin" wrote: > > > On Tue, Apr 25, 2023 at 08:42:17PM -0400, Peter Xu wrote: > > > > Hi, Michael, Jonathan, > > > > > > > >

[RFC PATCH 1/4] spapr: H_ENTER_NESTED should restore host XER ca field

2023-05-02 Thread Nicholas Piggin
Fix missing env->ca restore when going from L2 back to the host. Fixes: 120f738a467 ("spapr: implement nested-hv capability for the virtual hypervisor") Signed-off-by: Nicholas Piggin --- hw/ppc/spapr_hcall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/spapr_hcall.c

[RFC PATCH 4/4] spapr: Move spapr nested HV to a new file

2023-05-02 Thread Nicholas Piggin
Create spapr_nested.c for the nested HV implementation (modulo small pieces in MMU and exception handling). Signed-off-by: Nicholas Piggin --- hw/ppc/meson.build | 1 + hw/ppc/spapr_hcall.c | 429 +-- hw/ppc/spapr_nested.c | 496

[RFC PATCH 3/4] spapr: load and store l2 state with helper functions

2023-05-02 Thread Nicholas Piggin
Arguably this is just shuffling around register accesses, but one nice thing it does is allow the exit to save away the L2 state then switch the environment to the L1 before copying L2 data back to the L1, which logically flows more naturally and simplifies the error paths. Signed-off-by:

[RFC PATCH 2/4] spapr: Add a nested state struct

2023-05-02 Thread Nicholas Piggin
Rather than use a copy of CPUPPCState to store the host state while the environment has been switched to the L2, use a new struct for this purpose. Have helper functions to save and load this host state. Signed-off-by: Nicholas Piggin --- hw/ppc/spapr_hcall.c| 164

[RFC PATCH 0/4] spapr: clean up nested hv

2023-05-02 Thread Nicholas Piggin
Something like this is the way I'd been wanting to refactor nested hv. The state load/store functions and data is (somewhat) abstracted, and the hcall interface remains in the hcall handlers. If, hypothetically, you had a new flavour of nested enter hcall that had some other way of specifying the

Re: [PULL 61/73] hw/pci/aer: Implement PCI_ERR_UNCOR_MASK register

2023-05-02 Thread Leonardo Brás
Hello Michael, Juan, Peter, On Wed, 2023-04-26 at 09:19 +0200, Juan Quintela wrote: > "Michael S. Tsirkin" wrote: > > On Tue, Apr 25, 2023 at 08:42:17PM -0400, Peter Xu wrote: > > > Hi, Michael, Jonathan, > > > > > > On Tue, Mar 07, 2023 at 08:13:53PM -0500, Michael S. Tsirkin wrote: > > > This

[PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-02 Thread Leonardo Bras
Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK set for machine types < 8.0 will cause migration to fail if the target QEMU version is < 8.0.0 : qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10a read: 40 device: 0 cmask: ff wmask: 0 w1cmask:0

[PULL v3 04/10] xen-hvm: reorganize xen-hvm and move common function to xen-hvm-common

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini This patch does following: 1. creates arch_handle_ioreq() and arch_xen_set_memory(). This is done in preparation for moving most of xen-hvm code to an arch-neutral location, move the x86-specific portion of xen_set_memory to arch_xen_set_memory. Also, move

[PULL v3 05/10] include/hw/xen/xen_common: return error from xen_create_ioreq_server

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini This is done to prepare for enabling xenpv support for ARM architecture. On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails, continue to the PV backends initialization.

[PULL v3 03/10] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini In preparation to moving most of xen-hvm code to an arch-neutral location, move: - shared_vmport_page - log_for_dirtybit - dirty_bitmap - suspend - wakeup out of XenIOState struct as these are only used on x86, especially the ones related to dirty logging. Updated

[PULL v3 08/10] meson.build: do not set have_xen_pci_passthrough for aarch64 targets

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini have_xen_pci_passthrough is only used for Xen x86 VMs. Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/meson.build b/meson.build index 77d42898c8..000ef06bfa 100644 --- a/meson.build +++

[PULL v3 09/10] hw/arm: introduce xenpvh machine

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal Add a new machine xenpvh which creates a IOREQ server to register/connect with Xen Hypervisor. Optional: When CONFIG_TPM is enabled, it also creates a tpm-tis-device, adds a TPM emulator and connects to swtpm running on host machine via chardev socket and support TPM

[PULL v3 06/10] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure

2023-05-02 Thread Stefano Stabellini
From: Stefano Stabellini On ARM it is possible to have a functioning xenpv machine with only the PV backends and no IOREQ server. If the IOREQ server creation fails continue to the PV backends initialization. Also, moved the IOREQ registration and mapping subroutine to new function

[PULL v3 10/10] meson.build: enable xenpv machine build for ARM

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal Add CONFIG_XEN for aarch64 device to support build for ARM targets. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée --- meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meson.build b/meson.build

[PULL v3 07/10] hw/xen/xen-hvm-common: Use g_new and error_report

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal Replace g_malloc with g_new and perror with error_report. Signed-off-by: Vikram Garhwal Reviewed-by: Stefano Stabellini Reviewed-by: Paul Durrant --- hw/xen/xen-hvm-common.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PULL v3 01/10] hw/i386/xen/: move xen-mapcache.c to hw/xen/

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal xen-mapcache.c contains common functions which can be used for enabling Xen on aarch64 with IOREQ handling. Moving it out from hw/i386/xen to hw/xen to make it accessible for both aarch64 and x86. Signed-off-by: Vikram Garhwal Signed-off-by: Stefano Stabellini

[PULL v3 0/10] xenpvh3-tag

2023-05-02 Thread Stefano Stabellini
Cheers, Stefano The following changes since commit 4ebc33f3f3b656ebf62112daca6aa0f8019b4891: Merge tag 'pull-tcg-20230502-2' of https://gitlab.com/rth7680/qemu into staging (2023-05-02 21:18:45 +0100) are available in the Git repository at: https://gitlab.com/sstabellini/qemu xenpvh3-tag

[PULL v3 02/10] hw/i386/xen: rearrange xen_hvm_init_pc

2023-05-02 Thread Stefano Stabellini
From: Vikram Garhwal In preparation to moving most of xen-hvm code to an arch-neutral location, move non IOREQ references to: - xen_get_vmport_regs_pfn - xen_suspend_notifier - xen_wakeup_notifier - xen_ram_init towards the end of the xen_hvm_init_pc() function. This is done to keep the common

Re: [PATCH 3/8] migration: Add precopy initial data loaded ACK functionality

2023-05-02 Thread Peter Xu
On Mon, May 01, 2023 at 05:01:36PM +0300, Avihai Horon wrote: > Add the core functionality of precopy initial data, which allows the > destination to ACK that initial data has been loaded and the source to > wait for this ACK before completing the migration. > > A new return path command

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-02 Thread Peter Xu
(I've left high level comment in cover letter, but still some quick comments I noticed when reading) On Mon, May 01, 2023 at 05:01:35PM +0300, Avihai Horon wrote: > Add precopy initial data handshake between source and destination upon > migration setup. The purpose of the handshake is to notify

Re: [PATCH 0/8] migration: Add precopy initial data capability and VFIO precopy support

2023-05-02 Thread Peter Xu
On Mon, May 01, 2023 at 05:01:33PM +0300, Avihai Horon wrote: > Hello everyone, Hi, Avihai, > === Flow of operation === > > To use precopy initial data, the capability must be enabled in the > source. > > As this capability must be supported also in the destination, a > handshake is performed

Re: [RFC PATCH 1/4] pci: add handling of Enable bit in ATS Control Register

2023-05-02 Thread Viktor Prutyanov
On Wed, Apr 26, 2023 at 8:32 AM Jason Wang wrote: > > > 在 2023/4/24 19:21, Viktor Prutyanov 写道: > > According to PCIe Address Translation Services specification 5.1.3., > > ATS Control Register has Enable bit to enable/disable ATS. > > Add a new field for a trigger function which is called at the

Re: [PATCH] migration: Attempt disk reactivation in more failure scenarios

2023-05-02 Thread Peter Xu
On Tue, May 02, 2023 at 03:52:12PM -0500, Eric Blake wrote: > Commit fe904ea824 added a fail_inactivate label, which tries to > reactivate disks on the source after a failure while s->state == > MIGRATION_STATUS_ACTIVE, but didn't actually use the label if > qemu_savevm_state_complete_precopy()

[PATCH] block/export: call blk_set_dev_ops(blk, NULL, NULL)

2023-05-02 Thread Stefan Hajnoczi
Most export types install BlockDeviceOps pointers. It is easy to forget to remove them because that happens automatically via the "drive" qdev property in hw/ but not block/export/. Put blk_set_dev_ops(blk, NULL, NULL) calls in the core export.c code so the export types don't need to remember.

Re: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:20PM +0300, Vladimir Sementsov-Ogievskiy wrote: > colo_checkpoint_notify() is mostly used in colo.c. Outside we use it > once when x-checkpoint-delay migration parameter is set. So, let's > simplify the external API to only that function - notify COLO that > parameter

Re: [PATCH v4 10/10] migration: block incoming colo when capability is disabled

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:28PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We generally require same set of capabilities on source and target. > Let's require x-colo capability to use COLO on target. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v4 09/10] migration: disallow change capabilities in COLO state

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:27PM +0300, Vladimir Sementsov-Ogievskiy wrote: > COLO is not listed as running state in migrate_is_running(), so, it's > theoretically possible to disable colo capability in COLO state and the > unexpected error in migration_iteration_finish() is reachable. > >

Re: [PATCH v4 08/10] migration: process_incoming_migration_co(): move colo part to colo

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:26PM +0300, Vladimir Sementsov-Ogievskiy wrote: > +int coroutine_fn colo_incoming_co(void) > +{ > +MigrationIncomingState *mis = migration_incoming_get_current(); > +Error *local_err = NULL; > +QemuThread th; > + > +

[PATCH] migration: Attempt disk reactivation in more failure scenarios

2023-05-02 Thread Eric Blake
Commit fe904ea824 added a fail_inactivate label, which tries to reactivate disks on the source after a failure while s->state == MIGRATION_STATUS_ACTIVE, but didn't actually use the label if qemu_savevm_state_complete_precopy() failed. This failure to reactivate is also present in commit

Re: [PATCH v4 07/10] migration: split migration_incoming_co

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:25PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Originally, migration_incoming_co was introduced by > 25d0c16f625feb3b6 >"migration: Switch to COLO process after finishing loadvm" > to be able to enter from COLO code to one specific yield point, added > by

Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-02 Thread BALATON Zoltan
On Tue, 2 May 2023, Peter Maydell wrote: When we take a PNG screenshot the ordering of the colour channels in the data is not correct, resulting in the image having weird colouring compared to the actual display. (Specifically, on a little-endian host the blue and red channels are swapped; on

[PULL v2 03/12] qemu/bitops.h: Limit rotate amounts

2023-05-02 Thread Richard Henderson
From: Dickon Hood Rotates have been fixed up to only allow for reasonable rotate amounts (ie, no rotates >7 on an 8b value etc.) This fixes a problem with riscv vector rotate instructions. Signed-off-by: Dickon Hood Reviewed-by: Richard Henderson Message-Id:

[PULL v2 00/12] tcg patch queue

2023-05-02 Thread Richard Henderson
The following changes since commit c586691e676214eb7edf6a468e84e7ce3b314d43: Merge tag 'pull-target-arm-20230502-2' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-05-02 16:38:29 +0100) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags

Re: [PATCH v2] migration: Handle block device inactivation failures better

2023-05-02 Thread Eric Blake
On Tue, May 02, 2023 at 11:54:12AM +0200, Kevin Wolf wrote: > Hi Eric, > > you asked me for a review downstream, but since you would have to bring > back any problem to upstream anyway, let's discuss it here. For the > start, let me state that (a) I don't fully understand why this patch > fixes

Re: [PATCH v3 08/19] qemu/bitops.h: Limit rotate amounts

2023-05-02 Thread Richard Henderson
On 4/28/23 15:47, Lawrence Hunter wrote: static inline uint32_t ror32(uint32_t word, unsigned int shift) { -return (word >> shift) | (word << ((32 - shift) & 31)); +shift &= 31; +return (word >> shift) | (word << (32 - shift)); This is incorrect, because if shift == 0, you are

Re: [PATCH v4 10/20] block: drain from main loop thread in bdrv_co_yield_to_drain()

2023-05-02 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 06:21:20PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > For simplicity, always run BlockDevOps .drained_begin/end/poll() > > callbacks in the main loop thread. This makes it easier to implement the > > callbacks and avoids extra

Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server

2023-05-02 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > vhost-user activity must be suspended during bdrv_drained_begin/end(). > > This prevents new requests from interfering with whatever is happening > > in the drained section. >

Re: [PATCH v4 04/20] virtio-scsi: stop using aio_disable_external() during unplug

2023-05-02 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 03:19:52PM +0200, Kevin Wolf wrote: > Am 01.05.2023 um 17:09 hat Stefan Hajnoczi geschrieben: > > On Fri, Apr 28, 2023 at 04:22:55PM +0200, Kevin Wolf wrote: > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > > > This patch is part of an effort to remove the

Re: [PATCH v3 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

2023-05-02 Thread Niek Linnenbank
Hi Qianfan, Sorry for my late response, I had a holiday in between. On Tue, Apr 18, 2023 at 1:21 PM wrote: > From: qianfan Zhao > > Allwinner R40 (sun8i) SoC features a Quad-Core Cortex-A7 ARM CPU, > and a Mali400 MP2 GPU from ARM. It's also known as the Allwinner T3 > for In-Car

Re: [PATCH] softfloat: Fix the incorrect computation in float32_exp2()

2023-05-02 Thread Richard Henderson
On 5/2/23 16:25, Shivaprasad G Bhat wrote: The float32_exp2() is computing wrong exponent of 2. For example, with the following set of values {0.1, 2.0, 2.0, -1.0}, the expected output would be {1.071773, 4.00, 4.00, 0.50}. Instead, the function is computing {1.119102, 3.382044,

Re: [PATCH v4 06/20] block/export: wait for vhost-user-blk requests when draining

2023-05-02 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 05:42:51PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > > Each vhost-user-blk request runs in a coroutine. When the BlockBackend > > enters a drained section we need to enter a quiescent state. Currently > > any in-flight requests

Re: [PATCH] tests/avocado/virtio-gpu: Fix the URLs of the test_virtio_vga_virgl test

2023-05-02 Thread Marc-André Lureau
On Tue, May 2, 2023 at 2:57 PM Thomas Huth wrote: > The URLs here are not valid anymore - looks like the assets got moved > into the pub/archive/ subfolder instead. > > Signed-off-by: Thomas Huth > Reviewed-by: Marc-André Lureau > --- > tests/avocado/virtio-gpu.py | 4 ++-- > 1 file

Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

2023-05-02 Thread Marc-André Lureau
On Tue, May 2, 2023 at 5:56 PM Peter Maydell wrote: > When we take a PNG screenshot the ordering of the colour channels in > the data is not correct, resulting in the image having weird > colouring compared to the actual display. (Specifically, on a > little-endian host the blue and red

Re: [PATCH v3 00/57] tcg: Improve atomicity support

2023-05-02 Thread Richard Henderson
On 5/2/23 17:11, Peter Maydell wrote: On Tue, 25 Apr 2023 at 20:32, Richard Henderson wrote: v1: https://lore.kernel.org/qemu-devel/20221118094754.242910-1-richard.hender...@linaro.org/ v2: https://lore.kernel.org/qemu-devel/20230216025739.1211680-1-richard.hender...@linaro.org/ Based-on:

Re: [QEMU][PATCH v4 2/4] hw/net/can: Introduce Xilinx Versal CANFD controller

2023-05-02 Thread Francisco Iglesias
Hi Vikram, A few comments below and some suggestions! On [2023 Apr 24] Mon 23:34:31, Vikram Garhwal wrote: > The Xilinx Versal CANFD controller is developed based on SocketCAN, QEMU CAN > bus > implementation. Bus connection and socketCAN connection for each CAN module > can be set through

RE: [PATCH 3/9] target/Hexagon: Finish conversion to tcg_gen_qemu_{ld,st}_*

2023-05-02 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Tuesday, May 2, 2023 10:49 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Subject: Re: [PATCH 3/9] target/Hexagon: Finish conversion to > tcg_gen_qemu_{ld,st}_* > > On 5/2/23 16:27, Taylor Simpson wrote: > > > > > >>

Re: [PATCH] block/blkio: add 'fd' option to virtio-blk-vhost-vdpa driver

2023-05-02 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 04:50:50PM +0200, Stefano Garzarella wrote: > The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new > 'fd' property. Let's expose this to the user, so the management layer > can pass the file descriptor of an already opened vhost-vdpa character > device. This

[PATCH 2/3] target/openrisc: Set PC to cpu state on FPU exception

2023-05-02 Thread Stafford Horne
Store the PC to ensure the correct value can be read in the exception handler. Signed-off-by: Stafford Horne --- target/openrisc/fpu_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target/openrisc/fpu_helper.c b/target/openrisc/fpu_helper.c index f9e34fa2cc..1feebb9ac7 100644

[PATCH 1/3] target/openrisc: Allow fpcsr access in user mode

2023-05-02 Thread Stafford Horne
As per OpenRISC spec 1.4 FPCSR can be read and written in user mode. Update mtspr and mfspr helpers to support this by moving the is_user check into the helper. There is a logic change here to no longer throw an illegal instruction exception when executing mtspr/mfspr in user mode. The illegal

[PATCH 3/3] target/openrisc: Setup FPU for detecting tininess before rounding

2023-05-02 Thread Stafford Horne
OpenRISC defines tininess to be detected before rounding. Setup qemu to obey this. Signed-off-by: Stafford Horne --- target/openrisc/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c index 0ce4f796fa..cdbff26fb5 100644 ---

[PATCH 0/3] OpenRISC updates for user space FPU

2023-05-02 Thread Stafford Horne
This series adds support for the FPU related architecture changes defined in architecture spec revision v1.4. - https://openrisc.io/revisions/r1.4 In summary the architecture changes are: - Change FPCSR SPR permissions to allow for reading and writing from user space. - Clarify that FPU

Re: [PATCH v4 03/20] virtio-scsi: avoid race between unplug and transport event

2023-05-02 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 05:19:46PM +0200, Kevin Wolf wrote: > Am 25.04.2023 um 19:26 hat Stefan Hajnoczi geschrieben: > > Only report a transport reset event to the guest after the SCSIDevice > > has been unrealized by qdev_simple_device_unplug_cb(). > > > > qdev_simple_device_unplug_cb() sets

[PATCH 0/2] aio-posix: do not nest poll handlers

2023-05-02 Thread Stefan Hajnoczi
The following stack exhaustion was reported in https://bugzilla.redhat.com/show_bug.cgi?id=2186181: ... #51 0x55884fca7451 aio_poll (qemu-kvm + 0x9d6451) #52 0x55884fab9cbd bdrv_poll_co (qemu-kvm + 0x7e8cbd) #53 0x55884fab654b blk_io_plug (qemu-kvm + 0x7e554b) #54

[PATCH 2/2] tested: add test for nested aio_poll() in poll handlers

2023-05-02 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi --- tests/unit/test-nested-aio-poll.c | 130 ++ tests/unit/meson.build| 1 + 2 files changed, 131 insertions(+) create mode 100644 tests/unit/test-nested-aio-poll.c diff --git a/tests/unit/test-nested-aio-poll.c

[PATCH 1/2] aio-posix: do not nest poll handlers

2023-05-02 Thread Stefan Hajnoczi
QEMU's event loop supports nesting, which means that event handler functions may themselves call aio_poll(). The condition that triggered a handler must be reset before the nested aio_poll() call, otherwise the same handler will be called and immediately re-enter aio_poll. This leads to an

Re: [PULL 0/3] Various fixes

2023-05-02 Thread Richard Henderson
On 5/2/23 11:18, Thomas Huth wrote: Hi Richard! The following changes since commit 7c18f2d663521f1b31b821a13358ce38075eaf7d: Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-04-29 23:07:17 +0100) are available in the Git repository at:

Re: [PULL v2 00/34] target-arm queue

2023-05-02 Thread Richard Henderson
: Merge tag 'for-upstream' ofhttps://gitlab.com/bonzini/qemu into staging (2023-04-29 23:07:17 +0100) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20230502-2 for you to fetch changes up

Re: [PATCH v4 02/10] colo: make colo_checkpoint_notify static and provide simpler API

2023-05-02 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > colo_checkpoint_notify() is mostly used in colo.c. Outside we use it > once when x-checkpoint-delay migration parameter is set. So, let's > simplify the external API to only that function - notify COLO that > parameter was set. This make external API more

Re: [PATCH v4 06/10] migration: process_incoming_migration_co: simplify code flow around ret

2023-05-02 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela

Re: [PATCH v4 05/10] migration: drop colo_incoming_thread from MigrationIncomingState

2023-05-02 Thread Juan Quintela
Vladimir Sementsov-Ogievskiy wrote: > have_colo_incoming_thread variable is unused. colo_incoming_thread can > be local. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Juan Quintela

Re: [PATCH v20 03/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-05-02 Thread Nina Schoetterl-Glausch
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > On interception of STSI(15.1.x) the System Information Block > (SYSIB) is built from the list of pre-ordered topology entries. > > Signed-off-by: Pierre Morel > --- > MAINTAINERS | 1 + >

Re: [PATCH v11 00/13] target/arm: Allow CONFIG_TCG=n builds

2023-05-02 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Maydell writes: > >> On Tue, 2 May 2023 at 15:51, Peter Maydell wrote: >>> >>> On Tue, 2 May 2023 at 10:55, Peter Maydell wrote: >>> > >>> > On Wed, 26 Apr 2023 at 19:00, Fabiano Rosas wrote: >>> > > >>> > > Hi, >>> > > >>> > > Some minor changes: >>> > > >>> >

Re: [PULL 05/27] hw/xen: Watches on XenStore transactions

2023-05-02 Thread Peter Maydell
On Tue, 7 Mar 2023 at 18:27, David Woodhouse wrote: > > From: David Woodhouse > > Firing watches on the nodes that still exist is relatively easy; just > walk the tree and look at the nodes with refcount of one. > > Firing watches on *deleted* nodes is more fun. We add 'modified_in_tx' > and

Re: [PULL 11/73] cryptodev: Support query-stats QMP command

2023-05-02 Thread Peter Maydell
On Wed, 8 Mar 2023 at 01:11, Michael S. Tsirkin wrote: > > From: zhenwei pi > > Now we can use "query-stats" QMP command to query statistics of > crypto devices. (Originally this was designed to show statistics > by '{"execute": "query-cryptodev"}'. Daniel Berrangé suggested that > querying

Re: [PATCH v4 06/10] migration: process_incoming_migration_co: simplify code flow around ret

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:24PM +0300, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v4 05/10] migration: drop colo_incoming_thread from MigrationIncomingState

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:23PM +0300, Vladimir Sementsov-Ogievskiy wrote: > have_colo_incoming_thread variable is unused. colo_incoming_thread can > be local. > > Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu -- Peter Xu

Re: [PATCH v4 03/10] build: move COLO under CONFIG_REPLICATION

2023-05-02 Thread Peter Xu
On Fri, Apr 28, 2023 at 10:49:21PM +0300, Vladimir Sementsov-Ogievskiy wrote: > We don't allow to use x-colo capability when replication is not > configured. So, no reason to build COLO when replication is disabled, > it's unusable in this case. > > Note also that the check in

Re: [PATCH v11 00/13] target/arm: Allow CONFIG_TCG=n builds

2023-05-02 Thread Fabiano Rosas
Peter Maydell writes: > On Tue, 2 May 2023 at 15:51, Peter Maydell wrote: >> >> On Tue, 2 May 2023 at 10:55, Peter Maydell wrote: >> > >> > On Wed, 26 Apr 2023 at 19:00, Fabiano Rosas wrote: >> > > >> > > Hi, >> > > >> > > Some minor changes: >> > > >> > > - new patch to move a test under

Re: [PATCH v4 10/20] block: drain from main loop thread in bdrv_co_yield_to_drain()

2023-05-02 Thread Kevin Wolf
Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > For simplicity, always run BlockDevOps .drained_begin/end/poll() > callbacks in the main loop thread. This makes it easier to implement the > callbacks and avoids extra locks. > > Move the function pointer declarations from the I/O Code

Re: [PATCH v3 00/57] tcg: Improve atomicity support

2023-05-02 Thread Peter Maydell
On Tue, 25 Apr 2023 at 20:32, Richard Henderson wrote: > > v1: > https://lore.kernel.org/qemu-devel/20221118094754.242910-1-richard.hender...@linaro.org/ > v2: > https://lore.kernel.org/qemu-devel/20230216025739.1211680-1-richard.hender...@linaro.org/ > > Based-on:

[PATCH 03/16] target/alpha: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configs/targets/alpha-linux-user.mak | 1 - configs/targets/alpha-softmmu.mak| 1 - 2 files changed, 2 deletions(-) diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-linux-user.mak index 7e62fd796a..f7d3fb4afa 100644 ---

[PATCH 01/16] target/alpha: Use MO_ALIGN for system UNALIGN()

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/alpha/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index 9d25e21164..ffbac1c114 100644 --- a/target/alpha/translate.c +++ b/target/alpha/translate.c @@ -72,7 +72,7

[PATCH 08/16] target/mips: Use MO_ALIGN instead of 0

2023-05-02 Thread Richard Henderson
The opposite of MO_UNALN is MO_ALIGN. Signed-off-by: Richard Henderson --- target/mips/tcg/nanomips_translate.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/tcg/nanomips_translate.c.inc b/target/mips/tcg/nanomips_translate.c.inc index

[PATCH 15/16] target/sparc: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configs/targets/sparc-linux-user.mak | 1 - configs/targets/sparc-softmmu.mak | 1 - configs/targets/sparc32plus-linux-user.mak | 1 - configs/targets/sparc64-linux-user.mak | 1 - configs/targets/sparc64-softmmu.mak| 1 - 5 files

[PATCH 09/16] target/mips: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configs/targets/mips-linux-user.mak | 1 - configs/targets/mips-softmmu.mak | 1 - configs/targets/mips64-linux-user.mak| 1 - configs/targets/mips64-softmmu.mak | 1 - configs/targets/mips64el-linux-user.mak | 1 -

[PATCH 00/16] tcg: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
Based-on: 20230502135741.1158035-1-richard.hender...@linaro.org ("[PATCH 0/9] tcg: Remove compatability helpers for qemu ld/st") Add MO_ALIGN where required, so that we may remove TARGET_ALIGNED_ONLY. This is required for building tcg once, because we cannot have multiple definitions of MO_ALIGN

[PATCH 05/16] target/hppa: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configs/targets/hppa-linux-user.mak | 1 - configs/targets/hppa-softmmu.mak| 1 - 2 files changed, 2 deletions(-) diff --git a/configs/targets/hppa-linux-user.mak b/configs/targets/hppa-linux-user.mak index db873a8796..361ea39d71 100644 ---

[PATCH 12/16] target/sh4: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- configs/targets/sh4-linux-user.mak | 1 - configs/targets/sh4-softmmu.mak | 1 - configs/targets/sh4eb-linux-user.mak | 1 - configs/targets/sh4eb-softmmu.mak| 1 - 4 files changed, 4 deletions(-) diff --git a/configs/targets/sh4-linux-user.mak

[PATCH 06/16] target/mips: Add MO_ALIGN to gen_llwp, gen_scwp

2023-05-02 Thread Richard Henderson
These are atomic operations, so mark as requiring alignment. Signed-off-by: Richard Henderson --- target/mips/tcg/nanomips_translate.c.inc | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/mips/tcg/nanomips_translate.c.inc

[PATCH 14/16] target/sparc: Use cpu_ld*_code_mmu

2023-05-02 Thread Richard Henderson
This passes on the memop as given as argument to helper_ld_asi to the ultimate load primitive. Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/sparc/ldst_helper.c b/target/sparc/ldst_helper.c

[PATCH 11/16] target/sh4: Use MO_ALIGN where required

2023-05-02 Thread Richard Henderson
Mark all memory operations that are not already marked with UNALIGN. Signed-off-by: Richard Henderson --- target/sh4/translate.c | 102 ++--- 1 file changed, 66 insertions(+), 36 deletions(-) diff --git a/target/sh4/translate.c b/target/sh4/translate.c index

[PATCH 13/16] target/sparc: Use MO_ALIGN where required

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/translate.c | 66 +--- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index bc71e44e66..414e014b11 100644 --- a/target/sparc/translate.c +++

[PATCH 07/16] target/mips: Add missing default_tcg_memop_mask

2023-05-02 Thread Richard Henderson
Memory operations that are not already aligned, or otherwise marked up, require addition of ctx->default_tcg_memop_mask. Signed-off-by: Richard Henderson --- target/mips/tcg/mxu_translate.c | 3 ++- target/mips/tcg/micromips_translate.c.inc | 24 ++

[PATCH 16/16] tcg: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
All uses have now been expunged. Signed-off-by: Richard Henderson --- include/exec/memop.h | 13 ++--- include/exec/poison.h | 1 - tcg/tcg.c | 5 - 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/include/exec/memop.h b/include/exec/memop.h index

[PATCH 10/16] target/nios2: Remove TARGET_ALIGNED_ONLY

2023-05-02 Thread Richard Henderson
In gen_ldx/gen_stx, the only two locations for memory operations, mark the operation as either aligned (softmmu) or unaligned (user-only, as if emulated by the kernel). Signed-off-by: Richard Henderson --- configs/targets/nios2-softmmu.mak | 1 - target/nios2/translate.c | 10

[PATCH 02/16] target/alpha: Use MO_ALIGN where required

2023-05-02 Thread Richard Henderson
Mark all memory operations that are not already marked with UNALIGN. Signed-off-by: Richard Henderson --- target/alpha/translate.c | 36 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/target/alpha/translate.c b/target/alpha/translate.c index

[PATCH 04/16] target/hppa: Use MO_ALIGN for system UNALIGN()

2023-05-02 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6a3154ebc6..59e4688bfa 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -271,7 +271,7 @@

Re: [PATCH v11 00/13] target/arm: Allow CONFIG_TCG=n builds

2023-05-02 Thread Peter Maydell
On Tue, 2 May 2023 at 15:51, Peter Maydell wrote: > > On Tue, 2 May 2023 at 10:55, Peter Maydell wrote: > > > > On Wed, 26 Apr 2023 at 19:00, Fabiano Rosas wrote: > > > > > > Hi, > > > > > > Some minor changes: > > > > > > - new patch to move a test under CONFIG_TCG (broken on master); > > > -

Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server

2023-05-02 Thread Kevin Wolf
Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > vhost-user activity must be suspended during bdrv_drained_begin/end(). > This prevents new requests from interfering with whatever is happening > in the drained section. > > Previously this was done using aio_set_fd_handler()'s is_external

Re: proposed schedule for 8.1 release

2023-05-02 Thread Richard Henderson
On 5/2/23 15:44, Peter Maydell wrote: Hi; I figured we could put some dates into the proposed 8.1 schedule. Here's a starter: 2023-07-11 Soft feature freeze 2023-07-18 Hard feature freeze. Tag rc0 2023-07-25 Tag rc1 2023-08-01 Tag rc2 2023-08-08 Tag rc3 2023-08-15 Release; or tag rc4 if needed

RE: [PATCH 9/9] tcg: Remove compatability helpers for qemu ld/st

2023-05-02 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Tuesday, May 2, 2023 8:58 AM > To: qemu-devel@nongnu.org > Cc: mrol...@gmail.com; edgar.igles...@gmail.com; Taylor Simpson > ; a...@rev.ng; a...@rev.ng; laur...@vivier.eu; > phi...@linaro.org; jiaxun.y...@flygoat.com;

Re: [PATCH 3/9] target/Hexagon: Finish conversion to tcg_gen_qemu_{ld,st}_*

2023-05-02 Thread Richard Henderson
On 5/2/23 16:27, Taylor Simpson wrote: -Original Message- From: Richard Henderson Sent: Tuesday, May 2, 2023 8:58 AM To: qemu-devel@nongnu.org Cc: mrol...@gmail.com; edgar.igles...@gmail.com; Taylor Simpson ; a...@rev.ng; a...@rev.ng; laur...@vivier.eu; phi...@linaro.org;

Re: [PATCH] linux-user: Add /proc/cpuinfo handler for RISC-V

2023-05-02 Thread Andreas Schwab
On Mai 02 2023, Palmer Dabbelt wrote: > On Tue, 02 May 2023 06:44:00 PDT (-0700), sch...@suse.de wrote: >> Signed-off-by: Andreas Schwab >> --- >> linux-user/syscall.c | 30 -- >> 1 file changed, 28 insertions(+), 2 deletions(-) >> >> diff --git

Re: [PATCH v4 06/20] block/export: wait for vhost-user-blk requests when draining

2023-05-02 Thread Kevin Wolf
Am 25.04.2023 um 19:27 hat Stefan Hajnoczi geschrieben: > Each vhost-user-blk request runs in a coroutine. When the BlockBackend > enters a drained section we need to enter a quiescent state. Currently > any in-flight requests race with bdrv_drained_begin() because it is > unaware of

Re: [PATCH v2 00/10] Kconfig vs. default devices

2023-05-02 Thread Alex Bennée
Fabiano Rosas writes: > v2: > Applying the feedback received, all small tweaks. > > Patch 6 still needs consensus on whether to apply the fix to Kconfig > or elsewhere. Link to the previous version: > https://lore.kernel.org/r/461ba038-31bf-49c4-758b-94ece36f1...@redhat.com > > changelog: > >

RE: [PATCH 3/9] target/Hexagon: Finish conversion to tcg_gen_qemu_{ld,st}_*

2023-05-02 Thread Taylor Simpson
> -Original Message- > From: Richard Henderson > Sent: Tuesday, May 2, 2023 8:58 AM > To: qemu-devel@nongnu.org > Cc: mrol...@gmail.com; edgar.igles...@gmail.com; Taylor Simpson > ; a...@rev.ng; a...@rev.ng; laur...@vivier.eu; > phi...@linaro.org; jiaxun.y...@flygoat.com;

[PATCH] softfloat: Fix the incorrect computation in float32_exp2()

2023-05-02 Thread Shivaprasad G Bhat
The float32_exp2() is computing wrong exponent of 2. For example, with the following set of values {0.1, 2.0, 2.0, -1.0}, the expected output would be {1.071773, 4.00, 4.00, 0.50}. Instead, the function is computing {1.119102, 3.382044, 3.382044, -0.191022} Looking at the code, the

Re: [PATCH v2 00/10] Kconfig vs. default devices

2023-05-02 Thread Alex Bennée
Thomas Huth writes: > On 08/02/2023 20.43, Philippe Mathieu-Daudé wrote: >> On 8/2/23 20:26, Fabiano Rosas wrote: >> >>> We currently have a situation where disabling a Kconfig might result >>> in a runtime error when QEMU selects the corresponding device as a >>> default value for an option.

  1   2   3   >