Am 22.05.23 um 10:08 schrieb Paolo Bonzini:
The large comment in the patch says it all; the -no-pie flag is broken and
this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614
("build: move remaining compiler flag tests to meson", 2023-05-18).
Resolves:
On 5/22/23 17:36, Ninad Palsule wrote:
The VPD data is added for system and BMC FRU. This data is fabricated.
Tested:
- The system-vpd.service is active.
- VPD service related to bmc is active.
Signed-off-by: Ninad Palsule
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
> > -QEMUCursor *cursor_alloc(int width, int height)
> > +QEMUCursor *cursor_alloc(uint32_t width, uint32_t height)
> > {
> > QEMUCursor *c;
>
> Can't we check width/height > 0 && <= SOME_LIMIT_THAT_MAKES_SENSE?
>
> Maybe a 16K * 16K cursor is future proof and safe
> 2023年5月23日 02:25,Song Gao 写道:
>
>
>
> 在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道:
>> On 22/5/23 13:47, Jiaxun Yang wrote:
>>>
>>>
2023年5月22日 04:52,Huacai Chen 写道:
Hi, Jiaxun,
Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS
and
> On 22-May-2023, at 11:30 PM, Thomas Huth wrote:
>
> On 21/05/2023 07.51, Michael S. Tsirkin wrote:
>> On Fri, May 19, 2023 at 08:44:18PM +0530, Ani Sinha wrote:
>>>
>>>
On 17-May-2023, at 12:23 PM, Ani Sinha wrote:
Biosbits avocado tests on gitlab has thus far been
On 5/22/23 04:20, Markus Armbruster wrote:
The following changes since commit aa222a8e4f975284b3f8f131653a4114b3d333b3:
Merge tag 'for_upstream' ofhttps://git.kernel.org/pub/scm/virt/kvm/mst/qemu
into staging (2023-05-19 12:17:16 -0700)
are available in the Git repository at:
在 2023/5/15 2:55, Niek Linnenbank 写道:
Hi Qianfan,
On Wed, May 10, 2023 at 12:30 PM wrote:
From: qianfan Zhao
R40 has eight UARTs, support both 16450 and 16550 compatible modes.
Signed-off-by: qianfan Zhao
---
hw/arm/allwinner-r40.c | 31
On 2023/05/18 23:04, Tomasz Dzieciol wrote:
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/e1000e_core.c | 18 ++--
hw/net/igb_core.c| 214
On 2023/05/18 23:04, Tomasz Dzieciol wrote:
Refactoring is done in preparation for support of multiple advanced
descriptors RX modes, especially packet-split modes.
Signed-off-by: Tomasz Dzieciol
---
hw/net/igb_core.c | 178 +++-
hw/net/igb_regs.h
On 2023/05/18 23:04, Tomasz Dzieciol wrote:
Based-on: <20230423041833.5302-1-akihiko.od...@daynix.com>
("[PATCH v3 00/47] igb: Fix for DPDK")
Purposes of this series of patches:
* introduce packet-split RX descriptors support. This feature is used by Linux
VF driver for MTU values from 2048.
Signed-off-by: Akihiko Odaki
---
tests/avocado/netdev-ethtool.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/avocado/netdev-ethtool.py b/tests/avocado/netdev-ethtool.py
index f7e9464184..8de118e313 100644
--- a/tests/avocado/netdev-ethtool.py
+++ b/tests/avocado/netdev-ethtool.py
@@
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_regs.h | 32 +++-
hw/net/igb_core.c | 4 ++--
2 files changed, 29 insertions(+), 7 deletions(-)
diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h
index 21ee9a3b2d..eb995d8b2e 100644
---
igb has a configurable size limit for LPE, and uses different limits
depending on whether the packet is treated as a VLAN packet.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 36 +---
1 file changed, 21 insertions(+), 15
Keeping Tx packet state after the transmit queue is emptied but this
behavior is unreliable as the state can be reset anytime the migration
happens.
Always reset Tx packet state always after the queue is emptied.
Signed-off-by: Akihiko Odaki
---
hw/net/vmxnet3.c | 3 ++-
1 file changed, 2
In MSI-X mode, if there are interrupts already notified but not cleared
and a new interrupt arrives, e1000e incorrectly notifies the notified
ones again along with the new one.
To fix this issue, replace e1000e_update_interrupt_state() with
two new functions: e1000e_raise_interrupts() and
It is possible to have another VLAN tag even if the packet is already
tagged.
Signed-off-by: Akihiko Odaki
---
include/net/eth.h | 4 ++--
hw/net/net_tx_pkt.c | 16 +++-
net/eth.c | 22 ++
3 files changed, 15 insertions(+), 27 deletions(-)
diff
GPIE.Multiple_MSIX is not set by default, and needs to be set to get
interrupts from multiple MSI-X vectors.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
tests/qtest/libqos/igb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/libqos/igb.c
Without this change, the status flags may not be traced e.g. if checksum
offloading is disabled.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/e1000e_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/net/e1000e_core.c
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/net_tx_pkt.h | 8
hw/net/igb_core.c | 12 +++-
hw/net/net_tx_pkt.c | 18 ++
3 files changed, 33 insertions(+), 5 deletions(-)
diff --git a/hw/net/net_tx_pkt.h b/hw/net/net_tx_pkt.h
index
While the datasheet of e1000e says it checks CTRL.VME for tx VLAN
tagging, igb's datasheet has no such statements. It also says for
"CTRL.VLE":
> This register only affects the VLAN Strip in Rx it does not have any
> influence in the Tx path in the 82576.
(Appendix A. Changes from the 82575)
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_regs.h | 3 +++
hw/net/igb_core.c | 7 +++
2 files changed, 10 insertions(+)
diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h
index 894705599d..82ff195dfc 100644
--- a/hw/net/igb_regs.h
+++ b/hw/net/igb_regs.h
@@
For GPIE.NSICR, Section 7.3.2.1.2 says:
> ICR bits are cleared on register read. If GPIE.NSICR = 0b, then the
> clear on read occurs only if no bit is set in the IMS or at least one
> bit is set in the IMS and there is a true interrupt as reflected in
> ICR.INTA.
e1000e does similar though it
It is unlikely to find more bugs with KVM so remove test_igb_nomsi_kvm
to save time to run it.
Signed-off-by: Akihiko Odaki
Reviewed-by: Thomas Huth
Acked-by: Alex Bennée
---
tests/avocado/netdev-ethtool.py | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git
Section 7.3.4.1 says:
> When auto-clear is enabled for an interrupt cause, the EICR bit is
> set when a cause event mapped to this vector occurs. When the EITR
> Counter reaches zero, the MSI-X message is sent on PCIe. Then the
> EICR bit is cleared and enabled to be set by a new cause event
This follows the corresponding change for e1000e. This fixes:
tests/avocado/netdev-ethtool.py:NetDevEthtool.test_igb
Signed-off-by: Akihiko Odaki
---
hw/net/igb_core.c | 201 --
hw/net/trace-events | 11 +-
The datasheet says contradicting statements regarding ICR accesses so it
is not reliable to determine the behavior of ICR accesses. However,
e1000e does clear IMS bits when reading ICR accesses and Linux also
expects ICR accesses will clear IMS bits according to:
Section 7.2.2.3 Advanced Transmit Data Descriptor says:
> For frames that spans multiple descriptors, all fields apart from
> DCMD.EOP, DCMD.RS, DCMD.DEXT, DTALEN, Address and DTYP are valid only
> in the first descriptors and are ignored in the subsequent ones.
Signed-off-by: Akihiko Odaki
e1000e does not support using UDP for RSS hash, but igb does.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_regs.h | 3 +++
hw/net/igb_core.c | 16
2 files changed, 19 insertions(+)
diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h
index
Keeping Tx packet state after the transmit queue is emptied has some
problems:
- The datasheet says the descriptors can be reused after the transmit
queue is emptied, but the Tx packet state may keep references to them.
- The Tx packet state cannot be migrated so it can be reset anytime the
vmxnet3 has no dependency on PC, and VMware Fusion actually makes it
available on Apple Silicon according to:
https://kb.vmware.com/s/article/90364
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
eth_strip_vlan and eth_strip_vlan_ex refers to ehdr_buf as struct
eth_header. Enforce alignment for the structure.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/net_rx_pkt.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git
Rename variable "n" to "causes", which properly represents the content
of the variable.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index c954369964..6d55b43fb4 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -1873,7
Signed-off-by: Akihiko Odaki
---
hw/net/igb_common.h | 16 +++---
hw/net/igb_regs.h | 23
hw/net/igb_core.c | 129
3 files changed, 127 insertions(+), 41 deletions(-)
diff --git a/hw/net/igb_common.h b/hw/net/igb_common.h
index
igb does not properly ensure the buffer passed to
net_rx_pkt_set_protocols() is contiguous for the entire L2/L3/L4 header.
Allow it to pass scattered data to net_rx_pkt_set_protocols().
Fixes: 3a977deebe ("Intrdocue igb device emulation")
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram
Signed-off-by: Akihiko Odaki
---
docs/system/devices/igb.rst | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/docs/system/devices/igb.rst b/docs/system/devices/igb.rst
index afe036dad2..60c10bf7c7 100644
--- a/docs/system/devices/igb.rst
+++
igb's advanced descriptor uses a packet type encoding different from
one used in e1000e's extended descriptor. Fix the logic to encode
Rx packet type accordingly.
Fixes: 3a977deebe ("Intrdocue igb device emulation")
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
The old eth_setup_vlan_headers has no user so remove it and rename
eth_setup_vlan_headers_ex.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
include/net/eth.h | 9 +
hw/net/net_tx_pkt.c | 2 +-
net/eth.c | 2 +-
3 files changed, 3 insertions(+), 10
I have made significant changes for network packet abstractions so add
me as a reviewer.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c31d2279ab..8b2ef5943c 100644
---
The constants need to be consistent between the PF and VF.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_common.h | 8
hw/net/igb.c| 10 +-
hw/net/igbvf.c | 7 ---
3 files changed, 13
Signed-off-by: Akihiko Odaki
---
hw/net/igb_core.c | 23 ++-
1 file changed, 18 insertions(+), 5 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 688eaf7319..5345f57031 100644
--- a/hw/net/igb_core.c
+++ b/hw/net/igb_core.c
@@ -69,7 +69,7 @@ typedef
This allows to use the network packet abstractions even if PCI is not
used.
Signed-off-by: Akihiko Odaki
---
hw/net/net_tx_pkt.h | 31 ---
hw/net/e1000e_core.c | 13 -
hw/net/igb_core.c| 13 ++---
hw/net/net_tx_pkt.c | 36
Rename variable "n" to "causes", which properly represents the content
of the variable.
Signed-off-by: Akihiko Odaki
---
hw/net/e1000e_core.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c
index
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_regs.h | 1 +
include/net/eth.h | 4 ++-
include/qemu/crc32c.h | 1 +
hw/net/e1000e_core.c | 5
hw/net/igb_core.c | 15 +-
hw/net/net_rx_pkt.c | 64
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/igb_core.c | 96 +++
1 file changed, 48 insertions(+), 48 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
index 56a53872cf..20645c4764 100644
---
Signed-off-by: Akihiko Odaki
---
hw/net/net_rx_pkt.h | 19
include/net/eth.h| 4 ++--
hw/net/e1000e_core.c | 3 ++-
hw/net/igb_core.c| 14 ++--
hw/net/net_rx_pkt.c | 15 +
net/eth.c| 52
6
Without this change, the status flags may not be traced e.g. if checksum
offloading is disabled.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
hw/net/igb_core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c
The goto is a bit confusing as it changes the control flow only if L4
protocol is not recognized. It is also different from e1000e, and
noisy when comparing e1000e and igb.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/igb_core.c | 2 +-
1 file changed, 1 insertion(+),
e1000e_receive_internal() used to check the iov length to determine
copy the iovs to a contiguous buffer, but the check is flawed in two
ways:
- It does not ensure that iovcnt > 0.
- It does not take virtio-net header into consideration.
The size of this copy is just 18 octets, which can be even
Section 13.7.15 Receive Length Error Count says:
> Packets over 1522 bytes are oversized if LongPacketEnable is 0b
> (RCTL.LPE). If LongPacketEnable (LPE) is 1b, then an incoming packet
> is considered oversized if it exceeds 16384 bytes.
> These lengths are based on bytes in the received packet
This saves some code and enables tracepoint for e1000's VLAN filtering.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
hw/net/e1000x_common.h | 4 +++-
hw/net/e1000.c | 35 +--
hw/net/e1000e_core.c | 47
Before this change, e1000 and the common code updated BPRC and MPRC
depending on the matched filter, but e1000e and igb decided to update
those counters by deriving the packet type independently. This
inconsistency caused a multicast packet to be counted twice.
Updating BPRC and MPRC depending on
The uses of uint8_t pointers were misleading as they are never accessed
as an array of octets and it even require more strict alignment to
access as struct eth_header.
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
include/net/eth.h | 4 ++--
net/eth.c | 6 +++---
e1000e and igb employs NetPktRssIpV6TcpEx for RSS hash if TcpIpv6 MRQC
bit is set. Moreover, igb also has a MRQC bit for NetPktRssIpV6Tcp
though it is not implemented yet. Rename it to TcpIpv6Ex to avoid
confusion.
Signed-off-by: Akihiko Odaki
Reviewed-by: Sriram Yagnaraman
---
This function is not used.
Signed-off-by: Akihiko Odaki
---
hw/net/net_rx_pkt.h | 9 -
hw/net/net_rx_pkt.c | 5 -
2 files changed, 14 deletions(-)
diff --git a/hw/net/net_rx_pkt.h b/hw/net/net_rx_pkt.h
index a06f5c2675..ce8dbdb284 100644
--- a/hw/net/net_rx_pkt.h
+++
This is intended to be followed by another change for the interface.
It also fixes the leak of memory mapping when the specified memory is
partially mapped.
Fixes: e263cd49c7 ("Packet abstraction for VMWARE network devices")
Signed-off-by: Akihiko Odaki
---
hw/net/net_tx_pkt.h | 9
Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts")
Signed-off-by: Akihiko Odaki
Reviewed-by: Philippe Mathieu-Daudé
---
MAINTAINERS| 2 +-
docs/system/devices/igb.rst| 2 +-
igb_receive_internal() used to check the iov length to determine
copy the iovs to a contiguous buffer, but the check is flawed in two
ways:
- It does not ensure that iovcnt > 0.
- It does not take virtio-net header into consideration.
The size of this copy is just 22 octets, which can be even
Based-on: <366bbcafdb6e0373f0deb105153768a8c0bded87.ca...@gmail.com>
("[PATCH 0/1] e1000e: Fix tx/rx counters")
This series has fixes and feature additions to pass DPDK Test Suite with
igb. It also includes a few minor changes related to networking.
Patch [01, 10] are bug fixes.
Patch [11, 14]
When _FORTIFY_SOURCE=2, glibc version is 2.35, and GCC version is
12.1.0, the compiler complains as follows:
In file included from /usr/include/features.h:490,
from /usr/include/bits/libc-header-start.h:33,
from /usr/include/stdint.h:26,
from
On Mon, 2023-05-15 at 21:56 +0200, Juan Quintela wrote:
> We forget several places to add to trasferred amount of data. With
> this fixes I get:
>
>qemu_file_transferred() + multifd_bytes == transferred
>
> The only place whrer this is not true is during devices sending. But
> going all
On Tue, 2023-05-16 at 14:47 +0200, Cédric Le Goater wrote:
> On 5/16/23 11:24, Juan Quintela wrote:
> > David Edmondson wrote:
> > > Juan Quintela writes:
> > >
> > > > Define and use RATE_LIMIT_MAX instead.
> > >
> > > Suggest "RATE_LIMIT_MAX_NONE".
> >
> > Then even better
> >
> >
On 5/23/2023 8:45 AM, Richard Henderson wrote:
> On 5/18/23 06:57, Fei Wu wrote:
>> +void HELPER(inc_exec_freq)(void *ptr)
>> +{
>> + TBStatistics *stats = (TBStatistics *) ptr;
>> + tcg_debug_assert(stats);
>> + ++stats->executions.normal;
>> +}
> ...
>> +static inline void
On Tuesday, May 23, 2023 7:36 AM, Peter Xu wrote:
> > > We may also want to trap the channel setups on num:
> > >
> > > migrate_params_test_apply():
> > >
> > > if (params->has_multifd_channels) {
> > > dest->multifd_channels = params->multifd_channels;
> > > }
> >
> > Didn’t get
在 2023/5/22 下午9:44, Philippe Mathieu-Daudé 写道:
On 22/5/23 13:47, Jiaxun Yang wrote:
2023年5月22日 04:52,Huacai Chen 写道:
Hi, Jiaxun,
Rename loongarch_ipi to loongson_ipi? It will be shared by both MIPS
and LoongArch in your series.
Hi Huacai,
Thanks for the point, what’s the opinion
在 2023/5/15 2:55, Niek Linnenbank 写道:
Hi Qianfan,
On Wed, May 10, 2023 at 12:30 PM wrote:
From: qianfan Zhao
R40 has eight UARTs, support both 16450 and 16550 compatible modes.
Signed-off-by: qianfan Zhao
---
hw/arm/allwinner-r40.c | 31
在 2023/5/15 2:50, Niek Linnenbank 写道:
Hi Qianfan,
On Wed, May 10, 2023 at 12:30 PM wrote:
From: qianfan Zhao
Allwinner R40 (sun8i) SoC features a Quad-Core Cortex-A7 ARM CPU,
and a Mali400 MP2 GPU from ARM. It's also known as the Allwinner T3
for In-Car Entertainment
在 2023/5/16 3:58, Niek Linnenbank 写道:
Hi Qianfan,
On Wed, May 10, 2023 at 12:30 PM wrote:
From: qianfan Zhao
R40 has two ethernet controllers named as emac and gmac. The emac is
compatibled with A10, and the GMAC is compatibled with H3.
Signed-off-by: qianfan Zhao
在 2023/5/16 3:54, Niek Linnenbank 写道:
On Wed, May 10, 2023 at 12:30 PM wrote:
From: qianfan Zhao
A64's sd register was similar to H3, and it introduced a new register
named SAMP_DL_REG location at 0x144. The dma descriptor buffer size of
mmc2 is only 8K and the other mmc
在 2023/5/16 3:47, Niek Linnenbank 写道:
On Wed, May 10, 2023 at 12:30 PM wrote:
From: qianfan Zhao
Types of memory that the SDRAM controller supports are DDR2/DDR3
and capacities of up to 2GiB. This commit adds emulation support
of the Allwinner R40 SDRAM controller.
On 5/18/23 06:57, Fei Wu wrote:
+void HELPER(inc_exec_freq)(void *ptr)
+{
+TBStatistics *stats = (TBStatistics *) ptr;
+tcg_debug_assert(stats);
+++stats->executions.normal;
+}
...
+static inline void gen_tb_exec_count(TranslationBlock *tb)
+{
+if (tb_stats_enabled(tb,
在 2023/5/16 3:29, Niek Linnenbank 写道:
Hi Qianfan,
Good idea indeed to turn this driver into a more generic one. If
possible, its best to re-use code rather than adding new.
On Wed, May 10, 2023 at 12:30 PM wrote:
From: qianfan Zhao
This patch adds minimal support for AXP-221
On Sat, May 20, 2023 at 01:42:06AM +, Wang, Wei W wrote:
> On Friday, May 19, 2023 11:34 PM, Peter Xu wrote:
> > > Ah yes indeed it keeps working, because we apply -global bits before
> > > setup sockets. Then it's fine by me since that's the only thing I
> > > would still like to keep it
On 5/22/23 15:26, BALATON Zoltan wrote:
On Mon, 22 May 2023, Alex Bennée wrote:
(ajb: add Richard for his compiler-fu)
BALATON Zoltan writes:
On Mon, 22 May 2023, Alex Bennée wrote:
BALATON Zoltan writes:
The low level extract and deposit funtions provided by bitops.h are
used in
The 05/22/2023 16:09, Jonathan Cameron wrote:
> From: Ira Weiny
>
> To facilitate testing provide a QMP command to inject a general media
> event. The event can be added to the log specified.
>
> Signed-off-by: Ira Weiny
> Signed-off-by: Jonathan Cameron
>
> ---
Reviewed-by: Fan Ni
> v7:
On 5/22/23 10:41, Camilla Conte wrote:
Here's a second version (v2) of patches to support the Kubernetes runner for
Gitlab CI.
You can find the v1 thread here:
https://lore.kernel.org/qemu-devel/20230407145252.32955-1-cco...@redhat.com/.
This does not work:
The 05/22/2023 16:09, Jonathan Cameron wrote:
> From: Ira Weiny
>
> Replace the stubbed out CXL Get/Set Event interrupt policy mailbox
> commands. Enable those commands to control interrupts for each of the
> event log types.
>
> Skip the standard input mailbox length on the Set command due to
On Mon, 22 May 2023, Alex Bennée wrote:
(ajb: add Richard for his compiler-fu)
BALATON Zoltan writes:
On Mon, 22 May 2023, Alex Bennée wrote:
BALATON Zoltan writes:
The low level extract and deposit funtions provided by bitops.h are
used in performance critical places. It crept into
On 5/22/23 04:49, Thomas Huth wrote:
The following changes since commit aa222a8e4f975284b3f8f131653a4114b3d333b3:
Merge tag 'for_upstream' ofhttps://git.kernel.org/pub/scm/virt/kvm/mst/qemu
into staging (2023-05-19 12:17:16 -0700)
are available in the Git repository at:
Certainly seems like my patch is wrong as it will make the abort path
execute ide_cmd_done twice. During debug I came to the conclusion that
ide_cmd_done is not called at all as I was getting timeouts on the driver
side while waiting for D2H FIS. I am still not sure how I was getting this
behavior
On [2023 May 19] Fri 13:36:57, Vikram Garhwal wrote:
> Connect CANFD0 and CANFD1 on the Versal-virt machine and update
> xlnx-versal-virt
> document with CANFD command line examples.
>
> Signed-off-by: Vikram Garhwal
> Reviewed-by: Peter Maydell
Reviewed-by: Francisco Iglesias
> ---
>
On 22.05.23 21:46, Eric Blake wrote:
Although we already covered the need for padding bytes with our
changes in commit 3ae3fcfa, commit 66fcbca5 (both v5.0.0) added one
byte and relied on the rest of the text for implicitly covering 7
padding bytes. For consistency with other parts of the
Hi QEMU community,
I'm trying to build QEMU on my development environment on Windows (64 bit,
windows 10 enterprise), but am facing issues.
I'm using the MSYS2 installer as administrator with the following commands:
pacman -Syu
pacman -Su
pacman -S base-devel mingw-w64-x86_64-toolchain git
The 05/22/2023 16:09, Jonathan Cameron wrote:
> Following patches will need access to the mailbox return code
> type so move it to the header.
>
> Reviewed-by: Ira Weiny
> Signed-off-by: Jonathan Cameron
> ---
Reviewed-by: Fan Ni
> include/hw/cxl/cxl_device.h | 28
The 05/22/2023 16:09, Jonathan Cameron wrote:
> From: Ira Weiny
>
> CXL testing is benefited from an artificial event log injection
> mechanism.
>
> Add an event log infrastructure to insert, get, and clear events from
> the various logs available on a device.
>
> Replace the stubbed out CXL
The 05/22/2023 16:09, Jonathan Cameron wrote:
> From: Ira Weiny
>
> The device status register block was defined. However, there were no
> individual registers nor any data wired up.
>
> Define the event status register [CXL 3.0; 8.2.8.3.1] as part of the
> device status register block. Wire
Hi,
coverity recently reported some defects in code generated by idef-parser
(email attached). These defects are expected and we plan to emit a
/* coverity[event_tag] */ comment to disable the specific event triggered.
However, I'm not able to find the event_tag as I can't find the defect in
v4:
preparation patches are already merged to master
01: fix false-positive "error: ‘size’ may be used uninitialized",
keep r-bs
Vladimir Sementsov-Ogievskiy (1):
pci: ROM preallocation for incoming migration
hw/pci/pci.c | 79 ++--
1 file
On incoming migration we have the following sequence to load option
ROM:
1. On device realize we do normal load ROM from the file
2. Than, on incoming migration we rewrite ROM from the incoming RAM
block. If sizes mismatch we fail, like this:
Size mismatch:
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote:
> This test takes care to check the changes on different entitlements
> when the guest requests a polarization change.
>
> Signed-off-by: Pierre Morel
> ---
> tests/avocado/s390_topology.py | 56 ++
> 1 file
Try to be consistent in the spelling of polarization.
You use an s in the title and in the test name below.
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote:
> Polarization is changed on a request from the guest.
> Let's verify the polarization is accordingly set by QEMU.
>
> Signed-off-by:
On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote:
> Introduction of the s390x cpu topology core functions and
> basic tests.
>
> We test the corelation between the command line and
> the QMP results in query-cpus-fast for various CPU topology.
>
> Signed-off-by: Pierre Morel
> ---
>
On [2023 May 22] Mon 17:31:35, Philippe Mathieu-Daudé wrote:
> To be able to poke at FIFO content without popping it,
> introduce the fifo8_peek_buf() method by factoring
> common content from fifo8_pop_buf().
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/qemu/fifo8.h | 26
On Mon, May 22, 2023 at 11:44:32AM +0300, Vladimir Sementsov-Ogievskiy wrote:
> On 19.05.23 08:34, Michael S. Tsirkin wrote:
> > On Mon, May 15, 2023 at 03:52:29PM +0300, Vladimir Sementsov-Ogievskiy
> > wrote:
> > > On incoming migration we have the following sequence to load option
> > > ROM:
>
On Mon, May 22, 2023 at 8:55 PM Philippe Mathieu-Daudé
wrote:
>
> On 9/5/23 09:13, Marc-André Lureau wrote:
> > Hi
> >
> > On Mon, May 8, 2023 at 6:21 PM Mauro Matteo Cascella
> > mailto:mcasc...@redhat.com>> wrote:
> >
> > The cursor_alloc function still accepts a signed integer for both
> >
On [2023 May 22] Mon 17:31:34, Philippe Mathieu-Daudé wrote:
> There might be cases where we know the number of bytes we can
> pop from the FIFO, or we simply don't care how many bytes is
> returned. Allow fifo8_pop_buf() to take a NULL numptr.
>
> Signed-off-by: Philippe Mathieu-Daudé
All the other qemu_strto* and parse_uint allow a NULL str. Having
qemu_strtosz not crash on qemu_strtosz(NULL, NULL, ) is an easy
fix that adds some consistency between our string parsers.
Signed-off-by: Eric Blake
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Hanna Czenczek
---
v3: hoist
On Fri, May 19, 2023 at 2:39 AM Alex Bennée wrote:
>
>
> John Snow writes:
>
> > On Thu, May 18, 2023 at 12:20 PM Alex Bennée wrote:
> >>
> >> Since the update to the latest version Avocado only automatically
> >> collects logging under the avocado name space. Tweak the QEMUMachine
> >> class
All the qemu_strto*() functions permit a NULL endptr, just like their
libc counterparts, leaving parse_uint() as the oddball that caused
SEGFAULT on NULL and required the user to call parse_uint_full()
instead. Relax things for consistency, even though the testsuite is
the only impacted caller.
These two functions are subtly different, and not just because of
swapped parameter order. It took me adding better unit tests to
figure out why. Document the differences to make it more obvious to
developers trying to pick which one to use, as well as to aid in
upcoming semantic changes.
While
1 - 100 of 316 matches
Mail list logo