Re: [PATCH 03/16] target/riscv/cpu.c: restrict 'mvendorid' value

On Tue, Jun 13, 2023 at 4:52 AM Daniel Henrique Barboza wrote: > > > > On 6/12/23 00:56, Alistair Francis wrote: > > On Wed, May 31, 2023 at 5:49 AM Daniel Henrique Barboza > > wrote: > >> > >> We're going to change the handling of mvendorid/marchid/mimpid by the > >> KVM driver. Since these are

Re: [PATCH v6 1/9] migration: introduced 'MigrateAddress' in QAPI for migration wire protocol.

On 06/06/23 3:45 pm, Het Gala wrote: This patch introduces well defined MigrateAddress struct and its related child objects. The existing argument of 'migrate' and 'migrate-incoming' QAPI - 'uri' is of string type. The current migration flow follows double encoding scheme for fetching migrati

Re: [PATCH v15 00/10] TCG code quality tracking

On 6/7/2023 8:24 PM, Fei Wu wrote: > v15 > --- > This is a large change: > * remove all time related stuffs, including cmd 'info profile' > * remove the per-TB flag, use global flag instead > * remove tb_stats pause/filter, but add status > * remove qemu_log changes, and use monitor_printf > * use

RE: [PATCH v3 5/5] intel_iommu: Optimize out some unnecessary UNMAP calls

>-Original Message- >From: Peter Xu >Sent: Saturday, June 10, 2023 5:26 AM >Subject: Re: [PATCH v3 5/5] intel_iommu: Optimize out some unnecessary >UNMAP calls > >On Fri, Jun 09, 2023 at 05:49:06AM +, Duan, Zhenzhong wrote: >> Seems vtd_page_walk_one() already works in above way, che

RE: [PATCH v3 4/5] intel_iommu: Fix address space unmap

>-Original Message- >From: Peter Xu >Sent: Friday, June 9, 2023 9:37 PM >To: Duan, Zhenzhong >Cc: qemu-devel@nongnu.org; m...@redhat.com; jasow...@redhat.com; >pbonz...@redhat.com; richard.hender...@linaro.org; edua...@habkost.net; >marcel.apfelb...@gmail.com; alex.william...@redhat.com

Re: [PATCH] elf2dmp: Don't abandon when Prcb is set to 0

On 2023/06/12 12:42, Viktor Prutyanov wrote: Prcb may be set to 0 for some CPUs if the dump was taken before they start. The dump may still contain valuable information for started CPUs so don't abandon conversion in such a case. Signed-off-by: Akihiko Odaki --- contrib/elf2dmp/main.c | 5 +

Re: [PATCH] sdl2: Check if window exists before updating it

On 2023/06/12 18:00, Marc-André Lureau wrote: Hi On Thu, Jun 8, 2023 at 4:56 PM Akihiko Odaki > wrote: A console does not have a window if the surface is a placeholder and the console is not the first one. sdl2 cannot update the texture in such a ca

Re: [PATCH 5/5] cmd646: move device-specific BMDMA registers to separate memory region

On 12/6/23 21:28, Bernhard Beschow wrote: Am 9. Juni 2023 18:51:19 UTC schrieb Mark Cave-Ayland : The aim here is to eliminate any device-specific registers from the main BMDMA bar memory region so it can potentially be moved into the shared PCI IDE device. For each BMDMA bus create a new cm

[PATCH v3 2/4] hw/misc/bcm2835_property: Use 'raspberrypi-fw-defs.h' definitions

From: Sergey Kambalin Replace magic property values by a proper definition, removing redundant comments. Signed-off-by: Sergey Kambalin Message-Id: <20230531155258.8361-1-sergey.kamba...@auriga.com> [PMD: Split from bigger patch: 2/4] Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/bcm2835_

[PATCH v3 1/4] hw/arm/raspi: Import Linux raspi definitions as 'raspberrypi-fw-defs.h'

From: Sergey Kambalin Signed-off-by: Sergey Kambalin Message-Id: <20230531155258.8361-1-sergey.kamba...@auriga.com> [PMD: Split from bigger patch: 1/4] Signed-off-by: Philippe Mathieu-Daudé --- include/hw/misc/raspberrypi-fw-defs.h | 163 ++ 1 file changed, 163 insertio

[PATCH v3 0/4] hw/arm/raspi: Use named constants in BCM props

v2: https://lore.kernel.org/qemu-devel/20230612115950.5002-1-sergey.kamba...@auriga.com/ This is a respin of Sergey's patch but - split in multiple patches - removing redundant comments Sergey Kambalin (4): hw/arm/raspi: Import Linux raspi definitions as 'raspberrypi-fw-defs.h' hw/misc/b

[RFC PATCH v3 3/4] hw/misc/bcm2835_property: Replace magic frequency values by definitions

From: Sergey Kambalin Signed-off-by: Sergey Kambalin Message-Id: <20230531155258.8361-1-sergey.kamba...@auriga.com> [PMD: Split from bigger patch: 4/4] Signed-off-by: Philippe Mathieu-Daudé --- FIXME: RPI_FIRMWARE_DEFAULT_CLK_RATE is raspi1-specific... Good enough for now? --- include/hw/arm/r

[RFC PATCH v3 4/4] hw/misc/bcm2835_property: Handle CORE_CLK_ID firmware property

From: Sergey Kambalin Signed-off-by: Sergey Kambalin Message-Id: <20230531155258.8361-1-sergey.kamba...@auriga.com> [PMD: Split from bigger patch: 3/4] Signed-off-by: Philippe Mathieu-Daudé --- TOCHECK: seems raspi3-specific freq. Use a per-soc freq? Good enough for now? --- include/hw/arm/ras

Re: [PATCH v2] Use named constants in BCM props

On 12/6/23 13:59, Sergey Kambalin wrote: ping - PI_FIRMWARE_*_RATE constsnts were moved to raspberrypi-fw-defs.h (seems more suitable place for them) - inclusion of "qemu/osdep.h" has been removed - year in copyright header has been updated Signed-off-by: Sergey Kambalin --- hw/misc/bcm28

Re: [PATCH] imx_serial: set wake bit when we receive a data byte

Hi Martin, On 8/6/23 17:41, Martin Kaiser wrote: The linux kernel added a flood check for rx data recently in commmit 496a4471b7c3 ("serial: imx: work-around for hardware RX flood"). This check uses the wake bit in the uart status register 2. The wake bit indicates that the receiver detected a s

[Bug 1180923] Re: unused memory filled with 0x00 instead of 0xFF

I am using Qemu 8.0.0 and this issue happens only when kvm is enabled, tcg initialized the unused bytes to 0xFF as a real machine and works normally, so a question in my mind, does kvm use those umb area for increased performance? If emm386 M5 is used for using area D000-D7FF as frame page, emm38

Re: [RFC 4/6] migration: Deprecate -incoming

On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > >> Only "defer" is recommended. After setting all migation parameters, > >> start incoming migration with "migrate-incoming uri" command. > >> > >

Re: [RFC 4/6] migration: Deprecate -incoming

Peter Xu wrote: > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: >> Only "defer" is recommended. After setting all migation parameters, >> start incoming migration with "migrate-incoming uri" command. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 ++

Re: [PATCH] hw/i386/vmmouse: use the new input api

Hi Marc-André, Hi Lucas On Thu, Jun 8, 2023 at 9:49 PM Lucas Chollet wrote: No functional changes intended. Signed-off-by: Lucas Chollet ---  hw/i386/vmmouse.c | 95 +++  1 file changed, 71 insertions(+), 24 deletions(-)

Re: [PATCH V2] migration: file URI

On Mon, Jun 12, 2023 at 03:39:34PM -0400, Steven Sistare wrote: > On 6/12/2023 2:44 PM, Peter Xu wrote: > > Hi, Steve, > > > > On Wed, Jun 07, 2023 at 11:38:59AM -0700, Steve Sistare wrote: > >> Extend the migration URI to support file:. This can be used for > >> any migration scenario that does

Re: [RFC 4/6] migration: Deprecate -incoming

On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > > Signed-off-by: Juan Quintela > --- > docs/about/deprecated.rst | 7 +++ > softmmu/vl.c

Re: [PATCH V2] migration: file URI

On 6/12/2023 2:44 PM, Peter Xu wrote: > Hi, Steve, > > On Wed, Jun 07, 2023 at 11:38:59AM -0700, Steve Sistare wrote: >> Extend the migration URI to support file:. This can be used for >> any migration scenario that does not require a reverse path. It can be used >> as an alternative to 'exec:ca

[RFC 4/6] migration: Deprecate -incoming

Only "defer" is recommended. After setting all migation parameters, start incoming migration with "migrate-incoming uri" command. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ softmmu/vl.c | 2 ++ 2 files changed, 9 insertions(+) diff --git a/docs/about/d

[RFC 2/6] migration: migrate 'inc' command option is deprecated.

Use 'migrate_set_parameter block_incremental true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 11 +-- migration/migration.c | 5 + 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/docs/about/deprec

[RFC 0/6] Migration deprecated parts

Hi this series describe the migration parts that have to be deprecated. - It is an rfc because I doubt that I did the deprecation process right. Hello Markus O:-) - skipped field: It is older than me, I have never know what it stands for. As far as I know it has always been zero. - inc/blk m

[RFC 5/6] migration: Deprecate block migration

It is obsolete. It is better to use driver_mirror+NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela --- Can any of you give one example of how to use driver_mirror+NBD for deprecated.rst? Thanks, Juan. --- docs/about/deprecate

[RFC 1/6] migration: skipped field is really obsolete.

Has return zero for more than 10 years. Just mark it deprecated. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 12 ++-- 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprec

[RFC 6/6] migration: Deprecated old compression method

Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 qapi/migration.json | 92 --- migration/options.c | 13 ++ 3 files changed, 79 insertions(+), 34 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.r

[RFC 3/6] migration: migrate 'blk' command option is deprecated.

Use 'migrate_set_capability block true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 11 +++ migration/migration.c | 5 + 3 files changed, 19 insertions(+), 4 deletions(-) diff --git a/docs/about/deprecated.rst b/

Re: [PATCH 5/5] cmd646: move device-specific BMDMA registers to separate memory region

Am 9. Juni 2023 18:51:19 UTC schrieb Mark Cave-Ayland : >The aim here is to eliminate any device-specific registers from the main BMDMA >bar memory region so it can potentially be moved into the shared PCI IDE >device. > >For each BMDMA bus create a new cmd646-bmdma-specific memory region >re

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

Am 12. Juni 2023 15:21:19 UTC schrieb Igor Mammedov : >On Mon, 12 Jun 2023 16:51:55 +0200 >Igor Mammedov wrote: > >> On Sun, 11 Jun 2023 12:34:12 +0200 >> Bernhard Beschow wrote: >> >> > I440FX realization is currently mixed with PIIX3 creation. Furthermore, it >> > is >> > common practice t

Re: [Libguestfs] [PATCH v4 09/24] nbd: Replace bool structured_reply with mode enum

On Mon, Jun 12, 2023 at 06:07:59PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 08.06.23 16:56, Eric Blake wrote: > > The upcoming patches for 64-bit extensions requires various points in > > the protocol to make decisions based on what was negotiated. While we > > could easily add a 'bool exte

Re: [PATCH 11/15] hw/pci-host/i440fx: Add PCI_HOST_PROP_IO_MEM property

Am 12. Juni 2023 10:31:48 UTC schrieb "Philippe Mathieu-Daudé" : >On 11/6/23 12:34, Bernhard Beschow wrote: >> Introduce the property in anticipation of QOM'ification; Q35 has the same >> property. >> >> Signed-off-by: Bernhard Beschow >> --- >> hw/pci-host/i440fx.c | 14 ++ >>

Re: [PATCH 13/16] target/riscv/kvm.c: add multi-letter extension KVM properties

On 6/7/23 08:48, Andrew Jones wrote: On Tue, May 30, 2023 at 04:46:20PM -0300, Daniel Henrique Barboza wrote: Let's add KVM user properties for the multi-letter extensions that KVM currently supports: zicbom, zicboz, zihintpause, zbb, ssaia, sstc, svinval and svpbmt. As with the recently add

[PATCH] migration.json: Don't use space before colon

So all the file is consistent. Signed-off-by: Juan Quintela --- qapi/migration.json | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 179af0c4d8..cb7cd3e578 100644 --- a/qapi/migration.json +++ b/qapi/migrat

Re: [PATCH v4 06/24] nbd/client: Simplify cookie vs. index computation

On Mon, Jun 12, 2023 at 05:27:19PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 08.06.23 16:56, Eric Blake wrote: > > Our code relies on a sentinel cookie value of zero for deciding when a > > packet has been handled, as well as relying on array indices between 0 > > and MAX_NBD_REQUESTS-1 for d

Re: [PATCH 2/2] hw/char/parallel-isa: Export struct ISAParallelState

On 12/06/2023 11:06, BALATON Zoltan wrote: On Mon, 12 Jun 2023, Bernhard Beschow wrote: Am 11. Juni 2023 13:15:58 UTC schrieb BALATON Zoltan : On Sun, 11 Jun 2023, Bernhard Beschow wrote: Allows the struct to be embedded directly into device models without additional allocation. Suggested-by

Re: [PATCH 2/5] cmd646: create separate header and QOM type for CMD646_IDE

On 12/06/2023 10:21, Bernhard Beschow wrote: Am 9. Juni 2023 18:51:16 UTC schrieb Mark Cave-Ayland : This will enable CMD646-specific fields to be added to CMD6464IDEState in future. Signed-off-by: Mark Cave-Ayland --- hw/ide/cmd646.c | 4 +++- include/hw/ide/cmd646.h | 38 ++

Re: [PATCH 03/16] target/riscv/cpu.c: restrict 'mvendorid' value

On 6/12/23 00:56, Alistair Francis wrote: On Wed, May 31, 2023 at 5:49 AM Daniel Henrique Barboza wrote: We're going to change the handling of mvendorid/marchid/mimpid by the KVM driver. Since these are always present in all CPUs let's put the same validation for everyone. It doesn't make

Re: [PATCH v2 0/2] Export struct ISAParallelState

On 12/06/2023 09:12, Bernhard Beschow wrote: This series incorporates rebased versions of the ISAParallelState patches of [1] as requested by Mark. v2: * Add forgotten SoB tags (Zoltan, Phil) Changes since [1]: * Don't export register definitions (Phil) * Rephrase commit message of second patc

Re: [PATCH V2] migration: file URI

Hi, Steve, On Wed, Jun 07, 2023 at 11:38:59AM -0700, Steve Sistare wrote: > Extend the migration URI to support file:. This can be used for > any migration scenario that does not require a reverse path. It can be used > as an alternative to 'exec:cat > file' in minimized containers that do not >

Re: [PULL 26/42] target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, st}r

On 12/06/2023 16:20, Jonathan Cameron via wrote: On Tue, 6 Jun 2023 10:47:58 +0100 Peter Maydell wrote: From: Richard Henderson Round len_align to 16 instead of 8, handling an odd 8-byte as part of the tail. Use MO_ATOM_NONE to indicate that all of these memory ops have only byte atomicit

Re: [PATCH][RESEND v5 3/3] Add a Hyper-V Dynamic Memory Protocol driver (hv-balloon)

On 12.06.23 16:00, Maciej S. Szmigiero wrote: From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and inserting pieces of extra RAM into it on demand from a provided memory backend. One of advantages of

Re: Fwd: QEMU AVR Patch - Correct handling of AVR interrupts

Hello Phil, I believe I have resolved the problem. However, I didn't managed to make git send-email work yet. So please find the patch attached. Best regards, Le lun. 12 juin 2023 à 14:53, Philippe Mathieu-Daudé a écrit : > Hi Lucas, > > On 8/6/23 23:03, Adecy wrote: > > -- Forwarded

Re: [PATCH v4 11/24] nbd: Add types for extended headers

On 08.06.23 16:56, Eric Blake wrote: Add the constants and structs necessary for later patches to start implementing the NBD_OPT_EXTENDED_HEADERS extension in both the client and server, matching recent upstream nbd.git (through commit e6f3b94a934). This patch does not change any existing behavi

Re: [PATCH v4 10/24] nbd/client: Pass mode through to nbd_send_request

On 08.06.23 16:56, Eric Blake wrote: Once the 64-bit headers extension is enabled, the data layout we send over the wire for a client request depends on the mode negotiated with the server. Rather than adding a parameter to nbd_send_request, we can add a member to struct NBDRequest, since it alr

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

On Mon, 12 Jun 2023 16:51:55 +0200 Igor Mammedov wrote: > On Sun, 11 Jun 2023 12:34:12 +0200 > Bernhard Beschow wrote: > > > I440FX realization is currently mixed with PIIX3 creation. Furthermore, it > > is > > common practice to only set properties between a device's qdev_new() and > > qdev_r

Re: [PULL 26/42] target/arm: Use tcg_gen_qemu_{ld, st}_i128 in gen_sve_{ld, st}r

On Tue, 6 Jun 2023 10:47:58 +0100 Peter Maydell wrote: > From: Richard Henderson > > Round len_align to 16 instead of 8, handling an odd 8-byte as part > of the tail. Use MO_ATOM_NONE to indicate that all of these memory > ops have only byte atomicity. > > Reviewed-by: Peter Maydell > Signe

Re: [PATCH v4 09/24] nbd: Replace bool structured_reply with mode enum

On 08.06.23 16:56, Eric Blake wrote: The upcoming patches for 64-bit extensions requires various points in the protocol to make decisions based on what was negotiated. While we could easily add a 'bool extended_headers' alongside the existing 'bool structured_reply', this does not scale well if

Re: [PATCH v2] hw/vfio/pci-quirks: Support alternate offset for GPUDirect Cliques

On Mon, 12 Jun 2023 16:07:33 +0200 Cédric Le Goater wrote: > On 6/8/23 20:05, Alex Williamson wrote: > > NVIDIA Turing and newer GPUs implement the MSI-X capability at the offset > > previously reserved for use by hypervisors to implement the GPUDirect > > Cliques capability. A revised specifica

Re: [PATCH V9 00/46] Live Update

Hi Steve, On 6/7/23 12:37, Steven Sistare wrote: On 6/7/2023 11:55 AM, Michael Galaxy wrote: Another option could be to expose "-migrate-mode-disable" (instead of enable) and just enable all 3 modes by default, since we are already required to switch from "normal" mode to a CPR-specific mode

Re: [SPAM] [PATCH v3] 9pfs: deprecate 'proxy' backend

Hi Christian, On Sat, 10 Jun 2023 15:39:44 +0200 Christian Schoenebeck wrote: > As recent CVE-2023-2861 once again showed, the 9p 'proxy' fs driver is in > bad shape. Using the 'proxy' backend was already discouraged for safety > reasons before and we recommended to use the 'local' backend inste

Re: [PATCH v2 03/38] tests/multiarch: Add test-aes

Richard Henderson writes: > Use a shared driver and backends for i386, aarch64, ppc64, riscv64. > > Signed-off-by: Richard Henderson > --- > tests/tcg/aarch64/test-aes.c| 58 > tests/tcg/i386/test-aes.c | 68 + > tests/tcg/ppc64/test-aes.c

Re: [PATCH 15/15] hw/i386/pc_piix: Move i440fx' realize near its qdev_new()

On Sun, 11 Jun 2023 12:34:12 +0200 Bernhard Beschow wrote: > I440FX realization is currently mixed with PIIX3 creation. Furthermore, it is > common practice to only set properties between a device's qdev_new() and > qdev_realize(). Clean up to resolve both issues. > > Since I440FX spawns a PCI b

Re: [PATCH v4 08/24] nbd: Use enum for various negotiation modes

On 08.06.23 16:56, Eric Blake wrote: Deciphering the hard-coded list of integer return values from nbd_start_negotiate() will only get more confusing when adding support for 64-bit extended headers. Better is to name things in an enum. Although the function in question is private to client.c, pu

Re: [PATCH v4 06/24] nbd/client: Simplify cookie vs. index computation

On 08.06.23 16:56, Eric Blake wrote: Our code relies on a sentinel cookie value of zero for deciding when a packet has been handled, as well as relying on array indices between 0 and MAX_NBD_REQUESTS-1 for dereferencing purposes. As long as we can symmetrically convert between two forms, there i

Re: [PATCH v4 05/24] nbd: s/handle/cookie/ to match NBD spec

On 08.06.23 16:56, Eric Blake wrote: Externally, libnbd exposed the 64-bit opaque marker for each client NBD packet as the "cookie", because it was less confusing when contrasted with 'struct nbd_handle *' holding all libnbd state. It also avoids confusion between the nown 'handle' as a way to i

Re: [PATCH v2] hw/vfio/pci-quirks: Support alternate offset for GPUDirect Cliques

On 6/8/23 20:05, Alex Williamson wrote: NVIDIA Turing and newer GPUs implement the MSI-X capability at the offset previously reserved for use by hypervisors to implement the GPUDirect Cliques capability. A revised specification provides an alternate location. Add a config space walk to the quir

[PATCH][RESEND v5 3/3] Add a Hyper-V Dynamic Memory Protocol driver (hv-balloon)

From: "Maciej S. Szmigiero" This driver is like virtio-balloon on steroids: it allows both changing the guest memory allocation via ballooning and inserting pieces of extra RAM into it on demand from a provided memory backend. One of advantages of these over ACPI-based PC DIMM hotplug is that su

[PATCH][RESEND v5 1/3] error: define g_autoptr() cleanup function for the Error type

From: "Maciej S. Szmigiero" Used by the hv-balloon driver for automatic memory management. Signed-off-by: Maciej S. Szmigiero --- include/qapi/error.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qapi/error.h b/include/qapi/error.h index f21a231bb1a6..b0b1838e3e93 100644 --- a

[PATCH][RESEND v5 2/3] Add Hyper-V Dynamic Memory Protocol definitions

From: "Maciej S. Szmigiero" This commit adds Hyper-V Dynamic Memory Protocol definitions, taken from hv_balloon Linux kernel driver, adapted to the QEMU coding style and definitions. Signed-off-by: Maciej S. Szmigiero --- include/hw/hyperv/dynmem-proto.h | 423 +++

[PATCH][RESEND v5 0/3] Hyper-V Dynamic Memory Protocol driver (hv-balloon 🎈️)

From: "Maciej S. Szmigiero" This is almost a pure rebase/resend of the v4 of patch series located here: https://lore.kernel.org/qemu-devel/cover.1682584770.git.maciej.szmigi...@oracle.com/ The only other change from the previous version is that the check for the required Glib's GTree operations

Re: [PATCH 07/15] hw/pci-host/i440fx: Replace magic values by existing constants

On Sun, 11 Jun 2023 12:34:04 +0200 Bernhard Beschow wrote: > Signed-off-by: Bernhard Beschow Reviewed-by: Igor Mammedov > --- > hw/pci-host/i440fx.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/pci-host/i440fx.c b/hw/pci-host/i440fx.c > index 61e7b97ff

Re: [PATCH v4 03/24] nbd/server: Prepare for alternate-size headers

On 08.06.23 16:56, Eric Blake wrote: Upstream NBD now documents[1] an extension that supports 64-bit effect lengths in requests. As part of that extension, the size of the reply headers will change in order to permit a 64-bit length in the reply for symmetry[2]. Additionally, where the reply he

Re: [PATCH 05/15] hw/pci-host/q35: Initialize PCI_HOST_BYPASS_IOMMU property from board code

On Sun, 11 Jun 2023 12:34:02 +0200 Bernhard Beschow wrote: > The Q35 PCI host already has a PCI_HOST_BYPASS_IOMMU property. However, the > host initializes this property itself by accessing global machine state, > thereby assuming it to be a PC machine. Avoid this by having board code > set this

Re: [PATCH 04/15] hw/pci/pci_host: Introduce PCI_HOST_BYPASS_IOMMU macro

On Sun, 11 Jun 2023 12:34:01 +0200 Bernhard Beschow wrote: > Introduce a macro to avoid copy and pasting strings which can easily > cause typos. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Bernhard Beschow Reviewed-by: Igor Mammedov > --- > include/hw/pci/pci_host.h | 2 ++ > hw/

Re: [PATCH 03/15] hw/pci-host/q35: Initialize PCMachineState::bus in board code

On Sun, 11 Jun 2023 12:34:00 +0200 Bernhard Beschow wrote: > The Q35 PCI host currently sets the PC machine's PCI bus attribute > through global state, thereby assuming the machine to be a PC machine. > The Q35 machine code already holds on to Q35's pci bus attribute, so can > easily set its own

Re: [PATCH] coroutine-asm: add x86 CET shadow stack support

Hi Paolo On Wed, May 10, 2023 at 6:05 PM Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > patch looks generally good, but does not apply anymore. Are you planning to update it later to support the more secure " map_shadow_stack" syscall, if/when it is added? --- > meson.build

Re: [PATCH v2 38/38] host/include/ppc: Implement aes-round.h

On 6/8/23 23:24, Richard Henderson wrote: Detect CRYPTO in cpuinfo; implement the accel hooks. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza host/include/ppc/host/aes-round.h | 181 host/include/ppc/host/cpuinfo.h | 1 +

Re: [RFC v2 6/6] linux-user: Add '-native-bypass' option

Yeqi Fu writes: > Signed-off-by: Yeqi Fu > --- > include/qemu/envlist.h | 1 + > linux-user/main.c | 23 + > util/envlist.c | 56 ++ > 3 files changed, 80 insertions(+) > > diff --git a/include/qemu/envlist.h b/include/qemu

Re: [PATCH v2 31/38] target/ppc: Use aesdec_ISB_ISR_AK_IMC

On 6/8/23 23:23, Richard Henderson wrote: This implements the VNCIPHER instruction. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza target/ppc/int_helper.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/target/ppc/in

Re: [PATCH v2 25/38] target/ppc: Use aesenc_SB_SR_MC_AK

On 6/8/23 23:23, Richard Henderson wrote: This implements the VCIPHER instruction. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza target/ppc/int_helper.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/target/ppc/int_help

Re: [PATCH v2 15/38] target/ppc: Use aesdec_ISB_ISR_AK

On 6/8/23 23:23, Richard Henderson wrote: This implements the VNCIPHERLAST instruction. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza target/ppc/int_helper.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/target/ppc/int_helper.c

Re: [PATCH v2 02/38] util: Add cpuinfo-ppc.c

On 6/8/23 23:23, Richard Henderson wrote: Move the code from tcg/. Fix a bug in that PPC_FEATURE2_ARCH_3_10 is actually spelled PPC_FEATURE2_ARCH_3_1. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza host/include/ppc/host/cpuinfo.h | 29 h

Re: [PATCH v2 10/38] target/ppc: Use aesenc_SB_SR_AK

On 6/8/23 23:23, Richard Henderson wrote: This implements the VCIPHERLAST instruction. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza target/ppc/int_helper.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/target/ppc/int_helper.

Re: [PATCH v2 01/38] tcg/ppc: Define _CALL_AIX for clang on ppc64(be)

On 6/8/23 23:23, Richard Henderson wrote: Restructure the ifdef ladder, separating 64-bit from 32-bit, and ensure _CALL_AIX is set for ELF v1. Fixes the build for ppc64 big-endian host with clang. Signed-off-by: Richard Henderson --- Reviewed-by: Daniel Henrique Barboza tcg/ppc/tcg-t

Re: [RFC v2 6/6] linux-user: Add '-native-bypass' option

Manos Pitsidianakis writes: > On Wed, 07 Jun 2023 19:47, Yeqi Fu wrote: >>--- a/linux-user/main.c >>+++ b/linux-user/main.c >>+/* Set the library for native bypass */ >>+if (native_lib != NULL) { >>+char *token = malloc(strlen(native_lib) + 12); > > malloc() can fail (in rare

Re: [PATCH v3 2/8] target/arm: v8.3 PAC ID_AA64ISAR[12] feature-detection

On Jun 09 13:51, Richard Henderson wrote: > On 6/9/23 10:23, Aaron Lindsay wrote: > > +static inline int isar_feature_pauth_get_features(const ARMISARegisters > > *id) > > +{ > > +if (isar_feature_aa64_pauth_arch_qarma5(id)) { > > +return FIELD_EX64(id->id_aa64isar1, ID_AA64ISAR1, APA)

Re: [PATCH v3 1/8] target/arm: Add ID_AA64ISAR2_EL1

On Jun 09 13:49, Richard Henderson wrote: > On 6/9/23 10:23, Aaron Lindsay wrote: > > --- a/target/arm/hvf/hvf.c > > +++ b/target/arm/hvf/hvf.c > > @@ -847,6 +847,7 @@ static bool > > hvf_arm_get_host_cpu_features(ARMHostCPUFeatures *ahcf) > > { HV_SYS_REG_ID_AA64DFR1_EL1, &host_isar.id_

Re: [RFC 0/2] migration: Update error description outside migration.c

On Fri, May 26, 2023 at 11:50:01AM +, Tejus GK wrote: > Hi everyone, > > This patchset aims to cover code paths in the source code where a > migration is marked as failed via MIGRATION_STATUS_FAILED, however the > failure exists outside of migration.c, and without a call for > migrate_set_e

[PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

From: "liguang.zhang" There have a issue of guest reboot bug in kvm-mode: 1. in guest shell just run the reboot, guest can't reboot success, and host kvm stop the vcpu schedual. 2. for smp guest, ctrl+a+c switch to qemu command, use system_reset command to reset the guest, then vcpu crash kern

[PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

From: "liguang.zhang" kernel log ```shell The system is going down NOW! Sent SIGTERM to all processes logout Sent SIGKILL to all processes Requesting system reboot ``` then no response for qemu command: system_reset: kernel log: ```shell [ 53.739556] kvm [150]: VCPU exit error -95 [ 53.739

[PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

From: "liguang.zhang" kernel log ```shell reboot The system is going down NOW! Sent SIGTERM to all processes logout Sent SIGKILL to all processes Requesting system reboot ``` then no response for qemu command: system_reset: kernel log: ```shell [ 53.739556] kvm [150]: VCPU exit error -95 [

Re: [RFC v2 1/6] build: Add configure options for native calls

Alex Bennée writes: > Yeqi Fu writes: > >> Signed-off-by: Yeqi Fu >> --- >> Makefile| 4 +++ >> common-user/native/Makefile.include | 9 ++ >> common-user/native/Makefile.target | 22 + >> configure | 50 +++

Re: [PATCH 02/15] hw/pci-host/q35: Fix double, contradicting .endianness assignment

On Sun, 11 Jun 2023 12:33:59 +0200 Bernhard Beschow wrote: > Fixes the following clangd warning (-Winitializer-overrides): > > q35.c:297:19: Initializer overrides prior initialization of this subobject > q35.c:292:19: previous initialization is here > > Settle on native endian which causes

Re: Fwd: QEMU AVR Patch - Correct handling of AVR interrupts

Hi Lucas, On 8/6/23 23:03, Adecy wrote: -- Forwarded message - De : *Adecy* mailto:ld.ad...@gmail.com>> Date: jeu. 1 juin 2023 à 21:34 Subject: QEMU AVR Patch - Correct handling of AVR interrupts To: mailto:qemu-triv...@nongnu.org>> Hello, I would like to submit the attached p

Re: [PATCH 1/5] cmd646: checkpatch fixes

On 9/6/23 20:51, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- hw/ide/cmd646.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 4/5] cmd646: rename cmd646_bmdma_ops to bmdma_ops

On 9/6/23 20:51, Mark Cave-Ayland wrote: This is to allow us to use the cmd646_bmdma_ops name for the CMD646 device-specific registers in the next commit. Signed-off-by: Mark Cave-Ayland --- hw/ide/cmd646.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mat

Re: [QEMU PATCH 1/1] virtgpu: do not destroy resources when guest suspend

Hi On Thu, Jun 8, 2023 at 6:26 AM Jiqian Chen wrote: > After suspending and resuming guest VM, you will get > a black screen, and the display can't come back. > > This is because when guest did suspending, it called > into qemu to call virtio_gpu_gl_reset. In function > virtio_gpu_gl_reset, it d

Re: [PATCH 2/5] cmd646: create separate header and QOM type for CMD646_IDE

Am 9. Juni 2023 18:51:16 UTC schrieb Mark Cave-Ayland : >This will enable CMD646-specific fields to be added to CMD6464IDEState in >future. > >Signed-off-by: Mark Cave-Ayland >--- > hw/ide/cmd646.c | 4 +++- > include/hw/ide/cmd646.h | 38 ++ > 2 file

Re: [RFC v2 1/6] build: Add configure options for native calls

Yeqi Fu writes: > Signed-off-by: Yeqi Fu > --- > Makefile| 4 +++ > common-user/native/Makefile.include | 9 ++ > common-user/native/Makefile.target | 22 + > configure | 50 + > docs/devel/bu

[PATCH v2] Use named constants in BCM props

ping - PI_FIRMWARE_*_RATE constsnts were moved to raspberrypi-fw-defs.h (seems more suitable place for them) - inclusion of "qemu/osdep.h" has been removed - year in copyright header has been updated Signed-off-by: Sergey Kambalin --- hw/misc/bcm2835_property.c| 120 ++---

Re: [Libguestfs] [PATCH v4 02/24] nbd: Consistent typedef usage in header

On 08.06.23 17:17, Eric Blake wrote: On Thu, Jun 08, 2023 at 08:56:31AM -0500, Eric Blake wrote: We had a mix of struct declarataions followed by typedefs, and direct declarations struct definitions as part of a typedef. Pick a single style. Also float a couple of opaque typedefs earlier i

Re: [PATCH v2 2/8] target/riscv: Factor out extension tests to cpu_cfg.h

On 2023/6/12 19:10, Christoph Muellner wrote: From: Christoph Müllner This patch moves the extension test functions that are used to gate vendor extension decoders, into cpu_cfg.h. This allows to reuse them in the disassembler. This patch does not introduce new functionality. However, the pa

Re: [PATCH 6/9] target/riscv/cpu: Share RISCVCPUConfig with disassembler

On 2023/6/12 18:04, Christoph Müllner wrote: On Mon, Jun 12, 2023 at 12:01 PM LIU Zhiwei wrote: On 2023/6/12 17:47, Christoph Müllner wrote: On Mon, Jun 12, 2023 at 8:25 AM LIU Zhiwei wrote: On 2023/5/30 21:18, Christoph Muellner wrote: From: Christoph Müllner The disassembler needs th

[PATCH 0/4] TriCore bugfixes

Hi, this series fixes a bunch of TriCore issues on the bugtracker. Cheers, Bastian Bastian Koppelmann (3): target/tricore: Correctly fix saving PSW.CDE to CSA on call target/tricore: Add CHECK_REG_PAIR() for insn accessing 64 bit regs target/tricore: Fix helper_ret() not correctly restorin

[PATCH 2/4] target/tricore: Correctly fix saving PSW.CDE to CSA on call

we don't want to save PSW.CDC to the CSA, but PSW.CDE must be saved. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1699 Signed-off-by: Bastian Koppelmann --- target/tricore/op_helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/target/tricore/op_helper.c

[PATCH 4/4] target/tricore: Fix helper_ret() not correctly restoring PSW

We are always taking the TRICORE_FEATURE_13 branch as every CPU has TRICORE_FEATURE_13. For CPUs with ISA > 1.3 we have to take the else branch. We fix this by inverting the condition. We check for TRICORE_FEATURE_131, which every CPU except TRICORE_FEATURE_13 CPUs have. Resolves: https://gitlab

[PATCH 3/4] target/tricore: Add CHECK_REG_PAIR() for insn accessing 64 bit regs

some insns were not checking if an even index was used to access a 64 bit register. In the worst case that could lead to a buffer overflow as reported in https://gitlab.com/qemu-project/qemu/-/issues/1698. Reported-by: Siqi Chen Signed-off-by: Bastian Koppelmann --- target/tricore/translate.c |

[PATCH 1/4] target/tricore: Fix out-of-bounds index in imask instruction

From: Siqi Chen When translating "imask" instruction of Tricore architecture, QEMU did not check whether the register index was out of bounds, resulting in a global-buffer-overflow. Reviewed-by: Bastian Koppelmann Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1698 Reported-by: Siqi

  1   2   >