[PATCH v9 0/4] Virtio shared dma-buf

v1 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00598.html v2 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04530.html v3 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg06126.html v4 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Mon, Oct 02, 2023 at 03:56:03AM +0200, Laszlo Ersek wrote: > On 10/1/23 21:25, Michael S. Tsirkin wrote: > > Not this actually - v2 of this. > > Thank you, but: > > - Stefan's question should be answered still IMO (although if you pick > up this series, then that could be interpreted as "QEMU

[PATCH v9 3/4] vhost-user: add shared_object msg

Add three new vhost-user protocol `VHOST_USER_BACKEND_SHARED_OBJECT_* messages`. These new messages are sent from vhost-user back-ends to interact with the virtio-dmabuf table in order to add or remove themselves as virtio exporters, or lookup for virtio dma-buf shared objects. The action taken in

Re: [PATCH v2] mailmap: update email addresses for Luc Michel

On 29/9/23 16:03, Luc Michel wrote: Map my old and now invalid work email addresses to my personal one. Signed-off-by: Luc Michel --- Please ignore v1 sent with wrong e-mail address. --- .mailmap | 3 +++ 1 file changed, 3 insertions(+) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v9 4/4] libvhost-user: handle shared_object msg

In the libvhost-user library we need to handle VHOST_USER_GET_SHARED_OBJECT requests, and add helper functions to allow sending messages to interact with the virtio shared objects hash table. Signed-off-by: Albert Esteve --- subprojects/libvhost-user/libvhost-user.c | 120 ++

[PATCH v9 1/4] util/uuid: add a hash function

Add hash function to uuid module using the djb2 hash algorithm. Add a couple simple unit tests for the hash function, checking collisions for similar UUIDs. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Albert Esteve --- include/qemu/uuid.h| 2 ++ tests/unit/test-uuid.c | 27

[PATCH v9 2/4] hw/display: introduce virtio-dmabuf

This API manages objects (in this iteration, dmabuf fds) that can be shared along different virtio devices, associated to a UUID. The API allows the different devices to add, remove and/or retrieve the objects by simply invoking the public functions that reside in the virtio-dmabuf file. For vhos

Re: [PATCH] target/arm/kvm64.c: Remove unused include

On 25/9/23 13:04, Peter Maydell wrote: The include of hw/arm/virt.h in kvm64.c is unnecessary and also a layering violation since the generic KVM code shouldn't need to know anything about board-specifics. The include line is an accidental leftover from commit 15613357ba53a4763, where we cleaned

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On Wed, Aug 30, 2023 at 11:37:50AM -0400, Stefan Hajnoczi wrote: > On Wed, 30 Aug 2023 at 09:30, Laszlo Ersek wrote: > > > > On 8/30/23 14:10, Stefan Hajnoczi wrote: > > > On Sun, 27 Aug 2023 at 14:31, Laszlo Ersek wrote: > > >> > > >> (1) The virtio-1.0 specification > > >>

Re: [PATCH] mailmap: Fix Andrey Drobyshev author email

On 26/9/23 12:28, andrey.drobys...@virtuozzo.com wrote: From: Andrey Drobyshev This fixes authorship of commits 2848289168, 52b10c9c0c as the mailing list rewrote the "From:" field in the corresponding patches. See commit 3bd2608db7 ("maint: Add .mailmap entries for patches claiming list autho

Re: [PATCH v8 1/4] util/uuid: add a hash function

On Sun, Oct 1, 2023 at 10:15 PM Michael S. Tsirkin wrote: > On Fri, Sep 08, 2023 at 05:47:40PM +0200, Albert Esteve wrote: > > Add hash function to uuid module using the > > djb2 hash algorithm. > > > > Add a couple simple unit tests for the hash > > function, checking collisions for similar UUID

Re: [PATCH] crypto: only include tls-cipher-suites in emulators

On 28/9/23 09:49, Paolo Bonzini wrote: tls-cipher-suites is an object that is used to inject TLS configuration into the guest (via fw_cfg). It is never used for host-side TLS operation, and therefore it need not be available in the tools. Signed-off-by: Paolo Bonzini --- crypto/meson.build

Re: [PATCH v2 2/2] elf2dmp: check array bounds in pdb_get_file_size

On 1/10/23 01:53, Viktor Prutyanov wrote: Index in file_size array must be checked against num_files, because the entries we are looking for may be absent in the PDB. Fixes: Coverity CID 1521597 Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/pdb.c | 13 + 1 file changed, 9 i

Re: [PATCH v3 0/8] qemu-img: rebase: add compression support

On 9/19/23 20:57, Andrey Drobyshev wrote: > v2 --> v3: > * Patch 3/8: fixed logic in the if statement, so that we align on blk >when blk_old_backing == NULL; > * Patch 4/8: comment fix; > * Patch 5/8: comment fix; dropped redundant "if (blk_new_backing)" >statements. > > v2: https://lis

Re: [PATCH] build: Remove --enable-gprof

On 30/9/23 20:18, Richard Henderson wrote: This build option has been deprecated since 8.0. Remove all CONFIG_GPROF code that depends on that, including one errant check using TARGET_GPROF. Signed-off-by: Richard Henderson --- docs/about/deprecated.rst | 14 -- meson.build

Re: [PATCH] linux-user/hppa: Fix struct target_sigcontext layout

On 30/9/23 23:27, Richard Henderson wrote: Use abi_ullong not uint64_t so that the alignment of the field and therefore the layout of the struct is correct. Signed-off-by: Richard Henderson --- linux-user/hppa/signal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Phil

Re: [PATCH] MAINTAINERS: Add the CI-related doc files to the CI section

On 29/9/23 15:16, Thomas Huth wrote: The docs/devel/ci* were not covered yet, add them to MAINTAINERS so that the right people are put on CC: for related patches. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: MAINTAINERS still leaves more files uncovered than I'd like

On 29/9/23 13:43, Markus Armbruster wrote: Back in 2014 (time flies), I posted Subject: MAINTAINERS leaves too many files uncovered Message-ID: <87mw8rumhb@blackfin.pond.sub.org> https://lore.kernel.org/qemu-devel/87mw8rumhb@blackfin.pond.sub.org/ I updated my findings in

Re: MAINTAINERS still leaves more files uncovered than I'd like

Hi Markus, On 29/9/23 13:43, Markus Armbruster wrote: Back in 2014 (time flies), I posted Subject: MAINTAINERS leaves too many files uncovered Message-ID: <87mw8rumhb@blackfin.pond.sub.org> https://lore.kernel.org/qemu-devel/87mw8rumhb@blackfin.pond.sub.org/ I updated my

Re: [PATCH] MAINTAINERS: add standard-headers to Hosts/LINUX

Hi Cornelia, On 29/9/23 16:30, Cornelia Huck wrote: The files in there are updated via update-linux-headers.sh. So F: or X: (exclusion)? Regardless, Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cornelia Huck --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAIN

Re: [PATCH 3/9] hw/acpi: Add ACPI CPU hotplug init stub

Hi Salil, On 29/9/23 17:47, Salil Mehta wrote: From: Alex Bennée Sent: Friday, September 29, 2023 3:27 PM To: Salil Mehta Cc: qemu-devel@nongnu.org; qemu-...@nongnu.org; m...@kernel.org; jean- phili...@linaro.org; Jonathan Cameron ; lpieral...@kernel.org; peter.mayd...@linaro.org; richard.hend

Re: [PATCH] MAINTAINERS: Add include folder to the hw/char/ section

On 29/9/23 14:44, Thomas Huth wrote: The "Character devices" section only covers hw/char/ but misses the corresponding include/hw/char/ folder. Add it now. Signed-off-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] hw/display/ramfb: plug slight guest-triggerable leak on mode setting

On 10/1/23 18:07, Marc-André Lureau wrote: > Hi Laszlo > > On Sun, Oct 1, 2023 at 4:20 AM Laszlo Ersek wrote: >> >> On 10/1/23 00:14, Laszlo Ersek wrote: >>> On 9/29/23 13:17, Marc-André Lureau wrote: > [..] fwiw, my migration support patch is still unreviewed: https://patchew.org/QEMU/

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/1/23 21:25, Michael S. Tsirkin wrote: > Not this actually - v2 of this. Thank you, but: - Stefan's question should be answered still IMO (although if you pick up this series, then that could be interpreted as "QEMU bug, not spec bug") - I was supposed to update the commit message on 7/7 in

Re: [PATCH v2 1/1] qemu-img: do not erase destination file in qemu-img dd command

Can you please not top-post. This makes the discussion complex. This approach is followed in this mailing list and in other similar lists like LKML. On 10/1/23 19:08, Mike Maslenkin wrote: I thought about "conv=notrunc", but my main concern is changed virtual disk metadata. It depends on how qem

Re: [PATCH v8 1/4] util/uuid: add a hash function

On Fri, Sep 08, 2023 at 05:47:40PM +0200, Albert Esteve wrote: > Add hash function to uuid module using the > djb2 hash algorithm. > > Add a couple simple unit tests for the hash > function, checking collisions for similar UUIDs. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Albert Es

Re: [PATCH v3 2/2] vhost: Add Error parameter to vhost_scsi_common_start()

On Tue, Sep 12, 2023 at 04:32:59PM +0800, Li Feng wrote: > Please mention in the commit message that error messages improve, and > silent errors are now reported. > > Ack. Still waiting for v4 with the updated commit log. -- MST

Re: [PATCH v4 0/8] vdpa: Send all CVQ state load commands in parallel

On Tue, Aug 29, 2023 at 01:54:42PM +0800, Hawkins Jiawei wrote: > This patchset allows QEMU to delay polling and checking the device > used buffer until either the SVQ is full or control commands shadow > buffers are full, instead of polling and checking immediately after > sending each SVQ control

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

Not this actually - v2 of this. On Sun, Oct 01, 2023 at 03:24:59PM -0400, Michael S. Tsirkin wrote: > yes sorry - I am working on a pull request with this > included. > > On Mon, Sep 25, 2023 at 05:31:17PM +0200, Laszlo Ersek wrote: > > Ping -- Michael, any comments please? This set (now at v2) h

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

yes sorry - I am working on a pull request with this included. On Mon, Sep 25, 2023 at 05:31:17PM +0200, Laszlo Ersek wrote: > Ping -- Michael, any comments please? This set (now at v2) has been > waiting on your answer since Aug 30th. > > Laszlo > > On 9/5/23 08:30, Laszlo Ersek wrote: > > Mich

Re: [PATCH 2/2] qapi: qga: Clarify when out-data and err-data are populated

Reviewed-by: Konstantin Kostiuk On Sun, Oct 1, 2023 at 9:39 PM Daniel Xu wrote: > If output is being captured for a guest-exec invocation, the out-data > and err-data fields of guest-exec-status are only populated after the > process is reaped. This is somewhat counter intuitive and too late to

Re: [PATCH 2/3] qga: Add optional stream-output argument to guest-exec

Hi Konstantin, On Wed, Sep 27, 2023, at 2:43 AM, Konstantin Kostiuk wrote: > Hi Daniel, > > As for me, the idea of using QGA as an interactive shell is not good. > I suggest using virtio-serial as a transport for stdin/stdout of your > process. > Examples: > > https://stackoverflow.com/ques

[PATCH 1/2] qga: Fix memory leak when output stream is unused

If capture-output is requested but one of the channels goes unused (eg. we attempt to capture stderr but the command never writes to stderr), we can leak memory. guest_exec_output_watch() is (from what I understand) unconditionally called for both streams if output capture is requested. The first

[PATCH 0/2] Small fixes for qga

These are two small fixes that fell out of [0]. Since we are not moving forward with that patchset, I thought it would be good to at least send the fixes that came out of it. See commits for more details. [0]: https://lore.kernel.org/qemu-devel/cover.1695034158.git@dxuuu.xyz/ Daniel Xu (2):

[PATCH 2/2] qapi: qga: Clarify when out-data and err-data are populated

If output is being captured for a guest-exec invocation, the out-data and err-data fields of guest-exec-status are only populated after the process is reaped. This is somewhat counter intuitive and too late to change. Thus, it would be good to document the behavior. Signed-off-by: Daniel Xu ---

Re: [PATCH] build: Remove --enable-gprof

Richard Henderson writes: > This build option has been deprecated since 8.0. > Remove all CONFIG_GPROF code that depends on that, > including one errant check using TARGET_GPROF. > > Signed-off-by: Richard Henderson Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 1/1] qemu-img: do not erase destination file in qemu-img dd command

I thought about "conv=notrunc", but my main concern is changed virtual disk metadata. It depends on how qemu-img used. May be I followed to wrong pattern, but pros and cons of adding "conv" parameter was not in my mind in scope of the first patch version. I see 4 obvious ways of using `qemu-img dd`

Re: [PATCH] hw/display/ramfb: plug slight guest-triggerable leak on mode setting

Hi Laszlo On Sun, Oct 1, 2023 at 4:20 AM Laszlo Ersek wrote: > > On 10/1/23 00:14, Laszlo Ersek wrote: > > On 9/29/23 13:17, Marc-André Lureau wrote: [..] > >> fwiw, my migration support patch is still unreviewed: > >> https://patchew.org/QEMU/20230920082651.3349712-1-marcandre.lur...@redhat.com/

Re: [PATCH] linux-user/elfload: Enable LSX/LASX in HWCAP for LoongArch

On 10/1/23 01:53, Jiajie Chen wrote: Since support for LSX and LASX is landed in QEMU recently, we can update HWCAPS accordingly. Signed-off-by: Jiajie Chen --- linux-user/elfload.c | 8 1 file changed, 8 insertions(+) Reviewed-by: Richard Henderson r~

Re: [PATCH v2 1/1] qemu-img: do not erase destination file in qemu-img dd command

On 9/30/23 22:31, Mike Maslenkin wrote: Add a check that destination file exists and do not call bdrv_create for this case. Currently `qemu-img dd` command destroys content of destination file. Effectively this means that parameters (geometry) of destination image file are changing. This can be

Re: [PATCH 0/4] ui/console: multihead: fix crash, simplify logic

01.10.2023 12:31, Laszlo Ersek пишет: On 10/1/23 08:15, Mark Cave-Ayland wrote: On 30/09/2023 22:28, Laszlo Ersek wrote: On 9/29/23 09:57, Mark Cave-Ayland wrote: On 26/09/2023 09:00, Marc-André Lureau wrote: Hi Laszlo On Mon, Sep 25, 2023 at 7:36 PM Laszlo Ersek wrote: Has this been que

Re: [PATCH 0/4] ui/console: multihead: fix crash, simplify logic

On 10/1/23 08:15, Mark Cave-Ayland wrote: > On 30/09/2023 22:28, Laszlo Ersek wrote: > >> On 9/29/23 09:57, Mark Cave-Ayland wrote: >>> On 26/09/2023 09:00, Marc-André Lureau wrote: >>> Hi Laszlo On Mon, Sep 25, 2023 at 7:36 PM Laszlo Ersek wrote: > Has this been queued by some

[PATCH] linux-user/elfload: Enable LSX/LASX in HWCAP for LoongArch

Since support for LSX and LASX is landed in QEMU recently, we can update HWCAPS accordingly. Signed-off-by: Jiajie Chen --- linux-user/elfload.c | 8 1 file changed, 8 insertions(+) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index db75cd4b33..f11f25309e 100644 --- a/linux