Re: [PATCH v4 03/10] migration: migrate 'inc' command option is deprecated.

2023-10-16 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Markus Armbruster wrote: Juan Quintela writes: >>> So what I want, I want to remove -i/-b in the next version (9.0?). For >>> the other, I want to remove it, but I don't care if the code is around >>> in

Re: [PATCH 03/17] meson, cutils: allow non-relocatable installs

2023-10-16 Thread Markus Armbruster
Paolo Bonzini writes: > On Mon, Oct 16, 2023 at 1:55 PM Markus Armbruster wrote: >> Out of curiosity: what's a non-relocatable install, and why should I >> care? > > In a relocatable install if you move qemu-system-x86_64 from /usr/bin > to /home/armbru/bin, it will start looking for firmware

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-16 Thread Viresh Kumar
On 16-10-23, 12:40, Alex Bennée wrote: > > Viresh Kumar writes: > > > On 16-10-23, 11:45, Manos Pitsidianakis wrote: > >> On Mon, 16 Oct 2023 11:32, Hanna Czenczek wrote: > >> > diff --git a/include/hw/virtio/vhost-user.h > >> > b/include/hw/virtio/vhost-user.h > >> > index

Re: [PATCH 39/52] migration/rdma: Convert qemu_rdma_write_one() to Error

2023-10-16 Thread Zhijian Li (Fujitsu)
On 16/10/2023 20:11, Jason Gunthorpe wrote: > On Sat, Oct 07, 2023 at 03:40:50AM +, Zhijian Li (Fujitsu) wrote: >> +rdma-core >> >> >> Is global variable *errno* reliable when the documentation only states >> "returns 0 on success, or the value of errno on failure (which indicates the >>

[PATCH v2 2/3] backends: Initial support for SPDM socket support

2023-10-16 Thread Alistair Francis
From: Huai-Cheng Kuo SPDM enables authentication, attestation and key exchange to assist in providing infrastructure security enablement. It's a standard published by the DMTF [1]. SPDM supports multiple transports, including PCIe DOE and MCTP. This patch adds support to QEMU to connect to an

[PATCH v2 3/3] hw/nvme: Add SPDM over DOE support

2023-10-16 Thread Alistair Francis
From: Wilfred Mallawa Setup Data Object Exchance (DOE) as an extended capability for the NVME controller and connect SPDM to it (CMA) to it. Signed-off-by: Wilfred Mallawa Signed-off-by: Alistair Francis --- docs/specs/index.rst| 1 + docs/specs/spdm.rst | 114

[PATCH v2 0/3] Initial support for SPDM Responders

2023-10-16 Thread Alistair Francis
The Security Protocol and Data Model (SPDM) Specification defines messages, data objects, and sequences for performing message exchanges over a variety of transport and physical media. - https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.3.0.pdf SPDM currently supports PCIe

[PATCH v2 1/3] hw/pci: Add all Data Object Types defined in PCIe r6.0

2023-10-16 Thread Alistair Francis
Add all of the defined protocols/features from the PCIe-SIG r6.0 "Table 6-32 PCI-SIG defined Data Object Types (Vendor ID = 0001h)" table. Signed-off-by: Alistair Francis --- include/hw/pci/pcie_doe.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/hw/pci/pcie_doe.h

Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()

2023-10-16 Thread Michael Tokarev
05.09.2023 17:50, Kevin Wolf wrote: virtio_load() as a whole should run in coroutine context because it reads from the migration stream and we don't want this to block. However, it calls virtio_set_features_nocheck() and devices don't expect their .set_features callback to run in a coroutine

Re: [PATCH v17 0/9] gfxstream + rutabaga_gfx

2023-10-16 Thread Marc-André Lureau
Hi Gurchetan On Tue, Oct 17, 2023 at 5:27 AM Gurchetan Singh wrote: > > > > On Mon, Oct 9, 2023 at 12:15 AM Marc-André Lureau > wrote: >> >> Hi >> >> On Fri, Oct 6, 2023 at 5:08 AM Gurchetan Singh >> wrote: >> > >> > From: Gurchetan Singh >> > >> > Branch containing changes: >> > >> >

[PATCH v5 16/21] ebpf: Fix RSS error handling

2023-10-16 Thread Akihiko Odaki
calculate_rss_hash() was using hash value 0 to tell if it calculated a hash, but the hash value may be 0 on a rare occasion. Have a distinct bool value for correctness. Fixes: f3fa412de2 ("ebpf: Added eBPF RSS program.") Signed-off-by: Akihiko Odaki --- tools/ebpf/rss.bpf.c | 20

[PATCH v5 11/21] virtio-net: Return an error when vhost cannot enable RSS

2023-10-16 Thread Akihiko Odaki
vhost requires eBPF for RSS. Even when eBPF is not available, virtio-net reported RSS availability, and raised a warning only after the guest requested RSS, and the guest could not know that RSS is not available. Check RSS availability during device realization and return an error if RSS is

[PATCH v5 02/21] tap: Remove qemu_using_vnet_hdr()

2023-10-16 Thread Akihiko Odaki
Since qemu_set_vnet_hdr_len() is always called when qemu_using_vnet_hdr() is called, we can merge them and save some code. For consistency, express that the virtio-net header is not in use by returning 0 with qemu_get_vnet_hdr_len() instead of having a dedicated function,

[PATCH v5 18/21] ebpf: Simplify error handling

2023-10-16 Thread Akihiko Odaki
The error handling procedures required when rss_bpf__open() and rss_bpf__load(rss_bpf_ctx) are different so it's better to implement them separately. Signed-off-by: Akihiko Odaki --- ebpf/ebpf_rss.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/ebpf/ebpf_rss.c

[PATCH v5 10/21] virtio-net: Unify the logic to update NIC state for RSS

2023-10-16 Thread Akihiko Odaki
The code to attach or detach the eBPF program to RSS were duplicated so unify them into one function to save some code. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 90 ++--- 1 file changed, 36 insertions(+), 54 deletions(-) diff --git

[PATCH v5 20/21] ebpf: Refactor tun_rss_steering_prog()

2023-10-16 Thread Akihiko Odaki
This saves branches and makes later BPF program changes easier. Signed-off-by: Akihiko Odaki --- tools/ebpf/rss.bpf.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/tools/ebpf/rss.bpf.c b/tools/ebpf/rss.bpf.c index 22c75d5912..012af38df1 100644

[PATCH v5 09/21] virtio-net: Disable RSS on reset

2023-10-16 Thread Akihiko Odaki
RSS is disabled by default. Fixes: 590790297c ("virtio-net: implement RSS configuration command") Signed-off-by: Akihiko Odaki Reviewed-by: Michael Tokarev --- hw/net/virtio-net.c | 70 +++-- 1 file changed, 36 insertions(+), 34 deletions(-) diff --git

[PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT

2023-10-16 Thread Akihiko Odaki
virtio-net can report hash values even if the peer does not have a virtio-net header. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index c6a92ba3db..dc2b7b8ee7 100644 --- a/hw/net/virtio-net.c

[PATCH v5 21/21] ebpf: Add a separate target for skeleton

2023-10-16 Thread Akihiko Odaki
This generalizes the rule to generate the skeleton and allows to add another. Signed-off-by: Akihiko Odaki --- tools/ebpf/Makefile.ebpf | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tools/ebpf/Makefile.ebpf b/tools/ebpf/Makefile.ebpf index

[PATCH v5 12/21] virtio-net: Always set populate_hash

2023-10-16 Thread Akihiko Odaki
The member is not cleared during reset so may have a stale value. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 20feb20bb1..6eb206f297 100644 --- a/hw/net/virtio-net.c +++

[PATCH v5 01/21] tap: Remove tap_probe_vnet_hdr_len()

2023-10-16 Thread Akihiko Odaki
It was necessary since an Linux older than 2.6.35 may implement the virtio-net header but may not allow to change its length. Remove it since such an old Linux is no longer supported. Signed-off-by: Akihiko Odaki Acked-by: Michael S. Tsirkin --- net/tap_int.h | 1 - net/tap-bsd.c | 5

[PATCH v5 17/21] ebpf: Use standard section name

2023-10-16 Thread Akihiko Odaki
It makes easier to play with bpftool by allowing it to infer the program type. It also makes it unnecessary to set the program type manually when loading the program in ebpf_rss_load(). Signed-off-by: Akihiko Odaki --- ebpf/rss.bpf.skeleton.h | 1514 ---

[PATCH v5 19/21] ebpf: Return 0 when configuration fails

2023-10-16 Thread Akihiko Odaki
The kernel interprets the returned value as an unsigned 32-bit so -1 will mean queue 4294967295, which is awkward. Return 0 instead. Signed-off-by: Akihiko Odaki --- ebpf/rss.bpf.skeleton.h | 1339 +++ tools/ebpf/rss.bpf.c|2 +- 2 files changed, 670

[PATCH v5 03/21] net: Move virtio-net header length assertion

2023-10-16 Thread Akihiko Odaki
The virtio-net header length assertion should happen for any clients. Signed-off-by: Akihiko Odaki --- net/net.c | 5 + net/tap.c | 3 --- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/net/net.c b/net/net.c index 1bb4f33a63..6d2fa8d40f 100644 --- a/net/net.c +++ b/net/net.c

[PATCH v5 05/21] tap: Remove tap_receive()

2023-10-16 Thread Akihiko Odaki
The receive member of NetClientInfo is only for legacy clients and the receive_iov member is always used when it is set. Signed-off-by: Akihiko Odaki --- net/tap.c | 36 1 file changed, 36 deletions(-) diff --git a/net/tap.c b/net/tap.c index

[PATCH v5 08/21] virtio-net: Copy header only when necessary

2023-10-16 Thread Akihiko Odaki
It is necessary to copy the header only for byte swapping. Worse, when byte swapping is not needed, the header can be larger than the buffer due to VIRTIO_NET_F_HASH_REPORT, which results in buffer overflow. Copy the header only when byte swapping is needed. Fixes: e22f0603fb ("virtio-net:

[PATCH v5 14/21] virtio-net: Do not write hashes to peer buffer

2023-10-16 Thread Akihiko Odaki
The peer buffer is qualified with const and not meant to be modified. It also prevents enabling VIRTIO_NET_F_HASH_REPORT for peers without virtio-net header support. Signed-off-by: Akihiko Odaki --- hw/net/virtio-net.c | 36 +--- 1 file changed, 17 insertions(+),

[PATCH v5 13/21] virtio-net: Do not clear VIRTIO_NET_F_RSS

2023-10-16 Thread Akihiko Odaki
Even if eBPF is not available, virtio-net can perform RSS on the user-space if vhost is disabled although such a configuration results in a warning. If vhost is enabled, the configuration will be rejected when realizing the device. Therefore, VIRTIO_NET_F_RSS should not be cleared even if eBPF is

[PATCH v5 00/21] virtio-net RSS/hash report fixes and improvements

2023-10-16 Thread Akihiko Odaki
This series contains fixes and improvements for virtio-net RSS and hash reporting feature. V4 -> V5: Added patch "virtio-net: Do not write hashes to peer buffer". V3 -> V4: Extract patches "tap: Remove tap_receive()" and "net: Remove flag propagation" from "net: Remove receive_raw()".

[PATCH v5 04/21] net: Remove receive_raw()

2023-10-16 Thread Akihiko Odaki
While netmap implements virtio-net header, it does not implement receive_raw(). Instead of implementing receive_raw for netmap, add virtio-net headers in the common code and use receive_iov()/receive() instead. This also fixes the buffer size for the virtio-net header. Fixes: fbbdbddec0 ("tap:

[PATCH v5 06/21] net: Remove flag propagation

2023-10-16 Thread Akihiko Odaki
There is no defined flag now. Signed-off-by: Akihiko Odaki --- include/net/filter.h| 3 --- include/net/queue.h | 6 -- include/sysemu/replay.h | 2 +- net/dump.c | 4 ++-- net/filter-buffer.c | 4 +--- net/filter-mirror.c | 6 ++ net/filter-replay.c

[PATCH v5 07/21] tap: Shrink zeroed virtio-net header

2023-10-16 Thread Akihiko Odaki
tap prepends a zeroed virtio-net header when writing a packet to a tap with virtio-net header enabled but not in use. This only happens when s->host_vnet_hdr_len == sizeof(struct virtio_net_hdr). Signed-off-by: Akihiko Odaki --- net/tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 0/3] Add emulation of AmigaOne XE board

2023-10-16 Thread Nicholas Piggin
On Tue Oct 17, 2023 at 8:25 AM AEST, BALATON Zoltan wrote: > On Sat, 14 Oct 2023, BALATON Zoltan wrote: > > Changes in v3: > > - Update values, comment and commit message in patch 1 again > > > > Changes in v2: > > - Update comment and commit message in patch 1 (Mark) > > - Fix irq mapping in

Re: [PATCH v2 00/10] riscv: RVA22U64 profile support

2023-10-16 Thread Alistair Francis
On Mon, Oct 16, 2023 at 7:03 PM Andrew Jones wrote: > > On Thu, Oct 12, 2023 at 04:07:50PM -0300, Daniel Henrique Barboza wrote: > > > > > > On 10/11/23 00:01, Alistair Francis wrote: > > > On Sat, Oct 7, 2023 at 12:23 AM Daniel Henrique Barboza > > > wrote: > > > > > > > > Hi, > > > > > > > >

Re: [PATCH v2 1/3] target/riscv: Do not allow MXL_RV32 for TARGET_RISCV64

2023-10-16 Thread LIU Zhiwei
On 2023/10/17 11:32, Alistair Francis wrote: On Tue, Oct 17, 2023 at 12:14 PM LIU Zhiwei wrote: On 2023/10/16 9:51, Alistair Francis wrote: On Sun, Oct 15, 2023 at 4:05 AM Daniel Henrique Barboza wrote: On 10/14/23 00:35, Akihiko Odaki wrote: TARGET_RISCV64 does not have

Re: [PATCH 1/4] target/riscv: Remove misa_mxl validation

2023-10-16 Thread Akihiko Odaki
On 2023/10/17 11:29, LIU Zhiwei wrote: On 2023/10/12 13:42, Akihiko Odaki wrote: It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki ---   target/riscv/cpu.c | 13 ++---   1 file

Re: [PATCH v2 1/3] target/riscv: Do not allow MXL_RV32 for TARGET_RISCV64

2023-10-16 Thread Alistair Francis
On Tue, Oct 17, 2023 at 12:14 PM LIU Zhiwei wrote: > > > On 2023/10/16 9:51, Alistair Francis wrote: > > On Sun, Oct 15, 2023 at 4:05 AM Daniel Henrique Barboza > > wrote: > >> > >> > >> On 10/14/23 00:35, Akihiko Odaki wrote: > >>> TARGET_RISCV64 does not have riscv-32bit-cpu.xml so it

Re: [PATCH 1/4] target/riscv: Remove misa_mxl validation

2023-10-16 Thread LIU Zhiwei
On 2023/10/12 13:42, Akihiko Odaki wrote: It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki --- target/riscv/cpu.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-)

Re: [PATCH v2 1/3] target/riscv: Do not allow MXL_RV32 for TARGET_RISCV64

2023-10-16 Thread LIU Zhiwei
On 2023/10/16 9:51, Alistair Francis wrote: On Sun, Oct 15, 2023 at 4:05 AM Daniel Henrique Barboza wrote: On 10/14/23 00:35, Akihiko Odaki wrote: TARGET_RISCV64 does not have riscv-32bit-cpu.xml so it shouldn't accept MXL_RV32. Signed-off-by: Akihiko Odaki --- Reviewed-by: Daniel

Re: [PATCH v17 0/9] gfxstream + rutabaga_gfx

2023-10-16 Thread Gurchetan Singh
On Mon, Oct 9, 2023 at 12:15 AM Marc-André Lureau < marcandre.lur...@redhat.com> wrote: > Hi > > On Fri, Oct 6, 2023 at 5:08 AM Gurchetan Singh > wrote: > > > > From: Gurchetan Singh > > > > Branch containing changes: > > > > https://gitlab.com/gurchetansingh/qemu/-/commits/qemu-gfxstream-v17 >

Re: [PATCH v5 0/6] target/riscv: Add RISC-V Virtual IRQs and IRQ filtering support

2023-10-16 Thread Alistair Francis
On Mon, Oct 16, 2023 at 9:19 PM Rajnesh Kanwal wrote: > > This series adds M and HS-mode virtual interrupt and IRQ filtering support. > This allows inserting virtual interrupts from M/HS-mode into S/VS-mode > using mvien/hvien and mvip/hvip csrs. IRQ filtering is a use case of > this change, i-e

QEMU Virtio GPU features status & roadmap?

2023-10-16 Thread Hans de Ruiter
Hi, I'm working on Virtio GPU drivers for AmigaOS, and would like to know what features are currently stable enough to use. Looking at the master QEMU branch, both Virgl and blob resources are supported, but NOT at the same time. Is the ability to use both simultaneously coming soon? Also,

Re: [PATCH v4 2/2] migration: prevent migration when a poisoned page is unknown from the VM

2023-10-16 Thread William Roche
On 10/16/23 18:48, Peter Xu wrote: On Fri, Oct 13, 2023 at 03:08:39PM +, “William Roche wrote: diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index 5e95c496bb..e8db6380c1 100644 --- a/target/arm/kvm64.c +++ b/target/arm/kvm64.c @@ -1158,7 +1158,6 @@ void

RE: [PATCH RFC V2 35/37] hw/arm: Support hotplug capability check using _OSC method

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 5:23 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 34/37] target/arm/kvm,tcg: Register/Handle SMCCC hypercall exits to VMM/Qemu

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 5:15 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 29/37] arm/virt: Update the guest(via GED) about CPU hot-(un)plug events

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 1:31 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

Re: [PULL 00/25] Python patches

2023-10-16 Thread John Snow
On Mon, Oct 16, 2023 at 3:21 PM Stefan Hajnoczi wrote: > > Applied, thanks. > > Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any > user-visible changes. Hi Vladimir: all done! I've created a MR to backport your changes to the standalone repo here:

RE: [PATCH RFC V2 25/37] arm/virt: Add/update basic hot-(un)plug framework

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 1:21 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 23/37] arm/virt: Release objects for *disabled* possible vCPUs after init

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 12:58 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 22/37] hw/acpi: Make _MAT method optional

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 12:50 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 21/37] hw/arm: MADT Tbl change to size the guest with possible vCPUs

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 12:44 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 20/37] hw/acpi: Update GED _EVT method AML with cpu scan

2023-10-16 Thread Salil Mehta via
> From: Gavin Shan > Sent: Friday, September 29, 2023 12:36 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 19/37] hw/acpi: ACPI/AML Changes to reflect the correct _STA.{PRES,ENA} Bits to Guest

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 12:34 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

Re: Performance Issue with CXL-emulation

2023-10-16 Thread lokesh jaliminche
Hi Jonathan, Thanks for your quick and detailed response. I'll explore these options further and asses if I get any performance uptick. Thanks & Regards, Lokesh On Mon, Oct 16, 2023 at 2:56 AM Jonathan Cameron wrote: > > On Sun, 15 Oct 2023 10:39:46 -0700 > lokesh jaliminche wrote: > > > Hi

RE: [PATCH RFC V2 18/37] arm/virt: Make ARM vCPU *present* status ACPI *persistent*

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Friday, September 29, 2023 12:18 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

Re: Performance Issue with CXL-emulation

2023-10-16 Thread lokesh jaliminche
Hi Jonathan, Thanks for your quick and detailed response. I'll explore these options further and asses if I get any performance uptick. Thanks & Regards, Lokesh On Mon, Oct 16, 2023 at 2:56 AM Jonathan Cameron < jonathan.came...@huawei.com> wrote: > On Sun, 15 Oct 2023 10:39:46 -0700 > lokesh

Re: [PATCH v3 0/3] Add emulation of AmigaOne XE board

2023-10-16 Thread BALATON Zoltan
On Sat, 14 Oct 2023, BALATON Zoltan wrote: Changes in v3: - Update values, comment and commit message in patch 1 again Changes in v2: - Update comment and commit message in patch 1 (Mark) - Fix irq mapping in patch 2 (Volker) Regards, BALATON Zoltan BALATON Zoltan (3): via-ide: Fix legacy

UEFI secure boot on Macos

2023-10-16 Thread Jacek Suchenia
Hi Recently, I was trying to run x86_64 UEFI image on Macos (both Intel and Apple Silicon), * With edk2 and secure boot enabled - it hangs before video card init * With edk2 and without secure boot - it boots the image correctly - so the video splash screen from edk2 is present, and then the

[PATCH v3 0/2] Add PowerNV I2C Controller Model

2023-10-16 Thread Glenn Miles
Upstreams the PowerNV I2C controller model originally authored by Cédric Le Goater with minor changes by myself to split the actual addition of the model from wiring it up to a power processor model. This series only attaches the controller to the powernv9 chip model, but is expected to

[PATCH v3 2/2] ppc/pnv: Connect I2C controller model to powernv9 chip

2023-10-16 Thread Glenn Miles
From: Cédric Le Goater Wires up three I2C controller instances to the powernv9 chip XSCOM address space. Each controller instance is wired up to a single I2C bus of its own. No other I2C devices are connected to the buses at this time. Signed-off-by: Cédric Le Goater [milesg: Split wiring

[PATCH v3 1/2] ppc/pnv: Add an I2C controller model

2023-10-16 Thread Glenn Miles
From: Cédric Le Goater The more recent IBM power processors have an embedded I2C controller that is accessible by software via the XSCOM address space. Each instance of the I2C controller is capable of controlling multiple I2C buses (one at a time). Prior to beginning a transaction on an I2C

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-16 Thread BALATON Zoltan
On Sun, 15 Oct 2023, Mark Cave-Ayland wrote: On 14/10/2023 17:13, BALATON Zoltan wrote: On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because

RE: [PATCH RFC V2 17/37] arm/virt/acpi: Build CPUs AML with CPU Hotplug support

2023-10-16 Thread Salil Mehta via
> From: Gavin Shan > Sent: Thursday, September 28, 2023 2:36 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 16/37] hw/acpi: Update CPUs AML with cpu-(ctrl)dev change

2023-10-16 Thread Salil Mehta via
> From: Gavin Shan > Sent: Thursday, September 28, 2023 2:26 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 15/37] arm/virt: Create GED dev before *disabled* CPU Objs are destroyed

2023-10-16 Thread Salil Mehta via
> From: Gavin Shan > Sent: Thursday, September 28, 2023 2:08 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 14/37] arm/virt: Add cpu hotplug events to GED during creation

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Thursday, September 28, 2023 2:04 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 13/37] hw/acpi: Init GED framework with cpu hotplug events

2023-10-16 Thread Salil Mehta via
> From: Gavin Shan > Sent: Thursday, September 28, 2023 1:57 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 12/37] hw/acpi: Use qemu_present_cpu() API in ACPI CPU hotplug init

2023-10-16 Thread Salil Mehta via
> From: Gavin Shan > Sent: Thursday, September 28, 2023 1:41 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

Re: [PATCH 03/17] meson, cutils: allow non-relocatable installs

2023-10-16 Thread Paolo Bonzini
On Mon, Oct 16, 2023 at 1:55 PM Markus Armbruster wrote: > Out of curiosity: what's a non-relocatable install, and why should I > care? In a relocatable install if you move qemu-system-x86_64 from /usr/bin to /home/armbru/bin, it will start looking for firmware in /home/armbru/share/qemu. In a

RE: [PATCH RFC V2 11/37] hw/acpi: Add ACPI CPU hotplug init stub

2023-10-16 Thread Salil Mehta via
> From: Gavin Shan > Sent: Thursday, September 28, 2023 1:28 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

RE: [PATCH RFC V2 10/37] arm/acpi: Enable ACPI support for vcpu hotplug

2023-10-16 Thread Salil Mehta via
Hi Gavin, > From: Gavin Shan > Sent: Thursday, September 28, 2023 1:26 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; >

Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-16 Thread Paolo Bonzini
On Mon, Oct 16, 2023 at 10:05 PM Phil Dennis-Jordan wrote: > > I think fd and the HVF type should be placed in an anonymous union. > > Taking a look at the code and thinking through the implications, I'm > not actually sure what the intention of the union is Nevermind, I got confused that

[ANNOUNCE] QEMU 8.1.2 Stable released

2023-10-16 Thread Michael Tokarev
Hi everyone, The QEMU v8.1.2 stable release is now available. You can grab the tarball from our download page here: https://www.qemu.org/download/#source v8.1.2 is now tagged in the official qemu.git repository, and the stable-8.1 branch has been updated accordingly:

Re: [PATCH] MAINTAINERS: Add the nios2 interrupt controller to the nios2 section

2023-10-16 Thread Michael Tokarev
13.10.2023 09:54, Thomas Huth wrote: These files obviously belong to the nios2 target, so they should be listed in the nios2 section in the MAINTAINERS file. Queued to trivial-patches, thanks! /mjt

Re: [PATCH v2 0/2] hw/ppc/ppc440_uc: Maintain and remove dead code

2023-10-16 Thread Michael Tokarev
11.10.2023 17:07, Philippe Mathieu-Daudé wrote: Series fully reviewed. Applied to my trivial-patches tree. Thanks, /mjt

Re: [PATCH v2 1/2] ppc/pnv: Add an I2C controller model

2023-10-16 Thread Miles Glenn
On Fri, 2023-10-13 at 10:58 +0200, Philippe Mathieu-Daudé wrote: > Hi Glenn, Cédric, > > On 12/10/23 22:08, Glenn Miles wrote: > > From: Cédric Le Goater > > > > The more recent IBM power processors have an embedded I2C > > controller that is accessible by software via the XSCOM > > address

Re: [PULL 00/38] Migration 20231016 patches

2023-10-16 Thread Fabiano Rosas
373ad22c794a013da69663c03f1297a5c56: >> >> >> >> Merge tag 'pull-riscv-to-apply-20231012-1' of >> >> https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 >> >> -0400) >> >> >> >> are available in the Git repos

Re: [PATCH 0/3] hvf x86 correctness and efficiency improvements

2023-10-16 Thread Phil Dennis-Jordan
On Mon, 16 Oct 2023 at 18:49, Paolo Bonzini wrote: > > switching to hv_vcpu_run_until() WITHOUT hv_vcpu_interrupt() > > causes some very obvious problems where the vCPU simply > > doesn't exit at all for long periods.) > > Yes, that makes sense. It looks like hv_vcpu_run_until() has an >

[PULL 0/1] Block patches

2023-10-16 Thread Stefan Hajnoczi
The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56: Merge tag 'pull-riscv-to-apply-20231012-1' of https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git

[PULL 1/1] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-16 Thread Stefan Hajnoczi
From: hujian During the stop of dataplane for virtio-blk, virtio_bus_cleanup_host_notifier() is be called to clean up notifier at the end, if polled ioeventfd, virtio_blk_handle_output() is used to handle io request. But due to s->dataplane_disabled is false, it will be returned directly,

Re: [PATCH] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-16 Thread Stefan Hajnoczi
On Wed, Oct 11, 2023 at 02:14:26PM +0800, lv.mengz...@zte.com.cn wrote: > From: hujian > > During the stop of dataplane for virtio-blk, > virtio_bus_cleanup_host_notifier() is be > called to clean up notifier at the end, if polled ioeventfd, > virtio_blk_handle_output() > is used to handle io

Re: [RFC PATCH v3 37/78] target/hexagon: add fallthrough pseudo-keyword

2023-10-16 Thread Anton Johansson via
On 13/10/23, Emmanouil Pitsidianakis wrote: > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanouil Pitsidianakis > --- > target/hexagon/idef-parser/parser-helpers.c | 5 +++-- > 1

Re: [PULL 0/7] loongarch-to-apply queue

2023-10-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/25] Python patches

2023-10-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/26] Block layer patches

2023-10-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [GIT PULL 00/18] Host Memory Backends and Memory devices queue 2023-10-12

2023-10-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2 0/2] hw/ufs: fixes

2023-10-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/5] -Wshadow=local patches for 2023-10-12

2023-10-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/7] Misc patches

2023-10-16 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/38] Migration 20231016 patches

2023-10-16 Thread Stefan Hajnoczi
t; > >> Merge tag 'pull-riscv-to-apply-20231012-1' of > >> https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400) > >> > >> are available in the Git repository at: > >> > >> https://gitlab.co

Re: [PATCH 1/7] hw/ppc/spapr: Restrict PPCTimebase structure declaration to sPAPR

2023-10-16 Thread Mark Cave-Ayland
On 16/10/2023 05:49, Philippe Mathieu-Daudé wrote: Hi Mark, On 13/10/23 20:32, Mark Cave-Ayland wrote: On 13/10/2023 13:56, Philippe Mathieu-Daudé wrote: The PPCTimebase structure is only used by the sPAPR machine. Move its declaration to "hw/ppc/spapr.h". Move vmstate_ppc_timebase and the

Re: [PATCH] target/sparc: Clear may_lookup for npc == DYNAMIC_PC

2023-10-16 Thread Mark Cave-Ayland
On 16/10/2023 00:24, Richard Henderson wrote: With pairs of jmp+rett, pc == DYNAMIC_PC_LOOKUP and npc == DYNAMIC_PC. Make sure that we exit for interrupts. Signed-off-by: Richard Henderson --- Mark, I wonder if this will cure some of your lost interrupt issues. Spotted while looking at

Re: [RFC PATCH v3 03/78] fpu/softfloat: add fallthrough pseudo-keyword

2023-10-16 Thread Alex Bennée
Emmanouil Pitsidianakis writes: > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanouil Pitsidianakis > Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH v26 10/21] machine: adding s390 topology to query-cpu-fast

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel S390x provides two more topology attributes, entitlement and dedication. Let's add these CPU attributes to the QAPI command query-cpu-fast. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth

[PATCH v26 19/21] tests/avocado: s390x cpu topology test socket full

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel This test verifies that QMP set-cpu-topology does not accept to overload a socket. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 26 ++ 1 file changed, 26 insertions(+) diff --git

[PATCH v26 20/21] tests/avocado: s390x cpu topology dedicated errors

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Let's test that QEMU refuses to setup a dedicated CPU with low or medium entitlement. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth --- tests/avocado/s390_topology.py | 48 ++ 1 file changed, 48 insertions(+) diff --git

[PATCH v26 04/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel On interception of STSI(15.1.x) the System Information Block (SYSIB) is built from the list of pre-ordered topology entries. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina Schoetterl-Glausch Reviewed-by: Thomas Huth Acked-by: Markus

[PATCH v26 08/21] target/s390x/cpu topology: activate CPU topology

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and the topology facility in the host CPU model for the guest in the case the topology is available in QEMU and in KVM. The feature is disabled by default and fenced

[PATCH v26 15/21] tests/avocado: s390x cpu topology core

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel Introduction of the s390x cpu topology core functions and basic tests. We test the correlation between the command line and the QMP results in query-cpus-fast for various CPU topology. Signed-off-by: Pierre Morel Reviewed-by: Nina Schoetterl-Glausch Co-developed-by: Nina

[PATCH v26 12/21] qapi/s390x/cpu topology: CPU_POLARIZATION_CHANGE QAPI event

2023-10-16 Thread Nina Schoetterl-Glausch
From: Pierre Morel When the guest asks to change the polarization this change is forwarded to the upper layer using QAPI. The upper layer is supposed to take according decisions concerning CPU provisioning. Signed-off-by: Pierre Morel Reviewed-by: Thomas Huth Reviewed-by: Nina

  1   2   3   4   5   >