From: Fabiano Rosas
Add a version of qtest_init() that takes an environment variable
containing the path of the QEMU binary. This allows tests to use more
than one QEMU binary.
If no variable is provided or the environment variable does not exist,
that is not an error. Fallback to using QTEST_QE
From: Steve Sistare
Modify migrate_add_blocker and migrate_del_blocker to take an Error **
reason. This allows migration to own the Error object, so that if
an error occurs in migrate_add_blocker, migration code can free the Error
and clear the client handle, simplifying client code. It also si
From: Fabiano Rosas
We don't need to check p->quit in the multifd_send_thread() because it
is shadowed by the 'exiting' flag. Ever since that flag was added
p->quit became obsolete as a way to stop the thread.
Since p->quit is set at multifd_send_terminate_threads() under the
p->mutex lock, the
The following changes since commit 0d239e513e0117e66fa739fb71a43b9383a108ff:
Merge tag 'pull-lu-20231018' of https://gitlab.com/rth7680/qemu into staging
(2023-10-19 10:20:57 -0700)
are available in the Git repository at:
https://gitlab.com/juan.quintela/qemu.git tags/migration-20231020-pul
From: Thomas Huth
The analyze-migration.py script fails on s390x hosts:
Traceback (most recent call last):
File "scripts/analyze-migration.py", line 662, in
dump.read(dump_memory = args.memory)
File "scripts/analyze-migration.py", line 596, in read
classdesc = self.section_clas
The or1k-sim machine is the only one using the ompic, so let's add
this file to the corresponding sections in the MAINTAINERS file.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 62a8bef20e..14d8e4a85f 100644
--- a/M
We already cover util/qemu-timer.c in MAINTAINERS - change this entry
to util/qemu-timer*.c so that it covers util/qemu-timer-common.c, too.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 4cc71d1675..
The code from hw/input/ads7846.c is only used by hw/arm/spitz.c,
so add this file to the same section where hw/arm/spitz.c is
listed.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 14e8f7702d..34f9036df8 100644
--- a
This header include/hw/timer/stellaris-gptm.h obviously belongs to the
Stellaris machines, so let's add it to the corresponding section.
And hw/display/ssd0303.c and hw/display/ssd0323.c are only used
by hw/arm/stellaris.c, so add them to the corresponding section
in the MAINTAINERS file, too.
Si
This graphics adapter is only used by the Versatile Express machine,
so add it to the corresonding section in MAINTAINERS.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 34f9036df8..4a7339130e 100644
--- a/MAINTAINER
Some currently unvalued files can be associated with certain arm machines.
Let's list them in the corresponding sections in the MAINTAINERS file
so that the get_maintainers.pl script can suggest a maintainer for these
files.
Thomas Huth (4):
MAINTAINERS: Add include/hw/input/pl050.h to the Prime
The corresponding pl050.c file is already listed here, so we should
mention the header here, too.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 00642de2d7..14e8f7702d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6
Philippe Mathieu-Daudé writes:
> Address the comment added in commit 4629ed1e98
> ("qerror: Finally unused, clean up"), from 2015:
>
> /*
>* These macros will go away, please don't use
>* in new code, and do not add new ones!
>*/
>
> Mechanical transformation using sed, manually
> r
Philippe Mathieu-Daudé writes:
> Address the comment added in commit 4629ed1e98
> ("qerror: Finally unused, clean up"), from 2015:
>
> /*
>* These macros will go away, please don't use
>* in new code, and do not add new ones!
>*/
>
> Mechanical transformation using sed, manually
> r
Philippe Mathieu-Daudé writes:
> Address the comment added in commit 4629ed1e98
> ("qerror: Finally unused, clean up"), from 2015:
>
> /*
>* These macros will go away, please don't use
>* in new code, and do not add new ones!
>*/
>
> Mechanical transformation using sed, manually
> r
Hi Cédric,
>-Original Message-
>From: Cédric Le Goater
>Sent: Thursday, October 19, 2023 8:18 PM
>Subject: Re: [PATCH v2 02/27] vfio: Introduce base object for VFIOContainer and
>targetted interface
>
>On 10/19/23 04:29, Duan, Zhenzhong wrote:
>>> -Original Message-
>>> From: Cédr
On Fri, Oct 13, 2023 at 04:01:00PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Fri, 13 Oct 2023 16:01:00 +0200
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v2 01/16] target: Unify QOM style
> X-Mailer: git-send-email 2.41.0
>
> Enforce the style described by commit 067109a11c ("docs/devel:
>
On Fri, Oct 13, 2023 at 04:01:12PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Fri, 13 Oct 2023 16:01:12 +0200
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v2 13/16] target/i386: Declare CPU QOM types using
> DEFINE_TYPES() macro
> X-Mailer: git-send-email 2.41.0
>
> When multiple QOM types
Hi Philippe,
On Fri, Oct 13, 2023 at 04:00:59PM +0200, Philippe Mathieu-Daudé wrote:
> Date: Fri, 13 Oct 2023 16:00:59 +0200
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v2 00/16] target: Make 'cpu-qom.h' really target agnostic
> X-Mailer: git-send-email 2.41.0
>
> Since v1:
> - Added R-b ta
From: Pierre Morel
During a subsystem reset the Topology-Change-Report is cleared
by the machine.
Let's ask KVM to clear the Modified Topology Change Report (MTCR)
bit of the SCA in the case of a subsystem reset.
Signed-off-by: Pierre Morel
Reviewed-by: Thomas Huth
Reviewed-by: Nina Schoetterl
The following changes since commit 0d239e513e0117e66fa739fb71a43b9383a108ff:
Merge tag 'pull-lu-20231018' of https://gitlab.com/rth7680/qemu into staging
(2023-10-19 10:20:57 -0700)
are available in the Git repository at:
https://gitlab.com/thuth/qemu.git tags/pull-request-2023-10-20
for y
From: Pierre Morel
The topology information are attributes of the CPU and are
specified during the CPU device creation.
On hot plug we:
- calculate the default values for the topology for drawers,
books and sockets in the case they are not specified.
- verify the CPU attributes
- check that we
On 19/10/2023 23.15, Cédric Le Goater wrote:
On 10/19/23 22:49, Greg Kurz wrote:
Hi Juan,
On Thu, 19 Oct 2023 21:08:25 +0200
Juan Quintela wrote:
Current code does:
- register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
dependinfg on cpu number
- for newer machines, it regis
Fabiano Rosas writes:
> Signed-off-by: Fabiano Rosas
> ---
> qapi/migration.json | 20 ++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/migration.json b/qapi/migration.json
> index c352c7ac52..602cb706e3 100644
> --- a/qapi/migration.json
> +++ b/qap
Philippe Mathieu-Daudé writes:
> On 19/10/23 19:54, Markus Armbruster wrote:
>> Bernhard Beschow writes:
>>
>>> Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé"
>>> :
pcspk_init() is a legacy init function, inline and remove it.
Since the device is realized usin
On Thu, 2023-10-19 at 15:40 -0500, Glenn Miles wrote:
> Allow external devices to drive pca9552 input pins by adding
> input GPIO's to the model. This allows a device to connect
> its output GPIO's to the pca9552 input GPIO's.
>
> In order for an external device to set the state of a pca9552
> pi
On Tue, Aug 29, 2023 at 5:06 PM Cédric Le Goater wrote:
>
> From: Cédric Le Goater
>
> The Intel 82576EB GbE Controller say that the Physical and Virtual
> Functions support Function Level Reset. Add the capability to each
> device model.
>
Do we need to do migration compatibility for this?
Tha
On 10/19/23 17:34, Salil Mehta wrote:
Hi Shaoqin,
From: Shaoqin Huang
Sent: Thursday, October 19, 2023 10:05 AM
To: Salil Mehta ; qemu-devel@nongnu.org; qemu-
a...@nongnu.org
Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron
; lpieral...@kernel.org;
peter.mayd...@linaro.org; r
On Thu, Oct 19, 2023 at 09:16:00AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Thu, 19 Oct 2023 09:16:00 +0200
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v2 02/12] hw/i386/intel_iommu: Do not use SysBus API to map
> local MMIO region
> X-Mailer: git-send-email 2.41.0
>
> There is no point
On Thu, Oct 19, 2023 at 09:15:59AM +0200, Philippe Mathieu-Daudé wrote:
> Date: Thu, 19 Oct 2023 09:15:59 +0200
> From: Philippe Mathieu-Daudé
> Subject: [PATCH v2 01/12] hw/i386/amd_iommu: Do not use SysBus API to map
> local MMIO region
> X-Mailer: git-send-email 2.41.0
>
> There is no point i
On 19-10-23, 10:56, Alex Bennée wrote:
> From: Manos Pitsidianakis
>
> Tested with rust-vmm vhost-user-sound daemon:
>
> RUST_LOG=trace cargo run --bin vhost-user-sound -- --socket /tmp/snd.sock
> --backend null
>
> Invocation:
>
> qemu-system-x86_64 \
> -qmp unix:./qmp-s
On Thu, 2023-10-19 at 15:40 -0500, Glenn Miles wrote:
> > The pca9552 INPUT0 and INPUT1 registers are supposed to
> > hold the logical values of the LED pins. A logical 0
> > should be seen in the INPUT0/1 registers for a pin when
> > its corresponding LSn bits are set to 0, which is also
> > the
This patch removes the code that ufs-lu was duplicating from
scsi-hd and allows them to share code.
It makes ufs-lu have a virtual scsi-bus and scsi-hd internally.
This allows scsi related commands to be passed thorugh to the scsi-hd.
The query request and nop command work the same as the existing
在 2023/10/20 02:07, Michael S. Tsirkin 写道:
> On Thu, Oct 19, 2023 at 09:32:28AM -0700, Stefan Hajnoczi wrote:
>> On Wed, 18 Oct 2023 at 08:56, Michael S. Tsirkin wrote:
>>>
>>> From: Hawkins Jiawei
>>>
>>> This patch introduces vhost_vdpa_net_load_rss() to restore
>>> the hash calculation state a
On Thu, 19 Oct 2023, Mark Cave-Ayland wrote:
This series adds a simple implementation of legacy/native mode switching for PCI
IDE controllers and updates the via-ide device to use it.
The approach I take here is to add a new pci_ide_update_mode() function which
handles
management of the PCI BAR
On Thu, 19 Oct 2023, Mark Cave-Ayland wrote:
Allow the VIA IDE controller to switch between both legacy and native modes by
calling pci_ide_update_mode() to reconfigure the device whenever PCI_CLASS_PROG
is updated.
This patch also moves the setting of PCI_CLASS_PROG from via_ide_realize() to
vi
On 10/19/23 19:19, Stefan Hajnoczi wrote:
On Wed, 18 Oct 2023 at 13:42, wrote:
From: Helge Deller
The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56:
Merge tag 'pull-riscv-to-apply-20231012-1' of
https://github.com/alistair23/qemu into staging (2023-10-12 10:24:
From: Helge Deller
Allow the Astro source to be built.
Signed-off-by: Helge Deller
---
hw/hppa/Kconfig | 1 +
hw/pci-host/Kconfig | 4
hw/pci-host/meson.build | 1 +
3 files changed, 6 insertions(+)
diff --git a/hw/hppa/Kconfig b/hw/hppa/Kconfig
index 5dd8b5b21e..ff8528aaa8 1
From: Helge Deller
Add code to create an emulated C3700 machine.
It includes the following components:
- HP Powerbar SP2 Diva BMC card (serial port only)
- PCI 4x serial card (for serial ports #1-#4)
- USB OHCI controller with USB keyboard and USB mouse
Signed-off-by: Helge Deller
---
hw/hppa/
From: Helge Deller
This is a preparation patch to allow the creation of additional
hppa machine.
It splits out the creation of the machine into a
- machine_HP_common_init_cpus(), and a
- machine_HP_common_init_tail()
function.
This will allow to reuse the basic functions which are common to
all
From: Helge Deller
Signed-off-by: Helge Deller
---
hw/net/tulip.c | 2 +-
include/hw/pci/pci_ids.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/net/tulip.c b/hw/net/tulip.c
index 915e5fb595..11d866e431 100644
--- a/hw/net/tulip.c
+++ b/hw/net/tulip.c
@@ -10
From: Helge Deller
For SeaBIOS-hppa, the RTC and DebugOutputPort were in the I/O area of
the LASI chip of the emulated B160L machine.
Since we will add other machines without a LASI chip, move the emulated
devices into the I/O area of CPU#0 instead.
Signed-off-by: Helge Deller
---
hw/hppa/hppa
From: Helge Deller
The 64-bit PA-RISC machines use a Astro system bus adapter (SBA)
with Elroy PCI host chips.
Later generation Astro chips were named Pluto, Ike and REO.
Signed-off-by: Helge Deller
---
hw/pci-host/astro.c | 885
hw/pci-host/trace-e
From: Helge Deller
Add the new HP C3700 machine, the new Astro PCI host and
add the missing entry for the seabios-hppa directory.
Signed-off-by: Helge Deller
---
MAINTAINERS | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index ceea4c2bf2..68d0
From: Helge Deller
Provide necessary info to SeaBIOS-hppa.
Signed-off-by: Helge Deller
---
hw/hppa/machine.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
index c6d8deffcf..de925259ea 100644
--- a/hw/hppa/machi
From: Helge Deller
The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56:
Merge tag 'pull-riscv-to-apply-20231012-1' of
https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400)
are available in the Git repository at:
https://github.com/hdeller/qemu
From: Helge Deller
Those PS/2 ports are created with the LASI controller when
a 32-bit PA-RISC machine is created.
Mark them not user-createable to avoid showing them in
the qemu device list.
Signed-off-by: Helge Deller
Cc: qemu-sta...@nongnu.org
---
hw/input/lasips2.c | 10 ++
1 file
From: Helge Deller
The new SeaBIOS-hppa version 10 includes initial support
for PA2.0 CPUs.
Additionally update copyright and drop commented-out code.
Signed-off-by: Helge Deller
---
hw/hppa/machine.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/hppa/machin
On 19/10/23 20:29, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/i386/tcg/translate.c | 28 +++-
1 file changed, 3 insertions(+), 25 deletions(-)
diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c
index 0c81e066de..d420ed8f0a
On 19/10/23 20:29, Richard Henderson wrote:
Signed-off-by: Richard Henderson
---
target/rx/translate.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
On 19/10/23 20:29, Richard Henderson wrote:
We still need to check OS_{BYTE,WORD,LONG},
because m68k includes floating point in OS_*.
Signed-off-by: Richard Henderson
---
target/m68k/translate.c | 23 +++
1 file changed, 3 insertions(+), 20 deletions(-)
Reviewed-by: Phi
On 19/10/23 20:29, Richard Henderson wrote:
The two concrete type functions already existed, merely needing
a bit of hardening to invalid inputs.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op-common.h | 2 ++
include/tcg/tcg-op.h| 2 ++
tcg/tcg-op-ldst.c | 14 +
Hi Peter,
On 17/10/23 14:23, Peter Maydell wrote:
Now that we have converted to qdev, we can use the newer
qemu_input_handler_register() API rather than the legacy
qemu_add_kbd_event_handler().
Since we only have one user, take the opportunity to convert
from scancodes to QCodes, rather than us
On 19/10/23 19:54, Markus Armbruster wrote:
Bernhard Beschow writes:
Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé"
:
pcspk_init() is a legacy init function, inline and remove it.
Since the device is realized using &error_fatal, use the same
error for setting the "pit" li
On 29/9/23 16:03, Luc Michel wrote:
Map my old and now invalid work email addresses to my personal one.
Signed-off-by: Luc Michel
---
Please ignore v1 sent with wrong e-mail address.
---
.mailmap | 3 +++
1 file changed, 3 insertions(+)
Thanks, queued to hw-misc.
On 17/10/23 15:12, Philippe Mathieu-Daudé wrote:
Access to QemuInputHandlerState::handler are read-only.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/virtio/virtio-input.h | 2 +-
include/ui/input.h | 2 +-
chardev/msmouse.c| 2 +-
chardev/wctablet.c
On 17/10/23 16:01, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (7):
hw/virtio/virtio-pmem: Replace impossible check by assertion
hw/block/vhost-user-blk: Use DEVICE() / VIRTIO_DEVICE() macros
hw/display/virtio-gpu: Use VIRTIO_DEVICE() macro
hw/scsi/virtio-scsi: Use VIRTIO_SC
On 17/10/23 17:33, Thomas Huth wrote:
The corresponding .c file is already listed here, so we should
mention the header here, too.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
Thanks, queued to hw-misc.
On Thu, 19 Oct 2023 21:08:25 +0200
Juan Quintela wrote:
> Current code does:
> - register pre_2_10_vmstate_dummy_icp with "icp/server" and instance
> dependinfg on cpu number
> - for newer machines, it register vmstate_icp with "icp/server" name
> and instance 0
> - now it unregisters "icp/se
On 17/10/23 17:19, Thomas Huth wrote:
hw/input/lasips2.c and the corresponding header include/hw/input/lasips2.h
are only used by the HPPA machine, so add them to the corresponding section
in the MAINTAINERS file.
Signed-off-by: Thomas Huth
---
MAINTAINERS | 2 ++
1 file changed, 2 insertion
On 19/10/23 09:15, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (12):
hw/i386/amd_iommu: Do not use SysBus API to map local MMIO region
hw/i386/intel_iommu: Do not use SysBus API to map local MMIO region
hw/misc/allwinner-dramc: Move sysbus_mmio_map call from init ->
realiz
On 19/10/23 15:16, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (7):
hw/ppc/spapr_vio: Realize SPAPR_VIO_BRIDGE device before accessing it
hw/ppc/pnv_xscom: Rename pnv_xscom_realize(Error **) ->
pnv_xscom_init()
hw/ppc/pnv_xscom: Move sysbus_mmio_map() call within pnv_xscom
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Transformation done using the following coccinelle script:
@@
expression sbdev;
expression index;
expression addr;
expression subr
We already provide "hw/misc/mips_itu.h" to declare prototype
related to MIPSITUState. Move itc_reconfigure() declaration
there.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20231009171443.12145-3-phi...@linaro.org>
---
include/hw/misc/mips_itu.h | 2
When prototyping a heterogenous machine including the ITU,
we get:
include/hw/misc/mips_itu.h:76:5: error: unknown type name 'MIPSCPU'
MIPSCPU *cpu0;
^
MIPSCPU is declared in the target specific "cpu.h" header,
but we don't want to include it, because "cpu.h" is target
specific and
qbus_new() should not be called on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Cédric Le Goater
Reviewed-by: Thomas Huth
Message-Id: <20231019131647.19690-2-phi...@linaro.org>
---
hw/ppc/spapr_vio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a
Access QOM parent with the proper QOM VIRTIO_SCSI_COMMON() macro.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Mark Cave-Ayland
Message-Id: <20231017140150.44995-5-phi...@linaro.org>
---
hw/scsi/virtio-scsi.c | 2 +-
1 fil
qbus_new() should not be called on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20231019071611.98885-10-phi...@linaro.org>
---
hw/s390x/css-bridge.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/hw/s390x/css-bridge.c
Juan Quintela writes:
> Now that we know it only handles zero, we can remove the ch parameter.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Fabiano Rosas
Declare link statically using DEFINE_PROP_LINK().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20231017140150.44995-7-phi...@linaro.org>
---
hw/net/cadence_gem.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/net/cadence_gem.c b
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Message-Id: <20231012041237.22281-4-phi...@linaro.org>
---
hw/pci-host/sh_pci.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/sh_pci.c b/hw/pci-host/sh_pci.c
index 580e273d96..4edebced5e 1006
sysbus_mmio_map() should not be called on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20231018141151.87466-8-phi...@linaro.org>
---
hw/arm/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
From: Thomas Huth
The corresponding .c file is already listed here, so we should
mention the header here, too.
Signed-off-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Acked-by: Song Gao
Message-ID: <20231017153345.233807-1-th...@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé
---
M
The get_memory_region() handler is used when (un)plugging the
device, which can only occur *after* it is realized.
virtio_pmem_realize() ensure the instance can not be realized
without 'memdev'. Remove the superfluous check, replacing it
by an assertion.
Signed-off-by: Philippe Mathieu-Daudé
Rev
PCI functions are plugged on a PCI bus. They can only access
external memory regions via the bus.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20231011185954.10337-5-phi...@linaro.org>
---
hw/sparc64/sun4u.c | 8
1 file changed, 4 insertions(+), 4 de
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Transformation done using the following coccinelle script:
@@
expression sbdev;
expression index;
expression addr;
expression subr
Fix:
hw/pci/pci.c:504:54: error: declaration shadows a variable in the global
scope [-Werror,-Wshadow]
MemoryRegion *address_space_io,
^
hw/pci/pci.c:533:38: error: declaration shadows a variable i
Juan Quintela writes:
> We don't allow non zero compressed pages since:
>
> commit 3edcd7e6ebae3ef0ac178eed5f4225803159562d
> Author: Peter Lieven
> Date: Tue Mar 26 10:58:35 2013 +0100
>
> migration: search for zero instead of dup pages
>
> RDMA case is a bit more complicated, but they do
Access to QemuInputHandlerState::handler are read-only.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Reviewed-by: Mark Cave-Ayland
Message-Id: <20231017131251.43708-1-phi...@linaro.org>
---
include/hw/virtio/virtio-input.h | 2 +-
include/ui/input.h | 2 +-
Access QOM parent with the proper QOM [VIRTIO_]DEVICE() macros.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Mark Cave-Ayland
Message-Id: <20231017140150.44995-3-phi...@linaro.org>
---
hw/block/vhost-user-blk.c | 4 ++--
1 file changed, 2 insertions(+), 2
Declare link statically using DEFINE_PROP_LINK().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Mark Cave-Ayland
Message-Id: <20231017140150.44995-6-phi...@linaro.org>
---
hw/dma/xilinx_axidma.c | 6 ++
hw/dma/xlnx-zdma.c | 7 ++-
hw/dma/xlnx_csu_dma.c | 13 -
3
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Transformation done using the following coccinelle script:
@@
expression sbdev;
expression index;
expression addr;
expression subr
Access QOM parent with the proper QOM VIRTIO_DEVICE() macro.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Mark Cave-Ayland
Message-Id: <20231017140150.44995-4-phi...@linaro.org>
---
hw/display/virtio-gpu.c | 2 +-
1 file c
From: Akihiko Odaki
get_relocated_path() did not have error handling for PathCchSkipRoot()
because a path given to get_relocated_path() was expected to be a valid
path containing a drive letter or UNC server/share path elements on
Windows, but sometimes it turned out otherwise.
The paths passed
Since commit 93198b6cad ("i2c: Split smbus into parts") the SDRAM
types are enumerated as sdram_type in "hw/i2c/smbus_eeprom.h".
Using the enum removes this global shadow warning:
hw/mips/malta.c:209:12: error: declaration shadows a variable in the global
scope [-Werror,-Wshadow]
enum {
In order to make the next commit trivial, move the sysbus_init_mmio()
call in allwinner_r40_dramc_init() just before the corresponding
sysbus_mmio_map_overlap() call in allwinner_r40_dramc_realize().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-Id: <20231019071611.98885
When multiple QOM types are registered in the same file,
it is simpler to use the the DEFINE_TYPES() macro. In
particular because type array declared with such macro
are easier to review.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Yoshinori Sato
Message-Id: <20231012041237.22281-2-phi...
qbus_new() should not be called on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Michael S. Tsirkin
Message-Id: <20231019071611.98885-9-phi...@linaro.org>
---
hw/isa/isa-bus.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/hw/isa/isa-bus.
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Transformation done using the following coccinelle script:
@@
expression sbdev;
expression index;
expression addr;
expression subr
Fix:
hw/acpi/pcihp.c:499:36: error: declaration shadows a variable in the global
scope [-Werror,-Wshadow]
MemoryRegion *address_space_io,
^
include/exec/address-spaces.h:35:21: note: previous declaration is here
extern AddressSpace
BTW, this series depends on the patch "migration: simplify blockers".
- Steve
On 10/19/2023 4:47 PM, Steve Sistare wrote:
> Add a mode migration parameter that can be used to select alternate
> migration algorithms. The default mode is normal, representing the
> current migration algorithm, and
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Transformation done using the following coccinelle script:
@@
expression sbdev;
expression index;
expression addr;
expression subr
From: Luc Michel
Map my old and now invalid work email addresses to my personal one.
Signed-off-by: Luc Michel
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20230929140326.2056658-2-...@lmichel.fr>
Signed-off-by: Philippe Mathieu-Daudé
---
.mailmap | 3 +++
1 file changed, 3 insertions(+)
In order to make the next commit trivial, move sysbus_init_mmio()
calls just before the corresponding sysbus_mmio_map() calls.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Thomas Huth
Reviewed-by: LIU Zhiwei
Reviewed-by: Cédric Le Goater
Message-Id: <20231
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Transformation done using the following coccinelle script:
@@
expression sbdev;
expression index;
expression addr;
expression subr
pnv_xscom_realize() is not used to *realize* QDev object, rename
it as pnv_xscom_init(). The Error** argument is unused: remove it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Thomas Huth
Reviewed-by: LIU Zhiwei
Reviewed-by: Cédric Le Goater
Message-Id: <
There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.
Just map it without using the SysBus API.
Transformation done using the following coccinelle script:
@@
expression sbdev;
expression index;
expression addr;
expression subr
Fix:
hw/s390x/sclpquiesce.c:90:22: error: declaration shadows a variable in the
global scope [-Werror,-Wshadow]
QuiesceNotifier *qn = container_of(n, QuiesceNotifier, notifier);
^
hw/s390x/sclpquiesce.c:86:3: note: previous declaration is here
} qn;
^
Signe
"hw/mips/cpudevs.h" contains declarations which are specific
to the MIPS architecture; it doesn't make sense for these to
be called from a non-MIPS architecture. Move the declarations
to "target/mips/cpu.h".
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <202310
sysbus_mmio_map() should not be called on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Michael S. Tsirkin
Message-Id: <20231018141151.87466-7-phi...@linaro.org>
---
hw/arm/virt.c | 3 +--
hw/i386/microvm.c | 2 +-
hw/loongarch/virt.c |
1 - 100 of 695 matches
Mail list logo
