[PULL v2 34/78] virtio: call ->vhost_reset_device() during reset

2023-10-19 Thread Michael S. Tsirkin
From: Stefan Hajnoczi vhost-user-scsi has a VirtioDeviceClass->reset() function that calls ->vhost_reset_device(). The other vhost devices don't notify the vhost device upon reset. Stateful vhost devices may need to handle device reset in order to free resources or prevent stale device state

[PULL v2 41/78] hw/isa/piix3: Resolve redundant PIIX_NUM_PIC_IRQS

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow PIIX_NUM_PIC_IRQS is assumed to be the same as ISA_NUM_IRQS, otherwise inconsistencies can occur. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Message-Id: <20231007123843.127151-5-shen...@gmail.com> Signed-off-by: Michael S. Tsirkin ---

[PULL v2 37/78] hw/display: fix memleak from virtio_add_resource

2023-10-19 Thread Michael S. Tsirkin
From: Matheus Tavares Bernardino When the given uuid is already present in the hash table, virtio_add_resource() does not add the passed VirtioSharedObject. In this case, free it in the callers to avoid leaking memory. This fixed the following `make check` error, when built with

[PULL v2 74/78] hw/cxl: Add QTG _DSM support for ACPI0017 device

2023-10-19 Thread Michael S. Tsirkin
From: Dave Jiang Add a simple _DSM call support for the ACPI0017 device to return fake QTG ID values of 0 and 1 in all cases. This for _DSM plumbing testing from the OS. Following edited for readability Device (CXLM) { Name (_HID, "ACPI0017") // _HID: Hardware ID ... Method (_DSM, 4,

[PULL v2 61/78] hw/isa/piix: Reuse PIIX3 base class' realize method in PIIX4

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Resolves duplicate code. Also makes PIIX4 respect the PIIX3 properties which get added, too. This allows for using PIIX4 in the PC machine. Signed-off-by: Bernhard Beschow Message-Id: <20231007123843.127151-25-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin

[PULL v2 59/78] hw/isa/piix: Harmonize names of reset control memory regions

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow There is no need for having different names here. Having the same name further allows code to be shared between PIIX3 and PIIX4. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-Id:

[PULL v2 52/78] hw/isa/piix4: Remove unused inbound ISA interrupt lines

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow The Malta board, which is the only user of PIIX4, doesn't connect to the exported interrupt lines. PIIX3 doesn't expose such interrupt lines either, so remove them for PIIX4 for simplicity and consistency. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin

[PULL v2 49/78] hw/isa/piix3: Create USB controller in host device

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow The USB controller is an integral part of PIIX3 (function 2). So create it as part of the south bridge. Note that the USB function is optional in QEMU. This is why it gets object_initialize_child()'ed in realize rather than in instance_init. Signed-off-by: Bernhard

[PULL v2 54/78] hw/isa/piix4: Rename reset control operations to match PIIX3

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Both implementations are the same and will be shared upon merging. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Message-Id: <20231007123843.127151-18-shen...@gmail.com> Signed-off-by: Michael S. Tsirkin ---

[PULL v2 32/78] vhost-user: do not send RESET_OWNER on device reset

2023-10-19 Thread Michael S. Tsirkin
From: Stefan Hajnoczi The VHOST_USER_RESET_OWNER message is deprecated in the spec: This is no longer used. Used to be sent to request disabling all rings, but some back-ends interpreted it to also discard connection state (this interpretation would lead to bugs). It is recommended

[PULL v2 25/78] vhost-user: tighten "reply_supported" scope in "set_vring_addr"

2023-10-19 Thread Michael S. Tsirkin
From: Laszlo Ersek In the vhost_user_set_vring_addr() function, we calculate "reply_supported" unconditionally, even though we'll only need it if "wait_for_reply" is also true. Restrict the scope of "reply_supported" to the minimum. This is purely refactoring -- no observable change. Cc:

[PULL v2 36/78] timer/i8254: Fix one shot PIT mode

2023-10-19 Thread Michael S. Tsirkin
From: Damien Zammit Currently, the one-shot (mode 1) PIT expires far too quickly, due to the output being set under the wrong logic. This change fixes the one-shot PIT mode to behave similarly to mode 0. TESTED: using the one-shot PIT mode to calibrate a local apic timer. Signed-off-by: Damien

[PATCH 5/7] target/rx: Use tcg_gen_ext_i32

2023-10-19 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/rx/translate.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/target/rx/translate.c b/target/rx/translate.c index f8860830ae..c6ce717a95 100644 --- a/target/rx/translate.c +++ b/target/rx/translate.c @@ -492,13 +492,11

Re: [RFC PATCH v2 1/6] migration/multifd: Remove channels_ready semaphore

2023-10-19 Thread Juan Quintela
Peter Xu wrote: > On Thu, Oct 19, 2023 at 05:00:02PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > Fabiano, >> > >> > Sorry to look at this series late; I messed up my inbox after I reworked my >> > arrangement methodology of emails. ;) >> > >> > On Thu, Oct 19, 2023 at 11:06:06AM +0200,

[PULL v2 67/78] vhost-user-common: send get_inflight_fd once

2023-10-19 Thread Michael S. Tsirkin
From: Li Feng Currently the get_inflight_fd will be sent every time the device is started, and the backend will allocate shared memory to save the inflight state. If the backend finds that it receives the second get_inflight_fd, it will release the previous shared memory, which breaks inflight

[PULL v2 55/78] hw/isa/piix4: Reuse struct PIIXState from PIIX3

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow PIIX4 has its own, private PIIX4State structure. PIIX3 has almost the same structure, provided in a public header. So reuse it and add a cpu_intr attribute to it which is only used by PIIX4. Signed-off-by: Bernhard Beschow Message-Id:

[PULL v2 75/78] tests/acpi: Update DSDT.cxl with QTG DSM

2023-10-19 Thread Michael S. Tsirkin
From: Jonathan Cameron Description of change in previous patch. Signed-off-by: Jonathan Cameron Reviewed-by: Fan Ni Reviewed-by: Dave Jiang Message-Id: <20231012125623.21101-4-jonathan.came...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin ---

[PULL v2 64/78] hw/isa/piix: Resolve duplicate code regarding PCI interrupt wiring

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Now that both PIIX3 and PIIX4 use piix_set_irq() to trigger PCI IRQs the wiring in the respective realize methods can be shared, too. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Message-Id: <20231007123843.127151-28-shen...@gmail.com> Signed-off-by:

[PULL v2 66/78] hw/i386/pc_piix: Make PIIX4 south bridge usable in PC machine

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow QEMU's PIIX3 implementation actually models the real PIIX4, but with different PCI IDs. Usually, guests deal just fine with it. Still, in order to provide a more consistent illusion to guests, allow QEMU's PIIX4 implementation to be used in the PC machine. Signed-off-by:

[PULL v2 30/78] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

2023-10-19 Thread Michael S. Tsirkin
From: Laszlo Ersek (1) The virtio-1.2 specification writes: > 3 General Initialization And Device Operation > 3.1 Device Initialization > 3.1.1 Driver Requirements: Device Initialization > > [...] > > 7. Perform

[PULL v2 47/78] hw/i386/pc: Wire RTC ISA IRQs in south bridges

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Makes the south bridges a bit more self-contained and aligns PIIX3 more with PIIX4. The latter is needed for consolidating the PIIX south bridges. Signed-off-by: Bernhard Beschow Message-Id: <20231007123843.127151-11-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin

[PULL v2 28/78] vhost-user: hoist "write_sync", "get_features", "get_u64"

2023-10-19 Thread Michael S. Tsirkin
From: Laszlo Ersek In order to avoid a forward-declaration for "vhost_user_write_sync" in a subsequent patch, hoist "vhost_user_write_sync" -> "vhost_user_get_features" -> "vhost_user_get_u64" just above "vhost_set_vring". This is purely code movement -- no observable change. Cc: "Michael S.

[PULL v2 10/78] tests: bios-tables-test: Add test for smbios type4 count

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu This tests the commit d79a284a44bb7 ("hw/smbios: Fix smbios_smp_sockets calculation"). In smbios_get_tables() (hw/smbios/smbios.c), smbios type4 table is built for each socket, so the count of type4 tables should be equal to the number of sockets. Thus for the topology in this

[PULL v2 73/78] tests/acpi: Allow update of DSDT.cxl

2023-10-19 Thread Michael S. Tsirkin
From: Jonathan Cameron Addition of QTG in following patch requires an update to the test data. Signed-off-by: Jonathan Cameron Reviewed-by: Fan Ni Reviewed-by: Dave Jiang Message-Id: <20231012125623.21101-2-jonathan.came...@huawei.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael

[PULL v2 07/78] vdpa: Send cvq state load commands in parallel

2023-10-19 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch enables sending CVQ state load commands in parallel at device startup by following steps: * Refactor vhost_vdpa_net_load_cmd() to iterate through the control commands shadow buffers. This allows different CVQ state load commands to use their own unique buffers.

[PULL v2 29/78] vhost-user: allow "vhost_set_vring" to wait for a reply

2023-10-19 Thread Michael S. Tsirkin
From: Laszlo Ersek The "vhost_set_vring" function already centralizes the common parts of "vhost_user_set_vring_num", "vhost_user_set_vring_base" and "vhost_user_set_vring_enable". We'll want to allow some of those callers to wait for a reply. Therefore, rebase "vhost_set_vring" from just

[PULL v2 77/78] MAINTAINERS: Add include/hw/intc/i8259.h to the PC chip section

2023-10-19 Thread Michael S. Tsirkin
From: Thomas Huth i8259.c is already listed here, so the corresponding header should be mentioned in this section, too. Signed-off-by: Thomas Huth Message-Id: <20231017152625.229022-1-th...@redhat.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- MAINTAINERS | 1 +

[PULL v2 46/78] hw/isa/piix3: Wire PIC IRQs to ISA bus in host device

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Thie PIIX3 south bridge implements both the PIC and the ISA bus, so wiring the interrupts there makes the device model more self-contained. Furthermore, this allows the ISA interrupts to be wired to internal child devices in pci_piix3_realize() which will be performed in

[PULL v2 53/78] hw/isa/piix4: Rename "isa" attribute to "isa_irqs_in"

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Rename the "isa" attribute to align it with PIIX3 for consolidation. Signed-off-by: Bernhard Beschow Message-Id: <20231007123843.127151-17-shen...@gmail.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/isa/piix4.c | 10 +- 1 file

[PULL v2 68/78] vhost: move and rename the conn retry times

2023-10-19 Thread Michael S. Tsirkin
From: Li Feng Multiple devices need this macro, move it to a common header. Signed-off-by: Li Feng Reviewed-by: Raphael Norwitz Message-Id: <20231009044735.941655-3-fen...@smartx.com> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/vhost.h | 2 ++

[PULL v2 56/78] hw/isa/piix3: Merge hw/isa/piix4.c

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Now that the PIIX3 and PIIX4 device models are sufficiently prepared, their implementations can be merged into one file for further consolidation. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Message-Id: <20231007123843.127151-20-shen...@gmail.com>

[PULL v2 38/78] hw/i386/pc: Merge two if statements into one

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow By being the only entity assigning a non-NULL value to "rtc_irq", the first if statement determines whether the second if statement is executed. So merge the two statements into one. Signed-off-by: Bernhard Beschow Message-Id: <20231007123843.127151-2-shen...@gmail.com>

[PULL v2 71/78] vhost-user: fix lost reconnect

2023-10-19 Thread Michael S. Tsirkin
From: Li Feng When the vhost-user is reconnecting to the backend, and if the vhost-user fails at the get_features in vhost_dev_init(), then the reconnect will fail and it will not be retriggered forever. The reason is: When the vhost-user fails at get_features, the vhost_dev_cleanup will be

[PULL v2 16/78] tests: bios-tables-test: Extend smbios core count2 test to cover general topology

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu The commit 196ea60a734c3 ("hw/smbios: Fix core count in type4") fixed the miscalculation of cores per socket. The original core count2 test (with the topology configured by "-smp 275") didn't recognize that topology-related but because it just created a special topology with only

[PULL v2 44/78] hw/isa/piix3: Rename "pic" attribute to "isa_irqs_in"

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow TYPE_PIIX3_DEVICE doesn't instantiate a PIC since it relies on the board to do so. The "pic" attribute, however, suggests that there is one. Rename the attribute to reflect that it represents ISA interrupt lines. Use the same naming convention as in the VIA south bridges

[PULL v2 18/78] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the thread count field of smbios type4 table. Signed-off-by: Zhao Liu Message-Id: <20230928125943.1816922-12-zhao1@linux.intel.com> Reviewed-by:

[PULL v2 76/78] vhost-user: Fix protocol feature bit conflict

2023-10-19 Thread Michael S. Tsirkin
From: Hanna Czenczek The VHOST_USER_PROTOCOL_F_XEN_MMAP feature bit was defined in f21e95ee97d, which has been part of qemu's 8.1.0 release. However, it seems it was never added to qemu's code, but it is well possible that it is already used by different front-ends outside of qemu (i.e., Xen).

[PULL v2 60/78] hw/isa/piix: Share PIIX3's base class with PIIX4

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow Having a common base class will allow for futher code sharing between PIIX3 and PIIX4. Moreover, it makes PIIX4 implement the acpi-dev-aml-interface. Signed-off-by: Bernhard Beschow Reviewed-by: Michael S. Tsirkin Message-Id: <20231007123843.127151-24-shen...@gmail.com>

[PULL v2 50/78] hw/isa/piix3: Create power management controller in host device

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow The power management controller is an integral part of PIIX3 (function 3). So create it as part of the south bridge. Note that the ACPI function is optional in QEMU. This is why it gets object_initialize_child()'ed in realize rather than in instance_init. Signed-off-by:

[PULL v2 57/78] hw/isa/piix: Allow for optional PIC creation in PIIX3

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow In the PC machine, the PIC is created in board code to allow it to be virtualized with various virtualization techniques. So explicitly disable its creation in the PC machine via a property which defaults to enabled. Once the PIIX implementations are consolidated this

[PULL v2 39/78] hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 south bridge

2023-10-19 Thread Michael S. Tsirkin
From: Bernhard Beschow The next patches will need to take advantage of it. Signed-off-by: Bernhard Beschow Reviewed-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Message-Id: <20231007123843.127151-3-shen...@gmail.com> Signed-off-by: Michael S. Tsirkin --- hw/i386/pc_piix.c | 3 ++- 1

[PULL v2 78/78] intel-iommu: Report interrupt remapping faults, fix return value

2023-10-19 Thread Michael S. Tsirkin
From: David Woodhouse A generic X86IOMMUClass->int_remap function should not return VT-d specific values; fix it to return 0 if the interrupt was successfully translated or -EINVAL if not. The VTD_FR_IR_xxx values are supposed to be used to actually raise faults through the fault reporting

[PULL v2 17/78] tests: bios-tables-test: Update ACPI table binaries for smbios core count2 test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Change the core count2 from 275 to 260. Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: APIC: /* * Intel ACPI Component Architecture * AML/ASL+ Disassembler version 20200925 (64-bit version) * Copyright (c) 2000 -

[PULL v2 33/78] vhost-backend: remove vhost_kernel_reset_device()

2023-10-19 Thread Michael S. Tsirkin
From: Stefan Hajnoczi vhost_kernel_reset_device() invokes RESET_OWNER, which disassociates the owner process from the device. The device is left non-operational since SET_OWNER is only called once during startup in vhost_dev_init(). vhost_kernel_reset_device() is never called so this latent bug

[PULL v2 09/78] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 count test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the type 4 count. Signed-off-by: Zhao Liu Message-Id: <20230928125943.1816922-3-zhao1@linux.intel.com> Reviewed-by: Michael S. Tsirkin

[PULL v2 21/78] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 thread count2 test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be added to test the thread count2 field of smbios type4 table. Signed-off-by: Zhao Liu Message-Id: <20230928125943.1816922-15-zhao1@linux.intel.com> Reviewed-by:

[PULL v2 13/78] tests: bios-tables-test: Add test for smbios type4 core count

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu This tests the commit 196ea60a734c3 ("hw/smbios: Fix core count in type4"). In smbios_build_type_4_table() (hw/smbios/smbios.c), if the number of cores in the socket is not more than 255, then smbios type4 table encodes cores per socket into the core count field. So for the

[PULL v2 20/78] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + *

[PULL v2 23/78] tests: bios-tables-test: Add ACPI table binaries for smbios type4 thread count2 test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + *

[PULL v2 11/78] tests: bios-tables-test: Add ACPI table binaries for smbios type4 count test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 5 and 6. Changes in the tables: FACP: +/* + * Intel ACPI Component Architecture + * AML/ASL+ Disassembler version 20200925 (64-bit version) + * Copyright (c) 2000 - 2020 Intel Corporation + * + *

[PULL v2 05/78] vdpa: Introduce cursors to vhost_vdpa_net_loadx()

2023-10-19 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch introduces two new arugments, `out_cursor` and `in_cursor`, to vhost_vdpa_net_loadx(). Addtionally, it includes a helper function vhost_vdpa_net_load_cursor_reset() for resetting these cursors. Furthermore, this patch refactors vhost_vdpa_net_load_cmd() so that

[PULL v2 15/78] tests: bios-tables-test: Prepare the ACPI table change for smbios type4 core count2 test

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Following the guidelines in tests/qtest/bios-tables-test.c, this is step 1 - 3. List the ACPI tables that will be changed about the type 4 core count2 test case. Signed-off-by: Zhao Liu Message-Id: <20230928125943.1816922-9-zhao1@linux.intel.com> Reviewed-by: Michael S.

[PULL v2 08/78] tests: test-smp-parse: Add the test for cores/threads per socket helpers

2023-10-19 Thread Michael S. Tsirkin
From: Zhao Liu Use the different ways to calculate cores/threads per socket, so that the new CPU topology levels won't be missed in these 2 helpes: * machine_topo_get_cores_per_socket() * machine_topo_get_threads_per_socket() Test the commit a1d027be95bc3 ("machine: Add helpers to get cores/

[PULL v2 03/78] vdpa: Check device ack in vhost_vdpa_net_load_rx_mode()

2023-10-19 Thread Michael S. Tsirkin
From: Hawkins Jiawei Considering that vhost_vdpa_net_load_rx_mode() is only called within vhost_vdpa_net_load_rx() now, this patch refactors vhost_vdpa_net_load_rx_mode() to include a check for the device's ack, simplifying the code and improving its maintainability. Signed-off-by: Hawkins

[PULL v2 02/78] vdpa: Avoid using vhost_vdpa_net_load_*() outside vhost_vdpa_net_load()

2023-10-19 Thread Michael S. Tsirkin
From: Hawkins Jiawei Next patches in this series will refactor vhost_vdpa_net_load_cmd() to iterate through the control commands shadow buffers, allowing QEMU to send CVQ state load commands in parallel at device startup. Considering that QEMU always forwards the CVQ command serialized outside

[PULL v2 04/78] vdpa: Move vhost_svq_poll() to the caller of vhost_vdpa_net_cvq_add()

2023-10-19 Thread Michael S. Tsirkin
From: Hawkins Jiawei This patch moves vhost_svq_poll() to the caller of vhost_vdpa_net_cvq_add() and introduces a helper funtion. By making this change, next patches in this series is able to refactor vhost_vdpa_net_load_x() only to delay the polling and checking process until either the SVQ is

[PULL v2 01/78] vdpa: Use iovec for vhost_vdpa_net_cvq_add()

2023-10-19 Thread Michael S. Tsirkin
From: Hawkins Jiawei Next patches in this series will no longer perform an immediate poll and check of the device's used buffers for each CVQ state load command. Consequently, there will be multiple pending buffers in the shadow VirtQueue, making it a must for every control command to have its

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-19 Thread Michael S. Tsirkin
On Thu, Oct 19, 2023 at 10:33:08AM +, Bernhard Beschow wrote: > > > Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta : > >Hello, > > Hi Salil, > > >Can we assume that every machine type will have all the features which a GED > >Device can multiplex present together? like will Memory

Re: [PULL 12/54] target/riscv: deprecate the 'any' CPU type

2023-10-19 Thread Richard Henderson
On 10/11/23 21:10, Alistair Francis wrote: From: Daniel Henrique Barboza The 'any' CPU type was introduced in commit dc5bd18fa5725 ("RISC-V CPU Core Definition"), being around since the beginning. It's not an easy CPU to use: it's undocumented and its name doesn't tell users much about what

Re: [PATCH v3 0/3] Vhost-vdpa Shadow Virtqueue RSS Support

2023-10-19 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 05:11:14PM +0800, Hawkins Jiawei wrote: > This series enables shadowed CVQ to intercept RSS command > through shadowed CVQ, update the virtio NIC device model > so qemu send it in a migration, and the restore of that > RSS state in the destination. > > Note that this patch

Re: [PATCH v2 0/2] Vhost-vdpa Shadow Virtqueue Hash calculation Support

2023-10-19 Thread Michael S. Tsirkin
On Tue, Aug 29, 2023 at 04:47:33PM +0800, Hawkins Jiawei wrote: > This series enables shadowed CVQ to intercept > VIRTIO_NET_CTRL_MQ_HASH_CONFIG command through shadowed CVQ, > update the virtio NIC device model so qemu send it in a > migration, and the restore of that Hash calculation state > in

Re: [PULL 08/83] vdpa: Restore hash calculation state

2023-10-19 Thread Michael S. Tsirkin
On Thu, Oct 19, 2023 at 09:32:28AM -0700, Stefan Hajnoczi wrote: > On Wed, 18 Oct 2023 at 08:56, Michael S. Tsirkin wrote: > > > > From: Hawkins Jiawei > > > > This patch introduces vhost_vdpa_net_load_rss() to restore > > the hash calculation state at device's startup. > > > > Note that

Re: [PATCH v5 1/6] gdbstub: Check if gdb_regs is NULL

2023-10-19 Thread Alex Bennée
Akihiko Odaki writes: > cpu->gdb_regs may be NULL if no coprocessor is registered. > > Fixes: 73c392c26b ("gdbstub: Replace gdb_regs with an array") > Signed-off-by: Akihiko Odaki Queued to gdbstub/next, thanks. I'll leave the riscv stuff for the maintainers of the arch. -- Alex Bennée

Re: [PULL 06/25] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-19 Thread Nina Schoetterl-Glausch
On Thu, 2023-10-19 at 09:35 -0700, Stefan Hajnoczi wrote: > On Wed, 18 Oct 2023 at 06:09, Thomas Huth wrote: > > > > From: Pierre Morel > > > > During a subsystem reset the Topology-Change-Report is cleared > > by the machine. > > Let's ask KVM to clear the Modified Topology Change Report

Re: [PULL 03/25] s390x/cpu topology: add topology entries on CPU hotplug

2023-10-19 Thread Nina Schoetterl-Glausch
On Wed, 2023-10-18 at 15:06 +0200, Thomas Huth wrote: > From: Pierre Morel > > The topology information are attributes of the CPU and are > specified during the CPU device creation. > > On hot plug we: > - calculate the default values for the topology for drawers, > books and sockets in the

Re: [PATCH v2] hw/audio/pcspk: Inline pcspk_init()

2023-10-19 Thread Markus Armbruster
Bernhard Beschow writes: > Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé" > : >>pcspk_init() is a legacy init function, inline and remove it. >> >>Since the device is realized using _fatal, use the same >>error for setting the "pit" link. >> >>Reviewed-by: Mark Cave-Ayland

[PATCH v4] hw/pci: modify pci_setup_iommu() to set PCIIOMMUOps

2023-10-19 Thread Cédric Le Goater
From: Yi Liu This patch modifies pci_setup_iommu() to set PCIIOMMUOps instead of setting PCIIOMMUFunc. PCIIOMMUFunc is used to get an address space for a PCI device in vendor specific way. The PCIIOMMUOps still offers this functionality. But using PCIIOMMUOps leaves space to add more iommu

Re: [PATCH v2 07/19] target/i386: introduce flags writeback mechanism

2023-10-19 Thread Richard Henderson
On 10/19/23 03:46, Paolo Bonzini wrote: +/* + * Write back flags after last memory access. Some newer ALU instructions, as + * well as SSE instructions, write flags in the gen_* function, but that can + * cause incorrect tracking of CC_OP for instructions that write to both

Re: [PATCH v3 00/13] VIRTIO-IOMMU/VFIO: Don't assume 64b IOVA space

2023-10-19 Thread Cédric Le Goater
Hello Eric, On 10/19/23 15:51, Eric Auger wrote: Hi Cédric, On 10/19/23 13:07, Cédric Le Goater wrote: On 10/18/23 15:37, Michael S. Tsirkin wrote: On Wed, Oct 11, 2023 at 07:52:16PM +0200, Eric Auger wrote: This applies on top of vfio-next: https://github.com/legoater/qemu/, vfio-next

Re: [PATCH v3] misc/pca9552: Fix for pca9552 not getting reset

2023-10-19 Thread Miles Glenn
On Tue, 2023-10-10 at 22:41 +0200, Cédric Le Goater wrote: > On 10/10/23 22:35, Miles Glenn wrote: > > On Tue, 2023-10-10 at 21:31 +0100, Mark Cave-Ayland wrote: > > > On 10/10/2023 20:52, Glenn Miles wrote: > > > > > > > Testing of the pca9552 device on the powernv platform > > > > showed that

Re: [PATCH v5 03/10] hw/fsi: Introduce IBM's cfam,fsi-slave

2023-10-19 Thread Cédric Le Goater
On 10/11/23 17:13, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the

Re: [PULL v2 29/53] hw/i386: Remove now redundant TYPE_ACPI_GED_X86

2023-10-19 Thread Bernhard Beschow
Am 18. Oktober 2023 17:38:33 UTC schrieb Salil Mehta : >Hello, Hi Salil, >Can we assume that every machine type will have all the features which a GED >Device can multiplex present together? like will Memory and CPU Hotplug makes >sense for all the type of machines? I can't really answer

Re: [PATCH v2] hw/audio/pcspk: Inline pcspk_init()

2023-10-19 Thread Bernhard Beschow
Am 19. Oktober 2023 07:33:07 UTC schrieb "Philippe Mathieu-Daudé" : >pcspk_init() is a legacy init function, inline and remove it. > >Since the device is realized using _fatal, use the same >error for setting the "pit" link. > >Reviewed-by: Mark Cave-Ayland >Signed-off-by: Philippe

Re: [PULL 00/11] C3700 patches

2023-10-19 Thread Stefan Hajnoczi
On Wed, 18 Oct 2023 at 13:42, wrote: > > From: Helge Deller > > The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56: > > Merge tag 'pull-riscv-to-apply-20231012-1' of > https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400) > > are available in the

Re: [PATCH 2/8] docs/specs/edu: Convert to rST

2023-10-19 Thread Thomas Huth
On 27/09/2023 17.11, Peter Maydell wrote: Convert docs/specs/edu.txt to rST format. Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + docs/specs/{edu.txt => edu.rst} | 84 - docs/specs/index.rst| 1 + 3 files changed, 54

Re: [PATCH 1/8] docs/specs/vmw_pvscsi-spec: Convert to rST

2023-10-19 Thread Thomas Huth
On 27/09/2023 17.11, Peter Maydell wrote: Convert the docs/specs/vmw_pvscsi-spec.txt file to rST format. This conversion includes some minor wordsmithing of the text to fix some grammar nits. Signed-off-by: Peter Maydell --- The number of lines changed for markup formatting was such a large

Re: [PULL 15/29] tcg: Provide guest_base fallback for system mode

2023-10-19 Thread Stefan Hajnoczi
On Wed, 18 Oct 2023 at 15:30, Richard Henderson wrote: > > Provide a define to allow !tcg_use_softmmu code paths to > compile in system mode, but require elimination. > > Reviewed-by: Philippe Mathieu-Daudé > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 4 > 1 file changed, 4

Re: [PULL 06/25] s390x/cpu topology: resetting the Topology-Change-Report

2023-10-19 Thread Stefan Hajnoczi
On Wed, 18 Oct 2023 at 06:09, Thomas Huth wrote: > > From: Pierre Morel > > During a subsystem reset the Topology-Change-Report is cleared > by the machine. > Let's ask KVM to clear the Modified Topology Change Report (MTCR) > bit of the SCA in the case of a subsystem reset. > > Signed-off-by:

Re: [PULL 08/83] vdpa: Restore hash calculation state

2023-10-19 Thread Stefan Hajnoczi
On Wed, 18 Oct 2023 at 08:56, Michael S. Tsirkin wrote: > > From: Hawkins Jiawei > > This patch introduces vhost_vdpa_net_load_rss() to restore > the hash calculation state at device's startup. > > Note that vhost_vdpa_net_load_rss() has `do_rss` argument, > which allows future code to reuse

Re: [PATCH] MAINTAINERS: Fix typo in openpic_kvm.c entry

2023-10-19 Thread Philippe Mathieu-Daudé
On 19/10/23 17:58, Thomas Huth wrote: It's a .c file, not a header! Fixes: ff8cdbbd7e ("MAINTAINERS: Add information for OpenPIC") Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 5/9] hw/pcmcia/pxa2xx: Inline pxa2xx_pcmcia_init()

2023-10-19 Thread Thomas Huth
On 19/10/2023 15.09, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- include/hw/arm/pxa.h | 2 -- hw/arm/pxa2xx.c | 12 hw/pcmcia/pxa2xx.c | 6 -- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/include/hw/arm/pxa.h

Re: [PATCH v5 01/10] hw/fsi: Introduce IBM's Local bus

2023-10-19 Thread Daniel P . Berrangé
On Thu, Oct 19, 2023 at 10:34:52AM -0500, Ninad Palsule wrote: > Hello Daniel, > > On 10/19/23 03:14, Daniel P. Berrangé wrote: > > On Wed, Oct 11, 2023 at 10:13:30AM -0500, Ninad Palsule wrote: > > > This is a part of patchset where IBM's Flexible Service Interface is > > > introduced. > > > >

Re: [PATCH v2 4/9] hw/pcmcia/pxa2xx: Do not open-code sysbus_create_simple()

2023-10-19 Thread Thomas Huth
On 19/10/2023 15.09, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/pcmcia/pxa2xx.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/pcmcia/pxa2xx.c b/hw/pcmcia/pxa2xx.c index e7264feb45..a2ab96d749 100644 --- a/hw/pcmcia/pxa2xx.c +++

Re: [PATCH v2 3/9] hw/pcmcia/pxa2xx: Realize sysbus device before accessing it

2023-10-19 Thread Thomas Huth
On 19/10/2023 15.09, Philippe Mathieu-Daudé wrote: sysbus_mmio_map() should not be called on unrealized device. Signed-off-by: Philippe Mathieu-Daudé --- hw/pcmcia/pxa2xx.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/pcmcia/pxa2xx.c b/hw/pcmcia/pxa2xx.c

Re: [PATCH v2 2/9] hw/sd/pxa2xx: Do not open-code sysbus_create_simple()

2023-10-19 Thread Thomas Huth
On 19/10/2023 15.09, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/pxa2xx_mmci.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/sd/pxa2xx_mmci.c b/hw/sd/pxa2xx_mmci.c index 9f7a880bac..4749e935d8 100644 --- a/hw/sd/pxa2xx_mmci.c

Re: [PATCH] MAINTAINERS: Fix typo in openpic_kvm.c entry

2023-10-19 Thread Cédric Le Goater
On 10/19/23 17:58, Thomas Huth wrote: It's a .c file, not a header! Fixes: ff8cdbbd7e ("MAINTAINERS: Add information for OpenPIC") Signed-off-by: Thomas Huth Reviewed-by: Cédric Le Goater Thanks, C. --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it

2023-10-19 Thread Thomas Huth
On 19/10/2023 18.00, Thomas Huth wrote: On 19/10/2023 15.09, Philippe Mathieu-Daudé wrote: sysbus_mmio_map() and sysbus_connect_irq() should not be called on unrealized device. Signed-off-by: Philippe Mathieu-Daudé ---   hw/sd/pxa2xx_mmci.c | 2 +-   1 file changed, 1 insertion(+), 1

Re: [PATCH v2 1/9] hw/sd/pxa2xx: Realize sysbus device before accessing it

2023-10-19 Thread Thomas Huth
On 19/10/2023 15.09, Philippe Mathieu-Daudé wrote: sysbus_mmio_map() and sysbus_connect_irq() should not be called on unrealized device. Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/pxa2xx_mmci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/pxa2xx_mmci.c

Re: [PATCH v2 14/19] tcg: add negsetcondi

2023-10-19 Thread Richard Henderson
On 10/19/23 03:46, Paolo Bonzini wrote: This can be useful to write a shift bit extraction that does not depend on TARGET_LONG_BITS. Signed-off-by: Paolo Bonzini --- include/tcg/tcg-op-common.h | 4 include/tcg/tcg-op.h| 2 ++ tcg/tcg-op.c| 12

[PATCH] MAINTAINERS: Fix typo in openpic_kvm.c entry

2023-10-19 Thread Thomas Huth
It's a .c file, not a header! Fixes: ff8cdbbd7e ("MAINTAINERS: Add information for OpenPIC") Signed-off-by: Thomas Huth --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c12511c73b..a110a0c7a4 100644 --- a/MAINTAINERS +++

Re: [RFC PATCH v2 1/6] migration/multifd: Remove channels_ready semaphore

2023-10-19 Thread Fabiano Rosas
Juan Quintela writes: > Fabiano Rosas wrote: >> Juan Quintela writes: >> >>> Fabiano Rosas wrote: The channels_ready semaphore is a global variable not linked to any single multifd channel. Waiting on it only means that "some" channel has become ready to send data. Since we

Re: [PATCH v3 1/7] hw/ppc/spapr_vio: Realize SPAPR_VIO_BRIDGE device before accessing it

2023-10-19 Thread Thomas Huth
On 19/10/2023 15.16, Philippe Mathieu-Daudé wrote: qbus_new() should not be called on unrealized device. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_vio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr_vio.c b/hw/ppc/spapr_vio.c index

Re: [RFC PATCH v2 1/6] migration/multifd: Remove channels_ready semaphore

2023-10-19 Thread Peter Xu
On Thu, Oct 19, 2023 at 05:00:02PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > Fabiano, > > > > Sorry to look at this series late; I messed up my inbox after I reworked my > > arrangement methodology of emails. ;) > > > > On Thu, Oct 19, 2023 at 11:06:06AM +0200, Juan Quintela wrote: > >>

Re: [PATCH v2 01/19] target/i386: group common checks in the decoding phase

2023-10-19 Thread Richard Henderson
On 10/19/23 03:46, Paolo Bonzini wrote: In preparation for adding more similar checks, move the VEX.L=0 check and several X86_SPECIAL_* checks to a new field, where each bit represent a common check on unused bits, or a restriction on the processor mode. Likewise, many SVM intercepts can be

Re: [PATCH v2 02/19] target/i386: validate VEX.W for AVX instructions

2023-10-19 Thread Richard Henderson
On 10/19/23 03:46, Paolo Bonzini wrote: Instructions in VEX exception class 6 generally look at the value of VEX.W. Note that the manual places some instructions incorrectly in class 4, for example VPERMQ which has no non-VEX encoding and no legacy SSE analogue. AMD does a mess of its own, as

Re: [PATCH v2 00/19] target/i386: decoder changes for 8.2

2023-10-19 Thread Richard Henderson
On 10/19/23 03:46, Paolo Bonzini wrote: This includes: - implementing SHA and CMPccXADD instruction extensions - introducing a new mechanism for flags writeback that avoids a tricky failure - converting the more orthogonal parts of the one-byte opcode map, as well as the CMOVcc and

[PATCH v2 20/24] hw/xenpv: fix '-nic' support for xen-net-device

2023-10-19 Thread David Woodhouse
From: David Woodhouse I can't see how this has ever worked. If I start with the simple attempt "-nic user,model=xen", it creates a device with index -1 because it's assuming that it'll be attached to a hubport. So it creates a frontend at e.g. "/local/domain/84/device/vif/-1" and the guest fails

[PATCH v2 13/24] hw/xen: do not repeatedly try to create a failing backend device

2023-10-19 Thread David Woodhouse
From: David Woodhouse If xen_backend_device_create() fails to instantiate a device, the XenBus code will just keep trying over and over again each time the bus is re-enumerated, as long as the backend appears online and in XenbusStateInitialising. The only thing which prevents the XenBus code

[PATCH v2 01/24] i386/xen: Don't advertise XENFEAT_supervisor_mode_kernel

2023-10-19 Thread David Woodhouse
From: David Woodhouse This confuses lscpu into thinking it's running in PVH mode. Fixes: bedcc139248 ("i386/xen: implement HYPERVISOR_xen_version") Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- target/i386/kvm/xen-emu.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 22/24] tests/avocado: switch to using xen-net-device for Xen guest tests

2023-10-19 Thread David Woodhouse
From: David Woodhouse Fix the filename in the MAINTAINERS file too. Signed-off-by: David Woodhouse --- MAINTAINERS| 2 +- tests/avocado/kvm_xen_guest.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

<    1   2   3   4   5   6   7   >