Re: [External] Re: [PATCH 01/16] Cherry pick a set of patches that enables multifd zero page feature.

2023-10-27 Thread Hao Xiang
On Fri, Oct 27, 2023 at 6:22 AM Peter Maydell wrote: > > On Fri, 27 Oct 2023 at 13:32, Fabiano Rosas wrote: > > > > Hao Xiang writes: > > > > > Juan Quintela had a patchset enabling zero page checking in multifd > > > threads. > > > > > >

Re: [External] Re: [PATCH 01/16] Cherry pick a set of patches that enables multifd zero page feature.

2023-10-27 Thread Hao Xiang
On Fri, Oct 27, 2023 at 5:30 AM Fabiano Rosas wrote: > > Hao Xiang writes: > > > Juan Quintela had a patchset enabling zero page checking in multifd > > threads. > > > > https://lore.kernel.org/all/20220802063907.18882-13-quint...@redhat.com/ > > Hmm, risky to base your series on code more than

Re: [PULL 00/94] target/sparc: Convert to decodetree

2023-10-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/24] x86, KVM changes for 2023-10-26

2023-10-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/12] aspeed queue

2023-10-27 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH 0/3] migration: Downtime tracepoints

2023-10-27 Thread Joao Martins
On 27/10/2023 15:41, Peter Xu wrote: > On Fri, Oct 27, 2023 at 09:58:03AM +0100, Joao Martins wrote: >> On 26/10/2023 21:07, Peter Xu wrote: >>> On Thu, Oct 26, 2023 at 08:33:13PM +0100, Joao Martins wrote: Sure. For the fourth patch, feel free to add Suggested-by and/or a Link,

[PATCH] linux-user: Fix guest signal remapping after adjusting SIGABRT

2023-10-27 Thread Richard Henderson
The arithmetic within the loop was not adjusted properly after SIGRTMIN was stolen for the guest SIGABRT. The effect was that the guest libc could not send itself __SIGRTMIN to wake sleeping threads. Fixes: 38ee0a7dfb4b ("linux-user: Remap guest SIGABRT") Resolves:

Re: [PATCH 17/24] block: Protect bs->backing with graph_lock

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:26PM +0200, Kevin Wolf wrote: > Almost all functions that access bs->backing already take the graph > lock now. Add locking to the remaining users and finally annotate the > struct field itself as protected by the graph lock. > > Signed-off-by: Kevin Wolf > --- >

Re: [PATCH 16/24] block: Mark bdrv_replace_node() GRAPH_WRLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:25PM +0200, Kevin Wolf wrote: > Instead of taking the writer lock internally, require callers to already > hold it when calling bdrv_replace_node(). Its callers may already want > to hold the graph lock and so wouldn't be able to call functions that > take it

Re: [PATCH 15/24] block: Mark bdrv_replace_node_common() GRAPH_WRLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:24PM +0200, Kevin Wolf wrote: > Instead of taking the writer lock internally, require callers to already > hold it when calling bdrv_replace_node_common(). Basically everthing in > the function needs the lock and its callers may already want to hold the > graph lock

Re: [PATCH 14/24] block: Inline bdrv_set_backing_noperm()

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:23PM +0200, Kevin Wolf wrote: > It's only a single line and has a single caller. Inlining makes things > a bit easier to follow. > > Signed-off-by: Kevin Wolf > --- > block.c | 14 +- > 1 file changed, 1 insertion(+), 13 deletions(-) > Reviewed-by:

Re: [PATCH 13/24] block: Mark bdrv_set_backing_hd_drained() GRAPH_WRLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:22PM +0200, Kevin Wolf wrote: > Instead of taking the writer lock internally, require callers to already > hold it when calling bdrv_set_backing_hd_drained(). Basically everthing > in the function needs the lock and its callers may already want to hold > the graph

Re: [PATCH 12/24] block: Mark bdrv_cow_child() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:21PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_cow_child() need to hold a reader lock for the graph because it > accesses bs->backing. > > Signed-off-by: Kevin Wolf > --- > include/block/block_int-io.h | 5

Re: [PATCH 11/24] block: Mark bdrv_filter_child() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:20PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_filter_child() need to hold a reader lock for the graph because it > accesses bs->file/backing. > > Signed-off-by: Kevin Wolf > --- > include/block/block_int-io.h |

Re: [PATCH 10/24] block: Mark bdrv_chain_contains() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:19PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_chain_contains() need to hold a reader lock for the graph because > it calls bdrv_filter_or_cow_bs(), which accesses bs->file/backing. > > Signed-off-by: Kevin Wolf

Re: [PATCH 09/24] block: Mark bdrv_(un)freeze_backing_chain() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:18PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_(un)freeze_backing_chain() need to hold a reader lock for the > graph because it calls bdrv_filter_or_cow_child(), which accesses > bs->file/backing. > > Use the

Re: [PATCH 08/24] block: Mark bdrv_skip_filters() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:17PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_skip_filters() need to hold a reader lock for the graph because it > calls bdrv_filter_child(), which accesses bs->file/backing. > > Signed-off-by: Kevin Wolf > ---

Re: [PATCH 03/24] block: Mark bdrv_filter_bs() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 03:02:38PM -0500, Eric Blake wrote: > On Fri, Oct 27, 2023 at 05:53:12PM +0200, Kevin Wolf wrote: > > This adds GRAPH_RDLOCK annotations to declare that callers of > > bdrv_filter_bs() need to hold a reader lock for the graph because > > it calls bdrv_filter_child(), which

Re: [PATCH 07/24] block: Mark bdrv_skip_implicit_filters() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:16PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_skip_implicit_filters() need to hold a reader lock for the graph > because it calls bdrv_filter_child(), which accesses bs->file/backing. > > Signed-off-by: Kevin

Re: [PATCH 06/24] block: Mark bdrv_filter_or_cow_bs() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:15PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_filter_or_cow_bs() need to hold a reader lock for the graph because > it calls bdrv_filter_or_cow_child(), which accesses bs->file/backing. > > Signed-off-by: Kevin

Re: [PATCH 05/24] block: Mark block_job_add_bdrv() GRAPH_WRLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:14PM +0200, Kevin Wolf wrote: > Instead of taking the writer lock internally, require callers to already > hold it when calling block_job_add_bdrv(). These callers will typically > already hold the graph lock once the locking work is completed, which > means that they

Re: [PATCH 04/24] block: Mark bdrv_root_attach_child() GRAPH_WRLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:13PM +0200, Kevin Wolf wrote: > Instead of taking the writer lock internally, require callers to already > hold it when calling bdrv_root_attach_child(). These callers will > typically already hold the graph lock once the locking work is > completed, which means that

Re: [PATCH 03/24] block: Mark bdrv_filter_bs() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:12PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_filter_bs() need to hold a reader lock for the graph because > it calls bdrv_filter_child(), which accesses bs->file/backing. > > Signed-off-by: Kevin Wolf > --- >

Re: [PATCH 02/24] block: Mark bdrv_has_zero_init() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:11PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_has_zero_init() need to hold a reader lock for the graph because > it calls bdrv_filter_bs(), which accesses bs->file/backing. > > Signed-off-by: Kevin Wolf > --- >

Patch to fix malfunctioning of T2-T5 timers on the STM32 platform

2023-10-27 Thread Lucjan Bryndza
Current implementation of T2 - T5 times on the STM32 platform does not work properly. After configuring the timer-counter circuit to report interrupts every 10ms, in reality the first interrupt is reported only once after a few seconds, while subsequent interrupts do not come. The current

Re: [PATCH 01/24] block: Mark bdrv_probe_blocksizes() and callers GRAPH_RDLOCK

2023-10-27 Thread Eric Blake
On Fri, Oct 27, 2023 at 05:53:10PM +0200, Kevin Wolf wrote: > This adds GRAPH_RDLOCK annotations to declare that callers of > bdrv_probe_blocksizes() need to hold a reader lock for the graph because > it calls bdrv_filter_bs(), which accesses bs->file/backing. > > Signed-off-by: Kevin Wolf > ---

Re: [PATCH 01/11] qdev: Add qdev_prop_set_array()

2023-10-27 Thread Peter Maydell
On Fri, 8 Sept 2023 at 15:37, Kevin Wolf wrote: > > Instead of exposing the ugly hack of how we represent arrays in qdev (a > static "foo-len" property and after it is set, dynamically created > "foo[i]" properties) to boards, add an interface that allows setting the > whole array at once. > >

[PATCH v5 06/11] tests/qtest: Creating qtest for GMAC Module

2023-10-27 Thread Nabih Estefan
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: Ib0e07f6dacc1266b62b4926873ccd912250cf89d Signed-off-by: Nabih Estefan --- tests/qtest/meson.build | 7 +- tests/qtest/npcm_gmac-test.c | 209

[PATCH v5 02/11] hw/arm: Add PCI mailbox module to Nuvoton SoC

2023-10-27 Thread Nabih Estefan
From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Change-Id: I9421ff6bc7d365b0559c0a1f6b98cfd24b6f2d9f Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 3 ++- include/hw/arm/npcm7xx.h| 1 + 3 files

[PATCH v5 04/11] hw/net: Add NPCMXXX GMAC device

2023-10-27 Thread Nabih Estefan
From: Hao Wu This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver [Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL)

[PATCH v5 01/11] hw/misc: Add Nuvoton's PCI Mailbox Module

2023-10-27 Thread Nabih Estefan
From: Hao Wu The PCI Mailbox Module is a high-bandwidth communcation module between a Nuvoton BMC and CPU. It features 16KB RAM that are both accessible by the BMC and core CPU. and supports interrupt for both sides. This patch implements the BMC side of the PCI mailbox module. Communication

[PATCH v5 11/11] tests/qtest: Adding PCS Module test to GMAC Qtest

2023-10-27 Thread Nabih Estefan
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I4e9cc0e1056f35467252c7bf6bd5b44fef61b6e8 Signed-off-by: Nabih Estefan --- tests/qtest/npcm_gmac-test.c | 134 ++- 1 file changed, 133 insertions(+), 1 deletion(-) diff --git

[PATCH v5 09/11] hw/net: GMAC Rx Implementation

2023-10-27 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work with TAP

[PATCH v5 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-10-27 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v4] Added Signed-off-by tag and fixed patch 4 commit message as suggested by Peter Maydell (peter.mayd...@linaro.org) [Changes since v3] Fixed comments from Hao Wu (wuhao...@google.com) [Changes since v2] Fixed bugs related to the RC functionality of the

[PATCH v5 08/11] hw/net: General GMAC Implementation

2023-10-27 Thread Nabih Estefan
From: Nabih Estefan Diaz - General GMAC Register handling - GMAC IRQ Handling - Added traces in some methods for debugging - Lots of declarations for accessing information on GMAC Descriptors (npcm_gmac.h file) NOTE: With code on this state, the GMAC can boot-up properly and will show up in

[PATCH v5 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox

2023-10-27 Thread Nabih Estefan
From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Change-Id: Id7a4b3cbea564383b94d507552dfd16f6b5127d1 Signed-off-by: Hao Wu Signed-off-by: Nabih

[PATCH v5 05/11] hw/arm: Add GMAC devices to NPCM7XX SoC

2023-10-27 Thread Nabih Estefan
From: Hao Wu Change-Id: Ibbb1d7221bb14e75173bf051271e758d640f40c8 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2 deletions(-) diff --git

[PATCH v5 07/11] include/hw/net: Implemented Classes and Masks for GMAC Descriptors

2023-10-27 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implemeted classes for GMAC Receive and Transmit Descriptors - Implemented Masks for said descriptors Change-Id: Id671a69137927e169afc9e610dde8dcd7811f6be Signed-off-by: Nabih Estefan --- hw/net/npcm_gmac.c | 183 +++

[PATCH v5 10/11] hw/net: GMAC Tx Implementation

2023-10-27 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC. Change-Id:

Re: [PATCH] MAINTAINERS: Add the can documenation file to the CAN section

2023-10-27 Thread Vikram Garhwal
On Fri, Oct 27, 2023 at 10:44:35AM +0200, Philippe Mathieu-Daudé wrote: > CAUTION: This message has originated from an External Source. Please use > proper judgment and caution when opening attachments, clicking links, or > responding to this email. > > > On 27/10/23 08:09, Thomas Huth wrote:

Re: [PATCH v3 3/6] target/riscv/tcg: add user flag for profile support

2023-10-27 Thread Daniel Henrique Barboza
On 10/26/23 14:36, Andrea Bolognani wrote: On Thu, Oct 26, 2023 at 05:14:49PM +0200, Andrew Jones wrote: On Thu, Oct 26, 2023 at 07:36:21AM -0700, Andrea Bolognani wrote: On Mon, Oct 23, 2023 at 07:35:16PM +0200, Andrew Jones wrote: On Mon, Oct 23, 2023 at 02:00:00PM -0300, Daniel Henrique

Re: [PATCH v2 00/11] qapi-go: add generator for Golang interface

2023-10-27 Thread Victor Toso
Hi, Daniel & Andrea, it would be great to have your take on the Go side of this series. If we can agree with an acceptable 'unstable' version of Go modules, we can start building on top of this: - libraries/tools in Go to interact with QEMU - qapi specs to fix limitations (e.g: Data type names)

Re: [PATCH v6 09/23] ui/console: allow to override the default VC

2023-10-27 Thread Daniel P . Berrangé
On Fri, Oct 27, 2023 at 05:53:19AM -0700, Andrea Bolognani wrote: > On Wed, Oct 25, 2023 at 11:08:03PM +0400, marcandre.lur...@redhat.com wrote: > > If a display is backed by a specialized VC, allow to override the > > default "vc:80Cx24C". For that, set the dpy.type just before creating > > the

[PATCH] target/s390x/cpu topology: Fix ordering and creation of TLEs

2023-10-27 Thread Nina Schoetterl-Glausch
In case of horizontal polarization entitlement has no effect on ordering. Moreover, since the comparison is used to insert CPUs at the correct position in the TLE list, this affects the creation of TLEs and now correctly collapses horizontally polarized CPUs into one TLE. Fixes: f4f54b582f

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-27 Thread Peter Xu
Add cc list. On Fri, Oct 27, 2023 at 12:02:24PM -0400, Peter Xu wrote: > On Fri, Oct 27, 2023 at 11:28:36AM +0800, Ethan Chen wrote: > > On Thu, Oct 26, 2023 at 10:20:41AM -0400, Peter Xu wrote: > > > Could you elaborate why is that important? In what use case? > > I was not involved in the

Re: [PATCH v3 1/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread Akihiko Odaki
On 2023/10/28 0:49, carwynel...@gmail.com wrote: From: Carwyn Ellis Provides a display option, zoom-to-fit, that enables scaling of the display when full-screen mode is enabled. Also ensures that the corresponding menu item is marked as enabled when the option is set to on. Signed-off-by:

Re: [PATCH v3 18/37] vfio/container: Implement attach/detach_device

2023-10-27 Thread Cédric Le Goater
Sorry, previous email was empty. Friday effect ! On 10/26/23 12:30, Zhenzhong Duan wrote: From: Eric Auger No fucntional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater ---

Re: [PATCH v3 19/37] vfio/spapr: Introduce spapr backend and target interface

2023-10-27 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: Introduce an empry spapr backend which will hold spapr specific content, currently only prereg_listener and hostwin_list. Also introduce and instantiate a spapr specific target interface, currently only has add/del_window callbacks. Signed-off-by:

Re: [PATCH v3 18/37] vfio/container: Implement attach/detach_device

2023-10-27 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: From: Eric Auger No fucntional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater --- hw/vfio/common.c| 16

Re: [PATCH 2/6] system/physmem: IOMMU: Invoke the translate_size function if it is implemented

2023-10-27 Thread Peter Xu
On Fri, Oct 27, 2023 at 11:28:36AM +0800, Ethan Chen wrote: > On Thu, Oct 26, 2023 at 10:20:41AM -0400, Peter Xu wrote: > > Could you elaborate why is that important? In what use case? > I was not involved in the formulation of the IOPMP specification, but I'll try > to explain my perspective.

Re: [PATCH v3 16/37] vfio/container: Move dirty_pgsizes and max_dirty_bitmap_size to base container

2023-10-27 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: From: Eric Auger No functional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater Drop the Sob please, Reviewed-by: Cédric Le Goater Thanks,

[PATCH 18/24] blkverify: Add locking for request_fn

2023-10-27 Thread Kevin Wolf
This is either bdrv_co_preadv() or bdrv_co_pwritev() which both need to have the graph locked. Annotate the function pointer accordingly and add locking to its callers. This shouldn't actually have resulted in a bug because the graph lock is already held by blkverify_co_prwv(), which waits for

[PATCH 14/24] block: Inline bdrv_set_backing_noperm()

2023-10-27 Thread Kevin Wolf
It's only a single line and has a single caller. Inlining makes things a bit easier to follow. Signed-off-by: Kevin Wolf --- block.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/block.c b/block.c index d79a6f41f9..dc43e36f69 100644 --- a/block.c +++

[PATCH 09/24] block: Mark bdrv_(un)freeze_backing_chain() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_(un)freeze_backing_chain() need to hold a reader lock for the graph because it calls bdrv_filter_or_cow_child(), which accesses bs->file/backing. Use the opportunity to make bdrv_is_backing_chain_frozen() static, it has no

[PATCH 21/24] qcow2: Take locks for accessing bs->file

2023-10-27 Thread Kevin Wolf
This updates the qcow2 code to add GRAPH_RDLOCK annotations for all places that read bs->file. Signed-off-by: Kevin Wolf --- block/qcow2.h | 48 ++- block/qcow2-bitmap.c | 14 +++-- block/qcow2-cluster.c | 25 +++---

[PATCH 17/24] block: Protect bs->backing with graph_lock

2023-10-27 Thread Kevin Wolf
Almost all functions that access bs->backing already take the graph lock now. Add locking to the remaining users and finally annotate the struct field itself as protected by the graph lock. Signed-off-by: Kevin Wolf --- include/block/block_int-common.h | 2 +- block.c

[PATCH 16/24] block: Mark bdrv_replace_node() GRAPH_WRLOCK

2023-10-27 Thread Kevin Wolf
Instead of taking the writer lock internally, require callers to already hold it when calling bdrv_replace_node(). Its callers may already want to hold the graph lock and so wouldn't be able to call functions that take it internally. Signed-off-by: Kevin Wolf ---

[PATCH 24/24] block: Protect bs->file with graph_lock

2023-10-27 Thread Kevin Wolf
Almost all functions that access bs->file already take the graph lock now. Add locking to the remaining users and finally annotate the struct field itself as protected by the graph lock. Signed-off-by: Kevin Wolf --- block/parallels.h| 5 +++-- block/qed.h

[PATCH 04/24] block: Mark bdrv_root_attach_child() GRAPH_WRLOCK

2023-10-27 Thread Kevin Wolf
Instead of taking the writer lock internally, require callers to already hold it when calling bdrv_root_attach_child(). These callers will typically already hold the graph lock once the locking work is completed, which means that they can't call functions that take it internally. Signed-off-by:

[PATCH 13/24] block: Mark bdrv_set_backing_hd_drained() GRAPH_WRLOCK

2023-10-27 Thread Kevin Wolf
Instead of taking the writer lock internally, require callers to already hold it when calling bdrv_set_backing_hd_drained(). Basically everthing in the function needs the lock and its callers may already want to hold the graph lock and so wouldn't be able to call functions that take it internally.

[PATCH 23/24] block: Take graph lock for most of .bdrv_open

2023-10-27 Thread Kevin Wolf
Most implementations of .bdrv_open first open their file child (which is an operation that internally takes the write lock and therefore we shouldn't hold the graph lock while calling it), and afterwards many operations that require holding the graph lock, e.g. for accessing bs->file. This

[PATCH 22/24] vhdx: Take locks for accessing bs->file

2023-10-27 Thread Kevin Wolf
This updates the vhdx code to add GRAPH_RDLOCK annotations for all places that read bs->file. Signed-off-by: Kevin Wolf --- block/vhdx.h | 9 ++--- block/vhdx-log.c | 40 ++-- block/vhdx.c | 18 +++--- 3 files changed, 39

[PATCH 20/24] block: Add missing GRAPH_RDLOCK annotations

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK to some driver callbacks that are already called with the graph lock held, and which will need the annotation because they access bs->file, but don't have it yet. This also covers a few callbacks that were not marked GRAPH_RDLOCK before, but where updating BlockDriver is

[PATCH 08/24] block: Mark bdrv_skip_filters() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_skip_filters() need to hold a reader lock for the graph because it calls bdrv_filter_child(), which accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block-global-state.h | 8 ---

[PATCH 15/24] block: Mark bdrv_replace_node_common() GRAPH_WRLOCK

2023-10-27 Thread Kevin Wolf
Instead of taking the writer lock internally, require callers to already hold it when calling bdrv_replace_node_common(). Basically everthing in the function needs the lock and its callers may already want to hold the graph lock and so wouldn't be able to call functions that take it internally.

[PATCH 12/24] block: Mark bdrv_cow_child() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_cow_child() need to hold a reader lock for the graph because it accesses bs->backing. Signed-off-by: Kevin Wolf --- include/block/block_int-io.h | 5 +++-- block/stream.c | 2 +- qemu-img.c | 11

[PATCH 19/24] block: Introduce bdrv_co_change_backing_file()

2023-10-27 Thread Kevin Wolf
bdrv_change_backing_file() is called both inside and outside coroutine context. This makes it difficult for it to take the graph lock internally. It also means that driver implementations need to be able to run outside of coroutines, too. Switch it to the usual model with a coroutine based

[PATCH 06/24] block: Mark bdrv_filter_or_cow_bs() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_filter_or_cow_bs() need to hold a reader lock for the graph because it calls bdrv_filter_or_cow_child(), which accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block_int-io.h | 3 ++- block.c

[PATCH 00/24] block: Graph locking part 6 (bs->file/backing)

2023-10-27 Thread Kevin Wolf
This series is pleasantly boring for the most part and results in a GRAPH_RDLOCK_PTR annotation for bs->file and bs->backing. Kevin Wolf (24): block: Mark bdrv_probe_blocksizes() and callers GRAPH_RDLOCK block: Mark bdrv_has_zero_init() and callers GRAPH_RDLOCK block: Mark bdrv_filter_bs()

[PATCH 02/24] block: Mark bdrv_has_zero_init() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_has_zero_init() need to hold a reader lock for the graph because it calls bdrv_filter_bs(), which accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block-global-state.h | 2 +-

[PATCH 11/24] block: Mark bdrv_filter_child() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_filter_child() need to hold a reader lock for the graph because it accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block_int-io.h | 4 ++-- block.c | 4 ++-- 2 files changed, 4

[PATCH 05/24] block: Mark block_job_add_bdrv() GRAPH_WRLOCK

2023-10-27 Thread Kevin Wolf
Instead of taking the writer lock internally, require callers to already hold it when calling block_job_add_bdrv(). These callers will typically already hold the graph lock once the locking work is completed, which means that they can't call functions that take it internally. Signed-off-by: Kevin

[PATCH 07/24] block: Mark bdrv_skip_implicit_filters() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_skip_implicit_filters() need to hold a reader lock for the graph because it calls bdrv_filter_child(), which accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block_int-global-state.h | 3 ++- block.c

[PATCH 03/24] block: Mark bdrv_filter_bs() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_filter_bs() need to hold a reader lock for the graph because it calls bdrv_filter_child(), which accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block-io.h | 2 +- include/block/block_int-io.h | 3

[PATCH 01/24] block: Mark bdrv_probe_blocksizes() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_probe_blocksizes() need to hold a reader lock for the graph because it calls bdrv_filter_bs(), which accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block-global-state.h | 2 +-

[PATCH 10/24] block: Mark bdrv_chain_contains() and callers GRAPH_RDLOCK

2023-10-27 Thread Kevin Wolf
This adds GRAPH_RDLOCK annotations to declare that callers of bdrv_chain_contains() need to hold a reader lock for the graph because it calls bdrv_filter_or_cow_bs(), which accesses bs->file/backing. Signed-off-by: Kevin Wolf --- include/block/block-global-state.h | 4 ++- block.c

Re: [PATCH] hw/watchdog/wdt_aspeed: Remove unused 'hw/misc/aspeed_scu.h' header

2023-10-27 Thread Cédric Le Goater
On 10/27/23 15:42, Philippe Mathieu-Daudé wrote: Aspeed watchdog doesn't use anything from the System Control Unit. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/watchdog/wdt_aspeed.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v3 14/37] vfio/container: Move vrdl_list, pgsizes and dma_max_mappings to base container

2023-10-27 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: From: Eric Auger Move vrdl_list, pgsizes and dma_max_mappings to the base container object No functional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan [ clg: context changes ]

Re: [PATCH] Support for the RISCV Zalasr extension

2023-10-27 Thread Palmer Dabbelt
On Thu, 26 Oct 2023 16:03:28 PDT (-0700), turt...@utexas.edu wrote: From 4af1fca6e5c99578a5b80b834c22b70f6419639f Mon Sep 17 00:00:00 2001 From: Brendan Sweeney Date: Thu, 26 Oct 2023 17:01:29 -0500 Subject: [PATCH] Support for the RISCV Zalasr extension This doesn't have a commit body. At

[PATCH v3 1/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread carwynellis
From: Carwyn Ellis Provides a display option, zoom-to-fit, that enables scaling of the display when full-screen mode is enabled. Also ensures that the corresponding menu item is marked as enabled when the option is set to on. Signed-off-by: Carwyn Ellis --- qapi/ui.json | 7 ++-

[PATCH v3 0/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread carwynellis
From: Carwyn Ellis The intention here is to allow fullscreen scaling of the display to be enabled by setting the display option `zoom-to-fit` to on, allowing this to be set from the command line without having to interact with the ui menu. Includes changes requested by Akihiko Odaki.

Re: [v2 5/6] tests/migration: Introduce dirty-limit into guestperf

2023-10-27 Thread Fabiano Rosas
Hyman Huang writes: > Currently, guestperf does not cover the dirty-limit > migration, support this feature. > > Note that dirty-limit requires 'dirty-ring-size' set. > > To enable dirty-limit, setting x-vcpu-dirty-limit-period > as 500ms and x-vcpu-dirty-limit as 10MB/s: > $

Re: [v2 4/6] tests/migration: Introduce dirty-ring-size option into guestperf

2023-10-27 Thread Fabiano Rosas
Hyman Huang writes: > Dirty ring size configuration is not supported by guestperf tool. > > Introduce dirty-ring-size (ranges in [1024, 65536]) option so > developers can play with dirty-ring and dirty-limit feature easier. > > To set dirty ring size with 4096 during migration test: > $

Re: [PATCH v2 1/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread Carwyn Ellis
> On 27 Oct 2023, at 16:24, Akihiko Odaki wrote: > > On 2023/10/28 0:09, carwynel...@gmail.com wrote: >> From: Carwyn Ellis >> Provides a display option, zoom-to-fit, that enables scaling of the >> display when full-screen mode is enabled. >> Also ensures that the corresponding menu item is

Re: [PATCH v2 1/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread Akihiko Odaki
On 2023/10/28 0:09, carwynel...@gmail.com wrote: From: Carwyn Ellis Provides a display option, zoom-to-fit, that enables scaling of the display when full-screen mode is enabled. Also ensures that the corresponding menu item is marked as enabled when the option is set to on. Signed-off-by:

[PATCH v2] Optimize buffer_is_zero

2023-10-27 Thread Mikhail Romanov
Improve buffer_is_zero function which is often used in qemu-img utility. For instance, when converting a 4.4 GiB Windows 10 image to qcow2 it takes around 40% of qemu-img run time (measured with 'perf record'). * The main improvements: 1) Define an inline wrapper for this function in

[PATCH v2 0/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread carwynellis
From: Carwyn Ellis The intention here is to allow fullscreen scaling of the display to be enabled by setting the display option `zoom-to-fit` to on, allowing this to be set from the command line without having to interact with the ui menu. Includes changes requested by Akihiko Odaki.

[PATCH v2 1/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread carwynellis
From: Carwyn Ellis Provides a display option, zoom-to-fit, that enables scaling of the display when full-screen mode is enabled. Also ensures that the corresponding menu item is marked as enabled when the option is set to on. Signed-off-by: Carwyn Ellis --- qapi/ui.json | 8 ++--

Re: [v2 4/6] tests/migration: Introduce dirty-ring-size option into guestperf

2023-10-27 Thread Hyman Huang
ping1 在 2023/10/23 10:03, Yong Huang 写道: ping. Regarding the performance of the live migration, Guestperf could provide us with a clear response. IMHO, by just adding a few metrics, it might be developed into a more user-friendly metrics system in the future. We may still enrich it prior

Re: [PATCH v3 12/37] vfio/container: Move per container device list in base container

2023-10-27 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: VFIO Device is also changed to point to base container instead of legacy container. No fucntional change intended. Signed-off-by: Zhenzhong Duan [ clg: context changes ] Signed-off-by: Cédric Le Goater Please drop my SoB. Reviewed-by: Cédric Le

Re: [PATCH v3 13/37] vfio/container: Convert functions to base container

2023-10-27 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: From: Eric Auger In the prospect to get rid of VFIOContainer refs in common.c lets convert misc functions to use the base container object instead: vfio_devices_all_dirty_tracking vfio_devices_all_device_dirty_tracking

Re: [PATCH v3 11/37] vfio/container: Switch to IOMMU BE set_dirty_page_tracking/query_dirty_bitmap API

2023-10-27 Thread Cédric Le Goater
On 10/26/23 12:30, Zhenzhong Duan wrote: From: Eric Auger dirty_pages_supported field is also moved to the base container No fucntional change intended. Signed-off-by: Eric Auger Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Signed-off-by: Cédric Le Goater

[PULL 36/41] hw/net/cadence_gem: use FIELD to describe [TX|RX]STATUS register fields

2023-10-27 Thread Peter Maydell
From: Luc Michel Use de FIELD macro to describe the TXSTATUS and RXSTATUS register fields. Signed-off-by: Luc Michel Reviewed-by: sai.pavan.bo...@amd.com Message-id: 20231017194422.4124691-7-luc.mic...@amd.com Signed-off-by: Peter Maydell --- hw/net/cadence_gem.c | 34

[PULL 40/41] hw/net/cadence_gem: perform PHY access on write only

2023-10-27 Thread Peter Maydell
From: Luc Michel The MDIO access is done only on a write to the PHYMNTNC register. A subsequent read is used to retrieve the result but does not trigger an MDIO access by itself. Refactor the PHY access logic to perform all accesses (MDIO reads and writes) at PHYMNTNC write time.

[PULL 31/41] hw/net/cadence_gem: use REG32 macro for register definitions

2023-10-27 Thread Peter Maydell
From: Luc Michel Replace register defines with the REG32 macro from registerfields.h in the Cadence GEM device. Signed-off-by: Luc Michel Reviewed-by: sai.pavan.bo...@amd.com Message-id: 20231017194422.4124691-2-luc.mic...@amd.com Signed-off-by: Peter Maydell --- hw/net/cadence_gem.c | 527

[PULL 29/41] hw/arm: Avoid using 'first_cpu' when first ARM CPU is reachable

2023-10-27 Thread Peter Maydell
From: Philippe Mathieu-Daudé Prefer using a well known local first CPU rather than a global one. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20231025065909.57344-1-phi...@linaro.org Signed-off-by: Peter Maydell --- hw/arm/bananapi_m2u.c | 2 +-

[PULL 25/41] hw/intc/pxa2xx: Convert to Resettable interface

2023-10-27 Thread Peter Maydell
From: Philippe Mathieu-Daudé Factor reset code out of the DeviceRealize() handler. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Message-id: 20231020130331.50048-7-phi...@linaro.org Signed-off-by: Peter Maydell --- hw/arm/pxa2xx_pic.c | 17

[PULL 08/41] target/arm: Move ID_AA64DFR* feature tests together

2023-10-27 Thread Peter Maydell
Move all the ID_AA64DFR* feature test functions together. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20231024163510.2972081-7-peter.mayd...@linaro.org --- target/arm/cpu-features.h | 10 +- 1 file changed, 5

[PULL 05/41] target/arm: Move ID_AA64MMFR0 tests up to before MMFR1 and MMFR2

2023-10-27 Thread Peter Maydell
Move the ID_AA64MMFR0 feature test functions up so they are before the ones for ID_AA64MMFR1 and ID_AA64MMFR2. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-id: 20231024163510.2972081-4-peter.mayd...@linaro.org ---

[PULL 41/41] hw/net/cadence_gem: enforce 32 bits variable size for CRC

2023-10-27 Thread Peter Maydell
From: Luc Michel The CRC was stored in an unsigned variable in gem_receive. Change it for a uint32_t to ensure we have the correct variable size here. Signed-off-by: Luc Michel Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: sai.pavan.bo...@amd.com Message-id:

  1   2   3   >