Re: [PATCH v2] block/snapshot: Fix compiler warning with -Wshadow=local

2023-11-06 Thread Cédric Le Goater
On 10/24/23 13:51, Thomas Huth wrote: On 24/10/2023 12.37, Markus Armbruster wrote: Markus Armbruster writes: Thomas Huth writes: No need to declare a new variable in the the inner code block here, we can re-use the "ret" variable that has been declared at the beginning of the function.

Re: [PATCH 0/2] Some biosbits avocado test fixes

2023-11-06 Thread Ani Sinha
> On 27-Oct-2023, at 8:51 AM, Ani Sinha wrote: > > Included are couple of bios bits test fixes. > 32-bit SMBIOS entry point is enforced. > Console logging is enabled. > > I have tested these changes in the CI pipeline here and the test seems > to pass: > >

Re: [PATCH] system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add()

2023-11-06 Thread Michael S. Tsirkin
On Fri, Nov 03, 2023 at 01:56:02PM +0300, Dmitrii Gavrilov wrote: > Original goal of addition of drain_call_rcu to qmp_device_add was to cover > the failure case of qdev_device_add. It seems call of drain_call_rcu was > misplaced in 7bed89958bfbf40df what led to waiting for pending RCU callbacks >

Re: [PATCH v6 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-11-06 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 07:15:10PM +, Alex Bennée wrote: > Lets keep a cleaner split between the base class and the derived > vhost-user-device which we can use for generic vhost-user stubs. This > includes an update to introduce the vq_size property so the number of > entries in a virtq can

Re: [PATCH] system/qdev-monitor: move drain_call_rcu call under if (!dev) in qmp_device_add()

2023-11-06 Thread Vladimir Sementsov-Ogievskiy
[add Michael] On 03.11.23 13:56, Dmitrii Gavrilov wrote: Original goal of addition of drain_call_rcu to qmp_device_add was to cover the failure case of qdev_device_add. It seems call of drain_call_rcu was misplaced in 7bed89958bfbf40df what led to waiting for pending RCU callbacks under happy

Re: [PATCH v8 23/24] hw/display/ati: allow compiling without PIXMAN

2023-11-06 Thread Marc-André Lureau
HI Zoltan On Tue, Nov 7, 2023 at 11:21 AM wrote: > > From: Marc-André Lureau > > Change the "x-pixman" property default value and use the fallback path > when PIXMAN support is disabled. > > Signed-off-by: Marc-André Lureau please review today :) thanks > --- > hw/display/ati.c | 16

[PATCH v8 03/24] ui: compile out some qemu-pixman functions when !PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Those functions require the PIXMAN library. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 7 +-- ui/qemu-pixman.c | 6 ++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git

[PATCH v8 14/24] vhost-user-gpu: skip VHOST_USER_GPU_UPDATE when !PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau This simply means that 2d drawing updates won't be handled, but 3d should work. Signed-off-by: Marc-André Lureau Acked-by: Michael S. Tsirkin --- hw/display/vhost-user-gpu.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vhost-user-gpu.c

[PATCH v8 11/24] qmp/hmp: disable screendump if PIXMAN is missing

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau The command requires color conversion and line-by-line feeding. We could have a simple fallback for simple formats though. Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- qapi/ui.json | 3 ++- ui/ui-hmp-cmds.c | 2

[PATCH v8 13/24] ui/console: when PIXMAN is unavailable, don't draw placeholder msg

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau When we can't draw text, simply show a blank display. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- ui/console.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/console.c b/ui/console.c index a72c495b5a..8e688d3569 100644 --- a/ui/console.c

[PATCH v8 22/24] hw/mips: FULOONG depends on VT82C686

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- hw/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/mips/Kconfig b/hw/mips/Kconfig index ac1eb06a51..66ec536e06 100644 --- a/hw/mips/Kconfig +++ b/hw/mips/Kconfig @@ -33,6 +33,7

[PATCH v8 17/24] ui/spice: SPICE/QXL requires PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build| 6 +- hw/display/Kconfig | 2 +- ui/meson.build | 10 +- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/meson.build b/meson.build index

[PATCH v8 12/24] virtio-gpu: replace PIXMAN for region/rect test

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Use a simpler implementation for rectangle geometry & intersect, drop the need for (more complex) PIXMAN functions. Signed-off-by: Marc-André Lureau Acked-by: Michael S. Tsirkin --- include/ui/rect.h | 59 +

[PATCH v8 05/24] vl: drop needless -spice checks

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Since commit 5324e3e958e ("qemu-options: define -spice only #ifdef CONFIG_SPICE"), it is unnecessary to check at runtime for "-spice" option. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 7 +-- 1 file changed, 1 insertion(+), 6

[PATCH v8 09/24] ui/console: allow to override the default VC

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau If a display is backed by a specialized VC, allow to override the default "vc:80Cx24C". As suggested by Paolo, if the display doesn't implement a VC (get_vc() returns NULL), use a fallback that will use a muxed console on stdio. This changes the behaviour of "qemu

[PATCH v8 24/24] build-sys: make pixman actually optional

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 3 --- 1 file changed, 3 deletions(-) diff --git a/meson.build b/meson.build index 8422e7da0c..4848930680 100644 --- a/meson.build +++ b/meson.build @@ -817,9 +817,6 @@ if not

[PATCH v8 16/24] ui/vnc: VNC requires PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build| 6 +- ui/meson.build | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 505cc591b9..3e60f42f94 100644 --- a/meson.build +++

[PATCH v8 20/24] arm/kconfig: XLNX_ZYNQMP_ARM depends on PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau The Display Port has some strong PIXMAN dependency. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- hw/arm/Kconfig | 3 ++- hw/display/Kconfig | 5 + hw/display/meson.build | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff

[PATCH v8 18/24] ui/gtk: -display gtk requires PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/meson.build b/meson.build index 0f578ddbf4..8422e7da0c 100644 --- a/meson.build +++ b/meson.build @@ -1531,7 +1531,11 @@

[PATCH v8 01/24] build-sys: add a "pixman" feature

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau For now, pixman is mandatory, but we set config_host.h and Kconfig. Once compilation is fixed, "pixman" will become actually optional. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- meson.build | 10 -- include/ui/qemu-pixman.h

[PATCH v8 23/24] hw/display/ati: allow compiling without PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Change the "x-pixman" property default value and use the fallback path when PIXMAN support is disabled. Signed-off-by: Marc-André Lureau --- hw/display/ati.c | 16 +++- hw/display/ati_2d.c| 11 +++ hw/display/meson.build | 2 +- 3 files

[PATCH v8 21/24] hw/sm501: allow compiling without PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Change the "x-pixman" property default value and use the fallback path when PIXMAN support is disabled. Signed-off-by: Marc-André Lureau Reviewed-by: BALATON Zoltan --- hw/display/sm501.c | 46 +- 1 file changed, 33

[PATCH v8 08/24] vl: move display early init before default devices

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau The next commit needs to have the display registered itself before creating the default VCs. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git

[PATCH v8 15/24] ui/gl: opengl doesn't require PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau The QEMU fallback covers the requirements. We still need the flags of header inclusion with CONFIG_PIXMAN. Signed-off-by: Marc-André Lureau --- ui/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index

[PATCH v8 10/24] ui/vc: console-vc requires PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Add stubs for the fallback paths. get_vc() now returns NULL by default if !PIXMAN. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- ui/console-vc-stubs.c | 33 + ui/console.c | 3 +++ ui/meson.build| 2

[PATCH v8 19/24] ui/dbus: do not require PIXMAN

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Implement a fallback path for region 2D update. Signed-off-by: Marc-André Lureau --- ui/dbus-listener.c | 90 -- ui/meson.build | 4 +-- 2 files changed, 65 insertions(+), 29 deletions(-) diff --git a/ui/dbus-listener.c

[PATCH v8 07/24] vl: simplify display_remote logic

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Bump the display_remote variable when the -vnc option is parsed, just like -spice. Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/system/vl.c b/system/vl.c index

[PATCH v8 04/24] ui: add pixman-minimal.h

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau This is a tiny subset of PIXMAN API that is used pervasively in QEMU codebase to manage images and identify the underlying format. It doesn't seems worth to wrap this in a QEMU-specific API. Signed-off-by: Marc-André Lureau Acked-by: Thomas Huth ---

[PATCH v8 00/24] Make Pixman an optional dependency

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Hi, QEMU system emulators can be made to compile and work without Pixman. Only a few devices and options actually require it (VNC, Gtk, Spice for ex) and will have to be compiled out. However, most of QEMU graphics-related code is based on pixman_image_t and format. If

[PATCH v8 06/24] qemu-options: define -vnc only #ifdef CONFIG_VNC

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- system/vl.c | 13 + ui/vnc-stubs.c | 12 qemu-options.hx | 2 ++ 3 files changed, 11 insertions(+), 16 deletions(-) diff --git a/system/vl.c b/system/vl.c index

[PATCH v8 02/24] build-sys: drop needless warning pragmas for old pixman

2023-11-06 Thread marcandre . lureau
From: Marc-André Lureau Since commit 236f282c1c7 ("configure: check for pixman-1 version"), QEMU requires >= 0.21.8. Suggested-by: Thomas Huth Signed-off-by: Marc-André Lureau Reviewed-by: Thomas Huth --- include/ui/qemu-pixman.h | 4 1 file changed, 4 deletions(-) diff --git

Re: [PATCH v6 1/6] virtio: split into vhost-user-base and vhost-user-device

2023-11-06 Thread Michael S. Tsirkin
On Mon, Nov 06, 2023 at 07:15:10PM +, Alex Bennée wrote: > Lets keep a cleaner split between the base class and the derived > vhost-user-device which we can use for generic vhost-user stubs. This > includes an update to introduce the vq_size property so the number of > entries in a virtq can

Re: [PATCH 24/29] plugins: add an API to read registers

2023-11-06 Thread Akihiko Odaki
On 2023/11/06 20:40, Alex Bennée wrote: Akihiko Odaki writes: (re-adding qemu-devel which my mail client dropped a few messages ago, sorry) On 2023/11/06 19:46, Alex Bennée wrote: Akihiko Odaki writes: On 2023/11/06 18:30, Alex Bennée wrote: Akihiko Odaki writes: On 2023/11/04 4:59,

Re: [PATCH] dump:Add close fd on error return to avoid resource leak

2023-11-06 Thread Marc-André Lureau
On Tue, Nov 7, 2023 at 10:07 AM Zongmin Zhou wrote: > > Signed-off-by: Zongmin Zhou Reviewed-by: Marc-André Lureau > --- > dump/dump.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/dump/dump.c b/dump/dump.c > index 1c304cadfd..ad5294e853 100644 > --- a/dump/dump.c > +++

Re: [PATCH v13 00/11] Add VIRTIO sound card

2023-11-06 Thread Manos Pitsidianakis
On Tue, 7 Nov 2023 at 02:44, Michael S. Tsirkin wrote: > > On Mon, Oct 23, 2023 at 03:03:17PM +0300, Manos Pitsidianakis wrote: > > This patch series adds an audio device implementing the recent virtio > > sound spec (1.2) and a corresponding PCI wrapper device. > > > Pls send patches on top to

[PATCH] dump:Add close fd on error return to avoid resource leak

2023-11-06 Thread Zongmin Zhou
Signed-off-by: Zongmin Zhou --- dump/dump.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dump/dump.c b/dump/dump.c index 1c304cadfd..ad5294e853 100644 --- a/dump/dump.c +++ b/dump/dump.c @@ -2160,6 +2160,7 @@ void qmp_dump_guest_memory(bool paging, const char *protocol, return;

[PATCH] Implementation of SJA1000 CAN-bus devices that support MSI (PCI capability 0x05). - Implementation of multiple MSI vector support for SJA1000 devices. - Added can_pcm26d2ca_pci.c; support for

2023-11-06 Thread Deniz Eren
Signed-off-by: Deniz Eren --- hw/net/can/can_pcm26d2ca_pci.c | 281 + hw/net/can/can_sja1000.c | 91 +++ hw/net/can/can_sja1000.h | 12 ++ hw/net/can/meson.build | 1 + 4 files changed, 385 insertions(+) create mode 100644

[PATCH] Fix Windows 2000 and XP HDAudio Support

2023-11-06 Thread Christopher Lentocha
Change the ID to be a Realtek ALC885 so that both Windows 2000 and up (including XP) and macOS (on a later patch for HDEF ACPI Fixes) support HDA HDA is supported for ALC885 on macOS AppleHDA.kext and 2K people can use the following file to get sound working (MD5sum):

Re: [PATCH 00/35] tcg patch queue

2023-11-06 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/49] riscv-to-apply queue

2023-11-06 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

[PATCH v2] tests/acpi/bios-tables-test: do not write new blobs unless there are changes

2023-11-06 Thread Ani Sinha
When dumping table blobs using rebuild-expected-aml.sh, table blobs from all test variants are dumped regardless of whether there are any actual changes to the tables or not. This creates lot of new files for various test variants that are not part of the git repository. This is because we do not

Re: [PULL 81/94] target/sparc: Move FDMULQ to decodetree

2023-11-06 Thread Richard Henderson
On 11/6/23 14:02, Mark Cave-Ayland wrote: I was working through my SPARC boot tests for your latest target/sparc series when I spotted a segfault on my FreeBSD SPARC64 image. A git bisect indicated that this was the patch that originally introduced the error, something I must have missed when

Re: [PATCH 07/22] tests/avocado: update the tcg_plugins test

2023-11-06 Thread Richard Henderson
On 11/6/23 10:50, Alex Bennée wrote: There are a number of things that are broken on the test currently so lets fix that up: - replace retired Debian kernel for tuxrun_baseline one - remove "detected repeat instructions test" since ea185a55 - log total counted instructions/memory

Re: [PATCH 03/22] target/arm: hide the 32bit version of PAR from gdbstub

2023-11-06 Thread Richard Henderson
On 11/6/23 10:50, Alex Bennée wrote: This is a slightly hacky way to avoid duplicate PAR's in the system register XML we send to gdb which causes an alias. However the other alternative would be to post process ARMCPRegInfo once all registers have been defined looking for textual duplicates. And

Re: [PATCH v2 0/2] virtio-blk: add iothread-vq-mapping parameter

2023-11-06 Thread Stefan Hajnoczi
On Thu, Nov 02, 2023 at 03:10:52PM +0100, Kevin Wolf wrote: > Am 18.09.2023 um 18:16 hat Stefan Hajnoczi geschrieben: > > virtio-blk and virtio-scsi devices need a way to specify the mapping between > > IOThreads and virtqueues. At the moment all virtqueues are assigned to a > > single > >

Re: [PATCH 04/22] target/arm: hide all versions of DBGD[RS]AR from gdbstub

2023-11-06 Thread Richard Henderson
On 11/6/23 10:50, Alex Bennée wrote: This avoids two duplicates being presented to gdbstub. As the registers are RAZ anyway it is unlikely their value would be of use to someone using gdbstub anyway. Signed-off-by: Alex Bennée Message-Id: <20231103195956.1998255-5-alex.ben...@linaro.org> ---

Re: [PATCH 01/22] default-configs: Add TARGET_XML_FILES definition

2023-11-06 Thread Richard Henderson
On 11/6/23 10:50, Alex Bennée wrote: From: Akihiko Odaki loongarch64-linux-user has references to XML files so include them. Fixes: d32688ecdb ("default-configs: Add loongarch linux-user support") Signed-off-by: Akihiko Odaki Message-Id: <20231030054834.39145-6-akihiko.od...@daynix.com>

[PULL 59/85] target/hppa: Use tcg_temp_new_i64 not tcg_temp_new

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 162 1 file changed, 82 insertions(+), 80 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 0024c38c84..c8c702ac03 100644 --- a/target/hppa/translate.c +++

[PULL 63/85] target/hppa: Implement HAVG

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/helper.h | 1 + target/hppa/insns.decode | 2 ++ target/hppa/op_helper.c | 14 ++ target/hppa/translate.c | 5 + 4 files changed, 22 insertions(+) diff --git a/target/hppa/helper.h b/target/hppa/helper.h index

[PULL 34/85] target/hppa: Pass d to do_unit_cond

2023-11-06 Thread Richard Henderson
Hoist the resolution of d up one level above do_unit_cond. All computations are logical, and are simplified by using a mask of the correct width, after which the result may be compared with zero. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 20 +++- 1 file

Re: [PATCH 23/29] plugins: Use different helpers when reading registers

2023-11-06 Thread Richard Henderson
On 11/3/23 12:59, Alex Bennée wrote: --- a/plugins/api.c +++ b/plugins/api.c @@ -89,7 +89,11 @@ void qemu_plugin_register_vcpu_tb_exec_cb(struct qemu_plugin_tb *tb, void *udata) { if (!tb->mem_only) { -

[PULL 78/85] target/hppa: Add unwind_breg to CPUHPPAState

2023-11-06 Thread Richard Henderson
Fill in the insn_start value during form_gva, and copy it out to the env field in hppa_restore_state_to_opc. The value is not yet consumed. Signed-off-by: Richard Henderson --- target/hppa/cpu.h | 8 +++- target/hppa/cpu.c | 1 + target/hppa/translate.c | 13 - 3

[PULL 61/85] target/hppa: Implement HADD

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/helper.h | 3 +++ target/hppa/insns.decode | 8 +++- target/hppa/op_helper.c | 32 target/hppa/translate.c | 37 + 4 files changed, 79 insertions(+), 1 deletion(-)

[PULL 36/85] target/hppa: Drop attempted gdbstub support for hppa64

2023-11-06 Thread Richard Henderson
There is no support for hppa64 in gdb. Any attempt to provide the data for the larger hppa64 registers results in an error from gdb. Mask CR_SAR writes to the width of the register: 5 or 6 bits. Signed-off-by: Richard Henderson --- target/hppa/gdbstub.c | 32 +--- 1

[PULL 43/85] target/hppa: Decode d for bb instructions

2023-11-06 Thread Richard Henderson
Manipulate the shift count so that the bit to be tested is always placed at the MSB. Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 4 ++-- target/hppa/translate.c | 6 ++ 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/target/hppa/insns.decode

[PULL 58/85] target/hppa: Adjust vmstate_env for pa2.0 tlb

2023-11-06 Thread Richard Henderson
Split out the tlb to a subsection so that it can be separately versioned -- the format is only partially following the architecture and is partially guided by the qemu implementation. Signed-off-by: Richard Henderson --- target/hppa/machine.c | 93 ++- 1

[PULL 55/85] target/hppa: Remove TARGET_REGISTER_BITS

2023-11-06 Thread Richard Henderson
Rely only on TARGET_LONG_BITS, fixed at 64, and hppa_is_pa20. Signed-off-by: Richard Henderson --- target/hppa/cpu-param.h | 1 - target/hppa/cpu.h| 50 --- target/hppa/helper.h | 51 +-- target/hppa/cpu.c| 2 +- target/hppa/helper.c | 32 +++

[PULL 70/85] target/hppa: Return zero for r0 from load_gpr

2023-11-06 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/hppa/translate.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index b04a5bc444..ba15cf6ab8 100644 --- a/target/hppa/translate.c +++

[PULL 67/85] target/hppa: Implement PERMH

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 2 ++ target/hppa/translate.c | 29 + 2 files changed, 31 insertions(+) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 22ec07f892..19e537df24 100644 ---

[PULL 64/85] target/hppa: Implement HSHL, HSHR

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 5 + target/hppa/translate.c | 35 +++ 2 files changed, 40 insertions(+) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 6959555bf3..bb5cd267b0 100644 ---

[PULL 69/85] target/hppa: Precompute zero into DisasContext

2023-11-06 Thread Richard Henderson
Reduce the number of times we look for the constant 0. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/hppa/translate.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/target/hppa/translate.c

[PULL 54/85] hw/hppa: Use uint32_t instead of target_ureg

2023-11-06 Thread Richard Henderson
The size of target_ureg is going to change. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- hw/hppa/machine.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 85682e6bab..1f09b4b490 100644 ---

[PULL 81/85] target/hppa: Improve interrupt logging

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/int_helper.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/target/hppa/int_helper.c b/target/hppa/int_helper.c index 54875442e7..467ee7daf5 100644 --- a/target/hppa/int_helper.c +++ b/target/hppa/int_helper.c @@

[PULL 66/85] target/hppa: Implement MIXH, MIXW

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 5 target/hppa/translate.c | 55 2 files changed, 60 insertions(+) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 87db726d9e..22ec07f892 100644 ---

[PULL 83/85] hw/pci-host/astro: Trigger CPU irq on CPU HPA in high memory

2023-11-06 Thread Richard Henderson
From: Helge Deller The CPU HPA is in the high F-region on PA2.0 CPUs, so use F_EXTEND() to trigger interrupt request at the right CPU HPA address. Note that the cpu_hpa value comes out of the IRT, which doesn't store the higher addresss bits. Signed-off-by: Helge Deller ---

[PULL 68/85] target/hppa: Fix interruption based on default PSW

2023-11-06 Thread Richard Henderson
From: Helge Deller The default PSW is set by the operating system with the PDC_PSW firmware call. Use that setting to decide if wide mode is to be enabled for interruptions and EIRR usage. Signed-off-by: Helge Deller Reviewed-by: Richard Henderson Signed-off-by: Richard Henderson ---

[PULL 41/85] target/hppa: Decode d for add instructions

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 16 target/hppa/translate.c | 21 +++-- 2 files changed, 19 insertions(+), 18 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index d4a03b0299..0f29869949 100644 ---

[PULL 56/85] target/hppa: Remove most of the TARGET_REGISTER_BITS redirections

2023-11-06 Thread Richard Henderson
Remove all but those intended to change type to or from i64. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 910 ++-- 1 file changed, 406 insertions(+), 504 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index

[PULL 85/85] hw/hppa: Allow C3700 with 64-bit and B160L with 32-bit CPU only

2023-11-06 Thread Richard Henderson
From: Helge Deller Prevent that users try to boot a 64-bit only C3700 machine with a 32-bit CPU, and to boot a 32-bit only B160L machine with a 64-bit CPU. Signed-off-by: Helge Deller --- hw/hppa/machine.c | 24 1 file changed, 24 insertions(+) diff --git

[PULL 42/85] target/hppa: Decode d for sub instructions

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 12 ++-- target/hppa/translate.c | 22 +++--- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 0f29869949..ad454adcbb 100644 ---

[PULL 47/85] target/hppa: Implement LDD, LDCD, LDDA, STD, STDA

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 15 +++ target/hppa/translate.c | 4 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 48f09c9b06..33eec3f4c3 100644 ---

[PULL 50/85] target/hppa: Implement SHRPD

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 6 ++- target/hppa/translate.c | 97 2 files changed, 72 insertions(+), 31 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 7b51f39b9e..6f0c3f6ea5 100644

[PULL 74/85] target/hppa: Implement pa2.0 data prefetch instructions

2023-11-06 Thread Richard Henderson
These are aliased onto the normal integer loads to %g0. Since we don't emulate caches, prefetch is a nop. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c

[PULL 44/85] target/hppa: Decode d for cmpb instructions

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 9 +++-- target/hppa/translate.c | 12 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index b185523021..fc327e2bb3 100644 ---

[PULL 49/85] target/hppa: Implement EXTRD

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 7 +-- target/hppa/translate.c | 42 +--- 2 files changed, 36 insertions(+), 13 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 12684b590e..7b51f39b9e

[PULL 45/85] target/hppa: Decode CMPIB double-word

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 10 -- target/hppa/translate.c | 11 ++- 2 files changed, 18 insertions(+), 3 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index fc327e2bb3..48f09c9b06 100644 ---

[PULL 51/85] target/hppa: Implement CLRBTS, POPBTS, PUSHBTS, PUSHNOM

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 2 ++ target/hppa/translate.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 6f0c3f6ea5..ba7731b517 100644 --- a/target/hppa/insns.decode +++

[PULL 71/85] include/hw/elf: Remove truncating signed casts

2023-11-06 Thread Richard Henderson
There's nothing about elf that specifically requires signed vs unsigned. This is very much a target-specific preference. In the meantime, casting low and high from uint64_t back to Elf_SWord to uint64_t discards high bits that might have been set by translate_fn. Signed-off-by: Richard Henderson

[PULL 53/85] target/hppa: Implement IDTLBT, IITLBT

2023-11-06 Thread Richard Henderson
Rename the existing insert tlb helpers to emphasize that they are for pa1.1 cpus. Implement a combined i/d tlb for pa2.0. Still missing is the new 'P' tlb bit. Signed-off-by: Richard Henderson --- target/hppa/helper.h | 6 ++-- target/hppa/insns.decode | 4 +++ target/hppa/mem_helper.c |

RE: [PATCH v4 30/41] vfio/iommufd: Add support for iova_ranges

2023-11-06 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Tuesday, November 7, 2023 1:19 AM >Subject: Re: [PATCH v4 30/41] vfio/iommufd: Add support for iova_ranges > >On 11/2/23 08:12, Zhenzhong Duan wrote: >> Some vIOMMU such as virtio-iommu use iova ranges from host side to >> setup

[PULL 30/85] target/hppa: Pass d to do_cond

2023-11-06 Thread Richard Henderson
Hoist the resolution of d up one level above do_cond. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 82 +++-- 1 file changed, 54 insertions(+), 28 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index

[PULL 75/85] target/hppa: Add pa2.0 cpu local tlb flushes

2023-11-06 Thread Richard Henderson
From: Helge Deller The previous decoding misnamed the bit it called "local". Other than the name, the implementation was correct for pa1.x. Rename this field to "tlbe". PA2.0 adds (a real) local bit to PxTLB, and also adds a range of pages to flush in GR[b]. Signed-off-by: Helge Deller

[PULL 00/85] target/hppa patch queue

2023-11-06 Thread Richard Henderson
The following changes since commit 3e01f1147a16ca566694b97eafc941d62fa1e8d8: Merge tag 'pull-sp-20231105' of https://gitlab.com/rth7680/qemu into staging (2023-11-06 09:34:22 +0800) are available in the Git repository at: https://gitlab.com/rth7680/qemu.git tags/pull-pa-20231106 for you

[PULL 82/85] hw/pci-host/astro: Map Astro chip into 64-bit I/O memory region

2023-11-06 Thread Richard Henderson
From: Helge Deller Map Astro into high F-region and add alias for 32-bit OS in low region. Signed-off-by: Helge Deller --- hw/pci-host/astro.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/pci-host/astro.c b/hw/pci-host/astro.c index 4b2d7caf2d..df61386bd9

[PULL 72/85] hw/hppa: Translate phys addresses for the cpu

2023-11-06 Thread Richard Henderson
Hack the machine to use pa2.0 physical layout when required, using the PSW.W=0 absolute to physical mapping. Signed-off-by: Richard Henderson --- hw/hppa/machine.c | 117 -- 1 file changed, 71 insertions(+), 46 deletions(-) diff --git

[PULL 80/85] target/hppa: Update IIAOQ, IIASQ for pa2.0

2023-11-06 Thread Richard Henderson
These registers have a different format for pa2.0. Signed-off-by: Richard Henderson --- target/hppa/int_helper.c | 46 target/hppa/sys_helper.c | 10 + 2 files changed, 38 insertions(+), 18 deletions(-) diff --git a/target/hppa/int_helper.c

[PULL 84/85] hw/hppa: Turn on 64-bit CPU for C3700 machine

2023-11-06 Thread Richard Henderson
From: Helge Deller Signed-off-by: Helge Deller --- hw/hppa/machine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index 43c7afb89d..da9ca85806 100644 --- a/hw/hppa/machine.c +++ b/hw/hppa/machine.c @@ -696,7 +696,7 @@ static void

[PULL 06/85] target/hppa: Populate an interval tree with valid tlb entries

2023-11-06 Thread Richard Henderson
Complete the data structure conversion started earlier. This reduces the perf overhead of hppa_get_physical_address from ~5% to ~0.25%. Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 24 +- target/hppa/cpu.c| 2 + target/hppa/machine.c| 51 -

[PULL 76/85] target/hppa: Avoid async_safe_run_on_cpu on uniprocessor system

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/mem_helper.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index 7132ea221c..602e6c809f 100644 --- a/target/hppa/mem_helper.c +++ b/target/hppa/mem_helper.c @@ -480,6

[PULL 57/85] target/hppa: Remove remaining TARGET_REGISTER_BITS redirections

2023-11-06 Thread Richard Henderson
The conversions to/from i64 can be eliminated entirely, folding computation into adjacent operations. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 46 - 1 file changed, 13 insertions(+), 33 deletions(-) diff --git

[PULL 40/85] target/hppa: Decode d for cmpclr instructions

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/insns.decode | 6 -- target/hppa/translate.c | 11 +-- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/target/hppa/insns.decode b/target/hppa/insns.decode index 03b1a11cac..d4a03b0299 100644 ---

[PULL 09/85] target/hppa: Remove load_const

2023-11-06 Thread Richard Henderson
Replace with tcg_constant_reg. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/hppa/translate.c | 21 +++-- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index

[PULL 65/85] target/hppa: Implement HSHLADD, HSHRADD

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/helper.h | 2 ++ target/hppa/insns.decode | 12 ++-- target/hppa/op_helper.c | 32 target/hppa/translate.c | 32 4 files changed, 76 insertions(+), 2 deletions(-)

Re: [PULL 00/35] tcg patch queue

2023-11-06 Thread Stefan Hajnoczi
ing changes since commit 3e01f1147a16ca566694b97eafc941d62fa1e8d8: > > > >Merge tag 'pull-sp-20231105' of https://gitlab.com/rth7680/qemu into > > staging (2023-11-06 09:34:22 +0800) > > > > are available in the Git repository at: > > > >https://gitlab.com/rth7680/q

[PULL 60/85] target/hppa: Replace tcg_gen_*_tl with tcg_gen_*_i64

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index c8c702ac03..1d749e2a78 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1338,10

[PULL 79/85] target/hppa: Create raise_exception_with_ior

2023-11-06 Thread Richard Henderson
Handle pa2.0 logic for filling in ISR+IOR. Signed-off-by: Richard Henderson --- target/hppa/mem_helper.c | 64 1 file changed, 51 insertions(+), 13 deletions(-) diff --git a/target/hppa/mem_helper.c b/target/hppa/mem_helper.c index

[PULL 73/85] linux-user/hppa: Drop EXCP_DUMP from handled exceptions

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/hppa/cpu_loop.c | 4 1 file changed, 4 deletions(-) diff --git a/linux-user/hppa/cpu_loop.c b/linux-user/hppa/cpu_loop.c index 8ab1335106..d5232f37fe 100644 --- a/linux-user/hppa/cpu_loop.c +++ b/linux-user/hppa/cpu_loop.c @@ -147,12 +147,10

[PULL 46/85] target/hppa: Decode ADDB double-word

2023-11-06 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/hppa/translate.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 7f767fea64..1b4fa401ba 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3143,6 +3143,17 @@

[PULL 23/85] target/hppa: Adjust hppa_cpu_dump_state for hppa64

2023-11-06 Thread Richard Henderson
Dump all 64 bits for pa2.0 and low 32 bits for pa1.x. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- target/hppa/helper.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/target/hppa/helper.c b/target/hppa/helper.c

[PULL 37/85] target/hppa: Remove TARGET_HPPA64

2023-11-06 Thread Richard Henderson
Allow both user-only and system mode to run pa2.0 cpus. Avoid creating a separate qemu-system-hppa64 binary; force the qemu-hppa binary to use TARGET_ABI32. Signed-off-by: Richard Henderson --- configs/targets/hppa-linux-user.mak | 1 + target/hppa/cpu-param.h | 23

  1   2   3   4   5   6   7   >