Re: [PATCH 1/1] hw/sd: Declare CPU QOM types using DEFINE_TYPES() macro

2023-11-08 Thread Philippe Mathieu-Daudé
On 31/10/23 09:31, Cédric Le Goater wrote: On 10/31/23 09:06, Philippe Mathieu-Daudé wrote: When multiple QOM types are registered in the same file, it is simpler to use the the DEFINE_TYPES() macro. In particular because type array declared with such macro are easier to review. Mechanical tran

Re: [PATCH 0/2] dump: Fix issues flagged by Coverity

2023-11-08 Thread Markus Armbruster
Stephen Brennan writes: > Markus Armbruster writes: >> Markus Armbruster (2): >> dump: Plug file descriptor leak on non-seekable file >> dump: Fix HMP dump-guest-memory -z without -R > > Hi Markus, > > I'm a bit late on the uptake here as these are already queued, but thank > you so much for

Re: [PATCH 6/8] docs/specs/virt-ctlr: Convert to rST

2023-11-08 Thread Philippe Mathieu-Daudé
On 31/10/23 16:43, Peter Maydell wrote: On Tue, 31 Oct 2023 at 15:39, Philippe Mathieu-Daudé wrote: On 27/9/23 17:12, Peter Maydell wrote: Convert docs/specs/virt-ctlr.txt to rST format. I added the name of the device to give readers a bit more idea of which device we're actually documenting

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Markus Armbruster
Cédric Le Goater writes: > Hello Markus, > > On 11/8/23 06:50, Markus Armbruster wrote: >> Cédric Le Goater writes: >> >>> On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Introduce an iommufd object which allows the interaction with the host /dev/iommu device. The

Re: [PATCH v4 0/4] hw/audio/pcspk: Inline pcspk_init()

2023-11-08 Thread Philippe Mathieu-Daudé
On 3/11/23 09:56, Markus Armbruster wrote: Bernhard Beschow writes: Am 20. Oktober 2023 17:15:04 UTC schrieb "Philippe Mathieu-Daudé" : Unfortunately v2 was merged as commit 40f8214fcd, so adapt v3 to clean the mess. Philippe Mathieu-Daudé (4): hw/i386/pc: Pass Error** argument to pc_basi

Re: [PATCH v3 1/1] hmp: synchronize cpu state for lapic info

2023-11-08 Thread Philippe Mathieu-Daudé
On 26/10/23 23:19, Dongli Zhang wrote: While the default "info lapic" always synchronizes cpu state ... mon_get_cpu() -> mon_get_cpu_sync(mon, true) -> cpu_synchronize_state(cpu) -> ioctl KVM_GET_LAPIC (taking KVM as example) ... the cpu state is not synchronized when the apic-id is

Re: [PATCH 69/71] util/fifo8: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:58, Richard Henderson wrote: Signed-off-by: Richard Henderson --- util/fifo8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 65/71] cpu-target: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:58, Richard Henderson wrote: Signed-off-by: Richard Henderson --- cpu-target.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 03/71] targt/arm: Constify hvf/hvf.c

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 12:54, Philippe Mathieu-Daudé wrote: On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson ---   target/arm/hvf/hvf.c | 13 -   1 file changed, 8 insertions(+), 5 deletions(-) Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé

Re: [PATCH 49/71] hw/rtc: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:58, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/rtc/allwinner-rtc.c | 2 +- hw/rtc/aspeed_rtc.c | 2 +- hw/rtc/ds1338.c | 2 +- hw/rtc/exynos4210_rtc.c | 2 +- hw/rtc/goldfish_rtc.c| 2 +- hw/rtc/ls7a_rtc.c| 2 +- hw/rtc/m48

Re: [PATCH 37/71] hw/isa: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/isa/apm.c | 2 +- hw/isa/i82378.c | 2 +- hw/isa/lpc_ich9.c | 8 hw/isa/pc87312.c | 2 +- hw/isa/piix.c | 8 hw/isa/vt82c686.c | 4 ++-- 6 files changed, 13 insertions(+), 13

Re: [PATCH 22/71] hw/adc: Constify VMState

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- hw/adc/aspeed_adc.c| 2 +- hw/adc/max111x.c | 2 +- hw/adc/npcm7xx_adc.c | 2 +- hw/adc/stm32f2xx_adc.c | 2 +- hw/adc/zynq-xadc.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) Rev

Re: [PATCH 07/71] target/hppa: Constify VMState in machine.c

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/hppa/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 06/71] target/cris: Constify VMState in machine.c

2023-11-08 Thread Philippe Mathieu-Daudé
On 6/11/23 07:57, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/cris/machine.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Cédric Le Goater
Hello Markus, On 11/8/23 06:50, Markus Armbruster wrote: Cédric Le Goater writes: On 11/2/23 08:12, Zhenzhong Duan wrote: From: Eric Auger Introduce an iommufd object which allows the interaction with the host /dev/iommu device. The /dev/iommu can have been already pre-opened outside of qem

Re: [PATCH] Fix Windows 2000 and XP HDAudio Support

2023-11-08 Thread Philippe Mathieu-Daudé
Thanks Christopher for your patch, I'm Cc'ing Volker and Gerd who know better this hardware model. On 7/11/23 20:27, Christopher Lentocha wrote: Change the ID to be a Realtek ALC885 so that both Windows 2000 and up (including XP) and macOS (on a later patch for HDEF ACPI Fixes) support HDA HDA

Re: [PATCH v1 1/9] linux-headers: Add KVM headers for loongarch

2023-11-08 Thread Cornelia Huck
On Wed, Nov 08 2023, xianglai li wrote: > From: zhaotianrui > > Update linux KVM headers about LoongArch KVM form linux > kernel. Mainly contains some KVM structures and macro > defines such as LoongArch KVM registers number, LoongArch > fpu structure, exit reason of LoongArch IOCSR, etc. > > Si

Re: [PATCH v4] virtio: add VIRTQUEUE_ERROR QAPI event

2023-11-08 Thread Vladimir Sementsov-Ogievskiy
ping :) On 17.10.23 15:39, Vladimir Sementsov-Ogievskiy wrote: For now we only log the vhost device error, when virtqueue is actually stopped. Let's add a QAPI event, which makes possible: - collect statistics of such errors - make immediate actions: take core dumps or do some other debuggi

Re: [PATCH v1 8/9] target/loongarch: Implement set vcpu intr for kvm

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 02:41, xianglai li wrote: From: Tianrui Zhao Implement loongarch kvm set vcpu interrupt interface, when a irq is set in vcpu, we use the KVM_INTERRUPT ioctl to set intr into kvm. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li --- target/loongarch/cpu.c | 18 +++

Re: [PATCH v2] coverity: physmem: use simple assertions instead of modelling

2023-11-08 Thread Vladimir Sementsov-Ogievskiy
ping) Is it queued? On 06.10.23 01:53, Paolo Bonzini wrote: On Thu, Oct 5, 2023 at 4:04 PM Vladimir Sementsov-Ogievskiy wrote: +/* + * Assure Coverity (and ourselves) that we are not going to OVERRUN + * the buffer by following ldn_he_p(). + */ +

Re: [PATCH v1 4/9] target/loongarch: Implement kvm get/set registers

2023-11-08 Thread Philippe Mathieu-Daudé
Hi Tianrui, Xianglai, On 8/11/23 02:41, xianglai li wrote: From: Tianrui Zhao Implement kvm_arch_get/set_registers interfaces, many regs can be get/set in the function, such as core regs, csr regs, fpu regs, mp state, etc. Signed-off-by: Tianrui Zhao Signed-off-by: xianglai li --- meson.b

RE: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Duan, Zhenzhong
>-Original Message- >From: Cédric Le Goater >Sent: Wednesday, November 8, 2023 5:41 PM >Subject: Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object > + hwaddr iova, ram_addr_t size) +{ +int ret; +struct iommu_ioas_

Re: [PATCH] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

2023-11-08 Thread Philippe Mathieu-Daudé
On 8/11/23 09:59, Thomas Huth wrote: When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-proto-common.h:10: In file included from /root/qemu/include/qemu/atomic128.h:62: /root/qe

Re: [PATCH v4 26/41] backends/iommufd: Introduce the iommufd object

2023-11-08 Thread Cédric Le Goater
+ hwaddr iova, ram_addr_t size) +{ +int ret; +struct iommu_ioas_unmap unmap = { +.size = sizeof(unmap), +.ioas_id = ioas_id, +.iova = iova, +.length = size, +}; + +ret = ioctl(be->fd, IOMMU_IOAS_UNMAP, &unmap); +trace

Re: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Cédric Le Goater
FYI, I first tried this vfio-8.2 branch on s390x but wasn't actually able to use the iommufd backend (was getting errors like Property 'vfio-pci.iommufd' not found) so I think something isn't actually enabling IOMMUFD as expected with your change... It looks CONFIG_IOMMUFD is recognized by Kcon

Re: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Cédric Le Goater
On 11/8/23 04:26, Matthew Rosato wrote: On 11/7/23 1:28 PM, Cédric Le Goater wrote: On 11/2/23 08:12, Zhenzhong Duan wrote: Hi, Thanks all for giving guides and comments on previous series, here is the v4 of pure iommufd support part. Based on Cédric's suggestion, this series includes an effo

RE: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Duan, Zhenzhong
>-Original Message- >From: Duan, Zhenzhong >Sent: Wednesday, November 8, 2023 4:38 PM >Subject: RE: [PATCH v4 00/41] vfio: Adopt iommufd > > > >>-Original Message- >>From: Matthew Rosato >>Sent: Wednesday, November 8, 2023 11:27 AM >>Subject: Re: [PATCH v4 00/41] vfio: Adopt iomm

Re: QEMU Virtio GPU features status & roadmap?

2023-11-08 Thread Antonio Caggiano
Hi Hans, +cc Gert and Dmitry On 17/10/2023 02:48, Hans de Ruiter wrote: Hi, I'm working on Virtio GPU drivers for AmigaOS, and would like to know what features are currently stable enough to use. Looking at the master QEMU branch, both Virgl and blob resources are supported, but NOT at the

[PATCH] host/include/generic/host/atomic128: Fix compilation problem with Clang 17

2023-11-08 Thread Thomas Huth
When compiling QEMU with Clang 17 on a s390x, the compilation fails: In file included from ../accel/tcg/cputlb.c:32: In file included from /root/qemu/include/exec/helper-proto-common.h:10: In file included from /root/qemu/include/qemu/atomic128.h:62: /root/qemu/host/include/generic/host/atomic128-

Re: [PATCH 1/4] dump: Set dump info function pointers to NULL

2023-11-08 Thread Janosch Frank
On 11/8/23 09:03, Marc-André Lureau wrote: Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: Better to not rely on the struct zeroing since NULL is not necessarily 0. Signed-off-by: Janosch Frank --- dump/dump.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dump/dump.c b/du

RE: [PATCH v4 00/41] vfio: Adopt iommufd

2023-11-08 Thread Duan, Zhenzhong
>-Original Message- >From: Matthew Rosato >Sent: Wednesday, November 8, 2023 11:27 AM >Subject: Re: [PATCH v4 00/41] vfio: Adopt iommufd > >On 11/7/23 1:28 PM, Cédric Le Goater wrote: >> On 11/2/23 08:12, Zhenzhong Duan wrote: >>> Hi, >>> >>> Thanks all for giving guides and comments on

Re: [PATCH 4/4] target/s390x/arch_dump: Add arch cleanup function for PV dumps

2023-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: > > PV dumps block vcpu runs until dump end is reached. If there's an > error between PV dump init and PV dump end the vm will never be able > to run again. One example of such an error is insufficient disk space > for the dump file. > > Let'

Re: [PATCH 2/4] target/s390x/dump: Remove unneeded dump info function pointer init

2023-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: > > dump_state_prepare() now sets the fucntion pointers to NULL so we only function > need to touch them if we're going to use them. > > Signed-off-by: Janosch Frank regardless if the previous patch is applied, this patch lgtm Reviewed-b

Re: [PATCH 2/2] dump: Fix HMP dump-guest-memory -z without -R

2023-11-08 Thread Marc-André Lureau
On Wed, Nov 8, 2023 at 9:38 AM Markus Armbruster wrote: > > -z without -R has no effect: the dump format remains @elf. Fix the > logic error so it becomes @kdump-zlib. > > Fixes: e6549197f7ed (dump: Add command interface for kdump-raw formats) > Fixes: CID 1523841 > Signed-off-by: Markus Armbrust

Re: [PATCH 1/4] dump: Set dump info function pointers to NULL

2023-11-08 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2023 at 6:22 PM Janosch Frank wrote: > > Better to not rely on the struct zeroing since NULL is not necessarily > 0. > > Signed-off-by: Janosch Frank > --- > dump/dump.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/dump/dump.c b/dump/dump.c > index d355ada62e..1

<    1   2