[PATCH v2 0/3] Hexagon (target/hexagon) Use QEMU decodetree

2024-01-15 Thread Taylor Simpson
Replace the old Hexagon dectree.py with QEMU decodetree Changes in v2 Suggested Python improvements from Brian Cain Taylor Simpson (3): Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions) Hexagon (target/hexagon) Use QEMU decodetree (16-bit instructions) Hexagon

[PATCH v2 3/3] Hexagon (target/hexagon) Remove old dectree.py

2024-01-15 Thread Taylor Simpson
Now that we are using QEMU decodetree.py, remove the old decoder Signed-off-by: Taylor Simpson Reviewed-by: Brian Cain --- target/hexagon/opcodes.h| 2 - target/hexagon/decode.c | 344 target/hexagon/gen_dectree_import.c | 49

[PATCH v2 1/3] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions)

2024-01-15 Thread Taylor Simpson
The Decodetree Specification can be found here https://www.qemu.org/docs/master/devel/decodetree.html Covers all 32-bit instructions, including HVX We generate separate decoders for each instruction class. The reason will be more apparent in the next patch in this series. We add 2 new scripts

Re: [PATCH] linux-user: Fixed cpu restore with pc 0 on SIGBUS

2024-01-15 Thread Richard Henderson
On 1/13/24 07:57, Robbin Ehn wrote: Commit f4e1168198 (linux-user: Split out host_sig{segv,bus}_handler) introduced a bug, when returning from host_sigbus_handler the PC is never set. Thus cpu_loop_exit_restore is called with a zero PC and we immediate get a SIGSEGV. Signed-off-by: Robbin Ehn

Re: [PATCH v2 0/2] tcg: Jump after always false condition

2024-01-15 Thread Richard Henderson
On 12/20/23 05:22, Samuel Tardieu wrote: Unreachable code in an error handling block is listed in issue https://gitlab.com/qemu-project/qemu/-/issues/2030. After removing this code, the `fail` label is now immediately followed by a test whose condition can never be true when coming explicitly

RE: [PATCH v2 1/3] Hexagon (target/hexagon) Use QEMU decodetree (32-bit instructions)

2024-01-15 Thread ltaylorsimpson
> -Original Message- > From: Brian Cain > Sent: Sunday, January 14, 2024 5:21 PM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: Matheus Bernardino (QUIC) ; Sid > Manning ; Marco Liebel (QUIC) > ; richard.hender...@linaro.org; > phi...@linaro.org; a...@rev.ng; a...@rev.ng > Subject:

Re: [PATCH v2 03/19] qapi: create QAPISchemaDefinition

2024-01-15 Thread John Snow
On Mon, Jan 15, 2024 at 8:16 AM Markus Armbruster wrote: > > John Snow writes: > > > Include entities don't have names, but we generally expect "entities" to > > have names. Reclassify all entities with names as *definitions*, leaving > > the nameless include entities as QAPISchemaEntity

[PATCH 1/2] target/s390x: Emulate CVDG

2024-01-15 Thread Ilya Leoshkevich
CVDG is the same as CVD, except that it converts 64 bits into 128, rather than 32 into 64. Use larger data types in the CVD helper and reuse it. Reported-by: Ido Plat Signed-off-by: Ilya Leoshkevich --- target/s390x/helper.h| 1 + target/s390x/tcg/insn-data.h.inc | 1 +

[PATCH 2/2] tests/tcg/s390x: Test CONVERT TO DECIMAL

2024-01-15 Thread Ilya Leoshkevich
Check the CVD's and CVDG's corner cases. Signed-off-by: Ilya Leoshkevich --- tests/tcg/s390x/Makefile.target | 1 + tests/tcg/s390x/cvd.c | 42 + 2 files changed, 43 insertions(+) create mode 100644 tests/tcg/s390x/cvd.c diff --git

[PATCH 0/2] target/s390x: Emulate CVDG

2024-01-15 Thread Ilya Leoshkevich
Hi, Ido reported that we are missing the CVDG emulation (which is very similar to the existing CVD emulation). This series adds it along with a test. Best regards, Ilya Ilya Leoshkevich (2): target/s390x: Emulate CVDG tests/tcg/s390x: Test CONVERT TO DECIMAL target/s390x/helper.h

Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx()

2024-01-15 Thread Richard Henderson
On 1/16/24 04:57, Daniel Henrique Barboza wrote: I am now wondering if this is worth the trouble, and we should instead do: +    int vlmax = cpu->cfg.vlenb >> (s->sew - s->lmul); Like we're already doing in patch 9. Patch 12 would be a similar case. This is more like what I expected to see.

Re: [PATCH v2 01/19] qapi: sort pylint suppressions

2024-01-15 Thread John Snow
On Mon, Jan 15, 2024 at 7:18 AM Markus Armbruster wrote: > > John Snow writes: > > > Suggested-by: Markus Armbruster > > Signed-off-by: John Snow > > --- > > scripts/qapi/pylintrc | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/scripts/qapi/pylintrc

Re: [RFC PATCH v3 00/30] migration: File based migration with multifd and fixed-ram

2024-01-15 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Jan 11, 2024 at 03:38:31PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Mon, Nov 27, 2023 at 05:25:42PM -0300, Fabiano Rosas wrote: >> >> Hi, >> >> >> >> In this v3: >> >> >> >> Added support for the "file:/dev/fdset/" syntax to receive multiple >> >>

Re: [PATCH 3/3] tests/acpi: Update virt/SSDT.memhp

2024-01-15 Thread Laszlo Ersek
On 1/15/24 15:46, Bin Meng wrote: > On Mon, Jan 15, 2024 at 7:40 PM Alex Bennée wrote: >> >> Bin Meng writes: >> >>> The Arm dtb changes caused an address change: >>> >>> DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) >>> { >>> [ ... ] >>> -Name (MEMA, 0x43C8) >>>

Re: [PATCH] coroutine-ucontext: Save fake stack for pooled coroutine

2024-01-15 Thread Stefan Hajnoczi
On Fri, Jan 12, 2024 at 07:36:19PM +0900, Akihiko Odaki wrote: > Coroutine may be pooled even after COROUTINE_TERMINATE if > CONFIG_COROUTINE_POOL is enabled and fake stack should be saved in > such a case to keep AddressSanitizerUseAfterReturn working. Even worse, > I'm seeing stack corruption

Re: [RFC PATCH v3 11/30] migration/multifd: Allow multifd without packets

2024-01-15 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Nov 27, 2023 at 05:25:53PM -0300, Fabiano Rosas wrote: >> For the upcoming support to the new 'fixed-ram' migration stream >> format, we cannot use multifd packets because each write into the >> ramblock section in the migration file is expected to contain only the >>

[PATCH v2 1/3] hw/arm: Add EHCI/OHCI controllers to Allwinner R40 and Bananapi board

2024-01-15 Thread Guenter Roeck
Allwinner R40 supports two USB host ports shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. Add support for both of them. If machine USB support is not enabled, create unimplemented devices for the USB memory ranges to avoid crashes when booting Linux.

[PATCH v2 2/3] hw/arm: Add AHCI/SATA controller to Allwinner R40 and Bananapi board

2024-01-15 Thread Guenter Roeck
Allwinner R40 supports an AHCI compliant SATA controller. Add support for it. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Guenter Roeck --- docs/system/arm/bananapi_m2u.rst | 1 + hw/arm/Kconfig | 1 + hw/arm/allwinner-r40.c | 12 +++-

[PATCH v2 3/3] hw/arm: Add watchdog timer to Allwinner H40 and Bananapi board

2024-01-15 Thread Guenter Roeck
Add watchdog timer support to Allwinner-H40 and Bananapi. The watchdog timer is added as an overlay to the Timer module memory map. Signed-off-by: Guenter Roeck --- docs/system/arm/bananapi_m2u.rst | 2 +- hw/arm/Kconfig | 1 + hw/arm/allwinner-r40.c | 8

[PATCH v2 0/3] hw/arm: Add support for USB, SATA, and watchdog to Allwinner R40

2024-01-15 Thread Guenter Roeck
Add support for - USB 2.0 EHCI/OHCI - SATA/AHCI - Watchdog to Allwinner R40. The hardware is quite similar to Allwinner A10 and H3, so the code is derived from the implementations for those SOCs. Tested with bpim2u emulation by instantiating EHCI and OHCI keyboards, by booting from USB, by

Re: [PATCH 1/2] hw/arm/allwinner-a10: Unconditionally map the USB Host controllers

2024-01-15 Thread Guenter Roeck
On Mon, Jan 15, 2024 at 05:56:14PM +0100, Philippe Mathieu-Daudé wrote: > The USB Controllers are part of the chipset, thus are > always present and mapped in memory. > > Reported-by: Guenter Roeck > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Guenter Roeck Tested-by: Guenter Roeck

Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-15 Thread Daniel P . Berrangé
On Mon, Jan 15, 2024 at 05:39:19PM +, Peter Maydell wrote: > On Mon, 15 Jan 2024 at 13:54, Thomas Huth wrote: > > > > On 12/01/2024 16.39, Philippe Mathieu-Daudé wrote: > > > Hi Thomas > > > > > > +Laurent & Peter > > > > > > On 12/1/24 11:00, Thomas Huth wrote: > > >> It's been marked as

Re: [PATCH 11/13] trans_rvv.c.inc: remove vlmax arg from vec_element_loadx()

2024-01-15 Thread Daniel Henrique Barboza
On 1/12/24 19:51, Richard Henderson wrote: On 1/13/24 08:38, Daniel Henrique Barboza wrote: Signed-off-by: Daniel Henrique Barboza ---   target/riscv/insn_trans/trans_rvv.c.inc | 26 +   1 file changed, 18 insertions(+), 8 deletions(-) diff --git

Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-15 Thread Peter Maydell
On Mon, 15 Jan 2024 at 13:54, Thomas Huth wrote: > > On 12/01/2024 16.39, Philippe Mathieu-Daudé wrote: > > Hi Thomas > > > > +Laurent & Peter > > > > On 12/1/24 11:00, Thomas Huth wrote: > >> It's been marked as deprecated since QEMU 8.1, so it should be fine > >> to remove this now. > >> > >>

Re: [PATCH] hw/char/imx_serial: Implement receive FIFO and ageing timer for imx serial.

2024-01-15 Thread Peter Maydell
On Thu, 11 Jan 2024 at 13:33, Rayhan Faizel wrote: > > This patch implements a 32 half word FIFO as per imx serial device > specifications. If a non empty FIFO is below the trigger level, an ageing > timer will tick for a duration of 8 characters. On expiry, AGTIM will be set > triggering an

Re: [PATCH] tests/docker: Hexagon toolchain update

2024-01-15 Thread Matheus Tavares Bernardino
On Sun, 14 Jan 2024 15:23:54 -0800 Brian Cain wrote: > > This update includes support for privileged instructions. > > Signed-off-by: Brian Cain > --- Reviewed-by: Matheus Tavares Bernardino Tested-by: Matheus Tavares Bernardino > diff --git

Re: [PATCH 1/3] hw/arm: Add EHCI/OHCI controllers to Allwinner R40 and Bananapi board

2024-01-15 Thread Guenter Roeck
On 1/15/24 08:30, Philippe Mathieu-Daudé wrote: On 15/1/24 17:12, Guenter Roeck wrote: On 1/15/24 03:02, Philippe Mathieu-Daudé wrote: Hi, On 13/1/24 20:16, Guenter Roeck wrote: Allwinner R40 supports two USB host ports shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host

Re: [PATCH v3] load_elf: fix iterator's type for elf file processing

2024-01-15 Thread Peter Maydell
On Mon, 15 Jan 2024 at 09:22, Anastasia Belova wrote: > > j is used while loading an ELF file to byteswap segments' > data. If data is larger than 2GB an overflow may happen. > So j should be elf_word. > > This commit fixes a minor bug, maybe even a typo. > > Found by Linux Verification Center

Re: [PATCH v2 0/2] tcg: Jump after always false condition

2024-01-15 Thread Peter Maydell
On Tue, 19 Dec 2023 at 18:23, Samuel Tardieu wrote: > > Unreachable code in an error handling block is listed in issue > https://gitlab.com/qemu-project/qemu/-/issues/2030. > > After removing this code, the `fail` label is now immediately followed > by a test whose condition can never be true

Re: [PATCH 0/2] hw/arm: Unconditionally map MMIO-based USB host controllers

2024-01-15 Thread Peter Maydell
On Mon, 15 Jan 2024 at 16:56, Philippe Mathieu-Daudé wrote: > > When a chipset contain a USB controller, we can not simply > remove it. We could disable it, but that requires more changes > this series isn't aiming for. For more context: >

[PATCH 1/2] hw/arm/allwinner-a10: Unconditionally map the USB Host controllers

2024-01-15 Thread Philippe Mathieu-Daudé
The USB Controllers are part of the chipset, thus are always present and mapped in memory. Reported-by: Guenter Roeck Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/allwinner-a10.c | 49 +- 1 file changed, 20 insertions(+), 29 deletions(-) diff --git

[PATCH 0/2] hw/arm: Unconditionally map MMIO-based USB host controllers

2024-01-15 Thread Philippe Mathieu-Daudé
When a chipset contain a USB controller, we can not simply remove it. We could disable it, but that requires more changes this series isn't aiming for. For more context: https://lore.kernel.org/qemu-devel/56fde49f-7dc6-4f8e-9bbf-0336a20a9...@roeck-us.net/ Philippe Mathieu-Daudé (2):

[PATCH 2/2] hw/arm/nseries: Unconditionally map the TUSB6010 USB Host controller

2024-01-15 Thread Philippe Mathieu-Daudé
The TUSB6010 USB controller is solderer on the N800 and N810 tablets, thus is always present. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/nseries.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/arm/nseries.c b/hw/arm/nseries.c index 35aff46b4b..35deb74f65 100644

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-15 Thread Peter Maydell
On Mon, 15 Jan 2024 at 13:51, Shlomo Pongratz wrote: > > On 15/01/2024 12:37, Peter Maydell wrote: > > For instance, the kernel code suggests that pre-460A > > there's a 32 bit limit register, and post-460A there > > is a 64-bit limit (with an "UPPER_LIMIT" register to > > access the top 32

Re: [RFC PATCH v3 09/30] migration/ram: Add incoming 'fixed-ram' migration

2024-01-15 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Nov 27, 2023 at 05:25:51PM -0300, Fabiano Rosas wrote: >> Add the necessary code to parse the format changes for the 'fixed-ram' >> capability. >> >> One of the more notable changes in behavior is that in the 'fixed-ram' >> case ram pages are restored in one go rather

Call for GSoC/Outreachy internship project ideas

2024-01-15 Thread Stefan Hajnoczi
Dear QEMU and KVM communities, QEMU will apply for the Google Summer of Code and Outreachy internship programs again this year. Regular contributors can submit project ideas that they'd like to mentor by replying to this email before January 30th. Internship programs ---

Re: [PATCH 1/3] hw/arm: Add EHCI/OHCI controllers to Allwinner R40 and Bananapi board

2024-01-15 Thread Philippe Mathieu-Daudé
On 15/1/24 17:12, Guenter Roeck wrote: On 1/15/24 03:02, Philippe Mathieu-Daudé wrote: Hi, On 13/1/24 20:16, Guenter Roeck wrote: Allwinner R40 supports two USB host ports shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. Add support for both of them. If

[PATCH 2/2] target/riscv: Check 'A' and split extensions for atomic instructions

2024-01-15 Thread Rob Bradford
Following the pattern for 'M' and Zmmul check if either the 'A' extension is enabled or the appropriate split extension for the instruction. Also remove the assumption that only checking for 64-bit systems is required for the double word variants. Signed-off-by: Rob Bradford ---

[PATCH 1/2] target/riscv: Add Zaamo and Zalrsc extensions

2024-01-15 Thread Rob Bradford
These extensions represent the atomic operations from A (Zaamo) and the Load-Reserved/Store-Conditional operations from A (Zalrsc) Signed-off-by: Rob Bradford --- target/riscv/cpu.c | 5 + target/riscv/cpu_cfg.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/target/riscv/cpu.c

[PATCH 0/2] target/riscv: Add support for Zaamo & Zalrsc

2024-01-15 Thread Rob Bradford
Introduce support for the proposed new (fast-track) Zaamo and Zalrsc extensions [1] which represent the AMO and LR/SC subsets of the A extension. The motivation for the subsets being available separately is that certain classes of CPUs may choose to only implement a subset for architectural

Re: [PATCH 02/11] hw/core: Cleanup unused included headers in cpu-common.c

2024-01-15 Thread Zhao Liu
On Mon, Jan 15, 2024 at 05:07:52PM +0100, Philippe Mathieu-Daudé wrote: > Date: Mon, 15 Jan 2024 17:07:52 +0100 > From: Philippe Mathieu-Daudé > Subject: Re: [PATCH 02/11] hw/core: Cleanup unused included headers in > cpu-common.c > > On 15/1/24 15:45, Zhao Liu wrote: > > Hi Peter, > > > > On

Re: [PATCH] Fixed '-serial none' usage breaks following '-serial ...' usage

2024-01-15 Thread Peter Maydell
(I've cc'd a few people who might have opinions on possible command-line compatibility breakage.) On Wed, 10 Jan 2024 at 14:38, Bohdan Kostiv wrote: > > Hello, > > I have faced an issue in using serial ports when I need to skip a couple of > ports in the CLI. > > For example the ARM machine

Re: [PATCH 1/3] hw/arm: Add EHCI/OHCI controllers to Allwinner R40 and Bananapi board

2024-01-15 Thread Guenter Roeck
On 1/15/24 03:02, Philippe Mathieu-Daudé wrote: Hi, On 13/1/24 20:16, Guenter Roeck wrote: Allwinner R40 supports two USB host ports shared between a USB 2.0 EHCI host controller and a USB 1.1 OHCI host controller. Add support for both of them. If machine USB support is not enabled, create

Re: [PATCH 02/11] hw/core: Cleanup unused included headers in cpu-common.c

2024-01-15 Thread Philippe Mathieu-Daudé
On 15/1/24 15:45, Zhao Liu wrote: Hi Peter, On Mon, Jan 15, 2024 at 10:41:48AM +, Peter Maydell wrote: Date: Mon, 15 Jan 2024 10:41:48 + From: Peter Maydell Subject: Re: [PATCH 02/11] hw/core: Cleanup unused included headers in cpu-common.c On Mon, 15 Jan 2024 at 09:37, Zhao Liu

Re: [PATCH v3 0/2] block: commit/stream: Allow users to request only format driver names in backing file format

2024-01-15 Thread Kevin Wolf
Am 05.12.2023 um 18:14 hat Peter Krempa geschrieben: > Please see patches for rationale. > > Libvirt patches using this new flag will be posted soon-ish (after > cleanup). > > v3: > - changed name of flag to 'backing-mask-protocol' (Eric) > - decided to keep Vladimir's R-b as he requested

[PATCH 1/2] virtio-gpu: remove needless condition

2024-01-15 Thread marcandre . lureau
From: Marc-André Lureau qemu_create_displaysurface_pixman() never returns NULL. Signed-off-by: Marc-André Lureau --- hw/display/virtio-gpu.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/display/virtio-gpu.c b/hw/display/virtio-gpu.c index f8a675eb30..a62ffb1627 100644 ---

[PATCH 0/2] virtio-gpu: fix blob scanout post-load

2024-01-15 Thread marcandre . lureau
From: Marc-André Lureau Hi, The current post-loading code for scanout has a FIXME: it doesn't take the resource region/rect into account. But there is more, when adding blob migration support in commit f66767f75c9, I didn't realize that blob resources could be used for scanouts. This situationn

[PATCH 2/2] virtio-gpu: fix scanout migration post-load

2024-01-15 Thread marcandre . lureau
From: Marc-André Lureau The current post-loading code for scanout has a FIXME: it doesn't take the resource region/rect into account. But there is more, when adding blob migration support in commit f66767f75c9, I didn't realize that blob resources could be used for scanouts. This situationn

Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F]

2024-01-15 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 03:16:43PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 15:16:43 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 08/16] i386: Expose module level in CPUID[0x1F] > > On 1/15/2024 2:35 PM, Zhao Liu wrote: > > On Mon, Jan 15, 2024 at 02:11:17PM +0800,

Re: [PATCH v4 00/45] Raspberry Pi 4B machine

2024-01-15 Thread Peter Maydell
On Tue, 19 Dec 2023 at 16:11, Peter Maydell wrote: > > On Fri, 8 Dec 2023 at 02:32, Sergey Kambalin wrote: > > > > Introducing Raspberry Pi 4B model. > > It contains new BCM2838 SoC, PCIE subsystem, > > RNG200, Thermal sensor and Genet network controller. > > > > It can work with recent linux

Re: [PATCH v4 32/45] Enable BCM2838 GENET controller

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:35, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_peripherals.c | 16 > hw/arm/raspi4b.c | 17 - > include/hw/arm/bcm2838_peripherals.h | 2 ++ > 3 files changed, 18

Re: [PATCH] string-output-visitor: Fix (pseudo) struct handling

2024-01-15 Thread Kevin Wolf
Am 11.01.2024 um 12:45 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > > Commit ff32bb53 tried to get minimal struct support into the string > > output visitor by just making it return "". Unfortunately, it > > forgot that the caller will still make more visitor calls for the > >

Re: [PATCH v4 43/45] Add missed BCM2835 properties

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:36, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/misc/bcm2835_property.c | 47 > include/hw/arm/raspberrypi-fw-defs.h | 12 ++- > 2 files changed, 58 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU

2024-01-15 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 03:45:58PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 15:45:58 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 10/16] i386/cpu: Introduce cluster-id to X86CPU > > On 1/15/2024 1:59 PM, Zhao Liu wrote: > > (Also cc "machine core" maintainers.) > > >

Re: [PATCH v4 45/45] Add RPi4B to paspi4.rst

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:40, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > docs/system/arm/raspi.rst | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) Typo in the commit message subject. Otherwise Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 40/45] Add mailbox property tests. Part 1

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:35, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.c| 34 ++-- > tests/qtest/bcm2838-mailbox.h| 18 +- > tests/qtest/bcm2838-mbox-property-test.c | 206 +++ >

Re: [PATCH v4 37/45] Add mailbox tests tags. Part 1

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:38, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.h | 195 +- > 1 file changed, 190 insertions(+), 5 deletions(-) > > diff --git a/tests/qtest/bcm2838-mailbox.h

Re: [PATCH v4 36/45] Add mailbox test constants

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:36, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > tests/qtest/bcm2838-mailbox.h | 139 ++ > 1 file changed, 139 insertions(+) > > diff --git a/tests/qtest/bcm2838-mailbox.h b/tests/qtest/bcm2838-mailbox.h > index

Re: [PATCH v4 35/45] Add mailbox test stub

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:36, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > include/hw/arm/bcm2838_peripherals.h | 2 + > tests/qtest/bcm2838-mailbox.c| 71 > tests/qtest/bcm2838-mailbox.h| 46 ++ >

Re: [RFC PATCH v3 08/30] migration/ram: Add outgoing 'fixed-ram' migration

2024-01-15 Thread Fabiano Rosas
Peter Xu writes: > On Mon, Nov 27, 2023 at 05:25:50PM -0300, Fabiano Rosas wrote: >> From: Nikolay Borisov >> >> Implement the outgoing migration side for the 'fixed-ram' capability. >> >> A bitmap is introduced to track which pages have been written in the >> migration file. Pages are

Re: [PATCH v4 33/45] Connect RNG200, PCIE and GENET to GIC

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:34, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838.c | 19 +++ > include/hw/arm/bcm2838_peripherals.h | 2 ++ > 2 files changed, 21 insertions(+) > > diff --git a/hw/arm/bcm2838.c b/hw/arm/bcm2838.c

Re: [PATCH 3/3] tests/acpi: Update virt/SSDT.memhp

2024-01-15 Thread Bin Meng
On Mon, Jan 15, 2024 at 7:40 PM Alex Bennée wrote: > > Bin Meng writes: > > > The Arm dtb changes caused an address change: > > > > DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) > > { > > [ ... ] > > -Name (MEMA, 0x43C8) > > +Name (MEMA, 0x43D8) > > } >

Re: [PATCH] Reduce scope of def_regnum, remove dead assignment

2024-01-15 Thread Matheus Tavares Bernardino
On Sun, 14 Jan 2024 15:44:53 -0800 Brian Cain wrote: > > This is intended to address a coverity finding: CID 1527408. > > Signed-off-by: Brian Cain > --- Reviewed-by: Matheus Tavares Bernardino

Re: [PATCH v4 21/45] Add clock_isp stub

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:40, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_peripherals.c | 6 ++ > include/hw/arm/bcm2838_peripherals.h | 1 + > 2 files changed, 7 insertions(+) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v4 20/45] Implement BCM2838 thermal sensor

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_peripherals.c | 27 ++-- > hw/arm/raspi4b.c | 1 - > hw/misc/bcm2838_thermal.c| 98 > hw/misc/meson.build

Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode CPUID[4]

2024-01-15 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 03:00:25PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 15:00:25 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 14/16] i386: Use CPUCacheInfo.share_level to encode > CPUID[4] > > On 1/15/2024 2:25 PM, Zhao Liu wrote: > > Hi Xiaoyao, > > > > On Mon,

Re: [PATCH v7 15/16] i386: Use offsets get NumSharingCache for CPUID[0x8000001D].EAX[bits 25:14]

2024-01-15 Thread Zhao Liu
Hi Xiaoyao, On Mon, Jan 15, 2024 at 12:27:43PM +0800, Xiaoyao Li wrote: > Date: Mon, 15 Jan 2024 12:27:43 +0800 > From: Xiaoyao Li > Subject: Re: [PATCH v7 15/16] i386: Use offsets get NumSharingCache for > CPUID[0x801D].EAX[bits 25:14] > > On 1/15/2024 11:48 AM, Zhao Liu wrote: > > Hi

Re: [PATCH v4 19/45] Get rid of RNG200 timer

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:34, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin The commit message doesn't seem to match the changes here. > --- > hw/arm/bcm2838_peripherals.c | 14 + > hw/arm/raspi4b.c | 1 - > hw/misc/bcm2838_rng200.c | 78

Re: [PATCH 02/11] hw/core: Cleanup unused included headers in cpu-common.c

2024-01-15 Thread Zhao Liu
Hi Peter, On Mon, Jan 15, 2024 at 10:41:48AM +, Peter Maydell wrote: > Date: Mon, 15 Jan 2024 10:41:48 + > From: Peter Maydell > Subject: Re: [PATCH 02/11] hw/core: Cleanup unused included headers in > cpu-common.c > > On Mon, 15 Jan 2024 at 09:37, Zhao Liu wrote: > > > > From: Zhao

Re: [PATCH v4 18/45] Add RNG200 RNG and RBG

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:40, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/misc/bcm2838_rng200.c | 292 +-- > include/hw/misc/bcm2838_rng200.h | 10 +- > 2 files changed, 275 insertions(+), 27 deletions(-) > > diff --git

Re: [PATCH v4 17/45] Add RNG200 skeleton

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/misc/bcm2838_rng200.c | 152 +++ > hw/misc/meson.build | 1 + > hw/misc/trace-events | 9 ++ > include/hw/misc/bcm2838_rng200.h |

Re: [PATCH v4 16/45] Enable BCM2838 PCIE

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_pcie.c| 3 +++ > hw/arm/bcm2838_peripherals.c | 26 ++ > hw/arm/meson.build | 7 --- > hw/arm/raspi4b.c

Re: [PATCH v4 15/45] Add BCM2838 PCIE host

2024-01-15 Thread Peter Maydell
(I've cc'd our PCI subsystem maintainers, because I'm not really confident in reviewing a PCI controller model. Marcel, Michael: this is one of 3 patches adding the pcie controller for the raspberry pi 4 SoC. You can find the relevant patches also here:

Re: [PATCH v2 06/19] qapi/schema: make c_type() and json_type() abstract methods

2024-01-15 Thread Markus Armbruster
John Snow writes: > These methods should always return a str, it's only the default abstract > implementation that doesn't. They can be marked "abstract", which > requires subclasses to override the method with the proper return type. > > Signed-off-by: John Snow > --- > scripts/qapi/schema.py

[PATCH] target/m68k: Fix exception frame format for 68010

2024-01-15 Thread Daniel Palmer
>From the 68010 a word with the frame format and exception vector are placed on the stack before the PC and SR. M68K_FEATURE_QUAD_MULDIV is currently checked to workout if to do this or not for the configured CPU but that flag isn't set for 68010 so currently the exception stack when 68010 is

Re: [PATCH v2 05/19] qapi/schema: declare type for QAPISchemaArrayType.element_type

2024-01-15 Thread Markus Armbruster
John Snow writes: > This field should always be present and defined after check() is > called. Declare the property but allow its initialization to be delayed > until check() so that it can be typed without the use of `Optional`. > > This helps simplify typing by avoiding the need to interrogate

Re: [PATCH v4 14/45] Add BCM2838 PCIE Root Complex

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:40, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_pcie.c | 74 +++ > hw/arm/meson.build| 5 ++- > hw/arm/trace-events | 4 ++ > include/hw/arm/bcm2838_pcie.h | 53

Re: [PATCH 5/5] qemu-options: Remove the deprecated -singlestep option

2024-01-15 Thread Thomas Huth
On 12/01/2024 16.39, Philippe Mathieu-Daudé wrote: Hi Thomas +Laurent & Peter On 12/1/24 11:00, Thomas Huth wrote: It's been marked as deprecated since QEMU 8.1, so it should be fine to remove this now. Signed-off-by: Thomas Huth ---   docs/about/deprecated.rst   |  6 --  

Re: [PATCH v2 04/19] qapi/schema: declare type for QAPISchemaObjectTypeMember.type

2024-01-15 Thread Markus Armbruster
John Snow writes: > declare, but don't initialize the type of "type" to be QAPISchemaType - Declare > and allow the value to be initialized during check(). This creates a > form of delayed initialization for QAPISchemaType objects where the > static typing only represents the fully-realized

Re: [PATCH 10/13] target/riscv/insn_trans/trans_rvv.c.inc: use 'vlenb' in MAXSZ()

2024-01-15 Thread Daniel Henrique Barboza
On 1/12/24 19:45, Richard Henderson wrote: On 1/13/24 08:38, Daniel Henrique Barboza wrote: MAXSZ() returns the value in bytes. Now that we have access to vlenb we don't need to compensate with a '-3' in the scale to use 'vlen'. MAXSZ() now works as follows: LMUL  lmul=scale  MAXSZ (vlenb

Re: [PATCH V2] Handle wrap around in limit calculation

2024-01-15 Thread Shlomo Pongratz
On 15/01/2024 12:37, Peter Maydell wrote: See inline. On Mon, 15 Jan 2024 at 05:58, Shlomo Pongratz wrote: Thank you. Please see comments inline. On Fri, Jan 12, 2024 at 7:03 PM Peter Maydell wrote: On Tue, 9 Jan 2024 at 12:45, Shlomo Pongratz wrote: Hi; thanks for this patch. Hanlde

Re: [PATCH v3 4/4] [NOT FOR MERGE] tests/qtest/migration: Adapt tests to use older QEMUs

2024-01-15 Thread Fabiano Rosas
Peter Xu writes: > On Thu, Jan 11, 2024 at 10:58:49AM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >> > On Wed, Jan 10, 2024 at 11:42:18AM -0300, Fabiano Rosas wrote: >> >> Peter Xu writes: >> >> >> >> > On Tue, Jan 09, 2024 at 11:46:32AM -0300, Fabiano Rosas wrote: >> >> >> Hm, it

Re: [PATCH] configure: Add linux header compile support for LoongArch

2024-01-15 Thread Philippe Mathieu-Daudé
On 15/1/24 08:31, Bibo Mao wrote: When compiling qemu with system KVM mode for LoongArch, header files in directory linux-headers/asm-loongarch should be used firstly. Otherwise it fails to find kvm.h on system with old glibc, since latest kernel header files are not installed. This patch adds

Re: [PATCH v4 13/45] Add memory region for BCM2837 RPiVid ASB

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > hw/arm/bcm2838_peripherals.c | 3 +++ > include/hw/arm/bcm2838_peripherals.h | 3 ++- > include/hw/arm/raspi_platform.h | 1 + > 3 files changed, 6 insertions(+), 1 deletion(-) > > diff

Re: [PATCH v4 12/45] Temporarily disable unimplemented rpi4b devices

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > This commit adds RPi4B device tree modifications: > - disable pcie, rng200, thermal sensor and genet devices > (they're going to be re-enabled in the following commits) > - create additional memory region in device tree > if RAM amount

Re: [PATCH v4 11/45] Introduce Raspberry PI 4 machine

2024-01-15 Thread Peter Maydell
On Fri, 8 Dec 2023 at 02:33, Sergey Kambalin wrote: > > Signed-off-by: Sergey Kambalin > --- > @@ -329,11 +330,24 @@ void bcm_soc_peripherals_common_realize(DeviceState > *dev, Error **errp) > return; > } > > -if (!object_property_set_uint(OBJECT(>fb), "vcram-base", > -

Re: [PATCH v2] ppc/pnv: Add QME region for P10

2024-01-15 Thread Daniel Henrique Barboza
On 7/7/23 22:16, Nicholas Piggin wrote: On Fri Jul 7, 2023 at 5:12 PM AEST, Joel Stanley wrote: The Quad Management Engine (QME) manages power related settings for its quad. The xscom region is separate from the quad xscoms, therefore a new region is added. The xscoms in a QME select a given

Re: [PATCH v2 01/19] qapi: sort pylint suppressions

2024-01-15 Thread Markus Armbruster
John Snow writes: > Suggested-by: Markus Armbruster > Signed-off-by: John Snow > --- > scripts/qapi/pylintrc | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc > index 90546df5345..78b63af4df6 100644 > ---

Re: [RFC PATCH v3 12/30] migration/multifd: Allow QIOTask error reporting without an object

2024-01-15 Thread Peter Xu
On Mon, Nov 27, 2023 at 05:25:54PM -0300, Fabiano Rosas wrote: > The only way for the channel backend to report an error to the multifd > core during creation is by setting the QIOTask error. We must allow > the channel backend to set the error even if the QIOChannel has failed > to be created,

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

2024-01-15 Thread Marc-André Lureau
Hi On Mon, Jan 15, 2024 at 3:48 PM Fiona Ebner wrote: > > Am 15.01.24 um 12:33 schrieb Marc-André Lureau: > > Hi > > > > On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: > >> > >> Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > >>> Hi > >>> > >>> On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner

Re: [PATCH v2 23/43] target/riscv: Remove misa_mxl validation

2024-01-15 Thread Alex Bennée
Alex Bennée writes: > Alistair Francis writes: > >> On Tue, Jan 9, 2024 at 1:43 AM Alex Bennée wrote: >>> >>> Alex Bennée writes: >>> >>> > From: Akihiko Odaki >>> > >>> > It is initialized with a simple assignment and there is little room for >>> > error. In fact, the validation is even

Re: [RFC PATCH v3 11/30] migration/multifd: Allow multifd without packets

2024-01-15 Thread Peter Xu
On Mon, Nov 27, 2023 at 05:25:53PM -0300, Fabiano Rosas wrote: > For the upcoming support to the new 'fixed-ram' migration stream > format, we cannot use multifd packets because each write into the > ramblock section in the migration file is expected to contain only the > guest pages. They are

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

2024-01-15 Thread Fiona Ebner
Am 15.01.24 um 12:33 schrieb Marc-André Lureau: > Hi > > On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: >> >> Am 15.01.24 um 12:15 schrieb Marc-André Lureau: >>> Hi >>> >>> On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: Am 14.01.24 um 14:51 schrieb Marc-André Lureau: >>

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

2024-01-15 Thread Alex Bennée
Thomas Huth writes: > On 15/01/2024 12.32, Alex Bennée wrote: >> Thomas Huth writes: >> >>> The test_prescaler() part in the npcm7xx_watchdog_timer test is quite >>> repetive, testing all possible combinations of the WTCLK and WTIS >>> bitfields. Since each test spins up a new instance of

Re: [PATCH 3/3] tests/acpi: Update virt/SSDT.memhp

2024-01-15 Thread Alex Bennée
Bin Meng writes: > The Arm dtb changes caused an address change: > > DefinitionBlock ("", "SSDT", 1, "BOCHS ", "NVDIMM", 0x0001) > { > [ ... ] > -Name (MEMA, 0x43C8) > +Name (MEMA, 0x43D8) > } I'm confused by why this changes. Isn't this declaring the size of a

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

2024-01-15 Thread Thomas Huth
On 15/01/2024 12.32, Alex Bennée wrote: Thomas Huth writes: The test_prescaler() part in the npcm7xx_watchdog_timer test is quite repetive, testing all possible combinations of the WTCLK and WTIS bitfields. Since each test spins up a new instance of QEMU, this is rather an expensive test,

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

2024-01-15 Thread Marc-André Lureau
Hi On Mon, Jan 15, 2024 at 3:26 PM Fiona Ebner wrote: > > Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > > Hi > > > > On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: > >> > >> Am 14.01.24 um 14:51 schrieb Marc-André Lureau: > > diff --git a/ui/clipboard.c b/ui/clipboard.c >

Re: [PATCH] tests/qtest/npcm7xx_watchdog_timer: Only test the corner cases by default

2024-01-15 Thread Alex Bennée
Thomas Huth writes: > The test_prescaler() part in the npcm7xx_watchdog_timer test is quite > repetive, testing all possible combinations of the WTCLK and WTIS > bitfields. Since each test spins up a new instance of QEMU, this is > rather an expensive test, especially on loaded host systems.

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

2024-01-15 Thread Fiona Ebner
Am 15.01.24 um 12:15 schrieb Marc-André Lureau: > Hi > > On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: >> >> Am 14.01.24 um 14:51 schrieb Marc-André Lureau: diff --git a/ui/clipboard.c b/ui/clipboard.c index 3d14bffaf8..c13b54d2e9 100644 --- a/ui/clipboard.c +++

Re: [PATCH] ui/clipboard: avoid crash upon request when clipboard peer is not initialized

2024-01-15 Thread Marc-André Lureau
Hi On Mon, Jan 15, 2024 at 2:45 PM Fiona Ebner wrote: > > Am 14.01.24 um 14:51 schrieb Marc-André Lureau: > >> > >> diff --git a/ui/clipboard.c b/ui/clipboard.c > >> index 3d14bffaf8..c13b54d2e9 100644 > >> --- a/ui/clipboard.c > >> +++ b/ui/clipboard.c > >> @@ -129,7 +129,8 @@ void

<    1   2   3   >