On 3/9/24 10:43, Daniel Henrique Barboza wrote:
From: Ivan Klokov
The vstart_qe_zero flag is set at the beginning of the translation
Here and subject, s/qe/ne/.
r~
On 3/9/24 10:43, Daniel Henrique Barboza wrote:
trans_vmv_x_s, trans_vmv_s_x, trans_vfmv_f_s and trans_vfmv_s_f aren't
setting vstart = 0 after execution. This is usually done by a helper in
vector_helper.c but these functions don't use helpers.
We'll set vstart after any potential 'over'
On 3/9/24 10:43, Daniel Henrique Barboza wrote:
Vcrypto insns should also use the same helper the regular vector insns
uses to update the tail elements.
Move vext_set_tail_elems_1s() to vector_internals.c and make it public.
Use it in vcrypto_helper.c to set tail elements instead of
On 3/9/24 10:43, Daniel Henrique Barboza wrote:
Change all code that updates tail elems to use vext_set_tail_elems_1s()
instead of vext_set_elems_1s().
Setting 'env->vstart=0' needs to be the very last thing a helper does
because env->vstart is being checked by vext_set_tail_elems_1s().
I did
On 3/9/24 10:43, Daniel Henrique Barboza wrote:
vext_vv_rm_1() and vext_vv_rm_2() are setting vstart = 0 before their
respective callers (vext_vv_rm_2 and vext_vx_rm_2) update the tail
elements.
This is benign now, but we'll convert the tail updates to use
vext_set_tail_elems_1s(), and this
On 3/9/24 10:43, Daniel Henrique Barboza wrote:
We're going to make changes that will required each helper to be
responsible for the 'vstart' management, i.e. we will relieve the
'vstart < vl' assumption that helpers have today.
To do that we'll need to deal with how we're updating tail
This fixes the invalid bInterfaceProtocol value 0x04 in the USB audio
AudioControl descriptors. It should be zero. While Linux and Windows
forgive this error, macOS 14 Sonoma does not. The usb-audio device does
not appear in macOS sound settings even though the device is recognized
and shows up in
From: Ivan Klokov
The vstart_qe_zero flag is set at the beginning of the translation
phase from the env->vstart variable. During the execution phase all
functions will set env->vstart = 0 after a successful execution,
but the vstart_eq_zero flag remains the same as at the start of the
block.
Change the for loops in ldst helpers to do a single increment in the
counter, and assign it env->vstart, to avoid re-reading from vstart
every time.
Suggested-by: Richard Henderson
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Alistair Francis
Reviewed-by: Richard Henderson
---
Vcrypto insns should also use the same helper the regular vector insns
uses to update the tail elements.
Move vext_set_tail_elems_1s() to vector_internals.c and make it public.
Use it in vcrypto_helper.c to set tail elements instead of
vext_set_elems_1s(). Helpers must set env->vstart = 0 after
trans_vmv_v_i , trans_vfmv_v_f and the trans_##NAME macro from
GEN_VMV_WHOLE_TRANS() are calling mark_vs_dirty() in both branches of
their 'ifs'. conditionals.
Call it just once in the end like other functions are doing.
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Richard Henderson
Most of the vector translations has this following pattern at the start:
TCGLabel *over = gen_new_label();
tcg_gen_brcond_tl(TCG_COND_GEU, cpu_vstart, cpu_vl, over);
And then right at the end:
gen_set_label(over);
return true;
This means that if vstart >= vl we'll not set
Change all code that updates tail elems to use vext_set_tail_elems_1s()
instead of vext_set_elems_1s().
Setting 'env->vstart=0' needs to be the very last thing a helper does
because env->vstart is being checked by vext_set_tail_elems_1s().
A side effect of this change is that a lot of 'vta'
We're going to make changes that will required each helper to be
responsible for the 'vstart' management, i.e. we will relieve the
'vstart < vl' assumption that helpers have today.
To do that we'll need to deal with how we're updating tail elements
first. We can't update them if vstart >= vl, but
The helper isn't setting env->vstart = 0 after its execution, as it is
expected from every vector instruction that completes successfully.
Signed-off-by: Daniel Henrique Barboza
Reviewed-by: Richard Henderson
Reviewed-by: Alistair Francis
---
target/riscv/vector_helper.c | 1 +
1 file
trans_vmv_x_s, trans_vmv_s_x, trans_vfmv_f_s and trans_vfmv_s_f aren't
setting vstart = 0 after execution. This is usually done by a helper in
vector_helper.c but these functions don't use helpers.
We'll set vstart after any potential 'over' brconds, and that will also
mandate a mark_vs_dirty()
vext_vv_rm_1() and vext_vv_rm_2() are setting vstart = 0 before their
respective callers (vext_vv_rm_2 and vext_vx_rm_2) update the tail
elements.
This is benign now, but we'll convert the tail updates to use
vext_set_tail_elems_1s(), and this function is sensitive to vstart
changes. Do vstart =
Hi,
This new version has changes suggested by Richard in patches 2 and 6.
Other patches are unchanged.
Series based on alistair/riscv-to-apply.next.
Patches missing review: 2, 3, 4, 5, 6.
Changes from v8:
- patch 2:
- do an early exit if vstart >= vl in vext_ldst_stride(), vext_ldst_us()
On 3/9/24 17:14, Richard Henderson wrote:
On 3/8/24 11:53, Daniel Henrique Barboza wrote:
- patch 7 (patch 3 from v7): do not remove brconds from scalar move
insns
trans_vmv_s_x() and trans_vfmv_s_f() does not have a helper that will
handle vstart >= vl for them, so they need their
On Sat, 9 Mar 2024 at 18:29, Philippe Mathieu-Daudé wrote:
>
> On 9/3/24 18:27, Peter Maydell wrote:
> > On Tue, 5 Mar 2024 at 10:39, Thomas Huth wrote:
> >> Ok, while I was writing my mail, I was looking at https://brew.sh/ and
> >> didn't see a link to a bug tracker there ... but now I
On 3/8/24 11:53, Daniel Henrique Barboza wrote:
- patch 7 (patch 3 from v7): do not remove brconds from scalar move
insns
trans_vmv_s_x() and trans_vfmv_s_f() does not have a helper that will
handle vstart >= vl for them, so they need their brcond.
- patches 4 and 5 from v7: dropped.
On Fri, 8 Mar 2024 at 18:13, Paolo Bonzini wrote:
>
> The following changes since commit 8f6330a807f2642dc2a3cdf33347aa28a4c00a87:
>
> Merge tag 'pull-maintainer-updates-060324-1' of
> https://gitlab.com/stsquad/qemu into staging (2024-03-06 16:56:20 +)
>
> are available in the Git
On Fri, 8 Mar 2024 at 17:03, Maciej S. Szmigiero
wrote:
>
> From: "Maciej S. Szmigiero"
>
> The following changes since commit 8f6330a807f2642dc2a3cdf33347aa28a4c00a87:
>
> Merge tag 'pull-maintainer-updates-060324-1' of
> https://gitlab.com/stsquad/qemu into staging (2024-03-06 16:56:20
We are going to replace TARGET_PAGE_MASK by a
runtime variable. In order to reduce code duplication,
propagate TARGET_PAGE_MASK to get_physmapping() and
xen_phys_offset_to_gaddr().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Manos Pitsidianakis
Message-Id:
From: Eric Auger
Introduce a new enum type property allowing to set an
IOMMU granule. Values are 4k, 8k, 16k, 64k and host.
This latter indicates the vIOMMU granule will match
the host page size.
A subsequent patch will add such a property to the
virtio-iommu device.
Signed-off-by: Eric Auger
From: Zhao Liu
The support for "parameter=0" SMP configurations is removed, and QEMU
returns error for those cases.
So add the related test cases to ensure parameters can't accept 0.
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
Message-ID:
These definitions were removed in commit ea985d235b
("pc_piix: remove pc-i440fx-1.4 up to pc-i440fx-1.7").
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20240301185936.95175-2-phi...@linaro.org>
---
include/hw/i386/pc.h | 12
1 file changed, 12
The "isapc" machine only provides an ISA bus, not a PCI one,
and doesn't instanciate any i440FX south bridge.
Its machine class defines PCMachineClass::pci_enabled = false,
and pc_init1() only uses the pci_type argument when pci_enabled
is true. Since for this machine the argument is not used,
From: Zhao Liu
Although drawer was introduced to -smp along with book by s390 machine,
as a general topology level in QEMU that may be reused by other arches
in the future, it is desirable to cover this parameter's parsing in a
separate case.
Signed-off-by: Zhao Liu
Tested-by: Xiaoling Song
From: Zhao Liu
Currently, -smp supports 2 more new levels: book and drawer.
It is necessary to consider the effects of book and drawer in the test
cases to ensure that the calculations are correct. This is also the
preparation to add new book and drawer test cases.
Signed-off-by: Zhao Liu
From: Clément Chigot
Even if the error is set, the build is not aborted when the ncpus value
is wrong, the return is missing.
Signed-off-by: Clément Chigot
Reviewed-by: Peter Maydell
Fixes: 6bf1478543 ("hw/intc/grlib_irqmp: add ncpus property")
Reviewed-by: Philippe Mathieu-Daudé
Message-ID:
From: Zhao Liu
The smp_props.has_clusters in MachineClass is not a user configured
field, and it indicates if user specifies "clusters" in -smp.
After -smp parsing, other module could aware if the cluster level
is configured by user. This is used when the machine has only 1 cluster
since
From: Zhao Liu
In machine_parse_smp_config(), the number of total CPUs is calculated
by:
drawers * books * sockets * dies * clusters * cores * threads
To avoid missing the future new topology level, use a local variable to
cache the calculation result so that total CPUs are only calculated
From: Zhao Liu
Unsupported "parameter=1" SMP configurations is marked as deprecated,
so drop the related test case.
Signed-off-by: Zhao Liu
Reviewed-by: Thomas Huth
Message-ID: <20240308160148.3130837-5-zhao1@linux.intel.com>
Signed-off-by: Philippe Mathieu-Daudé
---
From: Zhao Liu
Since s390 machine supports both "drawers" and "books" in -smp, add the
"drawers" and "books" combination test case to match the actual topology
usage scenario.
Signed-off-by: Zhao Liu
Tested-by: Xiaoling Song
Reviewed-by: Thomas Huth
Message-ID:
From: Zhao Liu
The "parameter=0" SMP configurations have been marked as deprecated
since v6.2.
For these cases, -smp currently returns the warning and adjusts the
zeroed parameters to 1 by default.
Remove the above compatibility logic in v9.0, and return error directly
if any -smp parameter is
From: Zhao Liu
Currently, it was allowed for users to specify the unsupported
topology parameter as "1". For example, x86 PC machine doesn't
support drawer/book/cluster topology levels, but user could specify
"-smp drawers=1,books=1,clusters=1".
This is meaningless and confusing, so that the
From: BALATON Zoltan
The output of info qtree monitor command is very long. Add an option
to print a brief overview omitting all the details.
Signed-off-by: BALATON Zoltan
Reviewed-by: Dr. David Alan Gilbert
Message-ID: <20240307183812.0105d4e6...@zero.eik.bme.hu>
Signed-off-by: Philippe
From: Angelo Dureghello
Add reset support for mcf5208.
Signed-off-by: Angelo Dureghello
Reviewed-by: Thomas Huth
Message-ID: <20240309093459.984565-1-ang...@kernel-space.org>
Signed-off-by: Philippe Mathieu-Daudé
---
hw/m68k/mcf5208.c | 44 ++--
1
From: Zhao Liu
Use MAX_CPUS/MIN_CPUS macros in invalid topology case. This gives us the
flexibility to change the maximum and minimum CPU limits.
Signed-off-by: Zhao Liu
Tested-by: Xiaoling Song
Reviewed-by: Thomas Huth
Message-ID: <20240308160148.3130837-6-zhao1@linux.intel.com>
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*
All callers use host_type=TYPE_I440FX_PCI_HOST_BRIDGE.
Directly use this definition within pc_init1().
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20240301185936.95175-4-phi...@linaro.org>
---
hw/i386/pc_piix.c | 14 +-
1 file changed, 5
From: Zhao Liu
Although book was introduced to -smp along with drawer by s390 machine,
as a general topology level in QEMU that may be reused by other arches
in the future, it is desirable to cover this parameter's parsing in a
separate case.
Signed-off-by: Zhao Liu
Tested-by: Xiaoling Song
From: Zhao Liu
Currently, -smp supports up to 7-levels topology hierarchy:
-drawers/books/sockets/dies/clusters/cores/threads.
Though no machine supports all these 7 levels yet, these 7 levels have
the strict containment relationship and together form the generic CPU
topology representation
From: Thomas Weißschuh
Adjust indentation for commit d23055b8db8 (qapi: Require descriptions
and tagged sections to be indented).
Signed-off-by: Thomas Weißschuh
Reviewed-by: Markus Armbruster
Message-ID: <20240307-qapi-firmware-json-v2-1-3b29eabb9...@linutronix.de>
[PMD: Reword description
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*
"hw/xen/xen_pt.h" requires "hw/xen/xen_native.h" which is target
specific. It also declares IGD methods, which are not target
specific.
Target-agnostic code can use IGD methods. To allow that, extract
these methos into a new "hw/xen/xen_igd.h" header.
Signed-off-by: Philippe Mathieu-Daudé
xen-hvm.c calls xc_set_hvm_param() from ,
so better compile it with Xen CPPFLAGS.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Woodhouse
Message-Id: <20231114143816.71079-19-phi...@linaro.org>
---
hw/i386/xen/meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
From: Thomas Weißschuh
The doc title did not match the actual definition.
Fixes: 2720ceda05 ("docs: expand firmware descriptor to allow flash without
NVRAM")
Signed-off-by: Thomas Weißschuh
Reviewed-by: Philippe Mathieu-Daudé
Message-ID:
From: Paolo Bonzini
deliver_bitmask is allocated on the heap in apic_deliver(), but there
are many paths in the function that return before the corresponding
g_free() is reached. Fix this by switching to g_autofree and, while at
it, also switch to g_new. Do the same in apic_deliver_irq() as
From: Zhao Liu
The q35 machine is trying to support up to 4096 vCPUs [1], so it's
necessary to bump max_cpus in test-smp-parse to 4096 to cover the
topological needs of future machines.
[1]:
https://lore.kernel.org/qemu-devel/20240228143351.3967-1-anisi...@redhat.com/
Signed-off-by: Zhao Liu
From: Mark Cave-Ayland
MacOS X uses multiple techniques for calibrating timers depending upon the
detected
hardware. One of these calibration routines compares the change in the timebase
against the KeyLargo timer and uses this to recalculate the clock frequency,
timebase frequency and bus
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
...
* - It should not be passed to error_prepend(), error_vprepend() or
*
"sysemu/xen.h" defines CONFIG_XEN_IS_POSSIBLE as a target-agnostic
version of CONFIG_XEN accelerator.
Use it in order to use "sysemu/xen-mapcache.h" in target-agnostic files.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Woodhouse
Message-Id:
To avoid a potential global variable shadow in
hw/i386/pc_piix.c::pc_init1(), rename Xen's
"ram_memory" as "xen_memory".
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Woodhouse
Message-Id: <20231114143816.71079-11-phi...@linaro.org>
---
include/hw/xen/xen-hvm-common.h | 2 +-
Since commit 04b0de0ee8 ("xen: factor out common functions")
xen_hvm_inject_msi() stub is not required.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Woodhouse
Message-Id: <20231114143816.71079-8-phi...@linaro.org>
---
stubs/xen-hw-stub.c | 4
1 file changed, 4 deletions(-)
In order to build this file once for all targets, replace:
TARGET_PAGE_BITS -> qemu_target_page_bits()
TARGET_PAGE_SIZE -> qemu_target_page_size()
TARGET_PAGE_MASK -> -qemu_target_page_size()
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Manos Pitsidianakis
Message-Id:
Commit eaab4d60d3 ("Introduce Xen PCI Passthrough, qdevice")
introduced both xen_pt.[ch], but only added the license to
xen_pt.c. Use the same license for xen_pt.h.
Suggested-by: David Woodhouse
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Woodhouse
Message-Id:
vAPIC isn't KVM specific, so having its name prefixed 'kvm'
is misleading. Rename it simply 'vapic'. Rename the single
function prefixed 'kvm'.
Signed-off-by: Philippe Mathieu-Daudé
Message-Id: <20230905145159.7898-1-phi...@linaro.org>
---
hw/i386/{kvmvapic.c => vapic.c} | 5 ++---
Instead of the target-specific TARGET_PAGE_BITS definition,
use qemu_target_page_bits() which is target agnostic.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: David Woodhouse
Message-Id: <20231114143816.71079-15-phi...@linaro.org>
---
physmem.c doesn't use any declaration from "hw/xen/xen.h",
it only requires "sysemu/xen.h" and "system/xen-mapcache.h".
Suggested-by: David Woodhouse
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Woodhouse
Reviewed-by: David Hildenbrand
Message-Id:
NotifyVmexitOption_str() is QAPI-generated in
"qapi/qapi-types-run-state.h", which "sysemu/runstate.h"
already includes.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20240301185936.95175-3-phi...@linaro.org>
---
hw/i386/pc_piix.c | 4 +---
1 file changed, 1
Similarly to the restriction in hw/pci/msix.c (see commit
e1e4bf2252 "msix: fix msix_vector_masked"), restrict the
xen_is_pirq_msi() call in msi_is_masked() to Xen.
No functional change intended.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: David Woodhouse
Message-Id:
Use TARGET_PAGE_SIZE to calculate TARGET_PAGE_ALIGN.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Manos Pitsidianakis
Message-Id: <20231114163123.74888-2-phi...@linaro.org>
---
hw/i386/xen/xen-hvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/xen/xen-hvm.c
Xen is a system specific accelerator, it makes no sense
to include its headers in user emulation.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: David Woodhouse
Message-Id: <20231114143816.71079-3-phi...@linaro.org>
---
include/sysemu/xen.h | 8
1
The following changes since commit 84644ac1b0f80d41b8a2f66547b83b2ad4a98576:
Merge tag 'darwin-20240305' of https://github.com/philmd/qemu into staging
(2024-03-08 18:19:25 +)
are available in the Git repository at:
https://github.com/philmd/qemu.git tags/hw-misc-20240309
for you
On 3/8/24 11:53, Daniel Henrique Barboza wrote:
trans_vmv_x_s, trans_vmv_s_x, trans_vfmv_f_s and trans_vfmv_s_f aren't
setting vstart = 0 after execution. This is usually done by a helper in
vector_helper.c but these functions don't use helpers.
We'll set vstart after any potential 'over'
Am 9. März 2024 16:29:23 UTC schrieb "Philippe Mathieu-Daudé"
:
>Hi Bernhard,
>
>On 9/3/24 14:40, Bernhard Beschow wrote:
>> The PAM bit extraction is currently spread across pam.c and the northbridge
>> device models, making the extraction logic harder to comprehend. Also note
>> how
>>
05.03.2024 19:39, Richard Henderson wrote:
While the 8-bit input elements are sequential in the input vector,
the 32-bit output elements are not sequential in the output matrix.
Do not attempt to compute 2 32-bit outputs at the same time.
Cc: qemu-sta...@nongnu.org
Fixes: 23a5e3859f5
On 3/8/24 11:53, Daniel Henrique Barboza wrote:
+static void vext_set_tail_elems_1s(CPURISCVState *env, void *vd,
+ uint32_t desc, uint32_t esz,
+ uint32_t max_elems)
{
uint32_t vta = vext_vta(desc);
+uint32_t nf =
On 9/3/24 18:27, Peter Maydell wrote:
On Tue, 5 Mar 2024 at 10:39, Thomas Huth wrote:
On 04/03/2024 19.04, Daniel P. Berrangé wrote:
On Mon, Mar 04, 2024 at 06:11:58PM +0100, Thomas Huth wrote:
On 04/03/2024 17.56, Peter Maydell wrote:
On Mon, 4 Mar 2024 at 13:04, Thomas Huth wrote:
The
On 3/7/24 22:40, Yu-Ming Chang via wrote:
Both CSRRS and CSRRC always read the addressed CSR and cause any read side
effects regardless of rs1 and rd fields. Note that if rs1 specifies a register
holding a zero value other than x0, the instruction will still attempt to write
the unmodified value
On 9/3/24 18:51, Richard Henderson wrote:
When converting test vs UINT32_MAX to compare vs 0, we need to
adjust the condition to match.
Cc: qemu-sta...@nongnu.org
Fixes: 34aff3c2e06 ("tcg/aarch64: Generate CBNZ for TSTNE of UINT32_MAX")
Signed-off-by: Richard Henderson
---
On 9/3/24 18:51, Richard Henderson wrote:
Pass the type to tcg_out_logicali; remove the assert, duplicated
at the start of tcg_out_logicali.
Cc: qemu-sta...@nongnu.org
Fixes: 339adf2f38e ("tcg/aarch64: Support TCG_COND_TST{EQ,NE}")
Oops, thanks.
Reviewed-by: Philippe Mathieu-Daudé
On 4/3/24 08:35, Mark Cave-Ayland wrote:
MacOS X uses multiple techniques for calibrating timers depending upon the
detected
hardware. One of these calibration routines compares the change in the timebase
against the KeyLargo timer and uses this to recalculate the clock frequency,
timebase
Pass the type to tcg_out_logicali; remove the assert, duplicated
at the start of tcg_out_logicali.
Cc: qemu-sta...@nongnu.org
Fixes: 339adf2f38e ("tcg/aarch64: Support TCG_COND_TST{EQ,NE}")
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c.inc | 3 +--
1 file changed, 1
Oopsies exposed by Paolo's target/i386 changes.
r~
Richard Henderson (2):
tcg/aarch64: Fix tcg_out_cmp for test comparisons
tcg/aarch64: Fix tcg_out_brcond for test comparisons
tcg/aarch64/tcg-target.c.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--
2.34.1
When converting test vs UINT32_MAX to compare vs 0, we need to
adjust the condition to match.
Cc: qemu-sta...@nongnu.org
Fixes: 34aff3c2e06 ("tcg/aarch64: Generate CBNZ for TSTNE of UINT32_MAX")
Signed-off-by: Richard Henderson
---
tcg/aarch64/tcg-target.c.inc | 1 +
1 file changed, 1
On Sat, 9 Mar 2024, Isaac Woods wrote:
Signed-off-by: Isaac Woods
---
hw/usb/hcd-ehci-pci.c| 27 +++
hw/usb/hcd-ehci-sysbus.c | 7 +++
hw/usb/hcd-ehci.c| 2 +-
hw/usb/hcd-ehci.h| 2 ++
4 files changed, 37 insertions(+), 1 deletion(-)
diff --git
On Tue, 5 Mar 2024 at 10:39, Thomas Huth wrote:
>
> On 04/03/2024 19.04, Daniel P. Berrangé wrote:
> > On Mon, Mar 04, 2024 at 06:11:58PM +0100, Thomas Huth wrote:
> >> On 04/03/2024 17.56, Peter Maydell wrote:
> >>> On Mon, 4 Mar 2024 at 13:04, Thomas Huth wrote:
>
> The macOS jobs in
Hi Bernhard,
On 9/3/24 14:40, Bernhard Beschow wrote:
The PAM bit extraction is currently spread across pam.c and the northbridge
device models, making the extraction logic harder to comprehend. Also note how
pam_update() deals with PAM_REGIONS_COUNT, even though it handles exactly one
region.
The following changes since commit 84644ac1b0f80d41b8a2f66547b83b2ad4a98576:
Merge tag 'darwin-20240305' of https://github.com/philmd/qemu into staging
(2024-03-08 18:19:25 +)
are available in the Git repository at:
https://gitlab.com/mjt0k/qemu.git tags/pull-trivial-patches
for you
From: Ani Sinha
Update bios-bits docs to add more details on why a pre-OS environment for
testing bioses is useful. Add author's FOSDEM talk link. Also improve the
formating of the document while at it.
Signed-off-by: Ani Sinha
Reviewed-by: Michael Tokarev
Signed-off-by: Michael Tokarev
---
From: Thomas Huth
When setting GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_58 or higher,
glib adds type safety checks to the g_steal_pointer() macro. This
triggers errors in the build_cdat_table() function which uses the
g_steal_pointer() for type-casting from one pointer type to the other
(which
From: BALATON Zoltan
Signed-off-by: BALATON Zoltan
Reviewed-by: Michael Tokarev
Signed-off-by: Michael Tokarev
---
hw/scsi/lsi53c895a.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
index d607a5f9fb..f8598a17f5 100644
---
From: Markus Armbruster
Signed-off-by: Markus Armbruster
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Michael Tokarev
Signed-off-by: Michael Tokarev
---
include/qapi/qmp/qerror.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h
From: Thomas Huth
When setting GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_58 or higher,
glib adds type safety checks to the g_steal_pointer() macro. This
triggers errors in the ct3_build_cdat_entries_for_mr() function which
uses the g_steal_pointer() for type-casting from one pointer type to
the
From: Markus Armbruster
Both
$ qemu-system-x86_64 -chardev null,id=chr0,mux=on -mon chardev=chr0 -mon
chardev=chr0 -mon chardev=chr0 -mon chardev=chr0 -mon chardev=chr0
and
$ qemu-system-x86_64 -chardev null,id=chr0 -mon chardev=chr0 -mon
chardev=chr0
fail with
From: Markus Armbruster
Improve
Record/replay feature is not supported for '-rtc base=localtime'
Record/replay feature is not supported for 'smp'
Record/replay feature is not supported for '-snapshot'
to
Record/replay is not supported with -rtc base=localtime
Record/replay is
For a long time, we provide two compression formats in the
download area, .bz2 and .xz. There's absolutely no reason
to provide two in parallel, .xz compresses better, and all
the links we use points to .xz. Downstream distributions
mostly use .xz too.
For the release maintenance providing two
From: Frediano Ziglio
Not used outside C module.
Signed-off-by: Frediano Ziglio
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by Tokarev
Signed-off-by: Michael Tokarev
---
hw/vfio/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
From: Markus Armbruster
When block_resize() runs into an op blocker, it creates an error like
this:
error_setg(errp, "Device '%s' is in use", device);
Trouble is @device can be null. My system formats null as "(null)",
but other systems might crash. Reproducer:
1. Create two block
From: Thomas Huth
When setting GLIB_VERSION_MAX_ALLOWED to GLIB_VERSION_2_58 or higher
(which we'll certainly do in the not too distant future), glib adds
type safety checks to the g_steal_pointer() macro. This trigger an
error in the ct3_load_cdat() function: The local char *buf variable is
Signed-off-by: Isaac Woods
---
hw/usb/hcd-ehci-pci.c| 27 +++
hw/usb/hcd-ehci-sysbus.c | 7 +++
hw/usb/hcd-ehci.c| 2 +-
hw/usb/hcd-ehci.h| 2 ++
4 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/hw/usb/hcd-ehci-pci.c
This is a small patch that aims to add support for sending
message-signalled interrupts from EHCI controllers on PCI busses.
This was desirable for guests (in my case a hobbyist OS) that do not
have support for legacy PCI interrupt routing but still want to / have to
interface with EHCI
On Mon, 26 Feb 2024 22:59:07 +0100
Bernhard Beschow wrote:
> As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
> flash handling to pc_sysfw" causes a regression when specifying the property
> `-M pflash0` in the PCI PC machines:
> qemu-system-x86_64: Property
On Fri, 8 Mar 2024 at 15:50, Peter Maydell wrote:
>
> The following changes since commit 8f6330a807f2642dc2a3cdf33347aa28a4c00a87:
>
> Merge tag 'pull-maintainer-updates-060324-1' of
> https://gitlab.com/stsquad/qemu into staging (2024-03-06 16:56:20 +)
>
> are available in the Git
On Tue, 5 Mar 2024 at 11:06, Philippe Mathieu-Daudé wrote:
>
> The following changes since commit 52e7db443bd8d233acc3977bd150bdadb62db86c:
>
> Merge tag 'hppa-latest-pull-request' of
> https://github.com/hdeller/qemu-hppa into staging (2024-03-04 16:01:33 +)
>
> are available in the Git
Am Sat, 9 Mar 2024 10:34:59 +0100
schrieb Angelo Dureghello :
> Add reset support for mcf5208.
>
> Signed-off-by: Angelo Dureghello
> ---
> hw/m68k/mcf5208.c | 44 ++--
> 1 file changed, 42 insertions(+), 2 deletions(-)
Reviewed-by: Thomas Huth
1 - 100 of 122 matches
Mail list logo
