Re: [PATCH] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-02 Thread Philippe Mathieu-Daudé
On 2/5/24 11:26, Philippe Mathieu-Daudé wrote: On 2/5/24 10:26, Daniel P. Berrangé wrote: On Thu, May 02, 2024 at 10:22:02AM +0200, Philippe Mathieu-Daudé wrote: On 2/5/24 10:11, Philippe Mathieu-Daudé wrote: We only use Libtasn1 in unit tests. As noted in commit d47b83b118 ("tests: add migrat

Re: [PATCH v2 04/15] hw/riscv: add riscv-iommu-pci device

2024-05-02 Thread Daniel Henrique Barboza
On 4/29/24 04:21, Frank Chang wrote: Daniel Henrique Barboza mailto:dbarb...@ventanamicro.com>> 於 2024年3月8日 週五 上午12:04寫道: > > From: Tomasz Jeznach mailto:tjezn...@rivosinc.com>> > > The RISC-V IOMMU can be modelled as a PCIe device following the > guidelines of the RISC-V IOMMU spec, chap

Re: [PATCH] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-02 Thread Philippe Mathieu-Daudé
On 2/5/24 10:26, Daniel P. Berrangé wrote: On Thu, May 02, 2024 at 10:22:02AM +0200, Philippe Mathieu-Daudé wrote: On 2/5/24 10:11, Philippe Mathieu-Daudé wrote: We only use Libtasn1 in unit tests. As noted in commit d47b83b118 ("tests: add migration tests of TLS with x509 credentials"), having

Re: [PATCH] migration/rdma: Allow building without on-demand paging support

2024-05-02 Thread Philippe Mathieu-Daudé
On 2/5/24 11:19, Philippe Mathieu-Daudé wrote: On 2/5/24 11:10, Daniel P. Berrangé wrote: On Thu, May 02, 2024 at 11:05:47AM +0200, Philippe Mathieu-Daudé wrote: On-demand paging support was added in libibverbs v1.2.0 in commit https://github.com/linux-rdma/rdma-core/commit/e500adc7b1 That is

Re: [PATCH v1 0/2] Upgrade ACPI SPCR table to support SPCR table version 4 format

2024-05-02 Thread Peter Maydell
On Thu, 2 May 2024 at 06:12, Sia Jee Heng wrote: > > Update the SPCR table to accommodate the SPCR Table version 4 [1]. > The SPCR table has been modified to adhere to the version 4 format [2]. > > Meanwhile, the virt SPCR golden reference files have been updated to > accommodate the SPCR Table ve

Re: [PATCH] migration/rdma: Allow building without on-demand paging support

2024-05-02 Thread Philippe Mathieu-Daudé
On 2/5/24 11:10, Daniel P. Berrangé wrote: On Thu, May 02, 2024 at 11:05:47AM +0200, Philippe Mathieu-Daudé wrote: On-demand paging support was added in libibverbs v1.2.0 in commit https://github.com/linux-rdma/rdma-core/commit/e500adc7b1 That is 9 years old, so I'm surprised any distro we tar

Re: [PATCH] MAINTAINERS: Update the reviewers for RDMA migration

2024-05-02 Thread Philippe Mathieu-Daudé
Hi, On 2/5/24 09:44, Yu Zhang wrote: As the links [1][2] below stated, QEMU development community is currently having some difficulties in maintaining the RDMA migration subsystem due to the lack of resources (maintainers, test cases, test environment etc.) and considering to deprecate it. Acco

Re: [PATCH] target/arm: fix MPIDR value for ARM CPUs with SMT

2024-05-02 Thread Peter Maydell
On Wed, 1 May 2024 at 19:08, Marcin Juszkiewicz wrote: > > W dniu 22.04.2024 o 17:21, Richard Henderson pisze: > >>> For Arm's CPUs they fall into two categories: > >>> * older ones don't set MT in their MPIDR, and the Aff0 > >>> field is effectively the CPU number > >>> * newer ones do se

Re: [PATCH] migration/rdma: Allow building without on-demand paging support

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 11:05:47AM +0200, Philippe Mathieu-Daudé wrote: > On-demand paging support was added in libibverbs v1.2.0 in > commit https://github.com/linux-rdma/rdma-core/commit/e500adc7b1 That is 9 years old, so I'm surprised any distro we target still is so outdated. Can you say what

[PATCH] migration/rdma: Allow building without on-demand paging support

2024-05-02 Thread Philippe Mathieu-Daudé
On-demand paging support was added in libibverbs v1.2.0 in commit https://github.com/linux-rdma/rdma-core/commit/e500adc7b1 We don't check the libibverbs, so add a meson check on the IBV_ACCESS_ON_DEMAND symbol, and define HAVE_IBV_ACCESS_ON_DEMAND if found. Restrict rdma_support_odp() so it retur

Re: [PATCH 1/2] ppc/pnv: Begin a more complete ADU LPC model for POWER9/10

2024-05-02 Thread Cédric Le Goater
On 5/1/24 14:39, Nicholas Piggin wrote: On Wed Apr 17, 2024 at 9:25 PM AEST, Cédric Le Goater wrote: Hello Nick, On 4/17/24 13:02, Nicholas Piggin wrote: This implements a framework for an ADU unit model. The ADU unit actually implements XSCOM, which is the bridge between MMIO and PIB. Howeve

Re: [PATCH v10 1/2] tpm: convert tpmdev options processing to new visitor format

2024-05-02 Thread Markus Armbruster
James Bottomley writes: > Instead of processing the tpmdev options using the old qemu options, > convert to the new visitor format which also allows the passing of > json on the command line. > > Signed-off-by: James Bottomley > Tested-by: Stefan Berger > Reviewed-by: Stefan Berger [...] > d

Re: [PATCH 2/2] ppc/pnv: Implement ADU access to LPC space

2024-05-02 Thread Cédric Le Goater
Hello Nick, diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c index 5869aac89a..eb9dbc62dd 100644 --- a/hw/ppc/pnv.c +++ b/hw/ppc/pnv.c @@ -1642,6 +1642,8 @@ static void pnv_chip_power9_realize(DeviceState *dev, Error **errp) } /* ADU */ +object_property_set_link(OBJECT(&chip9->a

Re: [PATCH] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 10:22:02AM +0200, Philippe Mathieu-Daudé wrote: > On 2/5/24 10:11, Philippe Mathieu-Daudé wrote: > > We only use Libtasn1 in unit tests. As noted in commit d47b83b118 > > ("tests: add migration tests of TLS with x509 credentials"), having > > GnuTLS without Libtasn1 is a val

Re: [PATCH] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-02 Thread Philippe Mathieu-Daudé
On 2/5/24 10:11, Philippe Mathieu-Daudé wrote: We only use Libtasn1 in unit tests. As noted in commit d47b83b118 ("tests: add migration tests of TLS with x509 credentials"), having GnuTLS without Libtasn1 is a valid configuration, so do not require Libtasn1, to avoid: Dependency gnutls found:

Re: [PATCH] ppc/pnv: Update Power10's cfam id to use Power10 DD2

2024-05-02 Thread Cédric Le Goater
On 5/2/24 08:27, Aditya Gupta wrote: Power10 DD1.0 was dropped in: commit 8f054d9ee825 ("ppc: Drop support for POWER9 and POWER10 DD1 chips") Use the newer Power10 DD2 chips cfam id. Cc: Cédric Le Goater Cc: David Gibson Cc: Frédéric Barrat Cc: Laurent Vivier Cc: Mahesh J Salgaonkar

Re: [PATCH v3 11/19] backends/iommufd: Implement HostIOMMUDeviceClass::check_cap() handler

2024-05-02 Thread Cédric Le Goater
+static int hiod_iommufd_check_cap(HostIOMMUDevice *hiod, int cap, Error **errp) +{ +switch (cap) { +case HOST_IOMMU_DEVICE_CAP_IOMMUFD: +return 1; I don't understand this value. 1 means this host iommu device is attached to IOMMUFD backend, or else 0 if attached to legacy ba

[PATCH] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-02 Thread Philippe Mathieu-Daudé
We only use Libtasn1 in unit tests. As noted in commit d47b83b118 ("tests: add migration tests of TLS with x509 credentials"), having GnuTLS without Libtasn1 is a valid configuration, so do not require Libtasn1, to avoid: Dependency gnutls found: YES 3.7.1 (cached) Run-time dependency libtasn1

Re: QEMU headers in C++

2024-05-02 Thread Daniel P . Berrangé
On Wed, May 01, 2024 at 09:40:16PM -0700, Roman Kiryanov wrote: > Hi QEMU, > > I work in Android Studio Emulator and we would like to develop devices > in C++. Unfortunately, QEMU headers cannot be used with C++ as is > (e.g. they use C++ keywords as variable names or implicitly cast void* > to T*

Re: [PATCH v2] hw/s390x: Attach the sclpconsole to /machine/sclp/s390-sclp-event-facility

2024-05-02 Thread Thomas Huth
On 02/05/2024 09.57, Cédric Le Goater wrote: On 4/30/24 21:08, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. We should rather attach it to /machine/sclp/s390-sclp-event-facility where

Re: [PATCH v2] hw/s390x: Attach the sclpconsole to /machine/sclp/s390-sclp-event-facility

2024-05-02 Thread Cédric Le Goater
On 4/30/24 21:08, Thomas Huth wrote: The sclpconsole currently does not have a proper parent in the QOM tree, so it shows up under /machine/unattached - which is somewhat ugly. We should rather attach it to /machine/sclp/s390-sclp-event-facility where the other devices of type TYPE_SCLP_EVENT alr

[PATCH] MAINTAINERS: Update the reviewers for RDMA migration

2024-05-02 Thread Yu Zhang
As the links [1][2] below stated, QEMU development community is currently having some difficulties in maintaining the RDMA migration subsystem due to the lack of resources (maintainers, test cases, test environment etc.) and considering to deprecate it. According to our user experience in the rece

[PATCH] hw/input/tsc2005: Fix -Wchar-subscripts warning in tsc2005_txrx()

2024-05-02 Thread Philippe Mathieu-Daudé
Check the function index is not negative and use an unsigned variable to avoid the following warning with GCC 13.2.0: [666/5358] Compiling C object libcommon.fa.p/hw_input_tsc2005.c.o hw/input/tsc2005.c: In function 'tsc2005_timer_tick': hw/input/tsc2005.c:416:26: warning: array subscript ha

Re: [PATCH v4 12/17] xen: mapcache: Unmap first entries in buckets

2024-05-02 Thread Edgar E. Iglesias
On Tue, Apr 30, 2024 at 6:50 PM Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > When invalidating memory ranges, if we happen to hit the first > entry in a bucket we were never unmapping it. This was harmless > for foreign mappings but now that we're looking to reuse the > mapcache for

Re: [PATCH] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-02 Thread Daniil Tatianin
On 4/29/24 4:39 PM, Philippe Mathieu-Daudé wrote: (+Peter who has more experience on such design). On 29/4/24 13:32, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Daniil, Markus, On 26/4/24 10:39, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-s

Re: [PATCH v4 13/17] softmmu: Pass RAM MemoryRegion and is_write xen_map_cache()

2024-05-02 Thread Edgar E. Iglesias
On Thu, May 2, 2024 at 9:24 AM David Hildenbrand wrote: > > On 30.04.24 18:49, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Propagate MR and is_write to xen_map_cache(). > > I'm pretty sure the patch subject is missing a "to" :) Thanks David! I'll fix it in v5! Cheers, Edgar

Re: [PATCH v4 14/17] xen: Add xen_mr_is_memory()

2024-05-02 Thread David Hildenbrand
On 30.04.24 18:49, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add xen_mr_is_memory() to abstract away tests for the xen_memory MR. Signed-off-by: Edgar E. Iglesias --- [...] #endif diff --git a/system/physmem.c b/system/physmem.c index ad7a8c7d95..1a5ffcba2a 100644 --- a/system/

Re: [PATCH v4 3/3] qapi: introduce device-sync-config

2024-05-02 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 30.04.24 11:31, Vladimir Sementsov-Ogievskiy wrote: >> On 30.04.24 11:19, Markus Armbruster wrote: >>> Vladimir Sementsov-Ogievskiy writes: >>> Add command to sync config from vhost-user backend to the device. It may be helpful when VHOST_USER_

Re: [PATCH v4 13/17] softmmu: Pass RAM MemoryRegion and is_write xen_map_cache()

2024-05-02 Thread David Hildenbrand
On 30.04.24 18:49, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Propagate MR and is_write to xen_map_cache(). I'm pretty sure the patch subject is missing a "to" :) This is in preparation for adding support for grant mappings. No functional change. Reviewed-by: David Hildenbrand

Re: [PATCH v4 15/17] xen: mapcache: Remove assumption of RAMBlock with 0 offset

2024-05-02 Thread Edgar E. Iglesias
On Wed, May 1, 2024 at 11:24 PM Stefano Stabellini wrote: > > On Tue, 30 Apr 2024, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > The current mapcache assumes that all memory is mapped > > in a single RAM MR (the first one with offset 0). Remove > > this assumption and propagate t

<    1   2   3