Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-27 Thread Yong Huang
On Fri, Sep 27, 2024 at 11:35 PM Peter Xu wrote: > On Fri, Sep 27, 2024 at 10:50:01AM +0800, Yong Huang wrote: > > On Fri, Sep 27, 2024 at 3:55 AM Peter Xu wrote: > > > > > On Fri, Sep 27, 2024 at 02:13:47AM +0800, Yong Huang wrote: > > > > On Thu, Sep 26, 2024 at 3:17 AM Peter Xu wrote: > > >

Re: Re: [PATCH v2 0/2] Drop ignore_memory_transaction_failures for xilink_zynq

2024-09-27 Thread Chao Liu
On 2024/9/27 22:20, Peter Maydell wrote: On Fri, 27 Sept 2024 at 15:03, Chao Liu wrote: On 2024/9/27 20:18, Peter Maydell wrote: On Fri, 27 Sept 2024 at 09:52, Chao Liu wrote: Even if our test set is not sufficiently comprehensive, we can create an unimp_device for the maximum address space al

Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-27 Thread Peter Xu
On Fri, Sep 27, 2024 at 10:50:01AM +0800, Yong Huang wrote: > On Fri, Sep 27, 2024 at 3:55 AM Peter Xu wrote: > > > On Fri, Sep 27, 2024 at 02:13:47AM +0800, Yong Huang wrote: > > > On Thu, Sep 26, 2024 at 3:17 AM Peter Xu wrote: > > > > > > > On Fri, Sep 20, 2024 at 10:43:31AM +0800, Yong Huang

Re: [PATCH] qapi, machine-qmp-cmds.c: query-accelerator support

2024-09-27 Thread Daniel P . Berrangé
Markus: QAPI design Qs for you at the bottom On Wed, Sep 25, 2024 at 10:19:33AM -0300, Daniel Henrique Barboza wrote: > > > On 9/19/24 9:22 AM, Daniel P. Berrangé wrote: > > On Thu, Sep 19, 2024 at 08:20:56AM -0300, Daniel Henrique Barboza wrote: > > > Add a QMP command that shows all specific p

[PATCH v2 2/4] hw/ppc/spapr_vof: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Directly call ldn_be_p once instead of ldl_be_p / ldq_be_p. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_vof.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/hw/ppc/spapr_vof.c b/hw/ppc/spapr_vof.c index c02eaacfed..d238a44d88 100644 --

[PATCH v2 3/4] hw/ppc/vof: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Instead of be32_to_cpu (equivalent of ldl_be_p) and ldq_be_p, use ldn_be_p(). Similarly instead of cpu_to_be32 (equiv. stl_be_p) and cpu_to_be64 (equiv. stq_be_p), use stn_be_p(). Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/vof.c | 26 +- 1 file changed, 9 insertions

[PATCH v2 4/4] net/l2tpv3: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Directly call ldn_be_p once instead of ldl_be_p / ldq_be_p. Signed-off-by: Philippe Mathieu-Daudé --- net/l2tpv3.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index b5547cb917..7a0d5dcfe9 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -31

RE: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-27 Thread Sean Hefty
> > > I have met with the team from IONOS about their testing on actual IB > > > hardware here at KVM Forum today and the requirements are starting > > > to make more sense to me. I didn't say much in our previous thread > > > because I misunderstood the requirements, so let me try to explain > > >

[PATCH v2 1/4] hw/ppc/spapr_nvdimm: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
ldn/stn methods handle the access size, no need for the switch case. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_nvdimm.c | 47 --- 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/hw/ppc/spapr_nvdimm.c b/hw/ppc/spapr_nvdimm.c inde

[PATCH v2 0/4] hw/ppc & net: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Use ldN / stN methods to access variable lengths. v2: - Include unstaged change in vof.c Philippe Mathieu-Daudé (4): hw/ppc/spapr_nvdimm: Simplify LD/ST API uses hw/ppc/spapr_vof: Simplify LD/ST API uses hw/ppc/vof: Simplify LD/ST API uses net/l2tpv3: Simplify LD/ST API uses hw/ppc/spap

[PATCH 4/4] net/l2tpv3: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Directly call ldn_be_p once instead of ldl_be_p / ldq_be_p. Signed-off-by: Philippe Mathieu-Daudé --- net/l2tpv3.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/l2tpv3.c b/net/l2tpv3.c index b5547cb917..7a0d5dcfe9 100644 --- a/net/l2tpv3.c +++ b/net/l2tpv3.c @@ -31

[PATCH 2/4] hw/ppc/spapr_vof: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Directly call ldn_be_p once instead of ldl_be_p / ldq_be_p. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_vof.c | 27 +-- 1 file changed, 9 insertions(+), 18 deletions(-) diff --git a/hw/ppc/spapr_vof.c b/hw/ppc/spapr_vof.c index c02eaacfed..d238a44d88 100644 --

[PATCH 3/4] hw/ppc/vof: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Directly call ldn_be_p once instead of be32_to_cpu / ldq_be_p. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/vof.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c index b5b6514d79..fb152efbe0 100644 --- a/hw/ppc/vof.c +++ b/hw/ppc/vof.c @@

[PATCH 0/4] hw/ppc & net: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
Use ldN / stN methods to access variable lengths. Philippe Mathieu-Daudé (4): hw/ppc/spapr_nvdimm: Simplify LD/ST API uses hw/ppc/spapr_vof: Simplify LD/ST API uses hw/ppc/vof: Simplify LD/ST API uses net/l2tpv3: Simplify LD/ST API uses hw/ppc/spapr_nvdimm.c | 47

[PATCH 1/4] hw/ppc/spapr_nvdimm: Simplify LD/ST API uses

2024-09-27 Thread Philippe Mathieu-Daudé
ldn/stn methods handle the access size, no need for the switch case. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_nvdimm.c | 47 --- 1 file changed, 4 insertions(+), 43 deletions(-) diff --git a/hw/ppc/spapr_nvdimm.c b/hw/ppc/spapr_nvdimm.c inde

[PATCH 2/2] hw/loongarch/fw_cfg: Build in common_ss[]

2024-09-27 Thread Philippe Mathieu-Daudé
Nothing in LoongArch fw_cfg.c requires target specific definitions. Signed-off-by: Philippe Mathieu-Daudé --- hw/loongarch/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/loongarch/meson.build b/hw/loongarch/meson.build index bce7ebac97..005f017e21 100644 --- a

[PATCH 0/2] hw/loongarch: Build fw_cfg.c as common object

2024-09-27 Thread Philippe Mathieu-Daudé
LoongArch fw_cfg.c doesn't use target specific declarations, build it as common object. Philippe Mathieu-Daudé (2): hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion hw/loongarch/fw_cfg: Build in common_ss[] include/hw/loongarch/virt.h | 1 - hw/loongarch/meson.build| 2 +- 2 files

[PATCH 1/2] hw/loongarch/virt: Remove unnecessary 'cpu.h' inclusion

2024-09-27 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- include/hw/loongarch/virt.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/hw/loongarch/virt.h b/include/hw/loongarch/virt.h index c373e48f27..9ba47793ef 100644 --- a/include/hw/loongarch/virt.h +++ b/include/hw/loongarch/virt.h @@ -8,7 +8,6 @

Re: [PATCH 03/14] rust: define traits and pointer wrappers to convert from/to C representations

2024-09-27 Thread Paolo Bonzini
On Fri, Sep 27, 2024 at 6:10 PM Kevin Wolf wrote: > Am 01.07.2024 um 16:58 hat Paolo Bonzini geschrieben: > > The qemu::util::foreign module provides: > > > > - A trait for structs that can be converted to a C ("foreign") > > representation > > (CloneToForeign) > > > > - A trait for structs tha

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-27 Thread Michael Galaxy
Hi Gonglei, On 9/22/24 20:04, Gonglei (Arei) wrote: !---| This Message Is From an External Sender This message came from outside your organization. |---! Hi, -

Re: [PATCH 03/14] rust: define traits and pointer wrappers to convert from/to C representations

2024-09-27 Thread Paolo Bonzini
On Fri, Sep 27, 2024 at 9:36 PM Stefan Hajnoczi wrote: > > On Mon, 1 Jul 2024 at 11:02, Paolo Bonzini wrote: > > +/// A type for which there is a canonical representation as a C datum. > > +pub trait CloneToForeign { > > +/// The representation of `Self` as a C datum. Typically a > > +//

[PATCH v3 1/5] amd_iommu: Rename variable mmio to mr_mmio

2024-09-27 Thread Santosh Shukla
From: Suravee Suthikulpanit Rename the MMIO memory region variable 'mmio' to 'mr_mmio' so to correctly name align with struct AMDVIState::variable type. No functional change intended. Reviewed-by: Alejandro Jimenez Signed-off-by: Suravee Suthikulpanit Signed-off-by: Santosh Shukla --- hw/i3

Re: [PATCH] util/co-shared-resource: Remove unused co_try_get_from_shres

2024-09-27 Thread Vladimir Sementsov-Ogievskiy
On 18.09.24 15:42, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" co_try_get_from_shres hasn't been used since it was added in 55fa54a789 ("co-shared-resource: protect with a mutex") (Everyone uses the _locked version) Remove it. Signed-off-by: Dr. David Alan Gilbert Thanks, appli

Re: [PATCH] block: Remove unused aio_task_pool_empty

2024-09-27 Thread Vladimir Sementsov-Ogievskiy
On 17.09.24 03:20, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" aio_task_pool_empty has been unused since it was added in 6e9b225f73 ("block: introduce aio task pool") Remove it. Signed-off-by: Dr. David Alan Gilbert Thanks, applied to my block branch. -- Best regards, Vladimir

Re: [PATCH 03/14] rust: define traits and pointer wrappers to convert from/to C representations

2024-09-27 Thread Stefan Hajnoczi
On Mon, 1 Jul 2024 at 11:02, Paolo Bonzini wrote: > +/// A type for which there is a canonical representation as a C datum. > +pub trait CloneToForeign { > +/// The representation of `Self` as a C datum. Typically a > +/// `struct`, though there are exceptions for example `c_char` > +

Re: [PATCH v2] hw/arm/xlnx: Connect secondary CGEM IRQs

2024-09-27 Thread Peter Maydell
On Wed, 25 Sept 2024 at 20:34, Kinsey Moore wrote: > > Hey, > I just wanted to check on the status of this patch since it's been sitting > for a bit now and I noticed it hasn't gone into any branches. Is this waiting > on something from me? No, I'm afraid I just hadn't noticed it to pick it up.

Re: [PATCH v1 07/14] s390x/s390-hypercall: introduce DIAG500 STORAGE_LIMIT

2024-09-27 Thread David Hildenbrand
On 27.09.24 20:05, Halil Pasic wrote: On Thu, 12 Sep 2024 10:19:00 +0200 Thomas Huth wrote: diff --git a/hw/s390x/s390-hypercall.h b/hw/s390x/s390-hypercall.h index b7ac29f444..f0ca62bcbb 100644 --- a/hw/s390x/s390-hypercall.h +++ b/hw/s390x/s390-hypercall.h @@ -18,6 +18,7 @@ #define DIAG50

[RFC V2 PATCH 04/11] acpi: Support Control Method sleep button for x86

2024-09-27 Thread Annie Li
Adding Control Method Sleep button and its GPE event handler for x86. Signed-off-by: Annie Li --- hw/i386/acpi-build.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 5d4bd2b710..ee62333a03 100644 --- a/hw/i386/acpi-build.c +++ b/hw/

[RFC V2 PATCH 07/11] hw/acpi: Add ACPI GED support for the sleep event

2024-09-27 Thread Annie Li
From: Miguel Luis Add support for ACPI GED sleep event on the ACPI device interface so that HW-reduced systems can enable guests to sleep. Signed-off-by: Miguel Luis --- hw/acpi/generic_event_device.c | 9 + include/hw/acpi/generic_event_device.h | 1 + 2 files changed, 10 inse

[RFC V2 PATCH 06/11] acpi: Send the GPE event of suspend and wakeup for x86

2024-09-27 Thread Annie Li
The GPE event is triggered to notify the guest to suppend or wakeup itself. Signed-off-by: Annie Li --- hw/acpi/core.c | 17 + hw/core/machine-qmp-cmds.c | 2 ++ include/hw/acpi/acpi.h | 1 + include/hw/acpi/acpi_dev_interface.h |

[RFC V2 PATCH 10/11] tests/acpi: Update FACP and DSDT tables for sleep button

2024-09-27 Thread Annie Li
From: Miguel Luis [000h 4]Signature : "FACP"[Fixed ACPI Description Table (FADT)] [004h 0004 4] Table Length : 0114 [008h 0008 1] Revision : 06 -[009h 0009 1] Checksum : 12 +[009h 0009 1]

[RFC V2 PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

2024-09-27 Thread Annie Li
Followng hmp/qmp commands are implemented for pressing virtual sleep button, hmp: system_sleep qmp: { "execute": "system_sleep" } These commands put the guest into suspend or other power states depending on the power settings inside the guest. Signed-off-by: Annie Li --- hmp-commands.hx

[RFC V2 PATCH 11/11] arm/virt: enable sleep support

2024-09-27 Thread Annie Li
From: Miguel Luis For reference: qmp_system_sleep relies on wakeup support delegated by qemu_wakeup_suspend_enabled() hence the need for calling qemu_register_wakeup_support(). With this, we should be able to issue QMP system_sleep command now. Signed-off-by: Miguel Luis --- hw/arm/virt.c | 1

[RFC V2 PATCH 09/11] hw/arm: enable sleep support for arm/virt

2024-09-27 Thread Annie Li
From: Miguel Luis Include the ACPI control method device into arm/virt ACPI tables and the corresponding handling which enables triggering the event. Signed-off-by: Miguel Luis --- hw/arm/virt-acpi-build.c | 13 + hw/arm/virt.c| 13 - include/hw/arm/virt.h

[RFC V2 PATCH 02/11] acpi: Implement control method sleep button

2024-09-27 Thread Annie Li
The control method sleep button is added, as well as its GPE event handler. Co-developed-by: Miguel Luis Signed-off-by: Annie Li --- hw/acpi/control_method_device.c | 54 + hw/acpi/meson.build | 1 + include/hw/acpi/control_method_device.h |

[RFC V2 PATCH 05/11] tests/acpi: Update DSDT tables for Control method sleep button

2024-09-27 Thread Annie Li
Below is the sample iASL difference, * Signature"DSDT" - * Length 0x20A3 (8355) + * Length 0x2159 (8537) * Revision 0x01 32-bit table (V1), no 64-bit math support - * Checksum 0x37 + * Checksum 0x40 *

[RFC V2 PATCH 03/11] test/acpi: allow DSDT table changes

2024-09-27 Thread Annie Li
Signed-off-by: Annie Li --- tests/qtest/bios-tables-test-allowed-diff.h | 41 + 1 file changed, 41 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h index dfb8523c8b..512d40665d 100644 --- a/tests/qtest/bios-

[RFC V2 PATCH 08/11] tests/acpi: allow FACP and DSDT table changes for arm/virt

2024-09-27 Thread Annie Li
From: Miguel Luis List changed files for FACP and DSDT table changes for the arm/virt. Signed-off-by: Miguel Luis --- tests/qtest/bios-tables-test-allowed-diff.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-tes

[RFC V2 PATCH 00/11] Support ACPI Control Method Sleep button

2024-09-27 Thread Annie Li
The ACPI sleep button can be implemented as a fixed hardware button or Control Method Sleep button. The patch of implementing a fixed hardware sleep button was posted here 1). More discussions can be found here 2). Essentially, the discussion mainly focuses on whether the sleep button is implement

Re: [PATCH v1 00/14] s390x: virtio-mem support

2024-09-27 Thread David Hildenbrand
On 27.09.24 20:20, Halil Pasic wrote: On Wed, 11 Sep 2024 21:09:27 +0200 David Hildenbrand wrote: Anyway, if we want to proceed with the gitlab project, would it make sense to create an org for it, so that it doesn't look like David's personal project? Frankly, I would prefer making Document

Re: [PATCH 06/23] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources

2024-09-27 Thread Bernhard Beschow
Am 23. September 2024 10:28:35 UTC schrieb BALATON Zoltan : >On Mon, 23 Sep 2024, Bernhard Beschow wrote: >> Rather than accessing the attributes of TYPE_CCSR directly, use the >> SysBusDevice >> API which exists exactly for that purpose. Furthermore, registering the >> memory >> region with t

[PATCH v3 2/5] amd_iommu: Add support for pass though mode

2024-09-27 Thread Santosh Shukla
From: Suravee Suthikulpanit Introduce 'nodma' shared memory region to support PT mode so that for each device, we only create an alias to shared memory region when DMA-remapping is disabled. Reviewed-by: Alejandro Jimenez Signed-off-by: Suravee Suthikulpanit Signed-off-by: Santosh Shukla ---

Re: [PATCH v1 07/14] s390x/s390-hypercall: introduce DIAG500 STORAGE_LIMIT

2024-09-27 Thread Halil Pasic
On Thu, 12 Sep 2024 10:19:00 +0200 Thomas Huth wrote: > > diff --git a/hw/s390x/s390-hypercall.h b/hw/s390x/s390-hypercall.h > > index b7ac29f444..f0ca62bcbb 100644 > > --- a/hw/s390x/s390-hypercall.h > > +++ b/hw/s390x/s390-hypercall.h > > @@ -18,6 +18,7 @@ > > #define DIAG500_VIRTIO_RESET

Re: [PATCH v1 00/14] s390x: virtio-mem support

2024-09-27 Thread Halil Pasic
On Wed, 11 Sep 2024 21:09:27 +0200 David Hildenbrand wrote: > > Anyway, if we want to proceed with the gitlab project, would it make > > sense to create an org for it, so that it doesn't look like David's > > personal project? Frankly, I would prefer making Documentation/virt/kvm/s390/s390-diag.

[PATCH v3 3/5] amd_iommu: Use shared memory region for Interrupt Remapping

2024-09-27 Thread Santosh Shukla
From: Suravee Suthikulpanit Use shared memory region for interrupt remapping which can be aliased by all devices. Reviewed-by: Alejandro Jimenez Signed-off-by: Suravee Suthikulpanit Signed-off-by: Santosh Shukla --- hw/i386/amd_iommu.c | 22 ++ hw/i386/amd_iommu.h | 1 +

[PATCH v3 5/5] amd_iommu: Check APIC ID > 255 for XTSup

2024-09-27 Thread Santosh Shukla
From: Suravee Suthikulpanit The XTSup mode enables x2APIC support for AMD IOMMU, which is needed to support vcpu w/ APIC ID > 255. Reviewed-by: Alejandro Jimenez Signed-off-by: Suravee Suthikulpanit Signed-off-by: Santosh Shukla --- v3: - Fixed the typos: s/xt/xtsup at error_report() hw/i38

[PATCH v3 4/5] amd_iommu: Send notification when invalidate interrupt entry cache

2024-09-27 Thread Santosh Shukla
From: Suravee Suthikulpanit In order to support AMD IOMMU interrupt remapping emulation with PCI pass-through devices, QEMU needs to notify VFIO when guest IOMMU driver updates and invalidate the guest interrupt remapping table (IRT), and communicate information so that the host IOMMU driver can

[PATCH v3 0/5] Interrupt Remap support for emulated amd viommu

2024-09-27 Thread Santosh Shukla
Series adds following feature support for emulated amd vIOMMU 1) Pass Through(PT) mode 2) Interrupt Remapping(IR) mode 1) PT mode Introducing the shared 'nodma' memory region that can be aliased by all the devices in the PT mode. Shared memory with aliasing approach will help run VM faster when lo

Re: [PATCH 08/18] pc-bios/s390-ccw: Remove panics from ECKD IPL path

2024-09-27 Thread Jared Rossi
On 9/27/24 11:29 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from ECKD block device IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return

Re: [PATCH 07/18] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-09-27 Thread Jared Rossi
On 9/27/24 11:02 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code

Re: [PATCH v1 1/7] migration: Introduce structs for background sync

2024-09-27 Thread Hyman Huang
在 2024/9/27 23:35, Peter Xu 写道: On Fri, Sep 27, 2024 at 10:50:01AM +0800, Yong Huang wrote: On Fri, Sep 27, 2024 at 3:55 AM Peter Xu wrote: On Fri, Sep 27, 2024 at 02:13:47AM +0800, Yong Huang wrote: On Thu, Sep 26, 2024 at 3:17 AM Peter Xu wrote: On Fri, Sep 20, 2024 at 10:43:31AM +080

Re: [PATCH] MAINTAINERS: Update STM32L4x5 and B-L475E-IOT01A maintainers

2024-09-27 Thread Peter Maydell
On Sat, 21 Sept 2024 at 11:48, Inès Varhol wrote: > > It has been a learning experience to contribute to QEMU for our > end-of-studies project. For a few months now, Arnaud and I aren't > actively involved anymore as we lack time and access to the hardware. > Therefore it's high time to update the

Re: [PATCH 03/14] rust: define traits and pointer wrappers to convert from/to C representations

2024-09-27 Thread Kevin Wolf
Hi Paolo, as you asked me at KVM Forum to have a look at this, I'm going through it now. Am 01.07.2024 um 16:58 hat Paolo Bonzini geschrieben: > The qemu::util::foreign module provides: > > - A trait for structs that can be converted to a C ("foreign") representation > (CloneToForeign) > > -

Re: [PATCH v2 18/22] hw/virtio: fix -Werror=maybe-uninitialized false-positive

2024-09-27 Thread Eugenio Perez Martin
On Wed, Sep 25, 2024 at 10:08 AM Stefano Garzarella wrote: > > On Tue, Sep 24, 2024 at 05:05:49PM GMT, marcandre.lur...@redhat.com wrote: > >From: Marc-André Lureau > > For the title: I don't think it is a false positive, but a real fix, > indeed maybe not a complete one. > > > > >../hw/virtio/vh

Re: [PATCH 08/18] pc-bios/s390-ccw: Remove panics from ECKD IPL path

2024-09-27 Thread Thomas Huth
On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from ECKD block device IPL specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-b

Re: [PULL 00/31] tcg + linux-user patch queue

2024-09-27 Thread Peter Maydell
On Sun, 22 Sept 2024 at 13:01, Richard Henderson wrote: > > The following changes since commit 01dc65a3bc262ab1bec8fe89775e9bbfa627becb: > > Merge tag 'pull-target-arm-20240919' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-09-19 > 14:15:15 +0100) > > are available in

Re: [PATCH 07/18] pc-bios/s390-ccw: Remove panics from ISO IPL path

2024-09-27 Thread Thomas Huth
On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from IPL ISO El Torito specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-off-by: Jared Rossi --- pc-bios/

[PATCH 2/4] Add RCC device to stm32f405 SoC

2024-09-27 Thread Román Cárdenas Rodríguez
Signed-off-by: Roman Cardenas Rodriguez --- docs/system/arm/stm32.rst | 3 ++- hw/arm/Kconfig | 1 + hw/arm/stm32f405_soc.c | 12 +++- include/hw/arm/stm32f405_soc.h | 2 ++ 4 files changed, 16 insertions(+), 2 deletions(-) diff --git a/docs/system/arm/stm

[PATCH 4/4] Add GPIO device to stm32f405 SoC

2024-09-27 Thread Román Cárdenas Rodríguez
Signed-off-by: Roman Cardenas Rodriguez --- hw/arm/Kconfig | 1 + hw/arm/stm32f405_soc.c | 40 ++ hw/misc/stm32f4xx_syscfg.c | 24 include/hw/arm/stm32f405_soc.h | 3 +++ 4 files changed, 50 insertions(+), 18 delet

[PATCH 3/4] STM32: new GPIO device

2024-09-27 Thread Román Cárdenas Rodríguez
Generic GPIO class for STM32 devices. It can be used for most of STM32 chips. Note that it does not implement configuration locking mechanisms. Signed-off-by: Roman Cardenas Rodriguez --- hw/gpio/Kconfig | 3 + hw/gpio/meson.build | 1 + hw/gpio/stm32_gpio.c | 3

[PATCH 1/4] STM32F4: new RCC device

2024-09-27 Thread Román Cárdenas Rodríguez
Generic RCC class for STM32 devices. It can be used for most of STM32 chips. Note that it only implements enable and reset capabilities. Signed-off-by: Roman Cardenas Rodriguez --- hw/misc/Kconfig | 3 + hw/misc/meson.build | 1 + hw/misc/stm32_rcc.c | 162 +++

Re: [PATCH v2 0/2] Drop ignore_memory_transaction_failures for xilink_zynq

2024-09-27 Thread Peter Maydell
On Fri, 27 Sept 2024 at 15:03, Chao Liu wrote: > On 2024/9/27 20:18, Peter Maydell wrote: >> On Fri, 27 Sept 2024 at 09:52, Chao Liu wrote: >> Even if our test set is not sufficiently comprehensive, we can create an >> unimp_device for the maximum address space allowed by the board. This >> prev

Re: [PATCH v3 0/6] Support GPIO for AST2700

2024-09-27 Thread Konstantin Ryabitsev
On Fri, Sep 27, 2024 at 06:29:22AM GMT, Jamin Lin wrote: > > Also, your emails have an invalid "From" field set to > > "qemu-devel@nongnu.org" when retrieved with the b4 command. This is almost certainly done by the mailman list running on nongnu.org. It's a very patch-hostile setting, so I'm surp

Re: [PATCH v2 2/5] amd_iommu: Add support for pass though mode

2024-09-27 Thread Shukla, Santosh
On 9/21/2024 1:56 AM, Alejandro Jimenez wrote: > Hi Santosh, > > On 9/16/24 10:31, Santosh Shukla wrote: >> From: Suravee Suthikulpanit >> >> Introduce 'nodma' shared memory region to support PT mode >> so that for each device, we only create an alias to shared memory >> region when DMA-remapp

Re: [PATCH v2 0/2] Drop ignore_memory_transaction_failures for xilink_zynq

2024-09-27 Thread Chao Liu
On 2024/9/27 20:18, Peter Maydell wrote: On Fri, 27 Sept 2024 at 09:52, Chao Liu wrote: Hi, thank you for your prompt reply, it's a great encouragement to me! Based on your review suggestions, I have improved the v1 patch. By using create_unimplemented_device() during the initialization phase

[PATCH 7/8] target/mips: Enable MSA ASE for mips32r6-generic

2024-09-27 Thread Aleksandar Rakic
Enable MSA ASE for mips32r6-generic CPU. Cherry-picked 0186e83a0613e90aff6d4c12c91cdb080d695d37 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Aleksandar Markovic Signed-off-by: Faraz Shahbazker Signed-off-by: Aleksandar Rakic --- target/mips/cpu-defs.c.inc | 8 +--- 1 file cha

Re: [PATCH 4/8] Skip NaN mode check for soft-float

2024-09-27 Thread Peter Maydell
On Fri, 27 Sept 2024 at 14:27, Aleksandar Rakic wrote: > > Skip NaN mode check for soft-float. > > Cherry-picked 63492a56485f6b755fccf7ad623f7a189bfc79b6 > from https://github.com/MIPS/gnutools-qemu Please could you provide proper commit messages that justify why the change is being made? "We got

[PATCH 6/8] Revert use of clock_gettime for benchmarking

2024-09-27 Thread Aleksandar Rakic
This patch reverts the commit (with SHA 50290c002c045280f8defad911901e16bfb52884 from https://github.com/MIPS/gnutools-qemu) that breaks for mingw builds, where clock_gettime and CLOCK_MONOTONIC are not available. Cherry-picked d57c735e1af1ca719dbd0c3a904ad70c9c31cbb7 from https://github.com/MIPS/

[PATCH 0/8] Introduce MIPS64r6 target

2024-09-27 Thread Aleksandar Rakic
This patch series introduces support for the MIPS64r6 target in QEMU, bringing the latest architecture features and improvements to the MIPS target. In addition to the new target, this series also includes several bug fixes that have been in use internally for years within the MIPS ecosystem. The

[PATCH 4/8] Skip NaN mode check for soft-float

2024-09-27 Thread Aleksandar Rakic
Skip NaN mode check for soft-float. Cherry-picked 63492a56485f6b755fccf7ad623f7a189bfc79b6 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Faraz Shahbazker Signed-off-by: Aleksandar Rakic --- linux-user/mips/cpu_loop.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 3/8] GTM19-448: Fix script to work without realpath

2024-09-27 Thread Aleksandar Rakic
The archive-source.sh script depends on realpath command, which was introduced in coreutils-8.15. CentOS-6 build systems use coreutils-4.7, which does not have realpath, so fix the script to use 'readlink -e' to perform the same action. Cherry-picked 5d1d5766f0219ce2bec4e41c2467317df920ec0a and 80

[PATCH 8/8] target/mips: Enable MSA ASE for mips64R2-generic

2024-09-27 Thread Aleksandar Rakic
Enable MSA ASE for mips64R2-generic CPU. Cherry-picked 60f6ae8d3d685ba1ea5d301222fb72b67f39264f from https://github.com/MIPS/gnutools-qemu Signed-off-by: Faraz Shahbazker Signed-off-by: Aleksandar Rakic --- target/mips/cpu-defs.c.inc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) d

[PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-09-27 Thread MingZhu Yan
Applications sometimes only write the lower 32-bit payload bytes, this is used in ACT tests. As a workaround, this refers to the solution of sail-riscv. if the payload is written a few times with the same value, we process the whole htif command anyway. Signed-off-by: MingZhu Yan --- hw/char/ris

[PATCH 1/8] Add CP0 MemoryMapID register implementation

2024-09-27 Thread Aleksandar Rakic
Add CP0 MemoryMapID register implementation. Cherry-picked 9e0cb40adb110c2c76e2e97719ba8afcce72bcf5 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Aleksandar Rakic --- target/mips/sysemu/machine.c | 7 +-- 1 file cha

[PATCH 5/8] Add micromips to P5600

2024-09-27 Thread Aleksandar Rakic
Add micromips to P5600. Cherry-picked d7bf2c2f7f2e03b55c6e9c57eec5c3e6207005a0 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Faraz Shahbazker Signed-off-by: Matthew Fortune Signed-off-by: Aleksandar Rakic --- target/mips/cpu-defs.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH 2/8] Add support for emulation of CRC32 instructions

2024-09-27 Thread Aleksandar Rakic
Add emulation of MIPS' CRC32 (Cyclic Redundancy Check) instructions. Reuse zlib crc32() and Linux crc32c(). Cherry-picked 4cc974938aee1588f852590509004e340c072940 from https://github.com/MIPS/gnutools-qemu Signed-off-by: Yongbok Kim Signed-off-by: Aleksandar Markovic Signed-off-by: Aleksandar R

[PATCH] hw/char/riscv_htif: Fix htif_mm_write that causes infinite loop in ACT.

2024-09-27 Thread MingZhu Yan
Applications sometimes only write the lower 32-bit payload bytes, this is used in ACT tests. As a workaround, this refers to the solution of sail-riscv. if the payload is written a few times with the same value, we process the whole htif command anyway. Signed-off-by: MingZhu Yan --- hw/char/ris

Re: [PATCH] hw/x86: Always treat the PVH entrypoint as a 32-bit field

2024-09-27 Thread Ard Biesheuvel
On Fri, 27 Sept 2024 at 14:05, Paolo Bonzini wrote: > > On 9/27/24 09:19, Ard Biesheuvel wrote: > > - > > -pvh_start_addr = *(uint32_t *)elf_note_data_addr; > > } > > > > +pvh_start_addr = *(uint32_t *)elf_note_data_addr; > > I think we even want ldl_le_p(elf_note_data_addr) here

Re: [PATCH V3] arm/kvm: add support for MTE

2024-09-27 Thread Ganapatrao Kulkarni
On 26-09-2024 09:41 pm, Gustavo Romero wrote: Hi Cornelia and Ganapatrao, On 9/25/24 14:54, Cornelia Huck wrote: On Fri, Sep 20 2024, Ganapatrao Kulkarni wrote: Mostly nit-picking below, otherwise LGTM. Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don

Re: [PATCH v2 18/22] hw/virtio: fix -Werror=maybe-uninitialized false-positive

2024-09-27 Thread Eugenio Perez Martin
On Tue, Sep 24, 2024 at 3:07 PM wrote: > > From: Marc-André Lureau > > ../hw/virtio/vhost-shadow-virtqueue.c:545:13: error: ‘r’ may be used > uninitialized [-Werror=maybe-uninitialized] > > Signed-off-by: Marc-André Lureau > --- > hw/virtio/vhost-shadow-virtqueue.c | 2 +- > 1 file changed, 1

Re: [PATCH v2 0/2] Drop ignore_memory_transaction_failures for xilink_zynq

2024-09-27 Thread Peter Maydell
On Fri, 27 Sept 2024 at 09:52, Chao Liu wrote: > > Hi, thank you for your prompt reply, it's a great encouragement to me! > > Based on your review suggestions, I have improved the v1 patch. > > By using create_unimplemented_device() during the initialization phase, > I added a "znyq.umip" device e

Re: [PATCH v3 0/6] Support GPIO for AST2700

2024-09-27 Thread Cédric Le Goater
On 9/27/24 08:29, Jamin Lin wrote: Also, your emails have an invalid "From" field set to "qemu-devel@nongnu.org" when retrieved with the b4 command. I have been fixing them for a while. Could you please tell us how you send the patchsets ? hmm, curious. I wonder what's happening. Thanks, C.

Re: [PATCH] hw/x86: Always treat the PVH entrypoint as a 32-bit field

2024-09-27 Thread Paolo Bonzini
On 9/27/24 09:19, Ard Biesheuvel wrote: - -pvh_start_addr = *(uint32_t *)elf_note_data_addr; } +pvh_start_addr = *(uint32_t *)elf_note_data_addr; I think we even want ldl_le_p(elf_note_data_addr) here? It makes no sense to read big-endian data. Paolo

[PATCH v2 1/2] kvm: Allow kvm_arch_get/put_registers to accept Error**

2024-09-27 Thread Julia Suvorova
This is necessary to provide discernible error messages to the caller. Signed-off-by: Julia Suvorova Reviewed-by: Peter Xu --- accel/kvm/kvm-all.c| 41 +- include/sysemu/kvm.h | 4 ++-- target/arm/kvm.c | 4 ++-- target/i386/kvm/kvm.

[PATCH v2 0/2] kvm: Improve register failure reports for migration

2024-09-27 Thread Julia Suvorova
There were a few bugs with silent cpu failures during migrations [1]. The failures are no longer silent thanks to [2], but still indistinguishable, making diagnostics difficult. This patchset reworks kvm_arch_get/put_registers to handle Error** and return a correct message, with x86_64 as a start.

[PATCH v2 2/2] target/i386/kvm: Report which action failed in kvm_arch_put/get_registers

2024-09-27 Thread Julia Suvorova
To help debug and triage future failure reports (akin to [1,2]) that may occur during kvm_arch_put/get_registers, the error path of each action is accompanied by unique error message. [1] https://issues.redhat.com/browse/RHEL-7558 [2] https://issues.redhat.com/browse/RHEL-21761 Signed-off-by: Jul

Re: [PULL 0/6] Host Memory Backends and Memory devices queue 2024-09-24

2024-09-27 Thread Peter Maydell
On Tue, 24 Sept 2024 at 11:03, David Hildenbrand wrote: > > Hi, > > due to reset changes this contains a bit of churn that touches various > architectures, but it's all fairly minimal and straight-forward. > > The following changes since commit 01dc65a3bc262ab1bec8fe89775e9bbfa627becb: > > Merge

Re: [PATCH v5 6/7] aspeed/soc: Support GPIO for AST2700 and correct irq 130

2024-09-27 Thread Cédric Le Goater
Hello Jamin, On 9/27/24 10:33, Jamin Lin wrote: The register set of GPIO have a significant change since AST2700. Each GPIO pin has their own individual control register and users are able to set one GPIO pin’s direction, interrupt enable, input mask and so on in the same one control register.

Re: [PATCH v5 7/7] hw/gpio/aspeed: Add test case for AST2700

2024-09-27 Thread Thomas Huth
On 27/09/2024 10.33, Jamin Lin wrote: Add test case to test GPIO output and input pins from A0 to D7 for AST2700. Signed-off-by: Jamin Lin --- tests/qtest/aspeed_gpio-test.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a/tests/qtest/aspeed_gpio-test.c

Re: [PATCH v4 7/7] hw/gpio/aspeed: Add test case for AST2700

2024-09-27 Thread Thomas Huth
On 27/09/2024 10.12, Jamin Lin wrote: Hi Cedric, Subject: [PATCH v4 7/7] hw/gpio/aspeed: Add test case for AST2700 Add test case to test GPIO output and input pins from A0 to D7 for AST2700. Signed-off-by: Jamin Lin --- tests/qtest/aspeed_gpio-test.c | 64 ++

[PATCH 1/1] hw/cxl/cxl-mailbox-utils: Fix for device DDR5 ECS control feature tables

2024-09-27 Thread shiju . jose--- via
From: Shiju Jose CXL spec 3.1 section 8.2.9.9.11.2 describes the DDR5 Error Check Scrub (ECS) control feature. ECS log capabilities field in following ECS tables, which is common for all memory media FRUs in a CXL device. Fix struct CXLMemECSReadAttrs and struct CXLMemECSWriteAttrs to make log

[PATCH v2 2/2] xilink-zynq-devcfg: Fix up for memory address range size not set correctly

2024-09-27 Thread Chao Liu
Signed-off-by: Chao Liu --- hw/dma/xlnx-zynq-devcfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/dma/xlnx-zynq-devcfg.c b/hw/dma/xlnx-zynq-devcfg.c index b8544d0731..7170353a62 100644 --- a/hw/dma/xlnx-zynq-devcfg.c +++ b/hw/dma/xlnx-zynq-devcfg.c @@ -372,7 +372,7 @@ s

[PATCH v2 1/2] xilink_zynq: Add various missing unimplemented devices

2024-09-27 Thread Chao Liu
Add PMU, CAN, GPIO, I2C, and other as unimplemented devices. Remove a ignore_memory_transaction_failures concurrently. This allows operating systems such as Linux to run emulations such as xilinx_zynq-7000 Signed-off-by: Chao Liu --- hw/arm/xilinx_zynq.c | 46 +

[PATCH v2 0/2] Drop ignore_memory_transaction_failures for xilink_zynq

2024-09-27 Thread Chao Liu
Hi, thank you for your prompt reply, it's a great encouragement to me! Based on your review suggestions, I have improved the v1 patch. By using create_unimplemented_device() during the initialization phase, I added a "znyq.umip" device early on, which covers the 32-bit address space of GPA. This

[PATCH v5 3/7] hw/gpio/aspeed: Support different memory region ops

2024-09-27 Thread Jamin Lin via
It set "aspeed_gpio_ops" struct which containing read and write callbacks to be used when I/O is performed on the GPIO region. Besides, in the previous design of ASPEED SOCs, one register is used for setting one function for 32 GPIO pins. ex: GPIO000 is used for setting data value for GPIO A, B, C

[PATCH v5 4/7] hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index mode

2024-09-27 Thread Jamin Lin via
The interrupt status field is W1C, where a set bit on read indicates an interrupt is pending. If the bit extracted from data is set it should clear the corresponding bit in reg_value. However, if the extracted bit is clear then the value of the corresponding bit in reg_value should be unchanged. S

[PATCH v5 2/7] hw/gpio/aspeed: Support to set the different memory size

2024-09-27 Thread Jamin Lin via
According to the datasheet of ASPEED SOCs, a GPIO controller owns 4KB of register space for AST2700, AST2500, AST2400 and AST1030; owns 2KB of register space for AST2600 1.8v and owns 2KB of register space for AST2600 3.3v. It set the memory region size 2KB by default and it does not compatible re

[PATCH v5 6/7] aspeed/soc: Support GPIO for AST2700 and correct irq 130

2024-09-27 Thread Jamin Lin via
The register set of GPIO have a significant change since AST2700. Each GPIO pin has their own individual control register and users are able to set one GPIO pin’s direction, interrupt enable, input mask and so on in the same one control register. AST2700 does not have GPIO18_XXX registers for GPIO

[PATCH v5 7/7] hw/gpio/aspeed: Add test case for AST2700

2024-09-27 Thread Jamin Lin via
Add test case to test GPIO output and input pins from A0 to D7 for AST2700. Signed-off-by: Jamin Lin --- tests/qtest/aspeed_gpio-test.c | 68 ++ 1 file changed, 68 insertions(+) diff --git a/tests/qtest/aspeed_gpio-test.c b/tests/qtest/aspeed_gpio-test.c index d3

[PATCH v5 5/7] hw/gpio/aspeed: Add AST2700 support

2024-09-27 Thread Jamin Lin via
AST2700 integrates two set of Parallel GPIO Controller with maximum 212 control pins, which are 27 groups. (H, exclude pin: H7 H6 H5 H4) In the previous design of ASPEED SOCs, one register is used for setting one function for one set which are 32 pins and 4 groups. ex: GPIO000 is used for setting

  1   2   >