On 16/7/25 08:31, Xiaoyao Li wrote:
The implementation of host_cpu_max_instance_init() was merged into
host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
declaration of it remains in host-cpu.h.
Clean it up.
The implementation of host_cpu_max_instance_init() was merged into
host_cpu_instance_init() by commit 29f1ba338baf ("target/i386: merge
host_cpu_instance_init() and host_cpu_max_instance_init()"), while the
declaration of it remains in host-cpu.h.
Clean it up.
Signed-off-by: Xiaoyao Li
---
targ
On 7/16/2025 1:19 AM, Philippe Mathieu-Daudé wrote:
Generally APIs to the rest of QEMU should be documented in the headers.
Comments on individual functions or internal details are fine to live
in the C files. Make qemu_add_vm_change_state_handler_prio[_full]()
docstrings consistent by moving the
On 7/11/2025 3:46 AM, Babu Moger wrote:
Transient Scheduler Attacks (TSA) are new speculative side channel attacks
related to the execution timing of instructions under specific
microarchitectural conditions. In some cases, an attacker may be able to
use this timing information to infer data from
On 7/11/2025 3:46 AM, Babu Moger wrote:
Transient Scheduler Attacks (TSA) are new speculative side channel attacks
related to the execution timing of instructions under specific
microarchitectural conditions. In some cases, an attacker may be able to
use this timing information to infer data from
>-Original Message-
>From: Nicolin Chen
>Subject: Re: [RFC PATCH v3 06/15] hw/arm/smmuv3-accel: Restrict
>accelerated SMMUv3 to vfio-pci endpoints with iommufd
>
>On Tue, Jul 15, 2025 at 10:53:50AM +, Duan, Zhenzhong wrote:
>>
>>
>> >-Original Message-
>> >From: Shameer Kolo
Em Tue, 15 Jul 2025 13:36:26 -0400
"Michael S. Tsirkin" escreveu:
> On Thu, Jun 12, 2025 at 05:17:24PM +0200, Mauro Carvalho Chehab wrote:
> > Hi Michael,
> >
> > This is v10 of the patch series, rebased to apply after release
> > 10.0. The only difference against v9 is a minor confict resolutio
Add argument parsing to functional tests to improve developer experience
when running individual tests. All logs are printed to stdout
interspersed with TAP output.
./pyvenv/bin/python3 ../tests/functional/test_aarch64_virt.py --help
usage: test_aarch64_virt [-h] [-d]
QEMU Functional test
On 7/15/25 8:13 PM, Gustavo Romero wrote:
Hi Pierrick,
On 7/14/25 22:26, Pierrick Bouvier wrote:
On 7/14/25 4:31 PM, Gustavo Romero wrote:
Hi folks,
Richard, thanks for v8. Pierrick, thanks for testing it. :)
On 7/14/25 14:09, Pierrick Bouvier wrote:
On 7/14/25 8:58 AM, Richard Henderson wr
On Wed, Jul 16, 2025 at 12:25 AM Pierrick Bouvier
wrote:
>
> TF-A needs to be patched to enable support for FEAT_TCR2 and
> FEAT_SCTLR2. This new image contains updated firmware.
>
> Signed-off-by: Pierrick Bouvier
> ---
> tests/functional/test_aarch64_rme_sbsaref.py | 9 +
> tests/funct
usage: timestamp-based-on-real-time=[on|off]
Instead of using number of instructions executed (which is per vcpu), we
use the wall time for timestamps. This is useful when tracing user mode
programs as well.
Signed-off-by: Pierrick Bouvier
---
contrib/plugins/uftrace.c | 27
usage: trace-privilege-level=[on|off]
This option generates different traces (represented as different
processes in uftrace), allowing to follow privilege level changes.
For aarch64, we track current EL and Security State.
As well, we make sure that sampling works correctly with this option. If
This documentation summarizes how to use the plugin, and present two
examples of the possibilities offered by it.
As well, it explains how to rebuild and reproduce easily the system boot
example.
Signed-off-by: Pierrick Bouvier
---
docs/about/emulation.rst | 184 +++
usage: contrib/plugins/uftrace_symbols.py \
--prefix-symbols \
arm-trusted-firmware/build/qemu/debug/bl1/bl1.elf \
arm-trusted-firmware/build/qemu/debug/bl2/bl2.elf \
arm-trusted-firmware/build/qemu/debug/bl31/bl31.elf \
u-boot/u-boot:0x6000 \
u-
This plugin generates a binary trace compatible with:
https://github.com/namhyung/uftrace
It tracks frame pointer during execution, detecting function
calls/returns and works in system and user mode.
It's implemented for aarch64 only (adding other architecture should
be trivial, especially x86_64
This plugin generates a binary trace compatible with the excellent uftrace:
https://github.com/namhyung/uftrace
In short, it tracks all function calls performed during execution, based on
frame pointer analysis. A big advantage over "uftrace record" is that it works
in system mode, allowing to tra
usage: trace-sample=N
Allow to use sampling (every N instructions) for tracking the stack.
We implement a fast mode, where instrumentation is only per tb, and
simply dump current stack, and unwind new one, instead of tracking every
frame pointer change.
Signed-off-by: Pierrick Bouvier
---
contr
On 16/07/2025 00.20, John Snow wrote:
fwiw, I think this is important enough / harmless enough to sneak into
the rc releases, if possible.
Yes, sounds like a good idea to avoid breakage with the latest Python versions.
Series
Reviewed-by: Thomas Huth
On Tue, Jul 15, 2025 at 5:28 PM John Sn
On 16/7/25 04:21, Jason Wang wrote:
Hi Stefan:
On Wed, Jul 16, 2025 at 3:55 AM Stefan Hajnoczi wrote:
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any
user-visible changes.
I sent a V2 of the PULL:
https://mail.gnu.org/archive/html/qemu-devel/2
On Thu, Jul 10, 2025 at 02:46:11PM -0500, Babu Moger wrote:
> Date: Thu, 10 Jul 2025 14:46:11 -0500
> From: Babu Moger
> Subject: [PATCH v2 2/2] target/i386: Add TSA feature flag verw-clear
> X-Mailer: git-send-email 2.34.1
>
> Transient Scheduler Attacks (TSA) are new speculative side channel at
On Thu, Jul 10, 2025 at 02:46:10PM -0500, Babu Moger wrote:
> Date: Thu, 10 Jul 2025 14:46:10 -0500
> From: Babu Moger
> Subject: [PATCH v2 1/2] target/i386: Add TSA attack variants TSA-SQ and
> TSA-L1
> X-Mailer: git-send-email 2.34.1
>
> Transient Scheduler Attacks (TSA) are new speculative si
On Wed, Jul 16, 2025 at 12:01:44PM +0800, Yi Liu wrote:
> On 2025/7/15 20:27, CLEMENT MATHIEU--DRIF wrote:
> >
> >
> > On 15/07/2025 10:27 am, David Woodhouse wrote:
> > > On Tue, 2025-07-15 at 06:11 +, CLEMENT MATHIEU--DRIF wrote:
> > > >
> > > >
> > > > On 14/07/2025 11:22 pm, Konstantin
On 2025/7/15 20:27, CLEMENT MATHIEU--DRIF wrote:
On 15/07/2025 10:27 am, David Woodhouse wrote:
On Tue, 2025-07-15 at 06:11 +, CLEMENT MATHIEU--DRIF wrote:
On 14/07/2025 11:22 pm, Konstantin Belousov wrote:
On Mon, Jul 14, 2025 at 05:41:22PM +0100, David Woodhouse wrote:
On 14 July 2
>-Original Message-
>From: Nicolin Chen
>Subject: Re: [RFC PATCH v3 05/15] hw/arm/smmuv3-accel: Introduce
>smmuv3 accel device
>
>On Tue, Jul 15, 2025 at 10:48:31AM +, Duan, Zhenzhong wrote:
>> >+static const TypeInfo types[] = {
>> >+{
>> >+.name = TYPE_ARM_SMMUV3_ACCEL
On 10/7/25 16:48, Peter Maydell wrote:
On Mon, 10 Feb 2025 at 12:10, Philippe Mathieu-Daudé wrote:
Coverity reported a unnecessary NULL check:
qemu/system/qdev-monitor.c: 720 in qdev_device_add_from_qdict()
683 /* create device */
684 dev = qdev_new(driver);
...
719
Hi Eric,
>-Original Message-
>From: Eric Auger
>Subject: Re: [PATCH v3 05/20] hw/pci: Export
>pci_device_get_iommu_bus_devfn() and return bool
>
>
>
>On 7/8/25 1:05 PM, Zhenzhong Duan wrote:
>> Returns true if PCI device is aliased or false otherwise. This will be
>> used in following pat
Hi Pierrick,
On 7/14/25 22:26, Pierrick Bouvier wrote:
On 7/14/25 4:31 PM, Gustavo Romero wrote:
Hi folks,
Richard, thanks for v8. Pierrick, thanks for testing it. :)
On 7/14/25 14:09, Pierrick Bouvier wrote:
On 7/14/25 8:58 AM, Richard Henderson wrote:
Changes for v8:
- Re-order SCTLR2
On Mon, Jul 14, 2025 at 04:59:40PM +0100, Shameer Kolothum wrote:
> From: Nicolin Chen
>
> Not all fields in the SMMU IDR registers are meaningful for userspace.
> Only the following fields can be used:
>
> - IDR0: ST_LEVEL, TERM_MODEL, STALL_MODEL, TTENDIAN, CD2L, ASID16, TTF
> - IDR1: SI
On Tue, Jul 15, 2025 at 10:59 PM Vladimir Sementsov-Ogievskiy
wrote:
>
> On 14.07.25 05:12, Jason Wang wrote:
> > On Wed, Jul 9, 2025 at 10:43 PM Vladimir Sementsov-Ogievskiy
> > wrote:
> >>
> >> On 07.07.25 06:49, Jason Wang wrote:
> >>> On Thu, Jul 3, 2025 at 10:59 PM Daniil Tatianin
> >>> wro
Hi Stefan:
On Wed, Jul 16, 2025 at 3:55 AM Stefan Hajnoczi wrote:
>
> Applied, thanks.
>
> Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any
> user-visible changes.
I sent a V2 of the PULL:
https://mail.gnu.org/archive/html/qemu-devel/2025-07/msg03794.html
That inclu
在 2025/7/15 16:57, Peter Maydell 写道:
On Tue, 15 Jul 2025 at 08:33, zhangzhijie wrote:
0. DW pcie support 64bit resource
1. DW version type using Linux kernel
Signed-off-by: zhangzhijie
---
hw/pci-host/designware.c | 12 +---
include/hw/pci-host/designware.h | 2 +-
2
Coverity Scan noted an unusual pattern in the
MAX78000 aes device, with duplicated calls to
set_decrypt. This commit adds a comment noting
why the implementation is correct.
Signed-off-by: Jackson Donaldson
---
hw/misc/max78000_aes.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/m
On Mon, Jul 14, 2025 at 04:59:35PM +0100, Shameer Kolothum wrote:
> +static void
> +smmuv3_accel_ste_range(gpointer key, gpointer value, gpointer user_data)
> +{
> +SMMUDevice *sdev = (SMMUDevice *)key;
> +uint32_t sid = smmu_get_sid(sdev);
> +SMMUSIDRange *sid_range = (SMMUSIDRange *)u
On Thu, Jun 12, 2025 at 05:17:24PM +0200, Mauro Carvalho Chehab wrote:
> Hi Michael,
>
> This is v10 of the patch series, rebased to apply after release
> 10.0. The only difference against v9 is a minor confict resolution.
Unfortunately, this needs a rebase on top of latest PCIHP
changes in my tr
On Tue, Jul 15, 2025, 6:27 PM John Snow wrote:
> The way editable installs work has changed at some point since Fedora 40
> was released. Generally, we should be opting to use pyproject.toml
> installs (PEP517/518) - but those are not fully supported until v61 of
> setuptools, and CentOS Stream 9
Hi Paolo,
Can these two patches be included in the QEMU 10.1 release? We are only
adding bit definitions and not updating the CPU models, so the risk
should be very low.
thanks
Babu
On 7/10/2025 2:46 PM, Babu Moger wrote:
Transient Scheduler Attacks (TSA) are new speculative side channel at
The way editable installs work has changed at some point since Fedora 40
was released. Generally, we should be opting to use pyproject.toml
installs (PEP517/518) - but those are not fully supported until v61 of
setuptools, and CentOS Stream 9 ships v53.
Until that time, we can make use of a transi
Thank you for catching that!
On Mon, Jul 14, 2025 at 1:08 PM Philippe Mathieu-Daudé
wrote:
> On 14/7/25 18:55, Peter Maydell wrote:
> > In gmac_try_send_next_packet() we have code that does "if this block
> > of data won't fit in the buffer, reallocate it". However, the
> > condition it uses is
fwiw, I think this is important enough / harmless enough to sneak into
the rc releases, if possible.
On Tue, Jul 15, 2025 at 5:28 PM John Snow wrote:
>
> CI: https://gitlab.com/jsnow/qemu/-/pipelines/1928836481
>
> Unlike the previous series, this series only adjusts the *preferred*
> sphinx vers
On Wed, Jul 16, 2025 at 12:25 AM Pierrick Bouvier
wrote:
>
> TF-A needs to be patched to enable support for FEAT_TCR2 and
> FEAT_SCTLR2. This new image contains updated firmware.
>
> Signed-off-by: Pierrick Bouvier
> ---
> tests/functional/test_aarch64_device_passthrough.py | 9 +
> 1 fi
[...]
>>> @@ -662,6 +661,9 @@ static int zipl_load_segment(ComponentEntry *entry)
>>> */
>>> break;
>>> }
>>> +
>>> +comp_len += bprs->size * (bprs[i].blockct + 1);
>>> +
>>
>> I'm confused by the arithmetic here. Why is size multiplied
For x86_64 a 16 bit push op (pushw) of a memory address would generate
a 64 bit store on the stack instead of a 16 bit store.
For example:
pushw (%rax)
behaves like
pushq (%rax)
which is incorrect.
This patch fixes that.
Signed-off-by: Thomas Ogrisegg
---
target/i386/tcg/deco
From: Akihiko Odaki
Add docs/requirements.txt to
"Sphinx documentation configuration and build machinery".
Signed-off-by: Akihiko Odaki
Signed-off-by: John Snow
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index e88ed2c0a97..809cd1aa53c 100644
On 7/14/25 10:09 AM, Pierrick Bouvier wrote:
On 7/14/25 8:58 AM, Richard Henderson wrote:
Changes for v8:
- Re-order SCTLR2 and TCR2 so that they are independent of MEC.
- Enable the SCTLR2 and TCR2 enable bits.
- Squash 3 smaller MEC patches together.
This still fails the RME tests
CI: https://gitlab.com/jsnow/qemu/-/pipelines/1928836481
Unlike the previous series, this series only adjusts the *preferred*
sphinx version to be higher, leaving the accepted version at 3.4.3, the
version that CentOS Stream 9 still ships with.
Unfortunately, this means we can't cut out the compa
From: Akihiko Odaki
sphinx 5.3.0 fails with Python 3.13.1:
../docs/meson.build:37: WARNING: /home/me/qemu/build/pyvenv/bin/sphinx-build:
Extension error:
Could not import extension sphinx.builders.epub3 (exception: No module named
'imghdr')
../docs/meson.build:39:6: ERROR: Problem encountered:
TF-A needs to be patched to enable support for FEAT_TCR2 and
FEAT_SCTLR2. This new image contains updated firmware.
Signed-off-by: Pierrick Bouvier
---
tests/functional/test_aarch64_rme_sbsaref.py | 9 +
tests/functional/test_aarch64_rme_virt.py| 9 +
2 files changed, 10 inse
TF-A needs to be patched to enable support for FEAT_TCR2 and
FEAT_SCTLR2. This new image contains updated firmware.
Signed-off-by: Pierrick Bouvier
---
tests/functional/test_aarch64_device_passthrough.py | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/functiona
The FEAT_MEC series [1] introduces FEAT_TCR2 and FEAT_SCTLR2.
TF-A needs to be aware of that change to allow accesses to those registers, and
thus must be patched [2] to enable this for QEMU platforms.
Concerned test images need to be updated to allow them to boot.
[1]
https://lore.kernel.org/qe
On 7/14/25 10:38 AM, Pierrick Bouvier wrote:
On 7/14/25 8:52 AM, Richard Henderson wrote:
On 7/14/25 09:41, Pierrick Bouvier wrote:
Indeed, clang does not fold the condition "value && kvm_enabled() && !
kvm_arm_sve_supported()". Looks like a missing case.
This code compiles with gcc -O0, but no
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any
user-visible changes.
signature.asc
Description: PGP signature
Only accelerator implementations (and the common accelator
code) need to know about AccelClass internals. Move the
definition out but forward declare AccelState and AccelClass.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Zhao Liu
Reviewed-by: Richard Henderson
Message-Id: <20250703173248
Knowing the QOM type name of a CPU can be useful,
in particular to infer its model name.
Reviewed-by: Richard Henderson
Reviewed-by: Zhao Liu
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Xiaoyao Li
Message-Id: <20250715090624.52377-2-phi...@linaro.org>
---
qapi/machine.json | 3
Generally APIs to the rest of QEMU should be documented in the headers.
Comments on individual functions or internal details are fine to live
in the C files. Make qemu_add_vm_change_state_handler_prio[_full]()
docstrings consistent by moving them from source to header.
Suggested-by: Xiaoyao Li
Si
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Reviewed-by: Alex Bennée
Reviewed-by: Zhao Liu
Message-Id: <20250703173248.44995-4-phi...@linaro.org>
---
include/system/runstate.h | 10 ++
1 file changed, 10 insertions(+)
diff --git a/include/system/runstate.h b/i
The following changes since commit 9a4e273ddec3927920c5958d2226c6b38b543336:
Merge tag 'pull-tcg-20250711' of https://gitlab.com/rth7680/qemu into staging
(2025-07-13 01:46:04 -0400)
are available in the Git repository at:
https://github.com/philmd/qemu.git tags/accel-20250715
Co-developed-by: Mads Ynddal
Signed-off-by: Mads Ynddal
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250715104015.72663-8-phi...@linaro.org>
---
accel/hvf/hvf-accel-ops.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/accel
Unstable QMP 'x-accel-stats' dispatches to the
AccelOpsClass::get_stats() and get_vcpu_stats() handlers.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Pierrick Bouvier
Reviewed-by: Markus Armbruster
Reviewed-by: Zhao Liu
Message-Id: <20250715140048.84942-4-phi...@linaro.org>
---
qapi/acc
Statistic code is not specific to system emulation (except
cross-page checks) and can be used to analyze user-mode binaries.
Extract statistic related code to its own file: tcg-stats.c,
keeping the original LGPL-2.1-or-later license tag.
Note, this code is not yet reachable by user-mode.
Signed-of
Unfortunately "system/accel-ops.h" handlers are not only
system-specific. For example, the cpu_reset_hold() hook
is part of the vCPU creation, after it is realized.
Mechanical rename to drop 'system' using:
$ sed -i -e s_system/accel-ops.h_accel/accel-cpu-ops.h_g \
$(git grep -l s
Display the CPU model in 'info cpus'. Example before:
$ qemu-system-aarch64 -M xlnx-versal-virt -S -monitor stdio
QEMU 10.0.0 monitor - type 'help' for more information
(qemu) info cpus
* CPU #0: thread_id=42924
CPU #1: thread_id=42924
CPU #2: thread_id=42924
CPU #3: thread_id=42924
Extract KVM definitions from machine.json to accelerator.json.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Pierrick Bouvier
Reviewed-by: Zhao Liu
Message-Id: <20250703105540.67664-29-phi...@linaro.org>
---
MAINTAINERS| 1 +
qapi/accelerator.json | 39 ++
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any
user-visible changes.
signature.asc
Description: PGP signature
'info accel' dispatches to the AccelOpsClass::get_stats()
and get_vcpu_stats() handlers.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Richard Henderson
Reviewed-by: Pierrick Bouvier
Message-Id: <20250715140048.84942-5-phi...@linaro.org>
---
accel/accel-system.c | 8
hmp-commands-i
Declare tcg_dump_stats() in "tcg/tcg.h" so it can be used out of
accel/tcg/, like by {bsd,linux}-user.
Next commit will register the TCG AccelClass::get_stats handler,
which expects a AccelState, so propagate it to dump_accel_info().
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Richard Henderso
Factor tcg_get_stats() out of tcg_dump_stats(),
passing the current accelerator argument to match
the AccelClass::get_stats() prototype.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
Message-Id: <20250715140048.84942-7-phi...@linaro.org>
---
accel/tcg/internal-common.h |
This reverts commit bc93332fe460211c2d2f4ff50e1a0e030c7b5159,
which was merged prematurely, re-introducing Coverity CID 1547782
(unreachable code).
Reported-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Manos Pitsidianakis
Reviewed-by: Richard Henderson
Message-Id: <2025
As each target declares the same prototypes, we can
use a single header, removing the TARGET_XXX uses.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Pierrick Bouvier
Reviewed-by: Stefano Stabellini
Message-Id: <20250513171737.74386-1-phi...@linaro.org>
---
include/hw/arm/xen_arch_hvm.h |
"hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and
arch_xen_set_memory() prototypes, which are not used by xen-pvh.c.
Remove the unnecessary header inclusion.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Xiaoyao Li
Reviewed-by: Manos Pitsidianakis
Message-Id: <20250715071528.46
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Manos Pitsidianakis
Message-Id: <20250710111303.8917-1-phi...@linaro.org>
---
accel/tcg/monitor.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/accel/tcg/monitor.c b/accel/tcg/monitor.c
index e7ed728
On 15/7/25 16:00, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (8):
Revert "accel/tcg: Unregister the RCU before exiting RR thread"
accel/tcg: Extract statistic related code to tcg-stats.c
accel/system: Introduce @x-accel-stats QMP command
accel/system: Add 'info accel' on hu
On 15/7/25 19:19, Philippe Mathieu-Daudé wrote:
Generally APIs to the rest of QEMU should be documented in the headers.
Comments on individual functions or internal details are fine to live
in the C files. Make qemu_add_vm_change_state_handler_prio[_full]()
docstrings consistent by moving them fr
On 15/7/25 11:06, Philippe Mathieu-Daudé wrote:
Philippe Mathieu-Daudé (2):
qapi/machine: Add @qom-type field to CpuInfoFast structure
hw/core/machine: Display CPU model name in 'info cpus' command
Queued, thanks.
From: Michael Tokarev
Add missing long options and --help output.
Reorder options for consistency.
Use -b for --backing, and recognize -B for backwards
compatibility. Unfortunately we can't use -B to
specify backing format.
Signed-off-by: Michael Tokarev
Message-ID: <20250715140702.131321-1-
On 10/7/25 13:13, Philippe Mathieu-Daudé wrote:
Signed-off-by: Philippe Mathieu-Daudé
---
accel/tcg/monitor.c | 22 +++---
1 file changed, 15 insertions(+), 7 deletions(-)
Queued, thanks.
From: Michael Tokarev
For consistency with other commands, and since it already
accepts --image-opts, allow specifying -f fmt too.
Signed-off-by: Michael Tokarev
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250531171609.197078-16-...@tls.msk.ru>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin
From: Michael Tokarev
'qemu-img resize --help' does not work, since it wants more
arguments. Also -size is only recognized as a very last
argument, but it is common for tools to handle other options
after positional arguments too.
Tell getopt_long() to return non-options together with options,
On 13/5/25 19:17, Philippe Mathieu-Daudé wrote:
As each target declares the same prototypes, we can
use a single header, removing the TARGET_XXX uses.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/arm/xen_arch_hvm.h | 9 -
include/hw/i386/xen_arch_hvm.h | 11 ---
in
From: Michael Tokarev
Add missing long options and --help output,
reorder options for consistency.
Use -B for --backing-format, keep -F for
backwards compatibility.
Options added:
--format, --cache - for the image in question
--backing, --backing-format, --backing-cache, --backing-unsafe -
From: Michael Tokarev
Use the same function to parse --object as used by all
other qemu-img subcommands.
Signed-off-by: Michael Tokarev
Message-ID: <20250531171609.197078-11-...@tls.msk.ru>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qemu-img.c | 16 ++--
1 file changed
From: Fiona Ebner
The function bdrv_drop_intermediate() calls bdrv_drained_begin(),
which must be called with the graph unlocked.
Signed-off-by: Fiona Ebner
Message-ID: <20250530151125.955508-45-f.eb...@proxmox.com>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
include/block/block-gl
On 15/7/25 09:15, Philippe Mathieu-Daudé wrote:
"hw/xen/arch_hvm.h" only declares the arch_handle_ioreq() and
arch_xen_set_memory() prototypes, which are not used by xen-pvh.c.
Remove the unnecessary header inclusion.
Cc: Xiaoyao Li
Signed-off-by: Philippe Mathieu-Daudé
---
Based-on: <20250513
From: Michael Tokarev
Add missing long options and --help output,
reorder options for consistency.
Also add -s short option for --size (and remove OPTION_SIZE).
Signed-off-by: Michael Tokarev
Message-ID: <20250531171609.197078-26-...@tls.msk.ru>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wo
From: Michael Tokarev
Add missing long options and --help output,
reorder options for consistency.
Signed-off-by: Michael Tokarev
Message-ID: <20250531171609.197078-21-...@tls.msk.ru>
[kwolf: Fixed up qemu-iotests]
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qemu-img.c
From: Fiona Ebner
The functions blk_log_writes_close(), blkverify_close(),
quorum_close(), vmdk_close() via vmdk_free_extents(), and other
bdrv_close() implementations call bdrv_graph_wrlock_drained(), which
must be called with the graph unlocked. They are reached via the
BlockDriver's bdrv_close
From: Michael Tokarev
This info will be used to generate --help output.
Signed-off-by: Michael Tokarev
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Kevin Wolf
Message-ID: <20250531171609.197078-5-...@tls.msk.ru>
Signed-off-by: Kevin Wolf
---
qemu-img.c | 34 +
From: Fiona Ebner
Signed-off-by: Fiona Ebner
Message-ID: <20250605100938.43133-1-f.eb...@proxmox.com>
[kwolf: Fixed up pylint warnings flagged by 297]
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/tests/qom-set-drive | 75 ++
tests/qemu-iotes
From: Fiona Ebner
In combination with using a throttle filter to enforce IO limits for
a guest device, knowing the 'file' child of a block device can be
useful. If the throttle filter is only intended for guest IO, block
jobs should not also be limited by the throttle filter, so the
block operati
From: Michael Tokarev
Add missing long options and --help output,
reorder options for consistency.
Signed-off-by: Michael Tokarev
Message-ID: <20250531171609.197078-8-...@tls.msk.ru>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qemu-img.c | 60 +--
From: Fiona Ebner
The function bdrv_inactivate() calls bdrv_drain_all_begin(), which
needs to be called with the graph unlocked, so either
bdrv_inactivate() should be marked as GRAPH_UNLOCKED or the drain
needs to be moved to the callers. The caller in
qmp_blockdev_set_active() requires that the
From: Fiona Ebner
All accesses of bs->quiesce_counter are in the main thread, either
after a GLOBAL_STATE_CODE() macro or in a function with GRAPH_WRLOCK
annotation.
This is essentially a revert of 414c2ec358 ("block: access
quiesce_counter with atomic ops"). At that time, neither the
GLOBAL_STA
From: Michael Tokarev
Initializing an unsigned as -1, or using temporary
sval for conversion is awkward. Since we don't allow
other "negative" values anyway, use signed value and
pass it to bdrv_img_create() (where it is properly
converted to unsigned), simplifying code.
Signed-off-by: Michael
From: Michael Tokarev
Add missing long options and --help output,
reorder options for consistency.
Signed-off-by: Michael Tokarev
Message-ID: <20250531171609.197078-18-...@tls.msk.ru>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qemu-img.c | 60 ++
From: Fiona Ebner
Many write-locked sections are also drained sections. A new
bdrv_graph_wrunlock_drained() wrapper around bdrv_graph_wrunlock() is
introduced, which will begin a drained section first. A global
variable is used so bdrv_graph_wrunlock() knows if it also needs
to end such a drained
From: Fiona Ebner
The function blk_io_limits_disable() calls bdrv_drained_begin(), which
must be called with the graph unlocked.
Signed-off-by: Fiona Ebner
Message-ID: <20250530151125.955508-40-f.eb...@proxmox.com>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
include/system/block-ba
From: Michael Tokarev
In order to correctly print executable name in various
error messages, pass argv[0] to error_exit() function.
This way, error messages will refer to actual executable
name, which may be different from 'qemu-img'.
For subcommands, pass original command name from the
qemu-img
From: Michael Tokarev
qemu_opt_set_number() expects signed int64_t.
Use int64_t instead of uint64_t for img_size, use -1 as "unset"
value instead of UINT64_MAX, and do not require temporary sval
for conversion from string.
Signed-off-by: Michael Tokarev
Reviewed-by: Daniel P. Berrangé
Reviewe
From: Michael Tokarev
Add missing long options and --help output,
reorder options for consistency.
While at it, remove unused option_index variable.
Signed-off-by: Michael Tokarev
Message-ID: <20250715140903.131529-1-...@tls.msk.ru>
Reviewed-by: Kevin Wolf
Signed-off-by: Kevin Wolf
---
qemu
1 - 100 of 389 matches
Mail list logo
