Re: [ANNOUNCE] QEMU 10.1.0-rc3 is now available

2025-08-13 Thread Michael Tokarev
On 14.08.2025 00:01, Michael Roth wrote: Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 10.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu.org

Re: [PULL 0/4] Uefi 20250812 patches

2025-08-13 Thread Michael Tokarev
On 12.08.2025 13:01, Gerd Hoffmann wrote: hw/uefi: last-minute bug fixes for the uefi variable store [for 10.1] Gerd Hoffmann (3): hw/uefi: return success for notifications hw/uefi: check access for first variable hw/uef

[PATCH] hw/ufs: Ensure DBC of PRDT uses only lower 18 bits

2025-08-13 Thread Jeuk Kim
The UFS spec defines the PRDT data byte count as an 18-bit field. This commit masks the value to the lower 18 bits to prevent incorrect transfer lengths and ensure compliance. Signed-off-by: Jeuk Kim --- hw/ufs/ufs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ufs/uf

Re: [PATCH 20/33] hw/virtio/virtio-bus: refactor virtio_bus_set_host_notifier()

2025-08-13 Thread Philippe Mathieu-Daudé
On 13/8/25 18:48, Vladimir Sementsov-Ogievskiy wrote: The logic kept as is. Reaftor to simplify further changes. Typo "refactor". Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio-bus.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) Reviewed-by

Re: [PATCH 21/33] vhost-user: make trace events more readable

2025-08-13 Thread Philippe Mathieu-Daudé
On 13/8/25 18:48, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/trace-events | 4 +- hw/virtio/vhost-user.c | 94 +- 2 files changed, 94 insertions(+), 4 deletions(-) @@ -430,7 +519,8 @@ static int v

Re: [PATCH v2 0/3] DTB build housekeeping

2025-08-13 Thread Paolo Bonzini
On 7/15/25 08:06, Philippe Mathieu-Daudé wrote: On 8/7/25 22:48, Bernhard Beschow wrote: This series removes the bundled device tree blobs from the repository which are redundant to the bundled device tree sources. To make this work, the device tree compiler 'dtc' is now required whenever libfd

Re: [PATCH 32/33] test/functional: exec_command_and_wait_for_pattern: add vm arg

2025-08-13 Thread Philippe Mathieu-Daudé
On 13/8/25 18:48, Vladimir Sementsov-Ogievskiy wrote: Allow to specify non default vm for the command. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/functional/qemu_test/cmd.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 22/33] vhost-user-blk: add some useful trace-points

2025-08-13 Thread Philippe Mathieu-Daudé
On 13/8/25 18:48, Vladimir Sementsov-Ogievskiy wrote: Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/block/trace-events | 10 ++ hw/block/vhost-user-blk.c | 15 +++ 2 files changed, 25 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events index

Re: [PATCH 07/33] virtio: move common part of _set_guest_notifier to generic code

2025-08-13 Thread Philippe Mathieu-Daudé
Hi Vladimir, On 13/8/25 18:48, Vladimir Sementsov-Ogievskiy wrote: virtio-pci and virtio-mmiio handle config notifier equally but Typo virtio-mmio. with different code (mmio adds a separate function, when pci use common function). Let's chose the more compact way (pci) and reuse it for mmio.

Re: [PATCH v5 00/13] virtio: introduce support for GSO over UDP tunnel

2025-08-13 Thread Lei Yang
Tested this series of patches with virtio-net regression cases, everything works fine. Tested-by: Lei Yang On Wed, Aug 13, 2025 at 6:30 PM Paolo Abeni wrote: > > Some virtualized deployments use UDP tunnel pervasively and are impacted > negatively by the lack of GSO support for such kind of tra

[PATCH] vfio/container: Remap only populated parts in a section

2025-08-13 Thread Zhenzhong Duan
If there are multiple containers and unmap-all fails for some container, we need to remap vaddr for the other containers for which unmap-all succeeded. When ram discard is enabled, we should only remap populated parts in a section instead of the whole section. Export vfio_ram_discard_notify_popula

RE: [PATCH] vfio/container: set error on cpr failure

2025-08-13 Thread Duan, Zhenzhong
>-Original Message- >From: Steve Sistare >Subject: [PATCH] vfio/container: set error on cpr failure > >Set an error message if vfio_cpr_ram_discard_register_listener fails so >the fail label gets a valid error object. > >Reported-by: Cédric Le Goater >Fixes: eba1f657cbb1 ("vfio/containe

[PATCH v2] docs: riscv-iommu: Update status of kernel support

2025-08-13 Thread Joel Stanley
The iommu Linux kernel support is now upstream. VFIO is still downstream at this stage. Reviewed-by: Daniel Henrique Barboza Signed-off-by: Joel Stanley --- v2: - Fix VFIO link - Fix qemu spelling --- docs/specs/riscv-iommu.rst | 35 +-- 1 file changed, 13 inse

KVM sysreg ids for FEAT_SYSREG128

2025-08-13 Thread Richard Henderson
Hiya, QEMU (ab)uses the kvm encoding of system register ids in the migration stream. As we implement support for FEAT_D128, it would be good to agree on an encoding for the 128-bit registers so that we can avoid complications with migration later. I don't think this is terribly complicated.

Re: [PATCH v2 21/24] tests/qtest/migration: Take reference when passing %p to qtest_qmp

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:10PM -0300, Fabiano Rosas wrote: > The documentation of qobject_from_jsonv() states that it takes > ownership of any %p arguments passed in. > > Next patches will add config-passing to the tests, so take an extra > reference in the migrate_qmp* functions to ensure the

Re: [PATCH v2 20/24] migration: Allow migrate commands to provide the migration config

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:09PM -0300, Fabiano Rosas wrote: > Allow the migrate and migrate_incoming commands to pass the migration > configuration options all at once, dispensing the use of > migrate-set-parameters and migrate-set-capabilities. > > The motivation of this is to simplify the int

Re: [PATCH v2 19/24] migration: Store the initial values used for s->parameters

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:08PM -0300, Fabiano Rosas wrote: > Each migration parameters has a default value, store them for later > use in resetting s->parameters. Values overridden via the command line > with the debugging option -global migration. will be included. > > Make the structure cons

[ANNOUNCE] QEMU 10.1.0-rc3 is now available

2025-08-13 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 10.1 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu.org/qemu-10.1.0-rc3.tar.xz http://download.qe

Re: [PATCH v2 18/24] qapi/migration: Deprecate capabilities commands

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:07PM -0300, Fabiano Rosas wrote: > The concept of capabilities is being merged into the concept of > parameters. From now on, the commands that handle capabilities are > deprecated in favor of the commands that handle parameters. > > Affected commands: > > - migrate-

Re: [PATCH v2 17/24] migration: Remove s->capabilities

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:06PM -0300, Fabiano Rosas wrote: > Last patch added capabilities to s->parameters. Now we can replace all > instances of s->capabilities with s->parameters: > > - The -global properties now get set directly in s->parameters. > > - Accessors from options.c now read fr

Re: [PATCH v2 15/24] migration: Cleanup hmp_info_migrate_parameters

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:04PM -0300, Fabiano Rosas wrote: > Do a cleanup of hmp_info_migrate_parameters() before adding more lines > into it: > > - Make sure every parameter asserts that the has_* field is > set. qmp_query_migrate_parameters should have set them all. (except > for block-b

Re: [PATCH v2 14/24] migration: Use visitors in migrate_params_test_apply

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:03PM -0300, Fabiano Rosas wrote: > Convert the code in migrate_params_test_apply() from an open-coded > copy of every migration parameter to a copy using visitors. The > current code has conditionals for each parameter's has_* field, which > is exactly what the visitor

Re: [PATCH v2 13/24] migration: Use QAPI_CLONE_MEMBERS in migrate_params_apply

2025-08-13 Thread Peter Xu
On Mon, Jun 30, 2025 at 04:59:02PM -0300, Fabiano Rosas wrote: > Instead of setting parameters one by one, use the temporary object, > which already contains the current migration parameters plus the new > ones and was just validated by migration_params_check(). Use cloning > to overwrite it. > >

[PATCH qemu v2 0/1] Default disable ignore guest PAT quirk

2025-08-13 Thread ~myrslint
Details of the issue addressed can be found here: https://gitlab.com/qemu-project/qemu/-/issues/2943 Most Intel CPUs in current use have self-snoop. The few added lines of code also check for availability of the quirk disablement option so if some CPU does not have this feature no change of behavi

[PATCH qemu v2 1/1] Default disable ignore guest PAT quirk (second revision)

2025-08-13 Thread ~myrslint
From: myrslint Thanks to Alex Bennée for the kind code review and helpful guidance. This is a second attempt at addressing this issue: https://gitlab.com/qemu-project/qemu/-/issues/2943 Most Intel CPUs in current use have self-snoop. The few added lines of code also check for availability of th

Re: [RFC PATCH 0/4] migration: Introduce postcopy-setup capability and state

2025-08-13 Thread Peter Xu
On Tue, Aug 12, 2025 at 03:34:26PM +0200, Juraj Marcin wrote: > Hi Peter > > On 2025-08-11 10:54, Peter Xu wrote: > > [Sorry to respond late on the real meat of this series..] > > > > On Thu, Aug 07, 2025 at 01:49:08PM +0200, Juraj Marcin wrote: > > > When postcopy migration starts, the source si

[PATCH v1 2/4] vfio/pci: Add an architecture specific error handler

2025-08-13 Thread Farhan Ali
Provide a architecture specific error handling callback, that can be used by platforms to handle PCI errors for passthrough devices. Signed-off-by: Farhan Ali --- hw/vfio/pci.c | 5 + hw/vfio/pci.h | 1 + 2 files changed, 6 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 0725

[PATCH v1 1/4] [NOTFORMERGE] linux-headers: Update for zpci vfio device

2025-08-13 Thread Farhan Ali
Signed-off-by: Farhan Ali --- linux-headers/linux/vfio.h | 2 ++ linux-headers/linux/vfio_zdev.h | 5 + 2 files changed, 7 insertions(+) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index 79bf8c0cc5..a437169bce 100644 --- a/linux-headers/linux/vfio.h +++ b/linux-

[PATCH v1 0/4] Error recovery for zPCI passthrough devices

2025-08-13 Thread Farhan Ali
Hi, This patch series introduces support for error recovery for passthrough PCI devices on System Z (s390x). This is the user space component for the Linux kernel patches [1]. For QEMU on eventfd notification for PCI error from vfio-pci driver we call the vfio error handler. We can use an architec

[PATCH v1 4/4] s390x/pci: Reset a device in error state

2025-08-13 Thread Farhan Ali
For passthrough devices in error state, for a guest driven reset of the device we can attempt a hot reset to recover the device. A hot reset of the device will trigger a CLP disable/enable cycle on the host to bring the device into a recovered state. Signed-off-by: Farhan Ali --- hw/s390x/s390-p

[PATCH v1 3/4] s390x/pci: Add PCI error handling for vfio pci devices

2025-08-13 Thread Farhan Ali
Add an s390x specific callback for vfio error handling. For s390x pci devices, we have platform specific error information. We need to retrieve this error information for passthrough devices. This is done via a memory region which exposes that information. Once this error information is retrieved

[PATCH 28/33] vhost: introduce backend migration

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Normally on migration we stop and destroy connection with vhost (vhost-user-blk server, or kernel vhost) on source and reinitialize it on target. With this commit we start to implement vhost backend migration, i.e. we don't stop the connection and operation of vhost. Instead, we pass backend-relat

[PATCH 07/33] virtio: move common part of _set_guest_notifier to generic code

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
virtio-pci and virtio-mmiio handle config notifier equally but with different code (mmio adds a separate function, when pci use common function). Let's chose the more compact way (pci) and reuse it for mmio. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio-mmio.c| 41

Re: [PATCH] vfio/igd: Enable quirks when IGD is not the primary display

2025-08-13 Thread Alex Williamson
On Thu, 14 Aug 2025 00:05:10 +0800 Tomita Moeko wrote: > Since linux 6.15, commit 41112160ca87 ("vfio/pci: match IGD devices in > display controller class"), IGD related regions are also exposed when > IGD is not primary display (device class is Display controller). > > Allow IGD quirks to be en

[PATCH 25/33] virtio: introduce .skip_vhost_migration_log() handler

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
For vhost user backend migration we'll need to disable memory logging on the device. Let's prepare a corresponding handler for the device. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 10 ++ include/hw/virtio/virtio.h | 2 ++ 2 files changed, 12 insertion

[PATCH 22/33] vhost-user-blk: add some useful trace-points

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/block/trace-events | 10 ++ hw/block/vhost-user-blk.c | 15 +++ 2 files changed, 25 insertions(+) diff --git a/hw/block/trace-events b/hw/block/trace-events index cc9a9f2460..3b5fd2a599 100644 --- a/hw/block/trace-events

[PATCH 30/33] virtio: support vhost backend migration

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Add logic to transfer virtio notifiers through migration channel for vhost backend migration case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio-bus.c | 2 +- hw/virtio/virtio.c | 74 -- include/hw/virtio/virtio.h | 2 ++ 3 fil

[PATCH 02/33] vhost: drop backend_features field

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
This field is mostly unused and sometimes confusing (we even have a TODO-like comment to drop it). Let's finally do. The field is used to held VHOST_USER_F_PROTOCOL_FEATURES for vhost-user and/or VHOST_NET_F_VIRTIO_NET_HDR for vhost-net (which may be vhoust-user-net). But we can simply recalculte

[PATCH 31/33] vhost-user-blk: support vhost backend migration

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Opt-out backend initialization code, and instead get the state from migration channel (including inflight region). Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/block/vhost-user-blk.c | 185 +++-- include/hw/virtio/vhost-user-blk.h | 2 + migration/options

[PATCH 26/33] io/channel-socket: introduce qio_channel_socket_keep_nonblock()

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Add a possibility to keep socket non-block status when passing through qio channel. We need this to support migration of open fds through migration channel. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/io/channel-socket.h | 3 +++ io/channel-socket.c | 16 2

[PATCH 08/33] virtio: drop *_set_guest_notifier_fd_handler() helpers

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Now they don't make code more readable. Let's better put the whole logic into virtio_queue_set_guest_notifier(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio.c | 76 +++--- 1 file changed, 17 insertions(+), 59 deletions(-) diff --git a

[PATCH 01/33] vhost: introduce vhost_ops->vhost_set_vring_enable_supported method

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Remove vhost-user specific hack from generic code. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost-user.c| 8 hw/virtio/vhost.c | 15 ++- include/hw/virtio/vhost-backend.h | 2 ++ 3 files changed, 16 insertions(+), 9 deletions(-)

[PATCH 24/33] chardev-add: support local migration

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
This commit introduces a possibility to migrate open chardev socket fd through migration channel without reconnecting. For this, user should: - enable new migration capability local-char-socket - mark the socket by an option support-local-migration=true - on target add local-incoming=true optio

[PATCH 21/33] vhost-user: make trace events more readable

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/trace-events | 4 +- hw/virtio/vhost-user.c | 94 +- 2 files changed, 94 insertions(+), 4 deletions(-) diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events index 76f0d458b2..e5142c27f9 1006

[PATCH 09/33] vhost-user: keep QIOChannelSocket for backend channel

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Keep QIOChannelSocket pointer instead of more generic QIOChannel. No real difference for now, but it would be simpler to migrate socket fd in further commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost-user.c | 21 ++--- 1 file changed, 10 insertions(+), 11 de

[PATCH 13/33] vhost: move vrings mapping to the top of vhost_virtqueue_start()

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
This simplifies further refactoring and final introduction of vhost backend live migration. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 47 +++ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/hw/virtio/vhost.c b/

[PATCH 11/33] vhost: make vhost_memory_unmap() null-safe

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
This helps to simplify failure paths of vhost_virtqueue_start() a lot. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1e14987cd5..1fdc1937b

[PATCH 14/33] vhost: vhost_virtqueue_start(): drop extra local variables

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
One letter named variables doesn't really help to read the code, and they simply duplicate structure fields. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virti

[PATCH 33/33] tests/functional: add test_x86_64_vhost_user_blk_fd_migration.py

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Introduce a simple test to check that local migration of vhost-user-blk device with passing open fds through unix socket works, and the disk is still working on target. Signed-off-by: Vladimir Sementsov-Ogievskiy --- ...test_x86_64_vhost_user_blk_fd_migration.py | 279 ++ 1 file

[PATCH 12/33] vhost: simplify calls to vhost_memory_unmap()

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
No reason to calculate memory size again, as we have corresponding variable for each vring. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 1fdc19

[PATCH 27/33] migration/socket: keep fds non-block

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
For migration channel keep fds non-blocking property as is. It's needed for future local migration of fds. Signed-off-by: Vladimir Sementsov-Ogievskiy --- migration/socket.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/socket.c b/migration/socket.c index 5ec65b8c03..9f7b6919cf 1

[PATCH 18/33] vhost: introduce check_memslots() helper

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 71 ++- 1 file changed, 40 insertions(+), 31 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index a8f8b85012..f9163ba895 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio

[PATCH 10/33] vhost: vhost_virtqueue_start(): fix failure path

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
We miss call to unmap in cases when vhost_memory_map() returns lenght less than requested (still we consider such cases as an error). Let's fix it in vhost_memory_map(). Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 33 + 1 file changed, 21 i

[PATCH 04/33] vhost: move protocol_features to vhost_user

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
As comment says: it's only for vhost-user. So, let's move it to corresponding vhost backend realization. Signed-off-by: Vladimir Sementsov-Ogievskiy --- backends/cryptodev-vhost.c| 1 - hw/net/vhost_net.c| 2 -- hw/virtio/vhost-user.c| 23 +++

[PATCH 16/33] vhost: simplify vhost_dev_init() error-path

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
No reason to rollback setting up busyloop timeout on failure. We don't do such rollback for other things we setup in backend. Also, look at vhost_net_init() in hw/net/vhost_net.c: we may fail after successfully called vhost_dev_init(), and in this case we'll just call vhost_dev_cleanup(), which doe

[PATCH 15/33] vhost: final refactoring of vhost vrings map/unmap

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Introduce helper functions vhost_vrings_map() and vhost_vrings_unmap() and use them. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 82 ++- 1 file changed, 52 insertions(+), 30 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virt

[PATCH 32/33] test/functional: exec_command_and_wait_for_pattern: add vm arg

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Allow to specify non default vm for the command. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/functional/qemu_test/cmd.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/functional/qemu_test/cmd.py b/tests/functional/qemu_test/cmd.py index dc5f422b77..2

[PATCH 17/33] vhost: move busyloop timeout initialization to vhost_virtqueue_init()

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Let's all per-virtqueue initializations be in one place. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index a3620c82d8..a8f8b85012 100644 ---

[PATCH 05/33] vhost-user-gpu: drop code duplication

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Obviously, this duplicated fragment doesn't make any sense. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/display/vhost-user-gpu.c | 4 1 file changed, 4 deletions(-) diff --git a/hw/display/vhost-user-gpu.c b/hw/display/vhost-user-gpu.c index 9fc6bbcd2c..79ea64b12c 100644 --- a/hw/di

[PATCH 20/33] hw/virtio/virtio-bus: refactor virtio_bus_set_host_notifier()

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
The logic kept as is. Reaftor to simplify further changes. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/virtio-bus.c | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c index 11adfbf3ab..c7e3941b1e 1

[PATCH 29/33] vhost-user: support backend migration

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
In case of local backend migration, skip backend-related initialization, but instead get the state from migration channel (including secondary channel file descriptor). Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost-user.c | 62 ++ 1 file

[PATCH 23/33] vhost: add some useful trace-points

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/trace-events | 8 hw/virtio/vhost.c | 16 2 files changed, 24 insertions(+) diff --git a/hw/virtio/trace-events b/hw/virtio/trace-events index e5142c27f9..bd595fcd91 100644 --- a/hw/virtio/trace-events +++

[PATCH 19/33] vhost: vhost_dev_init(): drop extra features variable

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index f9163ba895..e796ad347d 100644 --- a/hw/virtio/vhost.c +++ b/hw/virtio/vhost.c @@ -1596,7 +1596,6 @@ int vhost_dev_i

[PATCH 06/33] vhost: make vhost_dev.features private

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
It's hard to control where and how do we use this field. Let's cover all usages by getters/setters, and keep direct access to the field only in vhost.c. It will help to control migration of this field in further commits. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/display/vhost-user-gpu.c

[PATCH 00/33] vhost-user-blk: live-backend local migration

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Hi all! Local migration of vhost-user-blk requires non-trivial actions from management layer, it should provide a new connection for new QEMU process and handle disk operation movement from one connection to another. Such switching, including reinitialization of vhost-user connection, draining di

[PATCH 03/33] vhost-user: introduce vhost_user_has_prot() helper

2025-08-13 Thread Vladimir Sementsov-Ogievskiy
Make all protocol feature checks in the same way. Signed-off-by: Vladimir Sementsov-Ogievskiy --- hw/virtio/vhost-user.c | 102 ++--- 1 file changed, 44 insertions(+), 58 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c index cf6f5380

[PATCH] vfio/igd: Enable quirks when IGD is not the primary display

2025-08-13 Thread Tomita Moeko
Since linux 6.15, commit 41112160ca87 ("vfio/pci: match IGD devices in display controller class"), IGD related regions are also exposed when IGD is not primary display (device class is Display controller). Allow IGD quirks to be enabled in this configuration so that guests can have display output

Re: [PATCH 6.16 000/627] 6.16.1-rc1 review

2025-08-13 Thread Dan Carpenter
On Wed, Aug 13, 2025 at 04:53:37PM +0200, Greg Kroah-Hartman wrote: > On Wed, Aug 13, 2025 at 08:01:51PM +0530, Naresh Kamboju wrote: > > Hi Greg, > > > > > > 2) > > > > > > > > The following list of LTP syscalls failure noticed on qemu-arm64 with > > > > stable-rc 6.16.1-rc1 with CONFIG_ARM64_64K

Re: [PATCH] vfio/container: set error on cpr failure

2025-08-13 Thread Philippe Mathieu-Daudé
On 13/8/25 16:17, Steve Sistare wrote: Set an error message if vfio_cpr_ram_discard_register_listener fails so the fail label gets a valid error object. Reported-by: Cédric Le Goater Fixes: eba1f657cbb1 ("vfio/container: recover from unmap-all-vaddr failure") Signed-off-by: Steve Sistare ---

Re: [PATCH V3 1/1] hw/intc/arm_gicv3_kvm: preserve pending interrupts during cpr

2025-08-13 Thread Peter Maydell
On Wed, 13 Aug 2025 at 14:32, Steven Sistare wrote: > > Peter previously said "looks good" but wanted a sanity check from a > live update maintainer, which Fabiano provided. > > So, which maintainer will pull this for 10.1? It's not going into 10.1 (it has missed that boat, I'm afraid); it's on m

Re: [PATCH 6.16 000/627] 6.16.1-rc1 review

2025-08-13 Thread Greg Kroah-Hartman
On Wed, Aug 13, 2025 at 08:01:51PM +0530, Naresh Kamboju wrote: > Hi Greg, > > > > 2) > > > > > > The following list of LTP syscalls failure noticed on qemu-arm64 with > > > stable-rc 6.16.1-rc1 with CONFIG_ARM64_64K_PAGES=y build configuration. > > > > > > Most failures report ENOSPC (28) or mksw

Re: [RFC 16/26] memory: Make flatview_do_translate() return a pointer to MemoryRegionSection

2025-08-13 Thread Zhao Liu
> Yes, the usual approach is to have a Ref and a RefMut type e.g. Opaque and > OpaqueMut, and the OpaqueMut type can dereference immutably as an Opaque. > > See std::cell::{Ref, RefMut} for inspiration. > Thanks! I'll dorp Opaque directly for this case. If there're more similar cases, then we ca

Re: [RFC 16/26] memory: Make flatview_do_translate() return a pointer to MemoryRegionSection

2025-08-13 Thread Zhao Liu
On Tue, Aug 12, 2025 at 09:23:59PM +0200, Paolo Bonzini wrote: > Date: Tue, 12 Aug 2025 21:23:59 +0200 > From: Paolo Bonzini > Subject: Re: [RFC 16/26] memory: Make flatview_do_translate() return a > pointer to MemoryRegionSection > > Il mar 12 ago 2025, 17:17 Zhao Liu ha scritto: > > > But lo

Re: [RFC 00/26] rust/memory: Integrate the vm-memory API from rust-vmm

2025-08-13 Thread Zhao Liu
On Thu, Aug 07, 2025 at 04:13:00PM +0200, Paolo Bonzini wrote: > Date: Thu, 7 Aug 2025 16:13:00 +0200 > From: Paolo Bonzini > Subject: Re: [RFC 00/26] rust/memory: Integrate the vm-memory API from > rust-vmm > > [Adding Hanna who's been working on vm-memory] > > On 8/7/25 14:30, Zhao Liu wrote:

Re: [PATCH 6.16 000/627] 6.16.1-rc1 review

2025-08-13 Thread Naresh Kamboju
Hi Greg, > > 2) > > > > The following list of LTP syscalls failure noticed on qemu-arm64 with > > stable-rc 6.16.1-rc1 with CONFIG_ARM64_64K_PAGES=y build configuration. > > > > Most failures report ENOSPC (28) or mkswap errors, which may be related > > to disk space handling in the 64K page confi

Re: [RFC 25/26] rust/memory: Add binding to check target endian

2025-08-13 Thread Zhao Liu
On Thu, Aug 07, 2025 at 03:44:57PM +0300, Manos Pitsidianakis wrote: > Date: Thu, 7 Aug 2025 15:44:57 +0300 > From: Manos Pitsidianakis > Subject: Re: [RFC 25/26] rust/memory: Add binding to check target endian > > On Thu, Aug 7, 2025 at 3:10 PM Zhao Liu wrote: > > > > Add a binding (target_is_b

Re: [RFC 24/26] rust/memory: Provide AddressSpace bindings

2025-08-13 Thread Zhao Liu
On Thu, Aug 07, 2025 at 03:50:45PM +0200, Paolo Bonzini wrote: > Date: Thu, 7 Aug 2025 15:50:45 +0200 > From: Paolo Bonzini > Subject: Re: [RFC 24/26] rust/memory: Provide AddressSpace bindings > > On 8/7/25 14:30, Zhao Liu wrote: > > +impl GuestAddressSpace for AddressSpace { > > +type M = F

[PATCH] vfio/container: set error on cpr failure

2025-08-13 Thread Steve Sistare
Set an error message if vfio_cpr_ram_discard_register_listener fails so the fail label gets a valid error object. Reported-by: Cédric Le Goater Fixes: eba1f657cbb1 ("vfio/container: recover from unmap-all-vaddr failure") Signed-off-by: Steve Sistare --- hw/vfio/listener.c | 3 +++ 1 file change

Re: [PATCH V5 08/38] vfio/container: recover from unmap-all-vaddr failure

2025-08-13 Thread Steven Sistare
On 8/13/2025 8:54 AM, Cédric Le Goater wrote: Steve, On 6/10/25 17:39, Steve Sistare wrote: If there are multiple containers and unmap-all fails for some container, we need to remap vaddr for the other containers for which unmap-all succeeded. Recover by walking all address ranges of all contai

Re: [RFC 5/6] virtio,virtio-net: skip consistency check in virtio_load for iterative migration

2025-08-13 Thread Peter Xu
On Wed, Aug 13, 2025 at 11:25:00AM +0200, Eugenio Perez Martin wrote: > On Mon, Aug 11, 2025 at 11:56 PM Peter Xu wrote: > > > > On Mon, Aug 11, 2025 at 05:26:05PM -0400, Jonah Palmer wrote: > > > This effort was started to reduce the guest visible downtime by > > > virtio-net/vhost-net/vhost-vDPA

Re: [PATCH 6.16 000/627] 6.16.1-rc1 review

2025-08-13 Thread Naresh Kamboju
On Wed, 13 Aug 2025 at 18:21, Mark Brown wrote: > > On Wed, Aug 13, 2025 at 05:46:26PM +0530, Naresh Kamboju wrote: > > On Tue, 12 Aug 2025 at 23:57, Greg Kroah-Hartman > > > The following list of LTP syscalls failure noticed on qemu-arm64 with > > stable-rc 6.16.1-rc1 with CONFIG_ARM64_64K_PAGES=

Re: [PATCH V3 1/1] hw/intc/arm_gicv3_kvm: preserve pending interrupts during cpr

2025-08-13 Thread Steven Sistare
Peter previously said "looks good" but wanted a sanity check from a live update maintainer, which Fabiano provided. So, which maintainer will pull this for 10.1? - Steve On 8/11/2025 2:19 PM, Steve Sistare wrote: Close a race condition that causes cpr-transfer to lose VFIO interrupts on ARM.

Re: [PATCH qemu 1/1] Default disable ignore guest PAT quirk

2025-08-13 Thread Alex Bennée
~myrslint writes: > From: myrslint > > Addresses this issue: > https://gitlab.com/qemu-project/qemu/-/issues/2943 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2943 > Most Intel CPUs in current use have self-snoop. The few added lines of > code also check for availability of the quir

Re: [Question] VFIO migration will not be aborted in a corner scenario

2025-08-13 Thread Kunkun Jiang via
Hi Avihai, On 2025/8/12 22:08, Avihai Horon wrote: On 11/08/2025 19:34, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello, + Avihai On 8/11/25 18:02, Kunkun Jiang wrote: Hi all, While testing VFIO migration, I encountered an corner scenario case: VFIO

Re: [PATCH 6.16 000/627] 6.16.1-rc1 review

2025-08-13 Thread Mark Brown
On Wed, Aug 13, 2025 at 05:46:26PM +0530, Naresh Kamboju wrote: > On Tue, 12 Aug 2025 at 23:57, Greg Kroah-Hartman > The following list of LTP syscalls failure noticed on qemu-arm64 with > stable-rc 6.16.1-rc1 with CONFIG_ARM64_64K_PAGES=y build configuration. > > Most failures report ENOSPC (28)

Re: [Question] VFIO migration will not be aborted in a corner scenario

2025-08-13 Thread Kunkun Jiang via
Hi Cédric, On 2025/8/12 22:56, Cédric Le Goater wrote: On 8/12/25 16:08, Avihai Horon wrote: On 11/08/2025 19:34, Cédric Le Goater wrote: External email: Use caution opening links or attachments Hello, + Avihai On 8/11/25 18:02, Kunkun Jiang wrote: Hi all, While testing VFIO migration,

Re: [PATCH V5 08/38] vfio/container: recover from unmap-all-vaddr failure

2025-08-13 Thread Cédric Le Goater
Steve, On 6/10/25 17:39, Steve Sistare wrote: If there are multiple containers and unmap-all fails for some container, we need to remap vaddr for the other containers for which unmap-all succeeded. Recover by walking all address ranges of all containers to restore the vaddr for each. Do so by i

Re: [PATCH 6.16 000/627] 6.16.1-rc1 review

2025-08-13 Thread Greg Kroah-Hartman
On Wed, Aug 13, 2025 at 05:46:26PM +0530, Naresh Kamboju wrote: > Long story: > 1) > The perf gcc-13 build failed on x86_64 and i386. > > Build regression: qemu-arm64 ARM64_64K_PAGES ltp syscalls swap fsync > fallocate failed. > > > Ian Rogers > > perf topdown: Use attribute to see an event

Re: [PATCH RFC] arm/kvm: report registers we failed to set

2025-08-13 Thread Eric Auger
On 8/13/25 12:01 PM, Cornelia Huck wrote: > On Tue, Aug 12 2025, Eric Auger wrote: > >> Hi Connie, >> >> On 7/21/25 6:19 PM, Cornelia Huck wrote: >>> If we fail migration because of a mismatch of some registers between >>> source and destination, the error message is not very informative: >>> >

Re: [PATCH 6.16 000/627] 6.16.1-rc1 review

2025-08-13 Thread Naresh Kamboju
On Tue, 12 Aug 2025 at 23:57, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 6.16.1 release. > There are 627 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Res

[PATCH qemu 1/1] Default disable ignore guest PAT quirk

2025-08-13 Thread ~myrslint
From: myrslint Addresses this issue: https://gitlab.com/qemu-project/qemu/-/issues/2943 Most Intel CPUs in current use have self-snoop. The few added lines of code also check for availability of the quirk disablement option so if some CPU does not have this feature no change of behavior will occ

Re: [REGRESSION][BISECTED] kernel panic is not displayed correctly in qemu (CONFIG_DRM_BOCHS)

2025-08-13 Thread Thomas Zimmermann
Hi Am 10.07.25 um 06:21 schrieb Askar Safin: Steps to reproduce: - Build Linux v6.16-rc5 so: $ cat mini CONFIG_64BIT=y CONFIG_EXPERT=y CONFIG_EMBEDDED=y CONFIG_PRINTK=y CONFIG_PRINTK_TIME=y CONFIG_PCI=y CONFIG_TTY=y CONFIG_VT=y CONFIG_VT_CONSOLE=y CONFIG_DRM=y CONFIG_DRM_FBDEV_EMULATION=y

[PATCH qemu 0/1] A small patch to address Issue #2943

2025-08-13 Thread ~myrslint
Details of the issue can be found at: https://gitlab.com/qemu- project/qemu/-/issues/2943 This patch by default disables the KVM_X86_QUIRK_IGNORE_GUEST_PAT quirk because most Intel CPUs in current use do not need it. The bochs video driver bug which required it has been fixed as well. The end res

Re: [PATCH] docs: riscv-iommu: Update status of kernel support

2025-08-13 Thread Daniel Henrique Barboza
Hi Joel! Thanks for this update. Any help keeping the docs updated is dearly appreciated. A few comments: On 8/13/25 2:52 AM, Joel Stanley wrote: The iommu Linux kernel support is now upstream. VFIO is still downstream at this stage. Signed-off-by: Joel Stanley --- Daniel, the wording might

Re: [PULL 3/3] qemu-iotests: Ignore indentation in Killed messages

2025-08-13 Thread Michael Tokarev
On 12.08.2025 22:59, Kevin Wolf wrote: From: Werner Fink New bash 5.3 uses a different padding for reporting job status. Resolves: boo#1246830 Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3050 FWIW, I'm picking this up for qemu-stable as well. Thanks, /mjt

Re: [PATCH v5] net: bundle all offloads in a single struct

2025-08-13 Thread Paolo Abeni
Hi, On 8/13/25 12:34 PM, Michael Tokarev wrote: > On 13.08.2025 13:26, Paolo Abeni wrote: > >> +typedef struct NetOffloads { >> +bool csum; >> +bool tso4; >> +bool tso6; >> +bool ecn; >> +bool ufo; >> +bool uso4; >> +bool uso6; >> +} NetOffloads; > > BTW, can't this b

Re: [PATCH v5] net: bundle all offloads in a single struct

2025-08-13 Thread Michael Tokarev
On 13.08.2025 13:26, Paolo Abeni wrote: +typedef struct NetOffloads { +bool csum; +bool tso4; +bool tso6; +bool ecn; +bool ufo; +bool uso4; +bool uso6; +} NetOffloads; BTW, can't this be a bitmask (single integer) or a bitfield? Dunno how well it'll work, but it fe

[PATCH v5 13/13] net: implement UDP tunnel features offloading

2025-08-13 Thread Paolo Abeni
When any host or guest GSO over UDP tunnel offload is enabled the virtio net header includes the additional tunnel-related fields, update the size accordingly. Push the GSO over UDP tunnel offloads all the way down to the tap device extending the newly introduced NetFeatures struct, and eventually

[PATCH v5 10/13] vhost-net: implement extended features support

2025-08-13 Thread Paolo Abeni
Provide extended version of the features manipulation helpers, and let the device initialization deal with the full features space, adjusting the relevant format strings accordingly. Signed-off-by: Paolo Abeni --- v3 -> v4: - add missing features initialization - use new virtio_features macro

[PATCH v5 04/13] virtio: serialize extended features state

2025-08-13 Thread Paolo Abeni
If the driver uses any of the extended features (i.e. 64 or above), store the extended features range (64-127 bits). At load time, let legacy features initialize the full features range and pass it to the set helper; sub-states loading will have filled-up the extended part as needed. This is one

  1   2   >