Re: [Qemu-devel] [PATCH] qom: cpu: destroy work_mutex in cpu_common_finalize

2019-03-10 Thread
Hi Paolo, What's the status of this patch? I don't see it in upstream. Thanks, Li Qiang At 2019-01-08 07:41:09, "Paolo Bonzini" wrote: >On 02/01/19 08:41, Li Qiang wrote: >> Commit 376692b9dc6(cpus: protect work list with work_mutex) >> initialize a work_mutex in cpu_common_initfn, however

Re: [Qemu-devel] [PATCH PULL 00/10] RDMA queue

2019-01-19 Thread
Hi Marcel, Seems you lost another: hw: pvrdma: fix memory leak in error path -->http://lists.gnu.org/archive/html/qemu-devel/2019-01/msg01217.html At 2019-01-19 18:03:05, "Marcel Apfelbaum" wrote: >The following changes since commit a8d2b0685681e2f291faaa501efbbd76875f8ec8: > > Merge

Re: [Qemu-devel] [PATCH v2] s390: avoid potential null dereference ins390_pcihost_unplug()

2019-01-07 Thread
At 2019-01-08 00:10:29, "Cornelia Huck" wrote: >On Mon, 7 Jan 2019 16:04:35 + >Peter Maydell wrote: > >> On Mon, 7 Jan 2019 at 15:57, Cornelia Huck wrote: >> > On Mon, 7 Jan 2019 15:54:21 + >> > Peter Maydell wrote: >> > > On Mon, 7 Jan 2019 at 15:48, Cornelia Huck wrote: >> > >

Re: [Qemu-devel] [PATCH] hw: pvrdma: fix memory leak in error path

2019-01-07 Thread
At 2019-01-08 00:26:58, "Yuval Shaia" wrote: >On Thu, Jan 03, 2019 at 02:47:37PM +0100, Philippe Mathieu-Daudé wrote: >> On 1/3/19 2:03 PM, Li Qiang wrote: >> > Spotted by Coverity: CID 1398595 >> > >> >> Fixes: 2b05705dc8 >> >> > Signed-off-by: Li Qiang >> >> Reviewed-by: Philippe

Re: [Qemu-devel] [PATCH 2/5] pvrdma: add uar_read routine

2018-12-11 Thread
At 2018-12-11 23:22:32, "Yuval Shaia" wrote: >On Tue, Dec 11, 2018 at 06:56:39PM +0530, P J P wrote: >> From: Prasad J Pandit >> >> Define skeleton 'uar_read' routine. Avoid NULL dereference. >> >> Reported-by: Li Qiang >> Signed-off-by: Prasad J Pandit >> --- >>

Re: [Qemu-devel] [PATCH 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking

2018-11-20 Thread
At 2018-11-21 03:59:28, "Philippe Mathieu-Daudé" wrote: >Hi Markus, Li. > >On 20/11/18 20:34, Markus Armbruster wrote: >> Li Qiang writes: >> >>> And also do some code cleanup. >>> A lot of thanks to Markus's review and advice. >>> >>> Li Qiang (3): >>>fw_cfg: fix -boot bootsplash

Re: [Qemu-devel] [PATCH 2/2] hw: fw_cfg: refactor fw_cfg_reboot()

2018-11-18 Thread
At 2018-11-17 00:52:58, "Markus Armbruster" wrote: >Li Qiang writes: > >> Currently the user can set a negative reboot_timeout. >> Also it is wrong to parse 'reboot-timeout' with qemu_opt_get() and then >> convert it to number. > >Again, it's not wrong per se, just needlessly

Re: [Qemu-devel] [PATCH 1/2] hw: fw_cfg: refactor fw_cfg_bootsplash()

2018-11-18 Thread
At 2018-11-17 00:33:34, "Markus Armbruster" wrote: >Li Qiang writes: > >> Currently when the splash-time value is bigger than 0x >> we report and correct it, when it is less than 0 we just ingore it. > >s/ingore/ignore/ > >> Also we use qemu_opt_get() to get 'splash-time', then

Re: [Qemu-devel] [PATCH 2/2] tests: fw_cfg: add reboot_timeout test case

2018-10-29 Thread
At 2018-10-30 08:08:55, "Philippe Mathieu-Daudé" wrote: >On 28/10/18 13:40, Li Qiang wrote: >> Signed-off-by: Li Qiang >> --- >> tests/fw_cfg-test.c | 13 - >> 1 file changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/tests/fw_cfg-test.c b/tests/fw_cfg-test.c >>

Re: [Qemu-devel] qemu memory manage question

2017-04-17 Thread
> -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+liqiang6-s=360...@nongnu.org] On Behalf Of > jack.chen > Sent: Monday, April 17, 2017 6:56 PM > To: Peter Xu > Cc: qemu > Subject: Re: [Qemu-devel] qemu memory manage question > > Thanks,from the path you have list to

Re: [Qemu-devel] [for-2.9 PATCH 3/3] 9pfs: drop useless loop in v9fs_reset()

2017-03-31 Thread
> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Friday, March 31, 2017 7:28 PM > To: qemu-devel@nongnu.org > Cc: Eric Blake; 李强; Greg Kurz > Subject: [for-2.9 PATCH 3/3] 9pfs: drop useless loop in v9fs_reset() > > We don't need to wait

Re: [Qemu-devel] [for-2.9 PATCH 2/3] 9pfs: cancel active PDUs in virtfs_reset()

2017-03-31 Thread
> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Friday, March 31, 2017 7:27 PM > To: qemu-devel@nongnu.org > Cc: Eric Blake; 李强; Greg Kurz > Subject: [for-2.9 PATCH 2/3] 9pfs: cancel active PDUs in virtfs_reset() > > According to the

Re: [Qemu-devel] [for-2.9 PATCH 1/3] 9pfs: clear migration blocker at session reset

2017-03-31 Thread
> -Original Message- > From: Greg Kurz [mailto:gr...@kaod.org] > Sent: Friday, March 31, 2017 7:27 PM > To: qemu-devel@nongnu.org > Cc: Eric Blake; 李强; Greg Kurz > Subject: [for-2.9 PATCH 1/3] 9pfs: clear migration blocker at session reset > > The migration b

Re: [Qemu-devel] [PATCH] cirrus: fix off-by-one in cirrus_bitblt_rop_bkwd_transp_*_16

2017-03-17 Thread
] cirrus: fix off-by-one in > cirrus_bitblt_rop_bkwd_transp_*_16 > > The switch from pointers to addresses (commit > 026aeffcb4752054830ba203020ed6eb05bcaba8 and > ffaf857778286ca54e3804432a2369a279e73aa7) added a off-by-one bug to > 16bit backward blits. Fix. > > Reported-by: 李强 <liq

Re: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add option to disable blitter

2017-03-16 Thread
Hello Gerd, > -Original Message- > From: Qemu-devel > [mailto:qemu-devel-bounces+liqiang6-s=360...@nongnu.org] On Behalf Of > Gerd Hoffmann > Sent: Thursday, March 16, 2017 5:31 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: [Qemu-devel] [PULL for-2.9 4/7] cirrus: add

Re: [Qemu-devel] [PATCH] 9pfs: make unmarshal V9fsString more robust

2016-09-27 Thread
On 2016-09-28 0:40 GMT+08:00 Greg Kurz wrote: > > Talking about robustness was appropriate for your previous patches, but > it does not really apply here since v9fs_iov_vunmarshal() does not have > any issue with empty strings actually. > > I've changed the title to: > > 9pfs:

Re: [Qemu-devel] [PATCH] usb: ehci: fix memory leak in ehci_process_itd

2016-09-26 Thread
Ping! 2016-09-19 10:48 GMT+08:00 Li Qiang : > From: Li Qiang > > While processing isochronous transfer descriptors(iTD), if the page > select(PG) field value is out of bands it will return. In this > situation the ehci's sg list doesn't be freed thus leading

[Qemu-devel] [PATCH] usb:xhci:fix memory leak in usb_xhci_exit

2016-09-12 Thread
If the xhci uses msix, it doesn't free the corresponding memory, thus leading a memory leak issue. This patch avoid this. Signed-off-by: Li Qiang --- hw/usb/hcd-xhci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c

[Qemu-devel] 答复: [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-12 Thread
Hi Dmitry > > > On 12 Aug 2016, at 04:21 AM, 李强 <liqiang...@360.cn> wrote: > > > > Hello Dmitry, > > > > I don't see the assert for 'max_frags' in vmxnet device emulation. Could you > please point it out? > > > Hi, > > I mean that ma

[Qemu-devel] 答复: [PATCH] net: vmxnet: check fragments count at pkt initialisation

2016-08-12 Thread
max_frags + VMXNET_TX_PKT_PL_START_FRAG)); p->raw = g_malloc((sizeof *p->raw) * max_frags); *pkt = p; } IIUC, we should do assert in the device layer, in vmxnet3_activate_device() in vmxnet? > -邮件原件- > 发件人: Dmitry Fleytman [mailto:dmi...@daynix.com] > 发送时间: 2016年8月11日 16:16 > 收件人: P J