在 2017年1月5日，23:10，Peter Maydell 写道：
>> sysbus_init_irq(sbd, &s->irq);
>>sysbus_init_mmio(sbd, &s->mem_ctrl);
>>sysbus_init_mmio(sbd, &s->mem_vram);
>
> This means we call sysbus_init_mmio() on the MemoryRegion*s
> before we have initialized them. That seems like a bad idea.
Opps，will
, Jan 04, 2017 at 05:04:02PM +, Peter Maydell wrote:
>>> On 4 January 2017 at 03:28, David Gibson
>>> wrote:
>>>> On Tue, Jan 03, 2017 at 10:02:21PM +0800, 赵小强 wrote:
>>>> Hi，david：
>>>>
>>>> To my understanding，what m
Hmm，sounds reasonable. I will take a look.
PS: guys, some other comments about this?
Best wishes ！
>> 在 2017年1月4日，11:28，David Gibson 写道：
>>
>> On Tue, Jan 03, 2017 at 10:02:21PM +0800, 赵小强 wrote:
>> Hi，david：
>>
>> To my understanding，what must be put
Hi，david：
To my understanding，what must be put in the realize function is code which
depends on property values. What's the benefit of moving memory region
initialization into realize function? I can not figure out, can you make some
explanations?
Thanks for your review.
Best wishes ！
ping
At 2016-10-23 14:31:26, "xiaoqiang zhao" wrote:
>This patch set aims for QOM'ifying code relate with sparc.
>It is part of my QOM'ify work of qemu code base.
>
>xiaoqiang zhao (9):
> hw/misc: QOM'ify eccmemctl.c
> hw/dma: QOM'ify sparc32_dma.c
> hw/dma: QOM'ify sun4m_iommu.c
> hw/m
ping ...
At 2016-10-23 15:06:51, "xiaoqiang zhao" wrote:
>This is some QOM'ify work relate with etraxfs.
>See each commit for details.
>
>xiaoqiang zhao (2):
> hw/timer: QOM'ify etraxfs_timer
> hw/net: QOM'ify etraxfs_eth.c
>
> hw/net/etraxfs_eth.c | 34 +++---
>
At 2016-05-09 17:24:04, mich...@walle.cc wrote:
>Hi Peter,
>
>Am 2016-05-04 16:56, schrieb Peter Maydell:
>
>> SPARC, lm32, CRIS maintainers: do you want to take your patches
>> or shall I just take 1-8 through the target-arm.next tree?
>
>There are other ones (milkymist-ac97, lm32_uart, lm32_jua
在 2016-03-31 16:15:17，"xiaoqiang zhao" 写道：
>
>
>> 在 2016年3月31日，16:05，Peter Maydell 写道：
>>
>>> On 31 March 2016 at 02:48, xiaoqiang zhao wrote:
>>>
在 2016年03月16日 20:00, Peter Maydell 写道:
> On 16 March 2016 at 11:31, Peter Maydell wrote:
>
> A general note -- since thes
At 2016-03-17 17:06:12, "xiaoqiang zhao" wrote:
>This patch set QOM'ify some files under hw/audio directory.
>See each patch's commit message for details.
>
>Changes in v2:
>Move AUD_open_in/out function into device realize stage
>
>Sorry for the misoperation before, so I resend this ver
At 2016-05-05 18:39:52, "Peter Maydell" wrote:
>On 5 May 2016 at 11:28, xiaoqiang zhao wrote:
>> This patch set QOM'ify files under hw/intc directory. See each commit
>> message for details.
>>
>> Changes in v1:
>> use error_setg instead of error_report in realize function
>
>How can
At 2016-03-29 15:47:19, "xiaoqiang zhao" wrote:
>This patch set trys to QOM'ify hw/char files, see commit messages
>for more details
>
>Changes in v2:
>* rename TYPE_SCLP_LM_CONSOLE to TYPE_SCLPLM_CONSOLE which is suggested by
> Cornelia Huck
>* rebase on the current master
>
>xiaoqi
于 12/19/2013 02:03 AM, Andreas Färber 写道:
Am 05.11.2013 11:16, schrieb xiaoqiang zhao:
changes:
1. use type constant for kvm_ioapic and ioapic
2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic
For QOM'ify, I move variable 'ioapic_no' from static to global.
Then we can drop the 'inst
于 12/19/2013 10:28 AM, Chen Fan 写道:
On Wed, 2013-12-18 at 19:03 +0100, Andreas Färber wrote:
Am 05.11.2013 11:16, schrieb xiaoqiang zhao:
changes:
1. use type constant for kvm_ioapic and ioapic
2. convert 'init' to QOM's 'realize' for ioapic and kvm_ioapic
For QOM'ify, I move variable 'ioapic_n
于 11/29/2013 11:48 AM, Andreas Färber 写道:
Am 29.11.2013 02:26, schrieb 赵小强:
于 11/12/2013 10:52 PM, Andreas Färber 写道:
it would be nice if you could check whether these
devices (the non-KVM versions at least) are covered by make check. For
ICC bus I am certain that it is.
1. Does "
于 11/29/2013 11:48 AM, Andreas Färber 写道:
Am 29.11.2013 02:26, schrieb 赵小强:
于 11/12/2013 10:52 PM, Andreas Färber 写道:
it would be nice if you could check whether these
devices (the non-KVM versions at least) are covered by make check. For
ICC bus I am certain that it is.
1. Does "
于 11/13/2013 02:06 PM, 赵小强 写道:
于 11/12/2013 10:52 PM, Andreas Färber 写道:
Resending yesterday's message since it hasn't arrived on qemu-devel...
Am 11.11.2013 04:58, schrieb 赵小强:
于 11/05/2013 04:51 PM, 赵小强 写道:
于 2013年11月05日 16:25, Chen Fan 写道:
On Tue, 2013-11-05 at 15:55 +0800,
于 11/12/2013 10:52 PM, Andreas Färber 写道:
Resending yesterday's message since it hasn't arrived on qemu-devel...
Am 11.11.2013 04:58, schrieb 赵小强:
于 11/05/2013 04:51 PM, 赵小强 写道:
于 2013年11月05日 16:25, Chen Fan 写道:
On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote:
[...]
di
于 11/12/2013 11:02 AM, Chen Fan 写道:
On Tue, 2013-11-12 at 09:54 +0800, 赵小强 wrote:
于 11/12/2013 09:28 AM, Chen Fan 写道:
On Mon, 2013-11-11 at 11:58 +0800, 赵小强 wrote:
于 11/05/2013 04:51 PM, 赵小强 写道:
于 2013年11月05日 16:25, Chen Fan 写道:
On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote
于 11/12/2013 09:28 AM, Chen Fan 写道:
On Mon, 2013-11-11 at 11:58 +0800, 赵小强 wrote:
于 11/05/2013 04:51 PM, 赵小强 写道:
于 2013年11月05日 16:25, Chen Fan 写道:
On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote:
changes includes:
1. use type constant for apic and kvm_apic
2. convert function '
于 11/05/2013 04:51 PM, 赵小强 写道:
于 2013年11月05日 16:25, Chen Fan 写道:
On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote:
changes includes:
1. use type constant for apic and kvm_apic
2. convert function 'init' to QOM's 'realize' for apic/kvm_apic
3. for consistency, a
于 2013年11月05日 16:25, Chen Fan 写道:
On Tue, 2013-11-05 at 15:55 +0800, xiaoqiang zhao wrote:
changes includes:
1. use type constant for apic and kvm_apic
2. convert function 'init' to QOM's 'realize' for apic/kvm_apic
3. for consistency, also QOM'ify apic's parent bus 'icc_bus'
---
hw/cpu/icc_bu
于 11/05/2013 01:23 AM, Andreas Färber 写道:
Hi,
Am 04.11.2013 07:41, schrieb 赵小强:
于 09/27/2013 01:30 PM, xiaoqiang zhao 写道:
From: "xiaoqiang.zhao"
Change apic and kvm/apic to use QOM interface.
Includes:
1. APICCommonState now use QOM realizefn
2. Remove DO_UPCAST() for APICCom
于 09/27/2013 01:30 PM, xiaoqiang zhao 写道:
From: "xiaoqiang.zhao"
Change apic and kvm/apic to use QOM interface.
Includes:
1. APICCommonState now use QOM realizefn
2. Remove DO_UPCAST() for APICCommonState
3. Use type constant
4. Change DeviceState pointers from 'd' to 'dev', sounds better?
Si
23 matches
Mail list logo
