Re: [Qemu-devel] [PATCH v6 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

>> So finally: >> >> Tested-by: Alex Bennée > Thanks for the testing. > > Abdallah: I've added this series to my target-arm.next queue, > so it should reach QEMU master some time next week. Thanks for > your efforts in working through QEMU's review process, and > sorry

Re: [Qemu-devel] [PATCH v6 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

> Abdallah Bouassida <abdallah.bouass...@lauterbach.com> writes: > >> The previous version: >> http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714 > I was trying to do some testing but I was finding it very hard to do at > gdb kept throwing up er

[Qemu-devel] ping Re: [PATCH v6 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

ping Le 4/19/2018 à 4:56 PM, Abdallah Bouassida a écrit : > The previous version: > http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714 > > Abdallah Bouassida (3): > target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo > type >

[Qemu-devel] [PATCH v6 3/3] target/arm: Add the XML dynamic generation

Generate an XML description for the cp-regs. Register these regs with the gdb_register_coprocessor(). Add arm_gdb_get_sysreg() to use it as a callback to read those regs. Add a dummy arm_gdb_set_sysreg(). Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- gdb

[Qemu-devel] [PATCH v6 2/3] target/arm: Add "_S" suffix to the secure version of a sysreg

ers follow the same convention. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> --- target/arm/helper.c | 29 ++--- 1 file changed, 18

[Qemu-devel] [PATCH v6 1/3] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

for any register we want to remove from the dynamic XML description. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Reviewed-by: Alex Bennée <alex.ben...@linaro.org> --- target/arm/cpu.h| 3 ++- targe

[Qemu-devel] [PATCH v6 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

The previous version: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714 Abdallah Bouassida (3): target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type target/arm: Add "_S" suffix to the secure version of a sysreg target/arm:

Re: [Qemu-devel] [Qemu-arm] [PATCH v5 3/3] target/arm: Add the XML dynamic generation

Hi Alex, First of all, thanks for the review! >> +static int arm_gdb_get_sysreg(CPUARMState *env, uint8_t *buf, int reg) >> +{ >> +ARMCPU *cpu = arm_env_get_cpu(env); >> +const ARMCPRegInfo *ri; >> +uint32_t key; >> + >> +key = cpu->dyn_xml.cpregs_keys[reg]; >> +ri =

[Qemu-devel] ping Re: [PATCH v5 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

ping http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33714

[Qemu-devel] [PATCH v5 2/3] target/arm: Add "_S" suffix to the secure version of a sysreg

ers follow the same convention. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- target/arm/helper.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/target/arm

[Qemu-devel] [PATCH v5 3/3] target/arm: Add the XML dynamic generation

Generate an XML description for the cp-regs. Register these regs with the gdb_register_coprocessor(). Add arm_gdb_get_sysreg() to use it as a callback to read those regs. Add a dummy arm_gdb_set_sysreg(). Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- gdb

[Qemu-devel] [PATCH v5 0/3] target/arm: Add a dynamic XML-description of the cp-registers to GDB

The previous version: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=33190 Abdallah Bouassida (3): target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type target/arm: Add "_S" suffix to the secure version of a sysreg target/arm:

[Qemu-devel] [PATCH v5 1/3] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

for any register we want to remove from the dynamic XML description. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- target/arm/cpu.h| 3 ++- target/arm/helper.c | 2 +- 2 files changed, 3 insertions(+),

[Qemu-devel] [PATCH v4 4/4] target/arm: Add arm_gdb_set_sysreg() callback

This is a callback to set the cp-regs registered by the dynamic XML. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- >> Adding to that our customers may need this write access, our tool TRACE32® >> needs this also in some particular cases. For

[Qemu-devel] [PATCH v4 2/4] target/arm: Add "_S" suffix to the secure version of a sysreg

ers follow the same convention. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- target/arm/helper.c | 29 ++--- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index c5d62c8..3b31f71 100

[Qemu-devel] [PATCH v4 3/4] target/arm: Add the XML dynamic generation

Generate an XML description for the cp-regs. Register these regs with the gdb_register_coprocessor(). Add arm_gdb_get_sysreg() to use it as a callback to read those regs. Add a dummy arm_gdb_set_sysreg(). Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- gdb

[Qemu-devel] [PATCH v4 1/4] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

for any register we want to remove from the dynamic XML description. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> --- target/arm/cpu.h| 3 ++- target/arm/helper.c | 2 +- 2 files changed, 3 insertions(+),

[Qemu-devel] [PATCH v4 0/4] Add a dynamic XML-description of the cp-registers to GDB

The previous version: http://patchwork.ozlabs.org/project/qemu-devel/list/?series=30973 Abdallah Bouassida (4): target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type target/arm: Add "_S" suffix to the secure version of a sysreg target/arm:

Re: [Qemu-devel] [PATCH v3 3/4] target/arm: Add the XML dynamic generation

Hi Peter, >> diff --git a/gdbstub.c b/gdbstub.c >> index f1d5148..ffab30b 100644 >> --- a/gdbstub.c >> +++ b/gdbstub.c >> @@ -665,6 +665,9 @@ static const char *get_feature_xml(const char *p, const >> char **newp, >> pstrcat(target_xml, sizeof(target_xml), ">

[Qemu-devel] [PATCH v3 3/4] target/arm: Add the XML dynamic generation

Generate an XML description for the cp-regs. Register these regs with the gdb_register_coprocessor(). Add arm_gdb_get_sysreg() to use it as a callback to read those regs. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- gdbstub.c| 7 include/qom

[Qemu-devel] [PATCH v3 0/4] target/arm: Add a dynamic XML-description of the cp-registers to GDB

review, Thanks a lot ;) Abdallah Bouassida (4): target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type target/arm: Add "_S" suffix to the secure version of a sysreg target/arm: Add the XML dynamic generation target/arm: Add arm_gdb_set_sysreg

[Qemu-devel] [PATCH v3 4/4] target/arm: Add arm_gdb_set_sysreg() callback

This is a callback to set the cp-regs registered by the dynamic XML. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- >> Some of our customers need to connect to Qemu using our tool TRACE32® >> via GDB, >> and for some use case they need to h

[Qemu-devel] [PATCH v3 1/4] target/arm: Add "ARM_CP_NO_GDB" as a new bit field for ARMCPRegInfo type

for any register we want to remove from the dynamic XML description. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- target/arm/cpu.h| 3 ++- target/arm/helper.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h

[Qemu-devel] [PATCH v3 2/4] target/arm: Add "_S" suffix to the secure version of a sysreg

ers follow the same convention. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- target/arm/helper.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/target/arm/helper.c b/target/arm/helper.c index bdd212f.

Re: [Qemu-devel] [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB This patch offers to GDB the ability to read/write all the coprocessor registers for ARM and ARM64 by generating dynamically an XML-description for these registers. Signed-off-by: Abdallah Bouassida <abdallah.bou

Re: [Qemu-devel] [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB This patch offers to GDB the ability to read/write all the coprocessor registers for ARM and ARM64 by generating dynamically an XML-description for these registers. Signed-off-by: Abdallah Bouassida <abdallah.bou

Re: [Qemu-devel] ping Re: [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

dynamically an XML-description for these registers. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- Hello Peter, Thanks for reviewing the previous version of this patch! http://patchwork.ozlabs.org/patch/861374/ *For the ARM64, should I differentiate the reg

[Qemu-devel] ping Re: [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- Hello Peter, Thanks for reviewing the previous version of this patch! http://patchwork.ozlabs.org/patch/861374/ *For the ARM64, should I differentiate the registers that have two views (32 and 64) Maybe by

[Qemu-devel] [PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB

[PATCH V2] target-arm:Add a dynamic XML-description of the cp-registers to GDB This patch offers to GDB the ability to read/write all the coprocessor registers for ARM and ARM64 by generating dynamically an XML-description for these registers. Signed-off-by: Abdallah Bouassida <abdallah.bou

[Qemu-devel] [PATCH RFC] target-arm:Add a dynamic XML-description of the cp-registers to GDB

t;32" tag for the registers name for the 32bit view and a "64" for the 64bit view. *How to properly handle the secure and the non secure views? Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> ---  gdbstub.c    | 18 +++  include/qom/cpu.h    | 19 +

Re: [Qemu-devel] [PATCH] target-arm: Bug fix in filling the cp_regs hashtable

Oh, I see! Thanks for the details! Regards, Abdallah Le 6/16/2017 à 3:51 PM, Peter Maydell a écrit : On 16 June 2017 at 15:42, Abdallah Bouassida <abdallah.bouass...@lauterbach.com> wrote: Check if the CPU supports AARCH64 before adding the 64bit view of the coprocessor's re

[Qemu-devel] [PATCH] target-arm: Bug fix in filling the cp_regs hashtable

Check if the CPU supports AARCH64 before adding the 64bit view of the coprocessor's register to the cp_regs hashtable. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- Bug description: if a register has the .state = ARM_CP_STATE_BOTH, its 64bit view will be

[Qemu-devel] [PATCH] target-x86: Add GDB XML description for SSE registers

xml_file to the new XML wrapper, modify the gdb_num_core_regs to fit the registers number defined in each XML file. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- @Paolo: This patch is in response to your hints here: https://lists.gnu.org/archive/html/qemu-devel/2017-03

Re: [Qemu-devel] [PATCH] target-x86:Add GDB XML register description support

ping http://patchwork.ozlabs.org/patch/709408/ Le 12/28/2016 à 5:34 PM, Abdallah Bouassida a écrit : [Qemu-devel] [PATCH] target-x86:Add GDB XML register description support This patch implements XML target description support for X86 and X86-64 architectures in the GDB stub, as the way

[Qemu-devel] [PATCH] target-x86:Add GDB XML register description support

file. Signed-off-by: Abdallah Bouassida <abdallah.bouass...@lauterbach.com> --- configure | 2 ++ gdb-xml/32bit-core.xml | 65 gdb-xml/64bit-core.xml | 73 ++ target/i386/cpu.c