[PULL 16/18] plugins: add plugin API to read guest memory

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée Message-Id: <20240916085400.1046925-17-alex.ben...@linaro.org> diff --git a/inclu

Canceled event with note: QEMU/KVM developers conference call @ Tue 17 Sept 2024 14:00 - 15:00 (BST) (qemu-devel@nongnu.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDA

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

Brian Cain writes: > On 9/16/2024 8:12 AM, Alex Bennée wrote: >> Brian Cain writes: >> >>> On 9/6/2024 9:39 PM, Brian Cain wrote: >>>> With newer clang builds (19.x), there's a warning for implicit function >>>> declarations and it r

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

t;> +++ b/tests/tcg/multiarch/linux/linux-test.c >> @@ -17,6 +17,7 @@ >>* along with this program; if not, see <http://www.gnu.org/licenses/>. >>*/ >> #define _GNU_SOURCE >> +#define _LARGEFILE64_SOURCE >> #include >> #include >

Re: [PATCH] tests/tcg/multiarch: Define _LARGEFILE64_SOURCE

t;> +++ b/tests/tcg/multiarch/linux/linux-test.c >> @@ -17,6 +17,7 @@ >>* along with this program; if not, see <http://www.gnu.org/licenses/>. >>*/ >> #define _GNU_SOURCE >> +#define _LARGEFILE64_SOURCE >> #include >> #include >>

[PATCH v2 16/18] plugins: add plugin API to read guest memory

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée --- vAJB: - explicit bool for cpu_memory_rw_debug v2 - fix alignment --- includ

[PATCH v2 17/18] plugins: add option to dump write argument to syscall plugin

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier Message-Id: <20240827215329.248434-3-rowanbh...@gmail.com> [AJB: tweak fmt string for vaddr] Signed-off-by: Alex Bennée --- vAJB - tweak fmt string for PRIu64 v2 - add sta

[PATCH v2 15/18] contrib/plugins: Add a plugin to generate basic block vectors

Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240816-bb-v3-1-b9aa4a5c7...@daynix.com> Signed-off-by: Alex Bennée --- docs/about/emulation.rst | 30 contrib/plugins/bbv.c| 158 +++ contrib/plugins/Makefile | 1 + 3 files changed, 189

[PATCH v2 18/18] contrib/plugins: avoid hanging program

Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Signed-off-by: Alex Bennée Reported-by: Elisha Hollander Reviewed-by: Richard Henderson --- contrib/plugins/ips.c | 5 + 1 file

[PATCH v2 09/18] tests/tcg/multiarch: add test for plugin memory access

From: Pierrick Bouvier Add an explicit test to check expected memory values are read/written. 8,16,32 load/store are tested for all arch. 64,128 load/store are tested for aarch64/x64. atomic operations (8,16,32,64) are tested for x64 only. By default, atomic accesses are non atomic if a single c

[PATCH v2 14/18] util/timer: avoid deadlock when shutting down

d-off-by: Alex Bennée Reported-by: Elisha Hollander --- util/qemu-timer.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 213114be68..6b1533bc2a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -685,10 +6

[PATCH v2 10/18] tests/tcg: clean up output of memory system test

: <20240910140733.4007719-20-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 47 ++--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tes

[PATCH v2 12/18] tests/tcg: ensure s390x-softmmu output redirected

The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Comment the use of EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée --- v2 - don't remove EXTFLAGS, add comment ---

[PATCH v2 13/18] tests/tcg: add a system test to check memory instrumentation

d a regions worth of writes to the expected total. Signed-off-by: Alex Bennée --- v2 - aggressively align test_data on "region size" - sort the regions in the final report - ensure alpha-softmmu uses byte access when it can v3 - fix thinko while iterating through the regions - fix

[PATCH v2 11/18] tests/tcg: only read/write 64 bit words on 64 bit systems

Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- v2 - >= test of __SIZEOF_POINTER__ --- tests/tcg/multiarch/system/memory.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/mu

[PATCH v2 04/18] plugins: save value during memory accesses

iewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 66 ++- include/hw/core/cpu.h | 4 +++

[PATCH v2 06/18] tests/tcg: add mechanism to run specific tests with plugins

ed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 452a2cde65..c5b1c7a786 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -152,10 +

[PATCH v2 02/18] deprecation: don't enable TCG plugins by default with TCI

ouvier Signed-off-by: Alex Bennée --- docs/about/deprecated.rst | 8 configure | 11 +-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index f7c7c33d39..5aa2e35314 100644 --- a/docs/about/deprecat

[PATCH v2 05/18] plugins: extend API to get latest memory value accessed

://gitlab.com/qemu-project/qemu/-/issues/2152 Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h

[PATCH v2 07/18] tests/tcg: allow to check output of plugins

off-by: Alex Bennée --- tests/tcg/Makefile.target | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index c5b1c7a786..2da70b2fcf 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -90,6 +90,7 @@ CFLAGS= L

[PATCH v2 03/18] contrib/plugins: control flow plugin

ben...@linaro.org> Based-on: <20240312075428.244210-1-pierrick.bouv...@linaro.org> Cc: Gustavo Romero Signed-off-by: Alex Bennée --- v2 - only need a single call back - drop need for INSN_WIDTH - still don't understand the early exits v3 - move initial STORE ops to first ins

[PATCH v2 00/18] tcg plugins pre-PR (deprecations, mem apis, contrib plugins)

/multiarch: add test for plugin memory access (0 acks, 1 sobs, 1 tbs) v2 - fix some nits - included fix to ips posted as an RFC before Alex. Akihiko Odaki (1): contrib/plugins: Add a plugin to generate basic block vectors Alex Bennée (9): deprecation: don't enable TCG plugins by default

[PATCH v2 01/18] deprecation: don't enable TCG plugins by default on 32 bit hosts

-12-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- v2 - don't manually set based on CPU type, use __SIZEOF_POINTER__ --- docs/about/deprecated.rst | 11 +++ configure | 21 - 2 files changed, 31 inser

[PATCH v2 08/18] tests/tcg/plugins/mem: add option to print memory accesses

: Pierrick Bouvier Message-Id: <20240724194708.1843704-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/mem.c | 69 - 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plu

Re: [PATCH 11/17] tests/tcg: only read/write 64 bit words on 64 bit systems

Philippe Mathieu-Daudé writes: > On 13/9/24 19:26, Alex Bennée wrote: >> While the compilers will generally happily synthesise a 64 bit value >> for you on 32 bit systems it doesn't exercise anything on QEMU. It >> also makes it hard to accurately compare the acc

Re: [PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected

Thomas Huth writes: > On 13/09/2024 19.26, Alex Bennée wrote: >> The multiarch system tests output serial data which should be >> redirected to the "output" chardev rather than echoed to the console. >> Remove the unused EXTFLAGS variable while we are at it

[RFC PATCH] contrib/plugins: avoid hanging program

Although we asks for instructions per second we work in quanta and that cannot be 0. Fail to load the plugin instead and report the minimum IPS we can handle. Signed-off-by: Alex Bennée Reported-by: Elisha Hollander --- contrib/plugins/ips.c | 5 + 1 file changed, 5 insertions(+) diff

[PATCH 15/17] contrib/plugins: Add a plugin to generate basic block vectors

Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240816-bb-v3-1-b9aa4a5c7...@daynix.com> Signed-off-by: Alex Bennée --- docs/about/emulation.rst | 30 contrib/plugins/bbv.c| 158 +++ contrib/plugins/Makefile | 1 + 3 files changed, 189

[PATCH 17/17] plugins: add option to dump write argument to syscall plugin

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier Message-Id: <20240827215329.248434-3-rowanbh...@gmail.com> [AJB: tweak fmt string for vaddr] Signed-off-by: Alex Bennée --- vAJB - tweak fmt string for PRIu64 --- docs/about/emulati

[PATCH 16/17] plugins: add plugin API to read guest memory

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée --- vAJB: - explicit bool for cpu_memory_rw_debug --- include/qemu/qemu-plugin.h

[PATCH 02/17] deprecation: don't enable TCG plugins by default with TCI

ouvier Signed-off-by: Alex Bennée --- docs/about/deprecated.rst | 8 configure | 11 +-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index f7c7c33d39..5aa2e35314 100644 --- a/docs/about/deprecat

[PATCH 13/17] tests/tcg: add a system test to check memory instrumentation

d a regions worth of writes to the expected total. Signed-off-by: Alex Bennée --- v2 - aggressively align test_data on "region size" - sort the regions in the final report - ensure alpha-softmmu uses byte access when it can v3 - fix thinko while iterating through the regions - fix

[PATCH 10/17] tests/tcg: clean up output of memory system test

: <20240910140733.4007719-20-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 47 ++--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tes

[PATCH 01/17] deprecation: don't enable TCG plugins by default on 32 bit hosts

-12-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- v2 - don't manually set based on CPU type, use __SIZEOF_POINTER__ --- docs/about/deprecated.rst | 11 +++ configure | 21 - 2 files changed, 31 inser

[PATCH 14/17] util/timer: avoid deadlock when shutting down

d-off-by: Alex Bennée Reported-by: Elisha Hollander --- util/qemu-timer.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 213114be68..6b1533bc2a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -685,10 +6

[PATCH 03/17] contrib/plugins: control flow plugin

ben...@linaro.org> Based-on: <20240312075428.244210-1-pierrick.bouv...@linaro.org> Cc: Gustavo Romero Signed-off-by: Alex Bennée --- v2 - only need a single call back - drop need for INSN_WIDTH - still don't understand the early exits v3 - move initial STORE ops to first ins

[PATCH 07/17] tests/tcg: allow to check output of plugins

off-by: Alex Bennée --- tests/tcg/Makefile.target | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index c5b1c7a786..2da70b2fcf 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -90,6 +90,7 @@ CFLAGS= L

[PATCH 12/17] tests/tcg: ensure s390x-softmmu output redirected

The multiarch system tests output serial data which should be redirected to the "output" chardev rather than echoed to the console. Remove the unused EXTFLAGS variable while we are at it. Signed-off-by: Alex Bennée --- tests/tcg/s390x/Makefile.softmmu-target | 2 +- 1 file changed, 1

[PATCH 11/17] tests/tcg: only read/write 64 bit words on 64 bit systems

Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index 8f2371975d..680dd4

[PATCH 09/17] tests/tcg/multiarch: add test for plugin memory access

From: Pierrick Bouvier Add an explicit test to check expected memory values are read/written. 8,16,32 load/store are tested for all arch. 64,128 load/store are tested for aarch64/x64. atomic operations (8,16,32,64) are tested for x64 only. By default, atomic accesses are non atomic if a single c

[PATCH 04/17] plugins: save value during memory accesses

iewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 66 ++- include/hw/core/cpu.h | 4 +++

[PATCH 05/17] plugins: extend API to get latest memory value accessed

://gitlab.com/qemu-project/qemu/-/issues/2152 Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h

[PATCH 08/17] tests/tcg/plugins/mem: add option to print memory accesses

: Pierrick Bouvier Message-Id: <20240724194708.1843704-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/mem.c | 69 - 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plu

[PATCH 00/17] tcg plugins pre-PR (deprecations, mem apis, contrib plugins)

/multiarch: add test for plugin memory access (0 acks, 1 sobs, 1 tbs) Alex. Akihiko Odaki (1): contrib/plugins: Add a plugin to generate basic block vectors Alex Bennée (8): deprecation: don't enable TCG plugins by default on 32 bit hosts deprecation: don't enable TCG plugins by defaul

[PATCH 06/17] tests/tcg: add mechanism to run specific tests with plugins

ed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 452a2cde65..c5b1c7a786 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -152,10 +

Re: [PATCH 1/2] tcg: Return TCGOp from tcg_gen_op[1-6]

Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/2] tcg: Fix branch/label link during plugin expansion

reading this. How can TCG know the state of the scoreboard variables and optimise away the branch? > > > r~ -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 1/1] allow using a higher icount

work for me. Can you try them out? > > On Tue, Sep 3, 2024, 14:13 Alex Bennée wrote: > > Alex Bennée writes: > > > Elisha Hollander writes: > > > >> Sure! > >> > >> `build/qemu-system-i386 -plugin build/contrib/plugins/libips.so,ip

Re: [PATCH v8 6/6] tests/tcg/multiarch: add test for plugin memory access

c is the list of expected patterns in > plugin output. By reading stdout, we can compare to plugins output and > have a multiarch test. > > Can be run with: > make -C build/tests/tcg/$ARCH-linux-user > run-plugin-test-plugin-mem-access-with-libmem.so Queued to plugins/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL 03/10] tests/docker: use debian-all-test-cross for mips64el tests

While the mips64el cross compilation environment is busted in Debian we can use the debian-all-test-cross image for building TCG tests like we do in the CI. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-4-alex.ben...@linaro.org> diff -

[PULL 01/10] tests/docker: remove debian-armel-cross

-container which is currently built from the more recent debian-12. Reviewed-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-2-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/con

[PULL 00/10] testing and gdbstub updates

ove docker-armel-cross - update i686 and mipsel images to bookworm - use docker-all-test-cross for mips64le tests - fix duplicated line in docs - update gitlab-runner ansible script - support MTE in gdbstub for system mode ---- A

[PULL 10/10] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode

tests. It links against boot.S and is executed by QEMU in system mode. Signed-off-by: Gustavo Romero Message-Id: <20240906143316.657436-6-gustavo.rom...@linaro.org> [AJB: fix stray _] Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-11-alex.ben...@linaro.org> di

[PULL 06/10] gdbstub: Use specific MMU index when probing MTE addresses

(which can be as small as 1 byte), rather than the number of bits used in the address space pointed to by ptr. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240906143316.657436-2-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240910173900.

[PULL 05/10] scripts/ci: update the gitlab-runner playbook

The upstream install instructions: https://docs.gitlab.com/runner/install/linux-repository.html Now refer to repositories and a setup script. Modernise the playbook to use the preferred delivery method. Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id

[PULL 02/10] tests/docker: update debian i686 and mipsel images to bookworm

Whatever issues there were which stopped these being updates when the rest were have now been resolved. However mips64el continues to be broken so don't update it here. Reviewed-by: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240910173900.4

[PULL 07/10] gdbstub: Add support for MTE in system mode

Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240906143316.657436-3-gustavo.rom...@linaro.org> [AJB: add #ifdef CONFIG_TCG guards] Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-8-alex.ben...@linaro.org> diff --git a/target/arm/gdbstub64.c

[PULL 08/10] tests/guest-debug: Support passing arguments to the GDB test script

mooth and informative exit if, for instance, the caller of the runner script passes an invalid argument or misses a required argument by the test script. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Message-Id: <20240906143316.657436-4-gustavo.rom...@linaro.org> Signed-off-by: Alex

[PULL 09/10] tests/tcg/aarch64: Improve linker script organization

From: Gustavo Romero Improve kernel.ld linker script organization by using MEMORY command. Signed-off-by: Richard Henderson Signed-off-by: Gustavo Romero Message-Id: <20240906143316.657436-5-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-10

[PULL 04/10] docs/devel: fix duplicate line

I guess the same change came in via two patch series. Remove the repetition. Fixes: 2a851fca9f (docs/devel: remind developers to run CI container pipeline when updating images) Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240910173900.4154726-5-alex.ben...@linaro.

[PATCH v2 10/10] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode

tests. It links against boot.S and is executed by QEMU in system mode. Signed-off-by: Gustavo Romero Message-Id: <20240906143316.657436-6-gustavo.rom...@linaro.org> [AJB: fix stray _] Signed-off-by: Alex Bennée --- v2 fixed stray underline causing tests to be skippe

[PATCH v2 09/10] tests/tcg/aarch64: Improve linker script organization

From: Gustavo Romero Improve kernel.ld linker script organization by using MEMORY command. Signed-off-by: Richard Henderson Signed-off-by: Gustavo Romero Message-Id: <20240906143316.657436-5-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/aarch64/system/kernel.l

[PATCH v2 08/10] tests/guest-debug: Support passing arguments to the GDB test script

mooth and informative exit if, for instance, the caller of the runner script passes an invalid argument or misses a required argument by the test script. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Message-Id: <20240906143316.657436-4-gustavo.rom...@linaro.org> Signed-off-by: Alex Be

[PATCH v2 01/10] tests/docker: remove debian-armel-cross

-container which is currently built from the more recent debian-12. Message-Id: <20240910140733.4007719-2-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 6 - .gitlab-ci.d/crossbuilds.yml

[PATCH v2 02/10] tests/docker: update debian i686 and mipsel images to bookworm

Whatever issues there were which stopped these being updates when the rest were have now been resolved. However mips64el continues to be broken so don't update it here. Message-Id: <20240910140733.4007719-3-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by:

[PATCH v2 06/10] gdbstub: Use specific MMU index when probing MTE addresses

(which can be as small as 1 byte), rather than the number of bits used in the address space pointed to by ptr. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240906143316.657436-2-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée --- target/arm/gdbstub64.

[PATCH v2 07/10] gdbstub: Add support for MTE in system mode

Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240906143316.657436-3-gustavo.rom...@linaro.org> [AJB: add #ifdef CONFIG_TCG guards] Signed-off-by: Alex Bennée --- v2 - while we enable system mode it is still TCG only so added guards to handle the --disable-

[PATCH v2 03/10] tests/docker: use debian-all-test-cross for mips64el tests

While the mips64el cross compilation environment is busted in Debian we can use the debian-all-test-cross image for building TCG tests like we do in the CI. Signed-off-by: Alex Bennée --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

[PATCH v2 05/10] scripts/ci: update the gitlab-runner playbook

errick Bouvier Signed-off-by: Alex Bennée --- scripts/ci/setup/gitlab-runner.yml | 39 +++--- 1 file changed, 30 insertions(+), 9 deletions(-) diff --git a/scripts/ci/setup/gitlab-runner.yml b/scripts/ci/setup/gitlab-runner.yml index 7bdafab511..57e7faebf1 100644 --- a/scri

[PATCH v2 04/10] docs/devel: fix duplicate line

I guess the same change came in via two patch series. Remove the repetition. Fixes: 2a851fca9f (docs/devel: remind developers to run CI container pipeline when updating images) Message-Id: <20240910140733.4007719-4-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex

[PATCH v2 00/10] Maintainer updates (testing, gdbstub) pre-PR

oo large. I'll roll a new series once I've sent the PR for this. Changes - moved mips64le TCG tests to use the debian-all-test-cross - fixed some --disable-tcg failures for the MTE patches The following still need review: tests/docker: use debian-all-test-cross for mips64el tes

[PATCH 23/26] contrib/plugins: Add a plugin to generate basic block vectors

Odaki Reviewed-by: Pierrick Bouvier Message-Id: <20240816-bb-v3-1-b9aa4a5c7...@daynix.com> Signed-off-by: Alex Bennée --- docs/about/emulation.rst | 30 contrib/plugins/bbv.c| 158 +++ contrib/plugins/Makefile | 1 + 3 files changed, 189

[PATCH 21/26] tests/tcg: add a system test to check memory instrumentation

use the test_data is page aligned we can be sure all accesses to it are ones we can count. Finally we add a python script to integrate the data from the plugin and the output of the test and validate they both agree on the total counts. Signed-off-by: Alex Bennée --- v2 - aggressively align

[PATCH 25/26] plugins: add option to dump write argument to syscall plugin

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Tested-by: Pierrick Bouvier Message-Id: <20240827215329.248434-3-rowanbh...@gmail.com> [AJB: tweak fmt string for vaddr] Signed-off-by: Alex Bennée --- vAJB - tweak fmt string for PRIu64 --- docs/about/emulati

[PATCH 20/26] tests/tcg: only read/write 64 bit words on 64 bit systems

While the compilers will generally happily synthesise a 64 bit value for you on 32 bit systems it doesn't exercise anything on QEMU. It also makes it hard to accurately compare the accesses to test_data when instrumenting. Signed-off-by: Alex Bennée --- tests/tcg/multiarch/system/memory.c

[PATCH 24/26] plugins: add plugin API to read guest memory

From: Rowan Hart Signed-off-by: Rowan Hart Reviewed-by: Pierrick Bouvier Message-Id: <20240827215329.248434-2-rowanbh...@gmail.com> [AJB: tweaked cpu_memory_rw_debug call] Signed-off-by: Alex Bennée --- vAJB: - explicit bool for cpu_memory_rw_debug --- include/qemu/qemu-plugin.h

[PATCH 22/26] util/timer: avoid deadlock when shutting down

d-off-by: Alex Bennée Reported-by: Elisha Hollander --- util/qemu-timer.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/util/qemu-timer.c b/util/qemu-timer.c index 213114be68..6b1533bc2a 100644 --- a/util/qemu-timer.c +++ b/util/qemu-timer.c @@ -685,10 +6

[PATCH 19/26] tests/tcg: clean up output of memory system test

: Alex Bennée --- tests/tcg/multiarch/system/memory.c | 47 ++--- 1 file changed, 29 insertions(+), 18 deletions(-) diff --git a/tests/tcg/multiarch/system/memory.c b/tests/tcg/multiarch/system/memory.c index 6eb2eb16f7..8f2371975d 100644 --- a/tests/tcg/multiarch/system

[PATCH 06/26] gdbstub: Add support for MTE in system mode

Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240906143316.657436-3-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée --- target/arm/gdbstub64.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/target/arm/gdbstub64.c b/target/arm/g

[PATCH 09/26] tests/tcg/aarch64: Extend MTE gdbstub tests to system mode

tests. It links against boot.S and is executed by QEMU in system mode. Signed-off-by: Gustavo Romero Message-Id: <20240906143316.657436-6-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée --- configure | 5 + tests/tcg/aarch64/Makefile.soft

[PATCH 14/26] plugins: save value during memory accesses

iewed-by: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- accel/tcg/atomic_template.h | 66 ++- include/hw/core/cpu.h | 4 +++

[PATCH 10/26] contrib/plugins/Makefile: Add a 'distclean' target

o avoid regressions with "make distclean", add this command to one of the build jobs, too. Signed-off-by: Thomas Huth Reviewed-by: Pierrick Bouvier Message-Id: <20240902154749.73876-1-th...@redhat.com> Signed-off-by: Alex Bennée --- .gitlab-ci.d/buildtest.yml | 2 ++ contrib

[PATCH 02/26] tests/docker: update debian i686 and mipsel images to bookworm

Whatever issues there were which stopped these being updates when the rest were have now been resolved. However mips64el continues to be broken so don't update it here. Signed-off-by: Alex Bennée --- tests/docker/dockerfiles/debian-i686-cross.docker | 10 -- tests/docker/docker

[PATCH 11/26] deprecation: don't enable TCG plugins by default on 32 bit hosts

The existing plugins already liberally use host pointer stuffing for passing user data which will fail when doing 64 bit guests on 32 bit hosts. We should discourage this by officially deprecating support and adding another nail to the 32 bit host coffin. Signed-off-by: Alex Bennée --- v2

[PATCH 00/26] Maintainer updates (testing, gdbstub, plugins)

by default on 32 bit hosts scripts/ci: update the gitlab-runner playbook docs/devel: fix duplicate line tests/docker: update debian i686 and mipsel images to bookworm tests/docker: remove debian-armel-cross Akihiko Odaki (1): contrib/plugins: Add a plugin to generate basic block vectors

[PATCH 04/26] scripts/ci: update the gitlab-runner playbook

The upstream install instructions: https://docs.gitlab.com/runner/install/linux-repository.html Now refer to repositories and a setup script. Modernise the playbook to use the preferred delivery method. Signed-off-by: Alex Bennée --- scripts/ci/setup/gitlab-runner.yml | 39

[PATCH 17/26] tests/tcg: allow to check output of plugins

off-by: Alex Bennée --- tests/tcg/Makefile.target | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index c5b1c7a786..2da70b2fcf 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -90,6 +90,7 @@ CFLAGS= L

[PATCH 08/26] tests/tcg/aarch64: Improve linker script organization

From: Gustavo Romero Improve kernel.ld linker script organization by using MEMORY command. Signed-off-by: Richard Henderson Signed-off-by: Gustavo Romero Message-Id: <20240906143316.657436-5-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/aarch64/system/kernel.l

[PATCH 16/26] tests/tcg: add mechanism to run specific tests with plugins

ed-off-by: Alex Bennée --- tests/tcg/Makefile.target | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target index 452a2cde65..c5b1c7a786 100644 --- a/tests/tcg/Makefile.target +++ b/tests/tcg/Makefile.target @@ -152,10 +

[PATCH 26/26] plugins: add ability to register a GDB triggered callback

I've extended the memory plugin to report on the packet. Signed-off-by: Alex Bennée --- include/qemu/plugin-event.h | 1 + include/qemu/qemu-plugin.h | 16 plugins/plugin.h | 9 + plugins/api.c| 18 ++ plugins/c

[PATCH 05/26] gdbstub: Use specific MMU index when probing MTE addresses

(which can be as small as 1 byte), rather than the number of bits used in the address space pointed to by ptr. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240906143316.657436-2-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée --- target/arm/gdbstub64.

[PATCH 07/26] tests/guest-debug: Support passing arguments to the GDB test script

mooth and informative exit if, for instance, the caller of the runner script passes an invalid argument or misses a required argument by the test script. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Message-Id: <20240906143316.657436-4-gustavo.rom...@linaro.org> Signed-off-by: Alex Be

[PATCH 15/26] plugins: extend API to get latest memory value accessed

://gitlab.com/qemu-project/qemu/-/issues/2152 Reviewed-by: Richard Henderson Reviewed-by: Xingtao Yao Reviewed-by: Alex Bennée Signed-off-by: Pierrick Bouvier Message-Id: <20240724194708.1843704-3-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/qemu-plugin.h

[PATCH 03/26] docs/devel: fix duplicate line

I guess the same change came in via two patch series. Remove the repetition. Fixes: 2a851fca9f (docs/devel: remind developers to run CI container pipeline when updating images) Signed-off-by: Alex Bennée --- docs/devel/testing/main.rst | 6 -- 1 file changed, 6 deletions(-) diff --git a

[PATCH 18/26] tests/plugin/mem: add option to print memory accesses

: Pierrick Bouvier Message-Id: <20240724194708.1843704-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/tcg/plugins/mem.c | 69 - 1 file changed, 68 insertions(+), 1 deletion(-) diff --git a/tests/tcg/plugins/mem.c b/tests/tcg/plu

[PATCH 13/26] contrib/plugins: control flow plugin

ro Cc: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240311153432.1395190-1-alex.ben...@linaro.org> --- v2 - only need a single call back - drop need for INSN_WIDTH - still don't understand the early exits v3 - move initial STORE ops to first instruction to avoid

[PATCH 01/26] tests/docker: remove debian-armel-cross

-container which is currently built from the more recent debian-12. Signed-off-by: Alex Bennée --- .gitlab-ci.d/container-cross.yml | 6 - .gitlab-ci.d/crossbuilds.yml | 7 - .../dockerfiles/debian-armel-cross.docker | 179 -- tests/lcitool

[PATCH 12/26] deprecation: don't enable TCG plugins by default with TCI

The softmmu memory instrumentation test sees so many more accesses than a normal translated host and its really not worth fixing up. Lets deprecate this odd configuration and save on the CI cycles. Signed-off-by: Alex Bennée --- docs/about/deprecated.rst | 8 configure

Re: [PATCH v4 0/5] gdbstub: Add support for MTE in system mode

m/qemu-project/qemu/-/issues/620 Queued to gdbstub/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v7 0/6] plugins: access values during a memory read/write

Pierrick Bouvier writes: > On 9/9/24 03:00, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> On 9/5/24 08:21, Alex Bennée wrote: >>>> Pierrick Bouvier writes: >>>> >>>>> This series allows plugins to know which value is re

<    1   2   3   4   5   6   7   8   9   10   >