Re: [PATCH 2/4] gdbstub: Add support for MTE in user mode

ch64-core.xml gdb-xml/aarch64-fpu.xml > gdb-xml/aarch64-pauth.xml gdb-xml/aarch64-mte.xml Ahh there it is, this got missed from the commit -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 1/4] gdbstub: Add support for target-specific stubs

quot;) > + * '0' -> Stop at "\0" > + * '.' -> Skip 1 char unless reached "\0" > + * Any other value is treated as the delimiter value itself > + */ > +typedef struct GdbCmdParseEntry { > +GdbCmdHandler handler; > +const char *cmd; > +bool cmd_startswith; > +const char *schema; > +bool allow_stop_reply; > +} GdbCmdParseEntry; > + > +#define get_cmd_parsers(p) (&g_array_index(p, GdbCmdParseEntry, 0)) > + > +/** > + * set_gdb_gen_query_table_arch() - set a table to handle arch-specific query > + * packets > + */ > +void set_gdb_gen_query_table_arch(GdbCmdParseEntry *table, int size); > + > +/** > + * set_gdb_gen_set_table_arch() - set a table to handle arch-specific set > + * packets > + */ > +void set_gdb_gen_set_table_arch(GdbCmdParseEntry *, int size); > + > +/** > + * set_query_supported_arch() - set arch-specific features in qSupported > + * features > + */ > +void set_query_supported_arch(char *); > + > +/** > + * gdb_put_packet() - put string into gdb server's buffer so it is sent > + * to the client > + */ > +int gdb_put_packet(const char *buf); > + > +#endif /* GDBSTUB_H */ -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/4] Add MTE stubs for aarch64 user mode

Gustavo Romero writes: > This patchset adds the stubs necessary to support GDB memory tagging > commands on QEMU aarch64 user mode. On application I'm getting the following failure on configure which makes me think something is missing: Program scripts/undefsym.py found: YES

Re: [PATCH 0/4] testing/next: purging remaining centos 8 bits

Philippe Mathieu-Daudé writes: > Hi Alex, > > On 21/5/24 14:53, Alex Bennée wrote: >> There are a few more bits referencing centos8 in the tree which needed >> cleaning up. After this we can remove the dedicated runner from the >> gitlab registration. If we want to kee

Re: Test scripts

e host copy of the script - there should be path to the directory > containing a copy of the script in VM. Execute the host script with > net arguments: > ./vsock_guest_exec_test.py srv Maybe these would best live in contrib/vsock with a README? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

Fabiano Rosas writes: > Alex Bennée writes: > >> Juan Quintela writes: >> >>> From: Fabiano Rosas >>> >>> Add a smoke test that migrates to a file and gives it to the >>> script. It should catch the most annoying errors such as changes in

Re: [PATCH v12 03/13] virtio-gpu: Use pkgconfig version to decide which virgl features are available

rsion().version_compare('>=1.0.0') > + config_host_data.set('HAVE_VIRGL_D3D_INFO_EXT', 1) > endif If all the host side needs is 1.0.0 then: Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v12 02/13] virtio-gpu: Handle virtio_gpu_virgl_init() failure

NITED; } case RS_RESET: { virtio_gpu_virgl_reset(g); gl->render_state = RS_INITED; break; } case RS_INIT_FAILED: /* nothing to do, return early and maybe log */ return; case RS_INITED: /* just continue */ break; } > }; > > struct VhostUserGPU { -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v12 01/13] virtio-gpu: Unrealize GL device

gt; @@ -336,6 +336,7 @@ void virtio_gpu_virgl_fence_poll(VirtIOGPU *g); > void virtio_gpu_virgl_reset_scanout(VirtIOGPU *g); > void virtio_gpu_virgl_reset(VirtIOGPU *g); > int virtio_gpu_virgl_init(VirtIOGPU *g); > +void virtio_gpu_virgl_deinit(VirtIOGPU *g); > int virtio_gpu_virgl_get_num_capsets(VirtIOGPU *g); > > #endif -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v12 00/13] Support blob memory and venus on qemu

Dmitry Osipenko writes: > On 5/21/24 17:57, Alex Bennée wrote: >> Alex Bennée writes: >> >>> Dmitry Osipenko writes: >>> >>>> Hello, >>>> >>>> This series enables Vulkan Venus context support on virtio-gpu. >>>>

Re: [PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

Salil Mehta writes: > Hi Alex, > >> From: Alex Bennée >> Sent: Tuesday, May 21, 2024 1:45 PM >> To: Salil Mehta >> >> Salil Mehta writes: >> >> > Add common function to help unregister the GDB register space. This >

Re: [PATCH v12 00/13] Support blob memory and venus on qemu

Alex Bennée writes: > Dmitry Osipenko writes: > >> Hello, >> >> This series enables Vulkan Venus context support on virtio-gpu. >> >> All virglrender and almost all Linux kernel prerequisite changes >> needed by Venus are already in upstream. For kern

Re: [PATCH v12 00/13] Support blob memory and venus on qemu

t. Just use virtio-gpu-device instead if you don't want enable virgl and opengl. This simplifies the logic and reduces the test matrix. but that's not a good solution because that needs virtio-mmio and there are reasons to have a PCI device (for one thing no ambiguity about discovery). -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 4/4] tests/vm: remove plain centos image

This isn't really used and we have lighter weight docker containers for testing this stuff directly. Signed-off-by: Alex Bennée --- tests/vm/Makefile.include | 1 - tests/vm/centos | 51 --- 2 files changed, 52 deletions(-) delete mode 1

[PATCH 2/4] docs/devel: update references to centos to later version

>From the website: "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." We have updated a few bits but there are still references that need fixing. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 8 1 file changed, 4 ins

[PATCH 0/4] testing/next: purging remaining centos 8 bits

build-environment setup that handles all distros and integrates with lcitool). Alex. Alex Bennée (4): ci: remove centos-steam-8 customer runner docs/devel: update references to centos to later version tests/vm: update centos.aarch64 image to 9 tests/vm: remove plain centos image docs

[PATCH 3/4] tests/vm: update centos.aarch64 image to 9

As Centos Stream 8 goes out of support we need to update. To do this powertools is replaced by crb and we don't over specify the python3 we want. Signed-off-by: Alex Bennée --- tests/vm/centos.aarch64 | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tes

[PATCH 1/4] ci: remove centos-steam-8 customer runner

This broke since eef0bae3a7 (migration: Remove block migration) but even after that was addressed it still fails to complete. As it will shortly be EOL lets to remove the runner definition and the related ansible setup bits. We still have centos9 docker images build and test. Signed-off-by: Alex

Re: [PATCH V10 7/8] gdbstub: Add helper function to unregister GDB register space

t; registers > + * @cpu - the CPU associated with registers > + */ > +void gdb_unregister_coprocessor_all(CPUState *cpu); > + > /** > * gdbserver_start: start the gdb server > * @port_or_device: connection spec for gdb -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

addest); > +#ifndef _WIN32 > +qtest_add_func("/migration/analyze-script", test_analyze_script); > +#endif > qtest_add_func("/migration/precopy/unix/plain", test_precopy_unix_plain); > qtest_add_func("/migration/precopy/unix/xbzrle", > test_precopy_unix_xbzrle); > /* > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build > index 66795cfcd2..d6022ebd64 100644 > --- a/tests/qtest/meson.build > +++ b/tests/qtest/meson.build > @@ -357,6 +357,8 @@ foreach dir : target_dirs > test_deps += [qsd] >endif > > + qtest_env.set('PYTHON', python.full_path()) > + >foreach test : target_qtests > # Executables are shared across targets, declare them only the first > time we > # encounter them -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 2/3] docs: define policy limiting the inclusion of generated files

; +manipulation is performed on code, however, this should be declared in the > +commit message. Lets avoid IRC speak in documents (s/IOW/In other words/), otherwise: Reviewed-by: Alex Bennée > + > +At times contributors may use or create scripts/tools to generate an initial > +boil

Re: [PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

trivial > + suggestions for how to change a patch, it is good practice to credit them > + by including a ``Suggested-by`` tag. Should we mention our use of Message-Id in so far the informal good practice is that we keep the Message-Id's of the last time a patch was posted and potent

Re: [PATCH 1/1] riscv, gdbstub.c: fix reg_width in ricsv_gen_dynamic_vector_feature()

921c05a > ("target/riscv/gdbstub.c: use 'vlenb' instead of shifting 'vlen'") set > beforehand. > > Cc: Akihiko Odaki > Cc: Alex Bennée > Reported-by: Robin Dapp > Fixes: 33a24910ae ("target/riscv: Use GDBFeature for dynamic XML") &

[PULL v2 00/11] testing and plugin updates

r microbit test - don't spam the linux source tree when importing headers - add STORE_U64 inline op to TCG plugins - add conditional callback op to TCG plugins ---- Alex Bennée (2): tests/tcg: don't append QEMU_O

Re: [RFC PATCH v3 04/18] hw/arm/smmu: Use enum for SMMU stage

ng tricks with bit masks, where BIT(0) is stage-1 and BIT(1) is >stage-2 and both is nested. > - Tracing, as stage is printed as int. > > Signed-off-by: Mostafa Saleh > Reviewed-by: Eric Auger Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL 03/11] plugins: prepare introduction of new inline ops

From: Pierrick Bouvier Until now, only add_u64 was available, and all functions assumed this or were named uniquely. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-Id

[PULL 09/11] plugins: distinct types for callbacks

hael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-10-alex.ben...@linaro.org> diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index c7b3b1cd66..98d27dded9 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -74,34 +74,40 @@ enum plugin

[PULL 07/11] plugins: conditional callbacks

immediate (op2). Callback is called if op1 |cond| op2 is true. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-6-pierrick.bouv...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-8

[PULL 10/11] plugins: extract cpu_index generate

sirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-11-alex.ben...@linaro.org> diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index e018728573..c9b298667f 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -101,12 +101,17 @@ static void gen_disabl

[PULL 01/11] tests/tcg: don't append QEMU_OPTS for armv6m-undef test

We don't want to build on the default machine setup here but define a custom one for the microbit. Reviewed-by: Pierrick Bouvier Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-2-alex.ben...@linaro.org> diff --git a/tests/tcg/arm/Makef

[PULL 00/11] testing and plugin updates

ns for microbit test - don't spam the linux source tree when importing headers - add STORE_U64 inline op to TCG plugins - add conditional callback op to TCG plugins ---- Alex Bennée (2): tests/tcg: don't append QEMU_O

[PULL 02/11] scripts/update-linux-header.sh: be more src tree friendly

$blddir/ $hdrdir/ Reviewed-by: Pierrick Bouvier Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-3-alex.ben...@linaro.org> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 36f3e91fe4..8963c39189 100755 ---

[PULL 06/11] tests/plugin/inline: add test for STORE_U64 inline op

From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-5-pierrick.bouv...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-7-alex.ben...@linaro.org> diff -

[PULL 04/11] plugins: extract generate ptr for qemu_plugin_u64

viewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-5-alex.ben...@linaro.org> diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 4069d51daf..97868781fe 100644 --- a/accel/tcg/plugin-gen.c +++ b/acce

[PULL 05/11] plugins: add new inline op STORE_U64

hael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-6-alex.ben...@linaro.org> diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index 93da98b76c..6c21a30105 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -70,6 +70,7 @@ enum plugin

[PULL 08/11] tests/plugin/inline: add test for conditional callback

org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex Bennée Message-Id: <20240514174253.694591-9-alex.ben...@linaro.org> diff --git a/tests/plugin/inline.c b/tests/plugin/inline.c index 103c3a22f6..cd63827b7d 100644 --- a/tests/plugin/inline.c +++ b/tests/plugin/inline.c @@

[PULL 11/11] plugins: remove op from qemu_plugin_inline_cb

From: Pierrick Bouvier This field is not needed as the callback type already holds this information. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-10-pierrick.bouv...@linaro.org> Reviewed-by: Michael S. Tsirkin Signed-off-by: Alex

[PATCH 01/11] tests/tcg: don't append QEMU_OPTS for armv6m-undef test

We don't want to build on the default machine setup here but define a custom one for the microbit. Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/arm/Makefile.softmmu-target b/tests/tc

[PATCH 09/11] plugins: distinct types for callbacks

From: Pierrick Bouvier To prevent errors when writing new types of callbacks or inline operations, we split callbacks data to distinct types. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-8-pierrick.bouv...@linaro.org> Signed-off-by

[PATCH 11/11] plugins: remove op from qemu_plugin_inline_cb

From: Pierrick Bouvier This field is not needed as the callback type already holds this information. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-10-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/plugin.

[PATCH 02/11] scripts/update-linux-header.sh: be more src tree friendly

$blddir/ $hdrdir/ Signed-off-by: Alex Bennée Message-Id: <20240510111802.241284-1-alex.ben...@linaro.org> --- scripts/update-linux-headers.sh | 80 + 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/scripts/update-linux-headers.sh b/scri

[PATCH 05/11] plugins: add new inline op STORE_U64

From: Pierrick Bouvier This new operation can store an immediate u64 value to a given scoreboard. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-4-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/plugin.h

[PATCH 00/11] maintainer updates (plugins, testing) pre-PR

This is mostly plugin related stuff which is all ready to go however I have a few miscellaneous testing updates which would appreciate the review. Thanks. Alex Bennée (2): tests/tcg: don't append QEMU_OPTS for armv6m-undef test scripts/update-linux-header.sh: be more src tree fri

[PATCH 04/11] plugins: extract generate ptr for qemu_plugin_u64

Signed-off-by: Alex Bennée --- accel/tcg/plugin-gen.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 4069d51daf..97868781fe 100644 --- a/accel/tcg/plugin-gen.c +++ b/accel/tcg/plugin-gen.c @@ -

[PATCH 08/11] tests/plugin/inline: add test for conditional callback

org> Signed-off-by: Alex Bennée --- tests/plugin/inline.c | 89 +-- 1 file changed, 86 insertions(+), 3 deletions(-) diff --git a/tests/plugin/inline.c b/tests/plugin/inline.c index 103c3a22f6..cd63827b7d 100644 --- a/tests/plugin/inline.c +++ b/tests/

[PATCH 03/11] plugins: prepare introduction of new inline ops

From: Pierrick Bouvier Until now, only add_u64 was available, and all functions assumed this or were named uniquely. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-2-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- includ

[PATCH 06/11] tests/plugin/inline: add test for STORE_U64 inline op

From: Pierrick Bouvier Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-5-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- tests/plugin/inline.c | 41 + 1 file changed, 37 insertions

[PATCH 07/11] plugins: conditional callbacks

immediate (op2). Callback is called if op1 |cond| op2 is true. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-6-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- include/qemu/plugin.h| 8 include/qemu/qemu-plugin.h

[PATCH 10/11] plugins: extract cpu_index generate

From: Pierrick Bouvier Factorizes function to access current cpu index for a given vcpu. Reviewed-by: Richard Henderson Signed-off-by: Pierrick Bouvier Message-Id: <20240502211522.346467-9-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée --- accel/tcg/plugin-gen.

Re: [Semihosting Tests PATCH 3/3] add SYS_GET_CMDLINE test

Alex Bennée writes: > We actually had the stubs to implement this. The main pain is getting > the binary name into the program so we can validate the result. > > Signed-off-by: Alex Bennée > --- > Makefile | 22 +++--- > usertest.c | 24 ++

Re: [PATCH 1/1] tests/fp/meson: don't build fp-bench test if fenv.h is missing

with host compiler) I think this patch probably should just live on in the downstream. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[Semihosting Tests PATCH 3/3] add SYS_GET_CMDLINE test

We actually had the stubs to implement this. The main pain is getting the binary name into the program so we can validate the result. Signed-off-by: Alex Bennée --- Makefile | 22 +++--- usertest.c | 24 2 files changed, 35 insertions(+), 11 deletions

[Semihosting Tests PATCH 1/3] .editorconfig: add code conventions for tooling

It's a pain when you come back to a code base you haven't touched in a while and realise whatever indent settings you were using having carried over. Add an editorconfig and be done with it. Signed-off-by: Alex Bennée --- .editorconfig | 28 1 file c

[Semihosting Tests PATCH 0/3] add SYS_GET_CMDLINE test

Hi Peter, Looking at bug #2322 I wanted to make sure SYS_GET_CMDLINE works as I expected. While at it I needed to fix a compile error with headers which I guess we got away with on earlier compilers. I've added an editorconfig for good measure. Alex Bennée (3): .editorconfig: add

[Semihosting Tests PATCH 2/3] update includes for bare metal compiling

We shouldn't use for our own implementation. Also the base types we need live in as doesn't exist for the bare metal compilers. Signed-off-by: Alex Bennée --- semihosting.c | 4 ++-- semihosting.h | 2 +- string.c | 2 +- usertest.c| 2 +- 4 files changed, 5 insert

[RFC PATCH] scripts/update-linux-header.sh: be more src tree friendly

$blddir/ $hdrdir/ Signed-off-by: Alex Bennée --- scripts/update-linux-headers.sh | 80 + 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 36f3e91fe4..8963c39189 100755 --- a/scri

Re: [PATCH v8 01/11] linux-headers: Update to Linux v6.9-rc3

quot; \ > "$output/include/standard-headers/asm-$arch" > @@ -165,7 +168,7 @@ rm -rf "$output/linux-headers/linux" > mkdir -p "$output/linux-headers/linux" > for header in const.h stddef.h kvm.h vfio.h vfio_ccw.h vfio_zdev.h vhost.h \ >psci.h psp-sev.h userfaultfd.h memfd.h mman.h nvme_ioctl.h \ > - vduse.h iommufd.h; do > + vduse.h iommufd.h bits.h; do What do we need bits for here? > cp "$tmpdir/include/linux/$header" "$output/linux-headers/linux" > done -- Alex Bennée Virtualisation Tech Lead @ Linaro

Canceled event with note: QEMU/KVM developers conference call @ Tue 14 May 2024 14:00 - 15:00 (BST) (qemu-devel@nongnu.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYDA

[RFC PATCH] tests/tcg: don't append QEMU_OPTS for armv6m-undef test

We don't want to build on the default machine setup here but define a custom one for the microbit. Signed-off-by: Alex Bennée --- tests/tcg/arm/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/arm/Makefile.softmmu-target b/tests/tc

Re: [PATCH v6 0/9] TCG plugins new inline operations

It's possible to mix various inline operations (add, store) with conditional > callbacks, allowing efficient "trap" based counters. > > It builds on top of new scoreboard API, introduced in the previous > series. Queued to plugins/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] sh4: select correct components for no-board build

Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: qemu-img cache modes with Linux cgroup v1

Hey, just FYI about tmpfs, during some development on Fedora 39 I noticed O_DIRECT is now supported on tmpfs (as opposed to our CI which runs Centos 9 Stream). `qemu-img convert -t none -O raw tests/images/cirros-qcow2.img /tmp/cirros.raw` where /tmp is indeed a tmpfs. I might be missing something

Re: [PATCH v2] Re-enable riscv64-debian-cross-container (debian riscv64 is finally usable again!)

r-cross.yml >> @@ -77,7 +77,6 @@ riscv64-debian-cross-container: >>allow_failure: true >>variables: >> NAME: debian-riscv64-cross >> -QEMU_JOB_OPTIONAL: 1 >> >> s390x-debian-cross-container: >>extends: .container_job_template >> -- >> 2.39.2 >> >> > > With regards, > Daniel -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v4] fix endianness bug

within the 60 or so chars recommended for subject lines ;-) -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 1/2] accel/tcg: Make TCGCPUOps::cpu_exec_halt return bool for whether to halt

*x86_cpu = X86_CPU(cpu); > @@ -138,6 +138,7 @@ void x86_cpu_exec_halt(CPUState *cpu) > cpu_reset_interrupt(cpu, CPU_INTERRUPT_POLL); > bql_unlock(); > } > +return cpu_has_work(cpu); The x86 version is essentially being called for side effects. Do we want to document this usage in the method? > } > > bool x86_need_replay_interrupt(int interrupt_request) -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 1/1] tests/fp/meson: don't build fp-bench test if fenv.h is missing

n > find at the following link. > > Link: https://lists.nongnu.org/archive/html/qemu-devel/2021-03/msg00492.html > Suggested-by: Paolo Bonzini > Signed-off-by: Dario Binacchi Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 3/3] gitlab: remove stale s390x-all-linux-static conf hacks

The libssh bug references 18.04 which we are no longer running. We don't need to disable glusterfs because a linux-user build shouldn't be trying to link to it anyway. Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners/ubuntu-22.04-s390x.yml | 4 +--- 1 file changed, 1 inser

[PATCH 0/3] testing/next: s390x gitlab updates

o the respective maintainers to investigate please as I have a publishing deadline coming up. Thanks, Alex. Alex Bennée (3): build-environment: make some packages optional gitlab: migrate the s390x custom machine to 22.04 gitlab: remove stale s390x-all-linux-static conf hacks .gitlab-ci.d/c

[PATCH 2/3] gitlab: migrate the s390x custom machine to 22.04

20.04 is dead (from QEMU's point of view), long live 22.04! Signed-off-by: Alex Bennée --- .gitlab-ci.d/custom-runners.yml | 2 +- ...20.04-s390x.yml => ubuntu-22.04-s390x.yml} | 28 +-- 2 files changed, 15 insertions(+), 15 deletions(-) rename .git

[PATCH 1/3] build-environment: make some packages optional

Upgrading the s390x runner exposed some packages are not available for it. Add an additional optional stage we only enable for arm64/x86_64 for now. Signed-off-by: Alex Bennée --- scripts/ci/setup/build-environment.yml | 16 +--- 1 file changed, 13 insertions(+), 3 deletions

Re: [PATCH v8 00/11] Support blob memory and venus on qemu

rces? We shouldn't expect the IPA to change between allocations should we? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 0/7] plugins: Use unwind info for special gdb registers

+- > target/i386/gdbstub.c | 1 + > target/i386/helper.c | 6 ++- > target/i386/tcg/cc_helper.c | 10 + > target/i386/tcg/tcg-cpu.c | 72 +++ > tcg/tcg-op.c | 5 +++ > tcg/tcg.c

Re: [PATCH 02/12] hw/vfio/pci: Replace sprintf() by g_strdup_printf()

hange, but the rationale seems irrelevant. Thanks, Alex > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/vfio/pci.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 64780d1b79..cc3cc89122 100644

Re: Backdoor in xz, should we switch compression format for tarballs?

Also does qemu link to libarchive? The original analysis wasn't a full reverse engineer of the payload so we don't know if it only affects sshd. On Sat, 30 Mar 2024, 07:01 Daniel P. Berrangé, wrote: > On Fri, Mar 29, 2024 at 06:59:30PM +0100, Paolo Bonzini wrote: > > For more info, see > > > htt

Re: Backdoor in xz, should we switch compression format for tarballs?

Um maybe? >From what I've read so far it doesn't seem the format is compromised but it certainly seems like a concerted attempt to subvert an upstream. However a knee-jerk jump to another format might be premature without carefully considering if other upstreams have been targeted. I guess zstd i

Re: [PATCH v3] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

On Wed, 27 Mar 2024 16:11:37 -0400 "Michael S. Tsirkin" wrote: > On Wed, Mar 27, 2024 at 11:39:15AM -0600, Alex Williamson wrote: > > On Fri, 22 Mar 2024 12:12:10 +0530 > > Vinayak Kale wrote: > > > > > In case of migration, during restore operation

Re: [PATCH v3] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

or Specific Info in VSC, check > is > still enforced for 3 byte VSC header. > - Updated commit description with live migration failure scenario. > v1->v2: > - Limited scope of change to vfio-pci devices instead of all pci devices. > > hw/vfio/pci.c | 24 +

[PULL 0/5] more maintainer updates (git, avocado)

on gitlab checkouts - update sbsa-ref tests ---- Alex Bennée (1): gitlab: aggressively avoid extra GIT data Marcin Juszkiewicz (4): tests/avocado: update sbsa-ref firmware tests/avocado: drop virtio-rng from sbsa-ref tests

[PULL 3/5] tests/avocado: drop virtio-rng from sbsa-ref tests

From: Marcin Juszkiewicz sbsa-ref is supposed to emulate real hardware so virtio-rng-pci does not fit here Signed-off-by: Marcin Juszkiewicz Message-Id: <20240318-sbsa-ref-firmware-update-v3-2-1c33b995a...@linaro.org> Signed-off-by: Alex Bennée diff --git a/tests/a

[PULL 1/5] gitlab: aggressively avoid extra GIT data

: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-Id: <20240312170011.1688444-1-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml index 2dd8a9b57c..bf3d8efab6 100644 --- a/.gitlab-ci.d/base.yml +++ b/.gitlab-ci.d/base.yml @@ -24,6 +24,10 @@ var

[PULL 5/5] tests/avocado: sbsa-ref: add OpenBSD tests for misc 'max' setup

..@linaro.org> Signed-off-by: Alex Bennée diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index cf8954d02e..98c76c1ff7 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -203,18 +203,36 @@ de

[PULL 4/5] tests/avocado: sbsa-ref: add Alpine tests for misc 'max' setup

..@linaro.org> Signed-off-by: Alex Bennée diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py index 259225f15f..cf8954d02e 100644 --- a/tests/avocado/machine_aarch64_sbsaref.py +++ b/tests/avocado/machine_aarch64_sbsaref.py @@ -140,1

[PULL 2/5] tests/avocado: update sbsa-ref firmware

it 085c2fb Signed-off-by: Marcin Juszkiewicz Tested-by: Philippe Mathieu-Daudé Message-Id: <20240318-sbsa-ref-firmware-update-v3-1-1c33b995a...@linaro.org> Signed-off-by: Alex Bennée diff --git a/tests/avocado/machine_aarch64_sbsaref.py b/tests/avocado/machine_aarch64_sbsaref.py

Re: [PATCH v5 15/24] tests/avocado: reverse_debugging.py add test for x86-64 q35 machine

Nicholas Piggin writes: > The x86-64 pc machine has a problem with record/replay. q35 seems > to work well. Add a new q35 test and update the flaky message for > pc. > > Signed-off-by: Nicholas Piggin Reviewed-by: Alex Bennée Tested-by: Alex Bennée -- Alex Bennée Virtualis

Re: [PATCH v5 12/24] savevm: Fix load_snapshot error path crash

Nicholas Piggin writes: > An error path missed setting *errp, which can cause a NULL deref. > > Signed-off-by: Nicholas Piggin Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v5 10/24] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state

Nicholas Piggin writes: > The regular qemu_bh_schedule() calls result in non-deterministic > execution of the bh in record-replay mode, which causes replay failure. > > Signed-off-by: Nicholas Piggin Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v5 08/24] replay: Fix migration use of clock

qemu_savevm_wait_unplug(s, MIGRATION_STATUS_SETUP, > MIGRATION_STATUS_ACTIVE); > > -s->setup_time = qemu_clock_get_ms(QEMU_CLOCK_HOST) - setup_start; > +s->setup_time = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) - setup_start; > > trace_migration_thread_setup_complete(); -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v5 07/24] chardev: set record/replay on the base device of a muxed device

nation of the log shows they are not recorded. > > Setting QEMU_CHAR_FEATURE_REPLAY on the base chardev fixes the problem. > > Signed-off-by: Nicholas Piggin Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v5 06/24] tests/avocado: replay_kernel.py add x86-64 q35 machine test

Nicholas Piggin writes: > The x86-64 pc machine is flaky with record/replay, but q35 is more > stable. Add a q35 test to replay_kernel.py. > > Signed-off-by: Nicholas Piggin Reviewed-by: Alex Bennée Tested-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v5 05/24] Revert "replay: stop us hanging in rr_wait_io_event"

ut of synch with > the execution and consumption of events by replay. > > Signed-off-by: Nicholas Piggin Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v5 13/24] tests/avocado: replay_linux.py remove the timeout expected guards

;, 'runtime limited') > class ReplayLinuxAarch64(ReplayLinux): > """ > :avocado: tags=accel:tcg > @@ -187,6 +190,7 @@ def get_common_args(self): > '-device', 'virtio-rng-pci,rng=rng0', > '-object&

Re: [PATCH v3 0/4] tests/avocado: update sbsa-ref firmware to latest

27; device as > sbsa-ref is supposed to emulate physical hardware. > > Added 'max' tests with 'pauth=off' and 'pauth-impdef=on' variants. Queued to for-9.0/misc-fixes, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 01/22] tcg: Add TCGContext.emit_before_op

AD(, TCGLabel) labels; > +TCGOp *emit_before_op; Could we add some kdoc comments to the TCGContext describing what each variables is for. Is this just a list of ops to emit before the current instruction emulation? Is it cleared between instruction boundaries? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Invitation: QEMU/KVM developers conference call @ Tue 2 Apr 2024 14:00 - 15:00 (BST) (qemu-devel@nongnu.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYD

Invitation: QEMU/KVM developers conference call @ Tue 16 Apr 2024 14:00 - 15:00 (BST) (qemu-devel@nongnu.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYD

Invitation: QEMU/KVM developers conference call @ Every 2 weeks from 13:00 to 14:00 on Tuesday (GMT) (qemu-devel@nongnu.org)

BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02 RRULE:FREQ=YEARLY;BYMONTH=3;BYD

KVM/QEMU Community Call 5th March Agenda Items

meid=MWd2dWI5NDM1bzdocnJlbTBhMHJhbG5sNWlfMjAyNDAyMjBUMTQwMDAwWiBjX2s1cDJscGd2YnB0ZGlya3U1c2kwMWJsbW5rQGc&tmsrc=c_k5p2lpgvbptdirku5si01blmnk%40group.calendar.google.com&scp=ALL If you want to be added to the invite list let me know and you can get spammed by your calendar app as well ;-) -- Alex Bennée Virtual

Re: [PATCH 21/22] plugins: Inline plugin_gen_empty_callback

Richard Henderson writes: > Each caller can use tcg_gen_plugin_cb directly. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 20/22] plugins: Move qemu_plugin_insn_cleanup_fn to tcg.c

->data, true); > +} > +#endif > + You could expand the ifdef to the next function and make an alternate empty alloc_tcg_plugin_context. Alternatively maybe we should consider dropping the CONFIG_PLUGIN gymnastics and make it a first class TCG feature? Is the null case still visibl

Re: [PATCH 12/22] plugins: Remove plugin helpers

Richard Henderson writes: > These placeholder helpers are no longer required. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

<    5   6   7   8   9   10   11   12   13   14   >