Re: [RFC PATCH v3] contrib/plugins: control flow plugin

2024-07-19 Thread Alex Bennée
Pierrick Bouvier writes: > On 7/18/24 07:59, Alex Bennée wrote: >> This is a simple control flow tracking plugin that uses the latest >> inline and conditional operations to detect and track control flow >> changes. It is currently an exercise at seeing how useful the cha

Re: [PATCH] tests/tcg/aarch64: Fix test-mte.py

2024-07-19 Thread Alex Bennée
a-f]+\)." > > Double up the \ to pass one through to the pattern. > > Signed-off-by: Richard Henderson Queued to maintainer/for-9.1-rc0, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[RFC PATCH v3] contrib/plugins: control flow plugin

2024-07-18 Thread Alex Bennée
ro Cc: Pierrick Bouvier Signed-off-by: Alex Bennée Message-Id: <20240311153432.1395190-1-alex.ben...@linaro.org> --- v2 - only need a single call back - drop need for INSN_WIDTH - still don't understand the early exits v3 - move initial STORE ops to first instruction to avo

[PATCH 13/15] target/riscv: Restrict semihosting to TCG

2024-07-18 Thread Alex Bennée
: <20240717105723.58965-7-phi...@linaro.org> Signed-off-by: Alex Bennée --- target/riscv/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/Kconfig b/target/riscv/Kconfig index 5f30df22f2..c332616d36 100644 --- a/target/riscv/Kconfig +++ b/target/riscv/K

[PATCH 12/15] target/mips: Restrict semihosting to TCG

2024-07-18 Thread Alex Bennée
: <20240717105723.58965-6-phi...@linaro.org> Signed-off-by: Alex Bennée --- target/mips/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/Kconfig b/target/mips/Kconfig index eb19c94c7d..876048b150 100644 --- a/target/mips/Kconfig +++ b/target/mips/Kconfig @@ -1,

[PATCH 08/15] semihosting: Include missing 'gdbstub/syscalls.h' header

2024-07-18 Thread Alex Bennée
complete_cb complete, ^ Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240717105723.58965-2-phi...@linaro.org> Signed-off-by: Alex Bennée --- include/semihosting/syscalls.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/semiho

[PATCH 15/15] semihosting: Restrict to TCG

2024-07-18 Thread Alex Bennée
From: Philippe Mathieu-Daudé Semihosting currently uses the TCG probe_access API. It is pointless to have it in the binary when TCG isn't. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20240717105723.58965-9-phi...@linaro.org> Signed-off-by: Alex

[PATCH 06/15] tests/plugins: use qemu_plugin_outs for inline stats

2024-07-18 Thread Alex Bennée
Using bare printf's in plugins is perfectly acceptable but they do rather mess up the output of "make check-tcg". Convert the printfs to use g_string and then output with the plugin output helper which will already be captured to .pout files by the test harness. Signed-off-by: A

[PATCH 11/15] target/m68k: Restrict semihosting to TCG

2024-07-18 Thread Alex Bennée
Reported-by: Anton Johansson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240717105723.58965-5-phi...@linaro.org> Signed-off-by: Alex Bennée --- target/m68k/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/m68k/Kconfig b/target/m68k/Kconfig

[PATCH 04/15] plugins/stoptrigger: TCG plugin to stop execution under conditions

2024-07-18 Thread Alex Bennée
Bouvier Message-Id: <20240715081521.19122-2-simon.hame...@grenoble-inp.org> Signed-off-by: Alex Bennée --- docs/devel/tcg-plugins.rst| 22 + contrib/plugins/stoptrigger.c | 151 ++ contrib/plugins/Makefile | 1 + 3 files changed, 174 inse

[PATCH 09/15] target/m68k: Add semihosting stub

2024-07-18 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since the SEMIHOSTING feature is optional, we need a stub to link when it is disabled. Suggested-by: Paolo Bonzini Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240717105723.58965-3-phi...@linaro.org> Signed-off-by: Alex Bennée --- target/m68k/semih

[PATCH 07/15] plugins/execlog.c: correct dump of registers values

2024-07-18 Thread Alex Bennée
From: Frédéric Pétrot Register values are dumped as 'sz' chunks of two nibbles in the execlog plugin, sz was 1 too big. Signed-off-by: Frédéric Pétrot Reviewed-by: Pierrick Bouvier Message-Id: <20240620083805.73603-1-frederic.pet...@univ-grenoble-alpes.fr> Signed-off-by: Alex

[PATCH 14/15] target/xtensa: Restrict semihosting to TCG

2024-07-18 Thread Alex Bennée
Reported-by: Anton Johansson Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240717105723.58965-8-phi...@linaro.org> Signed-off-by: Alex Bennée --- target/xtensa/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/xtensa/Kconfig b/target/xten

[PATCH 00/15] Final bits for 9.1-rc0 (docker, plugins, gdbstub, semihosting)

2024-07-18 Thread Alex Bennée
qemu_plugin_outs for inline stats testing: bump to latest libvirt-ci Alex Bennée (3): testing: bump to latest libvirt-ci gdbstub: Re-factor gdb command extensions tests/plugins: use qemu_plugin_outs for inline stats Frédéric Pétrot (1): plugins/execlog.c: correct dump of registers values

[PATCH 05/15] plugins: fix mem callback array size

2024-07-18 Thread Alex Bennée
From: Pierrick Bouvier data was correctly copied, but size of array was not set (g_array_sized_new only reserves memory, but does not set size). As a result, callbacks were not called for code path relying on plugin_register_vcpu_mem_cb(). Found when trying to trigger mem access callbacks for

[PATCH 10/15] target/mips: Add semihosting stub

2024-07-18 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since the SEMIHOSTING feature is optional, we need a stub to link when it is disabled. Signed-off-by: Philippe Mathieu-Daudé Message-Id: <20240717105723.58965-4-phi...@linaro.org> Signed-off-by: Alex Bennée --- target/mips/tcg/sysemu/semihosting-stub.

[PATCH 01/15] testing: bump to latest libvirt-ci

2024-07-18 Thread Alex Bennée
This brings in the latest python mappings for the BSD updates. Signed-off-by: Alex Bennée --- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- tests/lcitool/libvirt-ci| 2 +- tests/vm/generated/freebsd.json | 14 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff

[PATCH 03/15] gdbstub: Re-factor gdb command extensions

2024-07-18 Thread Alex Bennée
complications of transferring ownership of arrays and keeps the final command entries as static entries in the target code. Cc: Akihiko Odaki Cc: Gustavo Bueno Romero Cc: Peter Maydell Signed-off-by: Alex Bennée Reviewed-by: Gustavo Romero --- v2 - don't use strrstr, instead maintain a strv

[PATCH 02/15] tests/avocado: Remove non-working sparc leon3 test

2024-07-18 Thread Alex Bennée
Chigot Acked-by: Alex Bennée Message-Id: <20240710111755.60584-1-th...@redhat.com> [AJB: fix MAINTAINERS] Signed-off-by: Alex Bennée --- MAINTAINERS | 1 - tests/avocado/machine_sparc_leon3.py | 37 2 files changed, 38 deletions(-) delet

Re: [RFC PATCH] hw/core/cpu.h: try and document CPU_FOREACH[_SAFE]

2024-07-17 Thread Alex Bennée
Alex Bennée writes: > There is some confusion about when you should use one over the other. > Lets try and address that by adding some kdoc comments. > > Suggested-by: Paolo Bonzini > Signed-off-by: Alex Bennée ping? > --- > include/hw/core/cpu.h | 19

Re: [PATCH v4 0/8] semihosting: Restrict to TCG

2024-07-17 Thread Alex Bennée
nted for other accelerators, but > work need to be done. Meanwhile, do not enable it > unless TCG is available. Queued to semihosting/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] plugins/execlog.c: correct dump of registers values

2024-07-17 Thread Alex Bennée
Frédéric Pétrot writes: > Register values are dumped as 'sz' chunks of two nibbles in the execlog > plugin, sz was 1 too big. > > Signed-off-by: Frédéric Pétrot > Queued to plugins/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH] gdbstub: Re-factor gdb command extensions

2024-07-17 Thread Alex Bennée
Richard Henderson writes: > On 7/17/24 02:55, Alex Bennée wrote: >>> Are you expecting the same GdbCmdParseEntry object to be registered >>> multiple times? Can we fix that at a higher level? >> Its basically a hack to deal with the fact everything is tied to the

Re: [RFC PATCH] gdbstub: Re-factor gdb command extensions

2024-07-16 Thread Alex Bennée
Richard Henderson writes: > On 7/16/24 21:42, Alex Bennée wrote: >> void gdb_extend_qsupported_features(char *qsupported_features) >> { >> -/* >> - * We don't support different sets of CPU gdb features on different >> CPUs yet >> - * so

Re: [PATCH] cpu: Free queued CPU work

2024-07-16 Thread Alex Bennée
armcpu = ARM_CPU(cpuobj); pa_bits = arm_pamax(armcpu); object_unref(cpuobj); Anyway: Tested-by: Alex Bennée > --- > include/hw/core/cpu.h | 6 ++ > cpu-common.c | 11 +++ > hw/core/cpu-common.c | 1 + > 3 files changed, 18 insertions(+)

Re: [PATCH v6 1/7] plugins: fix mem callback array size

2024-07-16 Thread Alex Bennée
to trigger mem access callbacks for atomic > instructions. > > Reviewed-by: Xingtao Yao > Reviewed-by: Richard Henderson > Signed-off-by: Pierrick Bouvier I'm queuing this patch to plugins/next as it is a fix. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH] gdbstub: Re-factor gdb command extensions

2024-07-16 Thread Alex Bennée
Gustavo Romero writes: > Hi Alex, > > On 7/16/24 8:42 AM, Alex Bennée wrote: >> Coverity reported a memory leak (CID 1549757) in this code and its >> admittedly rather clumsy handling of extending the command table. >> Instead of handing over a full array of the comma

Re: [PATCH v4] plugins/stoptrigger: TCG plugin to stop execution under conditions

2024-07-16 Thread Alex Bennée
melin > Signed-off-by: Alexandre Iooss Queued to plugins/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

[RFC PATCH] gdbstub: Re-factor gdb command extensions

2024-07-16 Thread Alex Bennée
complications of transferring ownership of arrays and keeps the final command entries as static entries in the target code. Cc: Akihiko Odaki Cc: Gustavo Bueno Romero Cc: Peter Maydell Signed-off-by: Alex Bennée --- include/gdbstub/commands.h | 19 -- target/arm/internals.h | 4

Re: [PATCH] target/arm: Free GDB command data

2024-07-16 Thread Alex Bennée
GArray and its contents"). > > Also, there is a second leak here if you have more than one > CPU -- when the second CPU calls gdb_extend_query_table() etc, > the function will leak the first CPU's data. Having the function > API be clearly either "always takes ownership" or "never takes > ownership" would make it easier to fix this leak too. I'm working on cleaning this API up to make it easier to use. I'll send a patch once its tested. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 3/3] tests/tcg/aarch64: Add test cases for SME FMOPA (widening)

2024-07-15 Thread Alex Bennée
Richard Henderson writes: > From: Daniyal Khan > > Signed-off-by: Daniyal Khan > Message-Id: 172090222034.13953.1688870870882292209...@git.sr.ht > [rth: Split test cases to separate patch, tidy assembly.] > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée

Re: [PATCH 2/3] target/arm: Use FPST_F16 for SME FMOPA (widening)

2024-07-15 Thread Alex Bennée
n Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH 1/3] target/arm: Use float_status copy in sme_fmopa_s

2024-07-15 Thread Alex Bennée
nt FMOPA, FMOPS (non-widening)") > Signed-off-by: Daniyal Khan > [rth: Split from a larger patch] > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] meson: Use -fno-sanitize=function when available

2024-07-15 Thread Alex Bennée
a-cflags=-fno-sanitize=function > TARGETS: alpha-softmmu arm-softmmu m68k-softmmu mips64-softmmu > s390x-softmmu > MAKE_CHECK_ARGS: check-qtest check-tcg > > > --- > base-commit: f2cb4026fccfe073f84a4b440e41d3ed0c3134f6 > change-id: 20240714-function-7d32c723abbc > > Best regards, -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] accel/tcg: Make cpu_exec_interrupt hook mandatory

2024-07-12 Thread Alex Bennée
ore calling it. > > Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v6 7/7] tests/tcg/x86_64: add test for plugin memory access

2024-07-12 Thread Alex Bennée
Pierrick Bouvier writes: > On 7/8/24 12:15, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> Add an explicit test to check expected memory values are read/written. >>> For sizes 8, 16, 32, 64 and 128, we generate a load/store operation. >>&g

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-12 Thread Alex Bennée
gt; few more indirectly used, but worst case we just clone the bits we need > into the QEMU tree. Is Avocado still actively developed? I thought you guys used it quite widely within RedHat? > > With regards, > Daniel -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH] build deps: update lcitool to include rust bits

2024-07-12 Thread Alex Bennée
Manos Pitsidianakis writes: > Hi Daniel, Alex, > > I will pick this patch up with all the reviewed-by trailers for my > next Rust RFC series if that's alright with you, Absolutely - I made it for you ;-) -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-11 Thread Alex Bennée
e cachable? > > (1) Asset download should not count against test timeout. > (2) Running tests while disconnected should skip unavailable assets. > > Avocado kinda does this, but still generates errors instead of skips. > > > r~ -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] tests/avocado: Remove non-working sparc leon3 test

2024-07-11 Thread Alex Bennée
omas Huth Queued to testing/next, thanks. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] MAINTAINERS: add Edgar as Xen maintainer

2024-07-11 Thread Alex Bennée
bsystem in QEMU and we > are very happy to welcome him to the team. His knowledge and expertise > with QEMU internals will be of great help. > > Signed-off-by: Stefano Stabellini Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2] plugins/stoptrigger: TCG plugin to stop execution under conditions

2024-07-11 Thread Alex Bennée
here its execution flow went. > + > +Two types of triggers can be configured: a count of instructions to stop at, > +or an address to stop at. Multiple triggers can be set at once. > + > +By default, QEMU will exit with return code 0. A custom return code can be > +configured for each trigger using ``:CODE`` syntax. > + > +For example, to stop at the 20-th instruction with return code 41, at address > +0xd4 with return code 0 or at address 0xd8 with return code 42:: > + > + $ qemu-system-aarch64 $(QEMU_ARGS) \ > +-plugin > ./contrib/plugins/libstoptrigger.so,icount=20:41,addr=0xd4,addr=0xd8:42 -d > plugin > + > +The plugin will log the reason of exit, for example:: > + > + 0xd4 reached, exiting > + > Plugin API > == Otherwise it looks good to me. Unless you want to tackle additional exit modes? What is your current use case for this? -- Alex Bennée Virtualisation Tech Lead @ Linaro

[RFC PATCH] build deps: update lcitool to include rust bits

2024-07-10 Thread Alex Bennée
For rust development we need cargo, rustc and bindgen in our various development environments. Update the libvirt-ci project to (!495) and regenerate the containers and other dependency lists. Signed-off-by: Alex Bennée --- NB: - this is currently waiting on the upstream MR, but if you

Re: [PATCH] tests/avocado: Remove non-working sparc leon3 test

2024-07-10 Thread Alex Bennée
homas Huth Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH] plugins/stoptrigger: TCG plugin to stop execution under conditions

2024-07-10 Thread Alex Bennée
ecution flow went. > + > +Two types of triggers can be configured: a count of instructions to stop at, > +or an address to stop at. Multiple triggers can be set at once. > + > +By default, QEMU will exit with return code 0. A custom return code can be > +configured for each trigger using ``:CODE`` syntax. So I can see this being useful for general testing of "did the code get to this point". However would it be worth considering other cases like simply stopping the VM or triggering a gdbstub exception? > + > +For example, to stop at the 20-th instruction with return code 41, at address > +0xd4 with return code 0 or at address 0xd8 with return code 42:: > + > + $ qemu-system-aarch64 $(QEMU_ARGS) \ > +-plugin > ./contrib/plugins/libstoptrigger.so,icount=20:41,addr=0xd4,addr=0xd8:42 -d > plugin > + > +The plugin will log the reason of exit, for example:: > + > + 0xd4 reached, exiting > + > Plugin API > == -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH v4 2/7] rust: add bindgen step as a meson dependency

2024-07-10 Thread Alex Bennée
Generating bindings for Rust rustmod-bindgen-aarch64-softmmu_wrapper.h Failed to run rustfmt: cannot find binary path (non-fatal, continuing) [3041/3041] Linking target tests/qtest/qos-test -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH v4 5/7] .gitattributes: add Rust diff and merge attributes

2024-07-10 Thread Alex Bennée
Manos Pitsidianakis writes: > Set rust source code to diff=rust (built-in with new git versions) > and merge=binary for Cargo.lock files (they should not be merged but > auto-generated by cargo) > > Signed-off-by: Manos Pitsidianakis Reviewed-by: Alex Bennée -- Alex Bennée

Re: [RFC PATCH v4 2/7] rust: add bindgen step as a meson dependency

2024-07-09 Thread Alex Bennée
Alex Bennée writes: > Manos Pitsidianakis writes: > >> Add mechanism to generate rust hw targets that depend on a custom >> bindgen target for rust bindings to C. >> >> This way bindings will be created before the rust crate is compiled. >> >> Th

Re: [RFC PATCH v4 2/7] rust: add bindgen step as a meson dependency

2024-07-09 Thread Alex Bennée
m we have. I was going to say Bookworm has now superseded Bullseye which will reach its release + 3 year support point in August. However the version you mention in the Bookworm one! > > Paolo > >> At that point we have more information to figure out what >> if any tradeoff we want to make. >> >> thanks >> -- PMM >> -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [RFC PATCH v4 2/7] rust: add bindgen step as a meson dependency

2024-07-09 Thread Alex Bennée
ing edge (it even tripped up on the .cargo/bin/cargo I have installed). This needs to be set to the baseline which from: https://wiki.qemu.org/RustInQemu/2022 Looks to be 1.24.0 for rustc and I guess even lower for cargo (Debian says 0.66.0). While it might make sense to delay merging if we are waiting for one distro to produce a new LTS we shouldn't be needing rustup by default. -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v6 7/7] tests/tcg/x86_64: add test for plugin memory access

2024-07-08 Thread Alex Bennée
8,load,0x42 > +,atomic_op_u8,.*,8,store,0xf1 > +,load_u8,.*,8,load,0xf1 > +,store_u16,.*,16,store,0xf123 > +,atomic_op_u16,.*,16,load,0x0042 > +,atomic_op_u16,.*,16,store,0xf123 > +,load_u16,.*,16,load,0xf123 > +,store_u32,.*,32,store,0xff112233 > +,atomic_op_u32,.*,32,load,0x0042 > +,atomic_op_u32,.*,32,store,0xff112233 > +,load_u32,.*,32,load,0xff112233 > +,store_u64,.*,64,store,0xf123456789abcdef > +,atomic_op_u64,.*,64,load,0x0042 > +,atomic_op_u64,.*,64,store,0xf123456789abcdef > +,load_u64,.*,64,load,0xf123456789abcdef > +,store_u128,.*,128,store,0xf122334455667788f123456789abcdef > +,load_u128,.*,128,load,0xf122334455667788f123456789abcdef > +EOF > +} > + > +expected | while read line; do > +check "$plugin_out" "$line" > +done -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: QEMU Community Call Agenda Items (*July 9th*, 2024)

2024-07-08 Thread Alex Bennée
Manos Pitsidianakis writes: > Hello Alex, I thought It was tomorrow? QEMU Project Calendar says " > Tuesday, July 9⋅4:00 – 5:00pm > Every 2 weeks on Tuesday > " Sorry yes - I really should script my invite rather than copy/paste edit each time. > > On Mon, 8 Ju

Re: [PATCH v6 5/7] tests/tcg: allow to check output of plugins

2024-07-08 Thread Alex Bennée
tract-plugin,$@) output \ + with $(call strip-plugin,$<))) --8<---cut here---end--->8--- > endif > > gdb-%: % -- Alex Bennée Virtualisation Tech Lead @ Linaro

Updated invitation: QEMU/KVM developers conference call @ Every 2 weeks from 14:00 to 15:00 on Tuesday (BST) (qemu-devel@nongnu.org)

2024-07-08 Thread Alex Bennée
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02

Updated invitation: QEMU/KVM developers conference call @ Every 2 weeks from 14:00 to 15:00 on Tuesday from Tue 11 Jun to Tue 9 Jul (BST) (qemu-devel@nongnu.org)

2024-07-08 Thread Alex Bennée
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VTIMEZONE TZID:America/New_York X-LIC-LOCATION:America/New_York BEGIN:DAYLIGHT TZOFFSETFROM:-0500 TZOFFSETTO:-0400 TZNAME:EDT DTSTART:19700308T02

QEMU Community Call Agenda Items (July 8th, 2024)

2024-07-08 Thread Alex Bennée
Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 8/7/2024 14:00 UTC Are there any agenda items for the sync-up? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v6 4/7] tests/tcg: add mechanism to run specific tests with plugins

2024-07-08 Thread Alex Bennée
.c and aside from the inline asm I don't see why this couldn't be a multi-arch test. Could we not use the atomic primitives to make it multiarch? -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v6 3/7] plugins: extend API to get latest memory value accessed

2024-07-08 Thread Alex Bennée
ct/qemu/-/issues/1719 > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2152 > Reviewed-by: Richard Henderson > Reviewed-by: Xingtao Yao > Signed-off-by: Pierrick Bouvier Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v6 2/7] plugins: save value during memory accesses

2024-07-08 Thread Alex Bennée
will support wider operations, we'll be able to > reconsider this. > > Reviewed-by: Richard Henderson > Signed-off-by: Pierrick Bouvier Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v6 1/7] plugins: fix mem callback array size

2024-07-08 Thread Alex Bennée
to trigger mem access callbacks for atomic > instructions. > > Reviewed-by: Xingtao Yao > Reviewed-by: Richard Henderson > Signed-off-by: Pierrick Bouvier Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v1 2/2] xen: mapcache: Fix unmapping of first entries in buckets

2024-07-07 Thread Alex Bennée
"Edgar E. Iglesias" writes: > On Thu, Jul 4, 2024 at 9:48 PM Edgar E. Iglesias > wrote: > > On Thu, Jul 04, 2024 at 05:44:52PM +0100, Alex Bennée wrote: > > Anthony PERARD writes: > > > > > On Tue, Jul 02, 2024 at 12:44:21AM +0200, Edga

[PULL 20/40] gitlab: don't bother with KVM for TCI builds

2024-07-05 Thread Alex Bennée
In fact any other accelerator would be pointless as the point is to exercise the TCI accelerator anyway. Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-21-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml

[PULL 31/40] gdbstub: Move GdbCmdParseEntry into a new header file

2024-07-05 Thread Alex Bennée
to gdb_get_cmd_param. This commit also makes gdb_put_packet public since is used in gdbstub command handling. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Message-Id: <20240628050850.536447-3-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-32

[PULL 33/40] target/arm: Fix exception case in allocation_tag_mem_probe

2024-07-05 Thread Alex Bennée
From: Gustavo Romero If page in 'ptr_access' is inaccessible and probe is 'true' allocation_tag_mem_probe should not throw an exception, but currently it does, so fix it. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Message-Id: <20240628050850.536

[PULL 21/40] test/plugin: make insn plugin less noisy by default

2024-07-05 Thread Alex Bennée
While the match functionality is useful lets make the verbosity optional while we are actually running. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-22-alex.ben...@linaro.org> diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c

[PULL 38/40] gdbstub: Use true to set cmd_startswith

2024-07-05 Thread Alex Bennée
From: Gustavo Romero cmd_startswith is a boolean so use 'true' to set it instead of 1. Signed-off-by: Gustavo Romero Message-Id: <20240628050850.536447-10-gustavo.rom...@linaro.org> Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-39

[PULL 26/40] plugins/lockstep: clean-up output

2024-07-05 Thread Alex Bennée
We were repeating information which wasn't super clear. As we already will have dumped the last failing PC just note the divergence and dump the previous instruction log. Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-27-alex.ben...@linaro.org> diff --git a/contrib/p

[PULL 22/40] test/plugins: preserve the instruction record over translations

2024-07-05 Thread Alex Bennée
We are interested in the particular instruction so we should use a stable record for it. We could bring this down to physical address but for now vaddr + disas seems to do the trick. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-23-alex.

[PULL 28/40] plugins: Free CPUPluginState before destroying vCPU state

2024-07-05 Thread Alex Bennée
org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-29-alex.ben...@linaro.org> diff --git a/include/qemu/plugin.h b/include/qemu/plugin.h index bc5aef979e..af5f9db469 100644 --- a/include/qemu/plugin.h +++ b/include/qemu/plugin.h @@ -149,6 +149,9 @@ struct CP

[PULL 19/40] linux-user/main: Suppress out-of-range comparison warning for clang

2024-07-05 Thread Alex Bennée
wed-by: Akihiko Odaki Message-Id: <20240630190050.160642-15-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-20-alex.ben...@linaro.org> diff --git a/linux-user/main.c b/linux-user/main.c index 94c99a1366..7d3cf45fa9 100644 --- a/linux-user/main.c +

[PULL 32/40] gdbstub: Add support for target-specific stubs

2024-07-05 Thread Alex Bennée
functions as interfaces to extend the qSupported string, the query handler table, and the set handler table, allowing target-specific stub implementations. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Message-Id: <20240628050850.536447-4-gustavo.rom...@linaro.org> Signed-off-by

[PULL 30/40] gdbstub: Clean up process_string_cmd

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Change 'process_string_cmd' to return true on success and false on failure, instead of 0 and -1. Signed-off-by: Gustavo Romero Reviewed-by: Alex Bennée Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20240628050850.536447-2-gustavo.

[PULL 24/40] plugins/lockstep: make mixed-mode safe

2024-07-05 Thread Alex Bennée
The ExecState is shared across the socket and if we want to compare say 64 bit and 32 bit binaries we need the two to use the same sizes for things. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-25-alex.ben...@linaro.org> diff --git a/c

[PULL 23/40] plugins/lockstep: preserve sock_path

2024-07-05 Thread Alex Bennée
We can't assign sock_path directly from the autofree'd GStrv, take a copy. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-24-alex.ben...@linaro.org> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 237543b43a..67a7

[PULL 36/40] gdbstub: Make hex conversion function non-internal

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Make gdb_hextomem non-internal so it's not confined to use only in gdbstub.c. Signed-off-by: Gustavo Romero Reviewed-by: Richard Henderson Message-Id: <20240628050850.536447-8-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.

[PULL 39/40] gdbstub: Add support for MTE in user mode

2024-07-05 Thread Alex Bennée
', used to control the MTE fault type at runtime. Signed-off-by: Gustavo Romero Message-Id: <20240628050850.536447-11-gustavo.rom...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-40-alex.ben...@linaro.org> diff --git a/configs/targets/aarch64-linux-user.ma

[PULL 18/40] tests/tcg/arm: Use vmrs/vmsr instead of mcr/mrc

2024-07-05 Thread Alex Bennée
mnemonic is clearer. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-14-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-19-alex.ben...@linaro.org> diff --git a/tests/tcg/arm/fcvt.c b/tests

[PULL 25/40] plugins/lockstep: mention the one-insn-per-tb option

2024-07-05 Thread Alex Bennée
This really helps with lockstep although its super slow on big jobs. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-26-alex.ben...@linaro.org> diff --git a/contrib/plugins/lockstep.c b/contrib/plugins/lockstep.c index 8b90b37f67..1765

[PULL 34/40] target/arm: Make some MTE helpers widely available

2024-07-05 Thread Alex Bennée
Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-35-alex.ben...@linaro.org> diff --git a/target/arm/tcg/mte_helper.h b/target/arm/tcg/mte_helper.h new file mode 100644 index 00..1f471fb69b --- /dev/null +++ b/target/arm/tcg/mte_helper.h @@ -0,0 +1,66 @@ +/* + * ARM MemT

[PULL 27/40] plugins: Ensure vCPU index is assigned in init/exit hooks

2024-07-05 Thread Alex Bennée
From: Philippe Mathieu-Daudé Since vCPUs are hashed by their index, this index can't be uninitialized (UNASSIGNED_CPU_INDEX). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Message-Id: <20240606124010.2460-2-phi...@linaro.org> Signed-off-by: Alex Bennée Mess

[PULL 29/40] accel/tcg: Move qemu_plugin_vcpu_init__async() to plugins/

2024-07-05 Thread Alex Bennée
phi...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-30-alex.ben...@linaro.org> diff --git a/hw/core/cpu-common.c b/hw/core/cpu-common.c index 8f6cb64da3..b19e1fdacf 100644 --- a/hw/core/cpu-common.c +++ b/hw/core/cpu-common.c @@ -192,13 +192,6 @@

[PULL 40/40] tests/tcg/aarch64: Add MTE gdbstub tests

2024-07-05 Thread Alex Bennée
org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-41-alex.ben...@linaro.org> diff --git a/configure b/configure index 8b6a2f16ce..019fcbd0ef 100755 --- a/configure +++ b/configure @@ -1673,6 +1673,10 @@ for target in $target_list; do echo "GDB=$gdb_bin"

[PULL 05/40] tests/docker: Specify --userns keep-id for Podman

2024-07-05 Thread Alex Bennée
. Replace -u $(UID) with --userns keep-id, which fixes the UID remapping. This change is limited to Podman because Docker does not support --userns keep-id. Signed-off-by: Akihiko Odaki Message-Id: <20240626-podman-v1-1-f8c8daf2b...@daynix.com> Signed-off-by: Alex Bennée Mess

[PULL 17/40] tests/tcg/arm: Use -march and -mfpu for fcvt

2024-07-05 Thread Alex Bennée
From: Richard Henderson Clang requires the architecture to be set properly in order to assemble the half-precision instructions. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-13-richard.hender...@linaro.org> Signed-off-by: Alex Bennée M

[PULL 01/40] tests/lcitool: fix debian-i686-cross toolchain prefix

2024-07-05 Thread Alex Bennée
I guess we never noticed and tried to build with this cross image. Fix the toolchain prefix so we actually build 32 bit images. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-2-alex.ben...@linaro.org> diff --git a/tests/docker/dockerfiles/

[PULL 09/40] tests/tcg/aarch64: Explicitly specify register width

2024-07-05 Thread Alex Bennée
133...@daynix.com> Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-5-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-10-alex.ben...@linaro.org> diff --git a/tests/tcg/aarch64/bti-1.c b/tests/tcg/aarch64/bti-1.c index 99a8

[PULL 11/40] tests/tcg/aarch64: Do not use x constraint

2024-07-05 Thread Alex Bennée
; Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-12-alex.ben...@linaro.org> diff --git a/tests/tcg/arm/fcvt.c b/tests/tcg/arm/fcvt.c index 7ac47b564e..f631197287 100644 --- a/tests/tcg/arm/fcvt.c +++ b/tests/tcg/arm/fcvt.c @@ -126,7 +126,7 @@ static void convert_single_to_half(

[PULL 10/40] tests/tcg/aarch64: Fix irg operand type

2024-07-05 Thread Alex Bennée
.160642-6-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-11-alex.ben...@linaro.org> diff --git a/tests/tcg/aarch64/mte-1.c b/tests/tcg/aarch64/mte-1.c index 88dcd617ad..146cad4a04 100644 --- a/tests/tcg/aarch64/mte-1.c +++ b/tests/tcg/aarch64/mte-1.c @@

[PULL 13/40] tests/tcg/arm: Fix fcvt result messages

2024-07-05 Thread Alex Bennée
fcvt test cases for AArch32/64") Message-Id: <20240627-tcg-v2-1-1690a8133...@daynix.com> [rth: Update arm ref file as well] Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-9-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Me

[PULL 02/40] testing: restore some testing for i686

2024-07-05 Thread Alex Bennée
in the way and its TCG issues we want to catch I've added --disable-kvm to the build. Reported-by: Richard Henderson Suggested-by: Thomas Huth Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-3-alex.ben...@linaro.org> diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitla

[PULL 35/40] target/arm: Factor out code for setting MTE TCF0 field

2024-07-05 Thread Alex Bennée
across the board. Signed-off-by: Gustavo Romero Message-Id: <20240628050850.536447-7-gustavo.rom...@linaro.org> [AJB: clean-up includes, move MTE defines] Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-36-alex.ben...@linaro.org> diff -

[PULL 15/40] tests/tcg/arm: Use -fno-integrated-as for test-arm-iwmmxt

2024-07-05 Thread Alex Bennée
From: Richard Henderson Clang does not support IWMXT instructions. Fall back to the external assembler. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-11-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Mess

[PULL 12/40] tests/tcg/aarch64: Add -fno-integrated-as for sme

2024-07-05 Thread Alex Bennée
2-8-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-13-alex.ben...@linaro.org> diff --git a/tests/tcg/aarch64/Makefile.target b/tests/tcg/aarch64/Makefile.target index 11ccde5579..ad1774c2ce 100644 --- a/tests/tcg/aarch64/Makefile.target +++

[PULL 00/40] maintainer updates for testing, plugins and gdbstub

2024-07-05 Thread Alex Bennée
e x constraint tests/tcg/arm: Fix fcvt result messages tests/tcg/arm: Manually register allocate half-precision numbers Alex Bennée (11): tests/lcitool: fix debian-i686-cross toolchain prefix testing: restore some testing for i686 tracepoints: move physmem trace poi

[PULL 37/40] gdbstub: Pass CPU context to command handler

2024-07-05 Thread Alex Bennée
From: Gustavo Romero Allow passing the current CPU context to command handlers via user_ctx when the handler requires it. Signed-off-by: Gustavo Romero Message-Id: <20240628050850.536447-9-gustavo.rom...@linaro.org> Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Mess

[PULL 08/40] tests/tcg/aarch64: Drop -fno-tree-loop-distribute-patterns

2024-07-05 Thread Alex Bennée
From: Richard Henderson This option is not supported by clang, and is not required in order to get sve code generation with gcc 12. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-4-richard.hender...@linaro.org> Signed-off-by: Alex

[PULL 03/40] tracepoints: move physmem trace points

2024-07-05 Thread Alex Bennée
They don't need to be in the global trace-events file and can have a local trace header. Also add address_space_map tracepoint for tracking mapping behaviour. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-4-alex.ben...@linaro.org> diff

[PULL 04/40] hw/core: ensure kernel_end never gets used undefined

2024-07-05 Thread Alex Bennée
)) | ^ ../../hw/core/loader-fit.c:270:12: note: ‘kernel_end’ was declared here 270 | hwaddr kernel_end; |^~ Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Bennée Reviewed-by: Aleksandar Rikalo Message-Id

[PULL 07/40] tests/tcg: Adjust variable defintion from cc-option

2024-07-05 Thread Alex Bennée
From: Richard Henderson Define the variable to the compiler flag used, not "y". This avoids replication of the compiler flag itself. Signed-off-by: Richard Henderson Reviewed-by: Akihiko Odaki Message-Id: <20240630190050.160642-3-richard.hender...@linaro.org> Signed-off

[PULL 06/40] tests/tcg/minilib: Constify digits in print_num

2024-07-05 Thread Alex Bennée
Message-Id: <20240630190050.160642-2-richard.hender...@linaro.org> Signed-off-by: Alex Bennée Message-Id: <20240705084047.857176-7-alex.ben...@linaro.org> diff --git a/tests/tcg/minilib/printf.c b/tests/tcg/minilib/printf.c index 10472b4f58..fb0189c2bb 100644 --- a/tests/tcg/minilib/pr

  1   2   3   4   5   6   7   8   9   10   >