On Wed, 23 Oct 2024 14:44:19 +0200
Cédric Le Goater wrote:
> On 10/22/24 22:08, Alex Williamson wrote:
> > Thanks to work by Peter Xu, support is introduced in Linux v6.12 to
> > allow pfnmap insertions at PMD and PUD levels of the page table. This
> > means that provid
Move error handling code to the end of the function so that it can more
easily be shared by new mmap failure conditions. No functional change
intended.
Signed-off-by: Alex Williamson
---
hw/vfio/helpers.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions
pping level sizes, therefore this takes the simple approach
to align the mapping to the power-of-two size of the region, up to 1GiB,
which is currently the maximum alignment we care about.
Cc: Peter Xu
Signed-off-by: Alex Williamson
---
hw/vfio/helpers.c | 32 ++--
1
value for mmap, please share.
Thanks,
Alex
Alex Williamson (2):
vfio/helpers: Refactor vfio_region_mmap() error handling
vfio/helpers: Align mmaps
hw/vfio/helpers.c | 66 +--
1 file changed, 47 insertions(+), 19 deletions(-)
--
2.46.2
On Sat, 21 Sep 2024 00:14:40 -0700
Zhi Wang wrote:
> To support CXL device passthrough, vfio-cxl-core is introduced. This
> is the QEMU part.
>
> Get the CXL caps from the vfio-cxl-core. Trap and emulate the HDM
> decoder registers. Map the HDM decdoers when the guest commits a HDM
> decoder.
I
gt; hw/vfio/igd.c| 185 +--
> hw/vfio/pci-quirks.c | 1 +
> hw/vfio/pci.h | 1 +
> 3 files changed, 161 insertions(+), 26 deletions(-)
>
LGTM, for series
Reviewed-by: Alex Williamson
On Thu, 22 Aug 2024 13:08:29 +0200
Corvin Köhne wrote:
> The BDSM register is mirrored into MMIO space at least for gen 11 and
> later devices. Unfortunately, the Windows driver reads the register
> value from MMIO space instead of PCI config space for those devices [1].
> Therefore, we either h
On Tue, 13 Aug 2024 20:37:24 -0300
Jason Gunthorpe wrote:
> On Tue, Aug 13, 2024 at 03:03:20PM -0600, Alex Williamson wrote:
>
> > How does the guest know to write a remappable vector format? How does
> > the guest know the host interrupt architecture? For example why wo
On Tue, 13 Aug 2024 13:43:41 -0300
Jason Gunthorpe wrote:
> On Mon, Aug 12, 2024 at 11:00:40AM -0600, Alex Williamson wrote:
> > These devices have an embedded interrupt controller which is programmed
> > with guest physical MSI address/data, which doesn't work. We need
On Tue, 13 Aug 2024 11:35:15 -0400
Peter Xu wrote:
> On Mon, Aug 12, 2024 at 02:37:59PM -0400, Steven Sistare wrote:
> > On 8/8/2024 2:32 PM, Steven Sistare wrote:
> > > On 7/29/2024 8:29 AM, Igor Mammedov wrote:
> > > > On Sat, 20 Jul 2024 16:28:25 -0400
> > > > Steven Sistare wrote:
> > >
On Sat, 20 Jul 2024 12:15:27 -0700
Steve Sistare wrote:
> Do not map VFIO PCI BARs for DMA. This stops a raft of warnings of the
> following form at QEMU start time when using -object iommufd:
>
> qemu-kvm: warning: IOMMU_IOAS_MAP failed: Bad address, PCI BAR?
> qemu-kvm: vfio_container_dma_map
uires interrupt remapping support in
the host.
NB. The #define for the new vfio feature is temporary for RFC/RFT, a
formal proposal will include a proper linux-headers update.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=216055
Signed-off-by: Alex Williamson
---
hw/vfio/pci-quirks.c
On Tue, 9 Jul 2024 13:58:53 -0700
Steve Sistare wrote:
> Enable vfio-pci devices to be saved and restored across a cpr-exec of qemu.
>
> At vfio creation time, save the value of vfio container, group, and device
> descriptors in CPR state.
>
> In the container pre_save handler, suspend the use
On Fri, 5 Jul 2024 17:08:49 +0800 (CST)
tugouxp <13824125...@163.com> wrote:
> Hi folks:
>
>
> I have a questions about device vfio pass-through usage snarios,
> PCI device pass-throug for example. did the GPA that host physical
> memory mapped to Guest vcpu through MMU must be identical wi
On Wed, 3 Jul 2024 13:00:21 +0200 (CEST)
BALATON Zoltan wrote:
> On Wed, 3 Jul 2024, Michael S. Tsirkin wrote:
> > On Wed, Jul 03, 2024 at 04:15:23AM +0200, BALATON Zoltan wrote:
> >> On Tue, 2 Jul 2024, Michael S. Tsirkin wrote:
> >>> On Thu, Jun 27, 2024 at 03:08:00PM +0900, Akihiko Odaki w
On Wed, 10 Apr 2024 18:06:03 +0200
Philippe Mathieu-Daudé wrote:
> sprintf() is deprecated on Darwin since macOS 13.0 / XCode 14.1,
> resulting in painful developper experience. Use g_strdup_printf()
> instead.
Isn't this code only compiled for Linux hosts? Maybe still a valid
change, but the r
On Wed, 27 Mar 2024 16:11:37 -0400
"Michael S. Tsirkin" wrote:
> On Wed, Mar 27, 2024 at 11:39:15AM -0600, Alex Williamson wrote:
> > On Fri, 22 Mar 2024 12:12:10 +0530
> > Vinayak Kale wrote:
> >
> > > In case of migration, during restore operation
or Specific Info in VSC, check
> is
> still enforced for 3 byte VSC header.
> - Updated commit description with live migration failure scenario.
> v1->v2:
> - Limited scope of change to vfio-pci devices instead of all pci devices.
>
> hw/vfio/pci.c | 24 +
On Fri, 15 Mar 2024 23:22:22 +0530
Vinayak Kale wrote:
> On 11/03/24 8:32 pm, Alex Williamson wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Mon, 11 Mar 2024 17:45:19 +0530
> > Vinayak Kale wrote:
> >
> >>
On Mon, 11 Mar 2024 17:45:19 +0530
Vinayak Kale wrote:
> In case of migration, during restore operation, qemu checks config space of
> the
> pci device with the config space in the migration stream captured during save
> operation. In case of config space data mismatch, restore operation is fail
386/pc_sysfw.c | 17 +
> 4 files changed, 17 insertions(+), 4 deletions(-)
>
Please apply this, the original commits break my existing VMs.
Tested-by: Alex Williamson
On Fri, 8 Mar 2024 14:37:06 -0500
"Michael S. Tsirkin" wrote:
> On Fri, Mar 08, 2024 at 10:24:14AM -0700, Alex Williamson wrote:
> > On Fri, 8 Mar 2024 11:57:38 -0500
> > "Michael S. Tsirkin" wrote:
> >
> > > On Thu, Mar 07, 2024 at 11:46:42
On Fri, 8 Mar 2024 11:57:38 -0500
"Michael S. Tsirkin" wrote:
> On Thu, Mar 07, 2024 at 11:46:42AM -0700, Alex Williamson wrote:
> > The PCI 2.3 spec added definitions of the INTx disable and status bits,
> > in the command and status registers respectively. The
).
Add an experimental option to the base set of properties for PCI
devices which allows the DisINTx bit to be excluded from wmask, making
it read-only to the guest for testing purposes related to INTx masking.
Signed-off-by: Alex Williamson
---
hw/pci/pci.c | 14 ++
include
On Tue, 5 Mar 2024 05:59:46 +
Ankit Agrawal wrote:
> > One thing I forgot.
> >
> > Please add a test. tests/qtest/bios-tables-test.c
> > + relevant table dumps.
>
> Here I need to add a test that creates a vfio-pci device and numa
> nodes and link using the acpi-generic-initiator object.
On Sun, 3 Mar 2024 22:20:33 +
Xu Liu wrote:
> Hello,
>
> Recently I am running my programs in QEMU (x86_64) with “-accel=kvm”.
> The QEMU version is 6.0.0.
>
> I run my programs in two ways:
>
> 1. I pass through my device through vfio-pci to QEMU, this way
> works well.
>
> 2. I wr
On Fri, 1 Mar 2024 08:33:42 +
Ankit Agrawal wrote:
> >> As for your suggestion of using acpi-dev as the arg to take both
> >> pci-dev and acpi-dev.. Would that mean sending a pure pci device
> >> (not the corner case you mentioned) through the acpi-dev argument
> >> as well? Not sure if that
On Wed, 28 Feb 2024 10:29:32 -0800
Peter Delevoryas wrote:
> Hey guys,
>
> I’m having a little trouble reading between the lines on various
> docs, mailing list threads, KVM presentations, github forks, etc, so
> I figured I’d just ask:
>
> What is the status of IOMMU virtualization, like in th
On Thu, 1 Feb 2024 13:10:48 -0500
"Michael S. Tsirkin" wrote:
> On Thu, Feb 01, 2024 at 11:08:58PM +0530, Vinayak Kale wrote:
> >
> > On 31/01/24 11:08 pm, Alex Williamson wrote:
> > >
> > > On Wed, 31 Jan 2024 15:22:59 +0530
> > > Vinaya
On Wed, 31 Jan 2024 15:22:59 +0530
Vinayak Kale wrote:
> On 31/01/24 12:28 am, Alex Williamson wrote:
> >
> > On Tue, 30 Jan 2024 23:32:26 +0530
> > Vinayak Kale wrote:
> >
> >> Missed adding Michael, Marcel, Alex and Avihai earlier, apologies.
> >
On Tue, 30 Jan 2024 23:32:26 +0530
Vinayak Kale wrote:
> Missed adding Michael, Marcel, Alex and Avihai earlier, apologies.
>
> Regards,
> Vinayak
>
> On 30/01/24 3:26 pm, Vinayak Kale wrote:
> > In case of migration, during restore operation, qemu checks the config
> > space of the pci device
t; > phys_bits value as shown in this patch.
> >
> > Previous attempt at solving this issue in OVMF:
> > https://edk2.groups.io/g/devel/topic/102359124
> >
> > Cc: Gerd Hoffmann
> > Cc: Philippe Mathieu-Daudé
> > Cc: Alex Williamson
> >
NTX-0: VFIO_DEVICE_SET_IRQS failure: Invalid argument
>
> To avoid that, unconditionaly clear the IRQ index when MSI-X is
> disabled.
>
> Buglink: https://issues.redhat.com/browse/RHEL-21293
> Fixes: 5ebffa4e87e7 ("vfio/pci: use an invalid fd to enable MSI-X")
> Cc: J
On Wed, 24 Jan 2024 14:57:41 +0100
Eric Auger wrote:
> Hi Alex,
>
> On 1/24/24 14:37, Alex Williamson wrote:
> > On Wed, 24 Jan 2024 14:14:19 +0100
> > Eric Auger wrote:
> >
> >> Hi Alex,
> >>
> >> On 1/24/24 00:51, Alex Williamson wrote:
On Wed, 24 Jan 2024 14:14:19 +0100
Eric Auger wrote:
> Hi Alex,
>
> On 1/24/24 00:51, Alex Williamson wrote:
> > On Tue, 23 Jan 2024 19:15:55 +0100
> > Eric Auger wrote:
> >
> >> aw-bits is a new option that allows to set the bit width of
> >> the
On Tue, 23 Jan 2024 19:15:55 +0100
Eric Auger wrote:
> aw-bits is a new option that allows to set the bit width of
> the input address range. This value will be used as a default for
> the device config input_range.end. By default it is set to 64 bits
> which is the current value.
>
> Signed-off
On Fri, 12 Jan 2024 07:04:59 -0800
Steve Sistare wrote:
> Allow cpr-reboot for vfio if the guest is in the suspended runstate. The
> guest drivers' suspend methods flush outstanding requests and re-initialize
> the devices, and thus there is no device state to save and restore. The
> user is re
On Thu, 4 Jan 2024 16:40:39 +
Ankit Agrawal wrote:
> Had a discussion with RH folks, summary follows:
>
> 1. To align with the current spec description pointed by Jonathan, we first do
> a separate object instance per GI node as suggested by Jonathan. i.e.
> a acpi-generic-initiato
On Thu, 4 Jan 2024 03:36:06 +
Ankit Agrawal wrote:
> Thanks Jonathan for the review.
>
> > As per reply to the cover letter I definitely want to see SRAT table dumps
> > in here though so we can easily see what this is actually building.
>
> Ack.
>
> > I worry that some OS might make the
On Sun, 19 Nov 2023 18:31:10 +0530
wrote:
> From: Ankit Agrawal
>
> NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows
> partitioning of the GPU device resources (including device memory) into
> several (upto 8) isolated instances. Each of the partitioned memory needs
> a d
On Sun, 19 Nov 2023 18:31:11 +0530
wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
> achieve
On Wed, 8 Nov 2023 00:30:39 +0530
wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
> achieved
On Thu, 26 Oct 2023 09:10:43 +0200
Cédric Le Goater wrote:
> and drop warning when ENOTTY is returned. Only useful for the mdev-mtty
> driver today, which has partial support for INTx: the AUTOMASK
> behavior is not implemented.
FWIW, I prefer not to carry a sentence through from subject to comm
1522913
> Fixes: 2dca1b37a760 ("vfio/pci: add support for VF token")
> Cc: Alex Williamson
> Signed-off-by: Cédric Le Goater
> ---
> hw/vfio/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
&g
On Wed, 11 Oct 2023 19:52:29 +0200
Eric Auger wrote:
> Now we retrieve the usable IOVA ranges from the host,
> we now the physical IOMMU aperture and we can remove
s/now/use/?
> the assumption of 64b IOVA space when calling
> vfio_host_win_add().
>
> This works fine in general but in case of a
re. We can
just test iova_ranges != NULL for calling set_iova_ranges. In patch 13
we can again test against NULL, which I think also negates the need to
assert nr_iovas since the NULL test automatically catches the zero
case. Otherwise
Reviewed-by: Alex Williamson
> } VFIOContainer;
>
On Tue, 17 Oct 2023 12:28:30 -0300
Jason Gunthorpe wrote:
> On Tue, Oct 17, 2023 at 09:21:16AM -0600, Alex Williamson wrote:
>
> > Do we therefore need some programatic means for the kernel driver to
> > expose the node configuration to userspace? What interfaces would
>
On Tue, 17 Oct 2023 14:00:54 +
Ankit Agrawal wrote:
> >> -device
> >>vfio-pci-nohotplug,host=0009:01:00.0,bus=pcie.0,addr=04.0,rombar=0,id=dev0 \
> >> -object
> >>nvidia-acpi-generic-initiator,id=gi0,device=dev0,numa-node-start=2,numa-node-count=8
> >>
> >
> > Why didn't w
On Sun, 8 Oct 2023 01:47:38 +0530
wrote:
> From: Ankit Agrawal
>
> The CPU cache coherent device memory can be added as NUMA nodes
> distinct from the system memory nodes. These nodes are associated
> with the device and Qemu needs a way to maintain this link.
>
> Introduce a new acpi-generic-
On Sun, 8 Oct 2023 01:47:40 +0530
wrote:
> From: Ankit Agrawal
>
> NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows
> partitioning of the GPU device resources (including device memory) into
> several (upto 8) isolated instances. Each of the partitioned memory needs
> a de
On Sun, 8 Oct 2023 01:47:39 +0530
wrote:
> From: Ankit Agrawal
>
> ACPI spec provides a scheme to associate "Generic Initiators" [1]
> (e.g. heterogeneous processors and accelerators, GPUs, and I/O devices with
> integrated compute or DMA engines GPUs) with Proximity Domains. This is
> achieved
On Mon, 9 Oct 2023 13:30:48 +0100
Jonathan Cameron wrote:
> On Sun, 8 Oct 2023 01:47:40 +0530
> wrote:
>
> > From: Ankit Agrawal
> >
> > NVIDIA GPU's support MIG (Mult-Instance GPUs) feature [1], which allows
> > partitioning of the GPU device resources (including device memory) into
> > seve
On Mon, 2 Oct 2023 21:41:55 +0200
Laszlo Ersek wrote:
> On 10/2/23 21:26, Alex Williamson wrote:
> > On Mon, 2 Oct 2023 20:24:11 +0200
> > Laszlo Ersek wrote:
> >
> >> On 10/2/23 16:41, Alex Williamson wrote:
> >>> On Mon, 2 Oct 2023 15
On Mon, 2 Oct 2023 20:24:11 +0200
Laszlo Ersek wrote:
> On 10/2/23 16:41, Alex Williamson wrote:
> > On Mon, 2 Oct 2023 15:38:10 +0200
> > Cédric Le Goater wrote:
> >
> >> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote:
> >>> From: Marc-And
On Mon, 2 Oct 2023 15:38:10 +0200
Cédric Le Goater wrote:
> On 10/2/23 13:11, marcandre.lur...@redhat.com wrote:
> > From: Marc-André Lureau
> >
> > RAMFB migration was unsupported until now, let's make it conditional.
> > The following patch will prevent machines <= 8.1 to migrate it.
> >
> >
On Wed, 27 Sep 2023 15:03:09 +
Vikram Sethi wrote:
> > From: Alex Williamson
> > Sent: Wednesday, September 27, 2023 9:25 AM
> > To: Jason Gunthorpe
> > Cc: Jonathan Cameron ; Ankit Agrawal
> > ; David Hildenbrand ; Cédric Le
> > Goater ; shan
On Wed, 27 Sep 2023 10:53:36 -0300
Jason Gunthorpe wrote:
> On Wed, Sep 27, 2023 at 12:33:18PM +0100, Jonathan Cameron wrote:
>
> > CXL accelerators / GPUs etc are a different question but who has one
> > of those anyway? :)
>
> That's exactly what I mean when I say CXL will need it too. I ke
On Tue, 26 Sep 2023 18:54:53 +0200
David Hildenbrand wrote:
> On 26.09.23 16:52, Ankit Agrawal wrote:
> > Good idea. Fundamentally the device should not be creating NUMA
> > nodes, the VM should be configured with NUMA nodes and the device
> > memory associated with those nodes.
>
X in interrupt restoring on dynamic allocation
>
> hw/vfio/pci.c| 121 +--
> hw/vfio/pci.h| 1 +
> hw/vfio/trace-events | 2 +-
> 3 files changed, 96 insertions(+), 28 deletions(-)
>
Some minor comments on 2/ but otherwise:
Reviewed-by: Alex Williamson
On Mon, 18 Sep 2023 05:45:05 -0400
Jing Liu wrote:
> The vector_use callback is used to enable vector that is unmasked in
> guest. The kernel used to only support static MSI-X allocation. When
> allocating a new interrupt using "static MSI-X allocation" kernels,
> QEMU first disables all previous
On Wed, 30 Aug 2023 18:37:39 +0800
Zhenzhong Duan wrote:
> So that it doesn't need to be moved into container.c as done
> in following patch.
>
> Signed-off-by: Zhenzhong Duan
> ---
> hw/vfio/common.c | 17 -
> 1 file changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/h
On Wed, 30 Aug 2023 18:37:38 +0800
Zhenzhong Duan wrote:
> With a vfio device iterator added, we can make some migration and reset
> related functions group agnostic.
> E.x:
> vfio_mig_active
> vfio_migratable_device_num
> vfio_devices_all_dirty_tracking
> vfio_devices_all_device_dirty_tracking
>
On Wed, 30 Aug 2023 18:37:37 +0800
Zhenzhong Duan wrote:
> ...which will be used by both legacy and iommufd backend.
+1 to Eric's comments regarding complete sentences in the commit log
and suggested description.
>
> Signed-off-by: Yi Liu
> Signed-off-by: Zhenzhong Duan
> ---
> hw/vfio/comm
On Wed, 20 Sep 2023 15:12:59 -0300
Jason Gunthorpe wrote:
> On Wed, Sep 20, 2023 at 12:01:42PM -0600, Alex Williamson wrote:
> > On Wed, 20 Sep 2023 03:42:20 +
> > "Duan, Zhenzhong" wrote:
> >
> > > >-Original Message-
> >
On Wed, 13 Sep 2023 10:01:47 +0200
Eric Auger wrote:
> Now we retrieve the usable IOVA ranges from the host,
> we now the physical IOMMU aperture and we can remove
> the assumption of 64b IOVA space when calling
> vfio_host_win_add().
>
> This works fine in general but in case of an IOMMU memory
On Wed, 20 Sep 2023 14:49:19 -0300
Jason Gunthorpe wrote:
> On Wed, Sep 20, 2023 at 07:37:53PM +0200, Eric Auger wrote:
>
> > >> qemu will typically not be able to
> > >> self-open /dev/iommufd as it is root-only.
> > >
> > > I don't understand, we open multiple fds to KVM devices. This is the
On Wed, 20 Sep 2023 03:42:20 +
"Duan, Zhenzhong" wrote:
> >-Original Message-
> >From: Cédric Le Goater
> >Sent: Wednesday, September 20, 2023 1:08 AM
> >Subject: Re: [PATCH v1 15/22] Add iommufd configure option
> >
> >On 8/30/23 12:37, Zhenzhong Duan wrote:
> >> This adds "--enab
On Wed, 13 Sep 2023 10:01:47 +0200
Eric Auger wrote:
> Now we retrieve the usable IOVA ranges from the host,
> we now the physical IOMMU aperture and we can remove
> the assumption of 64b IOVA space when calling
> vfio_host_win_add().
>
> This works fine in general but in case of an IOMMU memory
On Wed, 13 Sep 2023 10:01:41 +0200
Eric Auger wrote:
> This helper reverses an array of regions, turning original
> regions into holes and original holes into actual regions,
> covering the whole UINT64_MAX span.
>
> Signed-off-by: Eric Auger
>
> ---
>
> v1 -> v2:
> - Move range_inverse_array
On Wed, 13 Sep 2023 10:01:38 +0200
Eric Auger wrote:
> Collect iova range information if VFIO_IOMMU_TYPE1_INFO_CAP_IOVA_RANGE
> capability is supported.
>
> This allows to propagate the information though the IOMMU MR
> set_iova_ranges() callback so that virtual IOMMUs
> get aware of those apert
io_pci_nvlink2")
>
> This was 2.5 years ago. Do the same in QEMU with a revert of commit
> ec132efaa81f ("spapr: Support NVIDIA V100 GPU with NVLink2"). Some
> adjustements are required on the NUMA part.
>
> Cc: Alexey Kardashevskiy
> Signed-off-by: Céd
On Fri, 15 Sep 2023 16:19:29 +0200
Cédric Le Goater wrote:
> Hello Ankit,
>
> On 9/15/23 04:45, ank...@nvidia.com wrote:
> > From: Ankit Agrawal
> >
> > For devices which allow CPU to cache coherently access their memory,
> > it is sensible to expose such memory as NUMA nodes separate from
> >
ay.
Thanks,
Alex
On Tue, 5 Sep 2023 09:09:07 -0600
Alex Williamson wrote:
> On Mon, 4 Sep 2023 21:00:53 +0400
> Marc-André Lureau wrote:
>
> > Hi
> >
> > On Mon, Sep 4, 2023 at 6:11 PM Alex Williamson
> > wrote:
> > >
> > > On
> On Tue, Sep 12, 2023 at 3:58 PM Alex Williamson
> wrote:
> >
> > On Tue, 12 Sep 2023 14:47:41 +0200
> > Philippe Mathieu-Daudé wrote:
> >
> > > Cc'ing VFIO maintainers.
> > >
> > > On 12/9/23 14:39, Shlomo Pongratz wrote:
> &
On Tue, 12 Sep 2023 14:47:41 +0200
Philippe Mathieu-Daudé wrote:
> Cc'ing VFIO maintainers.
>
> On 12/9/23 14:39, Shlomo Pongratz wrote:
> > Hi,
> > I'm running qemu-system-aarch64 (QEMU emulator version 7.0.93) on
> > Ubuntu 20.04.4 LTS i with Intel's i7.
> > I'm trying to pass a Samsung NVME d
On Mon, 11 Sep 2023 11:12:55 +0100
Joao Martins wrote:
> On 11/09/2023 10:48, Duan, Zhenzhong wrote:
> >> -Original Message-
> >> From: Joao Martins
> >> Sent: Monday, September 11, 2023 5:07 PM
> >> Subject: Re: [PATCH v1] vfio/common: Separate vfio-pci ranges
> >>
> >> On 11/09/2023 09
On Wed, 6 Sep 2023 15:10:39 -0300
Jason Gunthorpe wrote:
> On Wed, Aug 30, 2023 at 06:37:53PM +0800, Zhenzhong Duan wrote:
> > Note the /dev/iommu device may have been pre-opened by a
> > management tool such as libvirt. This mode is no more considered
> > for the legacy backend. So let's remove
On Mon, 4 Sep 2023 10:03:43 +0200
Eric Auger wrote:
> On x86, when assigning VFIO-PCI devices protected with virtio-iommu
> we encounter the case where the guest tries to map IOVAs beyond 48b
> whereas the physical VTD IOMMU only supports 48b. This ends up with
> VFIO_MAP_DMA failures at qemu le
On Mon, 4 Sep 2023 21:00:53 +0400
Marc-André Lureau wrote:
> Hi
>
> On Mon, Sep 4, 2023 at 6:11 PM Alex Williamson
> wrote:
> >
> > On Mon, 4 Sep 2023 15:06:21 +0400
> > Marc-André Lureau wrote:
> >
> > > Hi
> > >
> >
with normal width/height.
> >
> > On 8/16/2023 3:31 PM, Philippe Mathieu-Daudé wrote:
> > > On 16/8/23 23:55, Alex Williamson wrote:
> > >> The below referenced commit renames scanout_width/height to
> > >> backing_width/height, but also promotes these
On Mon, 21 Aug 2023 14:20:38 +0400
Marc-André Lureau wrote:
> Hi Alex
>
> On Thu, Aug 17, 2023 at 1:25 AM Alex Williamson
> wrote:
> >
> > On Wed, 16 Aug 2023 15:08:10 -0600
> > Alex Williamson wrote:
> > > > diff --git a/ui/egl-helpers.c b
screen when transitioning from ramfb to dmabuf display
when using Intel vGPU with these features.
Link: https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg02726.html
Fixes: 9ac06df8b684 ("virtio-gpu-udmabuf: correct naming of QemuDmaBuf size
properties")
Signed-off-by: Alex Williamson
On Wed, 16 Aug 2023 15:08:10 -0600
Alex Williamson wrote:
> > diff --git a/ui/egl-helpers.c b/ui/egl-helpers.c
> > index 8f9fbf583e..3d19dbe382 100644
> > --- a/ui/egl-helpers.c
> > +++ b/ui/egl-helpers.c
> > @@ -314,9 +314,9 @@ void egl_dmabuf_imp
This commit introduces a regression when using GVT-g with the display
and ramfb options. At the point where it appears the guest is switching
from ramfb to the vGPU display, the display goes black and QEMU reports:
qemu: eglCreateImageKHR failed
This message occurs repeatedly.
VM command line:
On Wed, 9 Aug 2023 14:07:07 +0200
Laszlo Ersek wrote:
> On 8/8/23 17:40, Alex Williamson wrote:
> > On Tue, 8 Aug 2023 16:59:16 +0200
> > Laszlo Ersek wrote:
> >
> >> The Solarflare Communications SFC9220 NIC's physical function (PF) appears
>
during boot on i440fx/SeaBIOS (a relatively frequent scenario).
> Users can restore the original behavior via the QEMU cmdline and the
> libvirt domain XML.
>
> (In two years, we've not seen any customer interest in this bug, hence
> there's no incentive to investigate (2).
On Fri, 28 Jul 2023 10:27:17 +0200
Cédric Le Goater wrote:
> On 7/28/23 10:09, Liu, Jing2 wrote:
> > Hi Alex,
> >
> > Thanks very much for reviewing the patches.
> >
> >> On July 28, 2023 1:25 AM, Alex Williamson
> >> wrote:
> >>
> &
On Thu, 27 Jul 2023 03:24:08 -0400
Jing Liu wrote:
> From: Reinette Chatre
>
> Kernel provides the guidance of dynamic MSI-X allocation support of
> passthrough device, by clearing the VFIO_IRQ_INFO_NORESIZE flag to
> guide user space.
>
> Fetch and store the flags from host for later use to d
On Thu, 27 Jul 2023 03:24:10 -0400
Jing Liu wrote:
> During migration restoring, vfio_enable_vectors() is called to restore
> enabling MSI-X interrupts for assigned devices. It sets the range from 0
> to nr_vectors to kernel to enable MSI-X and the vectors unmasked in
> guest. During the MSI-X en
On Thu, 27 Jul 2023 03:24:09 -0400
Jing Liu wrote:
> The vector_use callback is used to enable vector that is unmasked in
> guest. The kernel used to only support static MSI-X allocation. When
> allocating a new interrupt using "static MSI-X allocation" kernels,
> Qemu first disables all previous
On Fri, 14 Jul 2023 21:50:01 +0300
Michael Tokarev wrote:
> 14.07.2023 21:22, Alex Williamson wrote:
> > On Fri, 14 Jul 2023 14:38:06 +0300
> > Michael Tokarev wrote:
> >
> >> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> >> index d
On Fri, 14 Jul 2023 14:38:06 +0300
Michael Tokarev wrote:
> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> index d8aeee0b7e..12e7790cf6 100644
> --- a/hw/ppc/spapr_pci_vfio.c
> +++ b/hw/ppc/spapr_pci_vfio.c
> @@ -39,7 +39,7 @@ static void spapr_phb_vfio_eeh_reenable(SpaprPhbStat
gion_finalize(&bar->region);
> -if (bar->size) {
> +if (bar->mr) {
> +assert(bar->size);
> object_unparent(OBJECT(bar->mr));
> g_free(bar->mr);
> +bar->mr = NULL;
> }
> }
>
Reviewed-by: Alex Williamson
for
GPUDirect Cliques")
Signed-off-by: Alex Williamson
---
hw/vfio/pci-quirks.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/pci-quirks.c b/hw/vfio/pci-quirks.c
index 0ed2fcd53152..f4ff83680572 100644
--- a/hw/vfio/pci-quirks.c
+++ b/hw/vfio/pci-quirks.c
On Thu, 29 Jun 2023 16:42:23 +0100
Joao Martins wrote:
> On 29/06/2023 16:20, Avihai Horon wrote:
> > On 29/06/2023 15:44, Joao Martins wrote:
> >> On 29/06/2023 09:40, Zhenzhong Duan wrote:
> >>> This patch refactors vfio_migration_realize() and its dependend code
> >>> as follows:
> >>>
> >
igration/savevm.c| 1 +
> migration/target.c| 17 ++-
> hw/vfio/trace-events | 2 +-
> 9 files changed, 97 insertions(+), 37 deletions(-)
>
Reviewed-by: Alex Williamson
Cédric has stepped up involvement in vfio, reviewing and managing
patches, as well as pull requests. This work deserves gratitude and
punishment with a promotion to co-maintainer ;)
Signed-off-by: Alex Williamson
---
Cédric, I'd also support if you wanted to add a tree entry
On Tue, 27 Jun 2023 11:00:46 +0300
Avihai Horon wrote:
> On 26/06/2023 20:27, Alex Williamson wrote:
> > External email: Use caution opening links or attachments
> >
> >
> > On Mon, 26 Jun 2023 17:26:42 +0200
> > Cédric Le Goater wrote:
> >
&g
On Mon, 26 Jun 2023 17:26:42 +0200
Cédric Le Goater wrote:
> On 6/26/23 15:40, Joao Martins wrote:
> > On 26/06/2023 14:20, Cédric Le Goater wrote:
> >> Hello Avihai,
> >>
> >> On 6/26/23 10:23, Avihai Horon wrote:
> >>> The major parts of VFIO migration are supported today in QEMU. This
> >>
were given).
> * Dropped patch #8 (x-allow-pre-copy property). (Alex)
> * Adjusted patch #9 commit message according to drop of patch #8.
> * Added R-b to patch #9 and Tested-by tags to the series.
I think Cédric is going to handle the pull request for this, so...
Acked-by: Alex Williamson
1 - 100 of 2680 matches
Mail list logo
