[Bug 1826827] Re: dtc crash; pnv_dt_serial cannot find lpc's phandle

2020-11-25 Thread Amol Surati
** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1826827 Title: dtc crash; pnv_dt_serial cannot find lpc's phandle Status in QEMU: Fix

Re: [Qemu-devel] [Qemu-ppc] [PATCH] ppc/pnv: Generate phandle for the "interrupt-parent" property

2019-07-24 Thread Amol Surati
On Wed, Jul 24, 2019 at 06:57:30PM +1000, David Gibson wrote: > On Wed, Jul 24, 2019 at 09:11:54AM +0200, Cédric Le Goater wrote: > > On 24/07/2019 05:23, David Gibson wrote: > > > On Tue, Jul 23, 2019 at 11:01:38AM +0200, Cédric Le Goater wrote: > > >> Devices such as the BT or serial devices

Re: [Qemu-devel] [PATCH for-4.1 0/2] Compatibility fixes for nettle 2.7 vs 3.0 vs 3.5

2019-07-12 Thread Amol Surati
On Fri, Jul 12, 2019 at 11:18:47AM +0100, Daniel P. Berrangé wrote: > This short series fixes a few compatibility issues around different > nettle versions. Thank you for the fix. The compilation with nettle 3.5.1 now succeeds without resorting to --disable-werror or --disable-nettle. -amol

[Qemu-devel] qemu compilation failure with nettle 3.5.1

2019-07-10 Thread Amol Surati
Hi, The qemu upstream (at commit 6df2cdf44a at the moment) fails to compile with nettle 3.5.1. It seems that Nettle has deprecated a few parts of its API. A workaround is to provide --disable-nettle during qemu configuration. A portion of the error log: error: ‘nettle_aes_encrypt’ is

[Qemu-devel] [Bug 1828507] Re: qemu-system-ppc64 smp crash on manual reset

2019-05-10 Thread Amol Surati
If one continues with the iso, and installs the OS in the guest, the rebooting of the guest from within the guest OS too causes qemu to exit fatally. So, one can run 'systemctl reboot' or 'reboot' within the guest OS and see qemu crash (immediately after SLOF prints version, etc. as part of the

[Qemu-devel] [Bug 1828507] [NEW] qemu-system-ppc64 smp crash on manual reset

2019-05-10 Thread Amol Surati
Public bug reported: Host Environment: x86_64 Linux v5.0.2 QEMU emulator version 4.0.50 (v4.0.0-354-g812b835fb4) SLOF: Build Date = Jan 14 2019 18:00:39 FW Version = git-a5b428e1c1eae703 Problem: Qemu crash immediately after a manual reset (this is not the initial

[Qemu-devel] [Bug 1826827] Re: dtc crash; pnv_dt_serial cannot find lpc's phandle

2019-05-06 Thread Amol Surati
> Btw, I'm assuming where you say... My bad. Yes, you are correct. The problem is seen when decompiling the blob to source. > 1) The powernv machine in qemu is attempting to use a phandle for node > that doesn't have one. True. > 2) dtc is crashing with an assertion - that shouldn't happen,

[Qemu-devel] [Bug 1826827] Re: dtc crash; pnv_dt_serial cannot find lpc's phandle

2019-04-28 Thread Amol Surati
** Description changed: Qemu version: QEMU emulator version 4.0.50 (v4.0.0-142-ge0fb2c3d89) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers dtc version: Version: DTC 1.5.0-g5c3513f6 -

[Qemu-devel] [Bug 1826827] [NEW] dtc crash; pnv_dt_serial cannot find lpc's phandle

2019-04-28 Thread Amol Surati
Public bug reported: Qemu version: QEMU emulator version 4.0.50 (v4.0.0-142-ge0fb2c3d89) Copyright (c) 2003-2019 Fabrice Bellard and the QEMU Project developers dtc version: Version: DTC 1.5.0-g5c3513f6 - pnv_dt_serial has

[Qemu-devel] [Bug 1826827] Re: dtc crash; pnv_dt_serial cannot find lpc's phandle

2019-04-28 Thread Amol Surati
** Attachment added: "the powernv dtb" https://bugs.launchpad.net/qemu/+bug/1826827/+attachment/5259834/+files/dtb ** Description changed: - pnv_dt_serial has a line which is supposed to set the interrupt-parent - of the "isa-serial@i3f8" node to the phandle of "lpc@0". + Qemu version: + QEMU

Re: [Qemu-devel] [PATCH 1/2] ide/hw/core: fix crash on processing a partial-sector-size DMA xfer

2018-06-25 Thread Amol Surati
On Mon, Jun 25, 2018 at 05:10:23PM -0400, John Snow wrote: > > > On 06/20/2018 12:29 AM, Amol Surati wrote: > > Fixes: https://bugs.launchpad.net/qemu/+bug/1777315 > > > > QEMU's short PRD policy applies to a DMA transfer of size < 512 bytes. > > But

[Qemu-devel] [PATCH 0/2] ide/hw/core: fix bug# 1777315, crash on short PRDs

2018-06-19 Thread Amol Surati
in one go; - avoids the crash; - but, treats the affected transfers as short, instead of allowing them to continue. Amol Surati (1): ide/hw/core: fix crash on processing a partial-sector-size DMA xfer John Snow (1): tests/ide-test: test case for crash when processing short PRDs hw/ide

[Qemu-devel] [PATCH 1/2] ide/hw/core: fix crash on processing a partial-sector-size DMA xfer

2018-06-19 Thread Amol Surati
r size, such transfers are subjected to the policy, and therefore culled before they cause the crash. Signed-off-by: Amol Surati --- hw/ide/core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 2c62efc536..14d135224b 100644 --- a/hw/ide/core.c

[Qemu-devel] [PATCH 2/2] tests/ide-test: test case for crash when processing short PRDs

2018-06-19 Thread Amol Surati
From: John Snow Related Bug: https://bugs.launchpad.net/qemu/+bug/1777315 Signed-off-by: Amol Surati --- tests/ide-test.c | 28 1 file changed, 28 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index f39431b1a9..382c29a174 100644 --- a/tests/ide

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Wed, Jun 20, 2018 at 06:23:19AM +0530, Amol Surati wrote: > On Tue, Jun 19, 2018 at 05:43:52PM -0400, John Snow wrote: > > > > > > On 06/19/2018 05:26 PM, Amol Surati wrote: > > > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > > >>

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 05:43:52PM -0400, John Snow wrote: > > > On 06/19/2018 05:26 PM, Amol Surati wrote: > > On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > >> On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > >>> > >>>

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 08:04:03PM +0530, Amol Surati wrote: > On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > > > > > > On 06/19/2018 04:53 AM, Kevin Wolf wrote: > > > Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > > >> On Mon, J

Re: [Qemu-devel] [Qemu-block] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-19 Thread Amol Surati
On Tue, Jun 19, 2018 at 09:45:15AM -0400, John Snow wrote: > > > On 06/19/2018 04:53 AM, Kevin Wolf wrote: > > Am 19.06.2018 um 06:01 hat Amol Surati geschrieben: > >> On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrote: > >>> > >>>

Re: [Qemu-devel] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread Amol Surati
On Mon, Jun 18, 2018 at 08:14:10PM -0400, John Snow wrote: > > > On 06/18/2018 02:02 PM, Amol Surati wrote: > > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > >> This patch fixes the assumption that io_buffer_size is always a perfect > >

Re: [Qemu-devel] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread Amol Surati
On Mon, Jun 18, 2018 at 02:13:52PM -0400, John Snow wrote: > > On 06/18/2018 02:02 PM, Amol Surati wrote: > > On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > >> This patch fixes the assumption that io_buffer_size is always a perfect > >> multiple of t

[Qemu-devel] [Bug 1777315] Re: Denial of service

2018-06-18 Thread Amol Surati
A repro for the bug is setup at https://github.com/asurati/1777315, although the rfc-patch that was sent yesterday is pending testing. Unless qemu-devel advises otherwise, I am available to test and present it as a bugfix, by tomorrow. -- You received this bug notification because you are a

Re: [Qemu-devel] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-18 Thread Amol Surati
On Mon, Jun 18, 2018 at 12:05:15AM +0530, Amol Surati wrote: > This patch fixes the assumption that io_buffer_size is always a perfect > multiple of the sector size. The assumption is the cause of the firing > of 'assert(n * 512 == s->sg.size);'. > > Signed-o

[Qemu-devel] [RFC 0/1] ide: attempt at fixing the bug #1777315.

2018-06-17 Thread Amol Surati
g.size);', could work, provided these two are the only possibilities. Amol Surati (1): ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes hw/ide/core.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) -- 2.17.1

[Qemu-devel] [RFC 1/1] ide: bug #1777315: io_buffer_size and sg.size can represent partial sector sizes

2018-06-17 Thread Amol Surati
This patch fixes the assumption that io_buffer_size is always a perfect multiple of the sector size. The assumption is the cause of the firing of 'assert(n * 512 == s->sg.size);'. Signed-off-by: Amol Surati --- hw/ide/core.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deleti

[Qemu-devel] [PATCH] hw/intc/arm_gicv3: fix an extra left-shift when reading IPRIORITYR

2018-06-14 Thread Amol Surati
-by: Amol Surati --- hw/intc/arm_gicv3_dist.c | 3 ++- hw/intc/arm_gicv3_redist.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c index 93fe936862..53c55c5729 100644 --- a/hw/intc/arm_gicv3_dist.c +++ b/hw/intc