On 26/06/19 17:50, Laurent Vivier wrote:
Le 26/06/2019 à 17:16, Antonio Ospite a écrit :
On 26/05/19 16:47, Antonio Ospite wrote:
Hi,
Here is a v3 set to address
https://bugs.launchpad.net/qemu/+bug/1817345
CCing Laurent Vivier as the patch is going through the trivial-patches
branch
On 26/05/19 16:47, Antonio Ospite wrote:
Hi,
Here is a v3 set to address
https://bugs.launchpad.net/qemu/+bug/1817345
CCing Laurent Vivier as the patch is going through the trivial-patches
branch.
Ping.
I cannot see this in the trivial-patches repository nor in mainline qemu.
Thanks
From: Antonio Ospite
The configure script breaks when the qemu source directory is in a path
containing white spaces, in particular the list of targets is not
correctly generated when calling "./configure --help" because of how the
default_target_list variable is built.
I
From: Antonio Ospite
Since commit 79d77bcd36 (configure: Remove --source-path option,
2019-04-29) source_path cannot be overridden anymore, move it out of the
"default parameters" block since the word "default" may suggest that the
value can change, while in fact it does not
Ospite (2):
configure: set source_path only once and make its definition more
robust
configure: disallow spaces and colons in source path and build path
Makefile | 4
configure | 11 ---
2 files changed, 12 insertions(+), 3 deletions(-)
--
Antonio Ospite
https://ao2.it
https
On 22/05/19 17:21, Laurent Vivier wrote:
On 22/05/2019 17:01, Antonio Ospite wrote:
On 22/05/19 15:57, Laurent Vivier wrote:
On 09/05/2019 16:42, Peter Maydell wrote:
On Mon, 6 May 2019 at 18:27, Eric Blake wrote:
On 5/3/19 3:27 AM, Antonio Ospite wrote:
From: Antonio Ospite
On 22/05/19 15:57, Laurent Vivier wrote:
On 09/05/2019 16:42, Peter Maydell wrote:
On Mon, 6 May 2019 at 18:27, Eric Blake wrote:
On 5/3/19 3:27 AM, Antonio Ospite wrote:
From: Antonio Ospite
The configure script breaks when the qemu source directory is in a path
containing white spaces
On Mon, 6 May 2019 12:27:46 -0500
Eric Blake wrote:
> On 5/3/19 3:27 AM, Antonio Ospite wrote:
> > From: Antonio Ospite
> >
> > The configure script breaks when the qemu source directory is in a path
> > containing white spaces, in particular the list of targets is
:
https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg05398.html
Thanks,
Antonio
Antonio Ospite (2):
configure: set source_path only once and make its definition more
robust
configure: disallow spaces and colons in source path and build path
Makefile | 4
configure | 12
From: Antonio Ospite
The configure script breaks when the qemu source directory is in a path
containing white spaces, in particular the list of targets is not
correctly generated when calling "./configure --help" because of how the
default_target_list variable is built.
I
From: Antonio Ospite
Since commit 79d77bcd36 (configure: Remove --source-path option,
2019-04-29) source_path cannot be overridden anymore, move it out of the
"default parameters" block since the word "default" may suggest that the
value can change, while in fact it does not
On 19/03/19 09:41, Antonio Ospite wrote:
On 18/03/19 14:40, Peter Maydell wrote:
Normally configure identifies the source path by looking
at the location where the configure script itself exists.
We also provide a --source-path option which lets the user
manually override this.
There isn't
On 18/03/19 14:40, Peter Maydell wrote:
Normally configure identifies the source path by looking
at the location where the configure script itself exists.
We also provide a --source-path option which lets the user
manually override this.
There isn't really an obvious use case for the
# FAILS (CURDIR)
So checking both source_path and PWD is a probably a good thing.
I'd add the check in the Makefile too, to be on the safe side and cover
the case of: no_spaces/qemulink $ make
Yeah, it is a slow Saturday. :)
Ciao,
Antonio
--
Antonio Ospite
htt
From: Antonio Ospite
The configure script breaks when the qemu source directory is in a path
containing white spaces, in particular the list of targets is not
correctly generated when calling "./configure --help".
To avoid this issue, refuse to run the configure script if there
I am OK with just checking and complaining.
Linux too solves the problem in this way:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/Makefile?id=51193b76bfff5027cf96ba63effae808ad67cca7
A general "shellcheck" pass wouldn't hurt, tho.
Thank you,
Antonio
--
You
Public bug reported:
Hi,
I noticed that the configure script breaks when the qemu source
directory is in a path containing white spaces, in particular the list
of targets is not correctly generated when calling "./configure --help".
Steps to reproduce the problem:
$ mkdir "dir with spaces"
$
17 matches
Mail list logo
