Re: [PATCH v14 6/7] migration: Include migration support for machine check handling

2019-09-25 Thread Aravinda Prasad
On Wednesday 25 September 2019 07:09 AM, David Gibson wrote: > On Wed, Sep 18, 2019 at 01:42:51PM +0530, Aravinda Prasad wrote: >> This patch includes migration support for machine check >> handling. Especially this patch blocks VM migration >> requests until the machine

Re: [PATCH v14 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-25 Thread Aravinda Prasad
On Wednesday 25 September 2019 07:03 AM, David Gibson wrote: > On Wed, Sep 18, 2019 at 01:42:43PM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The m

Re: [PATCH v14 4/7] target/ppc: Build rtas error log upon an MCE

2019-09-25 Thread Aravinda Prasad
On Wednesday 25 September 2019 07:00 AM, David Gibson wrote: > On Wed, Sep 18, 2019 at 01:42:34PM +0530, Aravinda Prasad wrote: >> Upon a machine check exception (MCE) in a guest address space, >> KVM causes a guest exit to enable QEMU to build and pass the >> error to

Re: [PATCH v14 2/7] ppc: spapr: Introduce FWNMI capability

2019-09-24 Thread Aravinda Prasad
On Wednesday 25 September 2019 06:42 AM, David Gibson wrote: > On Wed, Sep 18, 2019 at 01:42:17PM +0530, Aravinda Prasad wrote: >> Introduce the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a ma

[Qemu-devel] [PATCH v14 0/7] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-09-18 Thread Aravinda Prasad
Change Log v10: - Reshuffled the patch sequence + minor fixes Change Log v9: - Fixed kvm cap and spapr cap issues Change Log v8: - Added functionality to check FWNMI capability during VM migration --- Aravinda Prasad (7): Wrapper function to wait on condition for the main loop mutex

[Qemu-devel] [PATCH v14 6/7] migration: Include migration support for machine check handling

2019-09-18 Thread Aravinda Prasad
This patch includes migration support for machine check handling. Especially this patch blocks VM migration requests until the machine check error handling is complete as these errors are specific to the source hardware and is irrelevant on the target hardware. Signed-off-by: Aravinda Prasad

[Qemu-devel] [PATCH v14 7/7] ppc: spapr: Activate the FWNMI functionality

2019-09-18 Thread Aravinda Prasad
This patch sets the default value of SPAPR_CAP_FWNMI_MCE to SPAPR_CAP_ON for machine type 4.2. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index a72a4b1..b6a249f 100644 --- a/hw/ppc

[Qemu-devel] [PATCH v14 5/7] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-18 Thread Aravinda Prasad
the first processor is done reading the error log. The first processor issues "ibm,nmi-interlock" call when the error log is consumed. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |9 hw/ppc/spapr_rtas.c| 57 +

[Qemu-devel] [PATCH v14 1/7] Wrapper function to wait on condition for the main loop mutex

2019-09-18 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad

[Qemu-devel] [PATCH v14 3/7] target/ppc: Handle NMI guest exit

2019-09-18 Thread Aravinda Prasad
in such cases. This patch handles KVM_EXIT_NMI exit. [1] https://www.spinics.net/lists/kvm-ppc/msg12637.html (e20bbd3d and related commits) Signed-off-by: Aravinda Prasad Reviewed-by: David Gibson Reviewed-by: Greg Kurz --- hw/ppc/spapr.c |8 hw/ppc/spapr_events.c

[Qemu-devel] [PATCH v14 2/7] ppc: spapr: Introduce FWNMI capability

2019-09-18 Thread Aravinda Prasad
also introduces fwnmi-mce capability to deal with the case when a guest with the KVM_CAP_PPC_FWNMI capability enabled is attempted to migrate to a host that does not support this capability. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |1 + hw/ppc/spapr_caps.c| 29

[Qemu-devel] [PATCH v14 4/7] target/ppc: Build rtas error log upon an MCE

2019-09-18 Thread Aravinda Prasad
, the guest performs recovery actions and logs the error. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 13 +++ hw/ppc/spapr_events.c | 222 hw/ppc/spapr_rtas.c| 26 ++ include/hw/ppc/spapr.h |6 + target/ppc/kvm.c

Re: [Qemu-devel] [PATCH v13 6/6] migration: Include migration support for machine check handling

2019-09-11 Thread Aravinda Prasad
u for your time for reviewing my patches. > > On Mon, 09 Sep 2019 12:55:02 +0530 > Aravinda Prasad wrote: > >> This patch includes migration support for machine check >> handling. Especially this patch blocks VM migration >> requests until the machine check erro

Re: [Qemu-devel] [PATCH v13 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-11 Thread Aravinda Prasad
On Monday 09 September 2019 08:49 PM, Greg Kurz wrote: > On Mon, 09 Sep 2019 12:54:53 +0530 > Aravinda Prasad wrote: > >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls and sets the default >&g

[Qemu-devel] [PATCH v13 4/6] target/ppc: Build rtas error log upon an MCE

2019-09-09 Thread Aravinda Prasad
, the guest performs recovery actions and logs the error. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 13 +++ hw/ppc/spapr_events.c | 222 hw/ppc/spapr_rtas.c| 26 ++ include/hw/ppc/spapr.h |6 + target/ppc/kvm.c

[Qemu-devel] [PATCH v13 6/6] migration: Include migration support for machine check handling

2019-09-09 Thread Aravinda Prasad
corruption and should be handled before migration. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 44 hw/ppc/spapr_events.c | 14 ++ hw/ppc/spapr_rtas.c|2 ++ include/hw/ppc/spapr.h |2 ++ 4 files changed, 62

[Qemu-devel] [PATCH v13 3/6] target/ppc: Handle NMI guest exit

2019-09-09 Thread Aravinda Prasad
in such cases. This patch handles KVM_EXIT_NMI exit. [1] https://www.spinics.net/lists/kvm-ppc/msg12637.html (e20bbd3d and related commits) Signed-off-by: Aravinda Prasad Reviewed-by: David Gibson Reviewed-by: Greg Kurz --- hw/ppc/spapr.c |8 hw/ppc/spapr_events.c

[Qemu-devel] [PATCH v13 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-09 Thread Aravinda Prasad
terlock" call. The second processor that also received a machine check error waits till the first processor is done reading the error log. The first processor issues "ibm,nmi-interlock" call when the error log is consumed. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.

[Qemu-devel] [PATCH v13 2/6] ppc: spapr: Introduce FWNMI capability

2019-09-09 Thread Aravinda Prasad
also introduces fwnmi-mce capability to deal with the case when a guest with the KVM_CAP_PPC_FWNMI capability enabled is attempted to migrate to a host that does not support this capability. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |1 + hw/ppc/spapr_caps.c| 29

[Qemu-devel] [PATCH v13 1/6] Wrapper function to wait on condition for the main loop mutex

2019-09-09 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad

[Qemu-devel] [PATCH v13 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-09-09 Thread Aravinda Prasad
cap issues Change Log v8: - Added functionality to check FWNMI capability during VM migration --- Aravinda Prasad (6): Wrapper function to wait on condition for the main loop mutex ppc: spapr: Introduce FWNMI capability target/ppc: Handle NMI guest exit target/ppc

Re: [Qemu-devel] [PATCH v12 4/6] target/ppc: Build rtas error log upon an MCE

2019-09-03 Thread Aravinda Prasad
On Tuesday 03 September 2019 03:36 PM, Greg Kurz wrote: > On Fri, 30 Aug 2019 14:43:58 +0530 > Aravinda Prasad wrote: > >> Upon a machine check exception (MCE) in a guest address space, >> KVM causes a guest exit to enable QEMU to build and pass the >> error to th

Re: [Qemu-devel] [PATCH v12 2/6] ppc: spapr: Introduce FWNMI capability

2019-09-03 Thread Aravinda Prasad
On Tuesday 03 September 2019 01:26 PM, Greg Kurz wrote: > On Tue, 3 Sep 2019 12:52:39 +0530 > Aravinda Prasad wrote: > >> >> >> On Friday 30 August 2019 07:28 PM, Greg Kurz wrote: >>> On Fri, 30 Aug 2019 14:43:40 +0530 >>> Aravinda Prasad

Re: [Qemu-devel] [PATCH v12 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-09-03 Thread Aravinda Prasad
On Friday 30 August 2019 10:38 PM, Greg Kurz wrote: > On Fri, 30 Aug 2019 14:44:07 +0530 > Aravinda Prasad wrote: > >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls and sets the default >&g

Re: [Qemu-devel] [PATCH v12 2/6] ppc: spapr: Introduce FWNMI capability

2019-09-03 Thread Aravinda Prasad
On Friday 30 August 2019 07:28 PM, Greg Kurz wrote: > On Fri, 30 Aug 2019 14:43:40 +0530 > Aravinda Prasad wrote: > >> Introduce the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a machine check

[Qemu-devel] [PATCH v12 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-08-30 Thread Aravinda Prasad
terlock" call. The second processor that also received a machine check error waits till the first processor is done reading the error log. The first processor issues "ibm,nmi-interlock" call when the error log is consumed. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.

[Qemu-devel] [PATCH v12 6/6] migration: Include migration support for machine check handling

2019-08-30 Thread Aravinda Prasad
corruption and should be handled before migration. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 44 hw/ppc/spapr_events.c | 14 ++ hw/ppc/spapr_rtas.c|2 ++ include/hw/ppc/spapr.h |2 ++ 4 files changed, 62

[Qemu-devel] [PATCH v12 4/6] target/ppc: Build rtas error log upon an MCE

2019-08-30 Thread Aravinda Prasad
, the guest performs recovery actions and logs the error. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 13 +++ hw/ppc/spapr_events.c | 233 hw/ppc/spapr_rtas.c| 26 + include/hw/ppc/spapr.h |6 + target/ppc/kvm.c

[Qemu-devel] [PATCH v12 3/6] target/ppc: Handle NMI guest exit

2019-08-30 Thread Aravinda Prasad
in such cases. This patch handles KVM_EXIT_NMI exit. [1] https://www.spinics.net/lists/kvm-ppc/msg12637.html (e20bbd3d and related commits) Signed-off-by: Aravinda Prasad Reviewed-by: David Gibson --- hw/ppc/spapr.c |8 hw/ppc/spapr_events.c | 24

[Qemu-devel] [PATCH v12 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-08-30 Thread Aravinda Prasad
--- Aravinda Prasad (6): Wrapper function to wait on condition for the main loop mutex ppc: spapr: Introduce FWNMI capability target/ppc: Handle NMI guest exit target/ppc: Build rtas error log upon an MCE ppc: spapr: Handle "ibm,nmi-register" and "ibm,nmi-

[Qemu-devel] [PATCH v12 2/6] ppc: spapr: Introduce FWNMI capability

2019-08-30 Thread Aravinda Prasad
also introduces fwnmi-mce capability to deal with the case when a guest with the KVM_CAP_PPC_FWNMI capability enabled is attempted to migrate to a host that does not support this capability. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |1 + hw/ppc/spapr_caps.c| 29

[Qemu-devel] [PATCH v12 1/6] Wrapper function to wait on condition for the main loop mutex

2019-08-30 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad

Re: [Qemu-devel] [Qemu-ppc] [patch-for-4.2 PATCH v11 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-08-29 Thread Aravinda Prasad
On Thursday 29 August 2019 03:51 PM, Greg Kurz wrote: > On Wed, 14 Aug 2019 11:40:50 +0530 > Aravinda Prasad wrote: > >> This patch set adds support for FWNMI in PowerKVM guests. >> >> System errors such as SLB multihit and memory errors >> that cannot b

[Qemu-devel] [patch-for-4.2 PATCH v11 6/6] migration: Include migration support for machine check handling

2019-08-14 Thread Aravinda Prasad
corruption and should be handled before migration. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 44 hw/ppc/spapr_events.c | 14 ++ hw/ppc/spapr_rtas.c|2 ++ include/hw/ppc/spapr.h |2 ++ 4 files changed, 62

[Qemu-devel] [patch-for-4.2 PATCH v11 3/6] target/ppc: Handle NMI guest exit

2019-08-14 Thread Aravinda Prasad
in such cases. This patch handles KVM_EXIT_NMI exit. [1] https://www.spinics.net/lists/kvm-ppc/msg12637.html (e20bbd3d and related commits) Signed-off-by: Aravinda Prasad Reviewed-by: David Gibson --- hw/ppc/spapr.c |8 hw/ppc/spapr_events.c | 23

[Qemu-devel] [patch-for-4.2 PATCH v11 2/6] ppc: spapr: Introduce FWNMI capability

2019-08-14 Thread Aravinda Prasad
also introduces fwnmi-mce capability to deal with the case when a guest with the KVM_CAP_PPC_FWNMI capability enabled is attempted to migrate to a host that does not support this capability. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |1 + hw/ppc/spapr_caps.c| 29

[Qemu-devel] [patch-for-4.2 PATCH v11 5/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-08-14 Thread Aravinda Prasad
terlock" call. The second processor that also received a machine check error waits till the first processor is done reading the error log. The first processor issues "ibm,nmi-interlock" call when the error log is consumed. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c

[Qemu-devel] [patch-for-4.2 PATCH v11 4/6] target/ppc: Build rtas error log upon an MCE

2019-08-14 Thread Aravinda Prasad
, the guest performs recovery actions and logs the error. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 13 +++ hw/ppc/spapr_events.c | 233 hw/ppc/spapr_rtas.c| 26 + include/hw/ppc/spapr.h |6 + target/ppc/cpu.h

[Qemu-devel] [patch-for-4.2 PATCH v11 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-08-14 Thread Aravinda Prasad
KVM capability Change Log v10: - Reshuffled the patch sequence + minor fixes Change Log v9: - Fixed kvm cap and spapr cap issues Change Log v8: - Added functionality to check FWNMI capability during VM migration --- Aravinda Prasad (6): Wrapper function to wait on condition

[Qemu-devel] [patch-for-4.2 PATCH v11 1/6] Wrapper function to wait on condition for the main loop mutex

2019-08-14 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries REPOST] pseries: Update SLOF firmware image

2019-08-13 Thread Aravinda Prasad
On Tuesday 13 August 2019 07:47 PM, David Gibson wrote: > On Tue, Aug 13, 2019 at 01:00:24PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 12 August 2019 03:38 PM, David Gibson wrote: >>> On Mon, Aug 05, 2019 at 02:14:39PM +0530, Aravinda P

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries REPOST] pseries: Update SLOF firmware image

2019-08-13 Thread Aravinda Prasad
On Monday 12 August 2019 03:38 PM, David Gibson wrote: > On Mon, Aug 05, 2019 at 02:14:39PM +0530, Aravinda Prasad wrote: >> Alexey/David, >> >> With the SLOF changes, QEMU cannot resize the RTAS blob. Resizing is >> required for FWNMI support which extends the RTAS

Re: [Qemu-devel] [Qemu-ppc] [GIT PULL for qemu-pseries REPOST] pseries: Update SLOF firmware image

2019-08-05 Thread Aravinda Prasad
Alexey/David, With the SLOF changes, QEMU cannot resize the RTAS blob. Resizing is required for FWNMI support which extends the RTAS blob to include an error log upon a machine check. The check to valid RTAS buffer fails in the guest because the rtas-size updated in QEMU is not reflecting in the

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-08 Thread Aravinda Prasad
On Friday 05 July 2019 06:53 PM, Greg Kurz wrote: > On Fri, 5 Jul 2019 16:49:17 +0530 > Aravinda Prasad wrote: > >> >> >> On Friday 05 July 2019 06:37 AM, David Gibson wrote: >>> On Thu, Jul 04, 2019 at 10:33:11AM +0530, Aravinda Prasad wrote: >>>

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-05 Thread Aravinda Prasad
On Friday 05 July 2019 06:37 AM, David Gibson wrote: > On Thu, Jul 04, 2019 at 10:33:11AM +0530, Aravinda Prasad wrote: >> >> >> On Thursday 04 July 2019 06:37 AM, David Gibson wrote: >>> On Wed, Jul 03, 2019 at 02:58:24PM +0530, Aravinda Prasad wrote: >>&g

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-05 Thread Aravinda Prasad
On Friday 05 July 2019 12:07 AM, Greg Kurz wrote: > On Thu, 4 Jul 2019 10:49:05 +0530 > Aravinda Prasad wrote: > >> >> >> On Thursday 04 July 2019 06:42 AM, David Gibson wrote: >>> On Wed, Jul 03, 2019 at 02:30:31PM +0530, Aravinda Prasad wrote: >>&g

Re: [Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-03 Thread Aravinda Prasad
On Thursday 04 July 2019 06:42 AM, David Gibson wrote: > On Wed, Jul 03, 2019 at 02:30:31PM +0530, Aravinda Prasad wrote: >> >> >> On Wednesday 03 July 2019 08:50 AM, David Gibson wrote: >>> On Tue, Jul 02, 2019 at 04:10:08PM +0530, Aravinda Prasad wrote: >>

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-03 Thread Aravinda Prasad
On Thursday 04 July 2019 06:37 AM, David Gibson wrote: > On Wed, Jul 03, 2019 at 02:58:24PM +0530, Aravinda Prasad wrote: >> >> >> On Wednesday 03 July 2019 08:33 AM, David Gibson wrote: >>> On Tue, Jul 02, 2019 at 11:54:26AM +0530, Aravinda Prasad wrote: >>

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-03 Thread Aravinda Prasad
On Wednesday 03 July 2019 08:33 AM, David Gibson wrote: > On Tue, Jul 02, 2019 at 11:54:26AM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 02 July 2019 09:21 AM, David Gibson wrote: >>> On Wed, Jun 12, 2019 at 02:51:04PM +0530, Aravinda Prasad wrote: >

Re: [Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-03 Thread Aravinda Prasad
On Wednesday 03 July 2019 08:50 AM, David Gibson wrote: > On Tue, Jul 02, 2019 at 04:10:08PM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 02 July 2019 09:41 AM, David Gibson wrote: >>> On Wed, Jun 12, 2019 at 02:51:38PM +0530, Aravinda Prasad wrote: >&g

Re: [Qemu-devel] [PATCH v10 4/6] target/ppc: Build rtas error log upon an MCE

2019-07-03 Thread Aravinda Prasad
On Wednesday 03 July 2019 08:37 AM, David Gibson wrote: > On Tue, Jul 02, 2019 at 03:19:24PM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 02 July 2019 09:33 AM, David Gibson wrote: >>> On Wed, Jun 12, 2019 at 02:51:21PM +0530, Aravinda Prasad wrote: >>&g

Re: [Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-07-02 Thread Aravinda Prasad
On Tuesday 02 July 2019 09:41 AM, David Gibson wrote: > On Wed, Jun 12, 2019 at 02:51:38PM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls and sets the default >> val

Re: [Qemu-devel] [PATCH v10 4/6] target/ppc: Build rtas error log upon an MCE

2019-07-02 Thread Aravinda Prasad
On Tuesday 02 July 2019 09:33 AM, David Gibson wrote: > On Wed, Jun 12, 2019 at 02:51:21PM +0530, Aravinda Prasad wrote: >> Upon a machine check exception (MCE) in a guest address space, >> KVM causes a guest exit to enable QEMU to build and pass the >> error to the gues

Re: [Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-07-02 Thread Aravinda Prasad
On Tuesday 02 July 2019 09:21 AM, David Gibson wrote: > On Wed, Jun 12, 2019 at 02:51:04PM +0530, Aravinda Prasad wrote: >> Introduce the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a ma

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-25 Thread Aravinda Prasad
On Tuesday 25 June 2019 12:30 PM, Greg Kurz wrote: > On Tue, 25 Jun 2019 11:46:06 +0530 > Aravinda Prasad wrote: > >> On Monday 24 June 2019 07:59 PM, Greg Kurz wrote: >>> On Wed, 12 Jun 2019 14:51:38 +0530 >>> Aravinda Prasad wrote: >>> >>&

Re: [Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-25 Thread Aravinda Prasad
On Monday 24 June 2019 07:59 PM, Greg Kurz wrote: > On Wed, 12 Jun 2019 14:51:38 +0530 > Aravinda Prasad wrote: > >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls and sets the default >&g

[Qemu-devel] [PATCH v10 2/6] ppc: spapr: Introduce FWNMI capability

2019-06-12 Thread Aravinda Prasad
also introduces fwnmi-mce capability to deal with the case when a guest with the KVM_CAP_PPC_FWNMI capability enabled is attempted to migrate to a host that does not support this capability. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |1 + hw/ppc/spapr_caps.c| 26

[Qemu-devel] [PATCH v10 3/6] target/ppc: Handle NMI guest exit

2019-06-12 Thread Aravinda Prasad
in such cases. This patch handles KVM_EXIT_NMI exit. [1] https://www.spinics.net/lists/kvm-ppc/msg12637.html (e20bbd3d and related commits) Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |8 hw/ppc/spapr_events.c | 23 +++ include/hw/ppc

[Qemu-devel] [PATCH v10 6/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-12 Thread Aravinda Prasad
terlock" call. The second processor that also received a machine check error waits till the first processor is done reading the error log. The first processor issues "ibm,nmi-interlock" call when the error log is consumed. Signed-off-by: Aravinda Prasad --- hw/ppc

[Qemu-devel] [PATCH v10 5/6] migration: Include migration support for machine check handling

2019-06-12 Thread Aravinda Prasad
corruption and should be handled before migration. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 27 +++ hw/ppc/spapr_events.c | 14 ++ include/hw/ppc/spapr.h |2 ++ 3 files changed, 43 insertions(+) diff --git a/hw/ppc/spapr.c b/hw/ppc

[Qemu-devel] [PATCH v10 1/6] Wrapper function to wait on condition for the main loop mutex

2019-06-12 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad

[Qemu-devel] [PATCH v10 4/6] target/ppc: Build rtas error log upon an MCE

2019-06-12 Thread Aravinda Prasad
, the guest performs recovery actions and logs the error. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 13 +++ hw/ppc/spapr_events.c | 238 hw/ppc/spapr_rtas.c| 26 + include/hw/ppc/spapr.h |6 + target/ppc/kvm.c

[Qemu-devel] [PATCH v10 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-06-12 Thread Aravinda Prasad
cap issues Change Log v8: - Added functionality to check FWNMI capability during VM migration --- Aravinda Prasad (6): Wrapper function to wait on condition for the main loop mutex ppc: spapr: Introduce FWNMI capability target/ppc: Handle NMI guest exit target/ppc

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Aravinda Prasad
On Thursday 06 June 2019 08:36 AM, David Gibson wrote: > On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: >> This patch includes migration support for machine check >> handling. Especially this patch blocks VM migration >> requests until the machine

Re: [Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-06 Thread Aravinda Prasad
On Thursday 06 June 2019 11:36 AM, Greg Kurz wrote: > On Thu, 6 Jun 2019 13:06:14 +1000 > David Gibson wrote: > >> On Wed, May 29, 2019 at 11:10:57AM +0530, Aravinda Prasad wrote: >>> This patch includes migration support for machine check >>> handling

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-06-06 Thread Aravinda Prasad
On Thursday 06 June 2019 08:32 AM, David Gibson wrote: > On Tue, Jun 04, 2019 at 12:15:26PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 03 June 2019 08:55 PM, Greg Kurz wrote: >>> On Wed, 29 May 2019 11:10:49 +0530 >>> Aravinda Prasad wr

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 07:04 AM, David Gibson wrote: > On Wed, May 29, 2019 at 11:10:14AM +0530, Aravinda Prasad wrote: >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The machine che

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-05 Thread Aravinda Prasad
On Tuesday 04 June 2019 08:20 PM, Greg Kurz wrote: > On Tue, 4 Jun 2019 11:38:31 +0530 > Aravinda Prasad wrote: > >> On Monday 03 June 2019 04:47 PM, Greg Kurz wrote: >>> On Mon, 3 Jun 2019 12:12:43 +0200 >>> Greg Kurz wrote: >>> >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 08:32 AM, David Gibson wrote: > On Tue, Jun 04, 2019 at 12:15:26PM +0530, Aravinda Prasad wrote: >> >> >> On Monday 03 June 2019 08:55 PM, Greg Kurz wrote: >>> On Wed, 29 May 2019 11:10:49 +0530 >>> Aravinda Prasad wr

Re: [Qemu-devel] [PATCH v9 3/6] target/ppc: Handle NMI guest exit

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 07:13 AM, David Gibson wrote: > On Wed, May 29, 2019 at 11:10:32AM +0530, Aravinda Prasad wrote: >> Memory error such as bit flips that cannot be corrected >> by hardware are passed on to the kernel for handling. >> If the memory address in e

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-05 Thread Aravinda Prasad
On Thursday 06 June 2019 07:05 AM, David Gibson wrote: > On Mon, Jun 03, 2019 at 01:17:23PM +0200, Greg Kurz wrote: >> On Mon, 3 Jun 2019 12:12:43 +0200 >> Greg Kurz wrote: >> >>> On Wed, 29 May 2019 11:10:14 +0530 >>> Aravinda Prasad wrote: >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 4/6] target/ppc: Build rtas error log upon an MCE

2019-06-04 Thread Aravinda Prasad
On Tuesday 04 June 2019 02:31 PM, Greg Kurz wrote: > On Tue, 4 Jun 2019 11:59:13 +0530 > Aravinda Prasad wrote: > >> On Monday 03 June 2019 07:30 PM, Greg Kurz wrote: >>> On Wed, 29 May 2019 11:10:40 +0530 >>> Aravinda Prasad wrote: >>> >>&g

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-06-04 Thread Aravinda Prasad
On Monday 03 June 2019 09:10 PM, Greg Kurz wrote: > On Wed, 29 May 2019 11:10:57 +0530 > Aravinda Prasad wrote: > >> This patch includes migration support for machine check >> handling. Especially this patch blocks VM migration >> requests until the machine check er

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-06-04 Thread Aravinda Prasad
On Monday 03 June 2019 08:55 PM, Greg Kurz wrote: > On Wed, 29 May 2019 11:10:49 +0530 > Aravinda Prasad wrote: > >> Enable the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a machine check

Re: [Qemu-devel] [PATCH v9 4/6] target/ppc: Build rtas error log upon an MCE

2019-06-04 Thread Aravinda Prasad
On Monday 03 June 2019 07:30 PM, Greg Kurz wrote: > On Wed, 29 May 2019 11:10:40 +0530 > Aravinda Prasad wrote: > >> Upon a machine check exception (MCE) in a guest address space, >> KVM causes a guest exit to enable QEMU to build and pass the >> error to the gue

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-06-04 Thread Aravinda Prasad
On Monday 03 June 2019 04:47 PM, Greg Kurz wrote: > On Mon, 3 Jun 2019 12:12:43 +0200 > Greg Kurz wrote: > >> On Wed, 29 May 2019 11:10:14 +0530 >> Aravinda Prasad wrote: >> >>> This patch adds support in QEMU to handle "ibm,nmi-registe

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-28 Thread Aravinda Prasad
On Friday 10 May 2019 12:21 PM, David Gibson wrote: > On Mon, Apr 22, 2019 at 12:33:45PM +0530, Aravinda Prasad wrote: >> Block VM migration requests until the machine check >> error handling is complete as (i) these errors are >> specific to the source hardw

[Qemu-devel] [PATCH v9 5/6] ppc: spapr: Enable FWNMI capability

2019-05-28 Thread Aravinda Prasad
deals with the case when a guest with the KVM_CAP_PPC_FWNMI capability enabled is attempted to migrate to a host that does not support this capability. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |1 + hw/ppc/spapr_caps.c| 24 hw/ppc/spapr_rtas.c

[Qemu-devel] [PATCH v9 2/6] Wrapper function to wait on condition for the main loop mutex

2019-05-28 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. This wrapper is required because qemu_global_mutex is a static variable. Signed-off-by: Aravinda Prasad

[Qemu-devel] [PATCH v9 6/6] migration: Include migration support for machine check handling

2019-05-28 Thread Aravinda Prasad
corruption and should be handled before migration. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c | 20 hw/ppc/spapr_events.c | 17 + hw/ppc/spapr_rtas.c|4 include/hw/ppc/spapr.h |2 ++ 4 files changed, 43 insertions(+) diff

[Qemu-devel] [PATCH v9 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-05-28 Thread Aravinda Prasad
the first processor is done reading the error log. The first processor issues "ibm,nmi-interlock" call when the error log is consumed. This patch implements the releasing part of the error-log while subsequent patch (which builds error log) handles the locking part. Signed-off-by: Ara

[Qemu-devel] [PATCH v9 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-28 Thread Aravinda Prasad
, the guest performs recovery actions and logs the error. Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |5 + hw/ppc/spapr_events.c | 236 include/hw/ppc/spapr.h |4 + 3 files changed, 245 insertions(+) diff --git a/hw/ppc/spapr.c b

[Qemu-devel] [PATCH v9 3/6] target/ppc: Handle NMI guest exit

2019-05-28 Thread Aravinda Prasad
in such cases. This patch handles KVM_EXIT_NMI exit. [1] https://www.spinics.net/lists/kvm-ppc/msg12637.html (e20bbd3d and related commits) Signed-off-by: Aravinda Prasad --- hw/ppc/spapr.c |1 + hw/ppc/spapr_events.c | 23 +++ hw/ppc/spapr_rtas.c

[Qemu-devel] [PATCH v9 0/6] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2019-05-28 Thread Aravinda Prasad
is in progress. --- Aravinda Prasad (6): ppc: spapr: Handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls Wrapper function to wait on condition for the main loop mutex target/ppc: Handle NMI guest exit target/ppc: Build rtas error log upon an

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-19 Thread Aravinda Prasad
On Thursday 16 May 2019 07:47 PM, Dr. David Alan Gilbert wrote: > * Aravinda Prasad (aravi...@linux.vnet.ibm.com) wrote: >> >> >> On Thursday 16 May 2019 04:24 PM, Greg Kurz wrote: >>> On Mon, 22 Apr 2019 12:33:45 +0530 >>> Aravinda Prasad wrote: >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-16 Thread Aravinda Prasad
On Thursday 16 May 2019 04:24 PM, Greg Kurz wrote: > On Mon, 22 Apr 2019 12:33:45 +0530 > Aravinda Prasad wrote: > >> Block VM migration requests until the machine check >> error handling is complete as (i) these errors are >> specific to the source hardware and is

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability

2019-05-15 Thread Aravinda Prasad
On Thursday 16 May 2019 07:15 AM, David Gibson wrote: > On Tue, May 14, 2019 at 11:02:07AM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 14 May 2019 10:17 AM, David Gibson wrote: >>> On Mon, May 13, 2019 at 04:00:43PM +0530, Aravinda Prasad wrote: >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-15 Thread Aravinda Prasad
On Thursday 16 May 2019 07:17 AM, David Gibson wrote: > On Tue, May 14, 2019 at 10:36:17AM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 14 May 2019 10:10 AM, David Gibson wrote: >>> On Tue, May 14, 2019 at 09:56:41AM +0530, Aravinda Prasad wrote: >>>&

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability

2019-05-13 Thread Aravinda Prasad
On Tuesday 14 May 2019 10:17 AM, David Gibson wrote: > On Mon, May 13, 2019 at 04:00:43PM +0530, Aravinda Prasad wrote: >> >> >> On Friday 10 May 2019 03:23 PM, David Gibson wrote: >>> On Fri, May 10, 2019 at 12:45:29PM +0530, Aravinda Prasad wrote: >>>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread Aravinda Prasad
On Tuesday 14 May 2019 10:10 AM, David Gibson wrote: > On Tue, May 14, 2019 at 09:56:41AM +0530, Aravinda Prasad wrote: >> >> >> On Tuesday 14 May 2019 05:38 AM, David Gibson wrote: >>> On Mon, May 13, 2019 at 01:30:53PM +0200, Greg Kurz wrote: >>&

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-13 Thread Aravinda Prasad
On Tuesday 14 May 2019 05:38 AM, David Gibson wrote: > On Mon, May 13, 2019 at 01:30:53PM +0200, Greg Kurz wrote: >> On Mon, 22 Apr 2019 12:33:26 +0530 >> Aravinda Prasad wrote: >> >>> Upon a machine check exception (MCE) in a guest address space, >>>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability

2019-05-13 Thread Aravinda Prasad
On Friday 10 May 2019 03:23 PM, David Gibson wrote: > On Fri, May 10, 2019 at 12:45:29PM +0530, Aravinda Prasad wrote: >> >> >> On Friday 10 May 2019 12:16 PM, David Gibson wrote: >>> On Mon, Apr 22, 2019 at 12:33:35PM +0530, Aravinda Prasad wrote:

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 3/6] target/ppc: Handle NMI guest exit

2019-05-12 Thread Aravinda Prasad
On Friday 10 May 2019 09:55 PM, Greg Kurz wrote: > On Mon, 22 Apr 2019 12:33:16 +0530 > Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected >> by hardware are passed on to the kernel for handling. >> If the memory addres

Re: [Qemu-devel] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-12 Thread Aravinda Prasad
On Friday 10 May 2019 03:22 PM, David Gibson wrote: > On Fri, May 10, 2019 at 12:35:13PM +0530, Aravinda Prasad wrote: >> >> >> On Friday 10 May 2019 12:12 PM, David Gibson wrote: >>> On Mon, Apr 22, 2019 at 12:33:26PM +0530, Aravinda Prasad wrote: [...] >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-05-12 Thread Aravinda Prasad
On Friday 10 May 2019 08:03 PM, Greg Kurz wrote: > On Fri, 10 May 2019 11:06:04 +0200 > Greg Kurz wrote: > >> On Mon, 22 Apr 2019 12:32:58 +0530 >> Aravinda Prasad wrote: >> >>> This patch adds support in QEMU to handle "ibm,nmi-registe

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 1/6] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2019-05-12 Thread Aravinda Prasad
On Friday 10 May 2019 02:36 PM, Greg Kurz wrote: > On Mon, 22 Apr 2019 12:32:58 +0530 > Aravinda Prasad wrote: > >> This patch adds support in QEMU to handle "ibm,nmi-register" >> and "ibm,nmi-interlock" RTAS calls. >> >> The machine chec

Re: [Qemu-devel] [PATCH v8 6/6] migration: Block migration while handling machine check

2019-05-10 Thread Aravinda Prasad
On Friday 10 May 2019 12:21 PM, David Gibson wrote: > On Mon, Apr 22, 2019 at 12:33:45PM +0530, Aravinda Prasad wrote: >> Block VM migration requests until the machine check >> error handling is complete as (i) these errors are >> specific to the source hardw

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 5/6] ppc: spapr: Enable FWNMI capability

2019-05-10 Thread Aravinda Prasad
On Friday 10 May 2019 12:16 PM, David Gibson wrote: > On Mon, Apr 22, 2019 at 12:33:35PM +0530, Aravinda Prasad wrote: >> Enable the KVM capability KVM_CAP_PPC_FWNMI so that >> the KVM causes guest exit with NMI as exit reason >> when it encounters a machine check except

Re: [Qemu-devel] [PATCH v8 4/6] target/ppc: Build rtas error log upon an MCE

2019-05-10 Thread Aravinda Prasad
On Friday 10 May 2019 12:12 PM, David Gibson wrote: > On Mon, Apr 22, 2019 at 12:33:26PM +0530, Aravinda Prasad wrote: >> Upon a machine check exception (MCE) in a guest address space, >> KVM causes a guest exit to enable QEMU to build and pass the >> error to the guest in

Re: [Qemu-devel] [Qemu-ppc] [PATCH v8 3/6] target/ppc: Handle NMI guest exit

2019-05-10 Thread Aravinda Prasad
On Friday 10 May 2019 12:07 PM, David Gibson wrote: > On Wed, Apr 24, 2019 at 10:20:42AM +0530, Aravinda Prasad wrote: > 65;5601;1c> >> >> On Tuesday 23 April 2019 12:23 PM, David Gibson wrote: >>> On Mon, Apr 22, 2019 at 12:33:16PM +0530, Aravinda Prasad wrote:

  1   2   3   >