The Saturday 26 Jul 2014 à 21:22:08 (+0200), Max Reitz wrote :
The only really time-consuming operation potentially performed by
qcow2_amend_options() is zero cluster expansion when downgrading qcow2
images from compat=1.1 to compat=0.10, so report status of that
operation and that operation
The Thursday 31 Jul 2014 à 09:51:05 (+0200), Benoît Canet wrote :
The Saturday 26 Jul 2014 à 21:22:05 (+0200), Max Reitz wrote :
Depending on the changed options and the image format,
bdrv_amend_options() may take a significant amount of time. In these
cases, a way to be informed about
The Saturday 26 Jul 2014 à 21:22:09 (+0200), Max Reitz wrote :
Reading the refcount of a cluster is an operation which can be useful in
all of the qcow2 code, so make that function globally available.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2-refcount.c | 23
The Saturday 26 Jul 2014 à 21:22:10 (+0200), Max Reitz wrote :
Currently, we have a bitmap for keeping track of which clusters have
been created during the zero cluster expansion process. This was
necessary because we need to properly increase the refcount for shared
L2 tables.
However,
The Saturday 26 Jul 2014 à 21:22:11 (+0200), Max Reitz wrote :
Add some tests for progress output to 061.
Signed-off-by: Max Reitz mre...@redhat.com
---
tests/qemu-iotests/061 | 27 +++
tests/qemu-iotests/061.out | 32
This header will allow to split monitor in two parts.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
include/monitor/monitor-system.h | 99
monitor.c| 57 ++-
2 files changed, 102 insertions(+), 54
Next commits will split monitor.c in monitor.c and monitor-system.c.
Change some function from static to public in order to prepare this.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
include/monitor/monitor.h | 10 ++
monitor.c | 24 ++--
2
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor-system.c | 43 +++
monitor.c| 44
2 files changed, 43 insertions(+), 44 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
index
Compile and link QAPI block core code into qemu-nbd.
This patch circle around unwanted dependecies by stubing some functions in
the stubs directory.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
Makefile| 33 +++--
Makefile.objs
Signed-off-by: Benoit Canet ben...@irqsave.net
---
disas.c | 10 --
include/monitor/monitor.h | 2 ++
monitor.c | 4 ++--
3 files changed, 4 insertions(+), 12 deletions(-)
diff --git a/disas.c b/disas.c
index 44a019a..b174f26 100644
--- a/disas.c
+++
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor-system.c | 69
monitor.c| 69
2 files changed, 69 insertions(+), 69 deletions(-)
diff --git a/monitor-system.c
Signed-off-by: Benoit Canet ben...@irqsave.net
---
include/monitor/monitor-system.h | 1 +
monitor.c| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/monitor/monitor-system.h b/include/monitor/monitor-system.h
index 6cbf2a4..76d87c7 100644
---
Signed-off-by: Benoit Canet ben...@irqsave.net
---
include/monitor/monitor-system.h | 1 +
monitor.c| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/monitor/monitor-system.h b/include/monitor/monitor-system.h
index 2e98091..3bc7167 100644
---
With this move the monitor.c/monitor-system.c split is complete.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor-system.c | 49 +
monitor.c| 49 -
2 files changed, 49 insertions(+),
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor-system.c | 5 +
monitor.c| 5 -
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/monitor-system.c b/monitor-system.c
index 25a132a..f5fb15a 100644
--- a/monitor-system.c
+++ b/monitor-system.c
@@ -231,3
The extracted function are help_cmd, do_help_cmd, do_trace_event_set_state,
and do_trace_file.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor-system.c | 121 +++
monitor.c| 121
This patch will allow to link qmp.o with utility binaries without dragging too
much unrelated object files and externals dependencies.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
Makefile.objs | 2 +-
qmp-system.c | 376 ++
qmp.c
This patch add a -qmp parameter to the qemu-nbd command line in order to be able
to manipulate the qemu-nbd block devices via qmp.
This could be used with containers to easily migrate from qemu to a container.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
Makefile.objs |
Hi,
Here are the follow up patches to the block QAPI extractions patches.
After this patchset the qemu-nbd command has a -qmp parameters allowing the user
to execute block related qmp commands.
Best regards
Benoît
Benoît Canet (24):
qmp: Extract system emulation related code from qmp.c
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index d2e56f8..560d5e4 100644
--- a/monitor.c
+++ b/monitor.c
@@ -173,10 +173,10 @@ static QLIST_HEAD(mon_list, Monitor) mon_list;
Also add sizeof variables for mon_cmd_t arrays for cross modules usage.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor-system.c | 984
monitor.c| 1010 ++
2 files
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor.c | 35 ---
1 file changed, 35 deletions(-)
diff --git a/monitor.c b/monitor.c
index 85484c3..bc7f3d3 100644
--- a/monitor.c
+++ b/monitor.c
@@ -22,64 +22,29 @@
* THE SOFTWARE.
*/
#include dirent.h
Signed-off-by: Benoit Canet ben...@irqsave.net
---
Makefile.target | 1 +
disas.c | 10 ++
include/monitor/monitor-system.h | 3 ++
include/monitor/monitor.h| 2 --
monitor-system.c | 69
This will allow monitor.c to access these functions once they are moved in
monitor-system.c
Signed-off-by: Benoit Canet ben...@irqsave.net
---
include/monitor/monitor-system.h | 37 ++
monitor-system.c | 1163 ++
monitor.c
Since qmp-command-olds.h is generated from qmp-commands.hx we will sometime want
to include only a subset of it. For example when linking qapi block commands
with qemu-nbd.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
Makefile | 7 +++
Signed-off-by: Benoit Canet ben...@irqsave.net
---
monitor-system.c | 283 +++
monitor.c| 281 --
2 files changed, 283 insertions(+), 281 deletions(-)
diff --git a/monitor-system.c
The Monday 21 Jul 2014 à 08:59:45 (-0600), Chris Friesen wrote :
On 07/19/2014 02:45 AM, Benoît Canet wrote:
I think in the throttling case the number of in flight operation is limited
by
the emulated hardware queue. Else request would pile up and throttling would
be
inefective.
So
The Monday 21 Jul 2014 à 09:35:29 (-0600), Chris Friesen wrote :
On 07/21/2014 09:15 AM, Benoît Canet wrote:
The Monday 21 Jul 2014 à 08:59:45 (-0600), Chris Friesen wrote :
On 07/19/2014 02:45 AM, Benoît Canet wrote:
I think in the throttling case the number of in flight operation
The Monday 21 Jul 2014 à 09:35:29 (-0600), Chris Friesen wrote :
On 07/21/2014 09:15 AM, Benoît Canet wrote:
The Monday 21 Jul 2014 à 08:59:45 (-0600), Chris Friesen wrote :
On 07/19/2014 02:45 AM, Benoît Canet wrote:
I think in the throttling case the number of in flight operation
The Monday 21 Jul 2014 à 09:35:29 (-0600), Chris Friesen wrote :
On 07/21/2014 09:15 AM, Benoît Canet wrote:
The Monday 21 Jul 2014 à 08:59:45 (-0600), Chris Friesen wrote :
On 07/19/2014 02:45 AM, Benoît Canet wrote:
I think in the throttling case the number of in flight operation
The Monday 21 Jul 2014 à 15:12:31 (-0600), Chris Friesen wrote :
On 07/21/2014 01:47 PM, Benoît Canet wrote:
The Monday 21 Jul 2014 à 09:35:29 (-0600), Chris Friesen wrote :
On 07/21/2014 09:15 AM, Benoît Canet wrote:
The Monday 21 Jul 2014 à 08:59:45 (-0600), Chris Friesen wrote :
On 07/19
The Saturday 19 Jul 2014 à 09:23:50 (+0200), Paolo Bonzini wrote :
Il 19/07/2014 08:27, Chris Friesen ha scritto:
Does it track in-flight operations though? Or just how many operations
can be requested in a given amount of time?
It should track in flight operations. However, I'm not sure
The Tuesday 15 Jul 2014 à 10:49:31 (-0400), Wolfgang Richter wrote :
The way I see block filter currently implemented is as a special block
device
with `is_filter` set to true.
Is this a correct characterization of the current incarnation?
Yes,
If so, I was wondering if it is possible
The Friday 11 Jul 2014 à 11:01:22 (+0800), Liu Yuan wrote :
This patch adds single read pattern to quorum driver and quorum vote is
default
pattern.
For now we do a quorum vote on all the reads, it is designed for unreliable
underlying storage such as non-redundant NFS to make sure data
This avoid breaking tests on RHEL6 where gnutls is too old for quorum to be
built by default.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
tests/qemu-iotests/041 | 41 +++--
1 file changed, 39 insertions(+), 2 deletions(-)
diff --git
The Monday 30 Jun 2014 à 16:09:57 (+0200), Stefan Hajnoczi wrote :
On Fri, Jun 27, 2014 at 10:17:16PM +0200, Benoît Canet wrote:
I think this patch can be boiled down to 2 lines:
if __name__ == '__main__':
+if 'quorum' not in iotests.qemu_img('--help'):
+iotests.notrun
fe069d9d had aligned code and documentation while dropping the s from the
actual JSON output. Fix that.
This also fix test/qemu-iotest/081 since the missing s was causing a
permutation.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
docs/qmp/qmp-events.txt | 26 +-
The Friday 27 Jun 2014 à 13:57:02 (+0200), Kevin Wolf wrote :
Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben:
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet ben...@irqsave.net
The Friday 27 Jun 2014 à 13:57:02 (+0200), Kevin Wolf wrote :
Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben:
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet ben...@irqsave.net
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block.c | 25
block/mirror.c| 60
The to-replace-node-name is designed to allow repairing a broken Quorum file.
This patch introduces a new class TestRepairQuorum testing that the feature
works.
Some further work will be done on QEMU to improve the robustness of the tests.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
The purpose of this change is to help create a json file containing
common definitions; each bit of generated C code must be emitted
only one time.
A second history global to all QAPISchema instances has been added
to detect when a file is included more than one time and skip these
includes.
It
in V3:
change commit title [Eric]
s/spitted/emitted/
change tests names [Eric]
Benoît Canet (1):
qapi: skip redundant includes
scripts/qapi.py | 14 +++---
tests/Makefile| 3 ++-
tests/qapi-schema
uneeded line break [Kevin]
remove uneeded empty line [Kevin]
Failed to run 041 tests since they are broken before this series.
Benoît Canet (2):
block: Add replaces argument to drive-mirror
qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror
node-name mode.
block.c
The Friday 27 Jun 2014 à 15:37:00 (+0200), Kevin Wolf wrote :
Am 27.06.2014 um 14:53 hat Benoît Canet geschrieben:
The Friday 27 Jun 2014 à 13:57:02 (+0200), Kevin Wolf wrote :
Am 16.06.2014 um 12:00 hat Benoît Canet geschrieben:
drive-mirror will bdrv_swap the new BDS named node-name
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block.c | 25
block/mirror.c| 60
uneeded line break [Kevin]
remove uneeded empty line [Kevin]
Failed to run 041 tests since they are broken before this series.
Benoît Canet (2):
block: Add replaces argument to drive-mirror
qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror
node-name mode.
block.c
The to-replace-node-name is designed to allow repairing a broken Quorum file.
This patch introduces a new class TestRepairQuorum testing that the feature
works.
Some further work will be done on QEMU to improve the robustness of the tests.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
The Friday 27 Jun 2014 à 15:41:50 (+0200), Benoît Canet wrote :
in V3:
change commit title [Eric]
s/spitted/emitted/
change tests names [Eric]
Benoît Canet (1):
qapi: skip redundant includes
scripts/qapi.py | 14
The Friday 27 Jun 2014 à 17:14:33 (+0200), Markus Armbruster wrote :
Benoît Canet benoit.ca...@irqsave.net writes:
The purpose of this change is to help create a json file containing
common definitions; each bit of generated C code must be emitted
only one time.
A second history
The Friday 27 Jun 2014 à 15:47:20 (+0200), Markus Armbruster wrote :
This series plus Paolo's [PATCH for 2.1] qdev: correctly send
DEVICE_DELETED for recursively-deleted devices makes qemu-iotests
check -qcow2 again pass for me.
Luiz offered to take it through his tree.
Markus Armbruster
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block.c | 25
block/mirror.c| 60
The to-replace-node-name is designed to allow repairing a broken Quorum file.
This patch introduces a new class TestRepairQuorum testing that the feature
works.
Some further work will be done on QEMU to improve the robustness of the tests.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
corruption by the user
[Kevin, Benoît]
Propagate error returned by check_to_replace_node [Kevin ]
Remove uneeded line break [Kevin]
remove uneeded empty line [Kevin]
Benoît Canet (2):
block: Add replaces argument to drive-mirror
qemu-iotests: Add TestRepairQuorum to 041
The Friday 27 Jun 2014 à 20:37:34 (+0200), Kevin Wolf wrote :
Am 27.06.2014 um 18:25 hat Benoît Canet geschrieben:
in v2:
Fixed 041.out [Benoît]
Tested 041 on top of markus [PATCH 2.1 0/2] Fix two recent event
regressions
in v1:
no blank line before EOF
This avoid breaking tests on RHEL6 where gnutls is too old for quorum to be
built by default.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
tests/qemu-iotests/041 | 13 +
1 file changed, 13 insertions(+)
diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041
index
This avoid breaking tests on RHEL6 where gnutls is too old for quorum to be
built by default.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
tests/qemu-iotests/041 | 49 +++--
1 file changed, 47 insertions(+), 2 deletions(-)
diff --git
The Tuesday 24 Jun 2014 à 16:08:57 (+0200), Kevin Wolf wrote :
Am 24.06.2014 um 15:32 hat Jeff Cody geschrieben:
On Tue, Jun 24, 2014 at 10:48:52AM +0800, Fam Zheng wrote:
On Mon, 06/23 21:08, Stefan Hajnoczi wrote:
On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote:
On Thu,
The Tuesday 17 Jun 2014 à 17:53:50 (-0400), Jeff Cody wrote :
This is a small helper function, to determine if 'base' is in the
chain of BlockDriverState 'top'. It returns true if it is in the chain,
and false otherwise.
If either argument is NULL, it will also return false.
Reviewed-by:
The Monday 23 Jun 2014 à 21:08:09 (+0800), Stefan Hajnoczi wrote :
On Thu, Jun 19, 2014 at 12:26:00PM -0400, Jeff Cody wrote:
On Thu, Jun 19, 2014 at 05:17:16PM +0800, Stefan Hajnoczi wrote:
On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote:
Let's discuss this topic in a
The Monday 23 Jun 2014 à 17:30:45 (+0200), Kevin Wolf wrote :
Am 12.06.2014 um 14:08 hat Benoît Canet geschrieben:
The Wednesday 11 Jun 2014 à 16:04:55 (+0200), Kevin Wolf wrote :
The idea of bdrv_fill_options() is to convert every parameter for
opening images, in particular the filename
The Monday 23 Jun 2014 à 12:32:30 (+0800), Fam Zheng wrote :
On Sat, 06/21 17:40, Benoît Canet wrote:
The Saturday 21 Jun 2014 à 17:39:11 (+0200), Benoît Canet wrote :
We still have the issue of unlocking the bottom BDS when a subtree is
detached
from the graphs by a swap. (It does
The Saturday 21 Jun 2014 à 16:53:58 (+0800), Fam Zheng wrote :
On Fri, 06/20 09:30, Eric Blake wrote:
On 06/19/2014 11:01 PM, Fam Zheng wrote:
On Thu, 06/19 22:20, Benoît Canet wrote:
The Thursday 19 Jun 2014 à 14:13:20 (-0600), Eric Blake wrote :
On 06/19/2014 02:01 PM, Benoît Canet
The Saturday 21 Jun 2014 à 23:15:19 (+0800), Fam Zheng wrote :
On Sat, 06/21 12:45, Benoît Canet wrote:
The Saturday 21 Jun 2014 à 16:53:58 (+0800), Fam Zheng wrote :
On Fri, 06/20 09:30, Eric Blake wrote:
On 06/19/2014 11:01 PM, Fam Zheng wrote:
On Thu, 06/19 22:20, Benoît Canet
The Saturday 21 Jun 2014 à 17:39:11 (+0200), Benoît Canet wrote :
The Saturday 21 Jun 2014 à 23:15:19 (+0800), Fam Zheng wrote :
On Sat, 06/21 12:45, Benoît Canet wrote:
The Saturday 21 Jun 2014 à 16:53:58 (+0800), Fam Zheng wrote :
On Fri, 06/20 09:30, Eric Blake wrote:
On 06/19
The Thursday 19 Jun 2014 à 17:17:16 (+0800), Stefan Hajnoczi wrote :
On Tue, Jun 17, 2014 at 05:53:48PM -0400, Jeff Cody wrote:
Changes from v5-v6:
* Check for attempt to commit an image to itself (Eric)
* Add a comment to the bdrv_find for block-commit, indicating
that libvirt uses
As the code will start to operate on arbitratry nodes we need the op blocker
to recursively block or unblock whole BDS subtrees.
Also add a function to reset all blocker from a BDS.
This patch also take care of changing blocker user so they are not broken.
Signed-off-by: Benoit Canet
Hi,
Here is my try at making blockers recursives.
It's far from perfect as it break test 040.
Any suggestion to fix the broken test case would be welcome.
Best regards
Benoît
Benoît Canet (1):
block: Make op blocker recursive
block.c | 87
The Thursday 19 Jun 2014 à 14:13:20 (-0600), Eric Blake wrote :
On 06/19/2014 02:01 PM, Benoît Canet wrote:
As the code will start to operate on arbitratry nodes we need the op blocker
s/arbitratry/arbitrary/
to recursively block or unblock whole BDS subtrees.
Also add a function
The Thursday 19 Jun 2014 à 14:26:04 (-0600), Eric Blake wrote :
On 06/19/2014 02:20 PM, Benoît Canet wrote:
This unconditionally removes all blockers of type op of the subtree
Yikes - is that really what we want? Or do we need to start doing
blocker reference counting?
Consider
The Tuesday 17 Jun 2014 à 17:53:49 (-0400), Jeff Cody wrote :
Currently, node_name is only filled in when done so explicitly by the
user. If no node_name is specified, then the node name field is not
populated.
If node_names are automatically generated when not specified, that means
that
The Tuesday 17 Jun 2014 à 17:53:53 (-0400), Jeff Cody wrote :
This modifies the block operation block-commit so that it will
accept node-name arguments for either 'top' or 'base' BDS.
The filename and node-name are mutually exclusive to each other;
i.e.:
top and top-node-name are
The Tuesday 17 Jun 2014 à 17:53:55 (-0400), Jeff Cody wrote :
This adds the ability for block-stream to use node-name arguments
for base, to specify the backing image to stream from.
Both 'base' and 'base-node-name' are optional, but mutually exclusive.
Either can be specified, but not both
The Tuesday 17 Jun 2014 à 17:53:58 (-0400), Jeff Cody wrote :
This allows a user to make a live change to the backing file recorded in
an open image.
The image file to modify can be specified 2 ways:
1) image filename
2) image node-name
Note: this does not cause the backing file itself
The Wednesday 18 Jun 2014 à 09:13:28 (-0400), Jeff Cody wrote :
On Wed, Jun 18, 2014 at 02:53:15PM +0200, Benoît Canet wrote:
The Tuesday 17 Jun 2014 à 17:53:49 (-0400), Jeff Cody wrote :
Currently, node_name is only filled in when done so explicitly by the
user. If no node_name
The Wednesday 18 Jun 2014 à 00:14:09 (+0200), Max Reitz wrote :
If filename is removed from the options QDict before entering
bdrv_open_common(), it cannot be stored in the BDS. Therefore, wait
until it has been copied there and remove it from the options only
afterwards.
This fixes
The Wednesday 18 Jun 2014 à 00:14:10 (+0200), Max Reitz wrote :
Add a new test for qemu-iotests which checks whether the filename (and
consequently the file) attribute is set for images which are opened
over NBD.
Signed-off-by: Max Reitz mre...@redhat.com
---
tests/qemu-iotests/097 |
The Tuesday 17 Jun 2014 à 18:17:46 (+0200), Max Reitz wrote :
On 16.06.2014 12:00, Benoît Canet wrote:
The to-replace-node-name is designed to allow repairing a broken Quorum file.
This patch introduces a new class TestRepairQuorum testing that the feature
works.
Some further work
The Saturday 14 Jun 2014 à 02:44:29 (+0200), Max Reitz wrote :
On 11.06.2014 15:24, Benoît Canet wrote:
The to-replace-node-name is designed to allow repairing of broken Quorum
file.
a broken Quorum file or broken Quorum files.
This patch introduce a new class TestRepairQuorum testing
in v10:
address max comments
Benoît Canet (4):
quorum: Add the rewrite-corrupted parameter to quorum
block: Add node-name argument to drive-mirror
block: Add replaces argument to drive-mirror
qemu-iotests: Add TestRepairQuorum to 041 to test drive-mirror
node-name mode
The to-replace-node-name is designed to allow repairing a broken Quorum file.
This patch introduces a new class TestRepairQuorum testing that the feature
works.
Some further work will be done on QEMU to improve the robustness of the tests.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
This new argument can be used to specify the node-name of the new mirrored BDS.
Signed-off-by: Benoit Canet ben...@irqsave.net
Reviewed-by: Max Reitz mre...@redhat.com
---
blockdev.c | 11 +--
hmp.c| 1 +
qapi/block-core.json | 4
qmp-commands.hx |
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet ben...@irqsave.net
Reviewed-by: Max Reitz mre...@redhat.com
---
block.c | 17 ++
block/mirror.c| 60
On read operations when this parameter is set and some replicas are corrupted
while quorum can be reached quorum will proceed to rewrite the correct version
of the data to fix the corrupted replicas.
This will shine with SSD where the FTL will remap the same block at another
place on rewrite.
The Friday 13 Jun 2014 à 14:52:29 (-0400), Jeff Cody wrote :
Currently, node_name is only filled in when done so explicitly by the
user. If no node_name is specified, then the node name field is not
populated.
If node_names are automatically generated when not specified, that means
that
The Friday 13 Jun 2014 à 14:52:31 (-0400), Jeff Cody wrote :
This simplifies the function bdrv_find_overlay(). With this change,
bdrv_find_base() is just a subset of usage of bdrv_find_overlay(),
so this also takes advantage of that.
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by:
The Friday 13 Jun 2014 à 14:52:37 (-0400), Jeff Cody wrote :
The QMP command 'block-stream' was missing QMP documentation. Add
that documentation.
Reviewed-by: Eric Blake ebl...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
qmp-commands.hx | 58
The Friday 13 Jun 2014 à 09:53:55 (-0400), Jeff Cody wrote :
On Fri, Jun 13, 2014 at 09:28:28PM +0800, Stefan Hajnoczi wrote:
snip
* Mutual exclusion of operations/background jobs (bs-in_use / BlockOpType)
* Streaming in two different parts of the backing chain - allowed?
(Benoît
The Friday 13 Jun 2014 à 16:17:34 (+0200), Benoît Canet wrote :
The Friday 13 Jun 2014 à 09:53:55 (-0400), Jeff Cody wrote :
On Fri, Jun 13, 2014 at 09:28:28PM +0800, Stefan Hajnoczi wrote:
snip
* Mutual exclusion of operations/background jobs (bs-in_use /
BlockOpType
The Wednesday 11 Jun 2014 à 16:04:55 (+0200), Kevin Wolf wrote :
The idea of bdrv_fill_options() is to convert every parameter for
opening images, in particular the filename and flags, to entries in the
options QDict.
This patch starts with moving the filename parsing and driver probing
The Wednesday 11 Jun 2014 à 16:04:56 (+0200), Kevin Wolf wrote :
bs-options now contains the modified version of the options.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 26 --
1 file changed, 16 insertions(+), 10 deletions(-)
diff --git a/block.c
The Wednesday 11 Jun 2014 à 16:04:57 (+0200), Kevin Wolf wrote :
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 88
+
1 file changed, 45 insertions(+), 43 deletions(-)
diff --git a/block.c b/block.c
index
The Wednesday 11 Jun 2014 à 16:04:58 (+0200), Kevin Wolf wrote :
The driver entry in the options QDict is now only missing if we're
opening an image with format probing.
We also catch cases now where both the drv argument and a driver
option is specified, e.g. by specifying -drive
The Wednesday 11 Jun 2014 à 16:04:59 (+0200), Kevin Wolf wrote :
This moves the bdrv_open_file() call a bit down so that it can use the
bdrv_open() code that selects the right block driver.
The code between the old and the new call site is either common code
(the error message for an unknown
The Wednesday 11 Jun 2014 à 16:05:00 (+0200), Kevin Wolf wrote :
It doesn't do much any more, we can move the code to bdrv_open() now.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c | 51 +++
1 file changed, 11 insertions(+), 40
The Tuesday 10 Jun 2014 à 19:58:44 (+0400), Michael Tokarev wrote :
Suggested-by: Peter Maydell peter.mayd...@linaro.org
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/virtio/virtio.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/virtio.c
The to-replace-node-name is designed to allow repairing of broken Quorum file.
This patch introduce a new class TestRepairQuorum testing that the feature
works.
Some further work will be done on QEMU to improve the robutness of the tests.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
On read operations when this parameter is set and some replicas are corrupted
while quorum can be reached quorum will proceed to rewrite the correct version
of the data to fix the corrupted replicas.
This will shine with SSD where the FTL will remap the same block at another
place on rewrite.
in V9:
fix leak [Stefan]
fix error message [Stefan]
relax constraint [Stefan]
Benoît Canet (4):
quorum: Add the rewrite-corrupted parameter to quorum
block: Add node-name argument to drive-mirror
block: Add replaces argument to drive-mirror
qemu-iotests: Add
drive-mirror will bdrv_swap the new BDS named node-name with the one
pointed by replaces when the mirroring is finished.
Signed-off-by: Benoit Canet ben...@irqsave.net
---
block.c | 17 ++
block/mirror.c| 60
301 - 400 of 2243 matches
Mail list logo
