These are the last bits required to make quorum usable in production.
v4:
update patchset to stefan's block branch
drop Max reviewed by because the series changes
Benoît Canet (3):
quorum: Add the rewrite-corrupted parameter to quorum.
block: Add drive-mirror-replace co
On read operations when this parameter is set and some replicas are corrupted
while quorum can be reached quorum will proceed to rewrite the correct version
of the data to fix the corrupted replicas.
This will shine with SSD where the FTL will remap the same block at another
place on rewrite.
Sig
The Monday 26 May 2014 à 19:37:11 (+0200), Markus Armbruster wrote :
> Introduced in commit a8d8ecb. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> block/qapi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/qapi.c b/block/qapi.c
> index 75f44f1..97e1641 1006
The Monday 26 May 2014 à 19:37:15 (+0200), Markus Armbruster wrote :
> Introduced in commit 661a0f7. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-img.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 62ea27e..d1
The Monday 26 May 2014 à 19:37:14 (+0200), Markus Armbruster wrote :
> Has always been leaky. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> block/sheepdog.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/sheepdog.c b/block/sheepdog.c
> in
The Monday 26 May 2014 à 19:37:13 (+0200), Markus Armbruster wrote :
> Has always been leaky. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> block/vvfat.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/block/vvfat.c b/block/vvfat.c
> index 2c82a5
The Monday 26 May 2014 à 19:37:12 (+0200), Markus Armbruster wrote :
> On error path. Introduced in commit a046433a. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> block/vvfat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/vvfat.c b/block/v
The Monday 26 May 2014 à 19:37:10 (+0200), Markus Armbruster wrote :
> Introduced in commit f298d07. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> blockdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index 6460c70..7ec7d79 100644
>
The Monday 26 May 2014 à 19:37:09 (+0200), Markus Armbruster wrote :
> blockdev_init() leaks bs_opts when qemu_opts_create() fails, i.e. when
> the ID is bad. Missed in commit ec9c10d.
>
> Signed-off-by: Markus Armbruster
> ---
> blockdev.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deleti
The Monday 26 May 2014 à 19:37:08 (+0200), Markus Armbruster wrote :
> Reproducer: "open -o a=b". Broken in commit fd0fee3.
> Signed-off-by: Markus Armbruster
> ---
> qemu-io.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-io.c b/qemu-io.c
> index ffbad25..
The Monday 26 May 2014 à 19:37:04 (+0200), Markus Armbruster wrote :
> Introduced in commit 5a8a30d. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> block/qcow2.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index
The Monday 26 May 2014 à 19:37:07 (+0200), Markus Armbruster wrote :
> Introduced in commit b543c5c. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-io.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-io.c b/qemu-io.c
> index ef3fef6..ffbad25 100644
> ---
The Monday 26 May 2014 à 19:37:06 (+0200), Markus Armbruster wrote :
> Instead of ignoring all option values but the last one, multiple -o
> options now have the same meaning as having a single option with all
> settings in the order of their respective -o options.
>
> Same as commit 2dc8328 for q
The Monday 26 May 2014 à 19:37:05 (+0200), Markus Armbruster wrote :
> Introduced in commit da557a. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> block.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block.c b/block.c
> index 40c5e1a..1996f84 100644
> --- a/block
The Monday 26 May 2014 à 19:37:03 (+0200), Markus Armbruster wrote :
> I figure the leak originated in bdrv_create2(), and was duplicated
> into callers when commit 91a073ak dropped that function. Looks like
> the other places have since been fixed.
>
> Spotted by Coverity.
>
> Signed-off-by: Ma
The Monday 26 May 2014 à 19:37:02 (+0200), Markus Armbruster wrote :
> Introduced in commit a283cb6; mostly harmless. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster
> ---
> qemu-img.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 1ad899e..6
The Thursday 22 May 2014 à 11:42:50 (+0200), Stefan Hajnoczi wrote :
> Normally one would expect that qcow2 image file lengths are multiples of
> the cluster size. This is not true in all cases and the spec should
> document this so implementers remember to accept such files.
>
> $ qemu-img creat
The Friday 16 May 2014 à 12:47:56 (+0200), Kevin Wolf wrote :
> Am 15.05.2014 um 18:35 hat Benoît Canet geschrieben:
> > The Thursday 15 May 2014 à 16:21:56 (+0200), Kevin Wolf wrote :
> > > A huge image size could cause s->l1_size to overflow. Make sure that
> > > i
in v4:
Document the feature [Eric, Luiz]
Benoît Canet (1):
qapi: skip redundant includes
docs/qapi-code-gen.txt| 2 +-
scripts/qapi.py | 14 +++---
tests/Makefile| 3 ++-
tests/qapi-schema
The purpose of this change is to help create a json file containing
common definitions; each bit of generated C code must be emitted
only one time.
A second history global to all QAPISchema instances has been added
to detect when a file is included more than one time and skip these
includes.
It do
The Thursday 15 May 2014 à 13:39:02 (-0600), Eric Blake wrote :
> On 05/15/2014 01:13 PM, Luiz Capitulino wrote:
> > On Wed, 14 May 2014 16:07:49 +0200
> > Benoît Canet wrote:
> >
> >> The purpose of this change is to help create a json file containing
> &
The Thursday 15 May 2014 à 16:21:54 (+0200), Kevin Wolf wrote :
> Huge values for header.cluster_bits cause unbounded allocations (e.g.
> for s->cluster_cache) and crash qemu this way. Less huge values may
> survive those allocations, but can cause integer overflows later on.
>
> The only cluster
The Thursday 15 May 2014 à 16:21:56 (+0200), Kevin Wolf wrote :
> A huge image size could cause s->l1_size to overflow. Make sure that
> images never require a L1 table larger than what fits in s->l1_size.
>
> This cannot only cause unbounded allocations, but also the allocation of
> a too small L
The Thursday 15 May 2014 à 16:21:55 (+0200), Kevin Wolf wrote :
> Too large L2 table sizes cause unbounded allocations. Images actually
> created by qemu-img only have 512 byte or 4k L2 tables.
>
> To keep things consistent with cluster sizes, allow ranges between 512
> bytes and 64k (in fact, dow
The Thursday 15 May 2014 à 08:06:14 (-0400), Jeff Cody wrote :
> On Thu, May 15, 2014 at 01:58:59PM +0200, Benoît Canet wrote:
> > The Wednesday 14 May 2014 à 23:20:15 (-0400), Jeff Cody wrote :
> > > Currently, node_name is only filled in when done so explicitly by the
The Wednesday 14 May 2014 à 23:20:19 (-0400), Jeff Cody wrote :
> On some image chains, QEMU may not always be able to resolve the
> filenames properly, when updating the backing file of an image
> after a block commit.
>
> For instance, certain relative pathnames may fail, or drives may
> have be
The Wednesday 14 May 2014 à 23:20:18 (-0400), Jeff Cody wrote :
> This modifies the block operation block-commit so that it will
> accept node-name arguments for either 'top' or 'base' BDS.
>
> The filename and node-name are mutually exclusive to each other;
> i.e.:
> "top" and "top-node-name"
The Wednesday 14 May 2014 à 23:20:15 (-0400), Jeff Cody wrote :
> Currently, node_name is only filled in when done so explicitly by the
> user. If no node_name is specified, then the node name field is not
> populated.
>
> If node_names are automatically generated when not specified, that means
>
The Wednesday 14 May 2014 à 23:20:16 (-0400), Jeff Cody wrote :
> This is a small helper function, to determine if 'base' is in the
> chain of BlockDriverState 'top'. It returns true if it is in the chain,
> and false otherwise.
>
> If either argument is NULL, it will also return false.
>
> Sign
The Wednesday 14 May 2014 à 23:20:17 (-0400), Jeff Cody wrote :
> Now that active layer block-commit is supported, the 'top' argument
> no longer needs to be mandatory.
>
> Change it optional, with the default being the active layer in the
Do you mean "Change it to optional" or "Make it optional"
be updated since the throttle_init() interface
> has changed.
>
> Cc: Benoît Canet
> Signed-off-by: Stefan Hajnoczi
> ---
> block.c | 7 +++
> include/qemu/throttle.h | 10 ++
> tests/test-throttle.c | 25 -
> util/
The Wednesday 14 May 2014 à 16:22:44 (+0200), Stefan Hajnoczi wrote :
> This series applies on top of my "dataplane: use QEMU block layer" series.
>
> Now that the dataplane code path is using the QEMU block layer we should make
> I/O throttling limits safe to use. When the block_set_io_throttle
t is running I/O for this device.
>
> Cc: Benoît Canet
> Signed-off-by: Stefan Hajnoczi
> ---
> blockdev.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/blockdev.c b/blockdev.c
> index 7810e9f..e0f1978 100644
> --- a/blockdev.c
> +++ b/blockdev.c
&
The Wednesday 14 May 2014 à 16:22:44 (+0200), Stefan Hajnoczi wrote :
> This series applies on top of my "dataplane: use QEMU block layer" series.
>
> Now that the dataplane code path is using the QEMU block layer we should make
> I/O throttling limits safe to use. When the block_set_io_throttle
The Wednesday 14 May 2014 à 16:22:46 (+0200), Stefan Hajnoczi wrote :
> Add a test case that checks the timer is really removed/added by the
> detach/attach functions.
>
> Cc: Benoît Canet
> Signed-off-by: Stefan Hajnoczi
> ---
> tests/test-throttle.c | 24 +
test cases need to be updated since the throttle_init() interface
> has changed.
>
> Cc: Benoît Canet
> Signed-off-by: Stefan Hajnoczi
> ---
> block.c | 7 +++
> include/qemu/throttle.h | 10 ++
> tests/test-throttle.c | 2
The purpose of this change is to help create a json file containing
common definitions; each bit of generated C code must be emitted
only one time.
A second history global to all QAPISchema instances has been added
to detect when a file is included more than one time and skip these
includes.
It do
in V3:
change commit title [Eric]
s/spitted/emitted/
change tests names [Eric]
Benoît Canet (1):
qapi: skip redundant includes
scripts/qapi.py | 14 +++---
tests/Makefile| 3 ++-
tests/qapi-schema
The Monday 12 May 2014 à 11:11:41 (-0600), Eric Blake wrote :
> On 05/09/2014 09:48 AM, Benoît Canet wrote:
>
> Subject line has problems. 'excepted' is not a word, and you are already
> asked to avoid trailing '.'. I suggest a much simpler:
>
> qapi: skip
The Monday 12 May 2014 à 19:04:22 (+0200), Benoît Canet wrote :
> The Monday 12 May 2014 à 18:43:33 (+0200), Kevin Wolf wrote :
> > Am 12.05.2014 um 17:50 hat Benoît Canet geschrieben:
> > > The Monday 12 May 2014 à 15:04:10 (+0200), Kevin Wolf wrote :
> > > > A
The Monday 12 May 2014 à 18:43:33 (+0200), Kevin Wolf wrote :
> Am 12.05.2014 um 17:50 hat Benoît Canet geschrieben:
> > The Monday 12 May 2014 à 15:04:10 (+0200), Kevin Wolf wrote :
> > > A huge image size could cause s->l1_size to overflow. Make sure that
> > > i
The Monday 12 May 2014 à 15:04:11 (+0200), Kevin Wolf wrote :
> Like qcow2 since commit 6d33e8e7, error out on invalid lengths instead
> of silently truncating them to 1023.
>
> Also don't rely on bdrv_pread() catching integer overflows that make len
> negative, but use unsigned variables in the f
The Monday 12 May 2014 à 15:04:10 (+0200), Kevin Wolf wrote :
> A huge image size could cause s->l1_size to overflow. Make sure that
> images never require a L1 table larger than what fits in s->l1_size.
>
> This cannot only cause unbounded allocations, but also the allocation of
> a too small L1
The Monday 12 May 2014 à 15:04:09 (+0200), Kevin Wolf wrote :
> Too large L2 table sizes cause unbounded allocations. Images actually
> created by qemu-img only have 512 byte or 4k L2 tables.
>
> To keep things consistent with cluster sizes, allow ranges between 512
> bytes and 64k (in fact, down
The Monday 12 May 2014 à 15:04:08 (+0200), Kevin Wolf wrote :
> Huge values for header.cluster_bits cause unbounded allocations (e.g.
> for s->cluster_cache) and crash qemu this way. Less huge values may
> survive those allocations, but can cause integer overflows later on.
>
> The only cluster si
The Monday 12 May 2014 à 15:04:07 (+0200), Kevin Wolf wrote :
> We were relying on all compilers inserting the same padding in the
> header struct that is used for the on-disk format. Let's not do that.
> Mark the struct as packed and insert an explicit padding field for
> compatibility.
>
> Signe
The Friday 14 Mar 2014 à 16:18:39 (+0100), Benoît Canet wrote :
Stefan, Kevin:
Ping,
I made this a dependency of Fam's nbd series to simplify his work on
the job blockers.
However Fam's series is a lot of work and takes time to merge.
This patchset is the only thing I _must_ succee
The purpose of this change is to help create a json file containing
common definitions; each bit of generated C code must be spitted
only one time.
A second history global to all QAPISchema instances has been added
to detect when a file is included more than one time and skip these
includes.
It do
in V2:
Keep the cycle detection [Markus]
Don't talk about idempottent [Markus]
Benoît Canet (1):
qapi: Let redundant includes be skipped excepted the first
occurrence.
scripts/qapi.py | 14 +++---
tests/Mak
The Friday 09 May 2014 à 07:36:31 (+0200), Markus Armbruster wrote :
> Benoît Canet writes:
>
> > The Thursday 08 May 2014 à 20:30:33 (+0200), Markus Armbruster wrote :
> [...]
> >> There are two reasons to detect cycles. The technical one is preventing
> >&g
The Thursday 08 May 2014 à 20:30:33 (+0200), Markus Armbruster wrote :
> Humor me: no period at end of subject.
>
> Benoît Canet writes:
>
> > The purpose of this change is to help create a json file containing
> > common definitions.
>
> Please describe th
The purpose of this change is to help create a json file containing
common definitions.
The history used to detect multiple inclusions is not a stack anymore
but a regular list.
The cycle detection check where updated and leaved in place to make
sure the code will never enter into an infinite rec
The Wednesday 07 May 2014 à 21:44:06 (+0200), Markus Armbruster wrote :
> Eric Blake writes:
>
> > On 05/06/2014 07:27 AM, Luiz Capitulino wrote:
> >> On Tue, 6 May 2014 15:07:40 +0200
> >> Benoît Canet wrote:
> >>
> >>> I am tr
7;t know about our ->bs[]
> BlockDriverStates, which is also part of the graph.
V1 seemed sweet and fine.
What has changed since V1 ?
Best regards
Benoît
>
> Cc: Benoît Canet
> Signed-off-by: Stefan Hajnoczi
> ---
> block/quorum.c | 48
>
The Tuesday 06 May 2014 à 09:27:25 (-0400), Luiz Capitulino wrote :
> On Tue, 6 May 2014 15:07:40 +0200
> Benoît Canet wrote:
>
> > I am trying to use this series to modularise the block API.
> >
> > Here are my finding.
> >
> > I tried to make a qmp/bl
ive format.
> * s/file path/file name/.
> * s/included/include/.
> * Move "-i" to the end of the command.
> * Fix GNUism when using sed.
>
> Changes in v6:
>
> * Split changes for long-line breaking in makefiles.
> * Put documentation on a separate section; reference
7;t know about our ->bs[]
> BlockDriverStates, which is also part of the graph.
>
> Cc: Benoît Canet
> Signed-off-by: Stefan Hajnoczi
> ---
> block/quorum.c | 48
> 1 file changed, 36 insertions(+), 12 deletions(-)
>
> diff --git a/blo
The Tuesday 29 Apr 2014 à 08:21:16 (+0200), Stefan Weil wrote :
> Those options were not enabled by default, even when the build
> environment would have supported them, so the corresponding
> code was not compiled in normal test builds like on build bots.
>
> Signed-off-by: Stefan Weil
> ---
>
The Monday 28 Apr 2014 à 09:07:58 (+0400), Michael Tokarev wrote :
> From: Stefan Weil
>
> The "Q" of the logo is already included in pc-bios/qemu_logo_no_text.svg.
>
> This file now adds the complete logo as it was designed by Benoît Canet.
> Benoît licensed it
The Sunday 27 Apr 2014 à 13:06:46 (+0400), Michael Tokarev wrote :
> 18.04.2014 00:31, Stefan Weil wrote:
> > The "Q" of the logo is already included in pc-bios/qemu_logo_no_text.svg.
> >
> > This file now adds the complete logo as it was designed by Benoît Canet.
The Thursday 17 Apr 2014 à 19:23:27 (+0200), Stefan Weil wrote :
> The "Q" of the logo is already included in pc-bios/qemu_logo_no_text.svg.
> This file now adds the complete logo as it was designed by Benoît Canet.
>
> Cc: Benoît Canet
> Signed-off-by: Stefan Weil
The counter being reseted to zero make the array index negative.
Reset it to 1.
Signed-off-by: Benoit Canet
---
hw/ide/core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index e1dfe54..c943a4d 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
The Thursday 10 Apr 2014 à 20:43:38 (+0200), Max Reitz wrote :
> Implement this function by passing it through to bs->file.
>
> Signed-off-by: Max Reitz
> ---
> block/json.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/block/json.c b/block/json.c
> index cb83780..dfeec81 100
The Thursday 10 Apr 2014 à 20:43:36 (+0200), Max Reitz wrote :
> Add passthrough functions for bdrv_aio_flush() and
> bdrv_invalidate_cache().
>
> Signed-off-by: Max Reitz
> ---
> block/json.c | 15 +++
> 1 file changed, 15 insertions(+)
>
> diff --git a/block/json.c b/block/json.c
The Monday 31 Mar 2014 à 15:39:19 (+0100), anton.iva...@kot-begemot.co.uk wrote
:
> From: Anton Ivanov
>
> This transport allows to connect a QEMU nic to a static Ethernet
> over L2TPv3 tunnel. The transport supports all options present
> in the Linux kernel implementation. It allows QEMU to con
The Monday 31 Mar 2014 à 15:39:19 (+0100), anton.iva...@kot-begemot.co.uk wrote
:
> From: Anton Ivanov
>
> This transport allows to connect a QEMU nic to a static Ethernet
> over L2TPv3 tunnel. The transport supports all options present
> in the Linux kernel implementation. It allows QEMU to con
gt; create mode 100644 tests/qapi-schema/include-self-cycle.err
> create mode 100644 tests/qapi-schema/include-self-cycle.exit
> create mode 100644 tests/qapi-schema/include-self-cycle.json
> create mode 100644 tests/qapi-schema/include-self-cycle.out
> create mode 100644 tests/qapi-schema/include-simple-sub.json
> create mode 100644 tests/qapi-schema/include-simple.err
> create mode 100644 tests/qapi-schema/include-simple.exit
> create mode 100644 tests/qapi-schema/include-simple.json
> create mode 100644 tests/qapi-schema/include-simple.out
>
>
> To: qemu-devel@nongnu.org
> Cc: Luiz Capitulino
> Cc: Markus Armbruster
> Cc: Eric Blake
> Cc: Benoît Canet
This patch is here to pave the way for the JSON include directive which
will need to do include loop detection.
Signed-off-by: Benoit Canet
---
Makefile | 12 ++--
scripts/qapi-commands.py |6 +-
scripts/qa
The new directive in the form { 'include': 'path/to/file.json' } will trigger
the
parsing of path/to/file.json.
The directive will be replaced by the result of the parsing.
This will allow for easy modularisation of qapi JSON descriptions files.
Signed-off-by: Benoit Canet
---
docs/qapi-code-g
In case of exception str(e) with e being the exception is more detailled.
Signed-off-by: Benoit Canet
Reviewed-by: Eric Blake
---
tests/qapi-schema/test-qapi.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qap
.txt [Eric]
Benoît Canet (3):
test-qapi: Make test-qapi.py spit useful error messages.
qapi: Change the qapi scripts to take their input as first argument.
qapi: Create an include directive for use in the JSON description
files.
Makefile | 12 +
The Thursday 27 Mar 2014 à 19:07:48 (+0100), Markus Armbruster wrote :
> Benoît Canet writes:
>
> > The new directive in the form { 'include': 'path/to/file.json' } will
> > trigger the
> > parsing of path/to/file.json.
> > The direc
The Monday 24 Mar 2014 à 16:58:55 (+0100), Kevin Wolf wrote :
> Am 24.03.2014 um 15:53 hat Benoît Canet geschrieben:
> > The Thursday 20 Mar 2014 à 17:06:26 (+0100), Benoît Canet wrote :
> > > The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote :
> > > > Am
is to be able to add QMP to qemu-nbd in a not so
distant future.
Best regards
Benoît
in V2:
Split second patch in two patches [Eric]
Document in docs/qapi-code-gen.txt [Eric]
Benoît Canet (3):
test-qapi: Make test-qapi.py spit useful error messages.
qapi: Change the qapi scrip
The new directive in the form { 'include': 'path/to/file.json' } will trigger
the
parsing of path/to/file.json.
The directive will be replaced by the result of the parsing.
This will allow for easy modularisation of qapi JSON descriptions files.
Signed-off-by: Benoit Canet
---
docs/qapi-code-g
This patch is here to pave the way for the JSON include directive which
will need to do include loop detection.
Signed-off-by: Benoit Canet
---
Makefile | 24
scripts/qapi-commands.py |8 --
scripts/qa
In case of exception str(e) with e being the exception is more detailled.
Signed-off-by: Benoit Canet
Reviewed-by: Eric Blake
---
tests/qapi-schema/test-qapi.py |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qap
The Wednesday 26 Mar 2014 à 13:42:38 (+0100), Markus Armbruster wrote :
> Wenchao Xia writes:
>
> > 于 2014/3/21 6:29, Eric Blake 写道:
> >> On 03/18/2014 08:38 PM, Wenchao Xia wrote:
> >>> 于 2014/3/7 2:49, Eric Blake 写道:
> On 01/02/2014 04:10 PM, Wenchao Xia wrote:
> > qapi-event.py will p
The Thursday 20 Mar 2014 à 17:06:26 (+0100), Benoît Canet wrote :
> The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote :
> > Am 20.03.2014 um 15:05 hat Benoît Canet geschrieben:
> > > The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote :
> > > &
The Friday 07 Mar 2014 à 23:55:56 (+0100), Max Reitz wrote :
> Add a test for the JSON protocol driver.
>
> Signed-off-by: Max Reitz
> ---
> tests/qemu-iotests/084 | 123
> +
> tests/qemu-iotests/084.out | 39 ++
> tests/qemu-iotests/
The Friday 07 Mar 2014 à 23:55:51 (+0100), Max Reitz wrote :
> Implement this function in the same way as raw_bsd does: Acknowledge
> that this is a passthrough driver (always return BDRV_BLOCK_OFFSET_VALID
> and BDRV_BLOCK_DATA and derive the offset directly from the sector
> index) and add BDRV_B
In case of exception str(e) with e being the exception is more detailled.
Signed-off-by: Benoit Canet
---
tests/qapi-schema/test-qapi.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py
index b3d1e1d..ac6da13
The new directive in the form { 'include': 'path/to/file.json' } will trigger
the
parsing of path/to/file.json.
The directive will be replaced by the result of the parsing.
This will allow for easy modularisation of qapi JSON descriptions files.
The qapi commands now takes the input file path as
The first patch make an error path in the test more explicit.
The second create an include directive for QAPI JSON files.
The purpose of this series is to be able to add QMP to qemu-nbd in a not so
distant future.
Best regards
Benoît
Benoît Canet (2):
test-qapi: Make test-qapi.py spit useful
The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote :
> Am 20.03.2014 um 15:05 hat Benoît Canet geschrieben:
> > The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote :
> > > Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben:
> > > > On Mon, Mar
The Thursday 20 Mar 2014 à 16:12:34 (+0100), Kevin Wolf wrote :
> Am 20.03.2014 um 15:05 hat Benoît Canet geschrieben:
> > The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote :
> > > Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben:
> > > > On Mon, Mar
The Tuesday 18 Mar 2014 à 14:27:47 (+0100), Kevin Wolf wrote :
> Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben:
> > On Mon, Mar 17, 2014 at 4:12 AM, Fam Zheng wrote:
> > > On Fri, 03/14 16:57, Benoît Canet wrote:
> > >> I discussed a bit with Stefan
The Monday 17 Mar 2014 à 21:24:40 (-0400), Jeff Cody wrote :
> Both tests 019 and 086 need proper quotations to work with pathnames
> that contain spaces.
>
> Signed-off-by: Jeff Cody
> ---
> tests/qemu-iotests/019 | 2 +-
> tests/qemu-iotests/086 | 8
> 2 files changed, 5 insertions(+)
The Monday 17 Mar 2014 à 21:24:39 (-0400), Jeff Cody wrote :
> The _rm_test_img() function in common.rc did not quote the image
> file, which left droppings in the scratch directory (and performed
> a potentially unsafe rm -f).
>
> This adds the necessary quotes.
>
> Signed-off-by: Jeff Cody
> -
The Monday 17 Mar 2014 à 21:24:38 (-0400), Jeff Cody wrote :
> The new functionality of common.qemu implements the QEMU control
> and communication functionality that was originally in test 085.
>
> This removes that now-duplicate functionality, and uses the
> common.qemu functions.
>
> Signed-of
The Monday 17 Mar 2014 à 21:24:37 (-0400), Jeff Cody wrote :
> This creates some common functions for bash language qemu-iotests
> to control, and communicate with, a running QEMU process.
>
> 4 functions are introduced:
>
> 1. _launch_qemu()
> This launches the QEMU process(es), and
The Tuesday 18 Mar 2014 à 15:36:42 (+0100), Kevin Wolf wrote :
> If it returns an error, the migrated VM will not be started, but qemu
> exits with an error message.
>
> Signed-off-by: Kevin Wolf
> Reviewed-by: Juan Quintela
> Reviewed-by: Eric Blake
> ---
>
> v2:
> - Update quorum as well (no
The Thursday 13 Mar 2014 à 09:54:15 (-0600), Eric Blake wrote :
> On 03/13/2014 09:33 AM, Benoît Canet wrote:
>
> >> We certainly can't do without comments.
> >>
> >> JSON is designed for easy data exchange, but we use it as programming
> >> languag
The Monday 17 Mar 2014 à 11:12:31 (+0800), Fam Zheng wrote :
> On Fri, 03/14 16:57, Benoît Canet wrote:
> >
> > Hello list,
> >
> > I plan to convert throttling to a block filter and write n way throttling
> > support.
> >
> > I discussed a b
The Saturday 15 Mar 2014 à 21:55:54 (+0100), Max Reitz wrote :
> If qcow2_alloc_clusters() fails, new_offset and ret will both be
> negative after the fail label, thus passing the first if condition and
> subsequently resulting in a call of qcow2_free_clusters() with an
> invalid (negative) offset
The Saturday 15 Mar 2014 à 21:55:54 (+0100), Max Reitz wrote :
> If qcow2_alloc_clusters() fails, new_offset and ret will both be
> negative after the fail label, thus passing the first if condition and
> subsequently resulting in a call of qcow2_free_clusters() with an
> invalid (negative) offset
The Friday 14 Mar 2014 à 21:24:38 (+0100), Lluís Vilanova wrote :
> Benoît Canet writes:
>
> > The Thursday 13 Mar 2014 à 19:05:12 (+0100), Lluís Vilanova wrote :
> >> Eric Blake writes:
> >>
> >> > On 03/13/2014 09:33 AM, Benoît Canet wrote:
>
The Thursday 13 Mar 2014 à 19:05:12 (+0100), Lluís Vilanova wrote :
> Eric Blake writes:
>
> > On 03/13/2014 09:33 AM, Benoît Canet wrote:
> >>> We certainly can't do without comments.
> >>>
> >>> JSON is designed for easy data exchange, but
Hello list,
I plan to convert throttling to a block filter and write n way throttling
support.
I discussed a bit with Stefan on the list and we came to the conclusion that the
block filter API need group support.
filter group:
-
My current plan to implement this is to add the follo
Tests for drive-mirror-replace whose purpose is to enable quorum file mirroring
and replacement after failure.
Signed-off-by: Benoit Canet
---
tests/qemu-iotests/041| 34 +--
tests/qemu-iotests/088| 219 ++
tests/qemu-iotests/088.out
601 - 700 of 2281 matches
Mail list logo
