Am 27. Mai 2024 16:20:44 UTC schrieb Richard Henderson
:
>On 5/27/24 08:29, Bernhard Beschow wrote:
>> I think the kernel's output indicates that the MMU is active:
>>
>>[7e849b05] *pgd=2c552831, *pte=109eb34f, *ppte=109eb83f
>>
>> AFAIU, the value in br
Am 27. Mai 2024 10:58:54 UTC schrieb Peter Maydell :
>On Mon, 27 May 2024 at 03:36, Richard Henderson
> wrote:
>>
>> On 5/25/24 13:50, Bernhard Beschow wrote:
>> >
>> >
>> > Am 25. Mai 2024 13:41:54 UTC schrieb Bernhard Beschow :
>> >&g
Am 25. Mai 2024 13:41:54 UTC schrieb Bernhard Beschow :
>
>
>Am 5. März 2024 13:52:34 UTC schrieb Peter Maydell :
>>From: Richard Henderson
>>
>>If translation is disabled, the default memory type is Device, which
>>requires alignment checking. This
Am 5. März 2024 13:52:34 UTC schrieb Peter Maydell :
>From: Richard Henderson
>
>If translation is disabled, the default memory type is Device, which
>requires alignment checking. This is more optimally done early via
>the MemOp given to the TCG memory operation.
>
>Reviewed-by: Philippe
Am 22. Mai 2024 10:43:04 UTC schrieb Akihiko Odaki :
>The non-standard .fa library prefix breaks the link source
s/prefix/suffix/ in the commit message and subject.
Best regards,
Bernhard
>de-duplication done by Meson so drop it.
>
>The lack of link source de-duplication causes
rks better than ever by also fixing the range of the machine
code. So:
Tested-by: Bernhard Beschow
The only issue that remains is that the machine code is reversed, i.e. the
first byte is output last. But that is a bug that existed before.
>Reported-by: Bernhard Beschow
>Signed-off-by: R
Am 8. Mai 2024 17:55:07 UTC schrieb Bernhard Beschow :
>In the -bios case the "isa-bios" memory region is an alias to the BIOS mapped
>to the top of the 4G memory boundary. Do the same in the -pflash case, but only
>for new machine versions for migration compatibility. This
Am 15. Mai 2024 07:52:32 UTC schrieb Richard Henderson
:
>Read from already translated pages, or saved mmio data.
>
>Reviewed-by: Philippe Mathieu-Daudé
>Signed-off-by: Richard Henderson
>---
> include/disas/disas.h | 5 +++--
> include/exec/translator.h | 4 ++--
>
Am 8. Mai 2024 20:39:28 UTC schrieb BALATON Zoltan :
>On Wed, 8 May 2024, Bernhard Beschow wrote:
>> This series changes the "isa-bios" MemoryRegion to be an alias rather than a
>> copy in the pflash case. This fixes issuing pflash commands in the isa-bios
>> reg
Am 13. Mai 2024 11:30:04 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 13/5/24 12:11, Bernhard Beschow wrote:
>> Signed-off-by: Bernhard Beschow
>> ---
>> hw/timer/imx_gpt.c| 18 +-
>> hw/timer/trace-events | 6 ++
>> 2 fi
Signed-off-by: Bernhard Beschow
---
hw/timer/imx_gpt.c| 18 +-
hw/timer/trace-events | 6 ++
2 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c
index a8edaec867..3c3b044622 100644
--- a/hw/timer/imx_gpt.c
+++ b/hw
The same statement is executed unconditionally right before the if statement.
Cc: Guenter Roeck
Signed-off-by: Bernhard Beschow
---
The duplicate line may indicate a bug. I'm not familiar with the code, so this
patch may go into the wrong direction. Please check!
---
hw/watchdog/wdt_imx2.c
This series improves the tracing experience in two devices used in ARM context.
It also removes a duplicate statement in an IMX watchdog which may indicate a
bug (see comment underneath commit message).
Best regards,
Bernhard
Bernhard Beschow (3):
hw/rtc/ds1338: Trace send and receive
Signed-off-by: Bernhard Beschow
---
hw/rtc/ds1338.c | 6 ++
hw/rtc/trace-events | 4
2 files changed, 10 insertions(+)
diff --git a/hw/rtc/ds1338.c b/hw/rtc/ds1338.c
index e479661c39..ec1b6c40b1 100644
--- a/hw/rtc/ds1338.c
+++ b/hw/rtc/ds1338.c
@@ -17,6 +17,7 @@
#include "
By default, SDL disables the screen saver which prevents the host from powering
down the screen even if the screen is locked. This results in draining the
battery needlessly when the host isn't connected to a wall charger. Fix that by
enabling the screen saver.
Signed-off-by: Bernhard Beschow
Am 8. Mai 2024 14:53:49 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 30/4/24 17:06, Bernhard Beschow wrote:
>
>> Bernhard Beschow (6):
>>hw/i386/x86: Eliminate two if statements in x86_bios_rom_init()
>>hw/i386: Have x86_bios_rom_init(
mory region only appears standalone when "isa-bios" is
an alias.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/pc.h | 1 +
hw/i386/pc.c | 1 +
hw/i386/pc_piix.c| 3 +++
hw/i386/pc_q35.c | 2 ++
hw/i386/pc_sysfw.c | 8 +++-
5 files changed, 14 insertions(+), 1 dele
Mathieu-Daudé
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 2 ++
hw/i386/x86.c | 25 -
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/include/hw/i386/x86.h b/include/hw/i386/x86.h
index 55c6809ae0..d7b7d3f3ce 100644
--- a/include/hw
The function creates and leaks two MemoryRegion objects regarding the BIOS which
will be moved into X86MachineState in the next steps to avoid the leakage.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 2 +-
hw/i386/microvm.c | 2 +-
hw
Fix the leaking in x86_bios_rom_init() by adding a "bios" attribute to
X86MachineState. Note that it is only used in the -bios case.
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 6 ++
hw/i386/x86.c | 13 ++--
Given that memory_region_set_readonly() is a no-op when the readonlyness is
already as requested it is possible to simplify the pattern
if (condition) {
foo(true);
}
to
foo(condition);
which is shorter and allows to see the invariant of the code more easily.
Signed-off-by: Bernhard
Fix the leaking in x86_bios_rom_init() and pc_isa_bios_init() by adding an
"isa_bios" attribute to X86MachineState.
Suggested-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 7 +++
hw/i386/pc_sysf
ios memory regions (Phil)
v2:
* Don't leak bios memory regions (Phil)
* Add compat machinery (Michael)
Testing done:
* `make check` with qemu-system-x86_64 (QEMU 8.2.2) installed. All tests
including migration tests pass.
* `make check-avocado`
Best regards,
Bernhard
Bernhard Beschow (6):
h
Am 30. April 2024 15:39:21 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 30/4/24 17:06, Bernhard Beschow wrote:
>> In the -bios case the "isa-bios" memory region is an alias to the BIOS mapped
>> to the top of the 4G memory boundary. Do the same in the -p
"isa-bios" region which some
real-world legacy bioses rely on.
Note that in the sev_enabled() case, the "isa-bios" memory region in the -pflash
case will now also point to encrypted memory, just like it already does in the
-bios case.
Signed-off-by: Bernhard Beschow
---
include/hw
The function creates and leaks two MemoryRegion objects regarding the BIOS which
will be moved into X86MachineState in the next steps to avoid the leakage.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 2 +-
hw/i386/microvm.c | 2 +-
hw/i386/pc_sysfw.c| 4 ++--
hw/i386/x86
Fix the leaking in x86_bios_rom_init() and pc_isa_bios_init() by adding an
"isa_bios" attribute to X86MachineState.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 2 ++
hw/i386/pc_sysfw.c| 7 +++
hw/i386/x86.c | 9 ++
The function is inspired by pc_isa_bios_init() and should eventually replace it.
Using x86_isa_bios_init() rather than pc_isa_bios_init() fixes pflash commands
to work in the isa-bios region.
While at it convert the magic number 0x10 (== 1MiB) to increase readability.
Signed-off-by: Bernhard
Bernhard Beschow (6):
hw/i386/x86: Eliminate two if statements in x86_bios_rom_init()
hw/i386: Have x86_bios_rom_init() take X86MachineState rather than
MachineState
hw/i386/x86: Don't leak "isa-bios" memory regions
hw/i386/x86: Don't leak "pc.bios" memory region
Fix the leaking in x86_bios_rom_init() by adding a "bios" attribute to
X86MachineState. Note that it is only used in the -bios case.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 1 +
hw/i386/x86.c | 13 ++---
2 files changed, 7 insertions(+), 7 deletion
Given that memory_region_set_readonly() is a no-op when the readonlyness is
already as requested it is possible to simplify the pattern
if (condition) {
foo(true);
}
to
foo(condition);
which is shorter and allows to see the invariant of the code more easily.
Signed-off-by: Bernhard
Am 25. April 2024 07:19:27 UTC schrieb "Philippe Mathieu-Daudé"
:
>Hi Bernhard,
>
>On 22/4/24 22:06, Bernhard Beschow wrote:
>> Now that the -bios and -pflash code paths work the same it is possible to
>> have a
>> common implementation.
>>
>&
Am 25. April 2024 08:07:43 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 22/4/24 22:06, Bernhard Beschow wrote:
>> This series changes the "isa-bios" MemoryRegion to be an alias rather than a
>> copy in the pflash case. This fixes issuing pflash commands in t
Am 25. April 2024 10:16:10 UTC schrieb "Michael S. Tsirkin" :
>On Mon, Apr 22, 2024 at 10:06:21PM +0200, Bernhard Beschow wrote:
>> This series changes the "isa-bios" MemoryRegion to be an alias rather than a
>> copy in the pflash case. This fixes issu
+Michael
Am 22. April 2024 20:06:21 UTC schrieb Bernhard Beschow :
>This series changes the "isa-bios" MemoryRegion to be an alias rather than a
>
>copy in the pflash case. This fixes issuing pflash commands in the isa-bios
>
>region which matches real hardware and whi
Given that memory_region_set_readonly() is a no-op when the readonlyness is
already as requested it is possible to simplify the pattern
if (condition) {
foo(true);
}
to
foo(condition);
which is shorter and allows to see the invariant of the code more easily.
Signed-off-by: Bernhard
e
isa-bios area is now encrypted. Does this need compat machinery or is it a
bugfix?
Testing done:
* `make check` with qemu-system-x86_64 (QEMU 8.2.2) installed. All tests
including migration tests pass.
* `make check-avocado`
Best regards,
Bernhard
Bernhard Beschow (4):
hw/i386/pc_sysfw: Rem
Now that the -bios and -pflash code paths work the same it is possible to have a
common implementation.
While at it convert the magic number 0x10 (== 1MiB) to increase readability.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 2 ++
hw/i386/pc_sysfw.c| 28
ioses rely on.
Note that in the sev_enabled() case, the "isa-bios" memory region in the -pflash
case will now also point to encrypted memory, just like it already does in the
-bios case.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc_sysfw.c | 13 ++---
1 file changed, 2 insertions(+), 11
Signed-off-by: Bernhard Beschow
---
hw/i386/pc_sysfw.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index 3efabbbab2..87b5bf59d6 100644
--- a/hw/i386/pc_sysfw.c
+++ b/hw/i386/pc_sysfw.c
@@ -41,8 +41,7 @@
#define
Am 26. Februar 2024 11:14:10 UTC schrieb "Philippe Mathieu-Daudé"
:
>Instantiate TYPE_ICH9_AHCI in TYPE_ICH9_SOUTHBRIDGE.
>
>Since the PC machines can disable SATA (see the
>PC_MACHINE_SATA dynamic property), add the 'sata-enabled'
>property to disable it.
>
>Signed-off-by: Philippe
-off-by: Philippe Mathieu-Daudé
This patch looks like good material on its own.
Reviewed-by: Bernhard Beschow
>---
> hw/i386/acpi-build.h | 3 ++-
> hw/i386/acpi-build.c | 5 ++---
> hw/i386/pc.c | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
>diff --git
sert? This
allows for further removal of code in this patch and avoids superficial
barriers for reusing this code. Or do I miss something?
Anyway, this patch looks like good material on its own and could be tagged
independently.
With dropping the assert considered:
Reviewed-by: Bernhard Beschow
>
> /* Map legacy -drive if=pflash to machine properties */
> for (i = 0; i < ARRAY_SIZE(pcms->flash); i++) {
Am 28. März 2024 14:09:52 UTC schrieb Mark Cave-Ayland
:
>On 27/03/2024 07:09, Gerd Hoffmann wrote:
>
>> On Tue, Mar 26, 2024 at 01:30:48PM +, Mark Cave-Ayland wrote:
>>> Heh I've actually been using isapc over the past couple of weeks to fire up
>>> some old programs in a Windows 3 VM :)
Am 26. März 2024 13:29:58 UTC schrieb "Philippe Mathieu-Daudé"
:
>Hi Igor,
>
>On 26/3/24 14:08, Thomas Huth wrote:
>>
>> s/iaspc/isapc/ in the subject
>>
>> On 26/03/2024 13.51, Igor Mammedov wrote:
>>> ISAPC machine was introduced 25 years ago and it's a lot of time since
>>> such machine
Am 12. März 2024 15:47:21 UTC schrieb "Michael S. Tsirkin" :
>On Sun, Feb 18, 2024 at 02:16:56PM +0100, Bernhard Beschow wrote:
>> This series attempts to make QEMU's south bridge families PIIX, ICH9, and VIA
>> 82xx more self-contained by integrating IO port
Am 12. März 2024 14:34:47 UTC schrieb Nicholas Piggin :
>On Tue Mar 12, 2024 at 8:36 PM AEST, Nicholas Piggin wrote:
>> On Tue Mar 12, 2024 at 7:28 PM AEST, Bernhard Beschow wrote:
>> >
>> >
>> > Am 9. März 2024 11:34:56 UTC schrieb BALATON Zoltan :
>&
Am 12. März 2024 16:58:11 UTC schrieb Nicholas Piggin :
>The following changes since commit 35ac6831d98e18e2c78c85c93e3a6ca1f1ae3e58:
>
> Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into
> staging (2024-03-12 13:42:57 +)
>
>are available in the Git repository at:
>
>
ally be a pity if it didn't make it
into 9.0.
FWIW:
Reviewed-by: Bernhard Beschow
>
>> Regards,
>> BALATON Zoltan
>>
>>> Co-authored-by: Bernhard Beschow
>>> Signed-off-by: BALATON Zoltan
>>> Reviewed-by: Nicholas Piggin
>>> Tested-by: Bern
Am 9. März 2024 16:29:23 UTC schrieb "Philippe Mathieu-Daudé"
:
>Hi Bernhard,
>
>On 9/3/24 14:40, Bernhard Beschow wrote:
>> The PAM bit extraction is currently spread across pam.c and the northbridge
>> device models, making the extraction logic harder t
) by moving the bit
extraction into the northbridge device models. As a side effect, pam_update()
becomes less Intel-specific which would allow it to be reused e.g. in VIA
northbridges.
Signed-off-by: Bernhard Beschow
---
include/hw/pci-host/pam.h | 7 +++
hw/pci-host/i440fx.c | 7 +--
hw
PAM_REGIONS_COUNT being 13 seems to be Intel-specific. There are VIA 82cXX
northbridges having only 10, for example. Communicate this by having
northbridge-specific constants.
Signed-off-by: Bernhard Beschow
--
Do we need the constants or can we omit them, given they're just used once
`
* This series is sent from a VM implementing this series.
Bernhard Beschow (2):
hw/pci-host/pam: Free PAMMemoryRegion from Intel-specific bit handling
hw/pci-host/pam: Remove northbridge-specific PAM_REGIONS_COUNT
include/hw/pci-host/i440fx.h | 4 +++-
include/hw/pci-host/pam.h| 9
Am 8. März 2024 08:10:24 UTC schrieb Laszlo Ersek :
>On 3/8/24 09:08, Philippe Mathieu-Daudé wrote:
>> On 7/3/24 20:43, Thomas Huth wrote:
>>> On 28/02/2024 17.43, Zhao Liu wrote:
Hi Philippe,
> +/*
> + * Real ICH9 contains a single SMI output line and doesn't
> broadcast
Am 1. März 2024 18:59:32 UTC schrieb "Philippe Mathieu-Daudé"
:
>Trivial cleanups, mostly around the 'isapc' machine.
>
>Philippe Mathieu-Daudé (4):
> hw/i386/pc: Remove pc_compat_1_4..1.7[] left over declarations
> hw/i386/pc: Use generated NotifyVmexitOption_str()
> hw/i386/pc: Remove
Am 5. März 2024 15:57:08 UTC schrieb Peter Maydell :
>On Sun, 3 Mar 2024 at 18:55, Bernhard Beschow wrote:
>>
>> Commit 99e1c1137b6f "hw/i386/pc: Populate RTC attribute directly" made
>> linking
>> the "rtc_state" property unnecessary and r
Now that pc_cmos_init() doesn't populate the X86MachineState::rtc attribute any
longer, its duties can be merged into pc_cmos_init_late() which is called within
machine_done notifier. This frees pc_piix and pc_q35 from explicit CMOS
initialization.
Signed-off-by: Bernhard Beschow
---
include/hw
ard
[1]
https://patchew.org/QEMU/20240221211626.48190-1-phi...@linaro.org/20240221211626
.48190-10-phi...@linaro.org/
Bernhard Beschow (4):
hw/i386/pc: Remove "rtc_state" link again
hw/i386/pc: Avoid one use of the current_machine global
hw/i386/pc: Set "normal" boot device order in pc_
since it is not needed.
Fixes: 84e945aad2d0 "vl, pc: turn -no-fd-bootchk into a machine property"
Cc: Paolo Bonzini
Signed-off-by: Bernhard Beschow
---
hw/i386/pc.c | 8
1 file changed, 8 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index f5ff970acf..63b7583af0 100644
--- a/hw
ot order -- which renders the user's
choice ineffective. Fix this by setting the "normal" boot order in
pc_basic_device_init() which already registers the boot_set() handler.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
The RTC can be accessed through the X86 machine instance, so rather than passing
the RTC it's possible to pass the machine state instead. This avoids
pc_boot_set() from having to access the current_machine global.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc.c | 7 ---
1 file changed, 4
Am 1. März 2024 17:46:07 UTC schrieb Sven Schnelle :
>Export range_list_from_string(), range_contains() and range_list_free()
>to allow plugins to parse filter ranges and match them to avoid
>reimplementing this functionality.
>
>Signed-off-by: Sven Schnelle
>---
> include/qemu/qemu-plugin.h
Am 28. Februar 2024 13:02:55 UTC schrieb BALATON Zoltan :
>On Wed, 28 Feb 2024, BALATON Zoltan wrote:
>> On Tue, 27 Feb 2024, Bernhard Beschow wrote:
>>> Am 27. Februar 2024 21:54:19 UTC schrieb BALATON Zoltan
>>> :
>>>> On Tue, 27 Feb 2024, Bernhard Besc
uses the pci_type argument when pci_enabled
>is true. Since for this machine the argument is not used,
>passing NULL makes more sense.
>
>Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Bernhard Beschow
Am 26. Februar 2024 21:59:07 UTC schrieb Bernhard Beschow :
>As reported by Volker [1], commit 6f6ad2b24582 "hw/i386/pc: Confine system
>
>flash handling to pc_sysfw" causes a regression when specifying the property
>
>`-M pflash0` in the PCI PC machines:
>
> q
Am 27. Februar 2024 21:54:19 UTC schrieb BALATON Zoltan :
>On Tue, 27 Feb 2024, Bernhard Beschow wrote:
>> Am 21. Februar 2024 11:53:21 UTC schrieb Mark Cave-Ayland
>> :
>>> On 18/02/2024 13:16, Bernhard Beschow wrote:
>>>> Port 92 is an integral part o
Am 21. Februar 2024 11:53:21 UTC schrieb Mark Cave-Ayland
:
>On 18/02/2024 13:16, Bernhard Beschow wrote:
>
>> Port 92 is an integral part of the PIIX and ICH south bridges, so
>> instantiate it
>> there. The isapc machine now needs to instantiate it explicitly, anal
Am 26. Februar 2024 11:14:09 UTC schrieb "Philippe Mathieu-Daudé"
:
>Instantiate TYPE_ICH_DMI_PCI_BRIDGE in TYPE_ICH9_SOUTHBRIDGE.
>
>Since the Q35 machine doesn't use it, add the 'd2p-enabled'
>property to disable it.
>
>Signed-off-by: Philippe Mathieu-Daudé
>---
>
Am 26. Februar 2024 11:13:59 UTC schrieb "Philippe Mathieu-Daudé"
:
>Since v1 [1]:
>- Rebased on top of Bernhard patches
>- Rename files with 'ich9_' prefix (Bernhard)
>
>Hi,
>
>I have a long standing southbridge QOM rework branches. Since
>Bernhard is actively working on the PIIX, I'll try to
now until a solution is found.
Best regards,
Bernhard
[1]
https://lore.kernel.org/qemu-devel/9e82a04b-f2c1-4e34-b4b6-46a0581b5...@t-online.de/
Bernhard Beschow (2):
Revert "hw/i386/pc_sysfw: Inline pc_system_flash_create() and remove
it"
Revert "hw/i386/pc: Confine system f
-by: Bernhard Beschow
---
include/hw/i386/pc.h | 2 ++
hw/i386/pc.c | 1 +
hw/i386/pc_piix.c| 1 +
hw/i386/pc_sysfw.c | 6 ++
4 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index e88468131a..0f9c1a45fc 100644
--- a/include/hw/i386
e reverted first.
This reverts commit cb05cc16029bb0a61ac5279ab7b3b90dcf2aa69f.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc_sysfw.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc_sysfw.c b/hw/i386/pc_sysfw.c
index b02e285579..b9c1eb352d 10064
Am 25. Februar 2024 13:03:46 UTC schrieb "Volker Rümelin" :
>Am 21.02.24 um 22:16 schrieb Philippe Mathieu-Daudé:
>> From: Bernhard Beschow
>>
>> Rather than distributing PC system flash handling across three files, let's
>> confine it to one. Now, pc_syste
Am 21. Februar 2024 15:50:33 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 8/2/24 23:03, Bernhard Beschow wrote:
>> There is no advantage in having these local variables which 1/ needlessly
>> have
>> different identifiers in both machines and 2/ which are redu
Am 24. Februar 2024 13:58:45 UTC schrieb Bernhard Beschow :
>The series aims to simplify the initialization process of all PC-based machines
>
>by streamlining redundant code.
>
>
>
>Since I haven't seen patches on the list so far for folding CMOS data
>
>generation
Am 22. Februar 2024 15:25:01 UTC schrieb "Michael S. Tsirkin" :
>On Thu, Feb 08, 2024 at 11:03:40PM +0100, Bernhard Beschow wrote:
>> The series aims to simplify the initialization process of all PC-based
>> machines.
>>
>> It consists of streamlining red
There is no advantage in having these local variables which 1/ needlessly have
different identifiers in both machines and 2/ which are redundant to pcms->bus
which is almost as short.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
---
hw/i386/pc_piix.c | 14 ++
Both the piix and the q35 machines introduce an rtc_state variable and defer the
initialization of the X86MachineState::rtc attribute to pc_cmos_init(). Resolve
this complication which makes pc_cmos_init() do what it says on the tin.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S
Rather than taking a QOM name which has to be resolved, let's pass the parent
directly as pointer. This simplifies the code.
Signed-off-by: Bernhard Beschow
Reviewed-by: Michael S. Tsirkin
---
include/hw/i386/x86.h | 2 +-
hw/i386/microvm.c | 2 +-
hw/i386/pc_piix.c | 7 +++
hw
otted while rebasing
* Patch 6: New patch possible after [1]
Best regards,
Bernhard
[1]
https://patchew.org/QEMU/20240221211626.48190-1-phi...@linaro.org/20240221211626
.48190-10-phi...@linaro.org/
Bernhard Beschow (6):
hw/i386/x86: Let ioapic_init_gsi() take parent as pointer
hw/i386/pc: Re
Now that pc_cmos_init() doesn't populate the X86MachineState::rtc attribute any
longer, its duties can be merged into pc_cmos_init_late() which is called within
machine_done notifier. This frees pc_piix and pc_q35 from explicit CMOS
initialization.
Signed-off-by: Bernhard Beschow
---
include/hw
ed and can be removed.
Fixes: 30d2a17b46e9 "hw/i386: Remove the deprecated machines 0.12 up to 0.15"
Cc: Thomas Huth
Signed-off-by: Bernhard Beschow
---
include/hw/i386/pc.h | 1 -
hw/i386/pc.c | 1 -
hw/i386/pc_piix.c| 2 +-
3 files changed, 1 insertion(+), 3 deletions(-)
The attribute is of type PCIBus; reflect that in the name. It will also make the
next change more intuitive.
Suggested-by: Philippe Mathieu-Daudé
Signed-off-by: Bernhard Beschow
---
include/hw/i386/pc.h | 2 +-
hw/i386/acpi-build.c | 2 +-
hw/i386/amd_iommu.c | 2 +-
hw/i386
Am 21. Februar 2024 09:04:21 UTC schrieb Paolo Bonzini :
>On Tue, Feb 20, 2024 at 11:43 PM Bernhard Beschow wrote:
>>
>>
>>
>> Am 20. Februar 2024 15:53:52 UTC schrieb Paolo Bonzini :
>> >Add a fd-bootchk property to PC machine types, so that -no-fd-bootchk
Am 20. Februar 2024 16:06:14 UTC schrieb Peter Maydell
:
>In the i386 PC machine, we want to run the pc_cmos_init_late()
>function only once the IDE and floppy drive devices have been set up.
>We currently do this using qemu_register_reset(), and then have the
>function call
Am 20. Februar 2024 15:53:52 UTC schrieb Paolo Bonzini :
>Add a fd-bootchk property to PC machine types, so that -no-fd-bootchk
>returns an error if the machine does not support booting from floppies
>and checking for boot signatures therein.
>
>Suggested-by: Philippe Mathieu-Daudé
Am 19. Februar 2024 16:38:46 UTC schrieb "Philippe Mathieu-Daudé"
:
>Expose TYPE_ICH_DMI_PCI_BRIDGE to the new
>"hw/pci-bridge/ich_dmi_pci.h" header.
>
>Signed-off-by: Philippe Mathieu-Daudé
>---
> MAINTAINERS | 1 +
> include/hw/pci-bridge/ich_dmi_pci.h | 20
ok for a one stop solution.
>
>Co-authored-by: Bernhard Beschow
>Signed-off-by: BALATON Zoltan
>---
>v2:
>Move top level title one level up so subsections will be below it in TOC
>
> MAINTAINERS | 1 +
> docs/system/ppc/amigang.rst | 161 ++
Am 18. Februar 2024 16:12:30 UTC schrieb BALATON Zoltan :
>On Sun, 18 Feb 2024, Bernhard Beschow wrote:
>> This series attempts to make QEMU's south bridge families PIIX, ICH9, and VIA
>> 82xx more self-contained by integrating IO port 92 like the originals do.
>>
&g
Am 19. Februar 2024 08:51:07 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 17/2/24 11:46, Bernhard Beschow wrote:
>> The interrupt handlers need to be populated before the device is realized
>> since
>> internal devices such as the RTC are wired during realize(
This function is used once in the pc machines. Remove it since it contains one
line only.
Signed-off-by: Bernhard Beschow
---
include/hw/input/i8042.h | 1 -
hw/i386/pc.c | 2 +-
hw/input/pckbd.c | 5 -
3 files changed, 1 insertion(+), 7 deletions(-)
diff --git
for simplicity.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/pc.h | 2 +-
include/hw/southbridge/ich9.h | 4
include/hw/southbridge/piix.h | 3 +++
hw/i386/pc.c | 18 --
hw/i386/pc_piix.c | 9 +++--
hw/i386/pc_q35.c
Port 92 is an integral part of south bridges. Allow for embedding it there.
South bridges aren't architecture-specific, so move port92.c to hw/isa which is
accessible to other architectures than x86.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/pc.h | 5 -
include/hw/isa
Fixes: fbd758008f0f "hw/isa: extract FDC37M81X to a separate file"
Signed-off-by: Bernhard Beschow
---
hw/isa/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/isa/meson.build b/hw/isa/meson.build
index f650b39507..3219282217 100644
--- a/hw/isa/m
.hu/
-> no regressions compared to master
Best regards,
Bernhard
Bernhard Beschow (5):
hw/isa/meson.build: Sort alphabetically
hw/i386/port92: Allow for TYPE_PORT92 to be embedded in devices
hw/isa: Embed TYPE_PORT92 in south bridges used in PC machines
hw/i386/pc: Inline i8042_setup_a20_line() and
Port 92 is an integral part of the south bridge, so instantiate it there.
Signed-off-by: Bernhard Beschow
---
hw/isa/vt82c686.c | 7 +++
hw/isa/Kconfig| 1 +
2 files changed, 8 insertions(+)
diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index aa91942745..c7b96b3133 100644
--- a/hw
Am 18. Februar 2024 10:47:26 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 17/2/24 11:46, Bernhard Beschow wrote:
>> The interrupt handlers need to be populated before the device is realized
>> since
>> internal devices such as the RTC are wired during realize(
: fc11ca08bc29 "hw/i386/q35: Realize LPC PCI function before accessing it"
Cc: Philippe Mathieu-Daudé
Signed-off-by: Bernhard Beschow
---
hw/i386/pc_q35.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index d346fa3b1d..43675bf
Am 13. Februar 2024 16:00:26 UTC schrieb "Philippe Mathieu-Daudé"
:
>On 13/2/24 16:55, Michael S. Tsirkin wrote:
>> On Tue, Feb 13, 2024 at 01:01:45PM +0100, Philippe Mathieu-Daudé wrote:
>>> Trivial patches removing uses of "hw/i386/pc.h".
>>
>> How did you test that it's indeed unused?
>
>I
mmit message (which is
now fixed) but didn't add an R-b tag so far.
Best regards,
Bernhard
>Reviewed-by: Bernhard Beschow
>Signed-off-by: Paolo Bonzini
>---
> hw/isa/fdc37m81x-superio.c | 32
> hw/isa/isa-superio.c | 18 --
> h
1 - 100 of 1762 matches
Mail list logo
