Re: [Qemu-devel] Wiki spam

2011-07-04 Thread Brad Hards
On Mon, 4 Jul 2011 03:15:06 PM Stefan Hajnoczi wrote: > Thanks. I have a regular wiki account so I checked the Recent Changes > page and undid the spam changes that I saw: > > http://wiki.qemu.org/Special:RecentChanges Is there a way to completely remove it? There is still spam on the wiki showi

Re: [Qemu-devel] [PATCH 08/11] usb-ehci: Fix handling of PED and PEDC port status bits

2011-06-24 Thread Brad Hards
5/11 does this: -#define PORTSC_RO_MASK 0x007021c5 +#define PORTSC_RO_MASK 0x007021c4 before 8/11 does this: > -#define PORTSC_RO_MASK 0x007021c4 > +#define PORTSC_RO_MASK 0x007021c0 You could push those together if there was a v2. I don't think its important though. Eve

[Qemu-devel] [PATCH] doc: Minor typo fix.

2011-06-08 Thread Brad Hards
Thanks to agraf_, stefanha and Snader_LB for their IRC assistance. Thanks to Markus Armbruster and Alexander Graf (again) for their assistance with the second version of this patch. No patch is too simple to test... Signed-off-by: Brad Hards --- qemu-options.hx |4 ++-- 1 files changed, 2

[Qemu-devel] [PATCH] doc: Minor typo fix.

2011-06-08 Thread Brad Hards
Thanks to agraf_, stefanha and Snader_LB for their IRC assistance. Signed-off-by: Brad Hards --- qemu-options.hx |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 82e085a..005c141 100644 --- a/qemu-options.hx +++ b/qemu

Re: [Qemu-devel] [0/7] USB UVC updates

2011-06-06 Thread Brad Hards
On Mon, 6 Jun 2011 07:32:32 PM Natalia Portillo wrote: > I see it ok, have you tested nothing broken? (specially with the &s patch) It doesn't work for me (before or after). The descriptor part (which I've now implemented) works OK (i.e. the guest can dump it), cheese runs in the guest but doesn'

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Brad Hards
I'm still confused. hw/usb-ehci.c line 526 is just a variable declaration: uint8_t *pci_conf; Line 529 looks like an unused assignment, but nothing I see on line 526. Would it be possible for you to double check the work, and possible paste the error message instead of summarising them? Brad

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Brad Hards
Ok, looking at the first example (line 526), I see code that looks like: static inline int ohci_put_iso_td(OHCIState *ohci, uint32_t addr, struct ohci_iso_td *td) { return (put_dwords(ohci, addr, (uint32_t *)td, 4) && put_words(ohci, addr + 16, td-

[Qemu-devel] [Bug 793317] Re: Large amount of write-only variables

2011-06-05 Thread Brad Hards
I don't have a file called hw/usb_ochi.c. Did you mean hw/usb-ohci.c? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/793317 Title: Large amount of write-only variables Status in QEMU: New Bug de

[Qemu-devel] [PATCH 7/7] usb-uvc: Use qemu_malloc()

2011-06-01 Thread Brad Hards
As requested by Blue Swirl (2010-06-10) Signed-off-by: Brad Hards --- hw/usb-uvc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index 1e3d339..d1e71f8 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c @@ -1025,7 +1025,7 @@ static int

qemu-devel@nongnu.org

2011-06-01 Thread Brad Hards
As requested by Blue Swirl (2010-06-10 17:46:16) Signed-off-by: Brad Hards --- hw/usb-uvc.c | 30 +++--- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index 5437a13..661eb1a 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c

[Qemu-devel] [PATCH 6/7] usb-uvc: Fix a couple of typos

2011-06-01 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb-uvc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index 661eb1a..1e3d339 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c @@ -893,7 +893,7 @@ static int usb_uvc_initfn(USBDevice *dev

[Qemu-devel] [PATCH 4/7] usb-uvc: fix some spelling issues.

2011-06-01 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb-uvc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index 20ac23e..5437a13 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c @@ -487,7 +487,7 @@ static int usb_uvc_handle_control(USBDevice *dev

[Qemu-devel] [PATCH 1/7] usb: Turn off debug output by default.

2011-06-01 Thread Brad Hards
Addresses comment by Blue Swirl (2010-06-10 17:46:16) Signed-off-by: Brad Hards --- hw/usb-uvc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index b711f51..e88ee00 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c @@ -31,7 +31,7 @@ #include

[Qemu-devel] [0/7] USB UVC updates

2011-06-01 Thread Brad Hards
Hi Natalia, As you suggested, I've stopped my nonsense and worked from your UVC patches (http://patchwork.ozlabs.org/patch/55001 and http://patchwork.ozlabs.org/patch/55000). These changes are relative to your patches (applied on top of trunk). I've mostly just incorporated some changes requested

[Qemu-devel] [PATCH 2/7] usb-uvc: compile fix

2011-06-01 Thread Brad Hards
Looks like function signature changed. Signed-off-by: Brad Hards --- hw/usb-uvc.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/usb-uvc.c b/hw/usb-uvc.c index e88ee00..c9c8f77 100644 --- a/hw/usb-uvc.c +++ b/hw/usb-uvc.c @@ -307,8 +307,9 @@ static void

[Qemu-devel] [PATCH 1/3] usb: Add defines for USB Serial Bus Release Number register

2011-06-01 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb.h |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index 9882400..2c051b3 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -26,6 +26,12 @@ #include "qdev.h" #include "qemu-queue.h" +/* Constant

[Qemu-devel] [0/3] usb: use defines instead of magic numbers for USB serial bus release number

2011-06-01 Thread Brad Hards
There is some commonality between the UHCI and EHCI (and xHCI, future) drivers. So we can make nice defines instead of magic numbers. usb-ehci.c |2 +- usb-uhci.c |2 +- usb.h |6 ++ 3 files changed, 8 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH 3/3] usb: Use defines for serial bus release number register for EHCI

2011-06-01 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb-ehci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c index f63519e..81b9d0b 100644 --- a/hw/usb-ehci.c +++ b/hw/usb-ehci.c @@ -1970,7 +1970,7 @@ static int usb_ehci_initfn(PCIDevice *dev

Re: [Qemu-devel] [PATCH 5/5] QMP: add server mode to QEMUMonitorProtocol

2011-06-01 Thread Brad Hards
On Thu, 2 Jun 2011 01:54:05 AM Luiz Capitulino wrote: > QEMU supports socket chardevs that establish connections like a server > or a client. Is this protocol documented anywhere? Brad

[Qemu-devel] [PATCH 2/3] usb: Use defines for serial bus release number register for UHCI

2011-06-01 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb-uhci.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index c0de05b..d9c86ad 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@ -1098,7 +1098,7 @@ static int usb_uhci_common_initfn(UHCIState *s

Re: [Qemu-devel] Webcams under KVM and Linux

2011-05-30 Thread Brad Hards
On Tue, 31 May 2011 09:39:02 AM Natalia Portillo wrote: > > Natalia: if possible, could you provide an overview of your work in this > > area? > > The best should be for you to check for the patches I sent (june 2010 on > the ML) and enhance what is left to be done. Sorry I wasn't clear. I'll try

Re: [Qemu-devel] Webcams under KVM and Linux

2011-05-30 Thread Brad Hards
On Mon, 30 May 2011 08:38:35 pm Gerd Hoffmann wrote: > I think people are also working on camera emulation, i.e. pass any (even > non-usb) v4l devices as usb webcam to the guest. No idea what the > status here is. I have it in early development. Its far from complete - just enough for the softwar

Re: [Qemu-devel] The process of kernel cross-compiling in arm-test-0.2.tar.gz

2011-05-23 Thread Brad Hards
On Monday 23 May 2011 19:26:45 daixiaoke wrote: > 3.Compiled uClinux following steps in the attachment(Chapter 4: Building > the uClinux image). “STM3210E-EVAL-jffs” was selected for "Porduct" while > Configure uClinux for STM3210E-EVAL. So you have built the images to install into a STM3210E board

[Qemu-devel] [Bug 618533] Re: OpenSolaris guest fails to see the Solaris partitions of a physical disk in qemu-kvm-9999 (GIT)

2011-05-22 Thread Brad Hards
Did this change get submitted? Is it still an issue? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/618533 Title: OpenSolaris guest fails to see the Solaris partitions of a physical disk in qemu-k

Re: [Qemu-devel] mouse doesn't work on guest OS

2011-05-21 Thread Brad Hards
> valuable for me. A clear, explicit problem description will make this a lot easier. You still haven't answered all of my questions, and you still haven't described what you've done to try to debug this problem. > On Sat, May 21, 2011 at 5:44 AM, Brad Hards wrote: &g

Re: [Qemu-devel] mouse doesn't work on guest OS

2011-05-20 Thread Brad Hards
On Friday 20 May 2011 23:59:25 Amirali Shambayati wrote: > Mouse doesn't work on guest ubuntu. You need to debug it, as if it was real hardware. > But none of them worked for me. any help is appreciated. This isn't a very in-depth problem description. Remember that we can't see your screen. Does

Re: [Qemu-devel] [PATCH v2] Add an isa device for SGA

2011-05-16 Thread Brad Hards
On Thu, 12 May 2011 10:55:13 pm Glauber Costa wrote: > This patch adds a dummy legacy ISA device whose responsibility is to > deploy sgabios, an option rom for a serial graphics adapter. > The proposal is that this device is always-on when -nographics, > but can otherwise be enable in any setup whe

Re: [Qemu-devel] -net interface association behavior change in current -git.

2011-05-12 Thread Brad Hards
On Fri, 13 May 2011 03:19:42 AM Vincent Palatin wrote: > > Does the kernel need some sort of vlan support compiled into it for this > > to work, or can the kernel not care? > > You don't need anything in your kernel, this is for Qemu network layer > configuration. Just to explain a bit further: qe

Re: [Qemu-devel] [PATCH 0/2] usb-linux: physical port handling.

2011-05-10 Thread Brad Hards
On Tuesday 10 May 2011 12:30:41 Gerd Hoffmann wrote: > Hi, > > These patches fix and improve the physical port handling in the usb host > driver. Passthrough of devices connected via usb hub should work better > now. Also you can specify usb devices for passthrough by physical port > (on the h

Re: [Qemu-devel] [PATCH 1/2] Add documentation for qemu_progres_print()

2011-05-06 Thread Brad Hards
On Fri, 6 May 2011 07:39:10 PM jes.soren...@redhat.com wrote: > +/* > + * Add delta to current state, and print the output if the current > + * state has progressed more than min_skip since the last value was > + * printed. 'max' specifies the relative percentage, ie. a function > + * can count for

Re: [Qemu-devel] [PATCH] doc: Add explanation that -alt-grab and -ctrl-grab affect special keys

2011-05-03 Thread Brad Hards
ping?

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-29 Thread Brad Hards
On Thursday 28 April 2011 20:46:25 Gerd Hoffmann wrote: > I think it would be much better to keep track of the mouse position (and > button state while being at it) in input.c instead of monitor.c. > > Once this is in place it should be easy to add kbd_mouse_* functions > which update position or

[Qemu-devel] [PATCH] doc: Add explanation that -alt-grab and -ctrl-grab affect special keys

2011-04-29 Thread Brad Hards
suggested by Phillip in the bug report. Signed-off-by: Brad Hards --- qemu-doc.texi |6 +- qemu-options.hx |6 -- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 86e017c..d96a6ab 100644 --- a/qemu-doc.texi +++ b/qemu-doc.texi @@ -278,7

[Qemu-devel] [Bug 568614] Re: x86_64 host curses interface: spacing/garbling

2011-04-27 Thread Brad Hards
Hi Devin, Can you test if this bug still exists with 0.14 (or better still, a git build)? Brad -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/568614 Title: x86_64 host curses interface: spacing/ga

[Qemu-devel] [Bug 705931] Re: make ui sdl error 1 on git devel

2011-04-27 Thread Brad Hards
Hi, Thanks for reporting this issue. I'm not able to repeat the problem (although I have no slackware), and the bug does look strange. Can you update (git pull) and try again? Can you confirm that you are using git://git.qemu.org/qemu.git? If it still fails, can you look at the problem file (ui

[Qemu-devel] [Bug 696530] Re: qemu-0.13.0-r2 special keys different when using -alt-grab

2011-04-27 Thread Brad Hards
Hi, Thanks for reporting this issue - sorry it takes a while to get these addressed. I've looked at the code, and the modifiers are handled specially depending on the command line option, so I think it is the intended behaviour. I've update the docs (and submitted a patch) to make it clearer. --

Re: [Qemu-devel] [PATCH 4/6] docs/tracing.txt: minor documentation fixes

2011-04-26 Thread Brad Hards
On Tue, 26 Apr 2011 10:26:01 pm Stefan Hajnoczi wrote: > -There is a set of static trace events declared in the trace-events source > +There is a set of static trace events declared in the "trace-events" > source Would it read better if it said "There are a set..." (i.e. "are" instead of "is")? B

[Qemu-devel] [RFC] Removing old command line options

2011-04-24 Thread Brad Hards
I've been trying to update the documentation (currently on neworking), and one of the things that makes it hard is that there are a few old (legacy) command line options (e.g. --tftp). Removing them is easy, but not really nice to users who depend on them. So I was thinking about a migration appro

Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-24 Thread Brad Hards
On Thursday 14 April 2011 08:01:43 Brad Hards wrote: > On Wed, 13 Apr 2011 10:52:37 pm Hans de Goede wrote: > > > @@ -359,7 +359,7 @@ static int usb_host_claim_interfaces(USBHostDevice > > > *dev, int configuration) > > > > > > ret = ioctl(dev-

[Qemu-devel] [PATCH] doc: fix slirp description

2011-04-24 Thread Brad Hards
*/ struct in_addr dhcp = { .s_addr = htonl(0x0a00020f) }; /* 10.0.2.15 */ struct in_addr dns = { .s_addr = htonl(0x0a000203) }; /* 10.0.2.3 */ Which I think is not what the documentation says. Signed-off-by: Brad Hards --- qemu-options.hx |4 ++-- 1 files changed, 2 insertions(+), 2

[Qemu-devel] [Bug 662461] Re: -name error message should have trailing newline

2011-04-23 Thread Brad Hards
It looks like this change (or equivalent) was applied by Aurelien Jarno in 5697f6ae4183f3b3320a1fe677e3404a05e75783 Thanks for reporting it and providing the fix. ** Changed in: qemu Status: New => Fix Committed -- You received this bug notification because you are a member of qemu- deve

[Qemu-devel] [PATCH] vl: trivial spelling fix

2011-04-23 Thread Brad Hards
Signed-off-by: Brad Hards --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index 68c3b53..b46ee66 100644 --- a/vl.c +++ b/vl.c @@ -756,7 +756,7 @@ void add_boot_device_path(int32_t bootindex, DeviceState *dev, /* * This function returns null

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-04-22 Thread Brad Hards
On Friday 22 April 2011 19:48:09 Peter Maydell wrote: > Looking at your .rej file it seems to have lost the hardcoded tab > characters[*] that are in the patch; I suspect something in your mailer > is turning them back into spaces. Try downloading the patch from > patchwork instead. Yep, that worke

Re: [Qemu-devel] [PATCH] target-arm: Minimal implementation of performance counters

2011-04-22 Thread Brad Hards
On Friday 22 April 2011 02:01:48 Peter Maydell wrote: > Newer Linux kernels assume the existence of the performance counter > cp15 registers. Provide a minimal implementation of these registers. > We support no events. This should be compliant with the ARM ARM, > except that we don't implement the

Re: [Qemu-devel] [OOT] gcc trick to help studying Qemu source

2011-04-22 Thread Brad Hards
On Tuesday 19 April 2011 19:07:39 Mulyadi Santosa wrote: > Hopefully it's useful for everybody, especially newbie like me. I added a note about this to the wiki. Perhaps you may like to expand / enhance it: http://wiki.qemu.org/Documentation/GettingStartedDevelopers#Getting_to_know_the_code Brad

[Qemu-devel] [PATCH] usb-uhci: Use defines for base address registers, instead of magic numbers

2011-04-21 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb-uhci.c | 58 ++-- hw/usb.h |6 + 2 files changed, 41 insertions(+), 23 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 346db3e..210b918 100644 --- a/hw/usb-uhci.c +++ b/hw/usb

Re: [Qemu-devel] Bug #757654: UHCI fails to signal stall response patch

2011-04-15 Thread Brad Hards
On Sat, 16 Apr 2011 06:57:00 am Jan Vesely wrote: > +s->status |= UHCI_STS_USBERR; This is per UHCI 1.1D Section 4.1.5. Looks good. > +*int_mask |= 0x02; > +if (td->ctrl & TD_CTRL_IOC) > +*int_mask |= 0x01; > +uhci_update_irq(s); I see "A hardware interr

Re: [Qemu-devel] Para-virtualized ram-based filesystem?

2011-04-15 Thread Brad Hards
On Saturday 16 April 2011 09:58:32 Ritchie, Stuart wrote: > How does that sound? As a general user: Confusing. Is there a concrete example (specific applications, specific performance issues, specific requirements) that you can share? Brad

Re: [Qemu-devel] [PATCH] Clean up after "make pdf"

2011-04-14 Thread Brad Hards
On Wednesday 13 April 2011 16:42:16 Brad Hards wrote: > --- > .gitignore |3 +++ > Makefile |5 - > 2 files changed, 7 insertions(+), 1 deletions(-) Signed-off-by: Brad Hards Sorry about that. Brad

Re: [Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-13 Thread Brad Hards
On Wed, 13 Apr 2011 10:52:37 pm Hans de Goede wrote: > > @@ -359,7 +359,7 @@ static int usb_host_claim_interfaces(USBHostDevice > > *dev, int configuration) > > > > ret = ioctl(dev->fd, USBDEVFS_CLAIMINTERFACE,&interface); > > if (ret< 0) { > > if (errno == EBUSY)

[Qemu-devel] [PATCH 4/4] usb: use DPRINTF instead of printf for some simple cases

2011-04-13 Thread Brad Hards
Signed-off-by: Brad Hards --- usb-linux.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 1f33c2c..b02a0f9 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -233,8 +233,8 @@ static void async_complete(void *opaque

[Qemu-devel] [PATCH 2/4] usb: initialise data element in Linux USB_DISCONNECT ioctl.

2011-04-13 Thread Brad Hards
This isn't used, but leaving it empty causes valgrind noise. Signed-off-by: Brad Hards --- usb-linux.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index 255009f..d958853 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -344,6 +344,7 @@ s

[Qemu-devel] [PATCH 3/4] usb: fix spelling errors in usb-linux.c

2011-04-13 Thread Brad Hards
Signed-off-by: Brad Hards --- usb-linux.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/usb-linux.c b/usb-linux.c index d958853..1f33c2c 100644 --- a/usb-linux.c +++ b/usb-linux.c @@ -107,7 +107,7 @@ enum { /* * Control transfer state. * Note that 'b

[Qemu-devel] [PATCH 1/4] usb: trivial spelling fixes

2011-04-13 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb-msd.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb-msd.c b/hw/usb-msd.c index 76f5b02..947fd3f 100644 --- a/hw/usb-msd.c +++ b/hw/usb-msd.c @@ -33,7 +33,7 @@ do { printf("usb-msd: " fmt , ## __VA_ARGS__);

[Qemu-devel] [PATCH 0/4] Minor USB fixes

2011-04-13 Thread Brad Hards
1 fixes spellos in the mass-storage driver 2-4 fix issues in Linux usb pass-through code.

[Qemu-devel] [PATCH] Clean up after "make pdf"

2011-04-12 Thread Brad Hards
--- .gitignore |3 +++ Makefile |5 - 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index 1d79680..08013fc 100644 --- a/.gitignore +++ b/.gitignore @@ -44,6 +44,9 @@ QMP/qmp-commands.txt *.ky *.log *.pdf +*.cps +*.fns +*.kys *.pg *.pyc *

[Qemu-devel] [Bug 757654] Re: UHCI fails to signal stall response

2011-04-11 Thread Brad Hards
Hi, Thanks for reporting this issue. Just so you are aware: the qemu USB maintainer is probably going to be away for a while longer, so don't be too worried if this patch doesn't get looked at for 2-4 weeks. Brad -- You received this bug notification because you are a member of qemu- devel-ml,

Re: [Qemu-devel] [PATCH 4/4] qxl: allow QXL_IO_LOG also in vga

2011-04-10 Thread Brad Hards
On Sun, 10 Apr 2011 08:26:06 pm Alon Levy wrote: > -if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT) > +if (d->mode == QXL_MODE_NATIVE || d->mode == QXL_MODE_COMPAT > +|| (io_port == QXL_IO_LOG)) I think this might look better with consistent use of brackets

[Qemu-devel] qemu_malloc failing

2011-04-09 Thread Brad Hards
Hi, I'm trying to investigate a bug (crash) that I see when attaching a USB device (a UVC webcam) from the host to the guest. I'm running it as: sudo gdb --args /opt/bin/qemu -hda ubuntu-test -name kubuntu-qemu -usb -device usb-tablet -m 1024 -serial stdio -usbdevice host:0c45:6450 (I've tried

[Qemu-devel] [Bug 721659] Re: qemu-kvm-0.13.0 doesn't pass USB devices to the VM

2011-04-09 Thread Brad Hards
Hi, Thanks for reporting this problem. Can you tell me a bit more about your configuration? For example: What are the guest and host operating systems? Is it always "need -1"? Do you ever see "need 1"? What is the device you're trying to open? Can you show the USB descriptors (e.g. from lsusb)?

[Qemu-devel] [Bug 663713] Re: Mouse frozen under an emulated ubuntu

2011-04-08 Thread Brad Hards
0.14 is out, so close bug report. ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/663713 Title: Mouse frozen under an emulated ubuntu S

[Qemu-devel] [Bug 663713] Re: Mouse frozen under an emulated ubuntu

2011-04-08 Thread Brad Hards
I'm not sure I understand you. I'm confused about whether you think qemu is "dead", or the bug is "dead", and what the relationship with gwibber is. Can you state whether, in your opinion / experience, a current version of qemu still has this bug or not? -- You received this bug notification bec

[Qemu-devel] [Bug 691424] Re: qemu/kvm SDL over ssh -X broken

2011-04-08 Thread Brad Hards
Hi, I tried this with a current (git) build, and I'm not able to reproduce it. I do see a problem with a bad initial SDL window size (its much too small) on a remote machine over a moderate-level network (wireless LAN). I don't see that when ssh-ing to localhost (even though both hosts are basica

[Qemu-devel] [Bug 663713] Re: Mouse frozen under an emulated ubuntu

2011-04-08 Thread Brad Hards
Fred, Can you test a current version and confirm that everything is OK now? Brad -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/663713 Title: Mouse frozen under an emulated ubuntu Status in QEMU

[Qemu-devel] [PATCH] event: trivial coding style fixes.

2011-04-08 Thread Brad Hards
Signed-off-by: Brad Hards --- input.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/input.c b/input.c index ec05548..5664d3a 100644 --- a/input.c +++ b/input.c @@ -161,15 +161,15 @@ void kbd_mouse_event(int dx, int dy, int dz, int buttons_state

[Qemu-devel] [Bug 754635] Re: -d option outs wrong info about sections

2011-04-08 Thread Brad Hards
Hi, Thanks for reporting this issue, and the investigation. I don't really understand the rationale for the change, so I can't help much. This change appears to be from 5cd2c5b6ad75c46d40118ac67c0c09d4e7930a65. I think input from Richard Henderson (the author of the change) would be very useful.

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Brad Hards
On Sat, 9 Apr 2011 12:34:21 am Markus Armbruster wrote: > There's one instance of state: position (if absolute) + buttons for any > number of mice. Funny things can happen when you have more than one > mouse and switch between them. For the common case (in most OS), each of the mice are mixed toge

Re: [Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Brad Hards
On Fri, 8 Apr 2011 05:44:00 pm Brad Hards wrote: > I've tested this with a kubuntu 10.10 guest and it works fine > for me with both relative and absolute pointing devices. Note > that testing with realtive pointing device was relatively > light. This fix (in slightly different f

[Qemu-devel] [PATCH] monitor: avoid moving cursor during "mouse_button" command

2011-04-08 Thread Brad Hards
ative and absolute pointing devices. Note that testing with realtive pointing device was relatively light. Signed-off-by: Brad Hards --- monitor.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/monitor.c b/monitor.c index f1a08dc..0ce162b 100644 --- a/moni

[Qemu-devel] [Bug 752476] Re: monitor command mouse_button 1 moves mouse

2011-04-07 Thread Brad Hards
Can you try the attached patch? ** Patch added: "0001-monitor-Avoid-moving-the-cursor-when-doing-mouse_but.patch" https://bugs.launchpad.net/qemu/+bug/752476/+attachment/1998150/+files/0001-monitor-Avoid-moving-the-cursor-when-doing-mouse_but.patch -- You received this bug notification beca

[Qemu-devel] [Bug 753916] Re: performance bug with SeaBios 0.6.x

2011-04-07 Thread Brad Hards
OK, from your test.swf file, I assume that the way you're testing is the boot-up of a Linux ISO, and that "100%" is an estimate of boot speed. I'm really not sure what the problem is. I can only suggest that you try various SeaBIOS versions and try to isolate which version is the problem. It also

[Qemu-devel] [Bug 752476] Re: monitor command mouse_button 1 moves mouse

2011-04-07 Thread Brad Hards
Hi. Thanks for reporting this issue. I'm able to (partly) reproduce this, but it might help if I could understand your configuration a bit more. Does mouse movement work for you using the normal interface (SDL or VNC)? Do you have the pointer device configured in an absolute mode (e.g. something

[Qemu-devel] [Bug 753916] Re: performance bug with SeaBios 0.6.x

2011-04-07 Thread Brad Hards
Hi. Thanks for reporting this issue. Can you tell us a bit more about the problem? I'm not sure what the cause could be, but perhaps we can understand it better with some of the following information (plus anything else you can think of that could be related): - What version of QEMU are you run

Re: [Qemu-devel] [PATCH RFC 0/5] kvm/vhost: enable durty logging during memory registration

2011-04-06 Thread Brad Hards
On Thu, 7 Apr 2011 06:41:35 am Michael S. Tsirkin wrote: > As a solution, this adds an explicit flag that > will enable dirty logging directly when registering > the ram. kvm then needs a single system call > to update tables for vga ram, vhost-net can simply ignore it. I'm not very familiar with Q

Re: [Qemu-devel] [PATCH] hw: improve multiboot module loading

2011-04-06 Thread Brad Hards
On Thu, 7 Apr 2011 10:19:01 am r...@humppa.name wrote: > Signed-off-by: Looks like something may be wrong with your git config Brad

[Qemu-devel] [Bug 688052] Re: usb does not work 0.13.0

2011-04-05 Thread Brad Hards
Thanks for the report. For the second part, you need to clone using the git protocol (git clone git://git.qemu.org/qemu.git as shown in http://wiki.qemu.org/Download#Latest_Source_Code). The http bit appears broken for now. I'm not sure about the first part yet - certainly trying a more recent

[Qemu-devel] [Bug 645524] Re: No picture from USB webcam (kvm 0.13-rc1)

2011-04-05 Thread Brad Hards
Thanks for the report. Can you tell me if it works with a Linux guest? Can you tell me what kind of camera it is (e.g. the descriptors from lsusb -v for the device)? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launc

[Qemu-devel] [Bug 521994] Re: Windows 98 doesn't detect mouse on qemu and SeaBIOS.

2011-04-05 Thread Brad Hards
Looks like this is fixed in qemu. ** Changed in: qemu Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/521994 Title: Windows 98 doesn't detect mouse on qemu

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-05 Thread Brad Hards
On Tue, 5 Apr 2011 06:29:48 pm Alexander Graf wrote: > > quality and resubmission. It would also help to have some explanatory > > text for some of the architectural docs that are available (e.g. there > > is a lot of words on the wiki about QED, and I guess its some kind of > > storage / disk thin

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-05 Thread Brad Hards
On Tue, 5 Apr 2011 08:53:21 pm Stefan Hajnoczi wrote: > scripts/checkpatch.pl is mentioned in CODING_STYLE. I have a git-hook > to automatically run it: > http://blog.vmsplice.net/2011/03/how-to-automatically-run-checkpatchpl.html > > That hook is just a personal tool I use. It is not required b

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-05 Thread Brad Hards
On Tue, 5 Apr 2011 06:29:48 pm Alexander Graf wrote: > What exactly do you mean by better-practice git setups? Some projects try to use special features in git. For example, KDE makes use of insteadOf and pushInsteadOf to allow checking out from anongit, and committing to the main server using a

Re: [Qemu-devel] KVM call agenda for April 05

2011-04-04 Thread Brad Hards
On Tue, 5 Apr 2011 05:59:27 am Anthony Liguori wrote: > - Trivial patch monkeys^Wteam -- this is an idea Stefan and I have been > kicking around to help some of the trivial patches get more attention on > the mailing list I saw a wiki page (http://wiki.qemu.org/Contribute/TrivialPatches) that I as

[Qemu-devel] [PATCH] Minor spelling mistakes in hw/usb-ccid.c

2011-04-04 Thread Brad Hards
Brad Hards Date: Tue, 5 Apr 2011 07:39:10 +1000 Subject: [PATCH] usb-ccid: spelling fixes. Signed-off-by: Brad Hards --- hw/usb-ccid.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/usb-ccid.c b/hw/usb-ccid.c index 44156cc..079b4a2 100644 --- a/hw/usb-ccid.c

Re: [Qemu-devel] A question about qemu 0.9.1

2011-04-04 Thread Brad Hards
On Mon, 4 Apr 2011 08:10:55 pm y y wrote: > op_movl_A0_EAX() come from? I think its a pre-processor generated thing. So to find it, I think you need to find the parts (like INDEX_op in one pre- processor command, and the rest in another place), and how it is pasted together. HTH. Brad

[Qemu-devel] [PATCH 3/4] usb: remove fallback to bNumInterfaces if no .nif

2011-04-02 Thread Brad Hards
All callers have been updated. Signed-off-by: Brad Hards --- hw/usb-desc.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 62591f2..a784155 100644 --- a/hw/usb-desc.c +++ b/hw/usb-desc.c @@ -76,7 +76,7 @@ int usb_desc_config(const

[Qemu-devel] [PATCH 4/4] usb: add support for "grouped" interfaces and the Interface Association Descriptor

2011-04-02 Thread Brad Hards
handles this case. Signed-off-by: Brad Hards --- hw/usb-desc.c | 47 +++ hw/usb-desc.h | 20 hw/usb.h |1 + 3 files changed, 68 insertions(+), 0 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index a784155

[Qemu-devel] [PATCH 2/4] usb: update config descriptors to identify number of interfaces

2011-04-02 Thread Brad Hards
Previously we relied on the .bNumInterfaces, but that won't always be accurate after the introduction of grouped interfaces. Signed-off-by: Brad Hards --- hw/usb-hid.c|3 +++ hw/usb-hub.c|1 + hw/usb-msd.c|2 ++ hw/usb-serial.c |1 + hw/usb-wacom.c |1 + 5

[Qemu-devel] [PATCH 1/4] usb: Add Interface Association Descriptor descriptor type

2011-04-02 Thread Brad Hards
Signed-off-by: Brad Hards --- hw/usb.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index d3d755d..418853f 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -124,6 +124,7 @@ #define USB_DT_ENDPOINT0x05 #define

[Qemu-devel] [PATCH v2 0/4]usb: implement Interface Association Descriptor support

2011-04-02 Thread Brad Hards
These descriptors are covered in Section 9.6.4 of the USB 3.0 spec, but there is a better description in the Intel IAD whitepaper (www.usb.org/developers/whitepapers/iadclasscode_r10.pdf). The short version is that IAD is an extra descriptor type that appears before a group (two or more) interf

[Qemu-devel] [PATCH 0/4] usb: implement Interface Association Descriptor support

2011-03-28 Thread Brad Hards
This patchset implements Interface Association Descriptor suppoort. These descriptors are covered in Section 9.6.4 of the USB 3.0 spec, but there is a better description in the Intel IAD whitepaper (www.usb.org/developers/whitepapers/iadclasscode_r10.pdf). The short version is that IAD is an ex

[Qemu-devel] [PATCH 3/4] usb: remove fallback to bNumInterfaces if no .nif

2011-03-28 Thread Brad Hards
All callers have been updated. --- hw/usb-desc.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/usb-desc.c b/hw/usb-desc.c index 62591f2..a784155 100644 --- a/hw/usb-desc.c +++ b/hw/usb-desc.c @@ -76,7 +76,7 @@ int usb_desc_config(const USBDescConfig *conf, uint8_t

[Qemu-devel] [PATCH 4/4] usb: add support for "grouped" interfaces and the Interface Association Descriptor

2011-03-28 Thread Brad Hards
This is used for some devices that have multiple interfaces that form a logic device. An example is Video Class, which has a Control interface and a Streaming interface. There can be additional interfaces on the same (physical) devices (e.g. a microphone), and Interface Association Descriptor handl

[Qemu-devel] [PATCH 2/4] usb: update config descriptors to identify number of interfaces

2011-03-28 Thread Brad Hards
Previously we relied on the .bNumInterfaces, but that won't always be accurate after the introduction of grouped interfaces. --- hw/usb-hid.c|3 +++ hw/usb-hub.c|1 + hw/usb-msd.c|2 ++ hw/usb-serial.c |1 + hw/usb-wacom.c |1 + 5 files changed, 8 insertions(+), 0

[Qemu-devel] [PATCH 1/4] usb: Add Interface Association Descriptor descriptor type

2011-03-28 Thread Brad Hards
--- hw/usb.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/usb.h b/hw/usb.h index d3d755d..418853f 100644 --- a/hw/usb.h +++ b/hw/usb.h @@ -124,6 +124,7 @@ #define USB_DT_ENDPOINT0x05 #define USB_DT_DEVICE_QUALIFIER 0x06 #define USB_

[Qemu-devel] Request for suggestions: USB Interface Association Descriptors

2011-03-25 Thread Brad Hards
Hi, I've just started the learning process on QEMU, and am trying to create a USB webcam virtual device (targetting the Linux UVC driver). So far, I'm able to create the device, plug it in (thanks to those involved in qdev), and inspect the descriptor. The problem is building the descriptor, a

Re: [Qemu-devel] [PATCH 0/2] Let boards state maximum RAM limits in QEMUMachine struct

2011-03-21 Thread Brad Hards
On Tue, 22 Mar 2011 04:47:18 am Peter Maydell wrote: > This fairly simple patchset adds a new 'max_ram' field to the QEMUMachine > structure so that a board model can specify the maximum RAM it will accept. > We can then produce a friendly diagnostic message when the user tries to > start qemu with