macOS 10.12 deprecated/replaced many AppKit constants to make naming
more consistent. Use the new constants, and #define them to the
old constants when compiling against a pre-10.12 SDK.
Signed-off-by: Brendan Shanks
---
ui/cocoa.m | 87
available.
Signed-off-by: Brendan Shanks
---
ui/cocoa.m | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index ddc058e76e..e2567d6946 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -54,6 +54,9 @@
#ifndef MAC_OS_X_VERSION_10_12
Public bug reported:
Commit 8bb93c6f99a42c2e0943bc904b283cd622d302c5 ("ui/console: ensure
graphic updates don't race with TCG vCPUs") causes the graphic update to
run on a non-main thread, which Cocoa is not happy with. It crashes
immediately after startup.
$ i386-softmmu/qemu-system-i386
2017-0
Tested on 10.12.3, it doesn't crash immediately (like before) but
crashes reliably once I send some keyboard input to qemu:
$ i386-softmmu/qemu-system-i386
**
ERROR:/Users/pip/no_backup/qemu/translate-common.c:34:tcg_handle_interrupt:
assertion failed: (qemu_mutex_iothread_locked())
Abort trap:
The keyboard input issue looks the same as #1675549, and that's on
Linux/SDL. So not specific to this fix or Cocoa.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1675108
Title:
Cocoa UI always cras
I just did a quick test on 10.12.3 with those two patches and didn't get
any crashes
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1675108
Title:
Cocoa UI always crashes on startup
Status in QEMU:
Fixed in -rc2, closing.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1675108
Title:
Cocoa UI always crashes on startup
Status in QEMU:
Fi
