Re: [PATCH 1/8] hmat acpi: Don't require initiator value in -numa

2022-07-17 Thread Brice Goglin
Le 18/07/2022 à 05:17, Liu, Jingqi a écrit : On 7/11/2022 6:44 PM, Hesham Almatary via wrote: From: Brice Goglin The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently always set because Qe

Re: [PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Brice Goglin
Le 30/06/2022 à 14:23, Igor Mammedov a écrit : On Thu, 30 Jun 2022 09:36:47 +0200 Brice Goglin wrote: Allow -numa without initiator value when hmat=on so that we may build more complex topologies, e.g. NUMA nodes whose best initiators are not just another single node. patches looks fine

[PATCH v4 3/4] tests: acpi: q35: add test for hmat nodes without initiators

2022-06-30 Thread Brice Goglin
0: 01 00 00 00 40 00 00 00 00 03 00 00 02 00 00 00 // @... 00F0: 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 // 0100: 00 00 00 00 01 00 00 00 00 00 00 00 01 00 00 00 // 0110: 02 00 00 00 0A 00 05 00 01 00 05 00 0A 00 01 00 //

[PATCH v4 4/4] tests: acpi: q35: update expected blobs *.hmat-noinitiators

2022-06-30 Thread Brice Goglin
02 00 00 00 // @... 00F0: 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 // 0100: 00 00 00 00 01 00 00 00 00 00 00 00 01 00 00 00 // 0110: 02 00 00 00 0A 00 05 00 01 00 05 00 0A 00 01 00 // Signed-off-by: Brice Gogl

[PATCH v4 2/4] tests: acpi: add and whitelist *.hmat-noinitiator expected blobs

2022-06-30 Thread Brice Goglin
.. which will be used by follow up hmat-noinitiator test-case. Signed-off-by: Brice Goglin Acked-by: Igor Mammedov Reviewed-by: Jonathan Cameron --- tests/data/acpi/q35/APIC.acpihmat-noinitiator | 0 tests/data/acpi/q35/DSDT.acpihmat-noinitiator | 0 tests/data/acpi/q35/FACP.acpihmat

[PATCH v4 1/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Brice Goglin
[11Eh 0286 2] Entry : 0001 Signed-off-by: Brice Goglin Reviewed-by: Jonathan Cameron --- hw/core/machine.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index a673302cce..d4d7e77401 100644 --- a/hw/core/machine.c +

[PATCH v4 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-30 Thread Brice Goglin
v1->v2: * add q35 acpi test Brice Goglin (4): hmat acpi: Don't require initiator value in -numa tests: acpi: add and whitelist *.hmat-noinitiator expected blobs tests: acpi: q35: add test for hmat nodes without initiators tests: acpi: q35: update expected blobs *.hmat-noinitia

[PATCH v3 1/4] hmat acpi: Don't require initiator value in -numa

2022-06-29 Thread Brice Goglin
[11Eh 0286 2] Entry : 0001 Signed-off-by: Brice Goglin Reviewed-by: Jonathan Cameron --- hw/core/machine.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index a673302cce..d4d7e77401 100644 --- a/hw/core/machine.c +

[PATCH v3 4/4] tests: acpi: q35: update expected blobs *.hmat-noinitiators

2022-06-29 Thread Brice Goglin
02 00 00 00 // @... 00F0: 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 // 0100: 00 00 00 00 01 00 00 00 00 00 00 00 01 00 00 00 // 0110: 02 00 00 00 0A 00 05 00 01 00 05 00 0A 00 01 00 // Signed-off-by: Brice Gogl

[PATCH v3 3/4] tests: acpi: q35: add test for hmat nodes without initiators

2022-06-29 Thread Brice Goglin
@... 00F0: 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 // 0100: 00 00 00 00 01 00 00 00 00 00 00 00 01 00 00 00 // 0110: 02 00 00 00 0A 00 05 00 01 00 05 00 0A 00 01 00 // Signed-off-by: Brice Goglin Reviewed-by: Jon

[PATCH v3 2/4] tests: acpi: add and whitelist *.hmat-noinitiator expected blobs

2022-06-29 Thread Brice Goglin
.. which will be used by follow up hmat-noinitiator test-case. Signed-off-by: Brice Goglin Reviewed-by: Jonathan Cameron --- tests/data/acpi/q35/APIC.acpihmat-noinitiator | 0 tests/data/acpi/q35/DSDT.acpihmat-noinitiator | 0 tests/data/acpi/q35/FACP.acpihmat-noinitiator | 0 tests/data/acpi

[PATCH v3 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-29 Thread Brice Goglin
Allow -numa without initiator value when hmat=on so that we may build more complex topologies, e.g. NUMA nodes whose best initiators are not just another single node. changes v2->v3: * improve messages for patches 0/4 and 3/4 changes v1->v2: * add q35 acpi test Brice Goglin (4): hma

Re: [PATCH 1/4] hmat acpi: Don't require initiator value in -numa

2022-06-28 Thread Brice Goglin
Le 28/06/2022 à 16:19, Igor Mammedov a écrit : On Thu, 23 Jun 2022 16:58:28 +0200 Brice Goglin wrote: The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently always set because Qemu -numa requires

[PATCH 4/4] tests: acpi: q35: update expected blobs *.hmat-noinitiators

2022-06-23 Thread Brice Goglin
02 00 00 00 // @... 00F0: 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 // 0100: 00 00 00 00 01 00 00 00 00 00 00 00 01 00 00 00 // 0110: 02 00 00 00 0A 00 05 00 01 00 05 00 0A 00 01 00 // Signed-off-by: Brice G

[PATCH 2/4] tests: acpi: add and whitelist *.hmat-noinitiator expected blobs

2022-06-23 Thread Brice Goglin
.. which will be used by follow up hmat-noinitiator test-case. Signed-off-by: Brice Goglin --- tests/data/acpi/q35/APIC.acpihmat-noinitiator | 0 tests/data/acpi/q35/DSDT.acpihmat-noinitiator | 0 tests/data/acpi/q35/FACP.acpihmat-noinitiator | 0 tests/data/acpi/q35/HMAT.acpihmat-noinitiator

[PATCH 3/4] tests: acpi: q35: add test for hmat nodes without initiators

2022-06-23 Thread Brice Goglin
02 00 00 00 // @... 00F0: 03 00 00 00 00 00 00 00 01 00 00 00 00 00 00 00 // 0100: 00 00 00 00 01 00 00 00 00 00 00 00 01 00 00 00 // 0110: 02 00 00 00 0A 00 05 00 01 00 05 00 0A 00 01 00 // Signed-off-by: Brice Gog

[PATCH 1/4] hmat acpi: Don't require initiator value in -numa

2022-06-23 Thread Brice Goglin
[11Eh 0286 2] Entry : 0001 Signed-off-by: Brice Goglin --- hw/core/machine.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index a673302cce..d4d7e77401 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -11

[PATCH 0/4] hmat acpi: Don't require initiator value in -numa

2022-06-23 Thread Brice Goglin
Brice Goglin (4): hmat acpi: Don't require initiator value in -numa tests: acpi: add and whitelist *.hmat-noinitiator expected blobs tests: acpi: q35: add test for hmat nodes without initiators tests: acpi: q35: update expected blobs *.hmat-noinitiators hw/core/mach

Re: [PATCH] hmat acpi: Don't require initiator value in -numa when hmat=on

2022-06-21 Thread Brice Goglin
Le 20/06/2022 à 18:05, Igor Mammedov a écrit : On Mon, 20 Jun 2022 17:24:18 +0200 Brice Goglin wrote: Le 20/06/2022 à 15:27, Igor Mammedov a écrit Machine (2966MB total) + Package P#0 NUMANode P#2 (979MB) Group0 NUMANode P#0 (980MB) Core P#0 + PU P#0 Core P#1

Re: [PATCH] hmat acpi: Don't require initiator value in -numa when hmat=on

2022-06-20 Thread Brice Goglin
Le 20/06/2022 à 15:27, Igor Mammedov a écrit Machine (2966MB total) + Package P#0 NUMANode P#2 (979MB) Group0 NUMANode P#0 (980MB) Core P#0 + PU P#0 Core P#1 + PU P#1 Group0 NUMANode P#1 (1007MB) Core P#2 + PU P#2 Core P#3 + PU P#3 here should be a

Re: [PATCH] hmat acpi: Don't require initiator value in -numa when hmat=on

2022-06-17 Thread Brice Goglin
Hello Could somebody please apply (or reject) this commit? Thanks Brice Le 06/04/2022 à 14:29, Brice Goglin a écrit : From: Brice Goglin The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currentl

[PATCH] hmat acpi: Don't require initiator value in -numa when hmat=on

2022-04-06 Thread Brice Goglin
From: Brice Goglin The "Memory Proximity Domain Attributes" structure of the ACPI HMAT has a "Processor Proximity Domain Valid" flag that is currently always set because Qemu -numa requires initiator=X when hmat=on. Unsetting this flag allows to create more complex memory

Re: [PATCH v1 10/11] linux-user: fix /proc/self/stat handling

2020-04-10 Thread Brice Goglin
executable name rather > > than the full path. Fix both these failings while cleaning up > the code > > to use GString to build up the reported values. As the whole > function > > is cleaned up also adjust the white space to the current

Re: linux-user: keep the name-ending parenthesis in /proc/self/stat

2020-04-09 Thread Brice Goglin
Le 09/04/2020 à 17:27, Alex Bennée a écrit : > Brice Goglin writes: > >> When the program name is very long, qemu-user may truncate it in >> /proc/self/stat. However the truncation must keep the ending ") " >> to conform to the proc manpage which says: >

Re: linux-user: keep the name-ending parenthesis in /proc/self/stat

2020-04-08 Thread Brice Goglin
Please apply my first patch if you believe Philippe's patch is wrong. I can't spend more time debugging this trivial issue unfortunately. Brice Le 08/04/2020 à 17:48, Laurent Vivier a écrit : > Le 08/04/2020 à 10:24, Brice Goglin a écrit : >> When the program name is very

linux-user: keep the name-ending parenthesis in /proc/self/stat

2020-04-08 Thread Brice Goglin
ic Courtes was testing it in Guix over qemu-aarch64. Signed-off-by: Philippe_Mathieu-Daudé Signed-off-by: Brice Goglin diff --git a/linux-user/syscall.c b/linux-user/syscall.c --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7305,7 +7305,11 @@ static int open_self_stat(void *cpu_e

Re: linux-user: keep the name-ending parenthesis in /proc/self/stat

2020-04-07 Thread Brice Goglin
Le 31/03/2020 à 00:29, Brice Goglin a écrit : > Le 31/03/2020 à 00:05, Philippe Mathieu-Daudé a écrit : >> On 3/30/20 9:07 PM, Brice Goglin wrote: >>> When the program name is very long, qemu-user may truncate it in >>> /proc/self/stat. However the truncation must

Re: linux-user: keep the name-ending parenthesis in /proc/self/stat

2020-03-30 Thread Brice Goglin
Le 31/03/2020 à 00:05, Philippe Mathieu-Daudé a écrit : > On 3/30/20 9:07 PM, Brice Goglin wrote: >> When the program name is very long, qemu-user may truncate it in >> /proc/self/stat. However the truncation must keep the ending ") " >> to conform to the proc manpa

linux-user: keep the name-ending parenthesis in /proc/self/stat

2020-03-30 Thread Brice Goglin
ic Courtes was testing it in guix over qemu-aarch64. Signed-off-by: Brice Goglin diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 5af55fca78..a1126dcf5b 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -7305,7 +7305,10 @@ static int open_self_stat(void *cpu_e