Re: [PATCH v42 59/98] hw/sd/sdcard: Add sd_cmd_SET/CLR_WRITE_PROT handler (CMD28 & CMD29)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 91 +++--- 1 file changed, 46 insertions(+), 45 deletions(-) diff --git a/hw/sd/sd.c b

Re: [PATCH v42 58/98] hw/sd/sdcard: Add sd_cmd_PROGRAM_CSD handler (CMD27)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 4650d20ee7..9d33113f11

Re: [PATCH v42 57/98] hw/sd/sdcard: Add sd_cmd_WRITE_SINGLE_BLOCK handler (CMD24)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 57 -- 1 file changed, 30 insertions(+), 27 deletions(-) diff --git a/hw/sd/sd.c b

Re: [PATCH v42 56/98] hw/sd/sdcard: Add sd_cmd_READ_SINGLE_BLOCK handler (CMD17)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 37 - 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index

Re: [PATCH v42 54/98] hw/sd/sdcard: Add sd_cmd_GO_INACTIVE_STATE handler (CMD15)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 37 + 1 file changed, 25 insertions(+), 12 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index

Re: [PATCH v42 55/98] hw/sd/sdcard: Add sd_cmd_SET_BLOCKLEN handler (CMD16)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 37 +++-- 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index

Re: [PATCH v42 52/98] hw/sd/sdcard: Add sd_cmd_STOP_TRANSMISSION handler (CMD12)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 38 --> 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/s

Re: [PATCH v42 53/98] hw/sd/sdcard: Add sd_cmd_SEND_STATUS handler (CMD13)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 40 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c

Re: [PATCH v42 51/98] hw/sd/sdcard: Add spi_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 50 -- 1 file changed, 20 insertions(+), 30 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd

Re: [PATCH v42 50/98] hw/sd/sdcard: Add sd_cmd_SEND_CSD/CID handlers (CMD9 & CMD10)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index

Re: [PATCH v42 48/98] hw/sd/sdcard: Add sd_cmd_DE/SELECT_CARD handler (CMD7)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 85 ++ 1 file changed, 47 insertions(+), 38 deletions(-) diff --git a/hw/sd/sd.c b

Re: [PATCH v42 49/98] hw/sd/sdcard: Add sd_cmd_SEND_IF_COND handler (CMD8)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 43 --- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c

Re: [PATCH v42 47/98] hw/sd/sdcard: Add sd_cmd_SWITCH_FUNCTION handler (CMD6)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 29 + 1 file changed, 17 insertions

Re: [PATCH v42 46/98] hw/sd/sdcard: Register Security Extension optional handlers

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: See "Advanced Security SD Extension Specification" v2.00. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 17 + 1 file changed, 13 insertions(+), 4 deletion

Re: [PATCH v42 45/98] hw/sd/sdcard: Register SDIO optional handlers

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: See "SD Input/Output Card Specification" v1.00. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/hw

Re: [PATCH v42 44/98] hw/sd/sdcard: Register optional handlers from spec v6.00

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 74aa38a442..406fadb3b4

Re: [PATCH v42 43/98] hw/sd/sdcard: Register generic optional handlers (CMD11 and CMD20)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 097cb0f2e2..74aa38a442

Re: [PATCH v42 42/98] hw/sd/sdcard: Remove SEND_DSR dead case (CMD4)

d->csd[6] = 0x00; ... } ... } The sd_normal_command() switch case for the SEND_DSR command do nothing and fallback to "illegal command". Since the command is mandatory (although the register isn't...) call the sd_cmd_unimplemented() handler. Signed-off-by: Philippe Mathieu-Dau

Re: [PATCH v42 41/98] hw/sd/sdcard: Store command class in SDProto

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Store the command class altogether with the other command fields (handler, name and type). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 36 +++- 1

Re: [PATCH v42 40/98] hw/sd/sdcard: Store command type in SDProto

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Store the command type altogether with the command handler and name. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/sd/sd.h | 5 +++-- hw/sd/sd.c | 44

Re: [PATCH v42 39/98] hw/sd/sdcard: Store command name in SDProto

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: We already have a const array where command handlers are listed. Store the command name there too. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 35

Re: [PATCH v42 38/98] hw/sd/sdcard: Prepare SDProto to contain more fields

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Convert array of command handlers to array of structures. The structure contains the command handler. No logical change intended. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 29

Re: [PATCH v42 37/98] hw/sd/sdcard: Pass SDState as argument to sd_[a]cmd_name()

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: In order to access SDState::SDProto from sd_[a]cmd_name(), pass SDState as argument. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH v42 36/98] hw/sd/sdcard: Move sd_[a]cmd_name() methods to sd.c

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Merge sdmmc-internal.c into sd.c by moving sd_cmd_name() and sd_acmd_name() and updating meson.build. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sdmmc-internal.h | 26 --- hw

Re: [PATCH v42 35/98] hw/sd/sdcard: Convert GEN_CMD to generic_write_byte (CMD56)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 0cb528b0b2..f9708064d0 100644

Re: [PATCH v42 34/98] hw/sd/sdcard: Convert LOCK_UNLOCK to generic_write_byte (CMD42)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index bdd5f3486a..0cb528b0b2

Re: [PATCH v42 32/98] hw/sd/sdcard: Convert PROGRAM_CID to generic_write_byte (CMD26)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions

Re: [PATCH v42 33/98] hw/sd/sdcard: Convert PROGRAM_CSD to generic_write_byte (CMD27)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index b9c72a0128..bdd5f3486a

Re: [PATCH v42 31/98] hw/sd/sdcard: Convert WRITE_SINGLE_BLOCK to generic_write_byte (CMD24)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions

Re: [PATCH v42 30/98] hw/sd/sdcard: Duplicate WRITE_SINGLE_BLOCK / WRITE_MULTIPLE_BLOCK cases

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: In order to modify the WRITE_SINGLE_BLOCK case in the next commit, duplicate it first. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 29 + 1 file changed

Re: [PATCH v42 29/98] hw/sd/sdcard: Introduce sd_cmd_to_receivingdata / sd_generic_write_byte

to be received on the data[] buffer, - sd_generic_write_byte() on the DAT lines to push the data. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 29 + 1 file changed, 29 insertions(+) diff --git a/hw/sd

Re: [PATCH v42 28/98] hw/sd/sdcard: Convert SEND_SCR to generic_read_byte (ACMD51)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions

Re: [PATCH v42 27/98] hw/sd/sdcard: Convert SEND_NUM_WR_BLOCKS to generic_read_byte (ACMD22)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1c4811f410..8d02cd9a26

Re: [PATCH v42 25/98] hw/sd/sdcard: Convert GEN_CMD to generic_read_byte (CMD56)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 19 +++ 1 file changed, 7 insertions(+), 12

Re: [PATCH v42 26/98] hw/sd/sdcard: Convert SD_STATUS to generic_read_byte (ACMD13)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions

Re: [PATCH v42 24/98] hw/sd/sdcard: Convert SEND_WRITE_PROT to generic_read_byte (CMD30)

On 6/28/24 9:01 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index eece33194a..bf922da2cc

Re: [PATCH v42 23/98] hw/sd/sdcard: Convert SEND_TUNING_BLOCK to generic_read_byte (CMD19)

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 48 +++- 1 file changed

Re: [PATCH v42 22/98] hw/sd/sdcard: Convert READ_SINGLE_BLOCK to generic_read_byte (CMD17)

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 18 +++--- 1 file changed, 3 insertions(+), 15

Re: [PATCH v42 21/98] hw/sd/sdcard: Duplicate READ_SINGLE_BLOCK / READ_MULTIPLE_BLOCK cases

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: In order to modify the READ_SINGLE_BLOCK case in the next commit, duplicate it first. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 18 ++ 1 file changed, 18

Re: [PATCH v42 20/98] hw/sd/sdcard: Convert SEND_CSD/SEND_CID to generic_read_byte (CMD9 & 10)

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 24 ++-- 1 file changed, 6 insertions(+), 18

Re: [PATCH v42 19/98] hw/sd/sdcard: Convert SWITCH_FUNCTION to generic_read_byte (CMD6)

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1a8d06804d..f7735c39a8

Re: [PATCH v42 19/98] hw/sd/sdcard: Convert SWITCH_FUNCTION to generic_read_byte (CMD6)

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1a8d06804d..f7735c39a8

Re: [PATCH v42 18/98] hw/sd/sdcard: Introduce sd_cmd_to_sendingdata and sd_generic_read_byte

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: All commands switching from TRANSFER state to (sending)DATA do the same: send stream of data on the DAT lines. Instead of duplicating the same code many times, introduce 2 helpers: - sd_cmd_to_sendingdata() on the I/O line setup the data to be

Re: [PATCH v42 16/98] hw/sd/sdcard: Generate random RCA value

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Rather than using the obscure 0x4567 magic value, use a real random one. Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 11 --- hw/sd

Re: [PATCH v42 12/98] hw/sd/sdcard: Restrict SWITCH_FUNCTION to sd_transfer_state (CMD6)

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: SWITCH_FUNCTION is only allowed in TRANSFER state (See 4.8 "Card State Transition Table). Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 4 1

Re: [PATCH v42 11/98] hw/sd/sdcard: Simplify sd_inactive_state handling

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Card entering sd_inactive_state powers off, and won't respond anymore. Handle that once when entering sd_do_command(). Remove condition always true in sd_cmd_GO_IDLE_STATE(). Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater

Re: [PATCH v42 05/98] hw/sd/sdcard: Trace requested address computed by sd_req_get_address()

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 9 +++-- hw/sd/trace-events | 1 + 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c

Re: [PATCH v42 04/98] hw/sd/sdcard: Trace block offset in READ/WRITE data accesses

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Useful to detect out of bound accesses. Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 4 ++-- hw/sd/trace-events | 4 ++-- 2 files changed, 4

Re: [PATCH v42 03/98] hw/sd/sdcard: Track last command used to help logging

command in the SDState and use it in the DAT handlers. This fixes a bug that all normal commands were displayed as APP commands. Fixes: 2ed61fb57b ("sdcard: Display command name when tracing CMD/ACMD") Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Reviewed-by:

Re: [PATCH v42 09/98] hw/sd/sdcard: Use READY_FOR_DATA definition instead of magic value

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1f37d9c93a

Re: [PATCH v42 10/98] hw/sd/sdcard: Assign SDCardStates enum values

: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 135b7d2e23..fbdfafa3a6 100644 --- a/hw/sd/sd.c +++ b/

Re: [PATCH v42 13/98] hw/sd/sdcard: Add direct reference to SDProto in SDState

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Keep direct reference to SDProto in SDState, remove then unnecessary sd_proto(). Signed-off-by: Philippe Mathieu-Daudé Tested-by: Cédric Le Goater Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 37

Re: [PATCH v42 14/98] hw/sd/sdcard: Extract sd_blk_len() helper

On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Extract sd_blk_len() helper, use definitions instead of magic values. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c

Re: [PATCH v42 00/98] hw/sd/sdcard: Add eMMC support

uot; patch) except qtest patch #15. I will scheme through the series for obvious flaws. Unfortunately, I can not review for 82-98 adding the eMMC part, we will need someone else for that. Adding Aspeed engineers. Anyhow, Tested-by: Cédric Le Goater Also available as: https://gitlab.com/p

Re: [PATCH 00/19] hw/sd: Add support for eMMC cards

tps://gitlab.com/philmd/qemu/-/tags/emmc-v4 Including Aspeed branch from Cédric on top (aspeed-9.1): https://gitlab.com/philmd/qemu/-/tags/aspeed_emmc-v4 Cédric Le Goater (5): hw/sd/sdcard: Basis for eMMC support hw/sd/sdcard: Add emmc_cmd_SET_RELATIVE_ADDR() handler hw/sd/sdcard: Fix

Re: [PATCH 2/3] hw/sd/sdcard: Use spec v3.01 by default

On 6/27/24 9:10 AM, Philippe Mathieu-Daudé wrote: Recent SDHCI expect cards to support the v3.01 spec to negociate lower I/O voltage. Select it by default. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- hw/sd/sd.c | 2 +- 1 file changed

Re: [PATCH 1/3] hw/sd/sdcard: Deprecate support for spec v1.10

hieu-Daudé Reviewed-by: Cédric Le Goater Thanks, C. --- docs/about/deprecated.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index ff3da68208..02cdef14aa 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst

Re: [PATCH v5 2/6] hw/ssi: Add SPI model

-by: Cédric Le Goater Thanks, C. --- include/hw/ppc/pnv_xscom.h| 3 + include/hw/ssi/pnv_spi.h | 40 +++ include/hw/ssi/pnv_spi_regs.h | 67 +++ hw/ssi/pnv_spi.c | 214 ++ hw/ppc/Kconfig| 3 + hw/ssi

Re: [PATCH 7/7] virtio-iommu: Revert transient enablement of IOMMU MR in bypass mode

nt of cold plugged VFIO devices. Now we do not use the IOMMU MR callback anymore, we can just get rid of this hack. Signed-off-by: Eric Auger Reviewed-by: Cédric Le Goater Thanks, C. --- hw/virtio/virtio-iommu.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/vir

Re: [PATCH 6/7] memory: remove IOMMU MR iommu_set_page_size_mask() callback

enabled. So let's remove the call to memory_region_iommu_set_page_size_mask in vfio common.c and remove the single implementation of the IOMMU MR callback in the virtio-iommu.c Signed-off-by: Eric Auger Reviewed-by: Cédric Le Goater Thanks, C. --- include/exec/memory.h| 38

Re: [PATCH 4/7] HostIOMMUDevice: Introduce get_page_size_mask() callback

On 6/26/24 10:26 AM, Eric Auger wrote: This callback will be used to retrieve the page size mask supported along a given Host IOMMU device. Signed-off-by: Eric Auger Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-container-base.h | 7 +++ include/sysemu

Re: [PATCH 3/7] HostIOMMUDevice : remove Error handle from get_iova_ranges callback

On 6/26/24 10:26 AM, Eric Auger wrote: The error handle argument is not used anywhere. let's remove it. Signed-off-by: Eric Auger Reviewed-by: Cédric Le Goater Thanks, C. --- include/sysemu/host_iommu_device.h | 3 +-- hw/vfio/container.c| 2 +- hw/vfio/iommufd.c

Re: [PATCH 2/7] vfio-container-base: Introduce vfio_container_get_iova_ranges() helper

g_list_free_full() was used both on the single call site, in virtio_iommu_set_iommu_device() but also in vfio_container_instance_finalize(). Instead use g_list_copy_deep. Fixes: cf2647a76e ("virtio-iommu: Compute host reserved regions") Signed-off-by: Eric Auger Suggested-by: Cédric Le Goater

Re: [PATCH 1/7] virtio-iommu: Fix error handling in virtio_iommu_set_host_iova_ranges()

On 6/26/24 10:26 AM, Eric Auger wrote: In case no IOMMUPciBus/IOMMUDevice are found we need to properly set the error handle and return. Fixes : Coverity CID 1549006 Signed-off-by: Eric Auger Fixes: cf2647a76e ("virtio-iommu: Compute host reserved regions") Reviewed-by: Cédric

Re: [PATCH v5 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h

On 6/26/24 11:05 AM, Chalapathi V wrote: In this commit target specific dependency from include/hw/ppc/pnv_xscom.h has been removed so that pnv_xscom.h can be included outside hw/ppc. Signed-off-by: Chalapathi V Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/ppc/pnv_xscom.h

Re: [PATCH 18/32] hw/sd: Add emmc_cmd_APP_CMD() handler

On 6/25/24 5:04 PM, Philippe Mathieu-Daudé wrote: Hi Cédric, On 3/7/23 15:24, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater ---   hw/sd/sd.c | 6 ++   1 file changed, 6 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 5ff132139ea9..95cb46b87519 100644 --- a/hw/sd/sd.c

Re: [PATCH 18/32] hw/sd: Add emmc_cmd_APP_CMD() handler

On 6/25/24 5:32 PM, Philippe Mathieu-Daudé wrote: On 25/6/24 17:13, Cédric Le Goater wrote: On 6/25/24 5:04 PM, Philippe Mathieu-Daudé wrote: Hi Cédric, On 3/7/23 15:24, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater ---   hw/sd/sd.c | 6 ++   1 file changed, 6 insertions

Re: [PATCH v3 0/2] Fix coverity issues for AST2700

Hello Jamin On 6/25/24 9:07 AM, Jamin Lin wrote: change from v1: aspeed/soc: coverity defect: DIVIDE_BY_ZERO aspeed/sdmc: coverity defect: Control flow issues (DEADCODE) change from v2: add more commit log from reviewer suggestion, Cédric. change from v3: replace qemu_log_mask with assert

[PATCH v2] aspeed: Deprecate the tacoma-bmc machine

The tacoma-bmc machine was a board including an AST2600 SoC based BMC and a witherspoon like OpenPOWER system. It was used for bring up of the AST2600 SoC in labs. It can be easily replaced by the rainier-bmc machine which is part of a real product offering. Signed-off-by: Cédric Le Goater

Re: [PATCH v2 00/12] hw/sd/sdcard: Accumulation of cleanups and fixes

deletions(-) Tested-by: Cédric Le Goater Thanks, C.

[PATCH] aspeed/sdmc: Check RAM size value at realize time

Le Goater --- hw/misc/aspeed_sdmc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/misc/aspeed_sdmc.c b/hw/misc/aspeed_sdmc.c index 94eed9264d09..ebf139cb5c91 100644 --- a/hw/misc/aspeed_sdmc.c +++ b/hw/misc/aspeed_sdmc.c @@ -271,6 +271,12 @@ static void aspeed_sdmc_realize

Re: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero

On 6/25/24 8:15 AM, Jamin Lin wrote: Hi cmd, Cedric and Peter, -Original Message- From: cmd Sent: Tuesday, June 25, 2024 2:07 PM To: Cédric Le Goater ; Jamin Lin ; Peter Maydell ; Steven Lee ; Troy Lee ; Andrew Jeffery ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC

[PATCH] aspeed: Deprecate the tacoma-bmc machine

The tacoma-bmc machine was a board including an AST2600 SoC based BMC and a witherspoon like OpenPOWER system. It was used for bring up of the AST2600 SoC in labs. It can be easily replaced by the rainier-bmc machine which is part of a real product offering. Signed-off-by: Cédric Le Goater

Re: [PATCH v1 1/2] aspeed/soc: fix coverity issue

Hello On 6/25/24 3:55 AM, Jamin Lin wrote: Hi Cedric, -Original Message- From: Cédric Le Goater Sent: Monday, June 24, 2024 9:58 PM To: Peter Maydell ; Jamin Lin Cc: Steven Lee ; Troy Lee ; Andrew Jeffery ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here ; Troy

Re: [PATCH v2 1/2] aspeed/soc: Fix possible divide by zero

ue. Fixes: Coverity CID 1547113 Signed-off-by: Jamin Lin Reviewed-by: Cédric Le Goater [ clg: Rewrote commit log ] Signed-off-by: Cédric Le Goater ---   hw/arm/aspeed_ast27x0.c | 6 ++   1 file changed, 6 insertions(+) diff --git a/hw/arm/aspeed_ast27x0.c b/hw/arm/aspeed_ast27x0.c index b6876b4862..

[PULL 23/42] virtio-iommu: Remove the implementation of iommu_set_iova_range

From: Eric Auger Now that we use PCIIOMMUOps to convey information about usable IOVA ranges we do not to implement the iommu_set_iova_ranges IOMMU MR callback. Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Duan Reviewed-by: Michael S. Tsirkin --- hw/virtio/virtio-iommu.c | 67

[PULL 12/42] hw/pci: Introduce helper function pci_device_get_iommu_bus_devfn()

From: Zhenzhong Duan Extract out pci_device_get_iommu_bus_devfn() from pci_device_iommu_address_space() to facilitate implementation of pci_device_[set|unset]_iommu_device() in following patch. No functional change intended. Signed-off-by: Yi Liu Signed-off-by: Yi Sun Signed-off-by: Nicolin

[PULL 28/42] vfio/common: Move dirty tracking ranges update to helper

- Introduced vfio_dirty_tracking_update_range() - Fixed typ in commit log ] Signed-off-by: Cédric Le Goater --- hw/vfio/common.c | 38 ++ 1 file changed, 22 insertions(+), 16 deletions(-) diff --git a/hw/vfio/common.c b/hw/vfio/common.c index

[PULL 20/42] HostIOMMUDevice: Introduce get_iova_ranges callback

From: Eric Auger Introduce a new HostIOMMUDevice callback that allows to retrieve the usable IOVA ranges. Implement this callback in the legacy VFIO and IOMMUFD VFIO host iommu devices. This relies on the VFIODevice agent's base container iova_ranges resource. Signed-off-by: Eric Auger

[PULL 04/42] backends/iommufd: Introduce TYPE_HOST_IOMMU_DEVICE_IOMMUFD[_VFIO] devices

-by: Cédric Le Goater Signed-off-by: Yi Liu Signed-off-by: Zhenzhong Duan Reviewed-by: Eric Auger Reviewed-by: Michael S. Tsirkin --- include/hw/vfio/vfio-common.h | 3 +++ include/sysemu/iommufd.h | 16 backends/iommufd.c| 35 ++- hw

[PULL 10/42] backends/iommufd: Implement HostIOMMUDeviceClass::get_cap() handler

From: Zhenzhong Duan Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan Reviewed-by: Eric Auger Reviewed-by: Michael S. Tsirkin --- backends/iommufd.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/backends/iommufd.c b/backends/iommufd.c index

[PULL 21/42] HostIOMMUDevice: Store the aliased bus and devfn

From: Eric Auger Store the aliased bus and devfn in the HostIOMMUDevice. This will be useful to handle info that are iommu group specific and not device specific (such as reserved iova ranges). Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Duan Reviewed-by: Michael S. Tsirkin ---

[PULL 34/42] vfio/container: Introduce vfio_create_container()

This routine allocates the QEMU struct type representing the VFIO container. It is minimal currently and future changes will do more initialization. Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/container.c | 19

[PULL 01/42] backends: Introduce HostIOMMUDevice abstract

IOMMU. Introduce .realize() to initialize HostIOMMUDevice further after instance init. Suggested-by: Cédric Le Goater Signed-off-by: Zhenzhong Duan Reviewed-by: Eric Auger Reviewed-by: Michael S. Tsirkin --- MAINTAINERS| 2 ++ include/sysemu/host_iommu_device.h | 53

[PULL 27/42] vfio: Remove unused declarations from vfio-common.h

These were forgotten in the recent cleanups. Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 4 1 file changed, 4 deletions(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio

[PULL 33/42] vfio/container: Introduce vfio_get_iommu_class_name()

-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/container.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/hw/vfio/container.c b/hw/vfio/container.c index 589f37bc6d68dae18f9e46371f14d6952b2240c0..bb6abe60ee29d5b69b494523c9002f53e1b2a3c8

[PULL 30/42] vfio/container: Introduce vfio_address_space_insert()

-by: Cédric Le Goater --- include/hw/vfio/vfio-common.h | 2 ++ hw/vfio/common.c | 6 ++ hw/vfio/container.c | 2 +- hw/vfio/iommufd.c | 2 +- 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio

[PULL 22/42] virtio-iommu: Compute host reserved regions

From: Eric Auger Compute the host reserved regions in virtio_iommu_set_iommu_device(). The usable IOVA regions are retrieved from the HostIOMMUDevice. The virtio_iommu_set_host_iova_ranges() helper turns usable regions into complementary reserved regions while testing the inclusion into existing

[PULL 14/42] vfio/pci: Pass HostIOMMUDevice to vIOMMU

From: Zhenzhong Duan With HostIOMMUDevice passed, vIOMMU can check compatibility with host IOMMU, call into IOMMUFD specific methods, etc. Originally-by: Yi Liu Signed-off-by: Nicolin Chen Signed-off-by: Yi Sun Signed-off-by: Zhenzhong Duan Reviewed-by: Eric Auger Reviewed-by: Michael S.

[PULL 32/42] vfio/container: Modify vfio_get_iommu_type() to use a container fd

The 'container' pointer has no other use than its 'fd' attribute. Simplify the prototype to ease future changes. Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/container.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PULL 38/42] vfio/container: Introduce an instance_init() handler

This allows us to move the initialization code from vfio_container_init(), which we will soon remove. Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/container-base.c | 19 +-- 1 file changed, 13 insertions

[PULL 26/42] vfio: Make vfio_devices_dma_logging_start() return bool

be saved in the migration stream when called from vfio_listener_log_global_stop(). Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/common.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw

[PULL 18/42] HostIOMMUDevice: Store the VFIO/VDPA agent

From: Eric Auger Store the agent device (VFIO or VDPA) in the host IOMMU device. This will allow easy access to some of its resources. Signed-off-by: Eric Auger Reviewed-by: Zhenzhong Duan Reviewed-by: Michael S. Tsirkin --- include/sysemu/host_iommu_device.h | 1 + hw/vfio/container.c

[PULL 37/42] vfio/container: Switch to QOM

Instead of allocating the container struct, create a QOM object of the appropriate type. Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/container.c | 6 +++--- hw/vfio/iommufd.c | 4 ++-- 2 files changed, 5 insertions

[PULL 40/42] vfio/container: Remove vfio_container_init()

It's now empty. Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-container-base.h | 2 -- hw/vfio/container-base.c | 5 - hw/vfio/container.c | 3 --- hw/vfio/iommufd.c

[PULL 31/42] vfio/container: Simplify vfio_container_init()

the 'space' pointer later in the execution flow. This should not have any consequence. Reviewed-by: Zhenzhong Duan Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- include/hw/vfio/vfio-container-base.h | 1 - hw/vfio/common.c | 1 + hw/vfio/container-base.c

[PULL 41/42] vfio/container: Introduce vfio_iommu_legacy_instance_init()

Just as we did for the VFIOContainerBase object, introduce an instance_init() handler for the legacy VFIOContainer object and do the specific initialization there. Reviewed-by: Zhenzhong Duan Reviewed-by: Eric Auger Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio

[PULL 29/42] vfio/common: Extract vIOMMU code from vfio_sync_dirty_bitmap()

: - Rebased on upstream - Fixed typo in commit log ] Reviewed-by: Zhenzhong Duan Tested-by: Eric Auger Signed-off-by: Cédric Le Goater --- hw/vfio/common.c | 63 +--- 1 file changed, 38 insertions(+), 25 deletions(-) diff --git a/hw/vfio/common.c b/hw

[PULL 15/42] intel_iommu: Extract out vtd_cap_init() to initialize cap/ecap

From: Zhenzhong Duan Extract cap/ecap initialization in vtd_cap_init() to make code cleaner. No functional change intended. Reviewed-by: Eric Auger Signed-off-by: Zhenzhong Duan Reviewed-by: Michael S. Tsirkin --- hw/i386/intel_iommu.c | 93 --- 1

[PULL 25/42] memory: Remove IOMMU MR iommu_set_iova_range API

From: Eric Auger Since the host IOVA ranges are now passed through the PCIIOMMUOps set_host_resv_regions and we have removed the only implementation of iommu_set_iova_range() in the virtio-iommu and the only call site in vfio/common, let's retire the IOMMU MR API and its memory wrapper.

<    1   2   3   4   5   6   7   8   9   10   >