Re: [PATCH 1/3] Include endian.h for Haiku to solve bswap* macros build

2020-09-26 Thread Carlo Arenas
FWIW the 32 bit image (haiku-r1beta2-x86_gcc2h-anyboot.zip[1]), uses gcc 2.95.3 as system CC a newer gcc (the same version that is used for the 64 bit port) is provided as an alternative though Carlo [1] https://www.haiku-os.org/get-haiku/r1beta2/

Re: [PATCH V10 2/8] target/mips: Fix PageMask with variable page size

2020-09-22 Thread Carlo Arenas
On Mon, Sep 21, 2020 at 7:53 PM Huacai Chen wrote: > was just added to mips target and that's nolonger true. s/nolonger/no longer/ IMHO might be worth also mentioning that it was added with ee3863b9d4 (target/mips: Support variable page size, 2020-04-08) to give a little more context. some

Re: [PATCH] linux-user: warn if trying to use qemu-mipsn32[el] with non n32 ELF

2020-08-23 Thread Carlo Arenas
The differences of bit width and endianness are already being taken care of by the current code. The differences in ABI for ILP32 are the only ones missing and so the new version[1] (sorry, not a series since it makes sense as a single change anyway) should be enough to fix any inconsistencies.

Re: [PATCH] configure: warn if not using a separate build directory

2020-03-31 Thread Carlo Arenas
On Tue, Mar 31, 2020 at 3:38 AM Daniel P. Berrangé wrote: > Running configure directly from the source directory is a build > configuration that will go away in future. It is also not currently > s/in future/in the future/g Carlo

Re: [Qemu-devel] [PATCH-for-4.1] crypto: Fix data type for len parameter in two typedefs

2019-07-18 Thread Carlo Arenas
this series seems to provide a more complete fix https://patchwork.ozlabs.org/cover/1131259/

Re: [Qemu-devel] [PULL 3/3] tests: vm: auto_install OpenBSD

2019-01-06 Thread Carlo Arenas
On Sat, Jan 5, 2019 at 9:39 PM Fam Zheng wrote: > +self.ssh_root("shutdown -p now") could use `halt -p` as a more direct/obvious/effective command

Re: [Qemu-devel] [PATCH v2 6/6] linux_user: consolidate sock_type

2017-10-17 Thread Carlo Arenas
On Wed, Oct 11, 2017 at 6:23 AM, Laurent Vivier wrote: > Le 26/09/2017 à 01:19, Carlo Marcelo Arenas Belón a écrit : >> remove unnecessary sock_type enum and other unused surrounding code to >> allow for per arch sockbits to mirror better linux headers for maintenance >> >>

Re: [Qemu-devel] linux-user: refactor socket.h into architecture specific sockbits

2017-10-17 Thread Carlo Arenas
On Mon, Oct 16, 2017 at 5:32 AM, Riku Voipio <riku.voi...@iki.fi> wrote: > On Wed, Oct 11, 2017 at 12:10:04AM -0700, Carlo Arenas wrote: >> some of the patches already have a Reviewed-by as shown by : >> >> http://patchwork.ozlabs.org/patch/818378/ > >

Re: [Qemu-devel] linux-user: refactor socket.h into architecture specific sockbits

2017-10-11 Thread Carlo Arenas
ping some of the patches already have a Reviewed-by as shown by : http://patchwork.ozlabs.org/patch/818378/ On Mon, Sep 25, 2017 at 4:19 PM, Carlo Marcelo Arenas Belón wrote: > the definitions in socket.h are meant to reflect the ones in linux for each > respective target,

Re: [Qemu-devel] [PATCH] scsi: Ignore executable for in-tree builds

2017-09-26 Thread Carlo Arenas
Reviewed-by: Carlo Marcelo Arenas Belón On Tue, Sep 26, 2017 at 8:14 AM, Eric Blake wrote: > The new qemu-pr-helper (commit b855f8d17) should not be checked in, > even when doing in-tree builds. > > Signed-off-by: Eric Blake > --- >

Re: [Qemu-devel] [RFC 1/6] linux-user: update hppa sockbits

2017-09-25 Thread Carlo Arenas
On Fri, Sep 22, 2017 at 9:13 AM, Laurent Vivier wrote: > Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > > updated to match arch/parisc/include/uapi/asm/socket.h from linux 4.14 > > I think it's not a good idea to change indentation, by adding spaces you > hide

Re: [Qemu-devel] [RFC 6/6] linux-user: update default socket.h

2017-09-25 Thread Carlo Arenas
On Fri, Sep 22, 2017 at 10:04 AM, Laurent Vivier wrote: > And you should move powerpc bits to linux-user/ppc/sockbits. PPC is IMHO a special case, since it is kept together with the generic header in the linux kernel (except for a similar exception to those few values that

Re: [Qemu-devel] [RFC 5/6] linux-user: fix 64bit versions of sparc and mips

2017-09-25 Thread Carlo Arenas
On Fri, Sep 22, 2017 at 10:01 AM, Laurent Vivier wrote: > Le 22/09/2017 à 16:02, Carlo Marcelo Arenas Belón a écrit : > > Signed-off-by: Carlo Marcelo Arenas Belón > > --- > > linux-user/mips64/sockbits.h | 1 + > > linux-user/socket.h | 4 ++--

Re: [Qemu-devel] [PATCH 2/3] linux-user: add SO_LINGER to setsockopt

2017-09-20 Thread Carlo Arenas
On Wed, Sep 20, 2017 at 11:53 AM, Laurent Vivier wrote: > > the test for optlen is replaced by passing optlen to the underlying > > setsockopt call directly, who would do the test and return the right > error. > > You can't do that, because sizeof(struct linger) may be

Re: [Qemu-devel] [PATCH 2/3] linux-user: add SO_LINGER to setsockopt

2017-09-20 Thread Carlo Arenas
On Wed, Sep 20, 2017 at 1:39 AM, Laurent Vivier wrote: > > Why did you remove "optname = SO_LINGER" and "if (optlen != > sizeof(struct target_linger))"? > the optname assignment is not really needed, since it is only used for the setsockopt call and that call is clearer using