Re: [PATCH v2 1/1] ui/cocoa: add zoom-to-fit display option

2023-10-27 Thread Carwyn Ellis
> On 27 Oct 2023, at 16:24, Akihiko Odaki wrote: > > On 2023/10/28 0:09, carwynel...@gmail.com wrote: >> From: Carwyn Ellis >> Provides a display option, zoom-to-fit, that enables scaling of the >> display when full-screen mode is enabled. >> Also ensures th

Re: [PATCH 1/1] ui/cocoa: add full-screen-scaling display option

2023-10-26 Thread Carwyn Ellis
> On 26 Oct 2023, at 03:51, Akihiko Odaki wrote: > > On 2023/10/25 23:04, carwynel...@gmail.com wrote: >> From: Carwyn Ellis >> Provides a display option, full-screen-scaling, that enables scaling of >> the display when full-screen mode is enabled. >> Also en

Re: [PATCH v3 2/2] hw/display/vmware_vga: do not discard screen updates

2022-04-22 Thread Carwyn Ellis
Awesome! Thanks! > On 22 Apr 2022, at 11:40, Gerd Hoffmann wrote: > > On Sun, Apr 10, 2022 at 05:49:30PM +0100, Carwyn Ellis wrote: >> ping >> >> https://patchew.org/QEMU/20220206183956.10694-1-carwynel...@gmail.com/20220206183956.10694-3-carwynel...@gmail.com/ >

[PATCH v2 0/1] ui/cocoa: show/hide menu in fullscreen on mouse

2022-04-10 Thread Carwyn Ellis
from Akihiko Odaki. Carwyn Ellis (1): ui/cocoa: show/hide menu in fullscreen on mouse ungrab/grab ui/cocoa.m | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) -- 2.35.1

[PATCH v2 1/1] ui/cocoa: show/hide menu in fullscreen on mouse ungrab/grab

2022-04-10 Thread Carwyn Ellis
feedback from Akihiko Odaki. Signed-off-by: Carwyn Ellis --- ui/cocoa.m | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index c4e5468f9e..ea2cd4ece0 100644 --- a/ui/cocoa.m +++ b/ui/cocoa.m @@ -656,13 +656,11 @@ - (void) toggleFullScreen:(id)sender

Re: [PATCH 1/1] ui/cocoa: show/hide menu in fullscreen on mouse ungrab/grab

2022-04-10 Thread Carwyn Ellis
Thanks, taking a look now and will push up another patch once I’ve tested the changes. Regards Carwyn > On 18 Feb 2022, at 18:42, Akihiko Odaki wrote: > > On 2022/01/03 20:45, Carwyn Ellis wrote: >> The menu bar is only accessible when the Cocoa UI is windowed. In order >&

Re: [PATCH v3 2/2] hw/display/vmware_vga: do not discard screen updates

2022-04-10 Thread Carwyn Ellis
let me know if you think there’s anything else that needs changing here and I’ll resubmit if so. FWIW I’ve been using this fix for a couple of months now without any issues. Thanks Carwyn > On 6 Feb 2022, at 18:39, Carwyn Ellis wrote: > > In certain circumstances, typically when ther

[PATCH v3 0/2] use trace events and fix garbled output

2022-02-06 Thread Carwyn Ellis
applied to the display has also been simplified, since we always start the traversal at the beginning of the queue to ensure that all updates are applied. Carwyn Ellis (2): hw/display/vmware_vga: replace fprintf calls with trace events hw/display/vmware_vga: do not discard screen updates hw

[PATCH v3 1/2] hw/display/vmware_vga: replace fprintf calls with trace events

2022-02-06 Thread Carwyn Ellis
Debug output was always being sent to STDERR. This has been replaced with trace events. Signed-off-by: Carwyn Ellis --- hw/display/trace-events | 3 +++ hw/display/vmware_vga.c | 30 ++ 2 files changed, 21 insertions(+), 12 deletions(-) diff --git a/hw/display

[PATCH v3 2/2] hw/display/vmware_vga: do not discard screen updates

2022-02-06 Thread Carwyn Ellis
. Additionally when adding updates to the queue, if the buffer reaches capacity we force a flush before accepting further events. Signed-off-by: Carwyn Ellis --- hw/display/trace-events | 1 + hw/display/vmware_vga.c | 41 +++-- 2 files changed, 24 insertions

[PATCH 2/2] hw/display/vmware_vga: do not discard screen updates

2022-01-04 Thread Carwyn Ellis
. Additionanlly when adding updates to the queue, if the buffer reaches capacity we force a flush before accepting further events. Signed-off-by: Carwyn Ellis --- hw/display/trace-events | 1 + hw/display/vmware_vga.c | 41 +++-- 2 files changed, 24 insertions

[PATCH 0/2] use trace events and fix garbled output

2022-01-04 Thread Carwyn Ellis
has also been simplified, since we always start the traversal at the beginning of the queue to ensure that all updates are applied. Carwyn Ellis (2): hw/display/vmware_vga: replace fprintf calls with trace events hw/display/vmware_vga: do not discard screen updates hw/display/trace-events

[PATCH 1/2] hw/display/vmware_vga: replace fprintf calls with trace events

2022-01-04 Thread Carwyn Ellis
Debug output was always being sent to STDERR. This has been replaced with trace events. Signed-off-by: Carwyn Ellis --- hw/display/trace-events | 3 +++ hw/display/vmware_vga.c | 22 ++ 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/hw/display/trace

Re: [PATCH 2/2] hw/display/vmware_vga: do not discard screen updates

2022-01-04 Thread Carwyn Ellis
> On 4 Jan 2022, at 12:23, Gerd Hoffmann wrote: > > Hi, > >> This change firstly increases the screen update FIFO size to ensure it's >> large enough to accomodate all updates deferred in a given screen >> refresh cycle. > > How do you know it's large enough? > >> @@ -385,7 +385,14 @@ stat

Re: [PATCH 1/2] hw/display/vmware_vga: only show debug output if DEBUG enabled

2022-01-04 Thread Carwyn Ellis
Ok cool. Thanks for the info! > On 4 Jan 2022, at 09:27, Laurent Vivier wrote: > > Le 04/01/2022 à 10:20, Carwyn Ellis a écrit : >> Hey, >> Thanks for getting back to me. >> Yeah will take a look and update when I have a mo. > > It's reall

Re: [PATCH 1/2] hw/display/vmware_vga: only show debug output if DEBUG enabled

2022-01-04 Thread Carwyn Ellis
Hey, Thanks for getting back to me. Yeah will take a look and update when I have a mo. Cheers Carwyn > On 4 Jan 2022, at 09:18, Laurent Vivier wrote: > > Le 04/01/2022 à 10:11, Carwyn Ellis a écrit : >> Debug output was always being sent to STDERR. This has been replaced by &

[PATCH 1/2] hw/display/vmware_vga: only show debug output if DEBUG enabled

2022-01-04 Thread Carwyn Ellis
Debug output was always being sent to STDERR. This has been replaced by a define that will only show this output when DEBUG is set to true. Signed-off-by: Carwyn Ellis --- hw/display/vmware_vga.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/hw

[PATCH 2/2] hw/display/vmware_vga: do not discard screen updates

2022-01-04 Thread Carwyn Ellis
When updating the screen all updates are applied to ensure the display output is rendered correctly. Signed-off-by: Carwyn Ellis --- hw/display/vmware_vga.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_

[PATCH 0/2] hw/display/vmware_vga: supress debug output and fix

2022-01-04 Thread Carwyn Ellis
. The FIFO queue size has been increased and all display update events are now processed ensuring correct display output even during periods of high activity. Carwyn Ellis (2): hw/display/vmware_vga: only show debug output if DEBUG enabled hw/display/vmware_vga: do not discard screen

[PATCH 1/1] ui/cocoa: show/hide menu in fullscreen on mouse ungrab/grab

2022-01-03 Thread Carwyn Ellis
The menu bar is only accessible when the Cocoa UI is windowed. In order to allow the menu bar to be accessible in fullscreen mode, this change makes the menu visible when the mouse is ungrabbed. When the mouse is grabbed the menu is hidden again. Signed-off-by: Carwyn Ellis --- ui/cocoa.m | 8

[PATCH 0/1] Show/hide the menu bar in fullscreen on mouse

2022-01-03 Thread Carwyn Ellis
Minor change to make fullscreen mode in the Cocoa UI a little more convenient. The menu bar is now made visible when the mouse is released (ungrabbed) making it accessible without having to leave fullscreen mode. Grabbing the mouse hides the menu. Carwyn Ellis (1): ui/cocoa: show/hide menu in

[PATCH 1/2] ui/cocoa: add option to disable left-command forwarding to guest

2022-01-02 Thread Carwyn Ellis
reference the new left-command-key option along with the existing show-cursor option. Signed-off-by: Carwyn Ellis --- qapi/ui.json| 17 + qemu-options.hx | 12 ui/cocoa.m | 8 +++- 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/qapi/ui.json

[PATCH 2/2] ui/cocoa: release mouse when user switches away from QEMU window

2022-01-02 Thread Carwyn Ellis
control to the guest. This appraoch ensures that the calls to NSCursor hide and unhide are always balanced and thus work correctly when invoked. Signed-off-by: Carwyn Ellis --- ui/cocoa.m | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/cocoa.m b/ui/cocoa.m index 01045d6698..3f7af4a8fa

[PATCH 0/2] ui/cocoa: Add option to disable left command and hide cursor on click

2022-01-02 Thread Carwyn Ellis
ption which is also respected by the cocoa UI code. Carwyn Ellis (2): ui/cocoa: add option to disable left-command forwarding to guest ui/cocoa: release mouse when user switches away from QEMU window qapi/ui.json| 17 + qemu-options.hx | 12 ui/cocoa.m

Re: [PATCH 1/1] ui/cocoa: Add option to disable left command and hide cursor on click

2021-12-31 Thread Carwyn Ellis
> On 31 Dec 2021, at 17:56, Alexander Orzechowski > wrote: > > > On 12/31/21 12:42, Carwyn Ellis wrote: >> When switching between guest and host on a Mac using command-tab the >> command key is sent to the guest which can trigger functionality in the >> gues

Re: [PATCH 1/1] ui/cocoa: Add option to disable left command and hide cursor on click

2021-12-31 Thread Carwyn Ellis
Ok cool, I’ll separate this out into 2 patches for the fullscreen and left-command changes respectively. Will aim to get this out at some point tomorrow. Cheers Carwyn > On 31 Dec 2021, at 17:49, Alexander Orzechowski > wrote: > > > On 12/31/21 12:42, Carwyn Ellis wrote: &g

[PATCH 1/1] ui/cocoa: Add option to disable left command and hide cursor on click

2021-12-31 Thread Carwyn Ellis
When switching between guest and host on a Mac using command-tab the command key is sent to the guest which can trigger functionality in the guest OS. Specifying left-command-key=off disables forwarding this key to the guest. Defaults to enabled. When switching between guest and host on a Mac with

[PATCH 0/1] ui/cocoa: Add option to disable left command and hide cursor on click

2021-12-31 Thread Carwyn Ellis
Added a call to hideCursor on left and right mouse clicks so if the cursor is visible after switching back to the guest a mouse click will hide the cursor again. - Also updated the command line docs to reference the show-cursor option which is also respected by the cocoa UI code. Carwyn

[PATCH 0/1] ui/cocoa: Add option to disable left command and hide cursor on click

2021-12-31 Thread Carwyn Ellis
Also updated the command line docs to reference the show-cursor option which is also respected by the cocoa UI code. Carwyn Ellis (1): ui/cocoa: Add option to disable left command and hide cursor on click qapi/ui.json| 17 + qemu-options.hx | 12 ui/co

[PATCH 1/1] ui/cocoa: Add option to disable left command and hide cursor on click

2021-12-31 Thread Carwyn Ellis
When switching between guest and host on a Mac using command-tab the command key is sent to the guest which can trigger functionality in the guest OS. Specifying left-command-key=off disables forwarding this key to the guest. Defaults to enabled. When switching between guest and host on a Mac with