Re: [Qemu-devel] [PATCH v2] Add page-size to output in 'info migrate'

2017-03-21 Thread Chao Fan
On Tue, Mar 21, 2017 at 09:22:52AM +0100, Juan Quintela wrote: >Chao Fan <fanc.f...@cn.fujitsu.com> wrote: >> The number of dirty pages outputed in 'pages' in the command >> 'info migrate', so add page-size to calculate the number of dirty >> pages in bytes. >> &

[Qemu-devel] [PATCH v2] Add page-size to output in 'info migrate'

2017-03-20 Thread Chao Fan
The number of dirty pages outputed in 'pages' in the command 'info migrate', so add page-size to calculate the number of dirty pages in bytes. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com> --- v2: fix the grammar in qapi-schem

[Qemu-devel] [PATCH] Add page-size to output in 'info migrate'

2017-03-16 Thread Chao Fan
The number of dirty pages outputed in 'pages' in the command 'info migrate', so add page-size to calculate the number of dirty pages in bytes. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com> --- hmp.c

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 12:37:30PM +, Daniel P. Berrange wrote: >On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: >> Chao Fan <fanc.f...@cn.fujitsu.com> wrote: >> > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> > It's also be

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 09:54:34AM -0500, Eric Blake wrote: >On 03/14/2017 05:27 AM, Chao Fan wrote: >> In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> It's also better for other tools to determine the cpu throttle >> value in different architecture. >&

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: >Chao Fan <fanc.f...@cn.fujitsu.com> wrote: >> In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> It's also better for other tools to determine the cpu throttle >> value in different arc

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 12:37:30PM +, Daniel P. Berrange wrote: >On Tue, Mar 14, 2017 at 01:29:43PM +0100, Juan Quintela wrote: >> Chao Fan <fanc.f...@cn.fujitsu.com> wrote: >> > In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> > It's also be

Re: [Qemu-devel] [PATCH] Add dirty-bytes-rate to output in 'info migrate'

2017-03-14 Thread Chao Fan
Daniel and Juan, Sorry for this patch, cause I did not see your reply. So Nack this patch. And thank you very much. Thanks, Chao Fan On Tue, Mar 14, 2017 at 08:38:41PM +0800, Chao Fan wrote: >Because 'dirty-bytes-rate' is in 'bytes/s', so it's better for other >tools to determine t

[Qemu-devel] [PATCH] Add dirty-bytes-rate to output in 'info migrate'

2017-03-14 Thread Chao Fan
Because 'dirty-bytes-rate' is in 'bytes/s', so it's better for other tools to determine the cpu throttle value in different architecture. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com> --- hmp.c | 6 +

Re: [Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 10:45:16AM +, Daniel P. Berrange wrote: >On Tue, Mar 14, 2017 at 06:27:47PM +0800, Chao Fan wrote: >> In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. >> It's also better for other tools to determine the cpu throttle >> value in d

[Qemu-devel] [PATCH] Output dirty-bytes-rate instead of dirty-pages-rate

2017-03-14 Thread Chao Fan
In hmp, dirty-bytes-rate is more friendly than dirty-pages-rate. It's also better for other tools to determine the cpu throttle value in different architecture. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com> --- hmp.c

Re: [Qemu-devel] [PATCH v2] Change the method to calculate dirty-pages-rate

2017-03-14 Thread Chao Fan
On Tue, Mar 14, 2017 at 09:38:46AM +0100, Juan Quintela wrote: >Chao Fan <fanc.f...@cn.fujitsu.com> wrote: >> In function cpu_physical_memory_sync_dirty_bitmap, file >> include/exec/ram_addr.h: >> >> if (src[idx][offset]) { >> unsigned long bits = atomic_

[Qemu-devel] [PATCH v2] Change the method to calculate dirty-pages-rate

2017-03-13 Thread Chao Fan
w_dirty will be 0b1100, and this function will return 2 but not 4 which is expected. the dirty pages in dirty_memory[DIRTY_MEMORY_MIGRATION] are all new, so these should be calculated also. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com&

Re: [Qemu-devel] [PATCH] Change the method to calculate dirty-pages-rate

2017-03-13 Thread Chao Fan
On Tue, Mar 14, 2017 at 09:41:30AM +0800, Li Zhijian wrote: > > >On 03/14/2017 09:26 AM, Chao Fan wrote: >> In function cpu_physical_memory_sync_dirty_bitmap, file >> include/exec/ram_addr.h: >> >> if (src[idx][offset]) { >> unsigned long bits = atomic_

[Qemu-devel] [PATCH] Change the method to calculate dirty-pages-rate

2017-03-13 Thread Chao Fan
w_dirty will be 0b1100, and this function will return 2 but not 4 which is expected. the dirty pages in dirty_memory[DIRTY_MEMORY_MIGRATION] are all new, so these should be calculated also. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> Signed-off-by: Li Zhijian <lizhij...@cn.fujitsu.com>

Re: [Qemu-devel] [PATCH v2] Add inst_dirty_pages_rate in 'info migrate'

2017-03-09 Thread Chao Fan
On Wed, Mar 08, 2017 at 01:45:59PM +, Daniel P. Berrange wrote: >On Wed, Mar 08, 2017 at 04:28:19PM +0800, Chao Fan wrote: >> Auto-converge aims to accelerate migration by slowing down the >> generation of dirty pages. But user doesn't know how to determine the >> thro

[Qemu-devel] [PATCH v2] Add inst_dirty_pages_rate in 'info migrate'

2017-03-08 Thread Chao Fan
Auto-converge aims to accelerate migration by slowing down the generation of dirty pages. But user doesn't know how to determine the throttle value, so, a new item "inst-dirty-pages-rate" in "info migrate" would be helpful for user's determination. Signed-off-

[Qemu-devel] [PATCH] Add inst_dirty_pages_rate in 'info migrate'

2017-03-01 Thread Chao Fan
Auto-converge aims to accelerate migration by slowing down the generation of dirty pages. But user doesn't know how to determine the throttle value, so, a new item "inst-dirty-pages-rate" in "info migrate" would be helpful for user's determination. Signed-off-

Re: [Qemu-devel] [PATCH RFC] migration: set cpu throttle value by workload

2017-02-05 Thread Chao Fan
On Fri, Jan 27, 2017 at 12:07:27PM +, Dr. David Alan Gilbert wrote: >* Chao Fan (fanc.f...@cn.fujitsu.com) wrote: >> Hi all, >> >> This is a test for this RFC patch. >> >> Start vm as following: >> cmdline="./x86_64-softmmu/qemu-system-x86_

Re: [Qemu-devel] [PATCH RFC] migration: set cpu throttle value by workload

2017-01-17 Thread Chao Fan
0.80.90 (total time from 21 to 30), 6s with the cpu throttle percentage is 99 (total time from 30 to completed). So I think the influence to the guest performance after my patch is fewer than the upstream version. Any comments will be welcome. [*]http://accc.riken.jp/en/supercom/himenobmt/ Th

Re: [Qemu-devel] [PATCH RFC] migration: set cpu throttle value by workload

2016-12-29 Thread Chao Fan
Hi all, There is something to explain in this RFC PATCH. On Thu, Dec 29, 2016 at 05:16:19PM +0800, Chao Fan wrote: >This RFC PATCH is my demo about the new feature, here is my POC mail: >https://lists.gnu.org/archive/html/qemu-devel/2016-12/msg00646.html > >When migration_bitmap_s

[Qemu-devel] [PATCH RFC] migration: set cpu throttle value by workload

2016-12-29 Thread Chao Fan
-by: Chao Fan <fanc.f...@cn.fujitsu.com> --- include/qemu/bitmap.h | 17 + migration/ram.c | 49 + 2 files changed, 66 insertions(+) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 63ea2d0..dc99f9b

Re: [Qemu-devel] An issue for migration determining the cpu throttle value according to workload

2016-12-11 Thread Chao Fan
ping... Thanks, Chao Fan On Tue, Dec 06, 2016 at 04:52:11PM +0800, Chao Fan wrote: >Hi all, > >Here is an issue in auto-converge feature of migration. > >When migrating a guest which consumes too much CPU & memory, dirty >pages amount will increase significantly, so do

[Qemu-devel] An issue for migration determining the cpu throttle value according to workload

2016-12-06 Thread Chao Fan
hink this feature is needed. If anyone has good ideas, please tell me. Thanks, Chao Fan

[Qemu-devel] [PATCH v2] migration: check the value of cpu throttle in migrate_set_parameters

2016-11-23 Thread Chao Fan
, cpu_throttle_increment will be useless, as the the percentage of CPU frequency will be 1, the least value. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> --- v2: fix the wrong variable type --- migration/migration.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/mig

[Qemu-devel] [PATCH] migration: check the value of cpu throttle in migrate_set_parameters

2016-11-23 Thread Chao Fan
, cpu_throttle_increment will be useless, as the the percentage of CPU frequency will be 1, the least value. Signed-off-by: Chao Fan <fanc.f...@cn.fujitsu.com> --- migration/migration.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/migration/migration.c b/migration/migra