Re: [PATCH 06/12] target/s390x: add zpci-interp to cpu models

2021-12-08 Thread Christian Borntraeger
Am 07.12.21 um 22:04 schrieb Matthew Rosato: The zpci-interp feature is used to specify whether zPCI interpretation is to be used for this guest. Signed-off-by: Matthew Rosato --- target/s390x/cpu_features_def.h.inc | 1 + target/s390x/gen-features.c | 2 ++ target/s390x/kvm/kvm.c

Re: [RFC PATCH] s390: kvm: reduce frequency of CPU syncs of diag318 info

2021-12-06 Thread Christian Borntraeger
Am 02.12.21 um 21:54 schrieb Collin Walling: On 11/23/21 01:14, Christian Borntraeger wrote: Am 22.11.21 um 23:33 schrieb Collin Walling: DIAGNOSE 0318 is invoked only once during IPL. As such, the diag318 info will only change once initially and during resets. Let's only sync the register

Re: [PATCH] s390x/ipl: support extended kernel command line size

2021-11-29 Thread Christian Borntraeger
This parm area has always been initialized to zero, so with older kernels this field would read zero and we must then assume that only 896 bytes are available. Acked-by: Viktor Mihajlovski Signed-off-by: Marc Hartmayer Reviewed-by: Christian Borntraeger --- hw/s390x/

[PATCH v2 1/1] MAINTAINERS: update email address of Christian Borntraeger

2021-11-26 Thread Christian Borntraeger
My borntrae...@de.ibm.com email is just a forwarder to the linux.ibm.com address. Let us remove the extra hop to avoid a potential source of errors. While at it, add the relevant email addresses to mailmap. Signed-off-by: Christian Borntraeger --- .mailmap| 1 + MAINTAINERS | 6 +++--- 2

Re: [PATCH 1/1] MAINTAINERS: update email address of Christian Borntraeger

2021-11-23 Thread Christian Borntraeger
Am 23.11.21 um 10:55 schrieb Christian Borntraeger: My borntrae...@de.ibm.com email is just a forwarder to the linux.ibm.com address. Let us remove the extra hop to avoid a potential source of errors. While at it, add the relevant email addresses to mailmap. Signed-off-by: Christian

[PATCH 1/1] MAINTAINERS: update email address of Christian Borntraeger

2021-11-23 Thread Christian Borntraeger
My borntrae...@de.ibm.com email is just a forwarder to the linux.ibm.com address. Let us remove the extra hop to avoid a potential source of errors. While at it, add the relevant email addresses to mailmap. Signed-off-by: Christian Borntraeger --- .mailmap| 1 + MAINTAINERS | 6 +++--- 2

Re: [PATCH v4] s390: kvm: adjust diag318 resets to retain data

2021-11-23 Thread Christian Borntraeger
;s390: guest support for diagnose 0x318") Reported-by: Christian Borntraeger Reviewed-by: Janosch Frank Reviewed-by: Christian Borntraeger Thomas, I think this is good to go. Will you take it via your tree? --- Changelog: v4 - fixed up commit message and added r-b's v3

Re: [RFC PATCH] s390: kvm: reduce frequency of CPU syncs of diag318 info

2021-11-22 Thread Christian Borntraeger
Am 22.11.21 um 23:33 schrieb Collin Walling: DIAGNOSE 0318 is invoked only once during IPL. As such, the diag318 info will only change once initially and during resets. Let's only sync the register to convey the info to KVM if and only if the diag318 info has changed. Only set the dirty bit

Re: [PATCH v3] s390: kvm: adjust diag318 resets to retain data

2021-11-16 Thread Christian Borntraeger
, the CPNC will be retained for each VCPU in the configuration after the diag 318 instruction has been invoked. Signed-off-by: Collin Walling Fixes: fabdada9357b ("s390: guest support for diagnose 0x318") Reported-by: Christian Borntraeger Reviewed-by: Christian Borntraeger maybe add cc s

Re: [PATCH v2] s390x: kvm: adjust diag318 resets to retain data

2021-11-08 Thread Christian Borntraeger
Walling Fixes: fabdada9357b ("s390: guest support for diagnose 0x318") Reported-by: Christian Borntraeger It would be good to add at least a comment in the diag308 handlers where the value of cpnc is resetted during the resets that Janosch mentioned. --- Changelog: v2

Re: [PATCH] s390x: kvm: adjust diag318 resets to retain data

2021-11-08 Thread Christian Borntraeger
Am 08.11.21 um 18:02 schrieb Janosch Frank: On 11/5/21 23:46, Collin Walling wrote: The CPNC portion of the diag 318 data is erroneously reset during an initial CPU reset caused by SIGP. Let's go ahead and relocate the diag318_info field within the CPUS390XState struct such that it is only

Re: [PATCH] s390x: kvm: adjust diag318 resets to retain data

2021-11-08 Thread Christian Borntraeger
Am 05.11.21 um 23:46 schrieb Collin Walling: The CPNC portion of the diag 318 data is erroneously reset during an initial CPU reset caused by SIGP. Let's go ahead and relocate the diag318_info field within the CPUS390XState struct such that it is only zeroed during a clear reset. This way,

Re: [PATCH] monitor: Fix find_device_state() for IDs containing slashes

2021-10-19 Thread Christian Borntraeger
a relative path. The obvious function to resolve relative paths is object_resolve_path(). It picks a parent automatically. Too much magic, we want to specify the parent. Create new object_resolve_path_at() for that, and use it in find_device_state(). Reported-by: Christian Borntraeger Si

regression on s390: was Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-18 Thread Christian Borntraeger
Am 15.10.21 um 21:15 schrieb Richard Henderson: On 10/15/21 4:08 AM, Christian Borntraeger wrote: Am 13.10.21 um 11:07 schrieb Paolo Bonzini: From: Markus Armbruster Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept

Re: [PULL 37/40] monitor: Tidy up find_device_state()

2021-10-15 Thread Christian Borntraeger
Am 13.10.21 um 11:07 schrieb Paolo Bonzini: From: Markus Armbruster Commit 6287d827d4 "monitor: allow device_del to accept QOM paths" extended find_device_state() to accept QOM paths in addition to qdev IDs. This added a checked conversion to TYPE_DEVICE at the end, which duplicates the

Re: [PATCH v3 1/1] virtio: write back F_VERSION_1 before validate

2021-10-13 Thread Christian Borntraeger
Am 13.10.21 um 12:10 schrieb Michael S. Tsirkin: On Mon, Oct 11, 2021 at 07:39:21AM +0200, Halil Pasic wrote: The virtio specification virtio-v1.1-cs01 states: "Transitional devices MUST detect Legacy drivers by detecting that VIRTIO_F_VERSION_1 has not been acknowledged by the driver."

Re: [RFC PATCH v1 2/2] s390x/kvm: Pass SIGP Stop flags

2021-10-11 Thread Christian Borntraeger
Am 11.10.21 um 09:09 schrieb David Hildenbrand: On 08.10.21 22:38, Eric Farman wrote: When building a Stop IRQ to pass to KVM, we should incorporate the flags if handling the SIGP Stop and Store Status order. With that, KVM can reject other orders that are submitted for the same CPU while

Re: [PATCH] s390x/ipl: check kernel command line size

2021-10-06 Thread Christian Borntraeger
Am 06.10.21 um 11:26 schrieb Marc Hartmayer: Check if the provided kernel command line exceeds the maximum size of the s390x Linux kernel command line size, which is 896 bytes. Reported-by: Sven Schnelle Signed-off-by: Marc Hartmayer Reviewed-by: Christian Borntraeger --- hw/s390x

Re: [PATCH] block: introduce max_hw_iov for use in scsi-generic

2021-09-24 Thread Christian Borntraeger
Peter, Michael, do we still do stable releases for QEMU or has this stopped? Am 24.09.21 um 07:27 schrieb Paolo Bonzini: Yes, the question is whether it still exists... Paolo El jue., 23 sept. 2021 16:48, Christian Borntraeger escribió: Am 23.09.21 um 15:04 schrieb Paolo Bonzini: > Li

Re: [PATCH] block: introduce max_hw_iov for use in scsi-generic

2021-09-23 Thread Christian Borntraeger
Am 23.09.21 um 15:04 schrieb Paolo Bonzini: Linux limits the size of iovecs to 1024 (UIO_MAXIOV in the kernel sources, IOV_MAX in POSIX). Because of this, on some host adapters requests with many iovecs are rejected with -EINVAL by the io_submit() or readv()/writev() system calls. In fact,

Recent qemu patch results in aio failures with host DASD disks resulting in guest I/O errors

2021-09-23 Thread Christian Borntraeger
Am 22.09.21 um 21:51 schrieb Halil Pasic: On Mon, 6 Sep 2021 16:24:20 +0200 Halil Pasic wrote: On Fri, 25 Jun 2021 16:18:12 +0200 Paolo Bonzini wrote: bs->sg is only true for character devices, but block devices can also be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET

[PATCH v2] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread Christian Borntraeger
Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/gen-features.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/s390x

Re: [PATCH] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread Christian Borntraeger
On 07.09.21 11:11, Christian Borntraeger wrote: Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/gen-features.c | 8 +++- 2 files changed

[PATCH] s390x/cpumodel: Add more feature to gen16 default model

2021-09-07 Thread Christian Borntraeger
Add the new gen16 features to the default model and fence them for machine version 6.1 and earlier. Signed-off-by: Christian Borntraeger --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/gen-features.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/s390x

Re: [PATCH v2 0/5] s390x: CPU Topology

2021-08-30 Thread Christian Borntraeger
On 26.08.21 11:22, Pierre Morel wrote: a gentle ping :) I would like if you have time, comments on the architecture I propose, if the handling is done at the right level, KVM vs QEMU. Do we expect changes in this series due to the discussed changes of PTF interpretion? Therefor I

Re: [PATCH 0/2] s390x: ccw: A simple test device for virtio CCW

2021-08-30 Thread Christian Borntraeger
On 27.08.21 12:50, Pierre Morel wrote: Hello All, This series presents a VIRTIO test device which receives data on its input channel and sends back a simple checksum for the data it received on its output channel. The goal is to allow a simple VIRTIO device driver to check the VIRTIO

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-08-19 Thread Christian Borntraeger
On 19.08.21 16:51, Christian Borntraeger wrote: On 19.08.21 10:43, Christian Borntraeger wrote: Interestingly enough this breaks my rpmbuild (both rpmbuild and mock). (mostly with a modified f35 spec file): cc -Isubprojects/libvhost-user/libvhost-user.a.p -Isubprojects/libvhost-user -I

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-08-19 Thread Christian Borntraeger
On 19.08.21 10:43, Christian Borntraeger wrote: Interestingly enough this breaks my rpmbuild (both rpmbuild and mock). (mostly with a modified f35 spec file): cc -Isubprojects/libvhost-user/libvhost-user.a.p -Isubprojects/libvhost-user -I../subprojects/libvhost-user -fdiagnostics-color=auto

Re: [PULL 6/7] meson: fix meson 0.58 warning with libvhost-user subproject

2021-08-19 Thread Christian Borntraeger
Interestingly enough this breaks my rpmbuild (both rpmbuild and mock). (mostly with a modified f35 spec file): cc -Isubprojects/libvhost-user/libvhost-user.a.p -Isubprojects/libvhost-user -I../subprojects/libvhost-user -fdiagnostics-color=auto -pipe -Wall -Winvalid-pch -std=gnu11 -O2 -g

Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-16 Thread Christian Borntraeger
On 16.07.21 16:58, Christian Borntraeger wrote: On 16.07.21 16:51, Richard Henderson wrote: On 7/16/21 4:28 AM, Christian Borntraeger wrote:   --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now" Full configure line is ../configure --prefix=/usr --libdir=

Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-16 Thread Christian Borntraeger
On 16.07.21 16:51, Richard Henderson wrote: On 7/16/21 4:28 AM, Christian Borntraeger wrote:   --extra-ldflags="-Wl,--build-id -pie -Wl,-z,relro -Wl,-z,now" Full configure line is ../configure --prefix=/usr --libdir=/usr/lib64 --sysconfdir=/etc --interp-prefix

Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-16 Thread Christian Borntraeger
On 16.07.21 08:54, Christian Borntraeger wrote: On 12.07.21 14:26, Alex Bennée wrote: Aside from a minor bloat to file size the ability to have TCG plugins has no real impact on performance unless a plugin is actively loaded. Even then the libempty.so plugin shows only a minor degradation

Re: [PULL 32/40] tcg/plugins: enable by default for most TCG builds

2021-07-16 Thread Christian Borntraeger
On 12.07.21 14:26, Alex Bennée wrote: Aside from a minor bloat to file size the ability to have TCG plugins has no real impact on performance unless a plugin is actively loaded. Even then the libempty.so plugin shows only a minor degradation in performance caused by the extra book keeping the

[PATCH fixup] s390x: fixup for "s390x/cpumodel: add 3931 and 3932"

2021-07-01 Thread Christian Borntraeger
as discussed we want to change some facility names. Please merge Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features_def.h.inc | 4 ++-- target/s390x/gen-features.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x

Re: [PATCH 1/1] s390x/cpumodel: add 3931 and 3932

2021-06-30 Thread Christian Borntraeger
On 30.06.21 17:32, Cornelia Huck wrote: On Wed, Jun 30 2021, Christian Borntraeger wrote: On 30.06.21 15:32, David Hildenbrand wrote: On 22.06.21 22:19, Christian Borntraeger wrote: This defines 5 new facilities and the new 3931 and 3932 machines. As before the name is not yet known

Re: [PATCH 1/1] s390x/cpumodel: add 3931 and 3932

2021-06-30 Thread Christian Borntraeger
On 30.06.21 15:32, David Hildenbrand wrote: On 22.06.21 22:19, Christian Borntraeger wrote: This defines 5 new facilities and the new 3931 and 3932 machines. As before the name is not yet known and we do use gen16a and gen16b. The new features are part of the full model. The default model

[PATCH 1/1] s390x/cpumodel: add 3931 and 3932

2021-06-22 Thread Christian Borntraeger
add the dependencies of new facilities and as a fix for z15 add a dependency from S390_FEAT_VECTOR_PACKED_DECIMAL_ENH to S390_VECTOR_PACKED_DECIMAL. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_features_def.h.inc | 5 + target/s390x/cpu_models.c | 6 ++ target

[PATCH 0/1] Add features and cpu models

2021-06-22 Thread Christian Borntraeger
5 new features and 2 new models Christian Borntraeger (1): s390x/cpumodel: add 3931 and 3932 target/s390x/cpu_features_def.h.inc | 5 + target/s390x/cpu_models.c | 6 ++ target/s390x/gen-features.c | 14 ++ 3 files changed, 25 insertions(+) -- 2.31.1

Re: [PATCH 0/5] linux-user/s390x: Fix psw.mask handling in signals

2021-06-15 Thread Christian Borntraeger
On 15.06.21 05:07, Richard Henderson wrote: The PSW_MASK_CC component of psw.mask was not handled properly in the creation or restoration of signal frames. Maybe add a Reported-by: jonathan.albre...@linux.vnet.ibm.com in the right patches? Richard Henderson (5): target/s390x:

Re: [PULL 03/34] tcg: Re-order tcg_region_init vs tcg_prologue_init

2021-06-14 Thread Christian Borntraeger
On 12.06.21 01:41, Richard Henderson wrote: Instead of delaying tcg_region_init until after tcg_prologue_init is complete, do tcg_region_init first and let tcg_prologue_init shrink the first region by the size of the generated prologue. Reviewed-by: Luis Pires Reviewed-by: Alex Bennée

Re: [PATCH v3 0/2] target/s390x: Fix SIGILL psw.addr reporting

2021-06-10 Thread Christian Borntraeger
On 10.06.21 11:49, David Hildenbrand wrote: On 02.06.21 02:22, Ilya Leoshkevich wrote: qemu-s390x puts a wrong value into SIGILL's siginfo_t's psw.addr: it should be a pointer to the instruction following the illegal instruction, but at the moment it is a pointer to the illegal instruction

qemu io test: spurious failures of 030

2021-06-10 Thread Christian Borntraeger
Folks, I have CI on s390 on qemu/master for each commit. And from time to time I do get spurious failures of 030. (always 030 and nothing else). I have a hard time reproducing this manually so I cannot debug this at the moment. Has anyone seen this as well? 030

Re: [PATCH] s390x/kvm: remove unused gs handling

2021-06-07 Thread Christian Borntraeger
gs as well. Signed-off-by: Cornelia Huck Reviewed-by: Christian Borntraeger --- target/s390x/kvm-stub.c | 5 - target/s390x/kvm.c | 10 +- target/s390x/kvm_s390x.h | 1 - 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/target/s390x/kvm-stub.c b/target

Re: [PATCH 4/4] pc-bios/s390-ccw: Allow building with Clang, too

2021-05-03 Thread Christian Borntraeger
On 03.05.21 11:31, Thomas Huth wrote: On 03/05/2021 11.14, Cornelia Huck wrote: On Mon, 03 May 2021 10:23:20 +0200 Markus Armbruster wrote: David Hildenbrand writes: On 03.05.21 07:17, Thomas Huth wrote: On 03/05/2021 06.58, Markus Armbruster wrote: Thomas Huth writes: Clang

Re: Compiling the s390-ccw bios with clang

2021-04-23 Thread Christian Borntraeger
On 23.04.21 09:57, Thomas Huth wrote: On 23/04/2021 08.52, Christian Borntraeger wrote: [...] We can of course discuss if we compile the BIOS for z10 instead of z900. TCG in the mean time can handle up to z13 and z10 is now also 13 years old. I'd really like to see us supporting Clang

Re: s390-ccw: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]

2021-04-23 Thread Christian Borntraeger
, Philippe Mathieu-Daudé wrote: On 4/22/21 2:41 PM, Christian Borntraeger wrote: On 22.04.21 13:47, Thomas Huth wrote: On 22/04/2021 13.24, Philippe Mathieu-Daudé wrote: On 4/22/21 12:30 PM, Peter Maydell wrote: On Thu, 22 Apr 2021 at 11:18, Daniel P. Berrangé wrote: This silents the warning

Re: [PATCH] pc-bios/s390-ccw: Silence GCC 11 stringop-overflow warning

2021-04-22 Thread Christian Borntraeger
homas Huth Signed-off-by: Philippe Mathieu-Daudé untested, but Acked-by: Christian Borntraeger --- pc-bios/s390-ccw/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile index 29fd9019b83..21581d1258d 100644 --- a/pc-bios/s390-cc

Re: s390-ccw: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]

2021-04-22 Thread Christian Borntraeger
On 22.04.21 13:47, Thomas Huth wrote: On 22/04/2021 13.24, Philippe Mathieu-Daudé wrote: On 4/22/21 12:30 PM, Peter Maydell wrote: On Thu, 22 Apr 2021 at 11:18, Daniel P. Berrangé wrote: On Thu, Apr 22, 2021 at 06:47:30AM +0200, Thomas Huth wrote: On 22/04/2021 06.18, Philippe

Re: s390-ccw: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]

2021-04-22 Thread Christian Borntraeger
On 22.04.21 06:47, Thomas Huth wrote: On 22/04/2021 06.18, Philippe Mathieu-Daudé wrote: Hi Thomas, Daniel, Stefano, Regarding the following warning (GCC 11 on Fedora 34): In file included from pc-bios/s390-ccw/main.c:11: In function ‘memset’, inlined from ‘boot_setup’ at

Re: [PATCH] pc-bios/s390-ccw/bootmap: Silence compiler warning from Clang

2021-04-21 Thread Christian Borntraeger
h Reviewed-by: Christian Borntraeger --- pc-bios/s390-ccw/bootmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/bootmap.c b/pc-bios/s390-ccw/bootmap.c index 44df7d16af..e4b2e5a1b0 100644 --- a/pc-bios/s390-ccw/bootmap.c +++ b/pc-bios/s390-ccw/bootma

Re: [PATCH] MAINTAINERS: add/replace backups for some s390 areas

2021-03-26 Thread Christian Borntraeger
On 25.03.21 14:55, Matthew Rosato wrote: S390 PCI currently has no backup, add one. Add an additional backup for vfio-ccw and refresh the backup for vfio-ap. Signed-off-by: Matthew Rosato Acked-by: Christian Borntraeger --- MAINTAINERS | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH 1/1] iotests: fix 051.out expected output after error text touchups

2021-03-19 Thread Christian Borntraeger
("block: Clarify error messages pertaining to 'node-name'") Signed-off-by: Connor Kuehl Tested-by: Christian Borntraeger Thanks for the quick response. --- tests/qemu-iotests/051.out | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/qemu-iotests/051.o

iotest 051 failure on s390

2021-03-18 Thread Christian Borntraeger
On s390 with latest master I do get 051 fail [17:30:00] [17:30:05] 5.4s output mismatch (see 051.out.bad) --- /home/cborntra/REPOS/qemu/tests/qemu-iotests/051.out +++ 051.out.bad @@ -61,13 +61,13 @@ (qemu) quit Testing: -drive file=TEST_DIR/t.qcow2,node-name=123foo

Re: [PATCH for 6.0 v3] hw/intc/i8259: Refactor pic_read_irq() to avoid uninitialized variable

2021-03-18 Thread Christian Borntraeger
Christian Borntraeger Signed-off-by: Philippe Mathieu-Daudé Tested-by: Christian Borntraeger --- Since v2: - Remove pic_intack() call (Zoltan) --- hw/intc/i8259.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index 3

Re: [PATCH] intc/i8259: avoid (false positive) gcc warning

2021-03-18 Thread Christian Borntraeger
On 18.03.21 17:03, Paolo Bonzini wrote: On 18/03/21 16:47, Christian Borntraeger wrote: some copiler versions are smart enough to detect a potentially uninitialized variable, but are not smart enough to detect that this cannot happen due to the code flow: ../hw/intc/i8259.c: In function

[PATCH] intc/i8259: avoid (false positive) gcc warning

2021-03-18 Thread Christian Borntraeger
in this function [-Werror=maybe-uninitialized] 203 | irq = irq2 + 8; | ^~ Let us initialize irq2 to -1 to avoid this warning as the most simple solution. Signed-off-by: Christian Borntraeger --- hw/intc/i8259.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PULL 13/18] hw/core: implement a guest-loader to support static hypervisor guests

2021-03-15 Thread Christian Borntraeger
-cmds.c', 'numa.c', Also Tested-by: Christian Borntraeger

Re: [PULL 13/18] hw/core: implement a guest-loader to support static hypervisor guests

2021-03-15 Thread Christian Borntraeger
On 15.03.21 17:44, Philippe Mathieu-Daudé wrote: On 3/15/21 5:16 PM, Christian Borntraeger wrote: On 08.03.21 14:50, Alex Bennée wrote: Hypervisors, especially type-1 ones, need the firmware/bootcode to put their initial guest somewhere in memory and pass the information to it via

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 17:20, Thomas Huth wrote: On 15/03/2021 16.44, Christian Borntraeger wrote: On 15.03.21 16:14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi

Re: [PULL 13/18] hw/core: implement a guest-loader to support static hypervisor guests

2021-03-15 Thread Christian Borntraeger
On 08.03.21 14:50, Alex Bennée wrote: Hypervisors, especially type-1 ones, need the firmware/bootcode to put their initial guest somewhere in memory and pass the information to it via platform data. The guest-loader is modelled after the generic loader for exactly this sort of purpose:

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 16:58, Thomas Huth wrote: On 15/03/2021 16.50, Philippe Mathieu-Daudé wrote: On 3/15/21 4:42 PM, Thomas Huth wrote: On 15/03/2021 16.14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 16:14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone -I/usr/include/glib-2.0 -I/usr/lib64/glib

Re: compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
On 15.03.21 16:42, Thomas Huth wrote: On 15/03/2021 16.14, Christian Borntraeger wrote: For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone

compile warning in i8259.c

2021-03-15 Thread Christian Borntraeger
For some time now I do see the following, when I compile x86-softmmu on s390: FAILED: libcommon.fa.p/hw_intc_i8259.c.o cc -Ilibcommon.fa.p -I. -I.. -Iqapi -Itrace -Iui -Iui/shader -I/usr/include/capstone -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount

Re: [PATCH 4/9] pc-bios/s390-ccw/netmain.c: Changed a malloc/free to GLib's variants

2021-03-13 Thread Christian Borntraeger
On 13.03.21 17:36, Mahmoud Mandour wrote: Changed a call to malloc() and its respective calls free() with GLib's allocation and deallocation functions. Signed-off-by: Mahmoud Mandour Nack. This is BIOS code and it does not have glib. --- pc-bios/s390-ccw/netmain.c | 6 +++--- 1 file

Re: [PATCH] s390x/cpu_model: use official name for 8562

2021-03-12 Thread Christian Borntraeger
On 11.03.21 14:27, Cornelia Huck wrote: The single-frame z15 is called "z15 T02". Signed-off-by: Cornelia Huck Acked-by: Christian Borntraeger --- target/s390x/cpu_models.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/cpu_models.c b/ta

Re: [PATCH v1 1/2] s390x/kvm: Get rid of legacy_s390_alloc()

2021-03-03 Thread Christian Borntraeger
always be around on kernels that also have KVM_CAP_DEVICE_CTRL (>= v3.15). [1] https://www.ibm.com/support/lifecycle/search?q=z%2FVM Suggested-by: Cornelia Huck Suggested-by: Thomas Huth Cc: Paolo Bonzini Cc: Richard Henderson Cc: Halil Pasic Cc: Cornelia Huck Cc: Christian Borntraeger C

Re: [PATCH v3] target/s390x/arch_dump: Fix warning for the name field in the PT_NOTE section

2021-02-05 Thread Christian Borntraeger
also add an assert() to make > sure that the provided names always fit the size field (which is fine for > the current callers, the function is called once with "CORE" and once with > "LINUX" as a name). > > Signed-off-by: Thomas Huth Reviewed-by: Christian Born

Re: [PATCH v2] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 05.02.21 08:08, Christian Borntraeger wrote: > > > On 05.02.21 07:12, Thomas Huth wrote: >> On 04/02/2021 18.00, Christian Borntraeger wrote: >>> On 04.02.21 17:41, Thomas Huth wrote: >>>> According to the "ELF-64 Object File Format" specifi

Re: [PATCH v2] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 05.02.21 07:12, Thomas Huth wrote: > On 04/02/2021 18.00, Christian Borntraeger wrote: >> On 04.02.21 17:41, Thomas Huth wrote: >>> According to the "ELF-64 Object File Format" specification: >>> >>> "The first word in the entry, names

Re: [PATCH v2] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 04.02.21 17:41, Thomas Huth wrote: > According to the "ELF-64 Object File Format" specification: > > "The first word in the entry, namesz, identifies the length, in > bytes, of a name identifying the entry’s owner or originator. The name field > contains a null-terminated string, with

Re: [PATCH] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 04.02.21 14:09, Thomas Huth wrote: > On 04/02/2021 14.01, Christian Borntraeger wrote: >> >> >> On 03.02.21 10:44, Thomas Huth wrote: >>> According to the "ELF-64 Object File Format" specification: >>> >>> "The first word in the

Re: [PATCH] target/s390x/arch_dump: Fixes for the name field in the PT_NOTE section

2021-02-04 Thread Christian Borntraeger
On 03.02.21 10:44, Thomas Huth wrote: > According to the "ELF-64 Object File Format" specification: > > "The first word in the entry, namesz, identifies the length, in > bytes, of a name identifying the entry’s owner or originator. The name field > contains a null-terminated string, with

Re: [PATCH v8 13/13] s390: Recognize confidential-guest-support option

2021-02-03 Thread Christian Borntraeger
right model. This may be >a little surprising, but shouldn't actually be harmful. > > To start a guest supporting Protected Virtualization using the new > option use the command line arguments: > -object s390-pv-guest,id=pv0 -machine confidential-guest-support=pv0 >

[PATCH v3] s390x/cpu_model: disallow unpack for --only-migratable

2021-01-25 Thread Christian Borntraeger
-migratable, we would get a failure only when the guest actually tries to transition; instead, explicitly disallow the unpack facility if --only-migratable was specified to avoid late surprises. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand --- target/s390x/cpu_models.c | 10

Re: [PATCH v2] s390x/cpu_model: disallow unpack for --only-migratable

2021-01-25 Thread Christian Borntraeger
On 25.01.21 14:38, Cornelia Huck wrote: > On Mon, 25 Jan 2021 14:22:38 +0100 > Christian Borntraeger wrote: > >> secure execution (aka protected virtualization) guests cannot be >> migrated at the moment. Disallow the unpack facility if the user >> specifies --only-

[PATCH v2] s390x/cpu_model: disallow unpack for --only-migratable

2021-01-25 Thread Christian Borntraeger
secure execution (aka protected virtualization) guests cannot be migrated at the moment. Disallow the unpack facility if the user specifies --only-migratable. Signed-off-by: Christian Borntraeger --- v1->v2: - add missing return - protect check with CONFIG_USER_ONLY for building non soft

Re: [PATCH] s390x/cpu_model: disallow unpack for --only-migratable

2021-01-25 Thread Christian Borntraeger
On 25.01.21 13:57, David Hildenbrand wrote: > On 25.01.21 13:53, Christian Borntraeger wrote: >> secure execution (aka protected virtualization) guests cannot be >> migrated at the moment. Disallow the unpack facility if the user >> specifies --only-migratable. >>

[PATCH] s390x/cpu_model: disallow unpack for --only-migratable

2021-01-25 Thread Christian Borntraeger
secure execution (aka protected virtualization) guests cannot be migrated at the moment. Disallow the unpack facility if the user specifies --only-migratable. Signed-off-by: Christian Borntraeger --- target/s390x/cpu_models.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/target

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-19 Thread Christian Borntraeger
On 18.01.21 18:39, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: >> On Thu, Jan 14, 2021 at 11:25:17AM +, Daniel P. Berrangé wrote: >>> On Wed, Jan 13, 2021 at 12:42:26PM +, Dr. David Alan Gilbert wrote: * Cornelia Huck (coh...@redhat.com)

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-18 Thread Christian Borntraeger
On 15.01.21 17:36, Cornelia Huck wrote: > On Thu, 14 Jan 2021 10:58:11 +1100 > David Gibson wrote: > >> At least some s390 cpu models support "Protected Virtualization" (PV), >> a mechanism to protect guests from eavesdropping by a compromised >> hypervisor. >> >> This is similar in function

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 14.01.21 15:15, Daniel P. Berrangé wrote: > On Thu, Jan 14, 2021 at 03:09:01PM +0100, Christian Borntraeger wrote: >> >> >> On 14.01.21 15:04, Cornelia Huck wrote: >>> On Thu, 14 Jan 2021 12:20:48 + >>> Daniel P. Berrangé wrote: >>> >>

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 14.01.21 15:04, Cornelia Huck wrote: > On Thu, 14 Jan 2021 12:20:48 + > Daniel P. Berrangé wrote: > >> On Thu, Jan 14, 2021 at 12:50:12PM +0100, Christian Borntraeger wrote: >>> >>> >>> On 14.01.21 12:45, Dr. David Alan Gilbert wrote: >

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 14.01.21 12:45, Dr. David Alan Gilbert wrote: > * Cornelia Huck (coh...@redhat.com) wrote: >> On Thu, 14 Jan 2021 11:52:11 +0100 >> Christian Borntraeger wrote: >> >>> On 14.01.21 11:36, Dr. David Alan Gilbert wrote: >>>> * Christian

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 14.01.21 11:36, Dr. David Alan Gilbert wrote: > * Christian Borntraeger (borntrae...@de.ibm.com) wrote: >> >> >> On 13.01.21 13:42, Dr. David Alan Gilbert wrote: >>> * Cornelia Huck (coh...@redhat.com) wrote: >>>> On Tue, 5 Jan 2021 12:41:25 -0800 &

Re: [for-6.0 v5 11/13] spapr: PEF: prevent migration

2021-01-14 Thread Christian Borntraeger
On 13.01.21 13:42, Dr. David Alan Gilbert wrote: > * Cornelia Huck (coh...@redhat.com) wrote: >> On Tue, 5 Jan 2021 12:41:25 -0800 >> Ram Pai wrote: >> >>> On Tue, Jan 05, 2021 at 11:56:14AM +0100, Halil Pasic wrote: On Mon, 4 Jan 2021 10:40:26 -0800 Ram Pai wrote: >> > The main

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-14 Thread Christian Borntraeger
On 14.01.21 10:19, Christian Borntraeger wrote: > > > On 14.01.21 10:10, Christian Borntraeger wrote: >> >> >> On 14.01.21 00:58, David Gibson wrote: >> [...] >>> +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp) >>&

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-14 Thread Christian Borntraeger
On 14.01.21 10:10, Christian Borntraeger wrote: > > > On 14.01.21 00:58, David Gibson wrote: > [...] >> +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp) >> +{ >> +if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_

Re: [PATCH v7 13/13] s390: Recognize confidential-guest-support option

2021-01-14 Thread Christian Borntraeger
On 14.01.21 00:58, David Gibson wrote: [...] > +int s390_pv_init(ConfidentialGuestSupport *cgs, Error **errp) > +{ > +if (!object_dynamic_cast(OBJECT(cgs), TYPE_S390_PV_GUEST)) { > +return 0; > +} > + > +if (!s390_has_feat(S390_FEAT_UNPACK)) { > +error_setg(errp, > +

Re: [PATCH v6 13/13] s390: Recognize confidential-guest-support option

2021-01-12 Thread Christian Borntraeger
On 13.01.21 01:57, David Gibson wrote: > On Tue, Jan 12, 2021 at 12:36:07PM +0100, Cornelia Huck wrote: > 65;6201;1c> On Tue, 12 Jan 2021 09:15:26 +0100 >> Christian Borntraeger wrote: >> >>> On 12.01.21 05:45, David Gibson wrote: >>>> At lea

Re: [PATCH v6 13/13] s390: Recognize confidential-guest-support option

2021-01-12 Thread Christian Borntraeger
On 12.01.21 12:36, Cornelia Huck wrote: > On Tue, 12 Jan 2021 09:15:26 +0100 > Christian Borntraeger wrote: > >> On 12.01.21 05:45, David Gibson wrote: >>> At least some s390 cpu models support "Protected Virtualization" (PV), >>> a mec

Re: [PATCH v6 13/13] s390: Recognize confidential-guest-support option

2021-01-12 Thread Christian Borntraeger
On 12.01.21 05:45, David Gibson wrote: > At least some s390 cpu models support "Protected Virtualization" (PV), > a mechanism to protect guests from eavesdropping by a compromised > hypervisor. > > This is similar in function to other mechanisms like AMD's SEV and > POWER's PEF, which are

Re: [PATCH v6 10/13] spapr: Add PEF based confidential guest support

2021-01-11 Thread Christian Borntraeger
On 12.01.21 05:45, David Gibson wrote: [...] > diff --git a/include/hw/ppc/pef.h b/include/hw/ppc/pef.h > new file mode 100644 > index 00..7c92391177 > --- /dev/null > +++ b/include/hw/ppc/pef.h > @@ -0,0 +1,26 @@ > +/* > + * PEF (Protected Execution Facility) for POWER support > + * >

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 14:17, Miroslav Rezanina wrote: > > > - Original Message - >> From: "Christian Borntraeger" >> To: "Thomas Huth" , "Miroslav Rezanina" >> >> Cc: "qemu-s390x" , "Philippe Mathieu-Daudé"

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 13:54, Thomas Huth wrote: > On 11/01/2021 13.42, Miroslav Rezanina wrote: >> >> >> - Original Message - >>> From: "Thomas Huth" >>> To: "Philippe Mathieu-Daudé" , mreza...@redhat.com, >>> qemu-devel@nongnu.org, "qemu-s390x" >>> >>> Sent: Monday, January 11, 2021 1:24:57

Re: [RHEL7 qemu-kvm PATCH 2/3] s390x: Fix vm name copy length

2021-01-11 Thread Christian Borntraeger
On 11.01.21 14:02, Christian Borntraeger wrote: > > > On 11.01.21 13:54, Thomas Huth wrote: >> On 11/01/2021 13.42, Miroslav Rezanina wrote: >>> >>> >>> - Original Message - >>>> From: "Thomas Huth" >>>> To:

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Christian Borntraeger
On 11.01.21 11:05, Laszlo Ersek wrote: > On 01/11/21 10:46, Christian Borntraeger wrote: >> >> >> On 04.01.21 14:24, Laszlo Ersek wrote: >>> virtio-fs qualifies as a bootable device minimally under OVMF, but >>> currently the necessary "bootindex&

Re: [PATCH] vhost-user-fs: add the "bootindex" property

2021-01-11 Thread Christian Borntraeger
file: > > /pci@i0cf8/pci-bridge@1,6/pci1af4,105a@0/filesystem@0 > > Cc: "Dr. David Alan Gilbert" > Cc: "Michael S. Tsirkin" > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Stefan Hajnoczi > Cc: qemu-s3...@nongnu.org &g

Re: [PATCH v2 1/2] s390x/pci: fix pcistb length

2020-12-18 Thread Christian Borntraeger
quot;s390: implement pci instructions") > Signed-off-by: Matthew Rosato > Reviewed-by: Pierre Morel Reviewed-by: Christian Borntraeger > --- > hw/s390x/s390-pci-inst.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/s390x/s390-pci-ins

Re: [PATCH v2] s390x: pv: Fence additional unavailable SCLP facilities for PV guests

2020-12-11 Thread Christian Borntraeger
On 11.12.20 11:51, Janosch Frank wrote: > There's no VSIE support for a protected guest, so let's better not > advertise it and its support facilities. > > Signed-off-by: Janosch Frank Reviewed-by: Christian Borntraeger shall we add Fixes: 0f73c5b30b8b ("s390

<    1   2   3   4   5   6   7   8   9   10   >