> "AlexChen" == AlexChen writes:
AlexChen> We should use printf format specifier "%u" instead of "%d"
AlexChen> for argument of type "unsigned int".
AlexChen> Reported-by: Euler Robot
AlexChen>Signed-off-by: Alex Chen ---
LGTM,
add
Reviewed-By: Peter Chubb
--
Peter ChubbTe
Igor> If the user provided too large a RAM size, the code used to
Igor> complain and trim it to the max size. Now tht RAM is allocated by
Igor> generic code, that's no longer possible, so generate an error and
Igor> exit instead.
You can add my 'reviewed-by' to this. There's one really minor ty
> "Igor" == Igor Mammedov writes:
Igor> memory region.
Igor> Signed-off-by: Igor Mammedov
Igor> Reviewed-by: Philippe Mathieu-Daudé
Igor> ---
Igor> CC: peter.ch...@nicta.com.au
You can add:
Reviewed-by: Peter Chubb
Igor> CC: peter.mayd...@linaro.org
Igor> CC: qemu-...@nongnu.org
Peter
> "Igor" == Igor Mammedov writes:
Igor> If user provided non-sense RAM size, board will complain and
Igor> continue running with max RAM size supported. Also RAM is going
Igor> to be allocated by generic code, so it won't be possible for
Igor> board to fix things up for user.
Igor> Make it
> "Philippe" == Philippe Mathieu-Daudé writes:
Philippe> Fix some trivial warnings when building with -O3.
For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its
manual).
Fixing the comments' placement i
> "Thomas" == Thomas Huth writes:
Thomas> Add Kconfig dependencies for the fsl-imx31 / kzm machine.
Thomas> This patch is slightly based on earlier work by Ákos Kovács
Thomas> (i.e. his "hw/arm/Kconfig: Add ARM Kconfig" patch).
Thomas> Signed-off-by: Thomas Huth
Reviewed-by: Peter Chubb
