[Qemu-devel] [PATCH v3] help: Update help to remove misleading display information

2016-08-12 Thread Colin Lord
Updates the help messages to remove misleading information about SDL being the normal display used. Signed-off-by: Colin Lord --- v3: Try to make help more general to cover all cases nicely. qemu-options.hx | 38 +- 1 file changed, 21 insertions(+), 17

[Qemu-devel] [PATCH v8 0/4] Dynamic module loading for block drivers

2016-08-12 Thread Colin Lord
no longer in the filename - Fixed formatting of parallels_probe() function header - Enforced consistent naming convention for the probe functions. They now follow the pattern bdrv_format_probe(). Colin Lord (2): blockdev: prepare iSCSI block driver for dynamic loading blockdev: Modularize

[Qemu-devel] [PATCH v8 4/4] blockdev: Modularize nfs block driver

2016-08-12 Thread Colin Lord
Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/Makefile.objs b/block/Makefile.objs

[Qemu-devel] [PATCH v8 1/4] blockdev: prepare iSCSI block driver for dynamic loading

2016-08-12 Thread Colin Lord
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- block/iscsi.c | 36

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-12 Thread Colin Lord
On 08/11/2016 09:29 PM, Fam Zheng wrote: > On Thu, 08/11 12:03, Colin Lord wrote: >> On 08/10/2016 11:23 PM, Fam Zheng wrote: >>> On Wed, 08/10 21:06, Max Reitz wrote: >>>> On 10.08.2016 21:04, Colin Lord wrote: >>>>> On 08/10/2016 02:37 PM, Max Reitz

[Qemu-devel] [PATCH v8 2/4] blockdev: Add dynamic generation of module_block.h

2016-08-12 Thread Colin Lord
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: S

[Qemu-devel] [PATCH v8 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-12 Thread Colin Lord
ibbz2, while the main QEMU package needn't to. With this patch, we (temporarily) change the case so that the main QEMU depends on libbz2 again. Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi --- Makefile | 3 --- block.c

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-11 Thread Colin Lord
On 08/10/2016 11:23 PM, Fam Zheng wrote: > On Wed, 08/10 21:06, Max Reitz wrote: >> On 10.08.2016 21:04, Colin Lord wrote: >>> On 08/10/2016 02:37 PM, Max Reitz wrote: >>>> On 08.08.2016 20:07, Colin Lord wrote: >>>>> From: Marc Mari >>>>

Re: [Qemu-devel] [Qemu-block] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Colin Lord
On 08/10/2016 03:24 PM, Colin Lord wrote: > On 08/10/2016 03:04 PM, Colin Lord wrote: >> On 08/10/2016 02:37 PM, Max Reitz wrote: >>> On 08.08.2016 20:07, Colin Lord wrote: >>>> From: Marc Mari >>>> >>>> Extend the current module interface to

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Colin Lord
On 08/10/2016 03:04 PM, Colin Lord wrote: > On 08/10/2016 02:37 PM, Max Reitz wrote: >> On 08.08.2016 20:07, Colin Lord wrote: >>> From: Marc Mari >>> >>> Extend the current module interface to allow for block drivers to be >>> loaded dynamically o

Re: [Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver

2016-08-10 Thread Colin Lord
On 08/10/2016 03:04 PM, Max Reitz wrote: > On 08.08.2016 20:07, Colin Lord wrote: >> Modularizes the nfs block driver so that it gets dynamically loaded. >> >> Signed-off-by: Colin Lord >> Reviewed-by: Stefan Hajnoczi >> --- >> block/Makefile.objs | 1 +

Re: [Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-10 Thread Colin Lord
On 08/10/2016 02:37 PM, Max Reitz wrote: > On 08.08.2016 20:07, Colin Lord wrote: >> From: Marc Mari >> >> Extend the current module interface to allow for block drivers to be >> loaded dynamically on request. The only block drivers that can be >> converted into m

[Qemu-devel] [PATCH v7 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-08 Thread Colin Lord
a new structure found in module_block.h Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi --- Makefile | 3 --- block.c | 62 +-- block/Makefile.objs | 3 +-- include/qemu/module.h | 3 +++

[Qemu-devel] [PATCH v7 4/4] blockdev: Modularize nfs block driver

2016-08-08 Thread Colin Lord
Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Stefan Hajnoczi --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/Makefile.objs b/block/Makefile.objs

[Qemu-devel] [PATCH v7 2/4] blockdev: Add dynamic generation of module_block.h

2016-08-08 Thread Colin Lord
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: S

[Qemu-devel] [PATCH v7 1/4] blockdev: prepare iSCSI block driver for dynamic loading

2016-08-08 Thread Colin Lord
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng --- block/iscsi.c | 36 vl.c | 40

[Qemu-devel] [PATCH v7 0/4] Dynamic module loading for block drivers

2016-08-08 Thread Colin Lord
the filename - Fixed formatting of parallels_probe() function header - Enforced consistent naming convention for the probe functions. They now follow the pattern bdrv_format_probe(). Colin Lord (2): blockdev: prepare iSCSI block driver for dynamic loading blockdev: Modularize nfs block driver

Re: [Qemu-devel] [Qemu-block] [PATCH v6 1/4] blockdev: prepare iSCSI block driver for dynamic loading

2016-08-08 Thread Colin Lord
On 08/08/2016 11:18 AM, Stefan Hajnoczi wrote: > On Tue, Aug 02, 2016 at 10:12:14AM -0400, Colin Lord wrote: >> diff --git a/vl.c b/vl.c >> index e7c2c62..1a5f807 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -506,6 +506,41 @@ static QemuOptsList qemu_fw_cfg_opts = {

[Qemu-devel] [PATCH v2] help: Update help to reflect that GTK is the default

2016-08-05 Thread Colin Lord
Updates the help messages to reflect that GTK is the default display (if enabled), not SDL. Signed-off-by: Colin Lord --- v2: Update to try to implement Paolo's suggested wordings. It looks to me like the subsections get wrapped at 72 lines, which mean there was a bit of a ripple effec

[Qemu-devel] [PATCH 1/2] rules.mak: Don't extract libs from .mo-libs in link command

2016-08-02 Thread Colin Lord
link command incorrectly, spoiling the purpose of modularization. Currently we don't have any .mo-libs usage, but it will be used soon when we modularize more multi-source objects, like sdl and gtk. Reported-by: Colin Lord Signed-off-by: Fam Zheng --- rules.mak | 2 +- 1 file chang

[Qemu-devel] [PATCH 2/2] gtk: Modularize GTK display

2016-08-02 Thread Colin Lord
None. This should give improvements in terms of performance, since much less libraries will be loaded at startup if GTK is not being used, and in terms of packaging, since GTK should be able to be packaged separately in binary package managers now. Signed-off-by: Colin Lord --- Makefile.objs

[Qemu-devel] [PATCH 0/2] Modularize GTK Display

2016-08-02 Thread Colin Lord
le loading for block drivers'. Colin Lord (1): gtk: Modularize GTK display Fam Zheng (1): rules.mak: Don't extract libs from .mo-libs in link command Makefile.objs| 1 + configure| 5 ++-- include/ui/console.h | 6 + rules.mak| 2

[Qemu-devel] [PATCH v6 0/4] Dynamic module loading for block drivers

2016-08-02 Thread Colin Lord
ey follow the naming pattern of format-probe.c - Renamed crypto probe file to be crypto-probe.c, luks is no longer in the filename - Fixed formatting of parallels_probe() function header - Enforced consistent naming convention for the probe functions. They now follow the pattern bdrv_format_pro

[Qemu-devel] [PATCH v6 1/4] blockdev: prepare iSCSI block driver for dynamic loading

2016-08-02 Thread Colin Lord
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng --- block/iscsi.c | 36 vl.c | 38

Re: [Qemu-devel] [PATCH v6 0/4] Dynamic module loading for block drivers

2016-08-02 Thread Colin Lord
On 08/02/2016 10:12 AM, Colin Lord wrote: > I'm sending one more version of this series. v5 didn't seem to need any > huge makeovers, but I found a small bug in it so I'm hoping it hasn't > been committed yet. In v5, if a user explicitly specified the driver to >

[Qemu-devel] [PATCH v6 4/4] blockdev: Modularize nfs block driver

2016-08-02 Thread Colin Lord
Modularizes the nfs block driver so that it gets dynamically loaded. --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/Makefile.objs b/block/Makefile.objs index 595f366..fa4d8b8 100644 --- a/block/Makefile.objs +++ b/b

[Qemu-devel] [PATCH v6 3/4] blockdev: Add dynamic module loading for block drivers

2016-08-02 Thread Colin Lord
nd in module_block.h Signed-off-by: Marc Marí Signed-off-by: Colin Lord --- Makefile | 3 --- block.c | 62 +-- block/Makefile.objs | 3 +-- include/qemu/module.h | 3 +++ util/module.c

[Qemu-devel] [PATCH v6 2/4] blockdev: Add dynamic generation of module_block.h

2016-08-02 Thread Colin Lord
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí Signed-off-by: Colin Lord --- Mak

Re: [Qemu-devel] [PATCH for 2.8 3/3] sdl: Modularize

2016-07-27 Thread Colin Lord
On 07/27/2016 02:26 AM, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > Makefile.objs | 1 + > configure | 4 +-- > include/qemu/module.h | 2 ++ > include/ui/console.h | 5 ++-- > ui/Makefile.objs | 2 ++ > ui/sdl-init.c | 75 >

[Qemu-devel] [PATCH 2/2] blockdev: Modularize nfs block driver

2016-07-27 Thread Colin Lord
Modularizes the nfs block driver so that it gets dynamically loaded. Signed-off-by: Colin Lord --- block/Makefile.objs | 1 + configure | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/block/Makefile.objs b/block/Makefile.objs index 595f366..fa4d8b8 100644

[Qemu-devel] [PATCH 0/2] Modularize NFS Block Driver and Makefile Cleanup

2016-07-27 Thread Colin Lord
protocol block driver that links to external libraries that has not been modularized (once my last patch set is applied). Colin Lord (2): blockdev: Remove unnecessary lines from Makefile blockdev: Modularize nfs block driver Makefile| 3 --- block/Makefile.objs | 1 + configure

[Qemu-devel] [PATCH 1/2] blockdev: Remove unnecessary lines from Makefile

2016-07-27 Thread Colin Lord
Removes some superfluous lines from the Makefile which should have been removed as part of the patch series to add dynamic loading for block driver modules. Signed-off-by: Colin Lord --- Makefile | 3 --- 1 file changed, 3 deletions(-) diff --git a/Makefile b/Makefile index 4b9384e..c7aa8cd

[Qemu-devel] [PATCH] help: Update help to reflect that GTK is the default

2016-07-27 Thread Colin Lord
Updates the messages displayed in the help option to reflect that GTK is the default display, not SDL. --- qemu-options.hx | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8e0d9a5..5bec1d3 100644 --- a/qemu-options.hx +++

Re: [Qemu-devel] [PATCH v5 0/3] Dynamic module loading for block drivers

2016-07-25 Thread Colin Lord
On 07/23/2016 02:21 PM, Max Reitz wrote: > On 20.07.2016 16:30, Colin Lord wrote: >> Here's v5 of the modularization series. Since it seems the concensus is >> that modularizing the format drivers is unnecessary, this series no >> longer modularizes those and is thu

[Qemu-devel] [PATCH v5 1/3] blockdev: prepare iSCSI block driver for dynamic loading

2016-07-20 Thread Colin Lord
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng --- block/iscsi.c | 36 vl.c | 38

[Qemu-devel] [PATCH v5 2/3] blockdev: Add dynamic generation of module_block.h

2016-07-20 Thread Colin Lord
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí Signed-off-by: Colin Lord --- Mak

[Qemu-devel] [PATCH v5 0/3] Dynamic module loading for block drivers

2016-07-20 Thread Colin Lord
the filename - Fixed formatting of parallels_probe() function header - Enforced consistent naming convention for the probe functions. They now follow the pattern bdrv_format_probe(). Colin Lord (1): blockdev: prepare iSCSI block driver for dynamic loading Marc Mari (2): blockdev: Add dy

[Qemu-devel] [PATCH v5 3/3] blockdev: Add dynamic module loading for block drivers

2016-07-20 Thread Colin Lord
a new structure found in module_block.h Signed-off-by: Marc Marí Signed-off-by: Colin Lord --- block.c | 37 +++-- block/Makefile.objs | 3 +-- include/qemu/module.h | 3 +++ util/module.c | 38 +++--- 4 files ch

Re: [Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-19 Thread Colin Lord
On 07/19/2016 06:54 AM, Paolo Bonzini wrote: > > > On 14/07/2016 21:02, Colin Lord wrote: >> Here's v4 of the modularization series. Things that have changed since >> v3 include: >> >> - Fix indentation of the generated header file module_block.h >&g

Re: [Qemu-devel] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver

2016-07-18 Thread Colin Lord
On 07/18/2016 12:28 PM, Max Reitz wrote: > On 14.07.2016 21:03, Colin Lord wrote: >> Modifies the bochs probe to return the format name as well as the >> score as the final step of separating the probe function from the >> driver. This keeps the probe completely inde

[Qemu-devel] [PATCH v4 31/32] blockdev: Separate out bdrv_probe_device functions

2016-07-14 Thread Colin Lord
This puts the bdrv_probe_device functions into their own files to facilitate the modularization of the block drivers. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/host_cdrom-probe.c | 40 + block/host_device

[Qemu-devel] [PATCH v4 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver

2016-07-14 Thread Colin Lord
This commit finalizes the separation of the BlockDriver from its device probing function. Now the accesses to these functions in block.c occur through the protocol_probes array, and each function returns a score and protocol name with which to find the corresponding driver. Signed-off-by: Colin

[Qemu-devel] [PATCH v4 26/32] blockdev: Separate vdi probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vdi probe from the vdi driver. The vdi probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 22/32] blockdev: Separate qcow probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the qcow probe from the qcow driver. The qcow probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 28/32] blockdev: Separate vmdk probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vmdk probe from the vmdk driver. The vmdk probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 24/32] blockdev: Separate qed probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the qed probe from the qed driver. The qed probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 29/32] blockdev: Separate vpc probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vpc probe from the vpc driver. The vpc probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 18/32] blockdev: Separate cloop probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the cloop probe from the cloop driver. The cloop probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v4 14/32] blockdev: Move vhdx probe to its own file

2016-07-14 Thread Colin Lord
Isolates vhdx probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vhdx-probe.c| 21 + block/vhdx.c | 20 +--- include/block/probe.h | 1 + 4 files changed, 24

[Qemu-devel] [PATCH v4 16/32] blockdev: Move vpc probe to its own file

2016-07-14 Thread Colin Lord
Isolates vpc probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vpc-probe.c | 9 + block/vpc.c | 8 +--- include/block/probe.h | 1 + 4 files changed, 12 insertions(+), 8 deletions

[Qemu-devel] [PATCH v4 23/32] blockdev: Separate qcow2 probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the qcow2 probe from the qcow2 driver. The qcow2 probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v4 13/32] blockdev: Move vdi probe to its own file

2016-07-14 Thread Colin Lord
Isolates vdi probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vdi-probe.c | 26 +++ block/vdi.c | 69 ++- block/vdi.h

[Qemu-devel] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver

2016-07-14 Thread Colin Lord
allows the score to be correlated to the driver without the probe function needing to be part of the driver. Signed-off-by: Colin Lord --- block.c | 20 block/bochs-probe.c | 25 - block/bochs.c | 1 - include/block/probe.h | 3

[Qemu-devel] [PATCH v4 21/32] blockdev: Separate parallels probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the parallels probe from the parallels driver. The parallels probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers

2016-07-14 Thread Colin Lord
This commit finalizes the separation of the block driver and probe function by removing the .bdrv_probe field from all BlockDrivers. Probing is now accomplished solely by iterating over the array of probe function pointers in the format_probes array. Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 15/32] blockdev: Move vmdk probe to its own file

2016-07-14 Thread Colin Lord
Isolates vmdk probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/vmdk-probe.c| 60 +++ block/vmdk.c | 60

[Qemu-devel] [PATCH v4 19/32] blockdev: Separate luks probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the luks probe from the crypto driver. The luks probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v4 07/32] blockdev: Move dmg probe to its own file

2016-07-14 Thread Colin Lord
Isolate dmg probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/dmg-probe.c | 17 + block/dmg.c | 16 +--- include/block/probe.h | 1 + 4 files changed, 20 insertions

[Qemu-devel] [PATCH v4 12/32] blockdev: Move raw probe to its own file

2016-07-14 Thread Colin Lord
Isolate raw probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/raw-probe.c | 10 ++ block/raw_bsd.c | 9 + include/block/probe.h | 1 + 4 files changed, 13 insertions(+), 8 deletions

[Qemu-devel] [PATCH v4 09/32] blockdev: Move qcow probe to its own file

2016-07-14 Thread Colin Lord
Isolates qcow probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/qcow-probe.c| 16 block/qcow.c | 31 ++- block/qcow.h | 21

[Qemu-devel] [PATCH v4 04/32] blockdev: Move bochs probe into separate file

2016-07-14 Thread Colin Lord
This puts the bochs probe function into its own separate file as part of the process of modularizing block drivers. Having the probe functions separate from the rest of the driver allows us to probe without having to potentially unnecessarily load the driver. Signed-off-by: Colin Lord Reviewed

[Qemu-devel] [PATCH v4 27/32] blockdev: Separate vhdx probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the vhdx probe from the vhdx driver. The vhdx probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 11/32] blockdev: Move qed probe to its own file

2016-07-14 Thread Colin Lord
Isolate qed probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/qed-probe.c | 18 ++ block/qed.c | 15 +-- include/block/probe.h | 1 + 4 files changed, 21 insertions

[Qemu-devel] [PATCH v4 08/32] blockdev: Move parallels probe to its own file

2016-07-14 Thread Colin Lord
Isolate parallels probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 1 + block/parallels-probe.c | 21 + block/parallels.c | 43 ++- block/parallels.h

[Qemu-devel] [PATCH v4 00/32] Dynamic module loading for block drivers

2016-07-14 Thread Colin Lord
onger in the filename - Fixed formatting of parallels_probe() function header - Enforced consistent naming convention for the probe functions. They now follow the pattern bdrv_format_probe(). Colin Lord (30): blockdev: prepare iSCSI block driver for dynamic loading blockdev: Move bochs

[Qemu-devel] [PATCH v4 06/32] blockdev: Move luks probe to its own file

2016-07-14 Thread Colin Lord
Isolates the luks probe function as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/crypto-probe.c | 23 +++ block/crypto.c| 21 + include/block/probe.h | 2 ++ 4

[Qemu-devel] [PATCH v4 25/32] blockdev: Separate raw probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the raw probe from the raw driver. The raw probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 01/32] blockdev: prepare iSCSI block driver for dynamic loading

2016-07-14 Thread Colin Lord
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts struct out of block/iscsi.c in order to allow the iscsi module to be dynamically loaded. Signed-off-by: Colin Lord Reviewed-by: Fam Zheng --- block/iscsi.c | 36 vl.c | 38

[Qemu-devel] [PATCH v4 10/32] blockdev: Move qcow2 probe to its own file

2016-07-14 Thread Colin Lord
Isolates qcow2 probe as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/qcow2-probe.c | 16 block/qcow2.c | 13 + include/block/probe.h | 1 + 4 files changed, 19 insertions

[Qemu-devel] [PATCH v4 03/32] blockdev: Add dynamic module loading for block drivers

2016-07-14 Thread Colin Lord
odule information is located in a new structure found in module_block.h Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c | 110 ++ include/qemu/module.h | 3 ++ util/module.c

[Qemu-devel] [PATCH v4 20/32] blockdev: Separate dmg probe from its driver

2016-07-14 Thread Colin Lord
Completes the separation of the dmg probe from the dmg driver. The dmg probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block.c

[Qemu-devel] [PATCH v4 02/32] blockdev: Add dynamic generation of module_block.h

2016-07-14 Thread Colin Lord
From: Marc Mari To simplify the addition of new block modules, add a script that generates module_block.h automatically from the modules' source code. This script assumes that the QEMU coding style rules are followed. Signed-off-by: Marc Marí Signed-off-by: Colin Lord Reviewed-by: Max

[Qemu-devel] [PATCH v4 05/32] blockdev: Move cloop probe to its own file

2016-07-14 Thread Colin Lord
Isolates cloop probing function as part of the modularization process. Signed-off-by: Colin Lord Reviewed-by: Max Reitz --- block/Makefile.objs | 2 +- block/cloop-probe.c | 17 + block/cloop.c | 16 +--- include/block/probe.h | 1 + 4 files changed

Re: [Qemu-devel] [Qemu-block] [PATCH 3/3] iotests: Test format probes

2016-07-13 Thread Colin Lord
On 07/12/2016 05:17 PM, John Snow wrote: > > > On 07/11/2016 03:50 PM, Colin Lord wrote: >> Adds a new iotest for testing that the format probing functions work as >> expected. This is done by booting up a vm with a disk image without >> specifying the image format.

[Qemu-devel] [PATCH 3/3] iotests: Test format probes

2016-07-11 Thread Colin Lord
the given format, and one check is done against a raw image. This is to ensure that a probe correctly returns a high score when the format is matched, and does not return a high score when the format should not be matched, as would be the case with raw images. Signed-off-by: Colin Lord --- tests

[Qemu-devel] [PATCH 1/3] iotests: Add dmg format option

2016-07-11 Thread Colin Lord
Adds option to test the dmg format. Signed-off-by: Colin Lord --- tests/qemu-iotests/common | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common index d60ea2c..dc937c7 100644 --- a/tests/qemu-iotests/common +++ b/tests/qemu-iotests

[Qemu-devel] [PATCH 0/3] Add tests for block driver format probes

2016-07-11 Thread Colin Lord
.com/dramborleg/qemu/tree/probe-iotests/tests/qemu-iotests/sample_images Colin Lord (3): iotests: Add dmg format option iotests: Add python functions for using sample images iotests: Test format probes tests/qemu-iotests/158| 53 +++ tests/qem

[Qemu-devel] [PATCH 2/3] iotests: Add python functions for using sample images

2016-07-11 Thread Colin Lord
This adds a python equivalent of the _use_sample_img and _rm_sample_img testing functions. Signed-off-by: Colin Lord --- tests/qemu-iotests/iotests.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 1687c33

Re: [Qemu-devel] [Qemu-block] [PATCH v3 04/32] blockdev: Move bochs probe into separate file

2016-07-07 Thread Colin Lord
On 07/06/2016 04:24 AM, Kevin Wolf wrote: > Am 05.07.2016 um 22:50 hat John Snow geschrieben: >> >> >> On 07/05/2016 11:49 AM, Daniel P. Berrange wrote: >>> On Tue, Jul 05, 2016 at 11:24:04AM -0400, Colin Lord wrote: >>>> This puts the bochs probe func

Re: [Qemu-devel] [PATCH v3 17/32] blockdev: Separate bochs probe from its driver

2016-07-07 Thread Colin Lord
On 07/06/2016 11:59 AM, Max Reitz wrote: > On 05.07.2016 17:24, Colin Lord wrote: >> Modifies the bochs probe to return the format name as well as the >> score as the final step of separating the probe function from the >> driver. This keeps the probe completely inde

Re: [Qemu-devel] [PATCH v3 02/32] blockdev: Add dynamic generation of module_block.h

2016-07-06 Thread Colin Lord
On 07/06/2016 09:17 AM, Max Reitz wrote: > On 05.07.2016 17:24, Colin Lord wrote: >> From: Marc Mari >> >> To simplify the addition of new block modules, add a script that generates >> module_block.h automatically from the modules' source code. >> >> Th

[Qemu-devel] [PATCH v3 32/32] blockdev: Remove bdrv_probe_device field from BlockDriver

2016-07-05 Thread Colin Lord
This commit finalizes the separation of the BlockDriver from its device probing function. Now the accesses to these functions in block.c occur through the protocol_probes array, and each function returns a score and protocol name with which to find the corresponding driver. Signed-off-by: Colin

[Qemu-devel] [PATCH v3 30/32] blockdev: Remove the .bdrv_probe field from BlockDrivers

2016-07-05 Thread Colin Lord
This commit finalizes the separation of the block driver and probe function by removing the .bdrv_probe field from all BlockDrivers. Probing is now accomplished solely by iterating over the array of probe function pointers in the format_probes array. Signed-off-by: Colin Lord --- block.c

[Qemu-devel] [PATCH v3 27/32] blockdev: Separate vhdx probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the vhdx probe from the vhdx driver. The vhdx probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 25/32] blockdev: Separate raw probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the raw probe from the raw driver. The raw probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1 + block

[Qemu-devel] [PATCH v3 29/32] blockdev: Separate vpc probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the vpc probe from the vpc driver. The vpc probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 28/32] blockdev: Separate vmdk probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the vmdk probe from the vmdk driver. The vmdk probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 21/32] blockdev: Separate parallels probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the parallels probe from the parallels driver. The parallels probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c

[Qemu-devel] [PATCH v3 22/32] blockdev: Separate qcow probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the qcow probe from the qcow driver. The qcow probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 23/32] blockdev: Separate qcow2 probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the qcow2 probe from the qcow2 driver. The qcow2 probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 31/32] blockdev: Separate out bdrv_probe_device functions

2016-07-05 Thread Colin Lord
This puts the bdrv_probe_device functions into their own files to facilitate the modularization of the block drivers. Signed-off-by: Colin Lord --- block/Makefile.objs | 1 + block/probe/host_cdrom.c | 40 + block/probe/host_device.c | 30

[Qemu-devel] [PATCH v3 26/32] blockdev: Separate vdi probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the vdi probe from the vdi driver. The vdi probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 24/32] blockdev: Separate qed probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the qed probe from the qed driver. The qed probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 13/32] blockdev: Move vdi probe to its own file

2016-07-05 Thread Colin Lord
Isolates vdi probe as part of the modularization process. Signed-off-by: Colin Lord --- block/Makefile.objs| 2 +- block/probe/vdi.c | 26 + block/vdi.c| 69 ++ include/block/driver/vdi.h | 49

[Qemu-devel] [PATCH v3 17/32] blockdev: Separate bochs probe from its driver

2016-07-05 Thread Colin Lord
allows the score to be correlated to the driver without the probe function needing to be part of the driver. Signed-off-by: Colin Lord --- block.c | 19 +++ block/bochs.c | 1 - block/probe/bochs.c | 25 - include/block/probe.h | 3

[Qemu-devel] [PATCH v3 11/32] blockdev: Move qed probe to its own file

2016-07-05 Thread Colin Lord
Isolate qed probe as part of the modularization process. Signed-off-by: Colin Lord --- block/Makefile.objs | 2 +- block/probe/qed.c | 18 ++ block/qed.c | 15 +-- include/block/probe.h | 1 + 4 files changed, 21 insertions(+), 15 deletions

[Qemu-devel] [PATCH v3 14/32] blockdev: Move vhdx probe to its own file

2016-07-05 Thread Colin Lord
Isolates vhdx probe as part of the modularization process. Signed-off-by: Colin Lord --- block/Makefile.objs | 2 +- block/probe/vhdx.c| 21 + block/vhdx.c | 20 +--- include/block/probe.h | 1 + 4 files changed, 24 insertions(+), 20

[Qemu-devel] [PATCH v3 09/32] blockdev: Move qcow probe to its own file

2016-07-05 Thread Colin Lord
Isolates qcow probe as part of the modularization process. Signed-off-by: Colin Lord --- block/Makefile.objs | 2 +- block/probe/qcow.c | 16 block/qcow.c| 31 ++- include/block/driver/qcow.h | 21

[Qemu-devel] [PATCH v3 19/32] blockdev: Separate luks probe from its driver

2016-07-05 Thread Colin Lord
Completes the separation of the luks probe from the crypto driver. The luks probe now returns the format in addition to the score, allowing correlation of the score and driver without the probe function being part of the driver itself. Signed-off-by: Colin Lord --- block.c | 1

[Qemu-devel] [PATCH v3 15/32] blockdev: Move vmdk probe to its own file

2016-07-05 Thread Colin Lord
Isolates vmdk probe as part of the modularization process. Signed-off-by: Colin Lord --- block/Makefile.objs | 2 +- block/probe/vmdk.c | 60 + block/vmdk.c| 60 ++--- include

  1   2   >