Re: [PATCH V3] arm/kvm: add support for MTE

2024-09-25 Thread Cornelia Huck
$AUTHOR: reworked original patch by doing X to avoid problem Y] > > Signed-off-by: Cornelia Huck > Signed-off-by: Ganapatrao Kulkarni Also, the S-o-b chain is a bit confusing that way, because you are listed as author of the patch, but I'm in the chain in front of you --

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-19 Thread Cornelia Huck
On Thu, Sep 19 2024, Ganapatrao Kulkarni wrote: > I have modified as below diff to keep TCG if loop as it is and adding if > for KVM case to clear/mask the MTE bits if MTE in KVM mode is not > enabled by user command(if no mte=on). > > Is below diff makes sense? > > diff --git a/target/arm/cpu

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-17 Thread Cornelia Huck
guest even if the board hadn't > enabled MTE by wiring up the tag RAM. This meant that if the guest > then tried to use MTE QEMU would segfault accessing the > non-existent tag RAM. > > Signed-off-by: Cornelia Huck > Signed-off-by: Ganapatrao Kulkarni > --- > Changes sin

Re: [PATCH v1 00/14] s390x: virtio-mem support

2024-09-11 Thread Cornelia Huck
On Wed, Sep 11 2024, "Michael S. Tsirkin" wrote: >> > >> > I'd rather have it in a shared and bigger repo than in your personal >> > gitlab one. Maybe there's a space somewhere in QEMU or the Virtio team's >> > repos that would be a good fit if the kernel's docu isn't the right place? >> >> At

Re: [RFC PATCH V2 1/5] include: Add macro definitions needed for interrupt controller kvm emulation

2024-09-10 Thread Cornelia Huck
On Tue, Sep 10 2024, Xianglai Li wrote: > Add macro definitions needed for interrupt controller kvm emulation. > > Signed-off-by: Xianglai Li > --- > Cc: Paolo Bonzini > Cc: Song Gao > Cc: Jiaxun Yang > Cc: Huacai Chen > Cc: "Michael S. Tsirki

Re: [PATCH] hw/i386: define _AS_LATEST() macros for machine types

2024-09-06 Thread Cornelia Huck
> Signed-off-by: Daniel P. Berrangé > --- > hw/i386/pc_piix.c| 11 +-- > hw/i386/pc_q35.c | 11 ++- > include/hw/i386/pc.h | 4 +++- > 3 files changed, 14 insertions(+), 12 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH for-9.2] hw: add compat machines for 9.2

2024-08-16 Thread Cornelia Huck
On Fri, Aug 16 2024, Daniel P. Berrangé wrote: > On Fri, Aug 16, 2024 at 12:37:23PM +0200, Cornelia Huck wrote: >> Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. >> >> Signed-off-by: Cornelia Huck >> --- >> hw/arm/virt.c |

[PATCH for-9.2] hw: add compat machines for 9.2

2024-08-16 Thread Cornelia Huck
Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 15 --- hw/i386/pc_q35.c | 13

Re: [PATCH] arm/kvm: add support for MTE

2024-08-02 Thread Cornelia Huck
t;> enabled MTE by wiring up the tag RAM. This meant that if the guest >>> then tried to use MTE QEMU would segfault accessing the >>> non-existent tag RAM. >>> >>> Signed-off-by: Cornelia Huck >>> Signed-off-by: Ganapatrao Kulkarni >>>

Re: [PATCH v3 2/5] target/arm/kvm: Fix PMU feature bit early

2024-07-19 Thread Cornelia Huck
On Fri, Jul 19 2024, Akihiko Odaki wrote: > On 2024/07/18 21:07, Peter Maydell wrote: >> On Tue, 16 Jul 2024 at 13:50, Akihiko Odaki wrote: >>> >>> kvm_arm_get_host_cpu_features() used to add the PMU feature >>> unconditionally, and kvm_arch_init_vcpu() removed it when it is actually >>> not ava

Re: [PATCH v2] scripts/checkpatch: more checks on files imported from Linux

2024-07-19 Thread Cornelia Huck
> 1 file changed, 24 insertions(+) Reviewed-by: Cornelia Huck

Re: [PATCH] scripts/checkpatch: emit a warning if an imported file is touched

2024-07-17 Thread Cornelia Huck
On Wed, Jul 17 2024, Stefano Garzarella wrote: > If a file imported from Linux is touched, emit a warning and suggest > using scripts/update-linux-headers.sh > > Signed-off-by: Stefano Garzarella > --- > scripts/checkpatch.pl | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(

Re: [RFC 0/4] Added Interrupt controller emulation for loongarch kvm

2024-07-17 Thread Cornelia Huck
the branch is: interrupt > > the qemu: > https://github.com/lixianglai/qemu > the branch is: interrupt > > Please note that the code above is regularly updated based on community > reviews. > > Cc: Paolo Bonzini > Cc: Song Gao > Cc: Huacai Chen > Cc: Jiaxun Yang

Re: [PATCH] arm/kvm: add support for MTE

2024-07-10 Thread Cornelia Huck
we didn't configure tag memory, but the rest of the behaviour stays the same? > > Signed-off-by: Cornelia Huck > Signed-off-by: Ganapatrao Kulkarni (...) > +void kvm_arm_enable_mte(Object *cpuobj, Error **errp) > +{ > +static bool tried_to_enable; > +

Re: [PATCH 0/4] update-linux-headers: prepare for updating to 6.9+ and for SNP patches

2024-06-04 Thread Cornelia Huck
ude/standard-headers/linux/kvm_para.h > rename include/standard-headers/{linux => misc}/pvpanic.h (100%) > create mode 100644 linux-headers/asm-x86/kvm_para.h > create mode 100644 linux-headers/linux/kvm_para.h With the hash added to the headers update, Reviewed-by: Cornelia Huck for the series.

Re: [PATCH 3/4] linux-headers: Update to current kvm/next

2024-06-03 Thread Cornelia Huck
On Mon, Jun 03 2024, Paolo Bonzini wrote: > On Mon, Jun 3, 2024 at 5:58 PM Cornelia Huck wrote: >> Hm, I'm not sure updating to kvm/next is a good idea ("current kvm/next" >> does not mean anything without a commit hash anyway.) I think we should >> only

Re: [PATCH 3/4] linux-headers: Update to current kvm/next

2024-06-03 Thread Cornelia Huck
On Mon, Jun 03 2024, Paolo Bonzini wrote: > From: Pankaj Gupta > > Also brings in an linux-headers/linux/vhost.h fix from v6.9-rc4. > > Co-developed-by: Michael Roth > Signed-off-by: Michael Roth > Signed-off-by: Pankaj Gupta > Message-ID: <20240530111643.1091816-3-pankaj.gu...@amd.com> > Sig

Re: [PATCH 0/2] ppc: spapr: Nested kvm guest migration fixes

2024-06-03 Thread Cornelia Huck
On Mon, Jun 03 2024, Shivaprasad G Bhat wrote: > The series fixes the issues exposed by the kvm-unit-tests[1] > sprs-migration test. > > The sprs DEXCR and HASKKEYR are not registered with one-reg IDs > without which the Qemu is not setting them to their 'previous' > value during guest migreation

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Cornelia Huck
On Mon, May 27 2024, Thomas Huth wrote: > On 27/05/2024 17.04, Cornelia Huck wrote: >> On Mon, May 27 2024, Thomas Huth wrote: >> >>> We are reusing the same temporary directory for installing the headers >>> of all targets, so there could be stale files here w

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Cornelia Huck
On Mon, May 27 2024, Thomas Huth wrote: > We are reusing the same temporary directory for installing the headers > of all targets, so there could be stale files here when switching from > one target to another. Make sure to delete the folder before installing > a new set of target headers into it

Re: [PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-27 Thread Cornelia Huck
"$output/standard-headers/asm-x86" > +"$output/include/standard-headers/asm-x86" > fi > if [ $arch = riscv ]; then > cp "$hdrdir/include/asm/ptrace.h" "$output/linux-headers/asm-riscv/" Reviewed-by: Cornelia Huck

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-16 Thread Cornelia Huck
On Wed, Apr 10 2024, Thomas Huth wrote: > On 09/04/2024 09.47, Shaoqin Huang wrote: >> Hi Thmoas, >> >> On 4/9/24 13:33, Thomas Huth wrote: +    assert_has_feature(qts, "host", "kvm-pmu-filter"); >>> >>> So you assert here that the feature is available ... >>>   assert_has_

Re: [PATCH] linux-headers: change the annotation of VFIO_IOMMU_SPAPR_REGISTER_MEMORY in vfio.h

2024-04-12 Thread Cornelia Huck
On Thu, Apr 11 2024, JianChunfu wrote: > The ioctl(VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA) won't be called > in SPAPR machine, which is replaced by VFIO_IOMMU_SPAPR_TCE_CREATE/ > VFIO_IOMMU_SPAPR_TCE_REMOVE, so change the description. > > Signed-off-by: JianChunfu > --- > linux-headers/linux/v

Re: [PATCH] Revert "hw/virtio: Add support for VDPA network simulation devices"

2024-04-08 Thread Cornelia Huck
et.rst| 121 - > 9 files changed, 3 insertions(+), 399 deletions(-) > delete mode 100644 docs/system/devices/vdpa-net.rst Acked-by: Cornelia Huck We should get rid of this before we release a version with non-upstream header code.

Re: [PATCH for-9.1 v5 1/3] hw: Add compat machines for 9.1

2024-03-25 Thread Cornelia Huck
On Mon, Mar 25 2024, Paolo Bonzini wrote: > Add 9.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. > > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Harsh Prateek Bora > Cc: Gavin Shan > Signed-off-by: Paolo Bonzini > --- > include/hw/boards.h| 3

Re: [PATCH 09/10] hw/pci: Set write-mask bits for PCIE Link-Control-2 register

2024-03-25 Thread Cornelia Huck
On Mon, Mar 25 2024, Cédric Le Goater wrote: > On 3/21/24 11:04, Saif Abrar wrote: >> PHB updates the register PCIE Link-Control-2. >> Set the write-mask bits for TLS, ENTER_COMP, TX_MARGIN, >> HASD, MOD_COMP, COMP_SOS and COMP_P_DE. > > > You should resend this patch independently of the PowerNV

Re: [PATCH] hw/arm/virt: Consolidate valid CPU types

2024-01-12 Thread Cornelia Huck
Signed-off-by: Gavin Shan > --- > hw/arm/virt.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v4 4/4] hw/misc/pvpanic: add support for normal shutdowns

2024-01-12 Thread Cornelia Huck
: Thomas Weißschuh > --- > docs/specs/pvpanic.rst| 2 ++ > hw/misc/pvpanic.c | 5 + > include/hw/misc/pvpanic.h | 3 ++- > 3 files changed, 9 insertions(+), 1 deletion(-) Not deeply involved with this, but looks reasonable to me. Acked-by: Cornelia Huck

Re: [PATCH v4 3/4] tests/qtest/pvpanic: use centralized definition of supported events

2024-01-12 Thread Cornelia Huck
| 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v4 2/4] hw/misc/pvpanic: centralize definition of supported events

2024-01-12 Thread Cornelia Huck
sa.c | 2 +- > hw/misc/pvpanic-pci.c | 2 +- > hw/misc/pvpanic.c | 2 +- > include/hw/misc/pvpanic.h | 1 + > 4 files changed, 4 insertions(+), 3 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v4 1/4] linux-headers: drop pvpanic.h

2024-01-12 Thread Cornelia Huck
| 3 +++ > include/standard-headers/linux/pvpanic.h | 9 - > scripts/update-linux-headers.sh | 3 +-- > 6 files changed, 4 insertions(+), 14 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH v2 3/3] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Cornelia Huck
On Wed, Nov 29 2023, Thomas Weißschuh wrote: > On 2023-11-29 09:23:46+0100, Cornelia Huck wrote: >> On Tue, Nov 28 2023, Thomas Weißschuh wrote: >> > diff --git a/include/standard-headers/linux/pvpanic.h >> > b/include/standard-headers/linux/pvpanic.h >> &

Re: [PATCH v2 3/3] hw/misc/pvpanic: add support for normal shutdowns

2023-11-29 Thread Cornelia Huck
On Tue, Nov 28 2023, Thomas Weißschuh wrote: > Shutdown requests are normally hardware dependent. > By extending pvpanic to also handle shutdown requests, guests can > submit such requests with an easily implementable and cross-platform > mechanism. > > Signed-off-by: Thomas Weißschuh > --- > d

Re: [PATCH for-8.2] target/arm: Disable SME if SVE is disabled

2023-11-28 Thread Cornelia Huck
On Mon, Nov 27 2023, Peter Maydell wrote: > There is no architectural requirement that SME implies SVE, but > our implementation currently assumes it. (FEAT_SME_FA64 does > imply SVE.) So if you try to run a CPU with eg "-cpu max,sve=off" > you quickly run into an assert when the guest tries to w

[PATCH for-9.0] hw: Add compat machines for 9.0

2023-11-20 Thread Cornelia Huck
Add 9.0 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 17 ++--- hw/i386/pc_q35.c | 13

Re: [virtio] Invitation to comment on Virtual I/O Device (VIRTIO) Version 1.3 - ends December 8th

2023-11-13 Thread Cornelia Huck
It seems that the original mail did not make it to some of the mailing lists it was intended to go to, possibly due to the html part of the original mail. Therefore, I'm trying again, this time with plain text only. Apologies in advance for any duplicates. On Wed, Nov 08 2023, Paul Knight wrote:

Re: [PATCH v1 1/9] linux-headers: Add KVM headers for loongarch

2023-11-08 Thread Cornelia Huck
On Wed, Nov 08 2023, xianglai li wrote: > From: zhaotianrui > > Update linux KVM headers about LoongArch KVM form linux > kernel. Mainly contains some KVM structures and macro > defines such as LoongArch KVM registers number, LoongArch > fpu structure, exit reason of LoongArch IOCSR, etc. > > Si

Re: [PATCH v2 3/3] arm/kvm: convert to read_sys_reg64

2023-10-17 Thread Cornelia Huck
On Tue, Oct 17 2023, Peter Maydell wrote: > On Tue, 10 Oct 2023 at 15:25, Cornelia Huck wrote: >> >> We can use read_sys_reg64 to get the SVE_VLS register instead of >> calling GET_ONE_REG directly. >> >> Suggested-by: Gavin Shan >> Signed-off-by: Corne

[PATCH v2 2/3] arm/kvm: convert to kvm_get_one_reg

2023-10-10 Thread Cornelia Huck
We can neaten the code by switching the callers that work on a CPUstate to the kvm_get_one_reg function. Reviewed-by: Gavin Shan Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 15 +++- target/arm/kvm64.c | 57 -- 2 files changed, 18

[PATCH v2 1/3] arm/kvm: convert to kvm_set_one_reg

2023-10-10 Thread Cornelia Huck
We can neaten the code by switching to the kvm_set_one_reg function. Reviewed-by: Gavin Shan Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 13 +++-- target/arm/kvm64.c | 66 +- 2 files changed, 21 insertions(+), 58 deletions(-) diff

[PATCH v2 3/3] arm/kvm: convert to read_sys_reg64

2023-10-10 Thread Cornelia Huck
We can use read_sys_reg64 to get the SVE_VLS register instead of calling GET_ONE_REG directly. Suggested-by: Gavin Shan Signed-off-by: Cornelia Huck --- target/arm/kvm64.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/arm/kvm64.c b/target/arm/kvm64.c index

[PATCH v2 0/3] arm/kvm: use kvm_{get,set}_one_reg

2023-10-10 Thread Cornelia Huck
oth in 'Odd fixes' anyway), I left them alone. Survives some testing on a Mt. Snow. Cornelia Huck (3): arm/kvm: convert to kvm_set_one_reg arm/kvm: convert to kvm_get_one_reg arm/kvm: convert to read_sys_reg64 target/arm/kvm.c | 28 +++--- target/arm/

Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-10-10 Thread Cornelia Huck
[spooky season is coming up, so time for some thread necromancy!] On Thu, Jul 27 2023, Cornelia Huck wrote: > On Tue, Jul 25 2023, Gavin Shan wrote: > >> On 7/24/23 18:48, Cornelia Huck wrote: >>> On Mon, Jul 24 2023, Gavin Shan wrote: >>>> >>>> On

Re: MAINTAINERS still leaves more files uncovered than I'd like

2023-09-29 Thread Cornelia Huck
On Fri, Sep 29 2023, Thomas Huth wrote: > On 29/09/2023 14.05, Cornelia Huck wrote: >> On Fri, Sep 29 2023, Markus Armbruster wrote: >> >>> Where are the remaining unmaintained files now? Top-scoring >>> directories, files in sub-directories not counted: &

[PATCH] MAINTAINERS: add standard-headers to Hosts/LINUX

2023-09-29 Thread Cornelia Huck
The files in there are updated via update-linux-headers.sh. Signed-off-by: Cornelia Huck --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 355b1960ce46..95df1f3d8884 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -556,6 +556,7 @@ M: Cornelia Huck

Re: MAINTAINERS still leaves more files uncovered than I'd like

2023-09-29 Thread Cornelia Huck
On Fri, Sep 29 2023, Markus Armbruster wrote: > Where are the remaining unmaintained files now? Top-scoring > directories, files in sub-directories not counted: > > $ sed 's,/[^/]*$,/,;s,^[^/]*$,./,' unmaintained-files | sort | uniq -c | > sort -nr > > # directory (...) > 40 in

Re: [PATCH for-8.2] hw/s390x/s390-virtio-ccw: Remove superfluous code to set the NIC model

2023-08-04 Thread Cornelia Huck
odel() - and this in turn calls qemu_find_nic_model() > which contains the same check for nd->model being NULL again. So we > can remove this from the calling site now. > > Signed-off-by: Thomas Huth > --- > hw/s390x/s390-virtio-ccw.c | 4 > 1 file changed, 4 deletions(-) Reviewed-by: Cornelia Huck

Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-07-27 Thread Cornelia Huck
On Tue, Jul 25 2023, Gavin Shan wrote: > On 7/24/23 18:48, Cornelia Huck wrote: >> On Mon, Jul 24 2023, Gavin Shan wrote: >>> >>> On 7/18/23 21:14, Cornelia Huck wrote: >>>> We can neaten the code by switching the callers that work on a >&g

Re: [PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-07-24 Thread Cornelia Huck
On Mon, Jul 24 2023, Gavin Shan wrote: > Hi Connie, > > On 7/18/23 21:14, Cornelia Huck wrote: >> We can neaten the code by switching the callers that work on a >> CPUstate to the kvm_get_one_reg function. >> >> Signed-off-by: Cornelia Huck &g

Re: [PATCH for-8.2 1/2] arm/kvm: convert to kvm_set_one_reg

2023-07-24 Thread Cornelia Huck
On Mon, Jul 24 2023, Gavin Shan wrote: > Hi Connie, > > On 7/18/23 21:14, Cornelia Huck wrote: >> We can neaten the code by switching to the kvm_set_one_reg function. >> >> Signed-off-by: Cornelia Huck >> --- >> target/arm/kvm.c | 13

[PATCH] hw: Add compat machines for 8.2

2023-07-18 Thread Cornelia Huck
Add 8.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 16 +--- hw/i386/pc_q35.c | 14

[PATCH for-8.2 1/2] arm/kvm: convert to kvm_set_one_reg

2023-07-18 Thread Cornelia Huck
We can neaten the code by switching to the kvm_set_one_reg function. Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 13 +++-- target/arm/kvm64.c | 66 +- 2 files changed, 21 insertions(+), 58 deletions(-) diff --git a/target/arm/kvm.c b

[PATCH for-8.2 2/2] arm/kvm: convert to kvm_get_one_reg

2023-07-18 Thread Cornelia Huck
We can neaten the code by switching the callers that work on a CPUstate to the kvm_get_one_reg function. Signed-off-by: Cornelia Huck --- target/arm/kvm.c | 15 +++- target/arm/kvm64.c | 57 -- 2 files changed, 18 insertions(+), 54 deletions

[PATCH for-8.2 0/2] arm/kvm: use kvm_{get,set}_one_reg

2023-07-18 Thread Cornelia Huck
conversions in the target/arm code. target/mips and target/ppc also have some potential for conversions, but as I cannot test either (and they are both in 'Odd fixes' anyway), I left them alone. Survives some testing on a Mt. Snow. Cornelia Huck (2): arm/kvm: convert to kvm_set_one_reg

Re: [PATCH 3/3] hw/arm/virt: Support host CPU type only when KVM or HVF is configured

2023-07-13 Thread Cornelia Huck
On Thu, Jul 13 2023, Gavin Shan wrote: > The CPU type 'host-arm-cpu' class won't be registered until KVM or > HVF is configured in target/arm/cpu64.c. Support the corresponding > CPU type only when KVM or HVF is configured. > > Signed-off-by: Gavin Shan > --- > hw/arm/virt.c | 2 ++ > 1 file ch

RE: [RFC PATCH v4 02/24] Update linux-header per VFIO device cdev v14

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, "Duan, Zhenzhong" wrote: >>-Original Message- >>From: Cornelia Huck >>Sent: Wednesday, July 12, 2023 3:49 PM >>Subject: Re: [RFC PATCH v4 02/24] Update linux-header per VFIO device cdev >>v14 >> >>On Wed, Jul

Re: [RFC PATCH v4 02/24] Update linux-header per VFIO device cdev v14

2023-07-12 Thread Cornelia Huck
On Wed, Jul 12 2023, Zhenzhong Duan wrote: > Signed-off-by: Zhenzhong Duan > --- > linux-headers/linux/iommufd.h | 347 ++ > linux-headers/linux/kvm.h | 13 +- > linux-headers/linux/vfio.h| 142 +- > 3 files changed, 498 insertions(+), 4 dele

Re: [PATCH 1/1] linux-headers: update to v6.5-rc1

2023-07-10 Thread Cornelia Huck
/mman.h| 14 ++ > linux-headers/linux/psp-sev.h | 7 + > linux-headers/linux/userfaultfd.h | 17 ++- > linux-headers/linux/vfio.h| 27 > linux-headers/linux/vhost.h | 31 > 32 files changed, 423 insertions(+), 154 deletions(-) Acked-by: Cornelia Huck

Re: [PATCH v1 4/5] arm/kvm: add skeleton implementation for userspace SMCCC call handling

2023-07-04 Thread Cornelia Huck
On Mon, Jun 26 2023, Shaoqin Huang wrote: > The SMCCC call filtering provide the ability to forward the SMCCC call > to userspace, so we provide a new option `user-smccc` to enable handling > SMCCC call in userspace, the default value is off. > > And add the skeleton implementation for userspace

Re: [PATCH v1 2/5] linux-headers: Import arm-smccc.h from Linux v6.4-rc7

2023-07-04 Thread Cornelia Huck
On Mon, Jun 26 2023, Shaoqin Huang wrote: > Copy in the SMCCC definitions from the kernel, which will be used to > implement SMCCC handling in userspace. > > Signed-off-by: Shaoqin Huang > --- > linux-headers/linux/arm-smccc.h | 240 > 1 file changed, 240 insert

Re: [PATCH v4 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support placeholder

2023-06-30 Thread Cornelia Huck
On Fri, Jun 30 2023, Daniel Henrique Barboza wrote: > On 6/21/23 11:54, Yong-Xuan Wang wrote: >> Sync-up Linux header to get latest KVM RISC-V headers having AIA support. >> >> Note: This is a placeholder commit and could be replaced when all referenced >> Linux patchsets are mainlined. >> >>

Re: [PATCH 1/2] linux-headers: Update with vfio_ap IRQ index mapping

2023-05-31 Thread Cornelia Huck
On Wed, May 31 2023, Anthony Krowiak wrote: > On 5/30/23 8:56 PM, Matthew Rosato wrote: >> On 5/30/23 6:55 PM, Tony Krowiak wrote: >>> Signed-off-by: Tony Krowiak >>> --- >>> linux-headers/linux/vfio.h | 9 + >>> 1 file changed, 9 insertions(+) >> >> Worth nothing here that linux-hea

Re: [PTACH v2 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support

2023-05-23 Thread Cornelia Huck
On Tue, May 23 2023, Yong-Xuan Wang wrote: > On Mon, May 8, 2023 at 3:39 PM Cornelia Huck wrote: >> >> On Fri, May 05 2023, Alex Williamson wrote: >> >> > On Fri, 5 May 2023 11:39:36 + >> > Yong-Xuan Wang wrote: >> > >> >> U

Re: [PATCH v7 0/1] arm: enable MTE for QEMU + kvm

2023-05-22 Thread Cornelia Huck
On Fri, Apr 28 2023, Cornelia Huck wrote: > Another open problem is mte vs mte3: tcg emulates mte3, kvm gives the guest > whatever the host supports. Without migration support, this is not too much > of a problem yet, but for compatibility handling, we'll need a way to keep >

Re: [PULL 04/29] arm/kvm: add support for MTE

2023-05-22 Thread Cornelia Huck
On Fri, May 19 2023, Peter Maydell wrote: > On Fri, 19 May 2023 at 14:31, Peter Maydell wrote: >> >> On Fri, 19 May 2023 at 13:55, Alex Bennée wrote: >> > >> > >> > Peter Maydell writes: >> > >> > > From: Cornelia Huck >> &

Re: [PATCH 1/4] virtio-dmabuf: introduce virtio-dmabuf

2023-05-08 Thread Cornelia Huck
On Wed, May 03 2023, Albert Esteve wrote: > This API manages objects (in this iteration, > dmabuf fds) that can be shared along different > virtio devices. > > The API allows the different devices to add, > remove and/or retrieve the objects by simply > invoking the public functions that reside i

Re: css_clear_io_interrupt() error handling

2023-05-08 Thread Cornelia Huck
On Mon, May 08 2023, Markus Armbruster wrote: > css_clear_io_interrupt() aborts on unexpected ioctl() errors, and I > wonder whether that's appropriate. Let's have a closer look: > > static void css_clear_io_interrupt(uint16_t subchannel_id, >uint16_t

Re: [PTACH v2 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support

2023-05-08 Thread Cornelia Huck
On Fri, May 05 2023, Alex Williamson wrote: > On Fri, 5 May 2023 11:39:36 + > Yong-Xuan Wang wrote: > >> Update the linux headers to get the latest KVM RISC-V headers with AIA >> support >> by the scripts/update-linux-headers.sh. >> The linux headers is comes from the riscv_aia_v1 branch a

Re: [PATCH v7 1/1] arm/kvm: add support for MTE

2023-05-04 Thread Cornelia Huck
On Tue, May 02 2023, Richard Henderson wrote: > On 5/2/23 10:03, Cornelia Huck wrote: >> Has anyone been able to access a real system with MTE? (All the systems >> where I had hoped that MTE would be available didn't have MTE in the end >> so far, so I'd be int

Re: [PATCH v7 1/1] arm/kvm: add support for MTE

2023-05-02 Thread Cornelia Huck
On Mon, May 01 2023, Richard Henderson wrote: > On 4/28/23 18:50, Juan Quintela wrote: >> Pardon my ignorance here, but to try to help with migration. How is >> this mte tag stored? >> - 1 array of 8bits per page of memory >> - 1 array of 64bits per page of memory >> - whatever >> >> Lets asume

[PATCH v7 1/1] arm/kvm: add support for MTE

2023-04-28 Thread Cornelia Huck
ay off with KVM unless requested explicitly. Signed-off-by: Cornelia Huck --- hw/arm/virt.c| 69 +--- target/arm/cpu.c | 9 +++--- target/arm/cpu.h | 4 +++ target/arm/kvm.c | 35 ++ target/arm/kvm64.c | 5 targe

[PATCH v7 0/1] arm: enable MTE for QEMU + kvm

2023-04-28 Thread Cornelia Huck
teresting in general.) In any case, I think we'll need a way to inform kvm of it. Tested with kvm selftests on FVP (as I still don't have any hardware with MTE...) and some make check(-tcg) incantations. Hopefully, I haven't (re)- introduced too many issues. Cornelia Huck (1): arm/

Re: [PATCH 1/6] update-linux-headers: sync-up header with Linux for KVM AIA support

2023-04-24 Thread Cornelia Huck
On Mon, Apr 24 2023, Thomas Huth wrote: > On 24/04/2023 11.07, Yong-Xuan Wang wrote: >> Sync-up Linux header to get latest KVM RISC-V headers having AIA support. >> >> Signed-off-by: Yong-Xuan Wang >> Reviewed-by: Jim Shu >> --- >> linux-headers/linux/kvm.h | 2 ++ >> target/riscv/kvm_risc

Re: [PATCH] kvm: Merge kvm_check_extension() and kvm_vm_check_extension()

2023-04-24 Thread Cornelia Huck
s the returned value, and ensures that SVM is actually > supported. Since QEMU follows the check with kvm_vm_enable_cap(), this > patch should only provide better error reporting. > > [1] > https://www.kernel.org/doc/html/latest/virt/kvm/api.html#kvm-check-extension > [2] https://l

Re: [PATCH RFC v1 01/10] linux-headers: Add KVM headers for loongarch

2023-04-20 Thread Cornelia Huck
On Thu, Apr 20 2023, Tianrui Zhao wrote: > Add asm-loongarch/kvm.h for loongarch KVM, and update > the linux/kvm.h about loongarch part. The structures in > the header are used as kvm_ioctl arguments. Just a procedural note: It's probably best to explicitly mark this as a placeholder patch until

Re: [PATCH 2/2] Add missing Linux kernel headers.

2023-04-05 Thread Cornelia Huck
On Wed, Apr 05 2023, David Turner wrote: > On Wed, Apr 5, 2023 at 3:06 PM Cornelia Huck wrote: > >> On Wed, Apr 05 2023, "David 'Digit' Turner" wrote: >> > The script has then been run against the official >> > 6.2.8 kernel source tree (current

Re: [PATCH 2/2] Add missing Linux kernel headers.

2023-04-05 Thread Cornelia Huck
On Wed, Apr 05 2023, "David 'Digit' Turner" wrote: > Add , used by hw/display/virtio-gpu-udmabuf.c > Add , used by qga/commands-posix.c > Add used by kvm-all.c, which requires > the _BITUL() macro definition to be available. > > Without these, QEMU will not compile on Debian 10 systems. Hm, I w

Re: [PATCH v2] virtio: refresh vring region cache after updating a virtqueue size

2023-03-27 Thread Cornelia Huck
+ > hw/virtio/virtio-pci.c | 1 + > hw/virtio/virtio.c | 2 +- > include/hw/virtio/virtio.h | 1 + > 5 files changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Cornelia Huck We can always do any ccw reshuffling on top.

Re: [PATCH v2] virtio: refresh vring region cache after updating a virtqueue size

2023-03-27 Thread Cornelia Huck
On Wed, Mar 22 2023, Halil Pasic wrote: > On Wed, 22 Mar 2023 10:52:31 +0100 > Cornelia Huck wrote: > [..] >> > >> > diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c >> > index e33e5207ab..f44de1a8c1 100644 >> > --- a/hw/s390x/

Re: [PATCH v2] virtio: refresh vring region cache after updating a virtqueue size

2023-03-27 Thread Cornelia Huck
On Fri, Mar 24 2023, Halil Pasic wrote: > On Wed, 22 Mar 2023 18:24:33 +0100 > Halil Pasic wrote: > >> > > --- a/hw/s390x/virtio-ccw.c >> > > +++ b/hw/s390x/virtio-ccw.c >> > > @@ -237,6 +237,7 @@ static int virtio_ccw_set_vqs(SubchDev *sch, >> > > VqInfoBlock *info, >> > > ret

Re: [PATCH v2] virtio: refresh vring region cache after updating a virtqueue size

2023-03-22 Thread Cornelia Huck
On Fri, Mar 17 2023, Carlos López wrote: > When a virtqueue size is changed by the guest via > virtio_queue_set_num(), its region cache is not automatically updated. > If the size was increased, this could lead to accessing the cache out > of bounds. For example, in vring_get_used_event(): > >

Re: [PATCH for-8.0] docs/system/arm/cpu-features.rst: Fix formatting

2023-03-21 Thread Cornelia Huck
On Tue, Mar 21 2023, Peter Maydell wrote: > On Thu, 16 Mar 2023 at 11:41, Peter Maydell wrote: >> >> On Thu, 16 Mar 2023 at 11:11, Cornelia Huck wrote: >> > >> > On Thu, Mar 16 2023, Peter Maydell wrote: >> > >> > > The markup for the

Re: [PATCH for-8.0] docs/system/arm/cpu-features.rst: Fix formatting

2023-03-16 Thread Cornelia Huck
On Thu, Mar 16 2023, Peter Maydell wrote: > The markup for the Arm CPU feature documentation is incorrect, > and results in the HTML not rendering correctly -- the first > line of each description is rendered in boldface as if it > were part of the option name. > > Reformat to match the styling u

Re: [PATCH] virtio: refresh vring region cache after updating a virtqueue size

2023-03-15 Thread Cornelia Huck
On Mon, Mar 13 2023, Carlos López wrote: > On 9/3/23 11:43, Cornelia Huck wrote: >> On Thu, Mar 02 2023, Carlos López wrote: >>> Fix this by calling virtio_queue_update_rings() after >>> virtio_queue_set_num() if we are not already calling >>> virtio_queue_

[PATCH for-8.1] hw: Add compat machines for 8.1

2023-03-14 Thread Cornelia Huck
Add 8.1 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 16 +--- hw/i386/pc_q35.c | 14

Re: [PATCH] virtio: refresh vring region cache after updating a virtqueue size

2023-03-09 Thread Cornelia Huck
On Thu, Mar 02 2023, Carlos López wrote: > When a virtqueue size is changed by the guest via > virtio_queue_set_num(), its region cache is not automatically updated. > If the size was increased, this could lead to accessing the cache out > of bounds. For example, in vring_get_used_event(): > >

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-07 Thread Cornelia Huck
On Thu, Mar 02 2023, Peter Maydell wrote: > On Thu, 2 Mar 2023 at 14:29, Cornelia Huck wrote: >> >> On Thu, Mar 02 2023, Peter Maydell wrote: >> > I think having MTE in the specific case of KVM behave differently >> > to how we've done all these existing

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-03 Thread Cornelia Huck
On Thu, Mar 02 2023, Peter Maydell wrote: > On Thu, 2 Mar 2023 at 14:29, Cornelia Huck wrote: >> >> On Thu, Mar 02 2023, Peter Maydell wrote: >> > I think having MTE in the specific case of KVM behave differently >> > to how we've done all these existing

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-03 Thread Cornelia Huck
On Fri, Mar 03 2023, Peter Maydell wrote: > On Tue, 28 Feb 2023 at 15:02, Cornelia Huck wrote: >> >> Introduce a new cpu feature flag to control MTE support. To preserve >> backwards compatibility for tcg, MTE will continue to be enabled as >> long as tag memory has

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-02 Thread Cornelia Huck
On Thu, Mar 02 2023, Peter Maydell wrote: > On Wed, 1 Mar 2023 at 14:15, Cornelia Huck wrote: >> >> On Wed, Mar 01 2023, Andrea Bolognani wrote: >> >> > On Wed, Mar 01, 2023 at 11:17:40AM +0100, Cornelia Huck wrote: >> >> On Tue, Feb 28 2023, Andre

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-02 Thread Cornelia Huck
On Wed, Mar 01 2023, Andrea Bolognani wrote: > On Wed, Mar 01, 2023 at 03:15:17PM +0100, Cornelia Huck wrote: >> On Wed, Mar 01 2023, Andrea Bolognani wrote: >> > I'm actually a bit confused. The documentation for the mte property >> > of the virt machine type s

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-01 Thread Cornelia Huck
On Wed, Mar 01 2023, Andrea Bolognani wrote: > On Wed, Mar 01, 2023 at 11:17:40AM +0100, Cornelia Huck wrote: >> On Tue, Feb 28 2023, Andrea Bolognani wrote: >> > On Tue, Feb 28, 2023 at 04:02:15PM +0100, Cornelia Huck wrote: >> >> +MTE CPU Property >> >

Re: [PATCH v6 1/2] arm/kvm: add support for MTE

2023-03-01 Thread Cornelia Huck
On Tue, Feb 28 2023, Andrea Bolognani wrote: > On Tue, Feb 28, 2023 at 04:02:15PM +0100, Cornelia Huck wrote: >> Introduce a new cpu feature flag to control MTE support. To preserve >> backwards compatibility for tcg, MTE will continue to be enabled as >> long as tag mem

[PATCH v6 2/2] qtests/arm: add some mte tests

2023-02-28 Thread Cornelia Huck
With TCG, verify the interaction of the 'mte' cpu feature with virt machine tag memory. With KVM, only verify the existence of the cpu feature, as we cannot probe or enable the feature. Acked-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Cornelia Huck --- tests

[PATCH v6 0/2] arm: enable MTE for QEMU + kvm

2023-02-28 Thread Cornelia Huck
Another respin of my kvm mte series; again, tested via check + check-tcg and on FVP. Changes v5->v6: - "arm/virt: don't try to spell out the accelerator" has been merged - some more reordering of the enable_mte logic - added more explanations - rebase to current master Cornel

[PATCH v6 1/2] arm/kvm: add support for MTE

2023-02-28 Thread Cornelia Huck
, MTE will stay off with KVM unless requested explicitly. Signed-off-by: Cornelia Huck --- docs/system/arm/cpu-features.rst | 21 ++ hw/arm/virt.c| 2 +- target/arm/cpu.c | 18 ++--- target/arm/cpu.h | 1 + target/arm/cpu64.c

Re: [RFC PATCH 1/5] linux-headers: [kvm, arm64] add the necessary definitions to match host kernel

2023-02-27 Thread Cornelia Huck
On Mon, Feb 27 2023, Miguel Luis wrote: > From: Haibo Xu > > linux-headers define host properties needed for the VMM to interact with > KVM, so let's include them *while* they're not available yet on linux > upstream since aarch64 nested virtualization is still a work in > progress. > > Ref: >

Re: [PATCH v5 2/3] arm/kvm: add support for MTE

2023-02-27 Thread Cornelia Huck
On Wed, Feb 15 2023, Eric Auger wrote: > Hi Richard, > On 2/6/23 19:27, Richard Henderson wrote: >> On 2/6/23 03:32, Eric Auger wrote: +void kvm_arm_enable_mte(Error **errp) +{ +    static bool tried_to_enable = false; +    Error *mte_migration_blocker = NULL; >>> can't you ma

Re: [PATCH v5 2/3] arm/kvm: add support for MTE

2023-02-27 Thread Cornelia Huck
On Mon, Feb 06 2023, Cornelia Huck wrote: > On Mon, Feb 06 2023, Eric Auger wrote: > >> Hi, >> >> On 2/3/23 21:40, Richard Henderson wrote: >>> On 2/3/23 03:44, Cornelia Huck wrote: >>>> +static void aarch64_cpu_get_mte(O

Re: [PATCH v5 3/3] qtests/arm: add some mte tests

2023-02-27 Thread Cornelia Huck
On Fri, Feb 10 2023, Cornelia Huck wrote: > On Mon, Feb 06 2023, Eric Auger wrote: > >> Hi, >> >> On 2/3/23 14:44, Cornelia Huck wrote: >>> +static void mte_tests_default(QTestState *qts, const char *cpu_type) >>> +{ >&

  1   2   3   4   5   6   7   8   9   10   >