Re: [Qemu-devel] [patch] firmware: qemu_fw_cfg.c: potential unintialized variable

2016-04-14 Thread Dan Carpenter
CC optimizes it away. Let me think about this some more... regards, dan carpenter

Re: [Qemu-devel] [patch] firmware: qemu_fw_cfg.c: potential unintialized variable

2016-04-14 Thread Dan Carpenter
On Thu, Apr 14, 2016 at 02:40:06PM -0400, Gabriel L. Somlo wrote: > On Thu, Apr 14, 2016 at 12:33:37PM +0300, Dan Carpenter wrote: > > It acpi_acquire_global_lock() return AE_NOT_CONFIGURED then "glk" isn't > ^ ^ > If

[Qemu-devel] [patch] firmware: qemu_fw_cfg.c: potential unintialized variable

2016-04-14 Thread Dan Carpenter
It acpi_acquire_global_lock() return AE_NOT_CONFIGURED then "glk" isn't initialized, which, if you got very unlucky, could cause a bug. Signed-off-by: Dan Carpenter diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index d999fe3..0e20116 100644 --- a/d

Re: [Qemu-devel] Request VFIO inclusion in linux-next

2012-06-27 Thread Dan Carpenter
On Wed, Jun 27, 2012 at 01:23:23PM -0600, Alex Williamson wrote: > On Wed, 2012-06-27 at 15:37 +0300, Dan Carpenter wrote: > > On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: > > > Hi, > > > > > > VFIO has been kicking around for well over

Re: [Qemu-devel] Request VFIO inclusion in linux-next

2012-06-27 Thread Dan Carpenter
;d like > to request a new branch be included in linux-next with a goal of being > accepted into v3.6. > Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos << 20); regards, dan carpenter