Re: [Qemu-devel] Regression caused by d2f39ad "exec.c: Ensure right alignment also for file backed ram"

> Am 24.10.2016 um 13:44 schrieb Igor Mammedov : > >> >> modified exec.c >> @@ -1254,7 +1254,11 @@ static void *file_ram_alloc(RAMBlock *block, >> } >> >> block->page_size = qemu_fd_getpagesize(fd); >> +#if defined(__x86_64__) || defined(__i386__) >> +

Re: [Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

On Fri, 29 Apr 2016 15:32:22 +0800 Fam Zheng <f...@redhat.com> wrote: > On Mon, 04/25 13:55, Dominik Dingel wrote: > > While in the anonymous ram case we already take care of the right alignment > > such an alignment gurantee does not exist for file backed ram alloca

[Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

-by: Halil Pasic <pa...@linux.vnet.ibm.com> Signed-off-by: Dominik Dingel <din...@linux.vnet.ibm.com> --- v2 -> v3: Skipping additional variable and just use alignment of memory region. As memory will not be backpropagated it is enough to round up to page_sizes. v1 -> v2: While enfor

Re: [Qemu-devel] [PATCH v2] exec.c: Ensure right alignment also for file backed ram

On Tue, 12 Apr 2016 23:45:18 +0200 Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 07/04/2016 23:31, Dominik Dingel wrote: > > diff --git a/exec.c b/exec.c > > index c4f9036..1ae98e4 100644 > > --- a/exec.c > > +++ b/exec.c > > @@ -1241,6 +1

[Qemu-devel] [PATCH v2] exec.c: Ensure right alignment also for file backed ram

-by: Halil Pasic <pa...@linux.vnet.ibm.com> Signed-off-by: Dominik Dingel <din...@linux.vnet.ibm.com> --- v1 -> v2: While enforcing alignments we allow memory sizes on page_size. On mmap the memory size will be round up to alignments. I thought about moving this alignment into qemu_ram_mmap

Re: [Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

On Thu, 24 Mar 2016 12:35:10 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote: > > > On 23/03/2016 22:32, Dominik Dingel wrote: > > -page_size = qemu_fd_getpagesize(fd); > > -block->mr->align = page_size; > > +alignment = MAX(qemu

[Qemu-devel] [PATCH] exec.c: Ensure right alignment also for file backed ram

-by: Halil Pasic <pa...@linux.vnet.ibm.com> Signed-off-by: Dominik Dingel <din...@linux.vnet.ibm.com> --- I thought about moving this alignment into qemu_ram_mmap but the result was a lot of code churn, the other possibility was to create an additional define ending up with two defines w

[Qemu-devel] [PATCH] Enable async page faults

S390 can also use async page faults, to enhance guest scheduling. But in the case of live migration we want to disable the feature and know if there are still notifications in flight. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com --- target-s390x/kvm.c | 42

[Qemu-devel] [PATCH] s390: Async page fault control

Following the current discussion on the kvm ML, here are the qemu bits regarding async page faults. They are responsible for enabling, disabling the feature and adding a savevm handler for live migration. Dominik Dingel (1): Enable async page faults with live migration target-s390x/kvm.c | 42

[Qemu-devel] [PATCH v3 2/4] S390: Add virtio-blk boot

If no kernel IPL entry is specified, boot the bios and pass if available device information for the first boot device (as given by the boot index). The provided information will be used in the next commit from the BIOS. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/hw

[Qemu-devel] [PATCH v3 0/4] Enhance s390 BIOS to enable boot device selection

This patchset allows the s390 platform to boot from a specified virtio-ccw-blk device, passed on the commandline. v2 - v3 - merge function s390_ipl_cpu and s390_ipl_reset - refactor boot logic for device - refactor BIOS code to be more explizit Dominik Dingel (4): S390: Merging s390_ipl_cpu

[Qemu-devel] [PATCH 4/4] S390: Sync Blob with source changes

Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 149cf70140e9e690960b49337b4e5f419c452a86..2c411da9ec0a6dad512c732cb0fd5454a9701ea6 100644 GIT binary patch literal 17528 zcmeHPeN0@}l|SVGklmlJH#FvultBmiqnJ)*hy)!Qpd)oq;hTIxGC

[Qemu-devel] [PATCH v3 1/4] S390: Merging s390_ipl_cpu and s390_ipl_reset

There is no use in have this splitted in two functions. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index cc3cd23..d14c548 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -57,16 +57,6 @@ typedef struct S390IPLState { } S390IPLState

[Qemu-devel] [PATCH 3/4] S390: BIOS boot from given device

Use the passed device, if there is no device, use the first applicable device. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index fd40fa5..be1efe8 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c @@ -12,6

[Qemu-devel] [PATCH v2 3/5] S390: BIOS create link to src folder for .img file

For *.img files, there will be a link created directly to the src folder, like for all other blobs. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/configure b/configure index cb29b69..2ab54ec 100755 --- a/configure +++ b/configure @@ -4389,6 +4389,7 @@ for bios_file

[Qemu-devel] [PATCH v2 2/5] S390: BIOS check for file

Add a check if the BIOS blob exists before trying to load. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index bcbba7c..f7a570e 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -93,6 +93,10 @@ static int s390_ipl_init(SysBusDevice *dev

[Qemu-devel] [PATCH v2 0/5] Enhance s390 BIOS to enable boot device selection

to the first device - assign the boot value in the start block - refactoring of the s390_ipl_cpu function Dominik Dingel (5): S390: Add virtio-blk boot S390: BIOS check for file S390: BIOS create link to src folder for .img file S390: BIOS boot from given device S390: Sync Blob with source

[Qemu-devel] [PATCH v2 1/5] S390: Add virtio-blk boot

Check for a kernel IPL entry and load kernel image if one was specified. If no kernel image was supplied and no boot device was specified or the boot device is not of type virtio-blk-ccw, print an error message and exit. Signed-off-by: Christian Paro cp...@us.ibm.com Signed-off-by: Dominik

[Qemu-devel] [PATCH v2 4/5] S390: BIOS boot from given device

Use the passed device, if there is no device, use the first applicable device. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index fd40fa5..206979f 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c @@ -12,6

[Qemu-devel] [PATCH v2 5/5] S390: Sync Blob with source changes

Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/pc-bios/s390-ccw.img b/pc-bios/s390-ccw.img index 149cf70140e9e690960b49337b4e5f419c452a86..4d2145ecb8d658e3a766272a15e15749afb01705 100644 GIT binary patch literal 17528 zcmeHPe{37qeSbWjL`sGv*SASk2$AUNR`BqDcNbG(c#{QI*bd6h

[Qemu-devel] [PATCH 06/10] s390-ccw.img: Enhance drain_irqs().

From: Cornelia Huck cornelia.h...@de.ibm.com - Use tpi + tsch to get interrupts. - Return an error if the irb indicates problems. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c index 1968fc6..1bd17d4 100644 ---

[Qemu-devel] [PATCH 03/10] S390: Check Bootdevice Type

...@us.ibm.com Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index ace5ff5..9758529 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -16,6 +16,8 @@ #include elf.h #include hw/loader.h #include hw/sysbus.h +#include hw/s390x/virtio-ccw.h

[Qemu-devel] [PATCH 08/10] s390-ccw.img: Get queue config from host.

From: Cornelia Huck cornelia.h...@de.ibm.com Ask the host about the configuration instead of guessing it. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c index e0cede5..5b9e1dc 100644 --- a/pc-bios/s390-ccw/virtio.c +++

[Qemu-devel] [PATCH 04/10] S390: check if BIOS is available and create links

Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com Check if the BIOS is available before loading it into the memory. Create the needed Links for build. Add a if the BIOS is available, also add the needed links for the build process. diff --git a/configure b/configure index 19777de..2bbbd54

[Qemu-devel] [PATCH 09/10] S390: Pass per-device loadparm values for CCW blk and net devs.

From: Christian Paro cp...@us.ibm.com Provide a loadparm property which can be used to pass IPL load parameters on a per-device basis for VirtioCcwDevice instances representing block and network devices. Signed-off-by: Christian Paro cp...@us.ibm.com diff --git a/hw/s390x/virtio-ccw.c

[Qemu-devel] [PATCH 07/10] s390-ccw.img: Rudimentary error checking.

From: Cornelia Huck cornelia.h...@de.ibm.com Try to handle at least some of the errors that may happen. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c index 1bd17d4..e0cede5 100644 --- a/pc-bios/s390-ccw/virtio.c +++

[Qemu-devel] [PATCH 05/10] s390-ccw.img: Detect devices with stsch.

From: Cornelia Huck cornelia.h...@de.ibm.com stsch is the canonical way to detect devices. As a bonus, we can abort the loop if we get cc 3, and we need to check only the valid devices (dnv set). Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com diff --git a/pc-bios/s390-ccw/main.c

[Qemu-devel] [PATCH 10/10] S390: Enabling device and program selection

Pass the eboot device info and the loadparm in register 7 and 8. Use this values in the BIOS to directly boot the respective operating system. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 36daa67..960ba71 100644 --- a/hw/s390x/ipl.c

[Qemu-devel] [PATCH 01/10] Common: Add a default bootindex for all applicable devices

, because we give them the highest available boot index. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/vl.c b/vl.c index 6caa5f4..84d7031 100644 --- a/vl.c +++ b/vl.c @@ -248,7 +248,7 @@ struct FWBootEntry { char *suffix; }; -static QTAILQ_HEAD(, FWBootEntry) fw_boot_order

[Qemu-devel] [PATCH 02/10] Common: Add quick access to first boot device

Instead of manually parsing the boot_list as character stream, we can access the nth boot device, specified by the position in the boot order. Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index 6578782..43b961c 100644

[Qemu-devel] [PATCH 00/10] S390: Enhance s390 BIOS to enable bootdevice selection

devs. Cornelia Huck (4): s390-ccw.img: Detect devices with stsch. s390-ccw.img: Enhance drain_irqs(). s390-ccw.img: Rudimentary error checking. s390-ccw.img: Get queue config from host. Dominik Dingel (5): Common: Add a default bootindex for all applicable devices Common: Add quick

Re: [Qemu-devel] [PATCH 04/10] S390: check if BIOS is available and create links

On Fri, 26 Apr 2013 17:23:18 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 14:12, Dominik Dingel wrote: Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com Check if the BIOS is available before loading it into the memory. Create the needed Links for build. Add

Re: [Qemu-devel] [PATCH 03/10] S390: Check Bootdevice Type

On Fri, 26 Apr 2013 17:22:08 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 14:12, Dominik Dingel wrote: Check for a kernel IPL entry and load kernel image if one was specified. If no kernel image was supplied and the first boot device is not a virtio-ccw-blk device

Re: [Qemu-devel] [PATCH 03/10] S390: Check Bootdevice Type

On Fri, 26 Apr 2013 17:48:37 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 17:42, Christian Borntraeger wrote: On 26/04/13 17:22, Alexander Graf wrote: On 26.04.2013, at 14:12, Dominik Dingel wrote: Check for a kernel IPL entry and load kernel image if one

Re: [Qemu-devel] [PATCH 03/10] S390: Check Bootdevice Type

On Fri, 26 Apr 2013 18:05:02 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 18:01, Christian Borntraeger wrote: On 26/04/13 17:48, Alexander Graf wrote: So I suggest to go with this patch and implement later on what we agree upon? I don't see how having first

Re: [Qemu-devel] [PATCH 04/10] S390: check if BIOS is available and create links

On Fri, 26 Apr 2013 17:57:44 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 17:48, Dominik Dingel wrote: On Fri, 26 Apr 2013 17:23:18 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 14:12, Dominik Dingel wrote: Signed-off-by: Dominik Dingel din

Re: [Qemu-devel] [PATCH 00/10] S390: Enhance s390 BIOS to enable bootdevice selection

On Fri, 26 Apr 2013 18:19:29 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 14:12, Dominik Dingel wrote: Ths patchset enhance the common code to assign every device a bootindex, and provide a function to return the device. The device will be then used in the ipl code

Re: [Qemu-devel] [PATCH 10/10] S390: Enabling device and program selection

On Fri, 26 Apr 2013 18:56:44 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 14:12, Dominik Dingel wrote: Pass the eboot device info and the loadparm in register 7 and 8. Use this values in the BIOS to directly boot the respective operating system. Signed-off

Re: [Qemu-devel] [PATCH 01/10] Common: Add a default bootindex for all applicable devices

On Fri, 26 Apr 2013 11:36:11 -0500 Anthony Liguori anth...@codemonkey.ws wrote: Dominik Dingel din...@linux.vnet.ibm.com writes: Currently only devices with a positive boot index will be pushed in the fw_boot_order queue, so if no boot index at all will be specified, the queue ends up

Re: [Qemu-devel] [PATCH 04/10] S390: check if BIOS is available and create links

On Fri, 26 Apr 2013 11:38:00 -0500 Anthony Liguori anth...@codemonkey.ws wrote: Alexander Graf ag...@suse.de writes: On 26.04.2013, at 17:48, Dominik Dingel wrote: On Fri, 26 Apr 2013 17:23:18 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 14:12, Dominik Dingel

Re: [Qemu-devel] [PATCH 09/10] S390: Pass per-device loadparm values for CCW blk and net devs.

On Fri, 26 Apr 2013 18:52:48 +0200 Alexander Graf ag...@suse.de wrote: On 26.04.2013, at 14:12, Dominik Dingel wrote: From: Christian Paro cp...@us.ibm.com Provide a loadparm property which can be used to pass IPL load parameters on a per-device basis for VirtioCcwDevice instances

Re: [Qemu-devel] [PATCH 01/10] Common: Add a default bootindex for all applicable devices

On Fri, 26 Apr 2013 22:13:14 +0300 Gleb Natapov g...@redhat.com wrote: On Fri, Apr 26, 2013 at 01:55:23PM -0500, Anthony Liguori wrote: Dominik Dingel din...@linux.vnet.ibm.com writes: On Fri, 26 Apr 2013 11:36:11 -0500 Anthony Liguori anth...@codemonkey.ws wrote: Dominik Dingel