Re: [Qemu-devel] [PATCH] exec: Stop using memory after free

2015-12-02 Thread Don Slutz
On 12/01/15 04:52, Paolo Bonzini wrote: > > > On 30/11/2015 23:11, Don Slutz wrote: >> memory_region_unref(mr) can free memory. >> >> For example I got: >> >> Program received signal SIGSEGV, Segmentation fault. >> [Switching to Thread 0x7f43

Re: [Qemu-devel] [PATCH] exec: Stop using memory after free

2015-12-02 Thread Don Slutz
mory_region_unref(mr), the reference count on the mr was still non-zero and so g_free() was not called. >> IMO we should invoke memory_region_unref(mr) after the if check. > > That's also possible. My attempts to do so all failed, maybe coding bugs. At that time I came up with the

[Qemu-devel] [PATCH] exec: Stop using memory after free

2015-11-30 Thread Don Slutz
->subpage) { (gdb) bt at /home/don/xen/tools/qemu-xen-dir/exec.c:1023 at /home/don/xen/tools/qemu-xen-dir/exec.c:1034 at /home/don/xen/tools/qemu-xen-dir/exec.c:2205 (gdb) p mr $1 = (MemoryRegion *) 0x7f43259468b0 And this change prevents this. Signed-off-by: Don Slutz --- exec.c

Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-29 Thread Don Slutz
On 7/5/2015 2:40 AM, Michael S. Tsirkin wrote: On Fri, Jul 03, 2015 at 03:50:19PM +0200, Paolo Bonzini wrote: On 03/07/2015 15:08, Don Slutz wrote: Creating it at the pc level and propagating makes code messy but I'd go along with it if it made sense from user's point of view, but i

Re: [Qemu-devel] [PATCH v8 6/8] vmport_rpc: Add QMP access to vmport_rpc object.

2015-07-03 Thread Don Slutz
On 07/03/15 13:56, Markus Armbruster wrote: Don Slutz writes: On 07/02/15 10:11, Markus Armbruster wrote: Don Slutz writes: From: Don Slutz This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport

Re: [Qemu-devel] [PATCH v8 6/8] vmport_rpc: Add QMP access to vmport_rpc object.

2015-07-03 Thread Don Slutz
On 07/02/15 10:11, Markus Armbruster wrote: Don Slutz writes: From: Don Slutz This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz

Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-07-03 Thread Don Slutz
On 07/01/15 02:50, Michael S. Tsirkin wrote: On Tue, Jun 23, 2015 at 07:39:33PM -0400, Don Slutz wrote: From: Don Slutz This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to

Re: [Qemu-devel] [ping][PATCH v8 0/8] Add limited support of VMware's hyper-call rpc

2015-06-30 Thread Don Slutz
Ping On 06/23/15 19:39, Don Slutz wrote: Changes v7 to v8: Rebase to master Drop patch #1 since commit 965eb2fcdfe919ecced6c34803535ad32dc1249c fixed this. Paolo Bonzini Ok to pull v7 1,2,3, and 9. Added Acked-by: Paolo Bonzini Moved v7 #9 to v8 #3 Eric

[Qemu-devel] [PATCH v8 7/8] vmport_rpc: Add migration

2015-06-23 Thread Don Slutz
From: Don Slutz Signed-off-by: Don Slutz CC: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 2 + 2 files changed, 252 insertions(+) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 917898b..7198e30 100644

[Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack

2015-06-23 Thread Don Slutz
From: Don Slutz This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz CC: Don Slutz --- hw/i386/pc.c

[Qemu-devel] [PATCH v8 5/8] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-06-23 Thread Don Slutz
From: Don Slutz To enable you must add "-device vmport_rpc" to command line. The support included is enough to allow VMware tools to install in a guest and provide guestinfo support. guestinfo support is provided by what is known as VMware RPC support. If the guest is running VM

[Qemu-devel] [PATCH v8 4/8] vmport_rpc: Add the object vmport_rpc

2015-06-23 Thread Don Slutz
From: Don Slutz This is the 1st part of "Add limited support of VMware's hyper-call rpc". This patch uses existing infrastructure used by vmmouse.c (provided by vmport.c) to handle the VMware backdoor command 30. One of the better on-line references is: https://sites.

[Qemu-devel] [PATCH v8 3/8] MAINTAINERS: add VMware port

2015-06-23 Thread Don Slutz
From: Don Slutz Signed-off-by: Don Slutz CC: Don Slutz Acked-by: Paolo Bonzini --- v8: Added Acked-by: Paolo Bonzini v7: Switched e-mail address in MAINTAINERS. MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3639173..1872a9c

[Qemu-devel] [PATCH v8 1/8] vmport: Switch to trace

2015-06-23 Thread Don Slutz
From: Don Slutz Signed-off-by: Don Slutz CC: Don Slutz Acked-by: Paolo Bonzini --- v8: Added Acked-by: Paolo Bonzini hw/misc/vmport.c | 6 ++ trace-events | 3 +++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d

[Qemu-devel] [PATCH v8 0/8] Add limited support of VMware's hyper-call rpc

2015-06-23 Thread Don Slutz
guestinfo.joejoel bar" [root@C63-min-tools ~]# vmtoolsd --cmd "info-get guestinfo.joejoel" bar [root@C63-min-tools ~]# ----------- to access guest info. QMP access is also provided. The live migration code is still in progress. Don Slutz (8): vmport: Switch to trace

[Qemu-devel] [BUGFIX][PATCH v8 2/8] vmport: Fix vmport_cmd_ram_size

2015-06-23 Thread Don Slutz
From: Don Slutz Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz CC: Don Slutz Acked-by: Paolo Bonzini --- v8: Added Acked-by: Paolo Bonzini hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion

Re: [Qemu-devel] [PATCH 0/2] exec: fixes for access clamping

2015-06-18 Thread Don Slutz
015 10:05:48 -0400 Message-Id: <1434117956-4929-2-git-send-email-dsl...@verizon.com> So as long as this change goes in, the patch "vmport: The io memory region" will be dropped. -Don Slutz > Paolo > > Paolo Bonzini (2): > exec: do not clamp accesses to MMIO regions

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-18 Thread Don Slutz
On 06/17/15 14:58, Michael S. Tsirkin wrote: > On Wed, Jun 17, 2015 at 01:34:33PM -0400, Don Slutz wrote: >> On 06/17/15 13:25, Paolo Bonzini wrote: >>> >>> >>> On 17/06/2015 19:14, Paolo Bonzini wrote: >>>> >>>> >>>>

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Don Slutz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/17/15 09:44, Paolo Bonzini wrote: > > On 12/06/2015 16:05, Don Slutz wrote: >> Changes v6 to v7: ... > Looks good, feel free to send out patches 1+2+3+9 in a pull request if > you want. If I am reading this correctly, I sh

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Don Slutz
On 06/17/15 13:25, Paolo Bonzini wrote: > > > On 17/06/2015 19:14, Paolo Bonzini wrote: >> >> >> On 17/06/2015 19:03, Don Slutz wrote: >>> On 06/17/15 12:29, Michael S. Tsirkin wrote: >>>> On Wed, Jun 17, 2015 at 06:17:19PM +0200, Paolo Bonz

Re: [Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-17 Thread Don Slutz
device is also enabled by default. >>> >>> This is historical, isn't it? >> >> Yes, but it has broken 2.3->2.2 migration. >> >> Let's just stop fighting windmills. >> >> Paolo > > I don't see what you are saying. Suddenly guest visible > changes within a machine type are ok? > > So we have a bug, need to fix it, preferably before piling up > more features. The best way imho is for 2.4 to avoid > this device unless requested explicitly. > My take on this is that Michael would like me to have a vmport_rpc=on option, just like vmport=on (which already exists). With a default of off. I have no problem adding it. -Don Slutz

Re: [Qemu-devel] [PATCH v7 6/9] vmport_rpc: Add QMP access to vmport_rpc object.

2015-06-17 Thread Don Slutz
On 06/15/15 11:53, Eric Blake wrote: > On 06/12/2015 08:05 AM, Don Slutz wrote: >> This adds one new inject command: >> >> inject-vmport-action >> >> And three guest info commands: >> >> vmport-guestinfo-set >> vmport-guestinfo-get >> que

Re: [Qemu-devel] [BUGFIX][PATCH v7 1/9] vmport: The io memory region needs to be at least a size of 4

2015-06-15 Thread Don Slutz
On 06/15/15 11:09, Eric Blake wrote: > On 06/15/2015 07:53 AM, Don Slutz wrote: >> On 06/12/15 18:38, Eric Blake wrote: > >>>> >>>> +/* Only support 1 address */ >>>> +if (addr) { >>>> +return ~0U; >>>

Re: [Qemu-devel] [BUGFIX][PATCH v7 1/9] vmport: The io memory region needs to be at least a size of 4

2015-06-15 Thread Don Slutz
On 06/12/15 18:38, Eric Blake wrote: > On 06/12/2015 08:05 AM, Don Slutz wrote: >> Before: >> >> commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 >> Author: Peter Crosthwaite >> Date: Mon Mar 16 22:35:54 2015 -0700 >> >> exec: Respect as_tra

[Qemu-devel] [PATCH v7 9/9] MAINTAINERS: add VMware port

2015-06-12 Thread Don Slutz
From: Don Slutz Signed-off-by: Don Slutz CC: Don Slutz --- v7: Switched e-mail address in MAINTAINERS. MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e728d3a..5155128 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -767,6 +767,13 @@ M

[Qemu-devel] [PATCH v7 5/9] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-06-12 Thread Don Slutz
Signed-off-by: Don Slutz CC: Don Slutz --- hw/misc/vmport_rpc.c | 796 ++- trace-events | 22 ++ 2 files changed, 817 insertions(+), 1 deletion(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index b7cd355..e2d5c36 100644 --- a/

[Qemu-devel] [PATCH v7 6/9] vmport_rpc: Add QMP access to vmport_rpc object.

2015-06-12 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz CC: Don Slutz --- v7: Delay call on g_strndup till after key length check

[Qemu-devel] [PATCH v7 8/9] vmport: Add VMware all ring hack

2015-06-12 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz CC: Don Slutz --- hw/i386/pc.c | 26

[Qemu-devel] [BUGFIX][PATCH v7 3/9] vmport: Fix vmport_cmd_ram_size

2015-06-12 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz CC: Don Slutz --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index

[Qemu-devel] [PATCH v7 4/9] vmport_rpc: Add the object vmport_rpc

2015-06-12 Thread Don Slutz
vmback/backdoor More in next patch. Signed-off-by: Don Slutz CC: Don Slutz --- hw/i386/pc.c | 6 +++ hw/misc/Makefile.objs | 1 + hw/misc/vmport_rpc.c | 126 ++ 3 files changed, 133 insertions(+) create mode 100644 hw/misc/vmport_rpc.

[Qemu-devel] [PATCH v7 7/9] vmport_rpc: Add migration

2015-06-12 Thread Don Slutz
Signed-off-by: Don Slutz CC: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 2 + 2 files changed, 252 insertions(+) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index e122bad..4984193 100644 --- a/hw/misc

[Qemu-devel] [BUGFIX][PATCH v7 1/9] vmport: The io memory region needs to be at least a size of 4

2015-06-12 Thread Don Slutz
Before: commit c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 Author: Peter Crosthwaite Date: Mon Mar 16 22:35:54 2015 -0700 exec: Respect as_tranlsate_internal length clamp it did not matter. Only accept I/O that starts on 1st port. Signed-off-by: Don Slutz CC: Don Slutz --- hw/misc

[Qemu-devel] [PATCH v7 2/9] vmport: Switch to trace

2015-06-12 Thread Don Slutz
Signed-off-by: Don Slutz CC: Don Slutz --- hw/misc/vmport.c | 7 +++ trace-events | 4 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 51b64bc..203e892 100644 --- a/hw/misc/vmport.c +++ b/hw/misc/vmport.c @@ -27,7 +27,7

[Qemu-devel] [PATCH v7 0/9] Add limited support of VMware's hyper-call rpc

2015-06-12 Thread Don Slutz
ls ~]# vmtoolsd --cmd "info-set guestinfo.joejoel bar" [root@C63-min-tools ~]# vmtoolsd --cmd "info-get guestinfo.joejoel" bar [root@C63-min-tools ~]# --- to access guest info. QMP access is also provided

Re: [Qemu-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-09 Thread Don Slutz
On 06/09/15 11:11, Paul Durrant wrote: >> -Original Message- >> From: Don Slutz [mailto:dsl...@verizon.com] >> Sent: 09 June 2015 15:28 >> To: Paul Durrant; Slutz, Donald Christopher; qemu-devel@nongnu.org; xen- >> de...@lists.xen.org >> Cc: Michael

[Qemu-devel] [Bug 1463463] Re: PCI devices on PCI to PCI bridges stopped being accessable from Xen with QEMU 2.3.0

2015-06-09 Thread Don Slutz
** Attachment added: "This is the Xen config file used" https://bugs.launchpad.net/qemu/+bug/1463463/+attachment/4412144/+files/C63-min-tools.bridge3.xfg -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/b

[Qemu-devel] [Bug 1463463] Re: PCI devices on PCI to PCI bridges stopped being accessable from Xen with QEMU 2.3.0

2015-06-09 Thread Don Slutz
Since Xen's tool stack does not know about PCI to PCI bridges, a config that shows this issue also requires the correct Linux kernel argument "pci=assign-busses" is used. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.la

[Qemu-devel] [Bug 1463463] [NEW] PCI devices on PCI to PCI bridges stopped being accessable from Xen with QEMU 2.3.0

2015-06-09 Thread Don Slutz
Public bug reported: The change set: commit 3996e85c1822e05c50250f8d2d1e57b6bea1229d Author: Paul Durrant Date: Tue Jan 20 11:06:19 2015 + Xen: Use the ioreq-server API when available ... Added calls to xen_map_pcidev() when available. However these call are only done at startup, n

Re: [Qemu-devel] [PATCH v2 0/4] Fix device listener interface for PCI to PCI bridges

2015-06-09 Thread Don Slutz
On 06/09/15 10:27, Michael S. Tsirkin wrote: > On Tue, Jun 09, 2015 at 02:14:29PM +, Paul Durrant wrote: >>> -Original Message- >>> From: Michael S. Tsirkin [mailto:m...@redhat.com] >>> Sent: 09 June 2015 13:30 >>> To: Paul Durrant >>&

Re: [Qemu-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-09 Thread Don Slutz
On 06/09/15 10:03, Paul Durrant wrote: >> -Original Message- >> From: Don Slutz [mailto:dsl...@verizon.com] >> Sent: 09 June 2015 14:51 >> To: Paul Durrant; Slutz, Donald Christopher; qemu-devel@nongnu.org; xen- >> de...@lists.xen.org >> Cc: Michael

Re: [Qemu-devel] [PATCH v2 2/4] Extend device listener interface for PCI to PCI bridges

2015-06-09 Thread Don Slutz
On 06/09/15 09:55, Paul Durrant wrote: >> -Original Message- >> From: Don Slutz [mailto:dsl...@verizon.com] >> Sent: 09 June 2015 14:53 >> To: Paul Durrant; Slutz, Donald Christopher; qemu-devel@nongnu.org; xen- >> de...@lists.xen.org >> Cc: Michael

Re: [Qemu-devel] [PATCH v2 2/4] Extend device listener interface for PCI to PCI bridges

2015-06-09 Thread Don Slutz
On 06/09/15 05:08, Paul Durrant wrote: >> -Original Message- >> From: Don Slutz [mailto:dsl...@verizon.com] >> Sent: 08 June 2015 22:19 >> To: qemu-devel@nongnu.org; xen-de...@lists.xen.org >> Cc: Michael S. Tsirkin; Paul Durrant; Stefano Stabellini; Don S

Re: [Qemu-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-09 Thread Don Slutz
On 06/09/15 05:05, Paul Durrant wrote: >> -Original Message- >> From: Don Slutz [mailto:dsl...@verizon.com] >> Sent: 08 June 2015 22:19 >> To: qemu-devel@nongnu.org; xen-de...@lists.xen.org >> Cc: Michael S. Tsirkin; Paul Durrant; Stefano Stabellini; Don S

[Qemu-devel] [PATCH v2 4/4] xen: Fix map/unmap of pcidev to ioreq server

2015-06-08 Thread Don Slutz
idev id: 1 bdf: 00:04.0 xen_map_pcidev id: 1 bdf: 03:04.0 Signed-off-by: Don Slutz CC: Don Slutz --- include/hw/xen/xen_common.h | 53 +++-- trace-events| 6 +++-- xen-hvm.c | 15 - 3 files changed, 55 inserti

[Qemu-devel] [PATCH v2 2/4] Extend device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
listener interface to be called when ever the secondary bus number is set to a new value. This new interface is called for all PCI devices that are on the secondary bridge. Signed-off-by: Don Slutz CC: Don Slutz --- hw/core/qdev.c | 7 +++ hw/pci/pci_bridge.c| 18

[Qemu-devel] [PATCH v2 3/4] xen: Add usage of device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
Signed-off-by: Don Slutz CC: Don Slutz --- include/hw/xen/xen_common.h | 10 ++ xen-hvm.c | 13 - 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/include/hw/xen/xen_common.h b/include/hw/xen/xen_common.h index 38f29fb..6579b78 100644 --- a

[Qemu-devel] [PATCH v2 0/4] Fix device listener interface for PCI to PCI bridges

2015-06-08 Thread Don Slutz
55, and 0 is not very special either (except it happens to be the reset value)." Dropped all checking of 0 and 255. Open question by Michael S. Tsirkin: >>>> On Thu, May 28, 2015 at 07:25:50AM -0400, Don Slutz wrote: ... >>>> It is not clear to me that the c

[Qemu-devel] [BUGFIX][PATCH v2 1/4] exec: Do not use MemoryRegion after free

2015-06-08 Thread Don Slutz
2 962 if (mr->subpage) { (gdb) p mr $10 = (MemoryRegion *) 0x7fdf32a168b0 (gdb) p *mr Cannot access memory at address 0x7fdf32a168b0 Signed-off-by: Don Slutz CC: Don Slutz --- exec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c inde

[Qemu-devel] [Bug 1462131] Re: qemu mainline regression with xen-unstable: unable to start QMP

2015-06-08 Thread Don Slutz
Fixed in: commit 779cec4d20907cbccb26fbf5f5c19c6cdee33eff Author: Markus Armbruster Date: Mon Jun 8 10:44:30 2015 +0200 monitor: Fix QMP ABI breakage around "id" ** Changed in: qemu Status: Confirmed => Fix Released -- You received this bug notification because you are a membe

[Qemu-devel] [Bug 1462131] Re: qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
Subject: Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP Date: Thu, 04 Jun 2015 16:10:34 -0600 From: Eric Blake Organization: Red Hat, Inc. To: Don Slutz , Fabio Fantoni , qemu-devel@nongnu.org , xen-devel , Stefano Stabellini , Anthony PERARD

Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/04/15 18:10, Eric Blake wrote: > [adding Markus, as author of the regression] > > On 06/04/2015 03:59 PM, Don Slutz wrote: >> On 06/04/15 11:04, Fabio Fantoni wrote: >>> Today after trying xen-unstable build (tested many

[Qemu-devel] [Bug 1462131] [NEW] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
Public bug reported: On 06/04/15 11:04, Fabio Fantoni wrote: > Today after trying xen-unstable build (tested many hours) of some days > ago I tried update qemu to latest development version (from git master > commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b) and seems that there is > a regression:

Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
On 06/04/15 17:59, Don Slutz wrote: > On 06/04/15 11:04, Fabio Fantoni wrote: >> Today after trying xen-unstable build (tested many hours) of some days >> ago I tried update qemu to latest development version (from git master >> commit 6fa6b312765f698dc81b2c30e7eeb9683804a05b)

Re: [Qemu-devel] [Xen-devel] qemu mainline regression with xen-unstable: unable to start QMP

2015-06-04 Thread Don Slutz
not (for example > save/restore). > > Thanks for any reply and sorry for my bad english. > The patch: >From 1b0221078353870fe530e49de158cae205f9bce5 Mon Sep 17 00:00:00 2001 From: Don Slutz Date: Thu, 4 Jun 2015 17:04:42 -0400 Subject: [PATCH 01/14]

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Add .dir-locals.el file to configure emacs coding style

2015-06-04 Thread Don Slutz
gt; (indent-tabs-mode . nil > > Yes, that is fine too. > I got this from someone on the list, see https://wiki.linaro.org/PeterMaydell/QemuEmacsStyle Which then allows me to do: ((c-mode . ((c-file-style . "qemu" in .dir-locals.el But this is not a good general change :( But I would like at least the the stroustrup version. -Don Slutz > Regards, > Daniel >

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Add .dir-locals.el file to configure emacs coding style

2015-06-04 Thread Don Slutz
gt; (indent-tabs-mode . nil > > Yes, that is fine too. > I got this from someone on the list, see https://wiki.linaro.org/PeterMaydell/QemuEmacsStyle Which then allows me to do: ((c-mode . ((c-file-style . "qemu" in .dir-locals.el But this is not a good general change :( But I would like at least the the stroustrup version. -Don Slutz > Regards, > Daniel >

Re: [Qemu-devel] [PATCH 1/1] Fix device listener interface for PCI to PCI bridges

2015-05-29 Thread Don Slutz
On 05/28/15 17:05, Michael S. Tsirkin wrote: > On Thu, May 28, 2015 at 11:03:07PM +0200, Michael S. Tsirkin wrote: >> On Thu, May 28, 2015 at 03:09:48PM -0400, Don Slutz wrote: >>> On 05/28/15 08:28, Michael S. Tsirkin wrote: >>>> On Thu, May 28, 2015 at 07:25:50AM -0

Re: [Qemu-devel] [PATCH 1/1] Fix device listener interface for PCI to PCI bridges

2015-05-28 Thread Don Slutz
On 05/28/15 08:28, Michael S. Tsirkin wrote: On Thu, May 28, 2015 at 07:25:50AM -0400, Don Slutz wrote: On 05/28/15 05:30, Michael S. Tsirkin wrote: On Thu, May 28, 2015 at 04:46:37AM -0400, Don Slutz wrote: The commit 707ff80021ccd7a68f4b3d2c44eebf87efbb41c4 assumed that a PCI device has a

Re: [Qemu-devel] [PATCH 1/1] Fix device listener interface for PCI to PCI bridges

2015-05-28 Thread Don Slutz
On 05/28/15 05:30, Michael S. Tsirkin wrote: > On Thu, May 28, 2015 at 04:46:37AM -0400, Don Slutz wrote: >> The commit 707ff80021ccd7a68f4b3d2c44eebf87efbb41c4 assumed that a >> PCI device has a static address. This is not true for PCI devices >> that are on the secondar

[Qemu-devel] [PATCH 1/1] Fix device listener interface for PCI to PCI bridges

2015-05-28 Thread Don Slutz
secondary bus numbers 0 and 255. Extend the device listener interface to be called when ever the secondary bus number is set to a usable value. This includes a call on unrealize if the secondary bus number was valid. Signed-off-by: Don Slutz --- Note: Right now hvmloader in Xen does not handle PCI to

[Qemu-devel] Ping [PATCH 1/1] xen-hvm: Add trace to ioreq

2015-05-13 Thread Don Slutz
On 04/30/15 14:27, Don Slutz wrote: > Signed-off-by: Don Slutz > (cherry picked from commit b72adbe7510d0a30053d32334665ee887bec9e43) > --- > trace-events | 7 +++ > xen-hvm.c| 21 + > 2 files changed, 28 insertions(+) > > diff --git a/tra

Re: [Qemu-devel] [PATCH v6 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Don Slutz
On 05/12/15 15:50, Eric Blake wrote: > On 05/12/2015 01:03 PM, Don Slutz wrote: >> This adds one new inject command: >> >> inject-vmport-action >> >> And three guest info commands: >> >> vmport-guestinfo-set >> vmport-guestinfo-get >> quer

[Qemu-devel] [PATCH v6 5/7] vmport_rpc: Add migration

2015-05-12 Thread Don Slutz
Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 8 +- 2 files changed, 255 insertions(+), 3 deletions(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 9a32c6f..fe9cfc5 100644 --- a/hw/misc

[Qemu-devel] [PATCH v6 6/7] vmport: Add VMware all ring hack

2015-05-12 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz (cherry picked from commit

[Qemu-devel] [PATCH v6 7/7] MAINTAINERS: add VMware port

2015-05-12 Thread Don Slutz
Signed-off-by: Don Slutz --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3552b2..6945d30d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -766,6 +766,13 @@ M: Jiri Pirko S: Maintained F: hw/net/rocker/ +VMware port +M: Don Slutz +S

[Qemu-devel] [PATCH v6 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 268

[Qemu-devel] [PATCH v6 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-05-12 Thread Don Slutz
ta. Currently there are 2 protocols defined for VMware RPC. They determine the direction for data flow, guest to tool stack or tool stack to guest. There is no provided interrupt for VMware RPC. Getting VMPORT_RPC_DEBUG will provide a higher level trace calls that are simpler to understand.

[Qemu-devel] [PATCH v6 0/7] Add limited support of VMware's hyper-call rpc

2015-05-12 Thread Don Slutz
uot;info-set guestinfo.joejoel bar" [root@C63-min-tools ~]# vmtoolsd --cmd "info-get guestinfo.joejoel" bar [root@C63-min-tools ~]# --- to access guest info. QMP access is also provided. The liv

[Qemu-devel] [PATCH v6 2/7] vmport_rpc: Add the object vmport_rpc

2015-05-12 Thread Don Slutz
vmback/backdoor More in next patch. Signed-off-by: Don Slutz --- hw/i386/pc.c | 6 +++ hw/misc/Makefile.objs | 1 + hw/misc/vmport_rpc.c | 126 ++ 3 files changed, 133 insertions(+) create mode 100644 hw/misc/vmport_rpc.c diff --git a

[Qemu-devel] [PATCH v6 1/7] vmport.c: Fix vmport_cmd_ram_size

2015-05-12 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d..6b350ce

Re: [Qemu-devel] [PATCH v5 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Don Slutz
On 05/05/15 09:02, Eric Blake wrote: > On 04/30/2015 12:20 PM, Don Slutz wrote: >> This adds one new inject command: >> >> inject-vmport-action >> >> And three guest info commands: >> >> vmport-guestinfo-set >> vmport-guestinfo-get >> que

Re: [Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Don Slutz
On 04/30/15 16:15, Kevin Wolf wrote: > Am 30.04.2015 um 21:15 hat Eric Blake geschrieben: >> [adding qemu-block] >> >> On 04/30/2015 12:23 PM, Don Slutz wrote: >>> ~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head >>> QEMU emulator version

[Qemu-devel] [PATCH 1/1] xen-hvm: Add trace to ioreq

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz (cherry picked from commit b72adbe7510d0a30053d32334665ee887bec9e43) --- trace-events | 7 +++ xen-hvm.c| 21 + 2 files changed, 28 insertions(+) diff --git a/trace-events b/trace-events index 30eba92..4666dad 100644 --- a/trace-events +++ b

[Qemu-devel] [PATCH 1/1] vl.c: Since the help says that 'disk_image' is a raw hard disk image, pass format=raw

2015-04-30 Thread Don Slutz
~/qemu/out/master/x86_64-softmmu/qemu-system-x86_64 -h | head QEMU emulator version 2.3.50, Copyright (c) 2003-2008 Fabrice Bellard usage: qemu-system-x86_64 [options] [disk_image] 'disk_image' is a raw hard disk image for IDE hard disk 0 Standard options: ... Signed-off-by:

[Qemu-devel] [PATCH v5 7/7] MAINTAINERS: add VMware port

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b5ab755..4bbda42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -755,6 +755,13 @@ S: Maintained F: hw/net/vmxnet* F: hw/scsi/vmw_pvscsi* +VMware port +M: Don

[Qemu-devel] [PATCH v5 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
ta. Currently there are 2 protocols defined for VMware RPC. They determine the direction for data flow, guest to tool stack or tool stack to guest. There is no provided interrupt for VMware RPC. Getting VMPORT_RPC_DEBUG will provide a higher level trace calls that are simpler to understand.

[Qemu-devel] [PATCH v5 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 265

[Qemu-devel] [PATCH v5 5/7] vmport_rpc: Add migration

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 8 +- 2 files changed, 255 insertions(+), 3 deletions(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 2403f52..caa82ef 100644 --- a/hw/misc

[Qemu-devel] [PATCH v5 2/7] vmport_rpc: Add the object vmport_rpc

2015-04-30 Thread Don Slutz
vmback/backdoor More in next patch. Signed-off-by: Don Slutz --- hw/i386/pc.c | 6 +++ hw/misc/Makefile.objs | 1 + hw/misc/vmport_rpc.c | 126 ++ 3 files changed, 133 insertions(+) create mode 100644 hw/misc/vmport_rpc.c diff --git a

[Qemu-devel] [PATCH v5 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz (cherry picked from commit

[Qemu-devel] [PATCH v5 1/7] vmport.c: Fix vmport_cmd_ram_size

2015-04-30 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d..6b350ce

[Qemu-devel] [PATCH v5 0/7] Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
" No value found [root@C63-min-tools ~]# vmtoolsd --cmd "info-set guestinfo.joejoel bar" [root@C63-min-tools ~]# vmtoolsd --cmd "info-get guestinfo.joejoel" bar [root@C63-min-tools ~]# --- to access guest inf

Re: [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
On 04/30/15 11:23, Paolo Bonzini wrote: > > > On 30/04/2015 17:15, Don Slutz wrote: >> That is a possibility. It did not look simple to access CPUX86State >> where I needed to check HF2_VMPORT_HACK_MASK. Instead of the >> save/restore I could add it both

Re: [Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Don Slutz
On 04/30/15 09:55, Paolo Bonzini wrote: > > > On 30/04/2015 15:32, Don Slutz wrote: >> +#ifdef VMPORT_SHORT >> +info->value->key = g_strdup(ckey); >> +#else >> +info->value->key = g_strdup_printf("guestinfo.%s", ckey); >> +#

Re: [Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
On 04/30/15 09:54, Paolo Bonzini wrote: > On 30/04/2015 15:32, Don Slutz wrote: >> This is done by adding a new machine property vmware-port-ring3 that >> needs to be enabled to have any effect. It only effects accel=tcg >> mode. It is needed if you want to use VMware tools

[Qemu-devel] [PATCH v4 7/7] MAINTAINERS: add VMware port

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b5ab755..4bbda42 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -755,6 +755,13 @@ S: Maintained F: hw/net/vmxnet* F: hw/scsi/vmw_pvscsi* +VMware port +M: Don

[Qemu-devel] [PATCH v4 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
ta. Currently there are 2 protocols defined for VMware RPC. They determine the direction for data flow, guest to tool stack or tool stack to guest. There is no provided interrupt for VMware RPC. Getting VMPORT_RPC_DEBUG will provide a higher level trace calls that are simpler to understand.

[Qemu-devel] [PATCH v4 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-30 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 269

[Qemu-devel] [PATCH v4 5/7] vmport_rpc: Add migration

2015-04-30 Thread Don Slutz
Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 8 +- 2 files changed, 255 insertions(+), 3 deletions(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 0ba3319..a147561 100644 --- a/hw/misc

[Qemu-devel] [PATCH v4 0/7] Add limited support of VMware's hyper-call rpc

2015-04-30 Thread Don Slutz
in-tools ~]# vmtoolsd --cmd "info-get guestinfo.joejoel" bar [root@C63-min-tools ~]# --- to access guest info. QMP access is also provided. The live migration code is still in progress. Don Slutz (7): vmport.c: Fix vmport_cmd_ram_size vmport_rpc: Add the object vmport_rpc vmport_rpc:

[Qemu-devel] [PATCH v4 6/7] vmport: Add VMware all ring hack

2015-04-30 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz (cherry picked from commit

[Qemu-devel] [PATCH v4 1/7] vmport.c: Fix vmport_cmd_ram_size

2015-04-30 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index 7fcc00d..6b350ce

[Qemu-devel] [PATCH v4 2/7] vmport_rpc: Add the object vmport_rpc

2015-04-30 Thread Don Slutz
vmback/backdoor More in next patch. Signed-off-by: Don Slutz --- hw/i386/pc.c | 6 +++ hw/misc/Makefile.objs | 1 + hw/misc/vmport_rpc.c | 126 ++ 3 files changed, 133 insertions(+) create mode 100644 hw/misc/vmport_rpc.c diff --git a

Re: [Qemu-devel] [PATCH v2 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-28 Thread Don Slutz
On 04/28/15 04:13, Paolo Bonzini wrote: > > > On 28/04/2015 00:46, Don Slutz wrote: >> This adds one new inject command: >> >> inject-vmport-action >> >> And three guest info commands: >> >> vmport-guestinfo-set >> vmport-guestinf

Re: [Qemu-devel] [PATCH v2 0/7] Add limited support of VMware's hyper-call rpc

2015-04-27 Thread Don Slutz
On 04/27/15 18:45, Don Slutz wrote: > Changes v2 to v3: > > s/2.3/2.4 > Opps, forgot to change all the subjects. Can re-send if requested. -Don Slutz > Changes v1 to v2: >

[Qemu-devel] [PATCH v2 6/7] vmport: Add VMware all ring hack

2015-04-27 Thread Don Slutz
This is done by adding a new machine property vmware-port-ring3 that needs to be enabled to have any effect. It only effects accel=tcg mode. It is needed if you want to use VMware tools in accel=tcg mode. Signed-off-by: Don Slutz (cherry picked from commit

[Qemu-devel] [PATCH v2 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-04-27 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz --- hw/misc/vmport_rpc.c | 269

[Qemu-devel] [PATCH v2 2/7] vmport_rpc: Add the object vmport_rpc

2015-04-27 Thread Don Slutz
vmback/backdoor More in next patch. Signed-off-by: Don Slutz --- hw/i386/pc.c | 6 +++ hw/misc/Makefile.objs | 1 + hw/misc/vmport_rpc.c | 126 ++ 3 files changed, 133 insertions(+) create mode 100644 hw/misc/vmport_rpc.c diff --git a

[Qemu-devel] [PATCH v2 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-04-27 Thread Don Slutz
ta. Currently there are 2 protocols defined for VMware RPC. They determine the direction for data flow, guest to tool stack or tool stack to guest. There is no provided interrupt for VMware RPC. Getting VMPORT_RPC_DEBUG will provide a higher level trace calls that are simpler to understand.

[Qemu-devel] [PATCH v2 0/7] Add limited support of VMware's hyper-call rpc

2015-04-27 Thread Don Slutz
toolsd --cmd "info-set guestinfo.joejoel bar" [root@C63-min-tools ~]# vmtoolsd --cmd "info-get guestinfo.joejoel" bar [root@C63-min-tools ~]# --- to access guest info. QMP access is also provided

  1   2   3   4   5   6   >